r262201 - [X86] Disabling avx512f should also disable avx512vbmi and avx512ifma. Enabling avx512vbmi or avx512ifma should enable avx512f. Add command line switches and header defines for avx512ifma an

Author: ctopper Date: Mon Feb 29 00:51:38 2016 New Revision: 262201 URL: http://llvm.org/viewvc/llvm-project?rev=262201=rev Log: [X86] Disabling avx512f should also disable avx512vbmi and avx512ifma. Enabling avx512vbmi or avx512ifma should enable avx512f. Add command line switches and header

r262200 - [X86] Enabling xsave should not enable AVX. I seem to have done this, but I don't know why.

Author: ctopper Date: Mon Feb 29 00:51:34 2016 New Revision: 262200 URL: http://llvm.org/viewvc/llvm-project?rev=262200=rev Log: [X86] Enabling xsave should not enable AVX. I seem to have done this, but I don't know why. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified:

r262199 - [OPENMP 4.5] Initial support for data members in 'reduction' clauses.

Author: abataev Date: Sun Feb 28 23:54:20 2016 New Revision: 262199 URL: http://llvm.org/viewvc/llvm-project?rev=262199=rev Log: [OPENMP 4.5] Initial support for data members in 'reduction' clauses. OpenMP 4.5 allows to privatize non-static data members of current class in non-static member

Re: [PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

tonyarnold added a comment. Aside from the lack of tests, and `AllowNewlineBeforeBlockParameter` being outside of `BraceWrapping`, this is good! Much closer to how Apple's documentation and Xcode format blocks!  Comment at: include/clang/Format/Format.h:421 @@ +420,3 @@ +

Re: [PATCH] D15591: [Bugfix] Make type deduction work more nicely with unaddressable functions

george.burgess.iv updated this revision to Diff 49337. george.burgess.iv added a comment. - Rebased - Added tests for template type inference - Updated to use machinery introduced by http://reviews.llvm.org/D17701 http://reviews.llvm.org/D15591 Files: lib/Sema/SemaTemplateDeduction.cpp

Re: [PATCH] D13704: [Fix] Allow implicit conversions of the address of overloadable functions in C + docs update

george.burgess.iv updated this revision to Diff 49333. george.burgess.iv added a comment. Rebased, and narrowed the scope of the patch a bit. http://reviews.llvm.org/D13704 Files: include/clang/Basic/AttrDocs.td lib/Sema/SemaOverload.cpp test/CodeGen/overloadable.c

r262197 - [clang-cl] /EHc should not have an effect on /EHa

Author: majnemer Date: Sun Feb 28 19:40:30 2016 New Revision: 262197 URL: http://llvm.org/viewvc/llvm-project?rev=262197=rev Log: [clang-cl] /EHc should not have an effect on /EHa This matches behavior with MSVC. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/cl-eh.cpp

r262198 - [clang-cl] /EHc should not effect functions with explicit exception specifications

Author: majnemer Date: Sun Feb 28 19:40:36 2016 New Revision: 262198 URL: http://llvm.org/viewvc/llvm-project?rev=262198=rev Log: [clang-cl] /EHc should not effect functions with explicit exception specifications Functions with an explicit exception specification have their behavior dictated by

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther created this revision. ksuther added a reviewer: djasper. ksuther added a subscriber: cfe-commits. Herald added a subscriber: klimek. Changes to clang-format's Objective-C block formatting over the past year have made clang-format's output deviate from what is expected (in my opinion).

Re: [PATCH] D9237: Update block formatting to behave like Xcode

tonyarnold added a comment. @djasper so was the decision here to not merge these options? I think it's fair that you require a documented style guide somewhere (which Apple don't currently publish), however it would be good to at least have generic options in clang-format that allow us to

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4002 @@ +4001,3 @@ +static llvm::Value * +emitNumTeamsClauseForTargetDirective(CodeGenFunction , + const OMPExecutableDirective , ABataev wrote: > I

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

sfantao updated this revision to Diff 49331. sfantao marked an inline comment as done. sfantao added a comment. Emit num teams and thread limit using the inlined directives machinery. http://reviews.llvm.org/D17019 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

ksuther added a comment. This patch got buried, giving it a bump to see if anyone can take a look at it. http://reviews.llvm.org/D15643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r261774 - Bail on compilation as soon as a job fails.

On Sun, Feb 28, 2016 at 1:46 PM, Nico Weber wrote: > Do you think something like the implicit inputs thing in > http://reviews.llvm.org/D17695 could work for you as well, instead of this > patch? Having read just the patch description, I think it would be workable, although

Re: [PATCH] D17637: [PPC64][VSX] Add short, char, and bool data type for vec_vsx_ld and vec_vsx_st intrinsics

kbarton added a comment. This failed testing: Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 1 warning(s) in tests. Testing Time: 225.81s Failing Tests (1): Clang :: CodeGen/builtins-ppc-vsx.c Expected Passes: 25406

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio added a comment. //(This is mostly for my own reference)// BTW, there are a few other non-MS-only functions in the C standard library that allocate memory that needs to be free()d: 1. getcwd (and _getcwd/_wgetcwd) And some MS-specific functions that I'm surprised are actually MS-only:

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio updated this revision to Diff 49330. ariccio added a comment. Changed underscore prefixed variable names to `win` prefixed variable names. http://reviews.llvm.org/D17688 Files: llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp Index:

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio added a comment. In http://reviews.llvm.org/D17688#363835, @zaks.anna wrote: > The two underscores in the names are hard to read. Maybe we should just > prefix them with 'win'? I like that better, will change. http://reviews.llvm.org/D17688

Re: r261774 - Bail on compilation as soon as a job fails.

Do you think something like the implicit inputs thing in http://reviews.llvm.org/D17695 could work for you as well, instead of this patch? Then we don't have to forever promise to compile all .cc input files serially. On Wed, Feb 24, 2016 at 4:49 PM, Justin Lebar via cfe-commits <

Re: [PATCH] D17695: clang-cl: Implement initial limited support for precompiled headers.

thakis updated this revision to Diff 49325. thakis added a comment. clean up accidentally duplicate if block http://reviews.llvm.org/D17695 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/DiagnosticGroups.td include/clang/Driver/Action.h

r262189 - [modules] Prefer more complete array types.

Author: vvassilev Date: Sun Feb 28 13:08:24 2016 New Revision: 262189 URL: http://llvm.org/viewvc/llvm-project?rev=262189=rev Log: [modules] Prefer more complete array types. If we import a module that has a complete array type and one that has an incomplete array type, the declaration found by

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

On Sun, Feb 28, 2016 at 1:21 PM, Anna Zaks wrote: > zaks.anna added a comment. > > The two underscores in the names are hard to read. Maybe we should just > prefix them with 'win'? Two underscores in the name is actually undefined behavior, so I would second this

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

zaks.anna added a comment. The two underscores in the names are hard to read. Maybe we should just prefix them with 'win'? http://reviews.llvm.org/D17688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

2016-02-19 20:52 GMT+06:00 Aleksei Sidorin : > a.sidorin added a comment. > > Serge Pavlov: I'll enable tests from you patch ( > http://reviews.llvm.org/D14224) after all node types your patch supports > will be supported. If you're agree, of course. > > Yes, sure, that

[PATCH] D17695: clang-cl: Implement initial limited support for precompiled headers.

thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. In the gcc precompiled header model, one explicitly runs clang with `-x c++-header` on a .h file to produce a gch file, and then includes the header with `-include foo.h` and if a .gch file

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

logan added a comment. Hi @timonvo, I have committed this change as http://reviews.llvm.org/rL262178. Thanks for your work. Let's move forward to http://reviews.llvm.org/D15781. http://reviews.llvm.org/D15883 ___ cfe-commits mailing list

r262178 - Add ARM EHABI-related constants to unwind.h.

Author: logan Date: Sun Feb 28 09:01:42 2016 New Revision: 262178 URL: http://llvm.org/viewvc/llvm-project?rev=262178=rev Log: Add ARM EHABI-related constants to unwind.h. Adds a number of constants, defined in the ARM EHABI spec, to the Clang lib/Headers/unwind.h header. This is prerequisite