r262696 - [OPENMP] Simplify handling of clauses with postupdates, NFC.

Author: abataev Date: Fri Mar 4 01:21:16 2016 New Revision: 262696 URL: http://llvm.org/viewvc/llvm-project?rev=262696=rev Log: [OPENMP] Simplify handling of clauses with postupdates, NFC. Clauses with post-update expressions always have pre-init statement. So OMPClauseWithPreInit now is the

r262695 - [index] Distinguish USRs of anonymous enums by using their first enumerator.

Author: akirtzidis Date: Fri Mar 4 01:17:53 2016 New Revision: 262695 URL: http://llvm.org/viewvc/llvm-project?rev=262695=rev Log: [index] Distinguish USRs of anonymous enums by using their first enumerator. rdar://24609949. Modified: cfe/trunk/lib/Index/IndexingContext.cpp

r262694 - [index] Include parameter types in the USRs for C functions marked with 'overloadable' attribute.

Author: akirtzidis Date: Fri Mar 4 01:17:48 2016 New Revision: 262694 URL: http://llvm.org/viewvc/llvm-project?rev=262694=rev Log: [index] Include parameter types in the USRs for C functions marked with 'overloadable' attribute. Modified: cfe/trunk/lib/Index/USRGeneration.cpp

r262692 - [OpenCL] Refine pipe builtin support

Author: pxl Date: Fri Mar 4 01:11:16 2016 New Revision: 262692 URL: http://llvm.org/viewvc/llvm-project?rev=262692=rev Log: [OpenCL] Refine pipe builtin support Summary: Refine the type builtin support as the request with

r262688 - [X86] Pass __m64 types via SSE registers for GCC compatibility

Author: majnemer Date: Thu Mar 3 23:26:16 2016 New Revision: 262688 URL: http://llvm.org/viewvc/llvm-project?rev=262688=rev Log: [X86] Pass __m64 types via SSE registers for GCC compatibility For compatibility with GCC, classify __m64 as SSE. However, clang is a platform compiler for certain

r262687 - [VFS] Switch from close to SafelyCloseFileDescriptor

Author: majnemer Date: Thu Mar 3 23:26:14 2016 New Revision: 262687 URL: http://llvm.org/viewvc/llvm-project?rev=262687=rev Log: [VFS] Switch from close to SafelyCloseFileDescriptor The SafelyCloseFileDescriptor machinery does the right thing in the face of signals while close will do something

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3790 @@ -3923,3 +3789,3 @@ // where DD_ is an ID unique to the file (device and file IDs), PP is the - // mangled name of the function that encloses the target region and BB is the + // mangled

Re: [PATCH] D17874: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.

weimingz added a reviewer: apazos. weimingz added a comment. LGTM. Ana, could you take a look too? http://reviews.llvm.org/D17874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17853: Disable tail-call optimization for X86 interrupt handlers

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:9127 @@ +9126,3 @@ +// whose base type is \a BaseQTy. +static int CheckArrayExpressionDoesNotReferToUnitySize(Sema , + const Expr *E, This

r262686 - [index] Ignore ObjCTypeParamDecls during indexing.

Author: akirtzidis Date: Thu Mar 3 22:24:32 2016 New Revision: 262686 URL: http://llvm.org/viewvc/llvm-project?rev=262686=rev Log: [index] Ignore ObjCTypeParamDecls during indexing. Modified: cfe/trunk/lib/Index/IndexingContext.cpp cfe/trunk/test/Index/Core/index-source.m Modified:

[PATCH] D17874: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.

srhines created this revision. srhines added reviewers: cfe-commits, weimingz. Herald added a subscriber: aemerson. Using -no-integrated-as causes -mcpu=krait to be transformed into -march=armv7-a today. This precludes the assembler from using instructions like sdiv, which are present for krait.

Re: [PATCH] D16949: Fix for: Bug 5941 - improve diagnostic for * vs & confusion

ryee88 added a comment. Thanks! I don’t have commit permissions; can you submit for me? http://reviews.llvm.org/D16949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

arsenm added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1601 @@ +1600,3 @@ +if (CodeGenOpts.AMDGPUToolsInsertNopsOpt) + FuncAttrs.addAttribute("amdgpu_tools_insert_nops"); +if (CodeGenOpts.AMDGPUToolsNumReservedVGPROpt) Yes

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On Thu, Mar 3, 2016 at 4:28 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico Weber via cfe-commits wrote: > > On Thu, Mar 3, 2016 at 1:50 PM, Joerg Sonnenberger via cfe-commits < > > cfe-commits@lists.llvm.org> wrote: > >

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico Weber via cfe-commits wrote: > On Thu, Mar 3, 2016 at 1:50 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Thu, Mar 03, 2016 at 07:39:04PM +, Weiming Zhao via cfe-commits > > wrote: > > > Change the option

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

rafael added a subscriber: rafael. rafael added a comment. This is awesome! Comment at: include/clang/CodeGen/BackendUtil.h:38 @@ -37,3 +37,3 @@ const TargetOptions , const LangOptions , - StringRef TDesc, llvm::Module *M,

Re: r258504 - Change of UserLabelPrefix default value from "_" to ""

Sorry for not following up here; this will actually be solved in an entirely different way by http://reviews.llvm.org/D17183 On Thu, Mar 3, 2016 at 5:53 PM, Rafael Espíndola wrote: > As a first patch I think you can just leave every > > UserLabelPrefix = "" > > in

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Yes, sorry. http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

yaxunl updated the summary for this revision. yaxunl added a reviewer: tstellarAMD. yaxunl removed a subscriber: tstellarAMD. yaxunl updated this revision to Diff 49781. yaxunl added a comment. Add a test for -backend-option with and w/o target machine as suggested by Tom.

Re: r258504 - Change of UserLabelPrefix default value from "_" to ""

As a first patch I think you can just leave every UserLabelPrefix = "" in place. Cheers, Rafael ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

chandlerc added a comment. In http://reviews.llvm.org/D17784#367601, @kparzysz wrote: > This seemed fine to me, but at the second thought, the lines 2610-2613 in the > original should be removed. I agree. I think using LLVM_PREFIX here in any capacity is incorrect.

Re: [PATCH] D17582: [OPENMP] firstprivate and private clauses of teams, host codegeneration

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 262663. Repository: rL LLVM http://reviews.llvm.org/D17582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262663 - [OPENMP] firstprivate and private clauses of teams, host codegeneration

Author: cbertol Date: Thu Mar 3 16:09:40 2016 New Revision: 262663 URL: http://llvm.org/viewvc/llvm-project?rev=262663=rev Log: [OPENMP] firstprivate and private clauses of teams, host codegeneration Add code generation support for firstprivate and private clauses of teams on the host. Add

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

kparzysz added a comment. This seemed fine to me, but at the second thought, the lines 2610-2613 in the original should be removed. http://reviews.llvm.org/D17784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On Thu, Mar 3, 2016 at 1:50 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Mar 03, 2016 at 07:39:04PM +, Weiming Zhao via cfe-commits > wrote: > > Change the option name to -ffile-macro-prefix-to-remove > > This still sounds to me like a solution for a

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On Thu, Mar 03, 2016 at 07:39:04PM +, Weiming Zhao via cfe-commits wrote: > Change the option name to -ffile-macro-prefix-to-remove This still sounds to me like a solution for a very restricted part of a much more generic problem... Joerg ___

r262659 - [analyzer] ObjCDeallocChecker: Only check for nil-out when type is retainable.

Author: dcoughlin Date: Thu Mar 3 15:38:39 2016 New Revision: 262659 URL: http://llvm.org/viewvc/llvm-project?rev=262659=rev Log: [analyzer] ObjCDeallocChecker: Only check for nil-out when type is retainable. This fixes a crash when setting a property of struct type in -dealloc. Modified:

[clang-tools-extra] r262654 - Fix two minor syntax issues in the documentation

Author: sylvestre Date: Thu Mar 3 14:54:26 2016 New Revision: 262654 URL: http://llvm.org/viewvc/llvm-project?rev=262654=rev Log: Fix two minor syntax issues in the documentation Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-forward-declaration-namespace.rst

[clang-tools-extra] r262655 - fix some minor typos in the doc

Author: sylvestre Date: Thu Mar 3 14:57:16 2016 New Revision: 262655 URL: http://llvm.org/viewvc/llvm-project?rev=262655=rev Log: fix some minor typos in the doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-string-integer-assignment.rst

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

tstellarAMD added a comment. Do you have a test case for this? http://reviews.llvm.org/D17552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r262576 - Caught and fixed a typo in r262572.

Nico, the tests for ASTImporter (currently, test/ASTMerge) are currently set up to do an AST merge and check that certain errors occur. I don’t believe they actually go and code-gen, which would have caught this. I think investing in better ASTImporter testing is a great goal, but right now

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 262652. Repository: rL LLVM http://reviews.llvm.org/D17148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262652 - Add code generation for teams directive inside target region

Author: cbertol Date: Thu Mar 3 14:34:23 2016 New Revision: 262652 URL: http://llvm.org/viewvc/llvm-project?rev=262652=rev Log: Add code generation for teams directive inside target region Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

manmanren created this revision. manmanren added reviewers: dexonsmith, rjmccall. manmanren added a subscriber: cfe-commits. This can be used to display Fix-Its. We only add this to GNU attributes. Since it now has two optional arguments, and the common parsing does not handle "replacement = ",

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz updated the summary for this revision. weimingz updated this revision to Diff 49762. weimingz added a comment. Change the option name to -ffile-macro-prefix-to-remove http://reviews.llvm.org/D17741 Files: include/clang/Driver/Options.td include/clang/Lex/Preprocessor.h

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

sbenza added a comment. In http://reviews.llvm.org/D17811#366482, @Eugene.Zelenko wrote: > Does it make http://reviews.llvm.org/D17772 obsolete? Yes. The other patch has already been abandoned. http://reviews.llvm.org/D17811 ___ cfe-commits

r262641 - [OpenCL] Improve diagnostics of address spaces for variables in function

Author: stulova Date: Thu Mar 3 12:38:40 2016 New Revision: 262641 URL: http://llvm.org/viewvc/llvm-project?rev=262641=rev Log: [OpenCL] Improve diagnostics of address spaces for variables in function - Prevent local variables to be declared in global AS - Diagnose AS of local variables with

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

On Thu, Mar 3, 2016 at 12:06 PM, David Majnemer wrote: > > > On Thu, Mar 3, 2016 at 7:52 AM, Aaron Ballman > wrote: >> >> On Thu, Mar 3, 2016 at 10:43 AM, Andrey Bokhanko >> wrote: >> > Now I'm completely confused...

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

djasper added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:237 @@ +236,3 @@ +/// related to the same file entry are put into the same vector. +FileToReplacementsMap groupReplacementsByFile(const Replacements , +

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

sfantao added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:9071 @@ +9070,3 @@ +/// 0 if it is inconclusive. +static int CheckArrayExpressionReferToWholeSize(Sema , const Expr *E, +QualType BaseQTy) { ABataev

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

sfantao updated this revision to Diff 49749. sfantao marked 4 inline comments as done. sfantao added a comment. - Remove extra braces and revert the sense of the whole/unity array section check. http://reviews.llvm.org/D17547 Files: include/clang/Basic/DiagnosticSemaKinds.td

r262630 - clang-format: Use stable_sort when sorting #includes.

Author: djasper Date: Thu Mar 3 11:34:14 2016 New Revision: 262630 URL: http://llvm.org/viewvc/llvm-project?rev=262630=rev Log: clang-format: Use stable_sort when sorting #includes. Otherwise, clang-format can output useless replacements in the presence of identical #includes Modified:

[PATCH] D17853: Disable tail-call optimization for X86 interrupt handlers

aaboud created this revision. aaboud added reviewers: hjl.tools, DavidKreitzer, ABataev. aaboud added a subscriber: cfe-commits. Resolved Bug 26414. https://llvm.org/bugs/show_bug.cgi?id=26414 Since interrupt handler must be returned with iretq, tail call can't be used.

Re: [clang-tools-extra] r262615 - [clang-tidy] Do not emit warnings from misc-suspicious-semicolon when the compilation fails.

Thank you! On Thu, Mar 3, 2016 at 2:48 PM, Gábor Horváth wrote: > Thank you for the suggestions. This should be addressed in r262618. > > On 3 March 2016 at 14:42, Alexander Kornienko wrote: > >> >> >> On Thu, Mar 3, 2016 at 2:08 PM, Gabor Horvath via

Re: [PATCH] D17849: [clang-tidy] Make 'modernize-use-nullptr' check work on multiple nested implicit cast expressions.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D17849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17816: [PPC] FE support for generating VSX [negated] absolute value instructions

nemanjai added a comment. All of my comments are just nits and shouldn't hold up approval. As far as I can tell this looks fine, but I'll let the LGTM come from Kit or Hal. Comment at: lib/Headers/altivec.h:136 @@ -131,3 +135,3 @@ #if defined(__POWER8_VECTOR__) &&

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

On Thu, Mar 3, 2016 at 7:52 AM, Aaron Ballman wrote: > On Thu, Mar 3, 2016 at 10:43 AM, Andrey Bokhanko > wrote: > > Now I'm completely confused... :-) > > > > Can we rely that this MS engineer has enough authority to declare this > > to be a

r262625 - [OpenMP] Code generation for teams - kernel launching

Author: sfantao Date: Thu Mar 3 10:20:23 2016 New Revision: 262625 URL: http://llvm.org/viewvc/llvm-project?rev=262625=rev Log: [OpenMP] Code generation for teams - kernel launching Summary: This patch implements the launching of a target region in the presence of a nested teams region, i.e

[PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric created this revision. ioeric added reviewers: klimek, djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. formatAndApplyAllReplacements takes a set of Replacements, applies them on a Rewriter, and reformats the changed code. http://reviews.llvm.org/D17852

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

I spoke with a Microsoft compiler engineer who said this is most likely a bug that static_assert works in C mode in MSVC. Based on that, I would strongly prefer to not accept this patch. ~Aaron On Wed, Mar 2, 2016 at 9:33 PM, Aaron Ballman wrote: > I will talk to someone

Re: [PATCH] D17761: Added applyAllReplacementsAndFormat that works for multiple files.

ioeric abandoned this revision. ioeric added a comment. Start a new revision to put applyAllReplacementsAndFormat into non-core libTooling . http://reviews.llvm.org/D17761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

hfinkel added a subscriber: hfinkel. hfinkel added a comment. In http://reviews.llvm.org/D17741#367113, @weimingz wrote: > Add "-f__FILE__-prefix-to-remove" flag to support the trim of the prefix. > Passing special value __ALL_DIR__ to remove all dir parts. > > For example FILE is /a/b/c >

Re: [PATCH] D17816: [PPC] FE support for generating VSX [negated] absolute value instructions

amehsan added inline comments. Comment at: lib/Headers/altivec.h:136 @@ -131,3 +135,3 @@ #if defined(__POWER8_VECTOR__) && defined(__powerpc64__) static vector double __ATTRS_o_ai vec_abs(vector double __a) { nemanjai wrote: > I thought we were going to

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

kparzysz added a comment. This seemed fine to me, but at the second thought, the lines 2610-2613 in the original should be removed. http://reviews.llvm.org/D17784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262619 - [ARM] Add Clang targeting for ARMv8-M Baseline/Mainline

Author: brasmi01 Date: Thu Mar 3 07:52:22 2016 New Revision: 262619 URL: http://llvm.org/viewvc/llvm-project?rev=262619=rev Log: [ARM] Add Clang targeting for ARMv8-M Baseline/Mainline Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Driver/Tools.cpp

Re: [PATCH] D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline

bsmith closed this revision. bsmith added a comment. Committed as r262619. Repository: rL LLVM http://reviews.llvm.org/D15283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r262615 - [clang-tidy] Do not emit warnings from misc-suspicious-semicolon when the compilation fails.

Thank you for the suggestions. This should be addressed in r262618. On 3 March 2016 at 14:42, Alexander Kornienko wrote: > > > On Thu, Mar 3, 2016 at 2:08 PM, Gabor Horvath via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: xazax >> Date: Thu Mar 3 07:08:11

[clang-tools-extra] r262618 - [clang-tidy] Improve the robustness of a test.

Author: xazax Date: Thu Mar 3 07:43:23 2016 New Revision: 262618 URL: http://llvm.org/viewvc/llvm-project?rev=262618=rev Log: [clang-tidy] Improve the robustness of a test. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-suspicious-semicolon-fail.cpp Modified:

r262617 - [CLANG][AVX512][BUILTIN] movddup{128|256|512}

Author: mzuckerm Date: Thu Mar 3 07:43:05 2016 New Revision: 262617 URL: http://llvm.org/viewvc/llvm-project?rev=262617=rev Log: [CLANG][AVX512][BUILTIN] movddup{128|256|512} Differential Revision: http://reviews.llvm.org/D17826 Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

Re: [clang-tools-extra] r262615 - [clang-tidy] Do not emit warnings from misc-suspicious-semicolon when the compilation fails.

On Thu, Mar 3, 2016 at 2:08 PM, Gabor Horvath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xazax > Date: Thu Mar 3 07:08:11 2016 > New Revision: 262615 > > URL: http://llvm.org/viewvc/llvm-project?rev=262615=rev > Log: > [clang-tidy] Do not emit warnings from

r262616 - [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Author: stulova Date: Thu Mar 3 07:33:19 2016 New Revision: 262616 URL: http://llvm.org/viewvc/llvm-project?rev=262616=rev Log: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0 Applying the following restrictions for block types in OpenCL (v2.0 s6.12.5): - __block storage class is

Re: r261372 - [modules] Flatten -fmodule-name= and -fmodule-implementation-of= into a single

On 3 Mar 2016 3:18 a.m., "Argyrios Kyrtzidis via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > Mind if we keep -fmodule-implementation-of as an alias so that we can gradually transition to -fmodule-name ? Sure, no problem. > > On Feb 19, 2016, at 2:25 PM, Richard Smith via cfe-commits <

Re: [PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

dsanders accepted this revision. dsanders added a comment. Thanks. LGTM Repository: rL LLVM http://reviews.llvm.org/D16139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun added a comment. The comments should be addressed in: http://reviews.llvm.org/rL262615 Repository: rL LLVM http://reviews.llvm.org/D16535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r262615 - [clang-tidy] Do not emit warnings from misc-suspicious-semicolon when the compilation fails.

Author: xazax Date: Thu Mar 3 07:08:11 2016 New Revision: 262615 URL: http://llvm.org/viewvc/llvm-project?rev=262615=rev Log: [clang-tidy] Do not emit warnings from misc-suspicious-semicolon when the compilation fails. Added:

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

a.sidorin updated this revision to Diff 49727. a.sidorin marked 15 inline comments as done. a.sidorin added a comment. Add more comments; resolve issues pointed on review. http://reviews.llvm.org/D17446 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline

richard.barton.arm added a subscriber: richard.barton.arm. richard.barton.arm added a comment. Hi Bradley This matches the GCC targeting options: https://sourceware.org/ml/binutils/2015-12/msg00295.html https://sourceware.org/ml/binutils/2015-12/msg00296.html The code changes LGTM. I think as

r262611 - Fixing a checkfile error in avx512vlbw-builtins.c

Author: mzuckerm Date: Thu Mar 3 06:17:50 2016 New Revision: 262611 URL: http://llvm.org/viewvc/llvm-project?rev=262611=rev Log: Fixing a checkfile error in avx512vlbw-builtins.c Differential Revision: http://reviews.llvm.org/D17814 Modified: cfe/trunk/test/CodeGen/avx512vlbw-builtins.c

[libcxx] r262610 - Fix for PR26812: possible overflow issue in std::allocator::allocate

Author: marshall Date: Thu Mar 3 06:04:39 2016 New Revision: 262610 URL: http://llvm.org/viewvc/llvm-project?rev=262610=rev Log: Fix for PR26812: possible overflow issue in std::allocator::allocate Added:

r262609 - [CLANG][AVX512][BUILTIN] movdqu{qi|hi} {128|256|512}

Author: mzuckerm Date: Thu Mar 3 05:34:52 2016 New Revision: 262609 URL: http://llvm.org/viewvc/llvm-project?rev=262609=rev Log: [CLANG][AVX512][BUILTIN] movdqu{qi|hi} {128|256|512} Differential Revision: http://reviews.llvm.org/D17814 Modified:

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

sberg added a comment. Can you please push this, I do not have commit access. Thanks http://reviews.llvm.org/D15267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg added a comment. Can you please push this, I do not have commit access. Thanks http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

bkramer added a comment. This doesn't look right to me. Aborting tree transform on a bad source location seems just wrong. Where is the invalid source location coming from? Also the backtrace seems related to typo correction, maybe the bug is there? Repository: rL LLVM

r262606 - Tweak CMakeLists not for libclang to depend on the variable CLANG_TOOL_EXTRA_BUILD.

Author: chapuni Date: Thu Mar 3 05:09:43 2016 New Revision: 262606 URL: http://llvm.org/viewvc/llvm-project?rev=262606=rev Log: Tweak CMakeLists not for libclang to depend on the variable CLANG_TOOL_EXTRA_BUILD. Modified: cfe/trunk/tools/CMakeLists.txt

[clang-tools-extra] r262605 - [docs] Fix docs to work with doxygen 1.8.11

Author: alexfh Date: Thu Mar 3 04:45:59 2016 New Revision: 262605 URL: http://llvm.org/viewvc/llvm-project?rev=262605=rev Log: [docs] Fix docs to work with doxygen 1.8.11 Added: clang-tools-extra/trunk/docs/doxygen-mainpage.dox Removed: clang-tools-extra/trunk/docs/doxygen.intro

r262604 - [docs] Add missing file

Author: alexfh Date: Thu Mar 3 04:44:10 2016 New Revision: 262604 URL: http://llvm.org/viewvc/llvm-project?rev=262604=rev Log: [docs] Add missing file Added: cfe/trunk/docs/doxygen-mainpage.dox Added: cfe/trunk/docs/doxygen-mainpage.dox URL:

Re: [PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

hokein added a comment. friendly ping. Repository: rL LLVM http://reviews.llvm.org/D17762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262603 - [docs] Updated doxygen files to work well with doxygen 1.8.11

Author: alexfh Date: Thu Mar 3 04:42:46 2016 New Revision: 262603 URL: http://llvm.org/viewvc/llvm-project?rev=262603=rev Log: [docs] Updated doxygen files to work well with doxygen 1.8.11 Doxygen 1.8.11 doesn't seem to like files with ".intro" extension by default. Removed:

Re: [PATCH] D17845: [ASTImporter] Import "implicit" attribute of FunctionDecls

labath added a subscriber: lldb-commits. labath added a comment. I noticed this while debugging an importing issue in LLDB. I am not sure if I have selected the right reviewer, and also how/if to test this... http://reviews.llvm.org/D17845 ___

[PATCH] D17845: [ASTImporter] Import "implicit" attribute of FunctionDecls

labath created this revision. labath added a reviewer: akyrtzi. labath added a subscriber: cfe-commits. ASTImporter was importing this attribute only on destructor and constructor decls, as they take it in the constructor, but other decls can have this attribute as well, notably the global

r262598 - [CLANG][AVX512][BUILTIN] movdqa{32|64}{load|store|}{128|256|512}

Author: mzuckerm Date: Thu Mar 3 03:26:01 2016 New Revision: 262598 URL: http://llvm.org/viewvc/llvm-project?rev=262598=rev Log: [CLANG][AVX512][BUILTIN] movdqa{32|64}{load|store|}{128|256|512} Differential Revision: http://reviews.llvm.org/D17812 Modified:

Re: [PATCH] D17816: [PPC] FE support for generating VSX [negated] absolute value instructions

nemanjai added inline comments. Comment at: lib/Headers/altivec.h:136 @@ -131,3 +135,3 @@ #if defined(__POWER8_VECTOR__) && defined(__powerpc64__) static vector double __ATTRS_o_ai vec_abs(vector double __a) { I thought we were going to change the guard here

Re: [PATCH] D17808: [libclang] Link clang-tidy plugin into libclang if present.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262596: [libclang] Link clang-tidy plugin into libclang if present. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D17808?vs=49616=49719#toc Repository: rL LLVM

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262595: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D17807?vs=49615=49718#toc Repository: rL LLVM

r262596 - [libclang] Link clang-tidy plugin into libclang if present.

Author: d0k Date: Thu Mar 3 02:58:18 2016 New Revision: 262596 URL: http://llvm.org/viewvc/llvm-project?rev=262596=rev Log: [libclang] Link clang-tidy plugin into libclang if present. This is a sad workaround for the lack of plugin support in libclang. Depends on D17807, a tools-extra change

[clang-tools-extra] r262595 - [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

Author: d0k Date: Thu Mar 3 02:58:12 2016 New Revision: 262595 URL: http://llvm.org/viewvc/llvm-project?rev=262595=rev Log: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton. This doesn't really do much at the moment. You can load it via libclang and set the -checks via an extra command

r262593 - [Clang][AVX512][BUILTIN] Adding PSRL{W|WI}{128|256|512}

Author: mzuckerm Date: Thu Mar 3 02:55:20 2016 New Revision: 262593 URL: http://llvm.org/viewvc/llvm-project?rev=262593=rev Log: [Clang][AVX512][BUILTIN] Adding PSRL{W|WI}{128|256|512} Differential Revision: http://reviews.llvm.org/D17754 Modified:

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz updated this revision to Diff 49713. weimingz added a comment. Add "-f__FILE__-prefix-to-remove" flag to support the trim of the prefix. Passing special value __ALL_DIR__ to remove all dir parts. For example FILE is /a/b/c -f__FILE__-prefix-to-remove=/a/ will cause FILE be expanded to

Re: r261372 - [modules] Flatten -fmodule-name= and -fmodule-implementation-of= into a single

Mind if we keep -fmodule-implementation-of as an alias so that we can gradually transition to -fmodule-name ? > On Feb 19, 2016, at 2:25 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Fri Feb 19 16:25:36 2016 > New Revision: 261372 > > URL: