r270962 - [OPENMP] Fixed processing of '-fopenmp-version=' option and test.

Author: abataev Date: Thu May 26 23:13:39 2016 New Revision: 270962 URL: http://llvm.org/viewvc/llvm-project?rev=270962=rev Log: [OPENMP] Fixed processing of '-fopenmp-version=' option and test. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/lib/Frontend/CompilerInvocation.cpp

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

mclow.lists added a comment. Let's file a bug on this too - http://llvm.org/bugs (make it easier to find in the future) http://reviews.llvm.org/D20334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

ABataev added a comment. Hi Daniel, Will fix it ASAP Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 27.05.2016 1:33, Samuel Antao пишет: > sfantao updated the summary for this revision. > > http://reviews.llvm.org/D18110 http://reviews.llvm.org/D18110

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

pxli168 added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, , Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S +

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

alexfh added a comment. Full context diffs, please. See http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface for instructions. Repository: rL LLVM http://reviews.llvm.org/D20714 ___ cfe-commits mailing list

r270952 - [Intrin.h] Sort the __read[fg]s intrinsics

Author: majnemer Date: Thu May 26 21:06:14 2016 New Revision: 270952 URL: http://llvm.org/viewvc/llvm-project?rev=270952=rev Log: [Intrin.h] Sort the __read[fg]s intrinsics No functional change is intended. Modified: cfe/trunk/lib/Headers/Intrin.h Modified: cfe/trunk/lib/Headers/Intrin.h

r270953 - [CodeGen] Don't crash when sizeof(long) != 4 for some intrins

Author: majnemer Date: Thu May 26 21:06:19 2016 New Revision: 270953 URL: http://llvm.org/viewvc/llvm-project?rev=270953=rev Log: [CodeGen] Don't crash when sizeof(long) != 4 for some intrins _InterlockedIncrement and _InterlockedDecrement have 'long' in their prototypes. We assumed 'long' was

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

ahatanak marked an inline comment as done. ahatanak added a comment. I spent some time debugging the code and here is what I found. The initial buffer size is 0 when strstreambuf is constructed and all six pointers are null initially. When the first character is pushed, strstreambuf::overflow

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

ahatanak updated this revision to Diff 58740. ahatanak added a comment. Remove unused variable and add test case. http://reviews.llvm.org/D20334 Files: src/strstream.cpp test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/overflow.pass.cpp Index:

[PATCH] D20715: [docs] Document the source-based code coverage feature

vsk created this revision. vsk added a reviewer: bogner. vsk added subscribers: kcc, cfe-commits, silvas. It would be helpful to have a user-friendly guide for code coverage. There is some overlap with [1], but this document visits issues which may affect users in more depth. Prompted by:

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

timshen marked an inline comment as done. timshen added a comment. http://reviews.llvm.org/D20499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

timshen updated this revision to Diff 58734. timshen added a comment. Herald added a subscriber: klimek. Used pushFullExprCleanup. microsoft-abi-eh-cleanups.cpp fails because each pushFullExprCleanup introduces a new cleanup.cond variable, even if that pushFullExprCleanup is just for lifetime

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

timshen updated this revision to Diff 58738. timshen added a comment. Upload the rebased patch. http://reviews.llvm.org/D20499 Files: lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/EHScopeStack.h

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

timshen updated this revision to Diff 58737. timshen added a comment. Upload the rebased patch. http://reviews.llvm.org/D20499 Files: include/clang/AST/ExprCXX.h include/clang/AST/Stmt.h include/clang/Sema/CleanupInfo.h include/clang/Sema/ScopeInfo.h include/clang/Sema/Sema.h

[PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein, etienneb. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL

Re: [PATCH] D20428: Tracking exception specification source locations

rsmith added inline comments. Comment at: include/clang/AST/TypeLoc.h:1251 @@ -1250,2 +1250,3 @@ SourceLocation RParenLoc; + SourceRange ExceptionSpecRange; SourceLocation LocalRangeEnd; Can you arrange things so we only store this if there is an exception

Re: [PATCH] D20428: Tracking exception specification source locations

rsmith added a comment. Seems reasonable to me. Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3427 @@ -3402,5 +3402,6 @@ // recovery, but emit a diagnostic and don't store the results. - SourceRange NoexceptRange; + SourceRange NoexceptRange(Tok.getLocation(), +

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

bryanpkc updated this revision to Diff 58723. bryanpkc added a comment. Re-added test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o. http://reviews.llvm.org/D14727 Files: lib/Driver/ToolChains.cpp test/Driver/Inputs/gcc_version_parsing5/

r270940 - OpenMPClause.h: Fix r270882. [-Wdocumentation]

Author: chapuni Date: Thu May 26 19:15:11 2016 New Revision: 270940 URL: http://llvm.org/viewvc/llvm-project?rev=270940=rev Log: OpenMPClause.h: Fix r270882. [-Wdocumentation] Modified: cfe/trunk/include/clang/AST/OpenMPClause.h Modified: cfe/trunk/include/clang/AST/OpenMPClause.h URL:

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

jroelofs added a comment. In http://reviews.llvm.org/D14727#441758, @bryanpkc wrote: > Fixed the code to set GoodVersion.MajorStr before returning, and removed an > unnecessary file > (test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o). That file is not

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

bryanpkc updated this revision to Diff 58722. bryanpkc added a comment. Fixed the code to set GoodVersion.MajorStr before returning, and removed an unnecessary file (test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o). http://reviews.llvm.org/D14727 Files:

[PATCH] D20710: Lit C++11 Compatibility Patch #9

tigerleapgorge created this revision. tigerleapgorge added a reviewer: rsmith. tigerleapgorge added a subscriber: cfe-commits. Hi everyone, I am back again with Lit test C++11 compatibility patch #9. 30 tests are updated this time. They are follows.

[PATCH] D20709: Support ARM subtarget feature +long64

pirama created this revision. pirama added a reviewer: kristof.beyls. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: rengolin, aemerson. Set alignment and width of long datatype to be 64-bits if the ARM subtarget feature +long64 is set. http://reviews.llvm.org/D20709

Re: [PATCH] D20626: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

craig.topper added a subscriber: craig.topper. Comment at: test/CodeGen/avx512f-builtins.c:1927 @@ +1926,3 @@ + // check-label: @test_mm512_div_pd + // check: @llvm.x86.avx512.mask.div.pd.512 + return _mm512_div_pd(__a,__b); delena wrote: > I don't understand

Re: [PATCH] D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

sfantao updated this revision to Diff 58704. sfantao updated the summary for this revision. sfantao added a comment. Remove most of the logic in the first diff. It is no longer necessary given that all firstprivate captures are now passed by value no matter the directive they are captured in.

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath added a comment. In http://reviews.llvm.org/D20677#441598, @EricWF wrote: > I want to take a look at this as well. I'll review it tomorrow. Thanks! will wait until we have ironed out all the details, no hurry. / Asiri http://reviews.llvm.org/D20677

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath added a comment. In http://reviews.llvm.org/D20677#441407, @bcraig wrote: > https://mentorembedded.github.io/cxx-abi/abi-eh.html mentions the functions, > but it doesn't really say what they are for. The C++ standard mentions when > an exception of std::bad_cast and std::bad_typeid

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

EricWF added a reviewer: mclow.lists. EricWF added a subscriber: mclow.lists. EricWF added a comment. Adding @mclow.lists to this as well. http://reviews.llvm.org/D20677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] r270927 - Use size_t to store the results of sizeof calculations.

Author: asiri Date: Thu May 26 16:56:04 2016 New Revision: 270927 URL: http://llvm.org/viewvc/llvm-project?rev=270927=rev Log: Use size_t to store the results of sizeof calculations. NFC. Modified: libunwind/trunk/src/config.h Modified: libunwind/trunk/src/config.h URL:

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

EricWF added a comment. I want to take a look at this as well. I'll review it tomorrow. http://reviews.llvm.org/D20677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libunwind] r270925 - Fix gcc libunwind build.

On 5/26/16 3:45 PM, Asiri Rathnayake via cfe-commits wrote: struct blk_count { -static const uint32_t count = +static const uint64_t count = (sizeof(T) + sizeof(uint64_t) - Should that be 'size_t' instead? Jon -- Jon Roelofs jonat...@codesourcery.com CodeSourcery /

[libunwind] r270925 - Fix gcc libunwind build.

Author: asiri Date: Thu May 26 16:45:54 2016 New Revision: 270925 URL: http://llvm.org/viewvc/llvm-project?rev=270925=rev Log: Fix gcc libunwind build. r270692 seems to have broken gcc builds of libunwind. This is because statements like: static_assert(check_fit

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. In http://reviews.llvm.org/D20119#441548, @jroelofs wrote: > In http://reviews.llvm.org/D20119#441516, @rmaprath wrote: > > > Please shout! > > > Just add some parens: > > static_assert((check_fit::does_fit), > "or1k

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

LGTM. > On 2016-May-26, at 11:34, Bruno Cardoso Lopes wrote: > > bruno added a comment. > > Ping! > > > http://reviews.llvm.org/D20404 > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. LGTM. http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

jroelofs added a comment. In http://reviews.llvm.org/D20119#441516, @rmaprath wrote: > Please shout! Just add some parens: static_assert((check_fit::does_fit), "or1k registers do not fit into unw_context_t");

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

timshen updated this revision to Diff 58694. timshen marked 2 inline comments as done. timshen added a comment. Removed C++ constrain and added back the missing comment line. http://reviews.llvm.org/D20498 Files: include/clang/AST/ExprCXX.h include/clang/AST/Stmt.h

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. Looks like this patch breakes gcc builds of libunwind (none of the bots seem to test it though). The problem is two-fold, in `src/config.h` we have: // Define static_assert() unless already defined by compiler.

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

rsmith added inline comments. Comment at: lib/Sema/SemaInit.cpp:6197 @@ +6196,3 @@ + // but there may be a chance to merge them. + if (getLangOpts().CPlusPlus) +Cleanup.setExprNeedsCleanups(false); Why is this C++-only? We presumably would want to clean up

r270904 - Produce better pretty stack traces from crashes in template instantiation: add

Author: rsmith Date: Thu May 26 15:23:13 2016 New Revision: 270904 URL: http://llvm.org/viewvc/llvm-project?rev=270904=rev Log: Produce better pretty stack traces from crashes in template instantiation: add pretty stack trace entries for all cases where we instantiate the definition of something,

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

timshen marked 7 inline comments as done. Comment at: lib/Sema/SemaInit.cpp:6190-6191 @@ +6189,4 @@ + MaterializeTemporaryExpr(T, Temporary, BoundToLvalueReference); + + // Order an ExprWithCleanups for lifetime marks. + // > Please also sink the calls to

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

timshen updated this revision to Diff 58676. timshen added a comment. Update to reflect the comments. http://reviews.llvm.org/D20498 Files: include/clang/AST/ExprCXX.h include/clang/AST/Stmt.h include/clang/Sema/CleanupInfo.h include/clang/Sema/ScopeInfo.h include/clang/Sema/Sema.h

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

bcraig added a comment. LGTM. Probably want a "LGTM" from at least one other person though. In http://reviews.llvm.org/D20677#441085, @rmaprath wrote: > In http://reviews.llvm.org/D20677#441061, @jroelofs wrote: > > > This is the canonical reference for the Itanium ABI: > >

Re: [PATCH] D20626: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

delena added inline comments. Comment at: test/CodeGen/avx512f-builtins.c:1927 @@ +1926,3 @@ + // check-label: @test_mm512_div_pd + // check: @llvm.x86.avx512.mask.div.pd.512 + return _mm512_div_pd(__a,__b); I don't understand how do you receive intrinsic if

r270897 - Re-commit r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)"

Author: hans Date: Thu May 26 14:42:56 2016 New Revision: 270897 URL: http://llvm.org/viewvc/llvm-project?rev=270897=rev Log: Re-commit r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)" Also make explicit instantiation decls not

Re: [PATCH] D20336: [AMDGPU] Remove individual debugger options + update features

kzhuravl added a comment. http://reviews.llvm.org/rL270895 Repository: rL LLVM http://reviews.llvm.org/D20336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20336: [AMDGPU] Remove individual debugger options + update features

This revision was automatically updated to reflect the committed changes. Closed by commit rL270895: [AMDGPU] Remove individual debugger options + update features (authored by kzhuravl). Changed prior to commit: http://reviews.llvm.org/D20336?vs=57518=58668#toc Repository: rL LLVM

r270895 - [AMDGPU] Remove individual debugger options + update features

Author: kzhuravl Date: Thu May 26 14:36:39 2016 New Revision: 270895 URL: http://llvm.org/viewvc/llvm-project?rev=270895=rev Log: [AMDGPU] Remove individual debugger options + update features Differential Revision: http://reviews.llvm.org/D20336 Modified:

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

rsmith added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:446 @@ +445,3 @@ + case SD_FullExpression: +EHStack.pushCleanup(NormalEHLifetimeMarker, Object, + Size); This should use pushFullExprCleanup.

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

aturetsk added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + bruno wrote: > aturetsk wrote: > > bruno

r270886 - [OpenMP] Codegen for target update directive.

Author: sfantao Date: Thu May 26 13:30:22 2016 New Revision: 270886 URL: http://llvm.org/viewvc/llvm-project?rev=270886=rev Log: [OpenMP] Codegen for target update directive. Summary: This patch implements the code generation for the `target update` directive. The implemntation relies on the

Re: [PATCH] D20650: [OpenMP] Codegen for target update directive.

sfantao updated this revision to Diff 58658. sfantao added a comment. - Adapt target update tests bits to reflect latest changes in the trunk. http://reviews.llvm.org/D20650 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno added a comment. Ping! http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno added a comment. Ping! http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20675: Compilation for Intel MCU (Part 3/3)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + aturetsk wrote: > bruno wrote: > > Taking a look

RE: [PATCH] D20681: Add target-specific pre-linking passes to Clang

+Jeff To cite some of the previous discussions (http://lists.llvm.org/pipermail/cfe-dev/2016-May/048822.html ) Brian: On our side, we use such pre-link passes to interface with the specifics of our built-in function library. For example, we transform printf calls into a form that interacts

Re: [PATCH] D20683: [MSVC2015] Fix mangling for static variables initialization guards

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. lgtm, agreed, looks like an oversight. http://reviews.llvm.org/D20683 ___ cfe-commits mailing list

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda added a comment. Please see http://reviews.llvm.org/D20693 for an alternative approach. http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900 @@ -7897,1 +7899,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL 2.2 extension">; } // end of sema category

[PATCH] D20693: New checker to replace dynamic exception specifications

hintonda created this revision. hintonda added reviewers: alexfh, aaron.ballman. hintonda added subscribers: etienneb, Eugene.Zelenko, cfe-commits. [clang-tidy] New checker to replace dynamic exception specifications This is an alternative to D18575 which relied on reparsing the decl to find the

r270882 - [OpenMP] Parsing and sema support for the from clause

Author: sfantao Date: Thu May 26 12:49:04 2016 New Revision: 270882 URL: http://llvm.org/viewvc/llvm-project?rev=270882=rev Log: [OpenMP] Parsing and sema support for the from clause Summary: The patch contains the parsing and sema support for the `from` clause. Patch based on the original

r270880 - [OpenMP] Parsing and sema support for the to clause

Author: sfantao Date: Thu May 26 12:39:58 2016 New Revision: 270880 URL: http://llvm.org/viewvc/llvm-project?rev=270880=rev Log: [OpenMP] Parsing and sema support for the to clause Summary: The patch contains the parsing and sema support for the `to` clause. Patch based on the original post by

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

varjujan created this revision. varjujan added a reviewer: alexfh. varjujan added subscribers: xazax.hun, cfe-commits. This checker finds those function calls where the function arguments are provided in an incorrect order. It compares the name of the given variable to the argument name in the

Re: [PATCH] D18597: [OpenMP] Parsing and sema support for the to clause

sfantao updated this revision to Diff 58651. sfantao added a comment. - Mark MappableVarListInfo as final. http://reviews.llvm.org/D18597 Files: include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

This revision was automatically updated to reflect the committed changes. Closed by commit rL270878: [OpenMP] Parsing and sema support for target update directive (authored by sfantao). Changed prior to commit: http://reviews.llvm.org/D15944?vs=58469=58647#toc Repository: rL LLVM

r270878 - [OpenMP] Parsing and sema support for target update directive

Author: sfantao Date: Thu May 26 12:30:50 2016 New Revision: 270878 URL: http://llvm.org/viewvc/llvm-project?rev=270878=rev Log: [OpenMP] Parsing and sema support for target update directive Summary: This patch is to add parsing and sema support for `target update` directive. Support for the

Re: [PATCH] D20660: Remove `auto_ptr` in C++17.

NO_REMOVE seems like a strange way of saying it - is there existing precedent for that naming/description? (rather than something like _LIBCPP_PROVIDE_AUTOPTR ? As for tests - XFAILing seems a bit general when there's really not much value in running any of the tests anyway. REQUIRES, perhaps?

r270870 - [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

Author: sfantao Date: Thu May 26 11:53:38 2016 New Revision: 270870 URL: http://llvm.org/viewvc/llvm-project?rev=270870=rev Log: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses. Summary: If a variable is

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath added a comment. In http://reviews.llvm.org/D20677#441061, @jroelofs wrote: > This is the canonical reference for the Itanium ABI: > https://mentorembedded.github.io/cxx-abi/abi.html I was indeed looking at this, but couldn't find those exact function signatures (or something that

r270868 - [OpenMP] Adjust map type bits according to latest spec and use zero size array sections for pointers.

Author: sfantao Date: Thu May 26 11:48:10 2016 New Revision: 270868 URL: http://llvm.org/viewvc/llvm-project?rev=270868=rev Log: [OpenMP] Adjust map type bits according to latest spec and use zero size array sections for pointers. Summary: This patch changes the bits used to specify the map

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

jroelofs added a comment. This is the canonical reference for the Itanium ABI: https://mentorembedded.github.io/cxx-abi/abi.html http://reviews.llvm.org/D20677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath marked an inline comment as done. Comment at: src/cxa_aux_runtime.cpp:19-25 @@ -18,5 +18,9 @@ extern "C" { _LIBCXXABI_FUNC_VIS LIBCXXABI_NORETURN void __cxa_bad_cast(void) { +#ifndef _LIBCXXABI_NO_EXCEPTIONS throw std::bad_cast(); +#else + std::terminate(); +#endif

[PATCH] D20687: Update hasDynamicExceptionSpec to use functionType instead of functionDecl.

hintonda created this revision. hintonda added a reviewer: aaron.ballman. hintonda added a subscriber: cfe-commits. Herald added a subscriber: klimek. Update hasDynamicExceptionSpec to use functionType instead of functionDecl. http://reviews.llvm.org/D20687 Files:

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

bcraig added inline comments. Comment at: src/cxa_aux_runtime.cpp:19-24 @@ -18,4 +18,8 @@ extern "C" { _LIBCXXABI_FUNC_VIS LIBCXXABI_NORETURN void __cxa_bad_cast(void) { +#ifndef _LIBCXXABI_NO_EXCEPTIONS throw std::bad_cast(); +#else + std::terminate(); +#endif }

[PATCH] D20684: [X86][SSE] Replace VPMOVSX and (V)PMOVZX integer extension intrinsics with generic IR (clang)

RKSimon created this revision. RKSimon added reviewers: mkuper, craig.topper, spatel, andreadb. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. The VPMOVSX and (V)PMOVZX sign/zero extension intrinsics can be safely represented as generic

Re: [PATCH] D20672: Don't pass -fms-compatibility-version flag during build

This revision was automatically updated to reflect the committed changes. Closed by commit rL270860: Since some time clang itself figures out the default for ms-compatibility… (authored by ismail). Changed prior to commit: http://reviews.llvm.org/D20672?vs=58586=58623#toc Repository: rL

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath marked 2 inline comments as done. Comment at: src/cxa_aux_runtime.cpp:19-20 @@ -18,3 +18,4 @@ extern "C" { _LIBCXXABI_FUNC_VIS LIBCXXABI_NORETURN void __cxa_bad_cast(void) { +#ifndef _LIBCXXABI_NO_EXCEPTIONS throw std::bad_cast(); I'm not very

RE: [PATCH] D20681: Add target-specific pre-linking passes to Clang

+ Brian -Original Message- From: Tom Stellard [mailto:thomas.stell...@amd.com] Sent: Thursday, May 26, 2016 11:11 AM To: Liu, Yaxun (Sam) ; rich...@metafoo.co.uk; anastasia.stul...@arm.com Cc: Stellard, Thomas ; cfe-commits@lists.llvm.org

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath updated this revision to Diff 58620. http://reviews.llvm.org/D20677 Files: CMakeLists.txt src/cxa_aux_runtime.cpp src/cxa_handlers.cpp src/cxa_new_delete.cpp src/cxa_personality.cpp test/CMakeLists.txt test/backtrace_test.pass.cpp test/catch_array_01.pass.cpp

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

ldionne updated this revision to Diff 58619. ldionne added a comment. Rebase the patch on top of the current `master`. The patch passes all of Clang's tests (`make check-clang`). I also removed the TODO comment about diagnostics, since that was answered by Richard Smith.

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. Firefox build has ended and exposes 62 diagnostics, 44 unique ocurrences and 10 different diagnostics (shown below) in networking code. taking address of packed member 'address' of class or structure 'sctp_state_cookie' may result in an unaligned pointer value

Re: r270373 - [driver][mips] Support new versions of MIPS CodeScape toolchains

It does, thanks! On Thu, May 26, 2016 at 3:35 PM, Simon Atanasyan wrote: > I hope r270842 fixes the problem. > > Thanks a lot for your help. > > On Thu, May 26, 2016 at 11:28 AM, Ismail Donmez wrote: >> Indeed the problematic option is

Re: [PATCH] D20672: Don't pass -fms-compatibility-version flag during build

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm if it works :-) Repository: rL LLVM http://reviews.llvm.org/D20672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: r270838 - [OPENMP] Add option '-fopenmp-version=[31|40|45]' allowing choosing

Hi, I think this commit may have caused the failure in http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/13743. Could you check? Buildbot will have supressed the usual email because the previous build failed (for a different reason). > -Original Message- > From: cfe-commits

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 marked 4 inline comments as done. Comment at: lib/Sema/SemaExpr.cpp:10527 @@ +10526,3 @@ +ME->getMemberDecl()->hasAttr()) { + Diag(OpLoc, diag::warn_taking_address_of_packed_member) + << ME->getMemberDecl() << RD; aaron.ballman

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

tstellarAMD added a comment. Can you give some examples of what pre-link passes may be required? http://reviews.llvm.org/D20681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

Anastasia added a subscriber: Anastasia. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900 @@ -7897,1 +7899,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL 2.2 extension">; } // end of sema category

Re: [PATCH] D18641: [PP] Handle #include_next after include found relative to current one same as GCC

DmitryPolukhin abandoned this revision. DmitryPolukhin added a comment. It seems that there is no interest in this patch, abandon. http://reviews.llvm.org/D18641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified

flx added a comment. Friendly ping. http://reviews.llvm.org/D20010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20678: [mips] Fold MipsTargetInfoBase subclasses into MipsTargetInfoBase and rename to MipsTargetInfo. NFC

atanasyan accepted this revision. atanasyan added a reviewer: atanasyan. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/Targets.cpp:6986 @@ +6985,3 @@ + : TargetInfo(Triple), CPU((getTriple().getArch() ==

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

mprobst updated this revision to Diff 58612. mprobst marked an inline comment as done. mprobst added a comment. revert FormatTokenLexer, restrict to first token http://reviews.llvm.org/D20632 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp

Re: [PATCH] D20678: [mips] Fold MipsTargetInfoBase subclasses into MipsTargetInfoBase and rename to MipsTargetInfo. NFC

dsanders added inline comments. Comment at: lib/Basic/Targets.cpp:6986 @@ +6985,3 @@ + : TargetInfo(Triple), CPU((getTriple().getArch() == llvm::Triple::mips || + getTriple().getArch() == llvm::Triple::mipsel) +

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

mprobst marked 2 inline comments as done. Comment at: lib/Format/TokenAnnotator.cpp:698 @@ +697,3 @@ + +if (Style.Language == FormatStyle::LK_JavaScript) { + // JavaScript files can contain shebang lines of the form: alexeagle wrote: > should we still

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

flx added a comment. This is ready for review again. http://reviews.llvm.org/D20277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r270851 - Adding missing _mm512_castsi512_si256 intrinsic.

Author: mzuckerm Date: Thu May 26 09:32:11 2016 New Revision: 270851 URL: http://llvm.org/viewvc/llvm-project?rev=270851=rev Log: Adding missing _mm512_castsi512_si256 intrinsic. Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/test/CodeGen/avx512f-builtins.c Modified:

[PATCH] D20681: Add target-specific pre-linking passes to Clang

yaxunl created this revision. yaxunl added reviewers: rsmith, Anastasia. yaxunl added subscribers: cfe-commits, tstellarAMD. Sometimes a backend needs to apply certain target-specific passes before linking. This patch attempts to add that. It depends on a new virtual member function

Re: [PATCH] D20680: [mips] Slightly simplify MipsTargetInfo::setDataLayout(). NFC.

atanasyan accepted this revision. atanasyan added a reviewer: atanasyan. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 added a comment. Thanks @bruno, I'll have a look at using a VFS for the test. Comment at: lib/Basic/FileManager.cpp:389 @@ -383,2 +388,3 @@ UFE->File.reset(); + UFE->IsVirtual = true; return UFE; rsmith wrote: > Rather than adding this

[PATCH] D20680: [mips] Slightly simplify MipsTargetInfo::setDataLayout(). NFC.

dsanders created this revision. dsanders added subscribers: cfe-commits, atanasyan. dsanders added a dependency: D20679: [mips] Kill 'support' for untested EABI.. Depends on D20679 http://reviews.llvm.org/D20680 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

  1   2   >