r272247 - [Sema] Don't crash when a field w/ a mem-initializer clashes with a record name

Author: majnemer Date: Thu Jun 9 00:26:56 2016 New Revision: 272247 URL: http://llvm.org/viewvc/llvm-project?rev=272247=rev Log: [Sema] Don't crash when a field w/ a mem-initializer clashes with a record name It is possible for a field and a class to have the same name. In such cases,

r272246 - [X86] Handle AVX2 pslldqi and psrldqi intrinsics shufflevector creation directly in the header file instead of in CGBuiltin.cpp. Simplify the sse2 equivalents as well.

Author: ctopper Date: Thu Jun 9 00:15:12 2016 New Revision: 272246 URL: http://llvm.org/viewvc/llvm-project?rev=272246=rev Log: [X86] Handle AVX2 pslldqi and psrldqi intrinsics shufflevector creation directly in the header file instead of in CGBuiltin.cpp. Simplify the sse2 equivalents as

r272245 - [X86] Reuse the EmitX86Select routine to handle the select for masked palignr too.

Author: ctopper Date: Thu Jun 9 00:15:00 2016 New Revision: 272245 URL: http://llvm.org/viewvc/llvm-project?rev=272245=rev Log: [X86] Reuse the EmitX86Select routine to handle the select for masked palignr too. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified:

r272244 - [X86] Add void to the argument list of intrinsics that don't take arguments since empty argument list mean something else in C.

Author: ctopper Date: Thu Jun 9 00:14:28 2016 New Revision: 272244 URL: http://llvm.org/viewvc/llvm-project?rev=272244=rev Log: [X86] Add void to the argument list of intrinsics that don't take arguments since empty argument list mean something else in C. Modified:

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

I agree with Rafael. I ran with -ftime-report for a couple of weeks on a lot of tests and never hit this problem. It actually seems weird we have to handle the timer recursively here as well (I'd like to avoid it at all), but let's see what Richard has to say when he gets to this review. On Wed,

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

Since we found only one user, I think my preference is to handle it there. Cheers, Rafael On 8 June 2016 at 13:49, Vedant Kumar wrote: > vsk added a comment. > > Ping, any updates on this patch? > > > http://reviews.llvm.org/D20748 > > >

[PATCH] D21163: Strip Android version when looking up toolchain paths.

jmgao created this revision. jmgao added reviewers: srhines, danalbert. jmgao added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, aemerson. Android target triples can include a version number in the abi field (e.g. 'aarch64-linux-android21'), used for

[clang-tools-extra] r272235 - Update to match LLVM r272232.

Author: rsmith Date: Wed Jun 8 19:54:42 2016 New Revision: 272235 URL: http://llvm.org/viewvc/llvm-project?rev=272235=rev Log: Update to match LLVM r272232. Modified: clang-tools-extra/trunk/clang-query/tool/ClangQuery.cpp clang-tools-extra/trunk/tool-template/ToolTemplate.cpp

r272233 - Update to match LLVM r272232.

Author: rsmith Date: Wed Jun 8 19:53:41 2016 New Revision: 272233 URL: http://llvm.org/viewvc/llvm-project?rev=272233=rev Log: Update to match LLVM r272232. Modified: cfe/trunk/tools/arcmt-test/arcmt-test.cpp cfe/trunk/tools/c-index-test/c-index-test.c

[PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, jholewinski. Clang changes to make use of the LLVM intrinsics added in D21160. http://reviews.llvm.org/D21162 Files: include/clang/Basic/BuiltinsNVPTX.def lib/Headers/__clang_cuda_intrinsics.h

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452673, @thakis wrote: > Not sure if we want a flag that adds 50% overhead, no matter how convenient > it might be :-/ I now have a version of the patch that caches directory contents that it lists: real2m31.461s user

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added inline comments. Comment at: lib/Lex/PPDirectives.cpp:179 @@ +178,3 @@ +"exception", "iterator", "random", "strstream", "vector", +"forward_list", "limits", "ratio", "system_error", + Applying your patch reveled a bunch of ^M (carriage-return)

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

rsmith added inline comments. Comment at: lib/Lex/PPDirectives.cpp:33 @@ -28,2 +32,2 @@ #include "llvm/Support/Path.h" #include "llvm/Support/SaveAndRestore.h" eric_niebler wrote: > You mean, instead of the `StringSet` below? Looks like `StringSwitch` just >

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added inline comments. Comment at: lib/Lex/PPDirectives.cpp:220 @@ +219,3 @@ +// In the ASCII range? +if (Ch < 0 || Ch > 0xff) + return false; // Can't be a standard header rsmith wrote: > Comment doesn't match code: the ASCII range ends

[libcxx] r272216 - Add notes for 2688

Author: marshall Date: Wed Jun 8 17:33:25 2016 New Revision: 272216 URL: http://llvm.org/viewvc/llvm-project?rev=272216=rev Log: Add notes for 2688 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

r272215 - [docs] Coverage: Clarify return value of __llvm_profile_write_file

Author: vedantk Date: Wed Jun 8 17:32:03 2016 New Revision: 272215 URL: http://llvm.org/viewvc/llvm-project?rev=272215=rev Log: [docs] Coverage: Clarify return value of __llvm_profile_write_file Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified:

r272214 - [docs] Coverage: Flesh out instructions for avoiding static initializeres

Author: vedantk Date: Wed Jun 8 17:24:52 2016 New Revision: 272214 URL: http://llvm.org/viewvc/llvm-project?rev=272214=rev Log: [docs] Coverage: Flesh out instructions for avoiding static initializeres Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified:

r272213 - [CMake] Cleanup uses of USES_TERMINAL

Author: cbieneman Date: Wed Jun 8 17:20:43 2016 New Revision: 272213 URL: http://llvm.org/viewvc/llvm-project?rev=272213=rev Log: [CMake] Cleanup uses of USES_TERMINAL Now that we are on CMake 3.4.3 we no longer need a version check around this. This is the clang side of r272211. Modified:

[libcxx] r272212 - [CMake] Cleanup uses of USES_TERMINAL

Author: cbieneman Date: Wed Jun 8 17:20:28 2016 New Revision: 272212 URL: http://llvm.org/viewvc/llvm-project?rev=272212=rev Log: [CMake] Cleanup uses of USES_TERMINAL Now that we are on CMake 3.4.3 we no longer need a version check around this. This is the libcxx side of r272211. Modified:

Re: r272198 - [DebugInfo] Add calling conventions to DISubroutineType

At least in theory it'd be nice to have test cases for the other call sites this change adds CC to. On Wed, Jun 8, 2016 at 1:41 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Wed Jun 8 15:41:54 2016 > New Revision: 272198 > > URL:

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

dcoughlin added a comment. A 6% speed improvement could be a big win! Do we have a sense of what the expected increased memory cost (as a % of average use over the lifetime of the process) is? My guess is it would be relatively low. I suspect most analyzer users run relatively few concurrent

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

yaxunl updated this revision to Diff 60105. yaxunl marked an inline comment as done. yaxunl added a comment. Refactor to eliminate lambda function argument. http://reviews.llvm.org/D20681 Files: include/clang/CodeGen/BackendUtil.h lib/CodeGen/BackendUtil.cpp lib/CodeGen/CodeGenAction.cpp

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added inline comments. Comment at: lib/Lex/PPDirectives.cpp:33 @@ -28,2 +32,2 @@ #include "llvm/Support/Path.h" #include "llvm/Support/SaveAndRestore.h" You mean, instead of the `StringSet` below? Looks like `StringSwitch` just turns into

[libcxx] r272202 - Mark 2441 as ready

Author: marshall Date: Wed Jun 8 16:25:38 2016 New Revision: 272202 URL: http://llvm.org/viewvc/llvm-project?rev=272202=rev Log: Mark 2441 as ready Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

rsmith added a comment. Looks OK to me, pending Bruno's confirmation that performance is acceptable. Comment at: lib/Lex/PPDirectives.cpp:102 Can you use `llvm::StringSwitch` for this? I'd be interested to see how the performance compares.

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added a comment. Before this goes in again, I want to double check that this doesn't affect compile time on darwin + frameworks. Will get back to you asap. Comment at: lib/Lex/PPDirectives.cpp:218 @@ +217,3 @@ + SmallString<32> LowerInclude{Include}; + for (char& Ch :

Re: [PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

This revision was automatically updated to reflect the committed changes. Closed by commit rL272198: [DebugInfo] Add calling conventions to DISubroutineType (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D21141?vs=60055=60101#toc Repository: rL LLVM

r272198 - [DebugInfo] Add calling conventions to DISubroutineType

Author: rnk Date: Wed Jun 8 15:41:54 2016 New Revision: 272198 URL: http://llvm.org/viewvc/llvm-project?rev=272198=rev Log: [DebugInfo] Add calling conventions to DISubroutineType Summary: This should have been a very simple change, but it was greatly complicated by the construction of new

Re: [PATCH] D20428: Tracking exception specification source locations

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: lib/AST/Decl.cpp:2938-2948 @@ -2937,1 +2937,13 @@ +SourceRange FunctionDecl::getExceptionSpecSourceRange() const { + const TypeSourceInfo *TSI = getTypeSourceInfo(); + if (!TSI) +

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos added a comment. Hmm, http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332/steps/test/logs/stdio fails with "error: cannot use dynamic_cast with -fno-rtti"; is there some way to detect if "-fno-rtti" is the default, and in that case don't execute

Re: [PATCH] D20428: Tracking exception specification source locations

hintonda added a comment. The comment says to rebuild TypeSourceInfo, but isn't that what this does? if (TSInfo->getType() != FD->getType()) Updated = getFunctionTypeWithExceptionSpec(*this, TSInfo->getType(), ESI); TSInfo->overrideType(Updated); If so, could you fix this by either

[PATCH] D21150: [OpenMP] Cast captures by copy when passed to fork call so that they are compatible to what the runtime library expects.

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, arpith-jacob, carlo.bertolli, kkwli0. sfantao added subscribers: caomhin, cfe-commits. This patch fixes an issue detected when firstprivate variables are passed to an OpenMP outlined function vararg list. Currently they

Re: [PATCH] D21113: Add support for case-insensitive header lookup

thakis added a comment. Not sure if we want a flag that adds 50% overhead, no matter how convenient it might be :-/ http://reviews.llvm.org/D21113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452558, @thakis wrote: > Can you try building a few more files? Say, v8_base? Well, that was depressing: Putting the sdk on a vfat fs: real2m26.077s user68m31.476s sys 1m25.702s Using the flag: real9m5.179s

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

yaxunl marked 2 inline comments as done. yaxunl added a comment. > > We have prelinking passes in amdgpu backend but it requires the llvm change > > to be committed first. We can add a test for this after that. > > > Sure. Could you subscribe me to the relevant backend reviews if possible

Re: [PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

yaxunl added a comment. In http://reviews.llvm.org/D20979#452463, @Anastasia wrote: > Looking good generally, I am just not sure about mixing two different > representations. If we choose only one form of representation, would you suggest to use function metadata or function attribute?

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl marked 5 inline comments as done. Comment at: test/Headers/opencl-c-header.cl:50 @@ +49,3 @@ + +// === +// Compile for OpenCL 1.0 for the second time. The module should not be re-created. I changed the module to read only. If Clang tries to create a new

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl updated this revision to Diff 60078. yaxunl marked 2 inline comments as done. yaxunl added a comment. Modified the test for module as Anastasia suggested. http://reviews.llvm.org/D20444 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/LangOptions.def

Re: [PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Function pointers make sense to me, thanks! LGTM Comment at: lib/CodeGen/CGDebugInfo.cpp:834 @@ -833,1 +833,3 @@ +static unsigned getDwarfCC(CallingConv CC) { + switch

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

On 6/8/16, 11:12 AM, "tha...@google.com on behalf of Nico Weber" wrote: >On Wed, Jun 8, 2016 at 1:56 PM, Eric Niebler  wrote: >> >>(adding back cfe-commits, answers inline) >> >>On 6/8/16, 10:11 AM, "tha...@google.com on behalf

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

This revision was automatically updated to reflect the committed changes. Closed by commit rL272188: clang-rename: implement renaming of classes inside dynamic_cast (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21120?vs=60001=60073#toc Repository: rL LLVM

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

(adding back cfe-commits, answers inline) On 6/8/16, 10:11 AM, "tha...@google.com on behalf of Nico Weber" wrote: >Sounds like "commit to the current file case and fix all the world's includes" >then :-) (MinGW's windows headers have

[clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Author: vmiklos Date: Wed Jun 8 13:38:23 2016 New Revision: 272188 URL: http://llvm.org/viewvc/llvm-project?rev=272188=rev Log: clang-rename: implement renaming of classes inside dynamic_cast Refactor to do the same as what is done already for static_cast. Reviewers: klimek Differential

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig added a comment. In http://reviews.llvm.org/D20933#452352, @zaks.anna wrote: > > For the pile of LLVM projects that I am currently building (llvm, clang, > > libcxx, libcxxabi), 18.9% of all analyzed > > > functions hit the maximum step count. For the previously discussed large > > .C

Re: [PATCH] D21113: Add support for case-insensitive header lookup

thakis added a comment. Can you try building a few more files? Say, v8_base? http://reviews.llvm.org/D21113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

rnk added a comment. In http://reviews.llvm.org/D21141#452517, @aprantl wrote: > Assuming that we could usually get the calling convention from the Function — > what's the motivation for emitting the calling convention of a subprogram > that has been optimized away? I don't have any

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452431, @thakis wrote: > For performance: Can you check how build times for some large target in > Chromium on Linux targeting Windows compares with this vs having the sdk in a > fat mount? That would give us some data. I measured

Re: [PATCH] D21117: Specify target in lifetime-asan test.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272185: Specify target in lifetime-asan test. (authored by vitalybuka). Changed prior to commit: http://reviews.llvm.org/D21117?vs=59987=60071#toc Repository: rL LLVM http://reviews.llvm.org/D21117

r272185 - Specify target in lifetime-asan test.

Author: vitalybuka Date: Wed Jun 8 13:18:08 2016 New Revision: 272185 URL: http://llvm.org/viewvc/llvm-project?rev=272185=rev Log: Specify target in lifetime-asan test. Summary: Some target platforms -fsanitize=address. Reviewers: pcc, eugenis Subscribers: cfe-commits, christof, chapuni,

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

On Wed, Jun 8, 2016 at 1:56 PM, Eric Niebler wrote: > (adding back cfe-commits, answers inline) > > On 6/8/16, 10:11 AM, "tha...@google.com on behalf of Nico Weber" < > tha...@google.com on behalf of tha...@chromium.org> wrote: > >Sounds like "commit to the current file case and

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

Anastasia added a comment. In http://reviews.llvm.org/D20681#450073, @yaxunl wrote: > In http://reviews.llvm.org/D20681#448443, @Anastasia wrote: > > > Do you think we could add any test for this change? > > > We have prelinking passes in amdgpu backend but it requires the llvm change > to be

[PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

erik.pilkington created this revision. erik.pilkington added reviewers: faisalv, rsmith, ahatanak. erik.pilkington added a subscriber: cfe-commits. Clang crashes during the instantiation of a lambda call operator where a `VarDecl` is initialized with an expression that requires the `this` type

Re: [PATCH] D20880: [Coverage] Push a region and propagate counts through try blocks

vsk added a comment. Ping. http://reviews.llvm.org/D20880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

vsk added a comment. Ping, any updates on this patch? http://reviews.llvm.org/D20748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

> I still think it would be good if the extensions that only affect the > host-side are removed, in particular cl_khr_icd and cl_khr_terminate_context. > We have a runtime that indirectly includes both Clang’s OpenCLExtensions.def > and the Khronos extension header, and we run into problems

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

On Wed, Jun 8, 2016 at 1:27 PM, Hans Wennborg wrote: > On Wed, Jun 8, 2016 at 10:20 AM, Nico Weber wrote: > > It looks like we're starting to be more careful about header case. MSVC's > > intrin.h is called intrin.h with a lower-case 'i'; ours starts with

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds marked an inline comment as done. JamesReynolds added a comment. http://reviews.llvm.org/D21020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 60058. JamesReynolds marked an inline comment as not done. JamesReynolds added a comment. Missed one modification in last update. http://reviews.llvm.org/D21020 Files: clang-tidy/readability/IdentifierNamingCheck.cpp

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds marked an inline comment as done. JamesReynolds added a comment. http://reviews.llvm.org/D21020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.h:89 @@ +88,3 @@ + + typedef std::pair NamingCheckId; + I think I thought that this wouldn't get picked up by the specialization machinery

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 60056. JamesReynolds marked 5 inline comments as done. JamesReynolds added a comment. Applied suggested code changes. http://reviews.llvm.org/D21020 Files: clang-tidy/readability/IdentifierNamingCheck.cpp

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

On Wed, Jun 8, 2016 at 10:20 AM, Nico Weber wrote: > It looks like we're starting to be more careful about header case. MSVC's > intrin.h is called intrin.h with a lower-case 'i'; ours starts with an > upper-case 'I' for no good reason. > > It looks like file-only renames

Re: [PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

Anastasia added a comment. Looking good generally, I am just not sure about mixing two different representations. http://reviews.llvm.org/D20979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

It looks like we're starting to be more careful about header case. MSVC's intrin.h is called intrin.h with a lower-case 'i'; ours starts with an upper-case 'I' for no good reason. It looks like file-only renames work fine as of svn 1.7 without any workarounds (

Re: [PATCH] D21113: Add support for case-insensitive header lookup

thakis added a comment. For performance: Can you check how build times for some large target in Chromium on Linux targeting Windows compares with this vs having the sdk in a fat mount? That would give us some data. The discussion in the include case warning thread sounds like MS might update

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler reopened this revision. eric_niebler added a subscriber: bogner. eric_niebler added a comment. This revision is now accepted and ready to land. Reopening. I would like some eyes on the updated patch before we merge. @rsmith Would you prefer this (and http://reviews.llvm.org/D19842)

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:6494 @@ +6493,3 @@ +default: + assert(0 && "unable to find corresponding image type"); +} Please start the assert message from the upper case and finish with .

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 60054. hans marked 2 inline comments as done. hans added a comment. Addressing Saleem's comments, and renaming the flag to -fcase-insensitive-paths, since this doesn't apply just to includes, but anything that goes through vfs, including the main source

[PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

rnk created this revision. rnk added reviewers: aprantl, dblaikie. rnk added a subscriber: cfe-commits. rnk added a dependency: D21114: [DebugInfo] Add calling convention support for DWARF and CodeView. This should have been a very simple change, but it was greatly complicated by the

Re: [PATCH] D20732: Don't use static variables in LambdaCapture

john.brawn added a comment. In http://reviews.llvm.org/D20732#452055, @faisalv wrote: > I'm assuming you've given some thought to any existing pathological code that > might break if the actual compile-time alignment of Decl itself is changed > (since currently it seems to be that the

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: test/Headers/opencl-c-header.cl:50 @@ +49,3 @@ +// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o - -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -fdisable-module-hash %s |

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Repository: rL LLVM http://reviews.llvm.org/D21134 ___ cfe-commits mailing list

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna added a comment. > For the pile of LLVM projects that I am currently building (llvm, clang, > libcxx, libcxxabi), 18.9% of all analyzed > functions hit the maximum step count. For the previously discussed large .C > file, 37% of the analyzed functions hit the maximum step count.

r272159 - [Sema] Don't permit catching variably modified types

Author: majnemer Date: Wed Jun 8 11:05:07 2016 New Revision: 272159 URL: http://llvm.org/viewvc/llvm-project?rev=272159=rev Log: [Sema] Don't permit catching variably modified types Variably modified types shouldn't be permitted in catch clauses. This fixes PR28047. Modified:

r272156 - Prune away some unused using decls. NFC.

Author: d0k Date: Wed Jun 8 10:34:36 2016 New Revision: 272156 URL: http://llvm.org/viewvc/llvm-project?rev=272156=rev Log: Prune away some unused using decls. NFC. Found by clang's misc-unused-using-decls. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp

Re: [clang-tools-extra] r272152 - [include-fixer] Keep dot dot in SymbolInfo file paths.

Turns out that this is causing weirdness when path minimization is disabled, we will insert includes with .. in that case. I don't know how to solve that, maybe still clean up the path in the fixer if minimization is off? On Wed, Jun 8, 2016 at 5:10 PM, Haojian Wu via cfe-commits

[clang-tools-extra] r272155 - [clang-tidy] misc-argument-comment: don't bail out when an argument is a macro expansion (e.g. NULL).

Author: alexfh Date: Wed Jun 8 10:27:46 2016 New Revision: 272155 URL: http://llvm.org/viewvc/llvm-project?rev=272155=rev Log: [clang-tidy] misc-argument-comment: don't bail out when an argument is a macro expansion (e.g. NULL). Add CHECK-FIX tests. Modified:

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

alexfh added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:142 @@ +141,3 @@ +SourceManager (PP->getSourceManager()); +if (!SM.isInMainFile(MacroNameTok.getLocation())) + return; I'm not sure the check currently refuses

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272153: [OpenCL] Fix __builtin_astype for vec3 types. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D20133?vs=59630=60043#toc Repository: rL LLVM

r272149 - [Sparc] Complex return value ABI compliance.

Author: lerochris Date: Wed Jun 8 09:47:25 2016 New Revision: 272149 URL: http://llvm.org/viewvc/llvm-project?rev=272149=rev Log: [Sparc] Complex return value ABI compliance. According to the Sparc V8 ABI, complex numbers should be passed and returned as pairs of registers:

Re: [PATCH] D21132: [include-fixer] Keep dot dot in SymbolInfo file paths.

hokein updated this revision to Diff 60041. hokein added a comment. Rebase. http://reviews.llvm.org/D21132 Files: include-fixer/find-all-symbols/PathConfig.cpp include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp test/include-fixer/include_path.cpp

r272148 - [Sparc] Complex return value ABI compliance.

Author: lerochris Date: Wed Jun 8 09:46:05 2016 New Revision: 272148 URL: http://llvm.org/viewvc/llvm-project?rev=272148=rev Log: [Sparc] Complex return value ABI compliance. According to the Sparc V8 ABI, complex numbers should be passed and returned as pairs of registers:

Re: [PATCH] D21132: [include-fixer] Keep dot dot in SymbolInfo file paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272152: [include-fixer] Keep dot dot in SymbolInfo file paths. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21132?vs=60041=60042#toc Repository: rL LLVM

r272153 - [OpenCL] Fix __builtin_astype for vec3 types.

Author: yaxunl Date: Wed Jun 8 10:11:21 2016 New Revision: 272153 URL: http://llvm.org/viewvc/llvm-project?rev=272153=rev Log: [OpenCL] Fix __builtin_astype for vec3 types. __builtin_astype does not generate correct LLVM IR for vec3 types. This patch inserts bitcasts to/from vec4 when

[clang-tools-extra] r272152 - [include-fixer] Keep dot dot in SymbolInfo file paths.

Author: hokein Date: Wed Jun 8 10:10:18 2016 New Revision: 272152 URL: http://llvm.org/viewvc/llvm-project?rev=272152=rev Log: [include-fixer] Keep dot dot in SymbolInfo file paths. Summary: Currently, removing dot dot in header's path doesn't make include-fixer minimize path correctly in some

[clang-tools-extra] r272151 - [include-fixer] explicitly set minimize-paths in test.

Author: ioeric Date: Wed Jun 8 09:57:43 2016 New Revision: 272151 URL: http://llvm.org/viewvc/llvm-project?rev=272151=rev Log: [include-fixer] explicitly set minimize-paths in test. Modified: clang-tools-extra/trunk/test/include-fixer/include_path.cpp Modified:

[libcxx] r272150 - Patch ready for #2436

Author: marshall Date: Wed Jun 8 09:54:35 2016 New Revision: 272150 URL: http://llvm.org/viewvc/llvm-project?rev=272150=rev Log: Patch ready for #2436 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

Re: [PATCH] D21132: [include-fixer] Keep dot dot in SymbolInfo file paths.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Ok, let's try this. Maybe it will solve our path problems once and for all. ONCE AND FOR ALL. http://reviews.llvm.org/D21132 ___ cfe-commits

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

This revision was automatically updated to reflect the committed changes. Closed by commit rL272144: [clang-tidy] correct clang-tidy-diff.py help message (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D21050?vs=59813=60035#toc Repository: rL LLVM

[clang-tools-extra] r272144 - [clang-tidy] correct clang-tidy-diff.py help message

Author: alexfh Date: Wed Jun 8 09:27:43 2016 New Revision: 272144 URL: http://llvm.org/viewvc/llvm-project?rev=272144=rev Log: [clang-tidy] correct clang-tidy-diff.py help message Summary: Looks like the original code was copied from clang-format-diff.py. Update help message to make it

r272143 - clang-format: [JS] fix a FIXME.

Author: mprobst Date: Wed Jun 8 09:05:26 2016 New Revision: 272143 URL: http://llvm.org/viewvc/llvm-project?rev=272143=rev Log: clang-format: [JS] fix a FIXME. Modified: cfe/trunk/lib/Format/SortJavaScriptImports.cpp Modified: cfe/trunk/lib/Format/SortJavaScriptImports.cpp URL:

r272142 - clang-format: [JS] fix an assertion failure caused by shrinking sources.

Author: mprobst Date: Wed Jun 8 09:04:04 2016 New Revision: 272142 URL: http://llvm.org/viewvc/llvm-project?rev=272142=rev Log: clang-format: [JS] fix an assertion failure caused by shrinking sources. Summary: The JavaScript import sorter has a corner condition that can cause the overall source

r272141 - [AVX512] Emit select instruction instead of using x86 specific instrinsics.

Author: ibreger Date: Wed Jun 8 08:59:20 2016 New Revision: 272141 URL: http://llvm.org/viewvc/llvm-project?rev=272141=rev Log: [AVX512] Emit select instruction instead of using x86 specific instrinsics. This will allow us to remove the x86 instrinics from the backend. Differential Revision:

[PATCH] D21132: [include-fixer] Keep dot dot in SymbolInfo file paths.

hokein created this revision. hokein added reviewers: bkramer, ioeric. hokein added a subscriber: cfe-commits. Currently, removing dot dot in header's path doesn't make include-fixer minimize path correctly in some cases, for example, specify a relative search path based on the build

[PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

danielmarjamaki created this revision. danielmarjamaki added a reviewer: alexfh. danielmarjamaki added a subscriber: cfe-commits. danielmarjamaki set the repository for this revision to rL LLVM. this is a new check for clang-tidy that diagnoses when it see unusual array index syntax. there is

Re: [PATCH] D20428: Tracking exception specification source locations

aaron.ballman added a comment. One thing this patch does not do but needs to is fix `ASTContext::adjustExceptionSpec()` (Thanks to Don Hinton for pointing this out off-list!), however, I am at a bit of a loss for how best to rebuild the type location. Would it be correct to call

Re: [PATCH] D15926: Do not print certain warnings when input is a header.

erikjv updated this revision to Diff 60023. http://reviews.llvm.org/D15926 Files: include/clang/Basic/LangOptions.h lib/Frontend/CompilerInvocation.cpp lib/Lex/PPDirectives.cpp lib/Lex/PPMacroExpansion.cpp lib/Lex/Pragma.cpp test/Preprocessor/header_is_main_file.c Index:

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. Ping? Thanks a lot. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272136 - Correcting a typo in a comment; NFC.

Author: aaronballman Date: Wed Jun 8 07:33:18 2016 New Revision: 272136 URL: http://llvm.org/viewvc/llvm-project?rev=272136=rev Log: Correcting a typo in a comment; NFC. Modified: cfe/trunk/lib/Sema/TypeLocBuilder.h Modified: cfe/trunk/lib/Sema/TypeLocBuilder.h URL:

[clang-tools-extra] r272132 - [include-fixer] do not add enum forward declaration into symbol index table.

Author: ioeric Date: Wed Jun 8 07:13:14 2016 New Revision: 272132 URL: http://llvm.org/viewvc/llvm-project?rev=272132=rev Log: [include-fixer] do not add enum forward declaration into symbol index table. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/FindAllSymbols.cpp

  1   2   >