Re: r274110 - [AVX512] Zero extend cmp intrinsic return value.

This change codgens to something really awful now. Can you take a look? .section __TEXT,__text,regular,pure_instructions .section __TEXT,__literal8,8byte_literals .p2align 3 LCPI0_0: .quad -1 .section __TEXT,__const .p2align 6 LCPI0_1: .quad 0 .quad 1 .quad 2 .quad 3 .quad 8 .quad 8 .quad 8 .quad

r274425 - [X86] Replace 128-bit and 256 masked vpermilps/vpermilpd builtins with native IR.

Author: ctopper Date: Sat Jul 2 00:36:43 2016 New Revision: 274425 URL: http://llvm.org/viewvc/llvm-project?rev=274425=rev Log: [X86] Replace 128-bit and 256 masked vpermilps/vpermilpd builtins with native IR. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

[libcxx] r274424 - Add unordered_map::insert benchmark test and rename file

Author: ericwf Date: Sat Jul 2 00:30:54 2016 New Revision: 274424 URL: http://llvm.org/viewvc/llvm-project?rev=274424=rev Log: Add unordered_map::insert benchmark test and rename file Added: libcxx/trunk/benchmarks/unordered_set_operations.bench.cpp Removed:

[libcxx] r274423 - Improve performance of unordered_set::find by 45%. Add benchmarks.

Author: ericwf Date: Sat Jul 2 00:19:59 2016 New Revision: 274423 URL: http://llvm.org/viewvc/llvm-project?rev=274423=rev Log: Improve performance of unordered_set::find by 45%. Add benchmarks. This patch improves the performance of unordered_set's find by 45% when the value exists within the

Re: [PATCH] D21946: Subject: [PATCH] [Driver] fix windows SDK detect

comicfans44 added a comment. neither did I commited to LLVM ... so I'll wait. http://reviews.llvm.org/D21946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r274422 - Handle std::get(...) for std::tuple<>

Author: ericwf Date: Fri Jul 1 22:46:08 2016 New Revision: 274422 URL: http://llvm.org/viewvc/llvm-project?rev=274422=rev Log: Handle std::get(...) for std::tuple<> Modified: libcxx/trunk/include/tuple libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.elem/tuple.by.type.fail.cpp

Re: [PATCH] D21946: Subject: [PATCH] [Driver] fix windows SDK detect

zturner added a comment. In http://reviews.llvm.org/D21946#473070, @comicfans44 wrote: > I've not commited to cfe before, so I think I havn't commit access permission. If you've committed anywhere in LLVM, you should have commit access to cfe. Feel free to give it a try, as I won't be able

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added inline comments. Comment at: include/clang/Basic/TargetInfo.h:585 @@ +584,3 @@ + StringRef + TargetInfo::getNormalizedGCCRegisterName(StringRef Name, + bool ReturnCannonical = false) const; This gives

[libcxx] r274414 - Cleanup SFINAE in tuple, and add tests for reference assignment

Author: ericwf Date: Fri Jul 1 20:25:46 2016 New Revision: 274414 URL: http://llvm.org/viewvc/llvm-project?rev=274414=rev Log: Cleanup SFINAE in tuple, and add tests for reference assignment Modified: libcxx/trunk/include/__tuple

[libcxx] r274413 - Make tuple_constructible and family lazy again.

Author: ericwf Date: Fri Jul 1 19:58:17 2016 New Revision: 274413 URL: http://llvm.org/viewvc/llvm-project?rev=274413=rev Log: Make tuple_constructible and family lazy again. Added: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/test_lazy_sfinae.pass.cpp Modified:

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

sfantao updated this revision to Diff 62591. sfantao added a comment. - Fix format. http://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Tool.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/Tool.cpp lib/Driver/Tools.cpp

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 62590. sfantao added a comment. - Start static function name with caps. http://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao updated this revision to Diff 62589. sfantao added a comment. - Rebase http://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h include/clang/Driver/Types.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/Types.cpp

Re: [PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

sfantao updated this revision to Diff 62587. sfantao added a comment. - Rebase http://reviews.llvm.org/D21852 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

sfantao updated this revision to Diff 62584. sfantao added a comment. - Start staic function name with caps. http://reviews.llvm.org/D21851 Files: test/Driver/clang-offload-bundler.c tools/clang-offload-bundler/ClangOffloadBundler.cpp Index:

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

sfantao updated this revision to Diff 62583. sfantao added a comment. - Rebase. http://reviews.llvm.org/D21848 Files: include/clang/Driver/Compilation.h include/clang/Driver/ToolChain.h lib/Driver/Compilation.cpp lib/Driver/Driver.cpp lib/Driver/MSVCToolChain.cpp

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao updated this revision to Diff 62582. sfantao added a comment. - Rebase. http://reviews.llvm.org/D21847 Files: lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

r274409 - Add TargetInfo for 32-bit and 64-bit RenderScript

Author: pirama Date: Fri Jul 1 19:05:42 2016 New Revision: 274409 URL: http://llvm.org/viewvc/llvm-project?rev=274409=rev Log: Add TargetInfo for 32-bit and 64-bit RenderScript Summary: The TargetInfo for 'renderscript32' and 'renderscript64' ArchTypes are subclasses of ARMleTargetInfo and

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

This revision was automatically updated to reflect the committed changes. Closed by commit rL274409: Add TargetInfo for 32-bit and 64-bit RenderScript (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21334?vs=62520=62581#toc Repository: rL LLVM

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao updated this revision to Diff 62580. sfantao added a comment. - Rebase http://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c === ---

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

sfantao updated this revision to Diff 62577. sfantao added a comment. - Rebase http://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/Driver.h lib/Driver/Action.cpp lib/Driver/Driver.cpp

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

sfantao updated this revision to Diff 62575. sfantao added a comment. - Rebase http://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === ---

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao updated this revision to Diff 62573. sfantao added a comment. - Rebase http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === ---

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao updated this revision to Diff 62572. sfantao added a comment. - Rebase http://reviews.llvm.org/D18171 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp

[libcxx] r274408 - Add another workaround for C++17 inline variable ABI breakage.

Author: ericwf Date: Fri Jul 1 18:41:48 2016 New Revision: 274408 URL: http://llvm.org/viewvc/llvm-project?rev=274408=rev Log: Add another workaround for C++17 inline variable ABI breakage. Modified: libcxx/trunk/src/experimental/filesystem/path.cpp Modified:

Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

On Fri, Jul 1, 2016 at 4:37 PM, Eric Fiselier wrote: > The attribute is ignored unless it is placed on the in-class declaration > of the member. It has no effect when applied to the explicit definition. > Ugh, right, attributes added after the definition aren't well-treated. Seems

Re: [PATCH] D21871: [libcxx] [test] Make vector.bool/construct_default.pass.cpp more portable.

STL_MSFT abandoned this revision. STL_MSFT added a comment. Nah, they can totally be noexcept like the primary template. Usually we don't strengthen beyond the WP, but the wording is so clearly defective here, I'll go ahead and do this. No test changes necessary now.

[PATCH] D21946: Subject: [PATCH] [Driver] fix windows SDK detect

comicfans44 created this revision. comicfans44 added reviewers: zturner, majnemer. comicfans44 added a subscriber: cfe-commits. 1. readFullStringValue returns bool, should not compared with ERROR_SUCCESS 2. RegQueryValueExW string may contain null terminating char ,should be trimmed these leads

[libcxx] r274407 - Remove accidental change committed in r274403.

Author: ericwf Date: Fri Jul 1 18:31:55 2016 New Revision: 274407 URL: http://llvm.org/viewvc/llvm-project?rev=274407=rev Log: Remove accidental change committed in r274403. Modified: libcxx/trunk/src/chrono.cpp Modified: libcxx/trunk/src/chrono.cpp URL:

Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

The attribute is ignored unless it is placed on the in-class declaration of the member. It has no effect when applied to the explicit definition. I would rather keep the workaround internal than make the change in the headers. On Fri, Jul 1, 2016 at 5:34 PM, Richard Smith

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

sfantao updated this revision to Diff 62569. sfantao marked 2 inline comments as done. sfantao added a comment. - Change name of static function, format comments and remove \brief. http://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Tool.h

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

sfantao added a comment. Hi Alexey, thanks for the review! Comment at: include/clang/Driver/Tool.h:132-140 @@ -131,1 +131,11 @@ const char *LinkingOutput) const = 0; + /// ConstructJob - Construct jobs to perform the action \p JA, + /// writing to

Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

On Fri, Jul 1, 2016 at 4:22 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Jul 1 18:22:25 2016 > New Revision: 274403 > > URL: http://llvm.org/viewvc/llvm-project?rev=274403=rev > Log: > Work around ABI break caused by C++17 inline variables.

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

silvas added inline comments. Comment at: lib/Driver/Tools.cpp:3560 @@ +3559,3 @@ +if (PGOTrainArg->getOption().matches(options::OPT_fpgo_train_EQ)) { + if (StringRef(PGOTrainArg->getValue()) == "source-cfg") +CmdArgs.push_back("-fprofile-instrument=clang");

[libcxx] r274404 - Turn off ASAN's odr-violation diagnostics for now. See PR28391

Author: ericwf Date: Fri Jul 1 18:25:47 2016 New Revision: 274404 URL: http://llvm.org/viewvc/llvm-project?rev=274404=rev Log: Turn off ASAN's odr-violation diagnostics for now. See PR28391 Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py

[libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

Author: ericwf Date: Fri Jul 1 18:22:25 2016 New Revision: 274403 URL: http://llvm.org/viewvc/llvm-project?rev=274403=rev Log: Work around ABI break caused by C++17 inline variables. Modified: libcxx/trunk/src/chrono.cpp Modified: libcxx/trunk/src/chrono.cpp URL:

r274401 - [CodeView] Include MSVC style names for unnamed types

Author: majnemer Date: Fri Jul 1 18:12:54 2016 New Revision: 274401 URL: http://llvm.org/viewvc/llvm-project?rev=274401=rev Log: [CodeView] Include MSVC style names for unnamed types The CodeView printer expects to be able to generate fully qualified names from the debug info graph. This means

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 62567. sfantao added a comment. - Use StringRef instead of std::string, fix comments and mark class final. http://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao updated this revision to Diff 62565. sfantao added a comment. - Add Ctor dropped by mistake in the previous diff. http://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h include/clang/Driver/Types.h lib/Driver/Action.cpp lib/Driver/Driver.cpp

Re: [PATCH] D21453: Add support for attribute "overallocated"

ahatanak updated this revision to Diff 62560. ahatanak added a comment. The new patch defines a new attribute "flexible_array", which gets attached to the last array member of a struct. I made changes to clang to treat arrays marked "flexible_array" as C99's flexible array members where it

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

timshen added a comment. ...and r274396 to remove all of the checks for symbolic labels, which are not generated by release builds, nor controlled by a runtime-flag. Repository: rL LLVM http://reviews.llvm.org/D20499 ___ cfe-commits mailing

r274396 - Removes CHECKs for symbolic label names (as Debug Clang will generate).

Author: timshen Date: Fri Jul 1 17:50:00 2016 New Revision: 274396 URL: http://llvm.org/viewvc/llvm-project?rev=274396=rev Log: Removes CHECKs for symbolic label names (as Debug Clang will generate). Differential Revision: http://reviews.llvm.org/D20499 Modified:

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/Driver/Action.cpp:133 @@ +132,3 @@ +/// we assume 'host'. +std::string Action::getOffloadKindName(OffloadKind Kind) { + switch (Kind) { ABataev wrote: > 1. Maybe it is enough to return

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

sfantao updated this revision to Diff 62561. sfantao marked 3 inline comments as done. sfantao added a comment. - Use StringRef instead of string and mark bundler tool as final. http://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao updated this revision to Diff 62558. sfantao marked 3 inline comments as done. sfantao added a comment. - Mark classes 'final' and set defalt initializers. http://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h include/clang/Driver/Types.h lib/Driver/Action.cpp

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: include/clang/Driver/Types.h:78 @@ +77,3 @@ + /// compilation phase is a preprocessor one. + bool isSrcFile(ID Id); + ABataev wrote: > 'const'? `isSrcFile` is not member of a class. It is

r274392 - C++14 init-capture: error out instead of crashing.

Author: mren Date: Fri Jul 1 17:27:16 2016 New Revision: 274392 URL: http://llvm.org/viewvc/llvm-project?rev=274392=rev Log: C++14 init-capture: error out instead of crashing. When we have template arguments, we have a function and a pattern, the variable in init-capture belongs to the pattern

Re: [PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

sfantao updated this revision to Diff 62553. sfantao added a comment. - Rebase. - Fix format. http://reviews.llvm.org/D21852 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp test/Driver/openmp-offload.c Index:

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:345 @@ +344,3 @@ + /// return the triple by reference. + bool isOffloadSection(SectionRef CurSection, StringRef ) { +StringRef SectionName;

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

sfantao updated this revision to Diff 62550. sfantao marked 6 inline comments as done. sfantao added a comment. - Remove \brief and return errors instead of crashing when temporary tiles can't be created. http://reviews.llvm.org/D21851 Files: test/Driver/clang-offload-bundler.c

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

echristo added a comment. In http://reviews.llvm.org/D21334#472548, @pirama wrote: > Reformatted with clang-format for just the parts I added. I ignored > clang-format-suggested changes in code unrelated to this patch. Yep. > Is there a policy or practise on periodically fixing

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

timshen added a comment. Also committed r274387 to remove unnecessary CHECks. It seems to cause problems in certain platforms. Repository: rL LLVM http://reviews.llvm.org/D20499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r274387 - Remove unncessary CHECKs from r274385

Author: timshen Date: Fri Jul 1 16:16:58 2016 New Revision: 274387 URL: http://llvm.org/viewvc/llvm-project?rev=274387=rev Log: Remove unncessary CHECKs from r274385 Modified: cfe/trunk/test/CodeGen/temporary-lifetime.cpp Modified: cfe/trunk/test/CodeGen/temporary-lifetime.cpp URL:

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

davidxl added inline comments. Comment at: include/clang/Driver/Options.td:507 @@ +506,3 @@ +Group, Flags<[DriverOption]>, MetaVarName<"">, +HelpText<"Set to be the default profile output file (overridden by LLVM_PROFILE_FILE env var)">; +def fpgo_apply_EQ :

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

This revision was automatically updated to reflect the committed changes. timshen marked an inline comment as done. Closed by commit rL274385: [Temporary, Lifetime] Add lifetime marks for temporaries (authored by timshen). Changed prior to commit:

r274385 - [Temporary, Lifetime] Add lifetime marks for temporaries

Author: timshen Date: Fri Jul 1 16:08:47 2016 New Revision: 274385 URL: http://llvm.org/viewvc/llvm-project?rev=274385=rev Log: [Temporary, Lifetime] Add lifetime marks for temporaries With all MaterializeTemporaryExprs coming with a ExprWithCleanups, it's easy to add correct lifetime.end marks

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao updated this revision to Diff 62540. sfantao added a comment. - Remove \brief when not needed. http://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundler.c tools/CMakeLists.txt tools/clang-offload-bundler/CMakeLists.txt

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: test/Driver/clang-offload-bundler.c:14 @@ +13,3 @@ +// +// RUN: touch %t.empty + ABataev wrote: > Hmm, will it work on Windows? Maybe it is better just to add an empty test > file? I see

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao updated this revision to Diff 62538. sfantao marked 9 inline comments as done. sfantao added a comment. - Merge branch 'master' into patch-D13909 - Remove unecessary returns and fix iterators. http://reviews.llvm.org/D13909 Files: test/CMakeLists.txt

[PATCH] D21936: [clang-tidy] UnnecessaryValueParamCheck - only warn for virtual methods

flx created this revision. flx added reviewers: alexfh, sbenza. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. As changing virtual methods could break method overrides disable applying the fix and just warn. Repository: rL LLVM

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

jvesely added a subscriber: jvesely. Comment at: cfe/trunk/include/clang/Driver/Options.td:381 @@ +380,3 @@ +def cl_unsafe_math_optimizations : Flag<["-"], "cl-unsafe-math-optimizations">, Group, Flags<[CC1Option]>, + HelpText<"OpenCL only. Allow unsafe floating-point

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev added a comment. In http://reviews.llvm.org/D21823#470516, @xur wrote: > (1) It seems the original options of -fprofile-instr-generate and > -fprofile-instr-use will be kept. Is so, what is the guideline to use these > two sets of options. Sorry I'm not sure I understand what you're

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated this revision to Diff 62527. jakev added a comment. Don't allow `-fpgo-train` and `-fpgo-apply` together. Add `-fpgo-train-default-output=*` to set the default profile output file. Repository: rL LLVM http://reviews.llvm.org/D21823 Files: include/clang/Driver/Options.td

Re: [PATCH] D21706: [libcxx] refactor for throw

weimingz added inline comments. Comment at: include/exception:262 @@ -261,3 +261,3 @@ _LIBCPP_INLINE_VISIBILITY -inline void __libcpp_throw(_Exception const& __e) { +inline __attribute__((noreturn)) void __libcpp_throw(_Exception const& __e) { #ifndef _LIBCPP_NO_EXCEPTIONS

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added a reviewer: rsmith. Prazek added a comment. Adding Richard who was working on standard defect report that deprived sense of this check. There are some corner cases that are not in the standard and probably won't be handled in the future that we could handle still.

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao added a comment. In http://reviews.llvm.org/D18172#472152, @jlebar wrote: > Yeah, I'd say that in the absence of a rule, consistency with surrounding > code is king. Otherwise we're sending a message when we don't mean to be. > > I'm not at my machine, but my recollection is that most

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

This revision was automatically updated to reflect the committed changes. Closed by commit rL274380: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const… (authored by flx). Changed prior to commit: http://reviews.llvm.org/D20277?vs=62524=62530#toc Repository: rL LLVM

[clang-tools-extra] r274380 - [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

Author: flx Date: Fri Jul 1 15:12:15 2016 New Revision: 274380 URL: http://llvm.org/viewvc/llvm-project?rev=274380=rev Log: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved. Summary: Make check more useful in the following two cases: The

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: include/clang/Driver/Compilation.h:73 @@ +72,3 @@ + /// architecture, and device offload kind. + struct TCArgsKey { +const ToolChain *TC; ABataev wrote: > 1. 'final' > 2. default

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

sfantao updated this revision to Diff 62528. sfantao marked 3 inline comments as done. sfantao added a comment. - Add default initializers to toolchain arguments key and use range based iterator in Dtor. http://reviews.llvm.org/D21848 Files: include/clang/Driver/Compilation.h

Re: [PATCH] D21706: [libcxx] refactor for throw

mclow.lists added a comment. This is getting close. A nit, and a couple of non-trivial comments. Comment at: include/exception:262 @@ -261,3 +261,3 @@ _LIBCPP_INLINE_VISIBILITY -inline void __libcpp_throw(_Exception const& __e) { +inline __attribute__((noreturn)) void

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao updated this revision to Diff 62525. sfantao added a comment. - Remove \brief from one comment. http://reviews.llvm.org/D21847 Files: lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

r274379 - [Driver] Delete some dead code (NFC)

Author: vedantk Date: Fri Jul 1 14:41:20 2016 New Revision: 274379 URL: http://llvm.org/viewvc/llvm-project?rev=274379=rev Log: [Driver] Delete some dead code (NFC) Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

flx added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:34 @@ -29,1 +33,3 @@ +template bool isSetDifferenceEmpty(const S , const S ) { + for (const auto : S1) alexfh wrote: > +1 to `isSubset`. And please add a comment

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

flx updated this revision to Diff 62524. flx marked 5 inline comments as done. flx added a comment. Thanks for the review. I addressed all remaining comments. http://reviews.llvm.org/D20277 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

jlebar added a comment. Hi, Alexy. Would you mind not asking for 'final' in additional reviews until we've resolved this thread elsewhere? Feel free to find me on IRC if you want to talk about it synchronously. Thanks! http://reviews.llvm.org/D21845

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao added a comment. Hi Alexey, Thanks for the review! Addressed the comments in the new diff. http://reviews.llvm.org/D21847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao updated this revision to Diff 62523. sfantao marked an inline comment as done. sfantao added a comment. - Use llvm::sys::path::replace_extension to deal with the extension of the linker script. http://reviews.llvm.org/D21847 Files: lib/Driver/Driver.cpp lib/Driver/Tools.cpp

r274378 - [libclang] Sync-up the way top-level decls in an ASTUnit are handled with how decls in a DeclContext are handled.

Author: akirtzidis Date: Fri Jul 1 14:10:54 2016 New Revision: 274378 URL: http://llvm.org/viewvc/llvm-project?rev=274378=rev Log: [libclang] Sync-up the way top-level decls in an ASTUnit are handled with how decls in a DeclContext are handled. rdar://19775013 Modified:

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama updated this revision to Diff 62520. pirama added a comment. Reformatted with clang-format for just the parts I added. I ignored clang-format-suggested changes in code unrelated to this patch. Is there a policy or practise on periodically fixing format-related issues? If not, I can

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao added a comment. Hi Alexey, Thanks for the review! Addressed your comment in the new diff. Also removed `\brief` from the comments. http://reviews.llvm.org/D21845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao updated this revision to Diff 62519. sfantao marked an inline comment as done. sfantao added a comment. - Mark class as final and remove \brief from comments. http://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp test/Driver/openmp-offload.c Index:

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

sfantao updated this revision to Diff 62518. sfantao added a comment. - Add code dropped accidently in the previous diff. http://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/Driver.h lib/Driver/Action.cpp

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/Driver/Driver.cpp:2416 @@ +2415,3 @@ + /// be collapsed with it. + struct JobActionInfoTy { +// \brief The action this info refers to. ABataev wrote: > I think this can be marked

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/Driver/Driver.cpp:464-468 @@ +463,7 @@ + RuntimeName = A->getValue(); +HasCompatibleOpenMP = llvm::StringSwitch(RuntimeName) + .Case("libomp", true) +

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

sfantao updated this revision to Diff 62516. sfantao marked an inline comment as done. sfantao added a comment. - Check the OpenMP flags only in one place for purposes of obtaining the runtime kind. http://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td

Re: [cfe-dev] RFC: Default language standard mode policy

On Thu, Jun 30, 2016 at 01:41:00PM -0700, Richard Smith wrote: > On Thu, Jun 30, 2016 at 2:02 AM, David Chisnall > wrote: > > > On 29 Jun 2016, at 23:07, Richard Smith via cfe-dev < > > cfe-...@lists.llvm.org> wrote: > > > > > > Yes, those are real problems, but

Re: [PATCH] D21706: [libcxx] refactor for throw

weimingz updated this revision to Diff 62515. weimingz marked 5 inline comments as done. weimingz added a comment. fix issues per Noel's suggestion http://reviews.llvm.org/D21706 Files: include/__functional_03 include/__locale include/array include/bitset include/complex

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

arsenm closed this revision. arsenm added a comment. r274370 http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274370 - Emit more intrinsics for builtin functions

Author: arsenm Date: Fri Jul 1 12:38:14 2016 New Revision: 274370 URL: http://llvm.org/viewvc/llvm-project?rev=274370=rev Log: Emit more intrinsics for builtin functions This is important for building libclc. Since r273039 tests are failing due to now emitting calls to these functions instead

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

sfantao updated this revision to Diff 62507. sfantao marked 7 inline comments as done. sfantao added a comment. - Fix comments. - Mark functions properly with const and static. - Remove \brief. http://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

john.brawn added a comment. Commit r274365 should make extract_symbols.py work with Python 3. Repository: rL LLVM http://reviews.llvm.org/D21385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao updated this revision to Diff 62506. sfantao added a comment. - Use double instead of triple slash in one comment. http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

r274359 - Revert r274348 and r274349 until the Windows failures are fixed.

Author: vvassilev Date: Fri Jul 1 11:07:57 2016 New Revision: 274359 URL: http://llvm.org/viewvc/llvm-project?rev=274359=rev Log: Revert r274348 and r274349 until the Windows failures are fixed. Removed: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Modified:

Re: [PATCH] D21619: [Sema] Implement C++14's DR1579: Prefer moving id-expression out of functions

erik.pilkington added a comment. Yes, also PR28096. I marked them as being duplicates on the bugzilla. Repository: rL LLVM http://reviews.llvm.org/D21619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

scanon added a comment. I agree with Marshall. Aside from the points he raises, this approach looks fine. http://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r274356 - Driver: support -L for MSVC toolchain under the GNU driver

Author: compnerd Date: Fri Jul 1 10:36:31 2016 New Revision: 274356 URL: http://llvm.org/viewvc/llvm-project?rev=274356=rev Log: Driver: support -L for MSVC toolchain under the GNU driver When not using clang in the CL emulation mode, honour the -L flags as additional library paths to pass to

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

john.brawn added a comment. > http://clang.llvm.org/get_started.html doesn't specify a version of Python, > the LLVM webpage only say >= 2.7, and I ran the tests without any problem > with Python 3 (but maybe some tests were automatically skipped?). Also, > Python is also marked as only

RE: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"

With some digging I worked out at least part of the history. It's not that we care about PATH per se; the test is making sure that even if you don't have a linker in the package, there's still a file with the right name for clang to find in a place that it would (eventually) look. If you *do*

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

tejohnson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:758 @@ +757,3 @@ + + lto::Config Conf; + if (Error E = thinBackend( Can we pass along -save-temps here (i.e. invoke Conf.addSaveTemps)? http://reviews.llvm.org/D21545

  1   2   >