Re: [PATCH] D22384: [OpenMP] add check for both simdlen and safelen clauses specified

This revision was automatically updated to reflect the committed changes. Closed by commit rL275529: [OpenMP] add check for both simdlen and safelen clauses specified (authored by kli). Changed prior to commit: https://reviews.llvm.org/D22384?vs=64048=64087#toc Repository: rL LLVM

Re: [PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D22248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

hfinkel added a comment. Ping. https://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

doug.gregor added a comment. A bunch of comments above. This needs much more extensive testing, because there are numerous paths through the ternary operator code and the results need to be symmetric. Comment at: lib/Sema/SemaExpr.cpp:7007 @@ +7006,3 @@ +/// expression.

Re: [PATCH] D21954: [PM] Add some internal options for testing out the new PM.

chandlerc added a comment. I'd like someone more active on the Clang side to comment about this, but here is my 2 cents... It seems like it'd be nice to not populate or run or otherwise build up the legacy pass managers when using this option. I guess I would expect something to more split

Re: [PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

doug.gregor added a comment. I think this check should go into SemaChecking.cpp https://reviews.llvm.org/D22391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

Hi Paul, Could you provide a little bit more info about diagnostic you see? Maybe the tests just need to be fixed Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 15.07.2016 2:09, Paul Robinson пишет: > probinson added a subscriber: probinson. > probinson added a

Re: [PATCH] D22384: [OpenMP] add check for both simdlen and safelen clauses specified

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

ahatanak updated this revision to Diff 64077. ahatanak added a comment. Remove unused variable. https://reviews.llvm.org/D22392 Files: lib/Sema/SemaExpr.cpp test/Sema/nullability.c Index: test/Sema/nullability.c === ---

Re: [PATCH] D21954: [PM] Add some internal options for testing out the new PM.

silvas added a comment. Ping. https://reviews.llvm.org/D21954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

ahatanak created this revision. ahatanak added a reviewer: doug.gregor. ahatanak added a subscriber: cfe-commits. Currently clang issues a warning when the following code using a shorthand form of the conditional operator is compiled: $ cat test1.c ``` void foo() { int * _Nullable p0; int *

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

hfinkel added a comment. In https://reviews.llvm.org/D19544#484439, @spatel wrote: > Hi Matt - > > This looks like the right first step in the path that Hal suggested, except I > think we need a test case for each function that you want to enable. Please > see

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275507: Frontend: Simplify ownership model for clang's output streams. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D21537?vs=61317=64071#toc Repository: rL LLVM

r275507 - Frontend: Simplify ownership model for clang's output streams.

Author: pcc Date: Thu Jul 14 19:55:40 2016 New Revision: 275507 URL: http://llvm.org/viewvc/llvm-project?rev=275507=rev Log: Frontend: Simplify ownership model for clang's output streams. This changes the CompilerInstance::createOutputFile function to return a std::unique_ptr, rather than an

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

ahatanak created this revision. ahatanak added a reviewer: doug.gregor. ahatanak added a subscriber: cfe-commits. This patch makes clang issue a warning when a null constant is used in a context where a non null expression is expected. For example: ``` int * _Nonnull p0 = 0; // warning expected

[libcxxabi] r275505 - libc++abi: add a top level option for using CompilerRT

Author: compnerd Date: Thu Jul 14 19:49:42 2016 New Revision: 275505 URL: http://llvm.org/viewvc/llvm-project?rev=275505=rev Log: libc++abi: add a top level option for using CompilerRT Add an option to opt into compiler-rt instead of libgcc. This option defaults to OFF to avoid a behaviour

Re: r275417 - Diagnose taking address and reference binding of packed members

OK, actually, GCC is doing something a lot more clever here. Here's what seems to really be going on: Packed members are modeled somewhat like bitfield members: a packed member lvalue is a different kind of lvalue to which a reference cannot be bound (like a bitfield). An attempt to bind a const

Re: r275417 - Diagnose taking address and reference binding of packed members

It appears that GCC accepts that case. More generally, it looks like GCC suppresses the warning when the reference is a function parameter (any function, not just a copy constructor or similar). I'm not sure if that's an intentional feature or a bug, but it should be pretty easy for us to be

Re: [PATCH] D18510: [cxx1z-constexpr-lambda] Make conversion function constexpr

rsmith added a comment. I don't see how this approach can work; the fact that we happened to ask the expression evaluator to evaluate an expression is not sufficient reason for us to issue this warning. For instance: auto a = []{}; void (*p)() = a; ... will ask the evaluator to evaluate

Re: r275417 - Diagnose taking address and reference binding of packed members

I wonder if GCC accepts this: In file included from ../../net/tools/quic/quic_epoll_clock_test.cc:7: In file included from ../../net/tools/quic/test_tools/mock_epoll_server.h:16: In file included from ../../net/tools/epoll_server/epoll_server.h:41:

Re: [PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

bruening added inline comments. Comment at: docs/CSI.rst:30 @@ +29,3 @@ +To create a CSI tool, add ``#include `` at the top of the tool source +and implement function bodies for the hooks relevant to the tool. + Are there any constraints on what libraries the

Re: r275417 - Diagnose taking address and reference binding of packed members

On Thu, Jul 14, 2016 at 3:52 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Why did we upgrade the unaligned reference binding from a warning to an > error? That will make it hard to roll this change out across many codebases. > GCC has given an error on this since

Re: r275464 - Attempt to workaround Windows bots after my previous commit

Thank you. On Thu, Jul 14, 2016 at 4:00 PM Ben Langmuir wrote: > Thanks! it was actually my earlier commit that broke it, it just didn’t > turn up until a second build happened. > > Fixed in r275496 > > > > On Jul 14, 2016, at 2:55 PM, Vitaly Buka

Re: r275464 - Attempt to workaround Windows bots after my previous commit

Thanks! it was actually my earlier commit that broke it, it just didn’t turn up until a second build happened. Fixed in r275496 > On Jul 14, 2016, at 2:55 PM, Vitaly Buka wrote: > > The patch breaks this test: >

r275496 - Remove the new module cache from the index-module test

Author: benlangmuir Date: Thu Jul 14 17:53:23 2016 New Revision: 275496 URL: http://llvm.org/viewvc/llvm-project?rev=275496=rev Log: Remove the new module cache from the index-module test Forgot to add the new cache to the `rm -rf` line. This broke some bots when trying to load a module built

Re: r275417 - Diagnose taking address and reference binding of packed members

Why did we upgrade the unaligned reference binding from a warning to an error? That will make it hard to roll this change out across many codebases. On Thu, Jul 14, 2016 at 7:10 AM, Roger Ferrer Ibanez via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rogfer01 > Date: Thu Jul 14

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev added inline comments. Comment at: test/Profile/gcc-flag-compatibility.c:10 @@ -9,3 +9,3 @@ -// Check that -fprofile-generate uses the runtime default profile file. +// Check that -fprofile-generate overrides the default profraw. // RUN: %clang %s -c -S -o - -emit-llvm

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated this revision to Diff 64056. jakev marked 3 inline comments as done. jakev added a comment. Add a couple notes to the docs and a fixme to a test. We can more thoroughly fix up the docs in a separate patch. Repository: rL LLVM https://reviews.llvm.org/D21823 Files:

Re: [PATCH] D22190: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

rsmith added a comment. It's not meaningful to ask whether a value-dependent expression is an integral constant expression. The answer is not knowable, so the function asserting doesn't seem unreasonable. Any value we returned from that function would be a lie. Repository: rL LLVM

Re: [PATCH] D22113: C does not have inline variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL275493: C does not have inline variables. (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D22113?vs=64053=64057#toc Repository: rL LLVM https://reviews.llvm.org/D22113

r275493 - C does not have inline variables.

Author: probinson Date: Thu Jul 14 17:22:58 2016 New Revision: 275493 URL: http://llvm.org/viewvc/llvm-project?rev=275493=rev Log: C does not have inline variables. Add a few missing tests for related C++ diagnostics. Differential Revision: http://reviews.llvm.org/D22113 Modified:

Re: [PATCH] D22113: C does not have inline variables

rsmith accepted this revision. rsmith added a comment. Thanks! https://reviews.llvm.org/D22113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

dcoughlin added a comment. Other than adding expected notes for the path notes to the test, this looks good to me. Thanks Ádám! Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1698 @@ +1697,3 @@ +PathDiagnosticPiece * +CXXSelfAssignmentBRVisitor::VisitNode(const

r275490 - Add test inputs missed by r275481.

Author: rsmith Date: Thu Jul 14 17:15:06 2016 New Revision: 275490 URL: http://llvm.org/viewvc/llvm-project?rev=275490=rev Log: Add test inputs missed by r275481. Added: cfe/trunk/test/Modules/Inputs/unused-global-init/ cfe/trunk/test/Modules/Inputs/unused-global-init/init.h

Re: [PATCH] D22113: C does not have inline variables

probinson updated this revision to Diff 64053. probinson marked an inline comment as done. probinson added a comment. Reorder the checks. I didn't see any tests for the adjacent (C++) diagnostics so I added some. https://reviews.llvm.org/D22113 Files: lib/Sema/SemaDecl.cpp

Re: [PATCH] D22113: C does not have inline variables

probinson marked an inline comment as done. Comment at: lib/Sema/SemaDecl.cpp:6189-6191 @@ -6188,2 +6188,5 @@ << FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc()); +} else if (!getLangOpts().CPlusPlus) { + Diag(D.getDeclSpec().getInlineSpecLoc(),

r275481 - [modules] Don't pass interesting decls to the consumer for a module file that's

Author: rsmith Date: Thu Jul 14 16:50:09 2016 New Revision: 275481 URL: http://llvm.org/viewvc/llvm-project?rev=275481=rev Log: [modules] Don't pass interesting decls to the consumer for a module file that's passed on the command line but never actually used. We consider a (top-level) module to

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yeah, I think this makes sense on balance, even though it does create a weird situation for the `ASTPrinter` case, where we don't really want to transfer ownership of the stream.

Re: r275464 - Attempt to workaround Windows bots after my previous commit

The patch breaks this test: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/14659/steps/check-clang%20msan/logs/stdio On Thu, Jul 14, 2016 at 1:16 PM Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: benlangmuir > Date: Thu Jul 14 15:08:43 2016 >

[PATCH] D22384: [OpenMP] add check for both simdlen and safelen clauses specified

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel. kkwli0 added a subscriber: cfe-commits. This patch adds the check for specifying both simdlen and safelen clauses on the 'distribute simd' or 'distribute parallel for simd' constructs.

Re: r275417 - Diagnose taking address and reference binding of packed members

I mean clang's diagnostic could say this too. For example, it could have a note pointing at the attribute(packed) saying "struct alignment set to 1 here" or some such. On Thu, Jul 14, 2016 at 5:25 PM, Roger Ferrer Ibanez < roger.ferreriba...@arm.com> wrote: > Hi Nico, > > > yes, it should be

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: lib/AST/ASTImporter.cpp:2253-2254 @@ +2252,4 @@ + return nullptr; + } + else { +ToRequiresClause = nullptr; `else` on same line as `}` please.

Re: r275417 - Diagnose taking address and reference binding of packed members

Hi Nico, yes, it should be clearly stated in the documentation. I will try to find some time to contribute a change in the docs. I forgot that fact in my first answer to your original question. So, I think that the warning should fire in this case. Actually, I analysed precisely this case

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

mehdi_amini accepted this revision. mehdi_amini added a comment. (I didn't mark it as accepted because Teresa did, but in case you're waiting for me, don't) https://reviews.llvm.org/D21545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

pcc marked an inline comment as done. pcc added a comment. https://reviews.llvm.org/D21545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

pcc updated this revision to Diff 64043. pcc added a comment. - Add a FIXME https://reviews.llvm.org/D21545 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CMakeLists.txt Index: lib/CodeGen/CMakeLists.txt === ---

Re: r275417 - Diagnose taking address and reference binding of packed members

On Thu, Jul 14, 2016 at 10:15 AM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > this fires on (at least) usrsctplib [1]: > > FAILED: obj/third_party/usrsctp/usrsctp/sctp_input.o > ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:1708:15: > error:

Re: [PATCH] D22069: clang-tidy modernize-loop-convert: preserve type of alias declaration (bug 28341)

mgehre added a comment. I additionally have run the check on blender and ITK and the assert did not fire. https://reviews.llvm.org/D22069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22381: cppcoreguidelines-pro-bounds-constant-array-index: ignore implicit constructor

mgehre created this revision. mgehre added reviewers: alexfh, aaron.ballman. mgehre added a subscriber: cfe-commits. Herald added subscribers: nemanjai, aemerson. The code struct A { int x[3]; }; gets an compiler-generated copy constructor that uses ArraySubscriptExpr (see below).

r275466 - [arcmt/objcmt] Fix ParentMap crash with invalid code.

Author: akirtzidis Date: Thu Jul 14 15:21:16 2016 New Revision: 275466 URL: http://llvm.org/viewvc/llvm-project?rev=275466=rev Log: [arcmt/objcmt] Fix ParentMap crash with invalid code. rdar://22489560 Added: cfe/trunk/test/ARCMT/objcmt-invalid-code.mm

Re: r275417 - Diagnose taking address and reference binding of packed members

Hi Nico, it seems it may be necessary to take into account the actual offset of the field in such cases to avoid these kind of false positives. I reverted the change until I get a better solution. Thanks, Roger From: tha...@google.com

r275464 - Attempt to workaround Windows bots after my previous commit

Author: benlangmuir Date: Thu Jul 14 15:08:43 2016 New Revision: 275464 URL: http://llvm.org/viewvc/llvm-project?rev=275464=rev Log: Attempt to workaround Windows bots after my previous commit For some reason it seems the second invocation is getting DMOD_OTHER_H set to a path

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. Reverted. Repository: rL LLVM https://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r275462 - Reverting 275417

Author: rogfer01 Date: Thu Jul 14 15:05:30 2016 New Revision: 275462 URL: http://llvm.org/viewvc/llvm-project?rev=275462=rev Log: Reverting 275417 This change has triggered unexpected failures. Removed: cfe/trunk/test/Sema/address-packed-member-memops.c

Re: [PATCH] D22190: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL275461: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent… (authored by mgehre). Changed prior to commit: https://reviews.llvm.org/D22190?vs=63795=64030#toc Repository: rL

[clang-tools-extra] r275461 - cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

Author: mgehre Date: Thu Jul 14 15:00:48 2016 New Revision: 275461 URL: http://llvm.org/viewvc/llvm-project?rev=275461=rev Log: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode Summary: When the expression is value dependent,

Re: [PATCH] D20561: Warn when taking address of packed member

Yes I will revert this ASAP. Sorry for the fuss. From: Aaron Ballman Sent: 14 July 2016 19:30:58 To: reviews+d20561+public+af1fea8a731d8...@reviews.llvm.org Cc: Roger Ferrer Ibanez; Richard Smith; James Y Knight; Evgenii Stepanov;

r275460 - When importing classes and structs with anonymous structs, it is critical that

Author: spyffe Date: Thu Jul 14 14:53:44 2016 New Revision: 275460 URL: http://llvm.org/viewvc/llvm-project?rev=275460=rev Log: When importing classes and structs with anonymous structs, it is critical that distinct anonymous structs remain distinct despite having similar layout. This is already

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

tejohnson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:740 @@ +739,3 @@ + ComputeCrossModuleImportForModule(M->getModuleIdentifier(), *CombinedIndex, +ImportList); + mehdi_amini wrote: > This should go away

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos updated this revision to Diff 64027. https://reviews.llvm.org/D22237 Files: clang-rename/USRLocFinder.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rename/VirtualFunction.cpp === --- /dev/null +++

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos added a comment. Forgot to add asserts for main() in the testcase. https://reviews.llvm.org/D22237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22237: clang-rename: fix renaming member functions

vmiklos updated this revision to Diff 64025. https://reviews.llvm.org/D22237 Files: clang-rename/USRLocFinder.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rename/VirtualFunction.cpp === --- /dev/null +++

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:740 @@ +739,3 @@ + ComputeCrossModuleImportForModule(M->getModuleIdentifier(), *CombinedIndex, +ImportList); + This should go away at some point right?

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

pcc added a comment. Ping. https://reviews.llvm.org/D21537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

vsk updated this revision to Diff 64023. vsk added a comment. - Addressed Paul's comment: added a release note about this. - Rebased onto master to pick up an Xray change. https://reviews.llvm.org/D22290 Files: docs/ReleaseNotes.rst include/clang/Driver/Driver.h

r275454 - [index] Index system ImportDecls even when there is a DeclarationsOnly filter

Author: benlangmuir Date: Thu Jul 14 13:51:55 2016 New Revision: 275454 URL: http://llvm.org/viewvc/llvm-project?rev=275454=rev Log: [index] Index system ImportDecls even when there is a DeclarationsOnly filter Whether we call an ImportDecl a decl or a reference symbol role is somewhat academic,

Re: [PATCH] D20561: Warn when taking address of packed member

Roger, can you please revert? This seems to have caused some pain for our users, and it would be good to unblock them while deciding what to do about the issues. ~Aaron On Thu, Jul 14, 2016 at 2:19 PM, James Y Knight wrote: > jyknight added a comment. > > Regardless, I

Re: [PATCH] D21749: Changes related to new implementation of tooling::Replacements as class.

ioeric updated this revision to Diff 64015. ioeric added a comment. - merged with origin/master - Addressed reviewer's comments in the corresponding patch. https://reviews.llvm.org/D21749 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

Re: r275040 - [CodeGen] Treat imported static local variables as declarations

On Tue, Jul 12, 2016 at 3:51 PM David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Jul 12, 2016 at 2:55 PM, Robinson, Paul > wrote: > >> A declaration that gets used within the CU generally does get a >> debug-info description. >> > > It does

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

ioeric updated this revision to Diff 64016. ioeric marked 6 inline comments as done. ioeric added a comment. - Merge branch 'master' of http://llvm.org/git/clang into replace - Addressed reviewer's comments. https://reviews.llvm.org/D21748 Files: include/clang/Tooling/Core/Replacement.h

Re: [PATCH] D20561: Warn when taking address of packed member

jyknight added a comment. Regardless, I think this should not have added a new un-disableable error, but instead only a default-on warning. The ""binding reference to packed member" error is firing on some of our code, and even if it's not a false-positive, it should be possible to disable it

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

spatel added a comment. Hi Matt - This looks like the right first step in the path that Hal suggested, except I think we need a test case for each function that you want to enable. Please see test/Transforms/LoopVectorize/X86/veclib-calls.ll as a reference for how to do that.

Re: [PATCH] D20561: Warn when taking address of packed member

jyknight added a subscriber: jyknight. jyknight added a comment. This seems to trigger even for the implicitly generated copier of a packed struct. E.g. #include void copyit(epoll_event, const epoll_event ) { out = in; } Is that as intended? Repository: rL LLVM

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

mmasten added a comment. Hello all, Just wanted to see if you guys have some time to review. Thanks, Matt https://reviews.llvm.org/D19544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22351: [include-fixer] Move cursor to #include line in vim after inserting a missing header.

hokein added a comment. +Daniel who suggests this feature ;) https://reviews.llvm.org/D22351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno added a comment. Ping! https://reviews.llvm.org/D22248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r275440 - Despite there being an option, it seems that Sphinx has decided that "=123" is part of the option directive name, and so having "=0" in the option tag is problematic. Since the option tag is

Author: aaronballman Date: Thu Jul 14 12:15:06 2016 New Revision: 275440 URL: http://llvm.org/viewvc/llvm-project?rev=275440=rev Log: Despite there being an option, it seems that Sphinx has decided that "=123" is part of the option directive name, and so having "=0" in the option tag is

Re: [PATCH] D22351: [include-fixer] Move cursor to #include line in vim after inserting a missing header.

hokein updated this revision to Diff 64004. hokein added a comment. Add an option to make move-cursor configurable. https://reviews.llvm.org/D22351 Files: include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool/clang-include-fixer.py

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

probinson added a subscriber: probinson. probinson added a comment. On the thread you suggested it would affect out-of-tree targets, so this probably deserves a release note? https://reviews.llvm.org/D22290 ___ cfe-commits mailing list

Re: r275417 - Diagnose taking address and reference binding of packed members

Hi, this fires on (at least) usrsctplib [1]: FAILED: obj/third_party/usrsctp/usrsctp/sctp_input.o ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:1708:15: error: taking address of packed member 'time_entered' of class or structure 'sctp_state_cookie' may result in an

Re: [PATCH] D22113: C does not have inline variables

majnemer added a subscriber: majnemer. Comment at: lib/Sema/SemaDecl.cpp:6189-6191 @@ -6188,2 +6188,5 @@ << FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc()); +} else if (!getLangOpts().CPlusPlus) { + Diag(D.getDeclSpec().getInlineSpecLoc(),

Re: [PATCH] D22113: C does not have inline variables

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I don't think we intended this to be an extension for C.

Re: [PATCH] D22113: C does not have inline variables

probinson added a comment. Ping. https://reviews.llvm.org/D22113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22367: [include-fixer] Always add as few as possible qualifiers to the unidentified symbol.

bkramer accepted this revision. This revision is now accepted and ready to land. Comment at: include-fixer/IncludeFixerContext.cpp:54 @@ -49,2 +53,3 @@ - return FullyQualifiedName; + auto FullySymbolQualifiers = SplitQualifiers(FullyQualifiedName); + auto ScopedQualifiers =

[PATCH] D22367: [include-fixer] Always add as few as possible qualifiers to the unidentified symbol.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D22367 Files: include-fixer/IncludeFixerContext.cpp unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixerTest.cpp

Re: [PATCH] D22270: [ASTImporter] Properly report the locations of anonymous structs declared as part of named fields

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Thanks, Manman Repository: rL LLVM https://reviews.llvm.org/D22270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

rmaprath added a comment. Update: Almost there, should be able to put it up for review tomorrow. Cheers, / Asiri https://reviews.llvm.org/D22292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22351: [include-fixer] Move cursor to #include line in vim after inserting a missing header.

klimek added a subscriber: klimek. klimek added a comment. +1 to not throwing users around by default. Can we make it configurable if folks want it? https://reviews.llvm.org/D22351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22351: [include-fixer] Move cursor to #include line in vim after inserting a missing header.

bkramer added a comment. I'm not entirely sure if jumping cursors are a good user interface. It will completely throw the user out of context, which is exactly what we want to avoid with include-fixer. https://reviews.llvm.org/D22351 ___

Re: [PATCH] D22359: [OpenCL] In test/Driver/opencl.cl, don't require name of Clang binary to contain "clang"

This revision was automatically updated to reflect the committed changes. Closed by commit rL275428: [OpenCL] In test/Driver/opencl.cl, don't require name of Clang binary to… (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D22359?vs=63976=63981#toc Repository: rL LLVM

r275428 - [OpenCL] In test/Driver/opencl.cl, don't require name of Clang binary to contain "clang"

Author: d0k Date: Thu Jul 14 10:06:57 2016 New Revision: 275428 URL: http://llvm.org/viewvc/llvm-project?rev=275428=rev Log: [OpenCL] In test/Driver/opencl.cl, don't require name of Clang binary to contain "clang" The test currently fails if the name of the Clang binary doesn't contain

[PATCH] D22359: [OpenCL] In test/Driver/opencl.cl, don't require name of Clang binary to contain "clang"

mboehme created this revision. mboehme added a reviewer: bkramer. mboehme added a subscriber: cfe-commits. The test currently fails if the name of the Clang binary doesn't contain "clang". This patch removes that requirement, as some environments may choose to run the test with a differently

Re: [PATCH] D22310: Make the test for fno-pch-timestamp compatible with read-only checkouts.

pgousseau closed this revision. pgousseau added a comment. Committed in https://reviews.llvm.org/rL275415 https://reviews.llvm.org/D22310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r275417 - Diagnose taking address and reference binding of packed members

Author: rogfer01 Date: Thu Jul 14 09:10:43 2016 New Revision: 275417 URL: http://llvm.org/viewvc/llvm-project?rev=275417=rev Log: Diagnose taking address and reference binding of packed members This patch implements PR#22821. Taking the address of a packed member is dangerous since the reduced

Re: [PATCH] D20561: Warn when taking address of packed member

This revision was automatically updated to reflect the committed changes. Closed by commit rL275417: Diagnose taking address and reference binding of packed members (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D20561?vs=61089=63970#toc Repository: rL LLVM

r275416 - Removing more :option: tags that we do not have corresponding .. option directives for; these are causing the sphinx bot to fail (http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/1

Author: aaronballman Date: Thu Jul 14 09:07:37 2016 New Revision: 275416 URL: http://llvm.org/viewvc/llvm-project?rev=275416=rev Log: Removing more :option: tags that we do not have corresponding .. option directives for; these are causing the sphinx bot to fail

Re: [PATCH] D22310: Make the test for fno-pch-timestamp compatible with read-only checkouts.

pgousseau added a comment. In https://reviews.llvm.org/D22310#484017, @bkramer wrote: > lg Thanks for the review! https://reviews.llvm.org/D22310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r275415 - The test added in r275267 does not work on read-only checkouts because of the use of touch -m -t.

Author: pgousseau Date: Thu Jul 14 08:58:27 2016 New Revision: 275415 URL: http://llvm.org/viewvc/llvm-project?rev=275415=rev Log: The test added in r275267 does not work on read-only checkouts because of the use of touch -m -t. Following Tom Rybka suggestion, the test files are now copied to a

Re: r275368 - Add C++ dependencies to xray runtime

On 07/14/2016 02:10 PM, Dean Michael Berris wrote: Thanks Mikael -- this has been fixed in r275377 (http://reviews.llvm.org/rL275377). Yes, now it compiled. Thank you! /Mikael On Thu, Jul 14, 2016 at 7:30 PM Mikael Holmén >

[PATCH] D22351: [include-fixer] Move curosr to #include line in vim after inserting a missing header.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. A small improvement: for only one suggested header, user don't have to type ENTER manually after running the python script. https://reviews.llvm.org/D22351 Files:

  1   2   >