Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > mclow.lists wrote: > > mclow.lists wrote: > > > kimgr

Re: [PATCH] D22662: [cxx1z-constexpr-lambda] Make a lambda's closure type a literal type in C++1z.

faisalv updated this revision to Diff 65026. faisalv added a comment. Factor out the diagnostic builder RAII creation (through Sema.Diag) and reduce repetition. https://reviews.llvm.org/D22662 Files: include/clang/AST/DeclCXX.h lib/Sema/SemaType.cpp

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

Prazek added a comment. Is it in upstream yet? Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.h:19 @@ +18,3 @@ + +/// Flags slicing of member variables or vtable. See: +/// - courbet wrote: > Prazek wrote: > > some short description what does this

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Prazek marked 6 inline comments as done. Prazek added a comment. Repository: rL LLVM https://reviews.llvm.org/D22208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22663: Support setting default value for -rtlib at build time

zlei created this revision. zlei added reviewers: cfe-commits, ddunbar, Hahnfeld. This patch introduces a new cmake variable: CLANG_DEFAULT_RTLIB, thru which we can specify a default value for -rtlib (libgcc or compiler-rt) at build time, just like how we set the default C++ stdlib thru

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Prazek removed rL LLVM as the repository for this revision. Prazek updated this revision to Diff 65023. Prazek marked 4 inline comments as done. https://reviews.llvm.org/D22208 Files: clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Prazek added a subscriber: klimek. Prazek added a comment. Can you look at my previous comment? I nedd an expert for AST. Repository: rL LLVM https://reviews.llvm.org/D22208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Prazek added a comment. There is one bug left: In the ClangIncludeFixer.cpp:169 there is push back that looks like this Symbols.push_back(find_all_symbols::SymbolInfo( Split.first.trim(), find_all_symbols::SymbolInfo::SymbolKind::Unknown, CommaSplits[I].trim(), 1, {},

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:112 @@ -95,1 +111,3 @@ + auto CtorCallSourceRange = CharSourceRange::getTokenRange( + InnerCtorCall->getExprLoc(), CallParensRange.getBegin()); alexfh wrote: > > There is a

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFinder.cpp:81 @@ +80,3 @@ +const auto TypeEndLoc = Loc.getEndLoc(), + TypeBeginLoc = Lexer::GetBeginningOfToken( + TypeEndLoc,

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

alexfh added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:45 @@ -33,3 +44,3 @@ hasDeclaration(functionDecl(hasName("push_back"))), - on(hasType(cxxRecordDecl(hasAnyName("std::vector", "llvm::SmallVector", -

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:45 @@ -33,3 +44,3 @@ hasDeclaration(functionDecl(hasName("push_back"))), - on(hasType(cxxRecordDecl(hasAnyName("std::vector", "llvm::SmallVector", -

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:45 @@ -33,3 +44,3 @@ hasDeclaration(functionDecl(hasName("push_back"))), - on(hasType(cxxRecordDecl(hasAnyName("std::vector",

Re: [PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

Eugene.Zelenko updated this revision to Diff 65004. Eugene.Zelenko added a comment. Full context diff. Repository: rL LLVM https://reviews.llvm.org/D22656 Files: clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp Index:

Re: [PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Full context diffs, please. See http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rL LLVM https://reviews.llvm.org/D22656

Re: [PATCH] D22605: [Clang-tool-extra] Restructure release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL276371: Restructure release notes. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D22605?vs=64806=65003#toc Repository: rL LLVM https://reviews.llvm.org/D22605

[clang-tools-extra] r276371 - Restructure release notes.

Author: eugenezelenko Date: Thu Jul 21 19:34:42 2016 New Revision: 276371 URL: http://llvm.org/viewvc/llvm-project?rev=276371=rev Log: Restructure release notes. Differential revision: https://reviews.llvm.org/D22605 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

Re: [PATCH] D22605: [Clang-tool-extra] Restructure release notes

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D22605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/mpi/MPITidyModule.cpp:30 @@ +29,3 @@ +static ClangTidyModuleRegistry::Add X("mpi-module", + "Adds MPI lint

r276370 - [Coverage] Attempt to appease a Windows builder

Author: vedantk Date: Thu Jul 21 19:25:09 2016 New Revision: 276370 URL: http://llvm.org/viewvc/llvm-project?rev=276370=rev Log: [Coverage] Attempt to appease a Windows builder The builder prints out the following IR: \5CCoverageMapping\5COutput\5Ctest\5Cf1.c The updated test in r276367

Re: r276361 - Reverting r275115 which caused PR28634.

> On Jul 21, 2016, at 4:28 PM, Wolfgang Pieb via cfe-commits > wrote: > > Author: wolfgangp > Date: Thu Jul 21 18:28:18 2016 > New Revision: 276361 > > URL: http://llvm.org/viewvc/llvm-project?rev=276361=rev > Log: > Reverting r275115 which caused PR28634. > When

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

mzolotukhin accepted this revision. mzolotukhin added a comment. This revision is now accepted and ready to land. LGTM with a small nit: could you please run `opt -instnamer` on your test (it'll replace `%0`, `%1`,... with `%tmp0`, `%tmp1` etc, making it easier to modify test in future)?

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

mmasten added a comment. I think this is just saying that some of the weird types are not supported on all targets. For now, is it ok to proceed with checking this code in? Thanks, Matt https://reviews.llvm.org/D19544 ___ cfe-commits mailing

r276367 - [Coverage] Strengthen a test case

Author: vedantk Date: Thu Jul 21 19:00:02 2016 New Revision: 276367 URL: http://llvm.org/viewvc/llvm-project?rev=276367=rev Log: [Coverage] Strengthen a test case We should be able to use `mkdir` without turning on `REQUIRES: shell`. Moreover, this test should check for a path separator which

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL276365: [analyzer] Add checker modeling potential C++ self-assignment (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D19311?vs=64864=64996#toc Repository: rL LLVM

r276365 - [analyzer] Add checker modeling potential C++ self-assignment

Author: dcoughlin Date: Thu Jul 21 18:42:31 2016 New Revision: 276365 URL: http://llvm.org/viewvc/llvm-project?rev=276365=rev Log: [analyzer] Add checker modeling potential C++ self-assignment This checker checks copy and move assignment operators whether they are protected against

r276361 - Reverting r275115 which caused PR28634.

Author: wolfgangp Date: Thu Jul 21 18:28:18 2016 New Revision: 276361 URL: http://llvm.org/viewvc/llvm-project?rev=276361=rev Log: Reverting r275115 which caused PR28634. When empty (forwarding) basic blocks that are referenced by user labels are removed, incorrect code may be generated.

r276356 - [profile] update test case with interface change.

Author: davidxl Date: Thu Jul 21 18:19:39 2016 New Revision: 276356 URL: http://llvm.org/viewvc/llvm-project?rev=276356=rev Log: [profile] update test case with interface change. See http://reviews.llvm.org/D22613, http://reviews.llvm.org/D22614 Modified: cfe/trunk/test/Profile/c-generate.c

r276352 - [Sema] Handle errors during rewriteBuiltinFunctionDecl

Author: majnemer Date: Thu Jul 21 18:03:43 2016 New Revision: 276352 URL: http://llvm.org/viewvc/llvm-project?rev=276352=rev Log: [Sema] Handle errors during rewriteBuiltinFunctionDecl rewriteBuiltinFunctionDecl can encounter errors when performing DefaultFunctionArrayLvalueConversion. These

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

Alexander_Droste marked 5 inline comments as done. Alexander_Droste added a comment. https://reviews.llvm.org/D21962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

Alexander_Droste updated this revision to Diff 64985. Alexander_Droste added a comment. - use `llvm::StringMap` instead of `std::map` - `getQualifiedNameAsString` -> `getName` - remove redundant map lookup - create MPIi module - replace `misc` with `mpi` within the check I created an MPI module

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

teemperor added a comment. Binary size increases from 33017160 Bytes to 33060464 Bytes (+40 KiB). I'm not sure if that's too much for such a minor feature, so I've added two new revisions: - One is the original patch with the other mentioned issues fixed (so, same +40 KiB size increase here).

[PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: alexfh. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

teemperor updated this revision to Diff 64983. teemperor added a comment. - Replaced visitor-style utility functions with chained `if`s to reduce binary size. https://reviews.llvm.org/D22514 Files: lib/Analysis/CloneDetection.cpp test/Analysis/copypaste/test-min-max.cpp Index:

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

teemperor updated this revision to Diff 64982. teemperor marked 3 inline comments as done. teemperor added a comment. - Added `FIXME:` and removed duplicate "for example". https://reviews.llvm.org/D22514 Files: lib/Analysis/CloneDetection.cpp test/Analysis/copypaste/test-min-max.cpp

Re: [PATCH] D22542: [CodeGen] Fix a crash on valid when constant folding 'default:' statement in switch

This revision was automatically updated to reflect the committed changes. Closed by commit rL276350: [CodeGen] Fix a crash when constant folding switch statement (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D22542?vs=64569=64981#toc Repository: rL LLVM

r276350 - [CodeGen] Fix a crash when constant folding switch statement

Author: epilk Date: Thu Jul 21 17:31:40 2016 New Revision: 276350 URL: http://llvm.org/viewvc/llvm-project?rev=276350=rev Log: [CodeGen] Fix a crash when constant folding switch statement Differential revision: https://reviews.llvm.org/D22542 Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.h:36-37 @@ -32,1 +35,4 @@ +private: + std::vector ContainersWithPushBack; + std::vector SmartPointers; }; aaron.ballman wrote: > Why not use a SmallVector for these instead of a

RE: r276102 - [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Simon Pilgrim via cfe-commits > Sent: Wednesday, July 20, 2016 3:18 AM > To: cfe-commits@lists.llvm.org > Subject: r276102 - [X86][SSE] Reimplement SSE fp2si conversion intrinsics >

[PATCH] D22654: [Clang-rename] Remove custom version, fix extra space in error message

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: omtcyfz, vmiklos, klimek. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I also fixed some Include What You Use Warnings. Repository: rL LLVM

Re: [PATCH] D22587: [ASTContext] Fix part of DR224 for nontype template arguments

mgehre added inline comments. Comment at: lib/AST/ASTContext.cpp:4456 @@ +4455,3 @@ + // the template parameter and not an expression involving the template parameter. + auto *E = Arg.getAsExpr()->IgnoreImpCasts(); + while(auto *DeclRef = dyn_cast_or_null(E)) {

r276335 - Disable a flaky test on Windows that uses "echo >>"

Author: rnk Date: Thu Jul 21 16:07:47 2016 New Revision: 276335 URL: http://llvm.org/viewvc/llvm-project?rev=276335=rev Log: Disable a flaky test on Windows that uses "echo >>" Modified: cfe/trunk/test/Modules/embed-files.cpp Modified: cfe/trunk/test/Modules/embed-files.cpp URL:

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

kimgr added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + mclow.lists wrote: > mclow.lists wrote: > > kimgr wrote: > > > mclow.lists

Re: [PATCH] D22542: [CodeGen] Fix a crash on valid when constant folding 'default:' statement in switch

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman https://reviews.llvm.org/D22542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libunwind] r276215 - [libunwind] Properly align _Unwind_Exception.

I'm not sure we have an owner for libunwind, but things sounded positive on the code review, so go ahead and merge. Thanks, Hans On Wed, Jul 20, 2016 at 8:06 PM, Eric Fiselier wrote: > @Hans This should be merged into 3.9. > > Can a code owner give this the thumbs up? > > /Eric >

Re: [libunwind] r276128 - libunwind: limit stack usage in unwind cursor

On Wed, Jul 20, 2016 at 9:00 PM, Ed Maste wrote: > On 20 July 2016 at 15:19, Ed Maste via cfe-commits > wrote: >> Author: emaste >> Date: Wed Jul 20 10:19:09 2016 >> New Revision: 276128 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=276128=rev

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 64941. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Rebased on top of r276282 and resolved conflicts. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22642: CodeGen: Clean up implementation of vtable initializer builder. NFC.

pcc created this revision. pcc added a reviewer: rsmith. pcc added a subscriber: cfe-commits. - Simplify signature of CreateVTableInitializer function. - Move vtable component builder to a separate function. - Remove unnecessary accessors from VTableLayout class. This is in preparation for a

Re: [PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

dim added inline comments. Comment at: lib/Headers/cpuid.h:114 @@ -109,2 +113,3 @@ #define bit_AVX 0x1000 +#define bit_F16C0x2000 #define bit_RDRND 0x4000 bruno wrote: > Isn't this one also meant for gcc compat? Well, we didn't

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

emaste added a comment. Note that the addition of the referenceCount at the beginning of `__cxa_exception` for 64-bit builds causes the `_Unwind_Exception unwindHeader` to become misaligned. libstdc++ had this same issue (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38732, now fixed) and

Re: [PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

manmanren added a comment. In https://reviews.llvm.org/D22636#491679, @benlangmuir wrote: > > B.pcm becomes out of date when we try to load module "A", because another > > instance overwrites "B.pcm" > > > How can this happen? We intentionally keep the file descriptors of modules > open. If

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + mclow.lists wrote: > kimgr wrote: > > mclow.lists wrote: > > > kimgr

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > mclow.lists wrote: > > kimgr wrote: > > > I'm working

r276317 - Reroll "Include unreferenced nested types in member list only for CodeView"

Author: amccarth Date: Thu Jul 21 13:43:20 2016 New Revision: 276317 URL: http://llvm.org/viewvc/llvm-project?rev=276317=rev Log: Reroll "Include unreferenced nested types in member list only for CodeView" Another attempt at r276271, hopefully without breaking ModuleDebugInfo test. Modified:

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

yaxunl added inline comments. Comment at: include/clang/Basic/OpenCLExtensions.def:73 @@ -72,2 +72,3 @@ OPENCLEXT_INTERNAL(cl_khr_terminate_context, 200, ~0U) +OPENCLEXT_INTERNAL(cl_khr_mipmap_image, 200, ~0U) Better to follow the alphabetical order.

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

yaxunl added a comment. Need to add a test to Misc/amdgcn.languageOptsOpenCL.cl and SemaOpenCL/extension-version.cl Repository: rL LLVM https://reviews.llvm.org/D22637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

benlangmuir added a comment. > B.pcm becomes out of date when we try to load module "A", because another > instance overwrites "B.pcm" How can this happen? We intentionally keep the file descriptors of modules open. If you just built A, then you will have B.pcm still open. When you read

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. This is a patch I applied internally to debug out-of-date issues. In general is this the right way to add debugging messages in clang frontend?

[PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Adding extension cl_khr_mipmap_image to clang's OpenCL Extensions and initiated inside AMDGPU Target. Repository: rL LLVM

[PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. Even though this instance just built module "A", it is likely that "A" imports another module "B" and B.pcm becomes out of date when we try to load module "A", because

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated this revision to Diff 64927. yaxunl marked 4 inline comments as done. yaxunl added a comment. Update the test to accommodate changes in branch tip. https://reviews.llvm.org/D21567 Files: include/clang/AST/OperationKinds.def include/clang/Basic/DiagnosticGroups.td

[libcxx] r276309 - Remove FIXME for feature test macro

Author: jfb Date: Thu Jul 21 12:34:28 2016 New Revision: 276309 URL: http://llvm.org/viewvc/llvm-project?rev=276309=rev Log: Remove FIXME for feature test macro The value I'd picked was correct, as per the recently published SG10 paper http://wg21.link/p0096r3 Modified:

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

jfb added a comment. Two comments, then lgtm. Comment at: include/atomic:581 @@ +580,3 @@ + || __f == memory_order_acq_rel, ""))) \ +__attribute__ ((__unavailable__("memory order argument to atomic operation is invalid"))) +#endif

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

rivanvx added a comment. Addressed both concerns. https://reviews.llvm.org/D20168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22608: [Profile] Use a flag to enable PGO rather than the profraw filename.

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D22608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22587: [ASTContext] Fix part of DR224 for nontype template arguments

On 20 Jul 2016 1:25 p.m., "Matthias Gehre" wrote: > > mgehre created this revision. > mgehre added reviewers: klimek, aaron.ballman, rsmith. > mgehre added a subscriber: cfe-commits. > > Look through expressions to determine if a nontype template argument has been given the value

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added a comment. In https://reviews.llvm.org/D15075#486986, @zizhar wrote: > Akira, > You've mentioned a good point, this X86 logic should indeed be moved to > X86TargetInfo. > The current convertConstraint() implementation is not doing what I need – it > doesn’t handle all the

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

kimgr added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + mclow.lists wrote: > kimgr wrote: > > I'm working from the paper at

Re: [PATCH] D22587: [ASTContext] Fix part of DR224 for nontype template arguments

aaron.ballman added a comment. Generally LGTM with a small nit. Comment at: lib/AST/ASTContext.cpp:4456 @@ +4455,3 @@ + // the template parameter and not an expression involving the template parameter. + auto *E = Arg.getAsExpr()->IgnoreImpCasts(); + while(auto

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.h:36-37 @@ -32,1 +35,4 @@ +private: + std::vector ContainersWithPushBack; + std::vector SmartPointers; }; Why not use a SmallVector for these instead of a std::vector? Then

Re: [PATCH] D21453: Add support for attribute "overallocated"

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with one small testing nit, but you should wait for @rsmith to chime in since he had comments previously. Comment at: test/SemaCXX/flexible-array-attr.cpp:52 @@ +51,3 @@ + int a[4]; + int b[4]

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

aaron.ballman added a subscriber: aaron.ballman. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:31 @@ +30,3 @@ +// Stores a min and a max value which describe an interval. +struct ValueRange { + llvm::APSInt MinVal, MaxVal; I think this class can be replaced by

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet marked an inline comment as done. szepet added a comment. https://reviews.llvm.org/D22507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet removed rL LLVM as the repository for this revision. szepet updated this revision to Diff 64897. szepet added a comment. updating patch based on review comments https://reviews.llvm.org/D22507 Files: clang-tidy/misc/EnumMisuseCheck.cpp clang-tidy/misc/EnumMisuseCheck.h

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet marked 18 inline comments as done. szepet added a comment. https://reviews.llvm.org/D22507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r276292 - Move some IntrusiveRefCntPtrs instead of copying.

Author: d0k Date: Thu Jul 21 10:06:51 2016 New Revision: 276292 URL: http://llvm.org/viewvc/llvm-project?rev=276292=rev Log: Move some IntrusiveRefCntPtrs instead of copying. No functionality change intended. Modified: cfe/trunk/include/clang/Basic/Diagnostic.h

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/RuleOfFiveAndZeroCheck.cpp:63 @@ +62,3 @@ + if (const auto *MatchedDecl = Result.Nodes.getNodeAs(Match)) { + +diag(MatchedDecl->getLocation(), "class %0 defines a %1 but does not "

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:20 @@ +19,3 @@ + +static void ReplaceMoveWithForward(const UnresolvedLookupExpr *Callee, +

[clang-tools-extra] r276282 - [clang-tidy] Avoid duplicated DenseMap lookup.

Author: d0k Date: Thu Jul 21 09:13:45 2016 New Revision: 276282 URL: http://llvm.org/viewvc/llvm-project?rev=276282=rev Log: [clang-tidy] Avoid duplicated DenseMap lookup. The std::string is still constructed on demand. No functionality change intended. Modified:

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

bcraig added inline comments. Comment at: include/atomic:569 @@ +568,3 @@ +__attribute__ ((__enable_if__(__m == memory_order_release \ + || __m == memory_order_acq_rel, ""))) \ +__attribute__ ((__unavailable__("memory

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

mclow.lists added a comment. And is there any reason why `__libcpp_isinf` can't just return `false` for non-fp types? https://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

mclow.lists added a comment. Maybe something like this? (untested) template _LIBCPP_ALWAYS_INLINE typename std::enable_if::value, bool>::type __libcpp_isfinite(_A1 __lcpp_x) _NOEXCEPT { return isfinite(__lcpp_x); } template _LIBCPP_ALWAYS_INLINE typename

Re: [PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rL276280: [include-fixer] Add mising qualifiers to all instances of an unidentified… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D22567?vs=64849=64877#toc Repository: rL

[clang-tools-extra] r276280 - [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

Author: hokein Date: Thu Jul 21 08:47:09 2016 New Revision: 276280 URL: http://llvm.org/viewvc/llvm-project?rev=276280=rev Log: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol. Reviewers: bkramer Subscribers: ioeric, cfe-commits Differential Revision:

r276279 - Revert "Include unreferenced nested types in member list only for CodeView"

Author: amccarth Date: Thu Jul 21 08:41:25 2016 New Revision: 276279 URL: http://llvm.org/viewvc/llvm-project?rev=276279=rev Log: Revert "Include unreferenced nested types in member list only for CodeView" Patch broke ModuleDebugInfo test on the build bots (but not locally). Again. svn

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

mclow.lists added inline comments. Comment at: include/string_view:216 @@ +215,3 @@ + basic_string_view(const _CharT* __s) + : __data(__s), __size(_Traits::length(__s)) {} + kimgr wrote: > I'm working from the paper at

Re: [PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

dsanders updated this revision to Diff 64870. dsanders added a comment. Refresh and ping https://reviews.llvm.org/D21070 Files: lib/Basic/Targets.cpp lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp tools/driver/cc1as_main.cpp Index:

[libcxx] r276273 - Again, w/o the tabs

Author: marshall Date: Thu Jul 21 08:19:36 2016 New Revision: 276273 URL: http://llvm.org/viewvc/llvm-project?rev=276273=rev Log: Again, w/o the tabs Modified: libcxx/trunk/test/std/strings/string.view/string.view.ops/substr.pass.cpp Modified:

[libcxx] r276272 - Another fix to appease the no-exception bots.

Author: marshall Date: Thu Jul 21 08:18:50 2016 New Revision: 276272 URL: http://llvm.org/viewvc/llvm-project?rev=276272=rev Log: Another fix to appease the no-exception bots. Modified: libcxx/trunk/test/std/strings/string.view/string.view.ops/substr.pass.cpp Modified:

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware removed rL LLVM as the repository for this revision. baloghadamsoftware updated this revision to Diff 64864. baloghadamsoftware added a comment. Bug path string fixed. https://reviews.llvm.org/D19311 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos marked an inline comment as done. vmiklos added a comment. https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. > The patch looks fine to me (though I'm not sure if there are no new tests; if > they are interface changes should be applied). `make check-clang-tools` + the patch at r276098 passes for me at least. But any pending test should be trivial to adapt. > P.S. it seems

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 64859. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

rengolin added inline comments. Comment at: src/UnwindRegistersRestore.S:325 @@ -324,4 +324,3 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

NoQ added a comment. Whoops forgot the screenshots: F2187578: 2.png F2187579: 1.png Also not sure how to write tests for these, because we can't choose the directory path for the dump, can we?

[PATCH] D22622: [analyzer] Add more info to exploded graph dumps

NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin. NoQ added subscribers: xazax.hun, a.sidorin, cfe-commits. `debug.ViewExplodedGraph`, aka `-analyzer-viz-egraph-graphviz`, is often the only way to understand the otherwise confusing analyzer report. Exploded graphs are often

[clang-tools-extra] r276259 - [clang-rename] check whether -new-name is valid identifier in C++17

Author: omtcyfz Date: Thu Jul 21 05:21:31 2016 New Revision: 276259 URL: http://llvm.org/viewvc/llvm-project?rev=276259=rev Log: [clang-rename] check whether -new-name is valid identifier in C++17 Added: clang-tools-extra/trunk/test/clang-rename/InvalidNewName.cpp Modified:

Re: [PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D22567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

hokein updated this revision to Diff 64849. hokein added a comment. update error message. https://reviews.llvm.org/D22567 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h

  1   2   >