Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

mstorsjo abandoned this revision. mstorsjo added a comment. This test isn't strictly necessary, thus abandoning https://reviews.llvm.org/D22857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22090: [analyzer] Add more FileIDs to PlistDiagnostic map

zaks.anna added inline comments. Comment at: test/Analysis/diagnostics/Inputs/include/Something.h:1 @@ +1,2 @@ +void clang_analyzer_warnIfReached(); + Please, choose better file names. Every test that adds something cannot add a header called something:) It

Re: [PATCH] D22856: [analyzer] Change -analyze-function to accept qualified names.

zaks.anna added a comment. We'd definitely want the same routine in both: printing the name in -analyzer-display-progress and be accepted by -analyze-function. Looks like what ND->getQualifiedNameAsString() returns is not proper ObjC syntax, but maybe it's fine for the debug feature? Even

Re: [PATCH] D22862: [analyzer] Fix for PR15623: eliminate unwanted ProgramState checker data propagation.

zaks.anna added a comment. I am not sure it's the right way of fixing this problem and it introduces a regression. The bug is probably specific to "&&". + Devin as we might have seen something similar. Comment at: test/Analysis/misc-ps-region-store.m:332 @@ -330,3 +331,3 @@

[libcxx] r276955 - Add a bunch of noexcepts to char_traits and string_view.

Author: marshall Date: Wed Jul 27 23:52:02 2016 New Revision: 276955 URL: http://llvm.org/viewvc/llvm-project?rev=276955=rev Log: Add a bunch of noexcepts to char_traits and string_view. Modified: libcxx/trunk/include/__string libcxx/trunk/include/string_view Modified:

Re: [PATCH] D22810: scan-build: Add an option to show the description in the list of defect

zaks.anna added a comment. The report you are referencing does not seem to have "Description" as a column name. Also, the titles row is not gray all the way to the right... https://reviews.llvm.org/D22810 ___ cfe-commits mailing list

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

zaks.anna added inline comments. Comment at: test/Analysis/PR12421.c:11 @@ +10,2 @@ + +// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics does not support diagnostics that cross file boundaries. ayartsev wrote: > zaks.anna wrote: > > We

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

majnemer added a comment. In https://reviews.llvm.org/D22900#498793, @Gerolf wrote: > Nope, I don't see the tail call. Anyway, I'll simplify my test case. Don't > worry about it. > > clang++ -cc1 -x c++ -emit-llvm -triple i386-apple-darwin9 t.cpp > > cat t.ll: > > ; ModuleID = 't.cpp' >

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

Gerolf added a comment. Nope, I don't see the tail call. Anyway, I'll simplify my test case. Don't worry about it. clang++ -cc1 -x c++ -emit-llvm -triple i386-apple-darwin9 t.cpp cat t.ll: ; ModuleID = 't.cpp' source_filename = "t.cpp" target datalayout =

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

majnemer added a comment. In https://reviews.llvm.org/D22900#498781, @Gerolf wrote: > Please add the options you used to compile? I can certainly shrink the test > case a bit before I commit. clang -cc1 -x c++ -emit-llvm -triple i386-apple-darwin9 t.ii -o - https://reviews.llvm.org/D22900

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

Gerolf added a comment. Please add the options you used to compile? I can certainly shrink the test case a bit before I commit. https://reviews.llvm.org/D22900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

majnemer added a subscriber: majnemer. majnemer added a comment. The test seems a little large, the following shows that we emit a tail call with a byval argument on trunk. struct LARGE { union { int i; }; }; struct I { virtual void m_fn1(LARGE); }; struct CBase {

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D20168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22895: [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

teemperor added a comment. Is there a specific situation/bug we want to test against with these tests? I looks to me as if they would mainly test against non-determinism (i.e. same statements have different data due to non-determinism). Comment at:

[PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

Gerolf created this revision. Gerolf added reviewers: eli.friedman, mkuper. Gerolf added a subscriber: cfe-commits. This is just closing the loop for https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg28837.html with a test case and fixes PR28748 which had been introduced by r244207.

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

teemperor updated this revision to Diff 65857. teemperor marked 5 inline comments as done. teemperor added a comment. - Removed duplicate test case. https://reviews.llvm.org/D22514 Files: lib/Analysis/CloneDetection.cpp test/Analysis/copypaste/false-positives.cpp

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

teemperor updated this revision to Diff 65854. teemperor added a comment. - Rebased patch. - Fixed code style (`const type` instead of `type const`). - Fixed missing const on some variables in StmtDataCollector. - Rewrote a few comments/variable names. https://reviews.llvm.org/D22514 Files:

Re: [PATCH] D21946: Subject: [PATCH] [Driver] fix windows SDK detect

comicfans44 added a comment. In https://reviews.llvm.org/D21946#473071, @zturner wrote: > In https://reviews.llvm.org/D21946#473070, @comicfans44 wrote: > > > I've not commited to cfe before, so I think I havn't commit access > > permission. > > > If you've committed anywhere in LLVM, you

r276950 - [analyzer] Add check::BeginFunction to CheckerDocumentation checks. NFC.

Author: dcoughlin Date: Wed Jul 27 19:52:10 2016 New Revision: 276950 URL: http://llvm.org/viewvc/llvm-project?rev=276950=rev Log: [analyzer] Add check::BeginFunction to CheckerDocumentation checks. NFC. This was an oversight from when I added BeginFunction support in r261293. Modified:

Re: [PATCH] D22881: Fix NamedDeclFindingASTVisitor

compnerd closed this revision. compnerd added a comment. SVN r276948 https://reviews.llvm.org/D22881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r276949 - test: fix typo in file name (NFC)

Author: compnerd Date: Wed Jul 27 19:43:14 2016 New Revision: 276949 URL: http://llvm.org/viewvc/llvm-project?rev=276949=rev Log: test: fix typo in file name (NFC) Added: clang-tools-extra/trunk/test/clang-rename/ClassNameInFunctionDefinition.cpp - copied, changed from r276948,

[clang-tools-extra] r276948 - clang-rename: adjust NamedDeclFindingASTVisitor for RecordDecls

Author: compnerd Date: Wed Jul 27 19:42:01 2016 New Revision: 276948 URL: http://llvm.org/viewvc/llvm-project?rev=276948=rev Log: clang-rename: adjust NamedDeclFindingASTVisitor for RecordDecls Ensure that Context is always properly initialised in the constructor. It is used for querying the

r276947 - Replace preserve-as-comments CodeGen test with driver test

Author: niravd Date: Wed Jul 27 19:36:34 2016 New Revision: 276947 URL: http://llvm.org/viewvc/llvm-project?rev=276947=rev Log: Replace preserve-as-comments CodeGen test with driver test Added: cfe/trunk/test/Driver/preserve-as-comments.c Removed:

[PATCH] D22895: [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0, tra. sfantao added subscribers: cfe-commits, caomhin. This patch prevents OpenMP flags from being forwarded to CUDA device commands. That was causing the CUDA frontend to attempt to

only correct delayed typos for conditional expressions when needed.

r272587 (http://reviews.llvm.org/D20490) fixed an issue where typo correction could cause a crash when compiling C programs.The problem was that a typo expression could be inadvertently processed twice.r272587 fixed this for BinOp expressions. Conditional expressions can hit the same

Re: r276350 - [CodeGen] Fix a crash when constant folding switch statement

I hear that he is on vacation. On Wednesday, July 27, 2016, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Richard: ping? > > On Fri, Jul 22, 2016 at 7:00 AM, Hans Wennborg > wrote: > > Richard: should we merge this to 3.9? > > > > On Thu,

Re: r276350 - [CodeGen] Fix a crash when constant folding switch statement

Richard: ping? On Fri, Jul 22, 2016 at 7:00 AM, Hans Wennborg wrote: > Richard: should we merge this to 3.9? > > On Thu, Jul 21, 2016 at 6:31 PM, Erik Pilkington via cfe-commits > wrote: >> Author: epilk >> Date: Thu Jul 21 17:31:40 2016 >> New

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

Should this be merged to 3.9? Thanks, Hans On Wed, Jul 27, 2016 at 11:25 AM, Erik Pilkington via cfe-commits wrote: > Author: epilk > Date: Wed Jul 27 13:25:10 2016 > New Revision: 276900 > > URL: http://llvm.org/viewvc/llvm-project?rev=276900=rev > Log: > [Sema]

Re: r276907 - Add flags to toggle preservation of assembly comments

On 27 July 2016 at 21:57, Nirav Davé wrote: > Looks like I missed the target triple. Should work now. Still failing on *all* ARM targets. 'No available targets are compatible with this triple.' Please move the test to an x86 directory.

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL276937: Retry: [Driver] Compute effective target triples once per job (NFCI) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D22596?vs=64792=65829#toc Repository: rL LLVM

r276937 - Retry: [Driver] Compute effective target triples once per job (NFCI)

Author: vedantk Date: Wed Jul 27 18:02:20 2016 New Revision: 276937 URL: http://llvm.org/viewvc/llvm-project?rev=276937=rev Log: Retry: [Driver] Compute effective target triples once per job (NFCI) Compute an effective triple once per job. Cache the triple in the prevailing ToolChain for the

r276936 - Revert "[Driver] Compute effective target triples once per job (NFCI)"

Author: vedantk Date: Wed Jul 27 18:01:55 2016 New Revision: 276936 URL: http://llvm.org/viewvc/llvm-project?rev=276936=rev Log: Revert "[Driver] Compute effective target triples once per job (NFCI)" This reverts commit r275895 in order to address some post-commit review feedback from Eric

r276934 - [OpenMP] Add support to map member expressions with references to pointers.

Author: sfantao Date: Wed Jul 27 17:52:16 2016 New Revision: 276934 URL: http://llvm.org/viewvc/llvm-project?rev=276934=rev Log: [OpenMP] Add support to map member expressions with references to pointers. Summary: This patch add support to map pointers through references in class members.

r276933 - [OpenMP] Add support for mapping array sections through pointer references.

Author: sfantao Date: Wed Jul 27 17:49:49 2016 New Revision: 276933 URL: http://llvm.org/viewvc/llvm-project?rev=276933=rev Log: [OpenMP] Add support for mapping array sections through pointer references. Summary: This patch fixes a bug in the map of array sections whose base is a reference to

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

mprobst added a comment. Friendly ping :-) https://reviews.llvm.org/D22431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r276930 - test/Frontend: Add a test for aarch64 target CPU names.

Author: matze Date: Wed Jul 27 17:47:07 2016 New Revision: 276930 URL: http://llvm.org/viewvc/llvm-project?rev=276930=rev Log: test/Frontend: Add a test for aarch64 target CPU names. Nothing else checked the target cpu names for aarch64 yet. Add a test in the spirit of x86-target-cpu.c. Added:

r276931 - Basic/Targets.cpp: Reformat aarch64 CPU list.

Author: matze Date: Wed Jul 27 17:47:09 2016 New Revision: 276931 URL: http://llvm.org/viewvc/llvm-project?rev=276931=rev Log: Basic/Targets.cpp: Reformat aarch64 CPU list. Having 1 entry per line and an alphabetical order is clearer and reduces the risk of invalid merges. Modified:

r276929 - Refactor how include paths are appended to the command arguments.

Author: sfantao Date: Wed Jul 27 17:46:31 2016 New Revision: 276929 URL: http://llvm.org/viewvc/llvm-project?rev=276929=rev Log: Refactor how include paths are appended to the command arguments. Summary: This patch aims at removing redundancy in the way include paths for the regular and

Re: [PATCH] D20811: [analyzer] Model some library functions

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:509 @@ +508,3 @@ + //} + // } + //} I disagree about compactness being valuable here. I think it is more important to intrinsically document the spec.

Re: [PATCH] D22879: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

This revision was automatically updated to reflect the committed changes. Closed by commit rL276927: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D22879?vs=65800=65824#toc Repository: rL

r276927 - [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

Author: jlebar Date: Wed Jul 27 17:36:21 2016 New Revision: 276927 URL: http://llvm.org/viewvc/llvm-project?rev=276927=rev Log: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment. Summary: Before this patch, we computed the

Re: [PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

manmanren abandoned this revision. manmanren added a comment. Abandon this change for now. https://reviews.llvm.org/D22636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22879: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D22879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

rengolin added a comment. Ok, sounds good. Feel free to abandon this one as well. cheers, --renato https://reviews.llvm.org/D22857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22856: [analyzer] Change -analyze-function to accept qualified names.

dcoughlin added a comment. In https://reviews.llvm.org/D22856#497796, @NoQ wrote: > > I think it would be better for fully-qualified Objective-C methods to be > > specified with their Objective-C-style names. For example: "-[Test1 > > myMethodWithY:withX:]". > > > Uhm, need to know more about

Re: [PATCH] D22874: [analyzer] Fixes to the checker developer manual.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. A couple of nits. Otherwise, LGTM. Thanks! Comment at: www/analyzer/checker_dev_manual.html:534 @@ +533,3 @@ +itself to the child process (for example, in gcc you can

r276925 - Don't crash when generating code for __attribute__((naked)) member functions.

Author: jlebar Date: Wed Jul 27 17:04:24 2016 New Revision: 276925 URL: http://llvm.org/viewvc/llvm-project?rev=276925=rev Log: Don't crash when generating code for __attribute__((naked)) member functions. Summary: Previously this crashed inside EmitThisParam(). There should be no prelude for

Re: [PATCH] D22788: [OpenMP] Code generation for the is_device_ptr clause

sfantao updated this revision to Diff 65813. sfantao updated the summary for this revision. sfantao added a comment. - Remove unecessary brief directives from comments. https://reviews.llvm.org/D22788 Files: include/clang/AST/OpenMPClause.h include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/CodeGen/CGStmtOpenMP.cpp:3410-3411 @@ +3409,4 @@ + llvm::DenseSet EmittedAsFirstprivate; + CGCapturedStmtInfo CapturesInfo(cast(*D.getAssociatedStmt())); + for (const auto *C : D.getClausesOfKind())

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

sfantao updated this revision to Diff 65810. sfantao marked 8 inline comments as done. sfantao added a comment. - Remove unnecessary brief directives and refactor target data privatization code genenration. https://reviews.llvm.org/D22691 Files: include/clang/AST/OpenMPClause.h

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

echristo added a comment. Go ahead and split out your cleanups into another patch and remove the custom handling in the hexagon target then. Thanks! -eric Repository: rL LLVM https://reviews.llvm.org/D22766 ___ cfe-commits mailing list

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Not a huge fan of the registration/etc. That said, this is cleaner than a lot of the alternatives at the moment without making you do a lot of toolchain evisceration. LGTM. -eric

Re: [PATCH] D22879: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

jlebar added inline comments. Comment at: test/CodeGenCUDA/kernel-args-alignment.cu:1-2 @@ +1,3 @@ +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target + rnk wrote: > Typically clang doesn't need a registered backend for a target to generate

Re: [PATCH] D22879: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

jlebar updated this revision to Diff 65800. jlebar added a comment. Remove REQUIRES lines. https://reviews.llvm.org/D22879 Files: lib/CodeGen/CGCUDABuiltin.cpp lib/CodeGen/CGCUDANV.cpp test/CodeGenCUDA/kernel-args-alignment.cu Index: test/CodeGenCUDA/kernel-args-alignment.cu

Re: r276907 - Add flags to toggle preservation of assembly comments

Looks like I missed the target triple. Should work now. Thanks, -Nirav On Wed, Jul 27, 2016 at 4:41 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Nirav, > > This test is failing on darwin: > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574 > >

r276915 - Add target triple in test

Author: niravd Date: Wed Jul 27 15:48:39 2016 New Revision: 276915 URL: http://llvm.org/viewvc/llvm-project?rev=276915=rev Log: Add target triple in test Modified: cfe/trunk/test/CodeGen/preserve-as-comments.c Modified: cfe/trunk/test/CodeGen/preserve-as-comments.c URL:

Re: r276907 - Add flags to toggle preservation of assembly comments

Hi Nirav, This test is failing on darwin: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574 Can you take a look? On Wed, Jul 27, 2016 at 12:57 PM, Nirav Dave via cfe-commits wrote: > Author: niravd > Date: Wed Jul 27 14:57:40 2016 >

r276912 - test commit

Author: mmasten Date: Wed Jul 27 15:23:32 2016 New Revision: 276912 URL: http://llvm.org/viewvc/llvm-project?rev=276912=rev Log: test commit Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.h Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.h URL:

Re: [PATCH] D17820: Clang Code Completion Filtering

Fixed in r276889 by Simon Pilgrim! On 27/07/16 22:03, Vassil Vassilev wrote: Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change :

Re: r276889 - Fix unnecessary default switch warning

Thanks a lot! On 27/07/16 18:41, Simon Pilgrim via cfe-commits wrote: Author: rksimon Date: Wed Jul 27 11:41:56 2016 New Revision: 276889 URL: http://llvm.org/viewvc/llvm-project?rev=276889=rev Log: Fix unnecessary default switch warning Modified:

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated this revision to Diff 65796. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. Added missing codegen test. https://reviews.llvm.org/D21567 Files: include/clang/AST/OperationKinds.def include/clang/Basic/DiagnosticGroups.td

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl marked 9 inline comments as done. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:84 @@ +83,3 @@ +SamplerTy = llvm::PointerType::get(llvm::StructType::create( + CGM.getLLVMContext(), "__opencl_sampler_t"), + CGM.getContext().getTargetAddressSpace(

r276907 - Add flags to toggle preservation of assembly comments

Author: niravd Date: Wed Jul 27 14:57:40 2016 New Revision: 276907 URL: http://llvm.org/viewvc/llvm-project?rev=276907=rev Log: Add flags to toggle preservation of assembly comments Summary: Add -fpreserve-as-comments and -fno-preserve-as-comments. Reviewers: echristo, rnk Subscribers:

Re: [PATCH] D17820: Clang Code Completion Filtering

Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change : llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label in switch which covers all enumeration values

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

mstorsjo added a comment. In https://reviews.llvm.org/D22857#497719, @rengolin wrote: > I'll just echo @compnerd comments, since Phab didn't get it. > > - Change the syntax to __asm__, to be more portable > - Add Microsoft asm block syntax MSVC doesn't support inline assembly on ARM at all

r276904 - Adjust coercion of aggregates on RenderScript

Author: pirama Date: Wed Jul 27 14:01:51 2016 New Revision: 276904 URL: http://llvm.org/viewvc/llvm-project?rev=276904=rev Log: Adjust coercion of aggregates on RenderScript Summary: In RenderScript, the size of the argument or return value emitted in the IR is expected to be the same as the

[PATCH] D22881: Fix NamedDeclFindingASTVisitor

alexshap created this revision. alexshap added reviewers: klimek, omtcyfz. alexshap added subscribers: compnerd, cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Properly initialize the field Context in

Re: [PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

This revision was automatically updated to reflect the committed changes. Closed by commit rL276900: [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D21145?vs=60622=65779#toc Repository: rL

r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

Author: epilk Date: Wed Jul 27 13:25:10 2016 New Revision: 276900 URL: http://llvm.org/viewvc/llvm-project?rev=276900=rev Log: [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer Fixes PR27994, a crash on valid. Differential revision: https://reviews.llvm.org/D21145

Re: [PATCH] D22879: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

rnk added inline comments. Comment at: test/CodeGenCUDA/kernel-args-alignment.cu:1-2 @@ +1,3 @@ +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target + Typically clang doesn't need a registered backend for a target to generate IR for that

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

Anastasia added a comment. Btw, I am missing tests for generated __translate_sampler_initializer which I think we had at some point. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:84 @@ +83,3 @@ +SamplerTy = llvm::PointerType::get(llvm::StructType::create( +

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 updated this revision to Diff 65773. ashi1 marked an inline comment as done. ashi1 added a comment. Removed indentation as per Anastasia's comments. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp

r276896 - Update Clang Parser test error message to match new parser errors

Author: niravd Date: Wed Jul 27 12:39:47 2016 New Revision: 276896 URL: http://llvm.org/viewvc/llvm-project?rev=276896=rev Log: Update Clang Parser test error message to match new parser errors Modified: cfe/trunk/test/Parser/ms-inline-asm.c Modified: cfe/trunk/test/Parser/ms-inline-asm.c

[PATCH] D22879: [CUDA] Align kernel launch args correctly when the LLVM type's alignment is different from the clang type's alignment.

jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, cfe-commits. Before this patch, we computed the offsets in memory of args passed to GPU kernel functions by throwing all of the args into an LLVM struct. clang emits packed llvm structs basically whenever

Re: [PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

ibadawi updated this revision to Diff 65765. ibadawi added a comment. Restore the test lost in patch #2. Really sorry for the noise... https://reviews.llvm.org/D22871 Files: lib/Sema/SemaChecking.cpp test/Sema/outof-range-constant-compare.c Index: test/Sema/outof-range-constant-compare.c

Re: [PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

ibadawi updated this revision to Diff 65763. ibadawi added a comment. Remove extra blank line added by accident https://reviews.llvm.org/D22871 Files: lib/Sema/SemaChecking.cpp Index: lib/Sema/SemaChecking.cpp === ---

[PATCH] D22874: [analyzer] Fixes to the checker developer manual.

NoQ created this revision. NoQ added a reviewer: zaks.anna. NoQ added subscribers: dcoughlin, xazax.hun, a.sidorin, cfe-commits. 1. Fix the explanation of how to run tests after migration from autotools to cmake. 2. Expand the "debugging" section with more interesting stuff, as accidentally

r276891 - UsersManual.rst: update clang-cl option list

Author: hans Date: Wed Jul 27 11:56:03 2016 New Revision: 276891 URL: http://llvm.org/viewvc/llvm-project?rev=276891=rev Log: UsersManual.rst: update clang-cl option list Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

Anastasia added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ + #endif +#else + #ifdef cl_khr_mipmap_image Looks good! Could you just remove indentation please as it's not common for C macros? The same for the test

Re: [PATCH] D22518: Refactor how include paths are appended to the command arguments.

tra added a comment. Looks good. https://reviews.llvm.org/D22518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r276889 - Fix unnecessary default switch warning

Author: rksimon Date: Wed Jul 27 11:41:56 2016 New Revision: 276889 URL: http://llvm.org/viewvc/llvm-project?rev=276889=rev Log: Fix unnecessary default switch warning Modified: cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp Modified: cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp URL:

r276887 - Update cxx_dr_Status after 3.9 branch

Author: hans Date: Wed Jul 27 11:39:45 2016 New Revision: 276887 URL: http://llvm.org/viewvc/llvm-project?rev=276887=rev Log: Update cxx_dr_Status after 3.9 branch Modified: cfe/trunk/www/cxx_dr_status.html cfe/trunk/www/make_cxx_dr_status Modified: cfe/trunk/www/cxx_dr_status.html URL:

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

vsk added a comment. Ping. https://reviews.llvm.org/D22596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

ibadawi created this revision. ibadawi added reviewers: majnemer, rjmccall. ibadawi added a subscriber: cfe-commits. This is a proposed fix for bug 16154 (https://llvm.org/bugs/show_bug.cgi?id=16154) -- it was tentatively fixed in r183084 but had the fix was backed out in r183575 because the

Re: [PATCH] D17820: Clang Code Completion Filtering

junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change : llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default] default:

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

rengolin added a comment. In https://reviews.llvm.org/D22857#497805, @ahatanak wrote: > Is r276859 fixing a bug in the assembler? Sort of. It was just adding a comment character to ; instead of #. > I'm trying to understand why we have to add a clang test in this particular > case because I

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

ahatanak added a subscriber: ahatanak. ahatanak added a comment. Is r276859 fixing a bug in the assembler? I'm trying to understand why we have to add a clang test in this particular case because I don't think we normally add a test in clang every time we fix a bug in the backend or assembler.

Re: [PATCH] D22690: [OpenMP] Add support for mapping array sections through pointer references.

sfantao updated this revision to Diff 65751. sfantao marked an inline comment as done. sfantao added a comment. - Use castAs instead of getAs in pointer type. https://reviews.llvm.org/D22690 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGStmtOpenMP.cpp

Re: [PATCH] D22856: [analyzer] Change -analyze-function to accept qualified names.

NoQ added a comment. > I think it would be better for fully-qualified Objective-C methods to be > specified with their Objective-C-style names. For example: "-[Test1 > myMethodWithY:withX:]". Uhm, need to know more about those. So i just print "`-[`", then fully-qualified class name, then

Re: [PATCH] D22856: [analyzer] Change -analyze-function to accept qualified names.

dcoughlin added a comment. I think it would be better for fully-qualified Objective-C methods to be specified with their Objective-C-style names. For example: "-[Test1 myMethodWithY:withX:]". This would also remove the ambiguity when there are class and instance methods with the same

Re: [PATCH] D22518: Refactor how include paths are appended to the command arguments.

sfantao added a comment. Hi Art, Richard, Thanks for looking at this patch. I tried to address Richard concerns in the last diff. Let me know your thoughts, Thanks again, Samuel Comment at: lib/Driver/Tools.cpp:308-335 @@ -349,1 +307,30 @@ +Action::OffloadKind

Re: [PATCH] D22518: Refactor how include paths are appended to the command arguments.

sfantao updated this revision to Diff 65747. sfantao marked 3 inline comments as done. sfantao added a comment. - Remove of use of SmallVector and include CUDA args only for the regular toolchain. https://reviews.llvm.org/D22518 Files: lib/Driver/Tools.cpp

RE: r276361 - Reverting r275115 which caused PR28634.

Thanks for reverting this, our internal buildbots have gone green again. > Can you add a non-regression test case? > (It seems the test-suite didn’t catch this bug right?) Do we have any upstream buildbots using -O0? I haven't investigated very far* but -O0 seems to be the common factor between

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r276878. Repository: rL LLVM https://reviews.llvm.org/D17820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r276878 - Implement filtering for code completion of identifiers.

Author: vvassilev Date: Wed Jul 27 09:56:59 2016 New Revision: 276878 URL: http://llvm.org/viewvc/llvm-project?rev=276878=rev Log: Implement filtering for code completion of identifiers. Patch by Cristina Cristescu and Axel Naumann! Agreed on post commit review (D17820). Modified:

Re: [llvm-dev] [PATCH] Add support for the 'unless' matcher in the dynamic layer.

Is, but it is still a lot of typing and we are talking about debuging. 2016-07-27 3:40 GMT-07:00 Manuel Klimek : > On Wed, Jul 27, 2016 at 1:06 AM Piotr Padlewski via llvm-dev < > llvm-...@lists.llvm.org> wrote: > >> We could also just add nothing() matcher, so debugging would

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

rengolin requested changes to this revision. This revision now requires changes to proceed. Comment at: test/CodeGen/arm-inline-asm-windows.c:2 @@ +1,3 @@ +// REQUIRES: arm-registered-target +// RUN: %clang -target armv7-windows -c -o - %s + Also, I just noticed,

Re: [PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

rengolin added a subscriber: compnerd. rengolin added a comment. I'll just echo @compnerd comments, since Phab didn't get it. - Change the syntax to __asm__, to be more portable - Add Microsoft asm block syntax cheers, --renato https://reviews.llvm.org/D22857

  1   2   >