I played with modules a bit today, and as far as I can tell this is still
broken. If this proves difficult to fix, should this change be reverted for
now? It breaks using modules on Darwin.
On Sun, Mar 13, 2016 at 12:53 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> > On
sylvestre.ledru added a comment.
The Firefox report is using a previous version of the patch (which could not be
merged upstream: quick and dirty).
If you want, I can update my scan-build instance to use the new version (which
doesn't have the issues you mentioned)
https://reviews.llvm.org/D22
honggyu.kim updated this revision to Diff 65879.
honggyu.kim added a comment.
I've updated the diff that can be working with https://reviews.llvm.org/D22825.
I appreciate your work in backend, Hal.
Please correct me if I'm wrong.
https://reviews.llvm.org/D22666
Files:
lib/CodeGen/CodeGenFun
Author: zijiaoma
Date: Thu Jul 28 01:24:48 2016
New Revision: 276958
URL: http://llvm.org/viewvc/llvm-project?rev=276958&view=rev
Log:
[AArch64] Using AArch64TargetParser in Clang.
This resubmit r270688 which broke some specific buildbots.That's because
there is incorrect indexing problem in the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276958: [AArch64] Using AArch64TargetParser in Clang.
(authored by zijiaoma).
Changed prior to commit:
https://reviews.llvm.org/D21277?vs=60658&id=65878#toc
Repository:
rL LLVM
https://reviews.llvm.
mboehme added a comment.
This was reverted in https://reviews.llvm.org/rL276759 because it broke
modernize-loop-convert.
https://reviews.llvm.org/D22903 contains a fix for the modernize-loop-convert
issue. Will re-submit this patch once https://reviews.llvm.org/D22903 has
landed.
Repository:
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
D22566 will change RecursiveASTVisitor so that it descends into the
initialization expressions for lambda captures.
modernize-loop-convert needs to be prepared for this so that it does not
vmiklos added a comment.
Rebased on top of r276949 and resolved a failing test
(FunctionWithClassFindByName.cpp).
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
vmiklos updated this revision to Diff 65876.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
mstorsjo abandoned this revision.
mstorsjo added a comment.
This test isn't strictly necessary, thus abandoning
https://reviews.llvm.org/D22857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
zaks.anna added inline comments.
Comment at: test/Analysis/diagnostics/Inputs/include/Something.h:1
@@ +1,2 @@
+void clang_analyzer_warnIfReached();
+
Please, choose better file names. Every test that adds something cannot add a
header called something:) It won't
zaks.anna added a comment.
We'd definitely want the same routine in both: printing the name in
-analyzer-display-progress and be accepted by -analyze-function.
Looks like what ND->getQualifiedNameAsString() returns is not proper ObjC
syntax, but maybe it's fine for the debug feature? Even thoug
zaks.anna added a comment.
I am not sure it's the right way of fixing this problem and it introduces a
regression. The bug is probably specific to "&&".
+ Devin as we might have seen something similar.
Comment at: test/Analysis/misc-ps-region-store.m:332
@@ -330,3 +331,3 @@
Author: marshall
Date: Wed Jul 27 23:52:02 2016
New Revision: 276955
URL: http://llvm.org/viewvc/llvm-project?rev=276955&view=rev
Log:
Add a bunch of noexcepts to char_traits and string_view.
Modified:
libcxx/trunk/include/__string
libcxx/trunk/include/string_view
Modified: libcxx/trunk/
zaks.anna added a comment.
The report you are referencing does not seem to have "Description" as a column
name. Also, the titles row is not gray all the way to the right...
https://reviews.llvm.org/D22810
___
cfe-commits mailing list
cfe-commits@li
zaks.anna added inline comments.
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics
does not support diagnostics that cross file boundaries.
ayartsev wrote:
> zaks.anna wrote:
> > We s
majnemer added a comment.
In https://reviews.llvm.org/D22900#498793, @Gerolf wrote:
> Nope, I don't see the tail call. Anyway, I'll simplify my test case. Don't
> worry about it.
>
> clang++ -cc1 -x c++ -emit-llvm -triple i386-apple-darwin9 t.cpp
>
> cat t.ll:
>
> ; ModuleID = 't.cpp'
> source_
Gerolf added a comment.
Nope, I don't see the tail call. Anyway, I'll simplify my test case. Don't
worry about it.
clang++ -cc1 -x c++ -emit-llvm -triple i386-apple-darwin9 t.cpp
cat t.ll:
; ModuleID = 't.cpp'
source_filename = "t.cpp"
target datalayout = "e-m:o-p:32:32-f64:32:64-f80:128-n8:16
majnemer added a comment.
In https://reviews.llvm.org/D22900#498781, @Gerolf wrote:
> Please add the options you used to compile? I can certainly shrink the test
> case a bit before I commit.
clang -cc1 -x c++ -emit-llvm -triple i386-apple-darwin9 t.ii -o -
https://reviews.llvm.org/D22900
Gerolf added a comment.
Please add the options you used to compile? I can certainly shrink the test
case a bit before I commit.
https://reviews.llvm.org/D22900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
majnemer added a subscriber: majnemer.
majnemer added a comment.
The test seems a little large, the following shows that we emit a tail call
with a byval argument on trunk.
struct LARGE {
union {
int i;
};
};
struct I {
virtual void m_fn1(LARGE);
};
struct CBase {
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
teemperor added a comment.
Is there a specific situation/bug we want to test against with these tests? I
looks to me as if they would mainly test against non-determinism (i.e. same
statements have different data due to non-determinism).
Comment at: lib/Analysis/CloneDetection.
Thanks for taking a look at this!
I have two comments:
1. If we’re doing the check at the end of both branches of the if, we might as
well just move it to after.
2. It doesn’t make sense to have a failure that only occurs in C mode in
test/SemaCXX. Maybe just append it to the end of test/Sema/
Gerolf created this revision.
Gerolf added reviewers: eli.friedman, mkuper.
Gerolf added a subscriber: cfe-commits.
This is just closing the loop for
https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg28837.html with a
test case and fixes PR28748 which had been introduced by r244207.
http
teemperor updated this revision to Diff 65857.
teemperor marked 5 inline comments as done.
teemperor added a comment.
- Removed duplicate test case.
https://reviews.llvm.org/D22514
Files:
lib/Analysis/CloneDetection.cpp
test/Analysis/copypaste/false-positives.cpp
test/Analysis/copypaste/f
teemperor updated this revision to Diff 65854.
teemperor added a comment.
- Rebased patch.
- Fixed code style (`const type` instead of `type const`).
- Fixed missing const on some variables in StmtDataCollector.
- Rewrote a few comments/variable names.
https://reviews.llvm.org/D22514
Files:
l
comicfans44 added a comment.
In https://reviews.llvm.org/D21946#473071, @zturner wrote:
> In https://reviews.llvm.org/D21946#473070, @comicfans44 wrote:
>
> > I've not commited to cfe before, so I think I havn't commit access
> > permission.
>
>
> If you've committed anywhere in LLVM, you should
Author: dcoughlin
Date: Wed Jul 27 19:52:10 2016
New Revision: 276950
URL: http://llvm.org/viewvc/llvm-project?rev=276950&view=rev
Log:
[analyzer] Add check::BeginFunction to CheckerDocumentation checks. NFC.
This was an oversight from when I added BeginFunction support in r261293.
Modified:
compnerd closed this revision.
compnerd added a comment.
SVN r276948
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Wed Jul 27 19:43:14 2016
New Revision: 276949
URL: http://llvm.org/viewvc/llvm-project?rev=276949&view=rev
Log:
test: fix typo in file name (NFC)
Added:
clang-tools-extra/trunk/test/clang-rename/ClassNameInFunctionDefinition.cpp
- copied, changed from r276948,
cl
Author: compnerd
Date: Wed Jul 27 19:42:01 2016
New Revision: 276948
URL: http://llvm.org/viewvc/llvm-project?rev=276948&view=rev
Log:
clang-rename: adjust NamedDeclFindingASTVisitor for RecordDecls
Ensure that Context is always properly initialised in the constructor. It is
used for querying th
Author: niravd
Date: Wed Jul 27 19:36:34 2016
New Revision: 276947
URL: http://llvm.org/viewvc/llvm-project?rev=276947&view=rev
Log:
Replace preserve-as-comments CodeGen test with driver test
Added:
cfe/trunk/test/Driver/preserve-as-comments.c
Removed:
cfe/trunk/test/CodeGen/preserve-as-c
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob,
kkwli0, tra.
sfantao added subscribers: cfe-commits, caomhin.
This patch prevents OpenMP flags from being forwarded to CUDA device commands.
That was causing the CUDA frontend to attempt to em
r272587 (http://reviews.llvm.org/D20490) fixed an issue where typo correction
could cause a crash when compiling C programs.The problem was that a typo
expression could be inadvertently processed twice.r272587 fixed this for
BinOp expressions. Conditional expressions can hit the same p
I hear that he is on vacation.
On Wednesday, July 27, 2016, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Richard: ping?
>
> On Fri, Jul 22, 2016 at 7:00 AM, Hans Wennborg > wrote:
> > Richard: should we merge this to 3.9?
> >
> > On Thu, Jul 21, 2016 at 6:31 PM, Erik Pilk
Richard: ping?
On Fri, Jul 22, 2016 at 7:00 AM, Hans Wennborg wrote:
> Richard: should we merge this to 3.9?
>
> On Thu, Jul 21, 2016 at 6:31 PM, Erik Pilkington via cfe-commits
> wrote:
>> Author: epilk
>> Date: Thu Jul 21 17:31:40 2016
>> New Revision: 276350
>>
>> URL: http://llvm.org/viewvc/
Should this be merged to 3.9?
Thanks,
Hans
On Wed, Jul 27, 2016 at 11:25 AM, Erik Pilkington via cfe-commits
wrote:
> Author: epilk
> Date: Wed Jul 27 13:25:10 2016
> New Revision: 276900
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276900&view=rev
> Log:
> [Sema] Teach getCurrentThisType to
On 27 July 2016 at 21:57, Nirav Davé wrote:
> Looks like I missed the target triple. Should work now.
Still failing on *all* ARM targets.
'No available targets are compatible with this triple.'
Please move the test to an x86 directory.
http://llvm.org/docs/TestingGuide.html#platform-specific-t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276937: Retry: [Driver] Compute effective target triples
once per job (NFCI) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D22596?vs=64792&id=65829#toc
Repository:
rL LLVM
Author: vedantk
Date: Wed Jul 27 18:02:20 2016
New Revision: 276937
URL: http://llvm.org/viewvc/llvm-project?rev=276937&view=rev
Log:
Retry: [Driver] Compute effective target triples once per job (NFCI)
Compute an effective triple once per job. Cache the triple in the
prevailing ToolChain for the
Author: vedantk
Date: Wed Jul 27 18:01:55 2016
New Revision: 276936
URL: http://llvm.org/viewvc/llvm-project?rev=276936&view=rev
Log:
Revert "[Driver] Compute effective target triples once per job (NFCI)"
This reverts commit r275895 in order to address some post-commit review
feedback from Eric C
Author: sfantao
Date: Wed Jul 27 17:52:16 2016
New Revision: 276934
URL: http://llvm.org/viewvc/llvm-project?rev=276934&view=rev
Log:
[OpenMP] Add support to map member expressions with references to pointers.
Summary: This patch add support to map pointers through references in class
members. A
Author: sfantao
Date: Wed Jul 27 17:49:49 2016
New Revision: 276933
URL: http://llvm.org/viewvc/llvm-project?rev=276933&view=rev
Log:
[OpenMP] Add support for mapping array sections through pointer references.
Summary:
This patch fixes a bug in the map of array sections whose base is a reference
mprobst added a comment.
Friendly ping :-)
https://reviews.llvm.org/D22431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: matze
Date: Wed Jul 27 17:47:07 2016
New Revision: 276930
URL: http://llvm.org/viewvc/llvm-project?rev=276930&view=rev
Log:
test/Frontend: Add a test for aarch64 target CPU names.
Nothing else checked the target cpu names for aarch64 yet.
Add a test in the spirit of x86-target-cpu.c.
Add
Author: matze
Date: Wed Jul 27 17:47:09 2016
New Revision: 276931
URL: http://llvm.org/viewvc/llvm-project?rev=276931&view=rev
Log:
Basic/Targets.cpp: Reformat aarch64 CPU list.
Having 1 entry per line and an alphabetical order is clearer and reduces
the risk of invalid merges.
Modified:
cfe
Author: sfantao
Date: Wed Jul 27 17:46:31 2016
New Revision: 276929
URL: http://llvm.org/viewvc/llvm-project?rev=276929&view=rev
Log:
Refactor how include paths are appended to the command arguments.
Summary:
This patch aims at removing redundancy in the way include paths for the regular
and off
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:509
@@ +508,3 @@
+ //}
+ // }
+ //}
I disagree about compactness being valuable here. I think it is more important
to intrinsically document the spec.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276927: [CUDA] Align kernel launch args correctly when the
LLVM type's alignment is… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D22879?vs=65800&id=65824#toc
Repository:
r
Author: jlebar
Date: Wed Jul 27 17:36:21 2016
New Revision: 276927
URL: http://llvm.org/viewvc/llvm-project?rev=276927&view=rev
Log:
[CUDA] Align kernel launch args correctly when the LLVM type's alignment is
different from the clang type's alignment.
Summary:
Before this patch, we computed the
manmanren abandoned this revision.
manmanren added a comment.
Abandon this change for now.
https://reviews.llvm.org/D22636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D22879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
Ok, sounds good. Feel free to abandon this one as well.
cheers,
--renato
https://reviews.llvm.org/D22857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin added a comment.
In https://reviews.llvm.org/D22856#497796, @NoQ wrote:
> > I think it would be better for fully-qualified Objective-C methods to be
> > specified with their Objective-C-style names. For example: "-[Test1
> > myMethodWithY:withX:]".
>
>
> Uhm, need to know more about t
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
A couple of nits. Otherwise, LGTM. Thanks!
Comment at: www/analyzer/checker_dev_manual.html:534
@@ +533,3 @@
+itself to the child process (for example, in gcc you can
+s
Author: jlebar
Date: Wed Jul 27 17:04:24 2016
New Revision: 276925
URL: http://llvm.org/viewvc/llvm-project?rev=276925&view=rev
Log:
Don't crash when generating code for __attribute__((naked)) member functions.
Summary:
Previously this crashed inside EmitThisParam(). There should be no
prelude f
sfantao updated this revision to Diff 65813.
sfantao updated the summary for this revision.
sfantao added a comment.
- Remove unecessary brief directives from comments.
https://reviews.llvm.org/D22788
Files:
include/clang/AST/OpenMPClause.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/A
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:3410-3411
@@ +3409,4 @@
+ llvm::DenseSet EmittedAsFirstprivate;
+ CGCapturedStmtInfo CapturesInfo(cast(*D.getAssociatedStmt()));
+ for (const auto *C : D.getClausesOfKind()) {
sfantao updated this revision to Diff 65810.
sfantao marked 8 inline comments as done.
sfantao added a comment.
- Remove unnecessary brief directives and refactor target data privatization
code genenration.
https://reviews.llvm.org/D22691
Files:
include/clang/AST/OpenMPClause.h
lib/AST/Ope
echristo added a comment.
Go ahead and split out your cleanups into another patch and remove the custom
handling in the hexagon target then.
Thanks!
-eric
Repository:
rL LLVM
https://reviews.llvm.org/D22766
___
cfe-commits mailing list
cfe-com
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Not a huge fan of the registration/etc. That said, this is cleaner than a lot
of the alternatives at the moment without making you do a lot of toolchain
evisceration.
LGTM.
-eric
https
jlebar added inline comments.
Comment at: test/CodeGenCUDA/kernel-args-alignment.cu:1-2
@@ +1,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+
rnk wrote:
> Typically clang doesn't need a registered backend for a target to generate I
jlebar updated this revision to Diff 65800.
jlebar added a comment.
Remove REQUIRES lines.
https://reviews.llvm.org/D22879
Files:
lib/CodeGen/CGCUDABuiltin.cpp
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/kernel-args-alignment.cu
Index: test/CodeGenCUDA/kernel-args-alignment.cu
Looks like I missed the target triple. Should work now.
Thanks,
-Nirav
On Wed, Jul 27, 2016 at 4:41 PM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> Hi Nirav,
>
> This test is failing on darwin:
>
> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574
>
>
Author: niravd
Date: Wed Jul 27 15:48:39 2016
New Revision: 276915
URL: http://llvm.org/viewvc/llvm-project?rev=276915&view=rev
Log:
Add target triple in test
Modified:
cfe/trunk/test/CodeGen/preserve-as-comments.c
Modified: cfe/trunk/test/CodeGen/preserve-as-comments.c
URL:
http://llvm.org
Hi Nirav,
This test is failing on darwin:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574
Can you take a look?
On Wed, Jul 27, 2016 at 12:57 PM, Nirav Dave via cfe-commits
wrote:
> Author: niravd
> Date: Wed Jul 27 14:57:40 2016
> New Revision: 276907
>
> URL: h
Author: mmasten
Date: Wed Jul 27 15:23:32 2016
New Revision: 276912
URL: http://llvm.org/viewvc/llvm-project?rev=276912&view=rev
Log:
test commit
Modified:
cfe/trunk/include/clang/Frontend/CodeGenOptions.h
Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.h
URL:
http://llvm.org/view
Fixed in r276889 by Simon Pilgrim!
On 27/07/16 22:03, Vassil Vassilev wrote:
Looking into it.
On 27/07/16 18:34, Jun Bum Lim wrote:
junbuml added a subscriber: junbuml.
junbuml added a comment.
It appears that build fails due to this change :
llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:
Thanks a lot!
On 27/07/16 18:41, Simon Pilgrim via cfe-commits wrote:
Author: rksimon
Date: Wed Jul 27 11:41:56 2016
New Revision: 276889
URL: http://llvm.org/viewvc/llvm-project?rev=276889&view=rev
Log:
Fix unnecessary default switch warning
Modified:
cfe/trunk/lib/Sema/CodeCompleteConsum
yaxunl updated this revision to Diff 65796.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments. Added missing codegen test.
https://reviews.llvm.org/D21567
Files:
include/clang/AST/OperationKinds.def
include/clang/Basic/DiagnosticGroups.td
inc
yaxunl marked 9 inline comments as done.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:84
@@ +83,3 @@
+SamplerTy = llvm::PointerType::get(llvm::StructType::create(
+ CGM.getLLVMContext(), "__opencl_sampler_t"),
+ CGM.getContext().getTargetAddressSpace(
Author: niravd
Date: Wed Jul 27 14:57:40 2016
New Revision: 276907
URL: http://llvm.org/viewvc/llvm-project?rev=276907&view=rev
Log:
Add flags to toggle preservation of assembly comments
Summary: Add -fpreserve-as-comments and -fno-preserve-as-comments.
Reviewers: echristo, rnk
Subscribers: meh
Looking into it.
On 27/07/16 18:34, Jun Bum Lim wrote:
junbuml added a subscriber: junbuml.
junbuml added a comment.
It appears that build fails due to this change :
llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label
in switch which covers all enumeration values [-W
mstorsjo added a comment.
In https://reviews.llvm.org/D22857#497719, @rengolin wrote:
> I'll just echo @compnerd comments, since Phab didn't get it.
>
> - Change the syntax to __asm__, to be more portable
> - Add Microsoft asm block syntax
MSVC doesn't support inline assembly on ARM at all (the
Author: pirama
Date: Wed Jul 27 14:01:51 2016
New Revision: 276904
URL: http://llvm.org/viewvc/llvm-project?rev=276904&view=rev
Log:
Adjust coercion of aggregates on RenderScript
Summary:
In RenderScript, the size of the argument or return value emitted in the
IR is expected to be the same as the
alexshap created this revision.
alexshap added reviewers: klimek, omtcyfz.
alexshap added subscribers: compnerd, cfe-commits.
alexshap changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
Properly initialize the field Context in NamedDeclFindingAS
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276900: [Sema] Teach getCurrentThisType to reconize lambda
in in-class initializer (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D21145?vs=60622&id=65779#toc
Repository:
rL L
Author: epilk
Date: Wed Jul 27 13:25:10 2016
New Revision: 276900
URL: http://llvm.org/viewvc/llvm-project?rev=276900&view=rev
Log:
[Sema] Teach getCurrentThisType to reconize lambda in in-class initializer
Fixes PR27994, a crash on valid.
Differential revision: https://reviews.llvm.org/D21145
rnk added inline comments.
Comment at: test/CodeGenCUDA/kernel-args-alignment.cu:1-2
@@ +1,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+
Typically clang doesn't need a registered backend for a target to generate IR
for that targ
Anastasia added a comment.
Btw, I am missing tests for generated __translate_sampler_initializer which I
think we had at some point.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:84
@@ +83,3 @@
+SamplerTy = llvm::PointerType::get(llvm::StructType::create(
+ CGM.getLLVMCo
ashi1 updated this revision to Diff 65773.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Removed indentation as per Anastasia's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D22637
Files:
include/clang/Basic/OpenCLExtensions.def
lib/Basic/Targets.cpp
test/Misc
Author: niravd
Date: Wed Jul 27 12:39:47 2016
New Revision: 276896
URL: http://llvm.org/viewvc/llvm-project?rev=276896&view=rev
Log:
Update Clang Parser test error message to match new parser errors
Modified:
cfe/trunk/test/Parser/ms-inline-asm.c
Modified: cfe/trunk/test/Parser/ms-inline-asm
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
Before this patch, we computed the offsets in memory of args passed to
GPU kernel functions by throwing all of the args into an LLVM struct.
clang emits packed llvm structs basically whenever i
ibadawi updated this revision to Diff 65765.
ibadawi added a comment.
Restore the test lost in patch #2. Really sorry for the noise...
https://reviews.llvm.org/D22871
Files:
lib/Sema/SemaChecking.cpp
test/Sema/outof-range-constant-compare.c
Index: test/Sema/outof-range-constant-compare.c
=
ibadawi updated this revision to Diff 65763.
ibadawi added a comment.
Remove extra blank line added by accident
https://reviews.llvm.org/D22871
Files:
lib/Sema/SemaChecking.cpp
Index: lib/Sema/SemaChecking.cpp
===
--- lib/Sema/S
NoQ created this revision.
NoQ added a reviewer: zaks.anna.
NoQ added subscribers: dcoughlin, xazax.hun, a.sidorin, cfe-commits.
1. Fix the explanation of how to run tests after migration from autotools to
cmake.
2. Expand the "debugging" section with more interesting stuff, as accidentally
dis
Author: hans
Date: Wed Jul 27 11:56:03 2016
New Revision: 276891
URL: http://llvm.org/viewvc/llvm-project?rev=276891&view=rev
Log:
UsersManual.rst: update clang-cl option list
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-
Anastasia added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+ #endif
+#else
+ #ifdef cl_khr_mipmap_image
Looks good! Could you just remove indentation please as it's not common for C
macros?
The same for the test below!
tra added a comment.
Looks good.
https://reviews.llvm.org/D22518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rksimon
Date: Wed Jul 27 11:41:56 2016
New Revision: 276889
URL: http://llvm.org/viewvc/llvm-project?rev=276889&view=rev
Log:
Fix unnecessary default switch warning
Modified:
cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp
Modified: cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp
URL:
http:
Author: hans
Date: Wed Jul 27 11:39:45 2016
New Revision: 276887
URL: http://llvm.org/viewvc/llvm-project?rev=276887&view=rev
Log:
Update cxx_dr_Status after 3.9 branch
Modified:
cfe/trunk/www/cxx_dr_status.html
cfe/trunk/www/make_cxx_dr_status
Modified: cfe/trunk/www/cxx_dr_status.html
vsk added a comment.
Ping.
https://reviews.llvm.org/D22596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ibadawi created this revision.
ibadawi added reviewers: majnemer, rjmccall.
ibadawi added a subscriber: cfe-commits.
This is a proposed fix for bug 16154
(https://llvm.org/bugs/show_bug.cgi?id=16154) -- it was tentatively fixed in
r183084 but had the fix was backed out in r183575 because the app
junbuml added a subscriber: junbuml.
junbuml added a comment.
It appears that build fails due to this change :
llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label
in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]
default: llvm_unreacha
rengolin added a comment.
In https://reviews.llvm.org/D22857#497805, @ahatanak wrote:
> Is r276859 fixing a bug in the assembler?
Sort of. It was just adding a comment character to ; instead of #.
> I'm trying to understand why we have to add a clang test in this particular
> case because I d
ahatanak added a subscriber: ahatanak.
ahatanak added a comment.
Is r276859 fixing a bug in the assembler?
I'm trying to understand why we have to add a clang test in this particular
case because I don't think we normally add a test in clang every time we fix a
bug in the backend or assembler.
sfantao updated this revision to Diff 65751.
sfantao marked an inline comment as done.
sfantao added a comment.
- Use castAs instead of getAs in pointer type.
https://reviews.llvm.org/D22690
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_map_codegen
1 - 100 of 172 matches
Mail list logo
