Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

gribozavr added a subscriber: gribozavr. gribozavr added a comment. > If a user specifies "-fsanitize=" I think it is expected that the > sanitizer library would be included on the link line. I deeply disagree. If the user asks for `-nodefaultlibs`, we should not add any libraries ourselves,

r280337 - Remove whitespace to test commit access

Author: honggyu.kim Date: Thu Sep 1 01:14:45 2016 New Revision: 280337 URL: http://llvm.org/viewvc/llvm-project?rev=280337&view=rev Log: Remove whitespace to test commit access Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp URL: htt

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

zlei edited reviewers, added: bruno; removed: cfe-commits. zlei edited subscribers, added: cfe-commits; removed: bruno. zlei updated this revision to Diff 69947. zlei added a comment. Update the man page entry to state default behavior of this option. https://reviews.llvm.org/D24069 Files: do

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: zaks.anna, kubabrecka, bogner. > beanz added a subscriber: cfe-commits. > > The -nodefaultlibs and -nostdlib flags suppress all the runtime > libraries that the driver puts on the link line. This feels wrong. If > a use

Re: r262189 - [modules] Prefer more complete array types.

On 01/09/16 02:59, Akira Hatanaka wrote: I’ve come up with a patch and sent it to the list today since it is urgent to fix. https://reviews.llvm.org/D24110 Thank you. I saw it landed in the trunk. Thanks! On Aug 31, 2016, at 1:50 PM, Vassil Vassilev > wrote:

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: bogner, zaks.anna, bruno, filcab. > beanz added a subscriber: cfe-commits. > Herald added a subscriber: emaste. > > The FreeBSD and GNUTools drivers support -fsanitize arguments > bypassing -nodefaultlibs. With https://

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

mclow.lists added a comment. Other than the iterator.primitives/iterator.operations/prev.pass.cpp test, I think this is good to go. Comment at: test/std/iterators/iterator.primitives/iterator.operations/prev.pass.cpp:47 @@ +46,3 @@ + +{ +constexpr const char* s = "

[PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

zlei created this revision. zlei added a reviewer: cfe-commits. This option is used to avoid underlinking. It's available in LLVM's main tree, but not in a standalone build of libc++. This patch ensures the option is passed in whether libc++ is built in-tree or out-of-tree. https://reviews.llvm

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

This revision was automatically updated to reflect the committed changes. Closed by commit rL280330: [Sema] Don't diagnose an array type mismatch when the new or previous (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D24110?vs=69927&id=69935#toc Repository: rL LLV

[libcxx] r280335 - Fix libc++ configuration with -fsanitize-coverage

Author: krasin Date: Wed Aug 31 20:38:32 2016 New Revision: 280335 URL: http://llvm.org/viewvc/llvm-project?rev=280335&view=rev Log: Fix libc++ configuration with -fsanitize-coverage Summary: a recent change (r280015) in libc++ configuration broke LibFuzzer bot: http://lab.llvm.org:8011/builders/

r280333 - Fix typos in comments.

Author: gbiv Date: Wed Aug 31 20:26:58 2016 New Revision: 280333 URL: http://llvm.org/viewvc/llvm-project?rev=280333&view=rev Log: Fix typos in comments. Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/

[PATCH] D24115: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

r280330 - [Sema] Don't diagnose an array type mismatch when the new or previous

Author: ahatanak Date: Wed Aug 31 20:03:21 2016 New Revision: 280330 URL: http://llvm.org/viewvc/llvm-project?rev=280330&view=rev Log: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type. This fixes a bug where clang errors out on a valid code.

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak added a comment. I'll commit the patch as-is first and come up with a new patch which implements the improvements you suggested later. https://reviews.llvm.org/D24110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Context.hasSameType(NewArray, PrevVDTy)) return diagnoseVarDeclTypeMismatch(*this, New, PrevVD); } rsmith wrote: > ahatanak wr

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

bruno added inline comments. Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi zlei wrote: > bruno wrote: > > It might be worth mentioning what's the default behaviour in case the flag > > isn't specified? > This

[PATCH] D24113: Allow implicit conversions between incompatible pointer types in overload resolution in C.

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. In C, we allow pointer conversions like: ``` void foo(int *a); long b; void runFoo() { foo(&b); } ``` ...But not when overloading: ``` int bar(char *a) __attri

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

zlei added inline comments. Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi bruno wrote: > It might be worth mentioning what's the default behaviour in case the flag > isn't specified? This option behaves a lot

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Context.hasSameType(NewArray, PrevVDTy)) return diagnoseVarDeclTypeMismatch(*this, New, PrevVD); } ahatanak wrote: > rsmith wrot

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Context.hasSameType(NewArray, PrevVDTy)) return diagnoseVarDeclTypeMismatch(*this, New, PrevVD); } rsmith wrote: > If you do u

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM as-is, but one suggestion if you want to still allow diagnosing a few more cases. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Con

Re: r262189 - [modules] Prefer more complete array types.

I’ve come up with a patch and sent it to the list today since it is urgent to fix. https://reviews.llvm.org/D24110 Thank you. > On Aug 31, 2016, at 1:50 PM, Vassil Vassilev wrote: > > Hi Akira, > Thanks for your email. I am on vacation right now and I will

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3370-3374 @@ -3369,7 +3369,7 @@ // mismatch. - if (!NewArray->isIncompleteArrayType()) { + if (!NewArray->isIncompleteArrayType() && !NewArray->isDependentType()) { for (VarDecl *PrevVD = Old

[PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak created this revision. ahatanak added reviewers: v.g.vassilev, rsmith. ahatanak added a subscriber: cfe-commits. We shouldn't compare the bounds of two arrays and issue a diagnostic if one of them is dependent. https://reviews.llvm.org/D24110 Files: lib/Sema/SemaDecl.cpp test/SemaT

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz updated this revision to Diff 69926. beanz added a comment. - Changed warning text based on feedback from bruno - Made the warning apply to -nostdlib as well as -nodefaultlibs based on offline discussion with Anna https://reviews.llvm.org/D24091 Files: include/clang/Basic/DiagnosticDri

[libunwind] r280324 - Creating release candidate final from release_390 branch

Author: hans Date: Wed Aug 31 18:31:40 2016 New Revision: 280324 URL: http://llvm.org/viewvc/llvm-project?rev=280324&view=rev Log: Creating release candidate final from release_390 branch Added: libunwind/tags/RELEASE_390/final/ (props changed) - copied from r280323, libunwind/branche

[libcxxabi] r280318 - Creating release candidate final from release_390 branch

Author: hans Date: Wed Aug 31 18:31:22 2016 New Revision: 280318 URL: http://llvm.org/viewvc/llvm-project?rev=280318&view=rev Log: Creating release candidate final from release_390 branch Added: libcxxabi/tags/RELEASE_390/final/ (props changed) - copied from r280317, libcxxabi/branche

[libcxx] r280317 - Creating release candidate final from release_390 branch

Author: hans Date: Wed Aug 31 18:31:18 2016 New Revision: 280317 URL: http://llvm.org/viewvc/llvm-project?rev=280317&view=rev Log: Creating release candidate final from release_390 branch Added: libcxx/tags/RELEASE_390/final/ (props changed) - copied from r280316, libcxx/branches/rele

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support diagno

r280309 - Fix all tests under test/CXX (and test/Analysis) to pass if clang's default

Author: rsmith Date: Wed Aug 31 18:24:08 2016 New Revision: 280309 URL: http://llvm.org/viewvc/llvm-project?rev=280309&view=rev Log: Fix all tests under test/CXX (and test/Analysis) to pass if clang's default C++ language standard is not C++98. Modified: cfe/trunk/test/Analysis/misc-ps-region

r280308 - DR259: Demote the pedantic error for an explicit instantiation after an

Author: rsmith Date: Wed Aug 31 18:23:25 2016 New Revision: 280308 URL: http://llvm.org/viewvc/llvm-project?rev=280308&view=rev Log: DR259: Demote the pedantic error for an explicit instantiation after an explicit specialization to a warning for C++98 mode (this is a defect report resolution, so p

r280306 - Add -fprofile-dir= to clang.

Author: nicholas Date: Wed Aug 31 18:04:32 2016 New Revision: 280306 URL: http://llvm.org/viewvc/llvm-project?rev=280306&view=rev Log: Add -fprofile-dir= to clang. -fprofile-dir=path allows the user to specify where .gcda files should be emitted when the program is run. In particular, this is the

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

bruno added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:276 @@ +275,3 @@ +def warn_drv_sanitizers_and_nodefaultlibs : Warning< + "Passing -nodefaultlibs and -fsanitize has resulted in linking sanitizer runtimes.">, + InGroup>; What

[PATCH] D24105: [libc++] Limit gets to CRT versions below 14

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added subscribers: cfe-commits, kastiglione. Microsoft removed gets from the CRT in Visual Studio 2015 onwards [1]. Attempting to reference it when targeting CRT versions 14 and above will cause compile

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support diagnos

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz updated this revision to Diff 69910. beanz added a comment. Updates based on bruno's feedback. https://reviews.llvm.org/D24091 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/SanitizerArgs.h lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/Tool

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support diagno

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. @zaks.anna, the driver behind this is supporting building libcxx with sanitizers. The drivers for GNUTools and FreeBSD already support this workflow. I have updates to the test in https://reviews.llvm.org/D24091, which also cover this code. I'll push the updated test shor

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev added a comment. Gentle ping. https://reviews.llvm.org/D22494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz created this revision. beanz added reviewers: bogner, zaks.anna, bruno, filcab. beanz added a subscriber: cfe-commits. Herald added a subscriber: emaste. The FreeBSD and GNUTools drivers support -fsanitize arguments bypassing -nodefaultlibs. With https://reviews.llvm.org/D24048, Darwin will

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

zaks.anna added a comment. -nostdlib is often used to build parts of libsystem. It's worth noting that ASan and TSan are not supported for use on libsystem on darwin (and elsewhere?), though some subcomponents of it can be sanitized. I am not sure how this relates to UBSan. The user experience

Re: [PATCH] D24097: Add testcases for PR30188

rsmith added a subscriber: rsmith. rsmith requested changes to this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision now requires changes to proceed. This belongs in LLVM's test suite, not Clang's. https://reviews.llvm.org/D24097 ___

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

nlewycky updated this revision to Diff 69905. https://reviews.llvm.org/D23734 Files: lib/Transforms/Instrumentation/GCOVProfiling.cpp test/Transforms/GCOVProfiling/three-element-mdnode.ll tools/clang/include/clang/Driver/CC1Options.td tools/clang/include/clang/Driver/Options.td tools/cl

r280290 - DebugInfo: Fix -gsplit-dwarf + -fno-split-dwarf-inlining

Author: dblaikie Date: Wed Aug 31 15:54:35 2016 New Revision: 280290 URL: http://llvm.org/viewvc/llvm-project?rev=280290&view=rev Log: DebugInfo: Fix -gsplit-dwarf + -fno-split-dwarf-inlining I tested the cases involving split-dwarf + gmlt + no-split-dwarf-inlining, but didn't verify the simpler

Re: [PATCH] D24097: Add testcases for PR30188

davidxl added inline comments. Comment at: clang/test/CodeGen/pr30188.c:3 @@ +2,3 @@ + +// Check that optimizers are able to optimize the number of loads in the loop. +// CHECK: load Can you just do ... | grep load | count 3 Comment at: clang/

Re: r262189 - [modules] Prefer more complete array types.

Hi Akira, Thanks for your email. I am on vacation right now and I will try to look at this issue as soon as I can. Sorry for the inconvenience. Cheers, Vassil On 31/08/16 22:56, Akira Hatanaka wrote: Vassil and Richard, After this commit, clang errors out when compiling the following code,

r280289 - Don't diagnoes a mismatch between implicit and explicit exception

Author: rsmith Date: Wed Aug 31 15:38:32 2016 New Revision: 280289 URL: http://llvm.org/viewvc/llvm-project?rev=280289&view=rev Log: Don't diagnoes a mismatch between implicit and explicit exception specifications under -fno-exceptions, just as we don't diagnose other exception specification misma

r280288 - Fix mishandling of deletedness for assignment operators of classes with

Author: rsmith Date: Wed Aug 31 15:37:39 2016 New Revision: 280288 URL: http://llvm.org/viewvc/llvm-project?rev=280288&view=rev Log: Fix mishandling of deletedness for assignment operators of classes with indirect virtual bases. We don't need to be able to invoke such an assignment operator from t

r280287 - [codeview] Don't emit vshape info for classes without vfptrs

Author: rnk Date: Wed Aug 31 15:35:01 2016 New Revision: 280287 URL: http://llvm.org/viewvc/llvm-project?rev=280287&view=rev Log: [codeview] Don't emit vshape info for classes without vfptrs Classes with no virtual methods or whose virtual methods were all inherited from virtual bases don't have

[PATCH] D24099: [libc++] Don't add -fPIC on Windows

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. -fPIC doesn't make much sense for Windows, since Windows DLLs aren't compiled position independent and are instead relocated at runtime instead. https://reviews.llvm.org

[libcxxabi] r280286 - libc++abi: fix some -Wunused-function warnings

Author: compnerd Date: Wed Aug 31 15:29:05 2016 New Revision: 280286 URL: http://llvm.org/viewvc/llvm-project?rev=280286&view=rev Log: libc++abi: fix some -Wunused-function warnings is_initialized is only used in the no threads case or if on non ARM Apple targets. Use the preprocessor to remove

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz added a comment. I can change the implementation, but that quickly falls into target specific driver code. It results in adding the warning in one place for Darwin, another for FreeBSD, and a third for GNUTools. If that is the preferred way I can work up that patch. https://reviews.llvm

Re: r262189 - [modules] Prefer more complete array types.

Vassil and Richard, After this commit, clang errors out when compiling the following code, which used to compile without any errors. $ cat f2.cpp extern int compile_time_assert_failed[1]; template class C { enum { D }; public: template void foo1() { extern int compile_time_assert_failed[ (

r280281 - Revert "Driver: use the canonical static library naming"

Author: compnerd Date: Wed Aug 31 14:27:07 2016 New Revision: 280281 URL: http://llvm.org/viewvc/llvm-project?rev=280281&view=rev Log: Revert "Driver: use the canonical static library naming" This breaks chromium and its unclear if this is actually a modern convention. This reverts SVN r280169.

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

bruno added a comment. Hi Chris, Thanks for doing this. Comment at: lib/Driver/Driver.cpp:1554 @@ -1551,1 +1553,3 @@ +Args.hasArg(options::OPT_fsanitize_EQ)) + Diag(clang::diag::warn_drv_sanitizers_and_nodefaultlibs); } How hard is to fire the w

[PATCH] D24097: Add testcases for PR30188

sebpop created this revision. sebpop added reviewers: jmolloy, danielcdh, davidxl, mkuper, dberlin. sebpop added subscribers: llvm-commits, cfe-commits. Add testcases to clang test/ to make sure that the combined middle-end optimizations do not regress on optimizing the number of loads in the loop

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

bcraig added a comment. In https://reviews.llvm.org/D21803#530678, @tavianator wrote: > Ping? Well, I still think it's fine. Maybe a direct message to @mclow.lists or @EricWF? https://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator added a comment. Ping? https://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r280169 - Driver: use the canonical static library naming

This broke the win asan build: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/28203 More generally, though, this seems like it's a Boost convention and an MSVCRT convention, and not a general Windows convention: http://www.boost.org/doc/libs/1_42_0/more/getting_started/windows.html#lib

r280269 - Fix a typo in a comment.

Author: gbiv Date: Wed Aug 31 13:14:15 2016 New Revision: 280269 URL: http://llvm.org/viewvc/llvm-project?rev=280269&view=rev Log: Fix a typo in a comment. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://llvm.org/viewvc/llvm-project/cf

Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

rengolin added a comment. This looks like a work around the fact that --rtlib is being ignored with --nodefaultlibs. I'm not sure that's a sane behaviour, if you explicitly specify --rtlib. https://reviews.llvm.org/D24083 ___ cfe-commits mailing l

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

bruno added a subscriber: bruno. bruno added a comment. Hi Lei, Thanks for the doc improvement! Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi It might be worth mentioning what's the default behaviour in case

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. I've sent out an additional patch that adds a warning for using -nostdlibs and -fsanitize (See: https://reviews.llvm.org/D24091) https://reviews.llvm.org/D24048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D19910: [unwinder] Get rid of unused code

logan accepted this revision. logan added a comment. This revision is now accepted and ready to land. Sorry for the late reply. Thanks for your work. Yes, this is correct. However, it seems that this differential can be closed since it has been committed as https://reviews.llvm.org/rL271737.

Re: [PATCH] D24040: codechecker tool core

mehdi_amini added a comment. > This looks like a fairly large tool. Should it get its own "subproject level" > directory in the SVN instead of being nested within clang? I'd add that the clang-tools-extra are more closely tied to clang than what this seems to be. Is there a strong rev-lock wit

Re: [PATCH] D24040: codechecker tool core

mehdi_amini added a subscriber: mehdi_amini. mehdi_amini added a comment. This looks like a fairly large tool. Should it get its own "subproject level" directory in the SVN instead of being nested within clang? Comment at: tools/codechecker/README.md:50 @@ +49,3 @@ +# get sourc

r280257 - s/static inline/static/ for headers I have changed in r279475. NFC.

Author: timshen Date: Wed Aug 31 11:48:13 2016 New Revision: 280257 URL: http://llvm.org/viewvc/llvm-project?rev=280257&view=rev Log: s/static inline/static/ for headers I have changed in r279475. NFC. Modified: cfe/trunk/include/clang/AST/StmtGraphTraits.h cfe/trunk/include/clang/Analysi

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. I am planning to submit this today if there are no further suggestions. https://reviews.llvm.org/D23848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24084: [CMake] Cleanup libunwind lookup code.

rengolin added a comment. In https://reviews.llvm.org/D24084#530427, @logan wrote: > We can either (1) specify the path to libunwind or (2) manually download > `unwind.h` header from libunwind project and place it to `include` directory. That is a horrible dependency... I never hit it because

Re: [PATCH] D24084: [CMake] Cleanup libunwind lookup code.

logan added a comment. In https://reviews.llvm.org/D24084#530433, @rengolin wrote: > That is a horrible dependency... I never hit it because I always test libc++ > with libunwind. I think the best solution is to move/merge `libunwind/include/unwind.h` to/with `clang/lib/Headers/unwind.h`. An

[PATCH] D24087: [lit] Allow more file extensions for test cases.

logan created this revision. logan added reviewers: mclow.lists, EricWF. logan added a subscriber: cfe-commits. This commit splits the file extensions before determining the test format. This allows libc++abi to add assembly-based test cases. https://reviews.llvm.org/D24087 Files: test/libcxx

r280255 - [codeview] Pass through vftable shape information

Author: rnk Date: Wed Aug 31 11:11:43 2016 New Revision: 280255 URL: http://llvm.org/viewvc/llvm-project?rev=280255&view=rev Log: [codeview] Pass through vftable shape information The shape is really just the number of methods in the vftable, since we don't support 16 bit far calls. All calls are

Re: [PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

rengolin added a comment. That match would only make sense if LLVM's unwinder was forced on ARM targets, and they're most certainly not. Expecting both unwindwers to behave identically makes no sense. This fix looks good to me, but I'll let Marshall or Eric have a look first. https://reviews.

Re: [PATCH] D24024: Checkout cfe when building clang-tools-extra docs.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D24024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D24084: [CMake] Cleanup libunwind lookup code.

logan added a comment. Yes. This is what we have today. We can either (1) specify the path to libunwind or (2) manually download `unwind.h` header from libunwind project and place it to `include` directory. https://reviews.llvm.org/D24084 ___ cfe

[PATCH] D24081: [CMake] Fix libc++abi standalone cmake build.

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF. logan added a subscriber: cfe-commits. The cmake files install directory has been changed to ${prefix}/lib/cmake/llvm since r259821. Searching cmake modules in ${prefix}/share/llvm/cmake will result in fatal errors

Re: [PATCH] D24084: [CMake] Cleanup libunwind lookup code.

rengolin added a comment. > We have to do so because we need the modified "unwind.h" from libunwind. > (Note: which is bundled with clang/gcc is not sufficient.) So, you need libunwind's sources, even if you're not building or using them, to build libc++abi? https://reviews.llvm.org/D24084

[PATCH] D24084: [CMake] Cleanup libunwind lookup code.

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF, danalbert, thakis. logan added a subscriber: cfe-commits. This commit refines the code for libunwind lookup. First, this commit will always search for libunwind no matter LLVM unwinder is enabled or not. We have t

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF. logan added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. This commit fixes libc++abi build when LLVM unwinder (libunwind_llvm) is not enabled. This commit fixes the problem by

[PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF. logan added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This commit fixes __aeabi_idiv() link error when we are building libc++abi with compiler-rt. When compiler-rt is enabled, the option `--rt

[PATCH] D24085: arm: Fix ttype encoding assertion failure.

logan created this revision. logan added reviewers: mclow.lists, rengolin. logan added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. GCC 4.7 or newer emits 0x90 (indirect | pcrel) as the ttype encoding. This would hit an assertion in cxa_personality.cpp. This

[PATCH] D24080: [lit] Replace print with lit_config.note().

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF. logan added a subscriber: cfe-commits. This commit replaces print statement with lit_config.note(). This fixes python3 support for check-libcxxabi. https://reviews.llvm.org/D24080 Files: test/lit.cfg Index: te

[libcxxabi] r280251 - Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined().

Author: logan Date: Wed Aug 31 10:16:40 2016 New Revision: 280251 URL: http://llvm.org/viewvc/llvm-project?rev=280251&view=rev Log: Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined(). This commit fixes -Wundef by replacing: #if !LIBCXXABI_USE_LLVM_UNWINDER with: #if !defined(LIBCXXABI_USE

Re: [PATCH] D24040: codechecker tool core

artem.tamazov resigned from this revision. artem.tamazov removed a reviewer: artem.tamazov. artem.tamazov added a comment. It seems that my name got into reviewers list by mistake. https://reviews.llvm.org/D24040 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D24075: [include-fixer] Add a `query-symbol` option to query symbol without parsing the source file.

hokein updated this revision to Diff 69847. hokein added a comment. Update the test. https://reviews.llvm.org/D24075 Files: include-fixer/find-all-symbols/SymbolInfo.h include-fixer/tool/ClangIncludeFixer.cpp test/include-fixer/query_symbol.cpp Index: test/include-fixer/query_symbol.cpp

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL280236: [clang-tidy docs] Add missing option docs. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23918?vs=69839&id=69840#toc Reposito

r280245 - clang-format: Set default WebKit style to use C++11.

Author: djasper Date: Wed Aug 31 09:05:56 2016 New Revision: 280245 URL: http://llvm.org/viewvc/llvm-project?rev=280245&view=rev Log: clang-format: Set default WebKit style to use C++11. The WebKit style page says to use nullptr, so this should be fine: https://webkit.org/code-style-guidelines/

Re: [PATCH] D24040: codechecker tool core

rizsotto.mailinglist added a comment. Gyorgy and the ericsson team, thanks for doing this. very good job! good targeted functionality. i don't want to underestimate the complexity it requires, but to me this is a giant code. i do miss the explanation of the overall functional description what a

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69839. hokein added a comment. Update HeaderFileExtensions doc for all documents. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-build-namespaces.rst doc

r280240 - [clang-format-vim] Support vim linked against py3

Author: ldrumm Date: Wed Aug 31 08:36:36 2016 New Revision: 280240 URL: http://llvm.org/viewvc/llvm-project?rev=280240&view=rev Log: [clang-format-vim] Support vim linked against py3 clang-format.py previously only worked in vim compiled against python2. This patch adds the necessary syntax chan

[clang-tools-extra] r280236 - [clang-tidy docs] Add missing option docs.

Author: hokein Date: Wed Aug 31 08:21:18 2016 New Revision: 280236 URL: http://llvm.org/viewvc/llvm-project?rev=280236&view=rev Log: [clang-tidy docs] Add missing option docs. Reviewers: alexfh, Eugene.Zelenko, aaron.ballman Subscribers: aaron.ballman, cfe-commits Differential Revision: https:/

[clang-tools-extra] r280235 - [docs] Fix docs build error.

Author: hokein Date: Wed Aug 31 08:17:48 2016 New Revision: 280235 URL: http://llvm.org/viewvc/llvm-project?rev=280235&view=rev Log: [docs] Fix docs build error. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL: http://llvm.

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69838. hokein marked 3 inline comments as done. hokein added a comment. Fix more comments. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-build-namespaces.

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the updated documentation! https://reviews.llvm.org/D23918 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein marked an inline comment as done. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no + othe

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no + other de

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein added inline comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no + other desired e

cfe-commits@lists.llvm.org

ping. On Sun, Aug 28, 2016 at 7:52 PM, Eric Fiselier wrote: > @Hans While working on the std::tuple bug I found this bug in std::pair. > Since we are already doing another RC I would like to merge this fix. > > @Marshall Sound OK to you? > > /Eric > > On Sun, Aug 28, 2016 at 7:43 PM, Eric Fiseli

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no + other de

r280227 - Revision r280064 adds new options -fdenormal-fp-math and passes through option

Author: sjoerdmeijer Date: Wed Aug 31 07:31:03 2016 New Revision: 280227 URL: http://llvm.org/viewvc/llvm-project?rev=280227&view=rev Log: Revision r280064 adds new options -fdenormal-fp-math and passes through option -ffast-math to CC1, but it included a wrong llvm regression tests which was remo

  1   2   >