Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. I'll commit this change tomorrow barring any objections. https://reviews.llvm.org/D24642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

zaks.anna added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2055 @@ -2054,1 +2054,3 @@ } +def WarnImpcastToBoolDocs : Documentation { + let Category = DocCatFunction; You probably need to "propose" the attribute to the clang community. I'd send

Re: [PATCH] D24646: [CMake] Allow building Sphinx docs in nit-picky mode

EricWF updated this revision to Diff 71594. EricWF added a comment. Use spaces not tabs. https://reviews.llvm.org/D24646 Files: cmake/modules/AddSphinxTarget.cmake Index: cmake/modules/AddSphinxTarget.cmake === ---

Re: Upgrade and fix clang-format-vs

Sorry I haven't had a chance to get back to this. Things got busy at work. I do plan to get back to this as I'm hoping to add some features to this extension :) On Thu, Sep 15, 2016 at 7:31 PM Zachary Turner wrote: > Strange. FWIW you can dump all the variables that are

[PATCH] D24646: [CMake] Allow building Sphinx docs in nit-picky mode

EricWF created this revision. EricWF added reviewers: rnk, delcypher. EricWF added subscribers: llvm-commits, cfe-commits. Herald added subscribers: mgorny, beanz. The actual logic to build http://llvm.org/libcxx/docs does so with "-W" and "-n" enabled, meaning that the website will not be

[libcxx] r281697 - Attempt to fix Sphinx build

Author: ericwf Date: Thu Sep 15 22:47:53 2016 New Revision: 281697 URL: http://llvm.org/viewvc/llvm-project?rev=281697=rev Log: Attempt to fix Sphinx build Modified: libcxx/trunk/docs/BuildingLibcxx.rst libcxx/trunk/docs/Makefile.sphinx libcxx/trunk/docs/TestingLibcxx.rst Modified:

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

compnerd added inline comments. Comment at: lib/Headers/intrin.h:504 @@ +503,3 @@ +_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) { + long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE); + return (_PrevVal >> _BitPos) & 1;

Re: [PATCH] D24446: Implement revision to LWG#2758

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. The new overloads taking string_view's need to guard against self-aliasing string_views. Once that is fixed I would double check that your tests for `!is_convertible<_Tp const&, const

[libcxx] r281695 - Update _LIBCPP_EXCEPTION_ABI doc with @mclow's feedback

Author: ericwf Date: Thu Sep 15 21:51:26 2016 New Revision: 281695 URL: http://llvm.org/viewvc/llvm-project?rev=281695=rev Log: Update _LIBCPP_EXCEPTION_ABI doc with @mclow's feedback Modified: libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst Modified:

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

tejohnson created this revision. tejohnson added reviewers: mehdi_amini, pcc. tejohnson added a subscriber: cfe-commits. Herald added subscribers: mehdi_amini, dschuff, jfb. These options need to be passed to the plugin in order to have an effect on LTO/ThinLTO compiles.

r281693 - Alter the iOS/tvOS ARM64 C++ ABI to ignore the upper half of the

Author: rjmccall Date: Thu Sep 15 21:40:45 2016 New Revision: 281693 URL: http://llvm.org/viewvc/llvm-project?rev=281693=rev Log: Alter the iOS/tvOS ARM64 C++ ABI to ignore the upper half of the virtual table offset in a member function pointer. We are reserving this space for future ABI use

Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

EricWF updated this revision to Diff 71590. EricWF added a comment. - Add `always_inline` to _LIBCPP_INLINE_VISIBILITY. In future I think only _LIBCPP_ALWAYS_INLINE should actually apply `always_inline`, but I'll make that change separately. - Change `_LIBCPP_ALWAYS_INLINE` to use

[libcxx] r281692 - Move _LIBCPP_INLINE_VISIBILITY to first declaration in

Author: ericwf Date: Thu Sep 15 21:16:23 2016 New Revision: 281692 URL: http://llvm.org/viewvc/llvm-project?rev=281692=rev Log: Move _LIBCPP_INLINE_VISIBILITY to first declaration in Modified: libcxx/trunk/include/experimental/propagate_const Modified:

[libcxx] r281691 - Move _LIBCPP_INLINE_VISIBILITY to first declaration in sstream.

Author: ericwf Date: Thu Sep 15 21:09:26 2016 New Revision: 281691 URL: http://llvm.org/viewvc/llvm-project?rev=281691=rev Log: Move _LIBCPP_INLINE_VISIBILITY to first declaration in sstream. Modified: libcxx/trunk/include/sstream Modified: libcxx/trunk/include/sstream URL:

Re: [PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

rsmith added a comment. > But not here, because we would have to verify that the pointer in lam wasn't > mutated in a previous call of the lambda: Isn't that guaranteed, because the lambda is not marked `mutable`? Comment at: lib/Sema/SemaChecking.cpp:6594 @@ -6590,1 +6593,3

Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. Looks great. Thank you for seeing it through! https://reviews.llvm.org/D24642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24584: Do not warn about format strings that are indexed string literals.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281686: Do not warn about format strings that are indexed string literals. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24584?vs=71585=71586#toc Repository: rL LLVM

r281686 - Do not warn about format strings that are indexed string literals.

Author: srhines Date: Thu Sep 15 20:07:04 2016 New Revision: 281686 URL: http://llvm.org/viewvc/llvm-project?rev=281686=rev Log: Do not warn about format strings that are indexed string literals. Summary: The warning for a format string not being a string literal and therefore being potentially

Re: [PATCH] D24584: Do not warn about format strings that are indexed string literals.

meikeb updated this revision to Diff 71585. meikeb added a comment. . https://reviews.llvm.org/D24584 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c === ---

Re: [PATCH] D24584: Do not warn about format strings that are indexed string literals.

meikeb updated this revision to Diff 71584. meikeb added a comment. Rebase https://reviews.llvm.org/D24584 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBlocks.h lib/Sema/SemaChecking.cpp test/CodeGenObjCXX/lambda-expressions.mm test/Sema/format-strings.c Index:

Re: [PATCH] D24584: Do not warn about format strings that are indexed string literals.

meikeb updated this revision to Diff 71583. meikeb added a comment. Try to drop randomly uploaded commit. https://reviews.llvm.org/D24584 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c

Re: [PATCH] D24584: Do not warn about format strings that are indexed string literals.

meikeb updated this revision to Diff 71581. meikeb added a comment. Rebase to current commit. https://reviews.llvm.org/D24584 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBlocks.h lib/Sema/SemaChecking.cpp test/CodeGenObjCXX/lambda-expressions.mm test/Sema/format-strings.c Index:

Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

EricWF updated this revision to Diff 71579. EricWF added a comment. Revert accidental change. https://reviews.llvm.org/D24642 Files: include/__config src/string.cpp Index: src/string.cpp === --- src/string.cpp +++

[PATCH] D24642: Use __attribute__((internal_linkage)) when available.

EricWF created this revision. EricWF added reviewers: mclow.lists, eugenis. EricWF added subscribers: cfe-commits, eugenis. This patch has been a long time coming (Thanks @eugenis). It changes `_LIBCPP_INLINE_VISIBILITY` to use `__attribute__((internal_linkage))` instead of

r281682 - [CodeGen][ObjC] Block captures should inherit the type of the captured

Author: ahatanak Date: Thu Sep 15 19:02:06 2016 New Revision: 281682 URL: http://llvm.org/viewvc/llvm-project?rev=281682=rev Log: [CodeGen][ObjC] Block captures should inherit the type of the captured field in the enclosing lambda or block. This patch fixes a bug in code-gen where it uses the

Re: [PATCH] D21104: [CodeGen][ObjC] Block captures should inherit the type of the captured field in the enclosing lambda or block

This revision was automatically updated to reflect the committed changes. Closed by commit rL281682: [CodeGen][ObjC] Block captures should inherit the type of the captured (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D21104?vs=64199=71575#toc Repository: rL LLVM

[libcxx] r281681 - [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

Author: ericwf Date: Thu Sep 15 19:00:48 2016 New Revision: 281681 URL: http://llvm.org/viewvc/llvm-project?rev=281681=rev Log: [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility Summary: GCC and Clang handle visibility attributes on the out-of-line

Re: [PATCH] D24600: [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting to commit. Post commit review is very welcome (but nobody likes looking at visibility patches). https://reviews.llvm.org/D24600

Re: [PATCH] D24600: [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

EricWF updated this revision to Diff 71574. EricWF added a comment. - Update the patch based on r281673. - Add doc for `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY` - Move all uses of `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY` to the first declaration in order to support

Re: [PATCH] D24640: [CUDA] Don't try to run sanitizers on NVPTX.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281680: [CUDA] Don't try to run sanitizers on NVPTX. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D24640?vs=71572=71573#toc Repository: rL LLVM

r281680 - [CUDA] Don't try to run sanitizers on NVPTX.

Author: jlebar Date: Thu Sep 15 18:44:13 2016 New Revision: 281680 URL: http://llvm.org/viewvc/llvm-project?rev=281680=rev Log: [CUDA] Don't try to run sanitizers on NVPTX. Summary: Sanitizers aren't supported on NVPTX -- don't try to run them. This lets you e.g. pass -fsanitize=address and get

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

ahatanak abandoned this revision. ahatanak added a comment. The crash I was trying to fix was fixed in https://reviews.llvm.org/D23643. https://reviews.llvm.org/D14471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: Upgrade and fix clang-format-vs

Strange. FWIW you can dump all the variables that are present in your environment. You need to go to Tools -> Options -> Projects and Solutions -> Build and Run and choose either Normal, Detailed, or Diagnostic for the MSBuild project build output verbosity. Then in the output window you will

Re: Upgrade and fix clang-format-vs

When I first opened the solution in VS it prompted me to install it and I did. On Thu, Sep 15, 2016 at 4:17 PM, Zachary Turner wrote: > You may need to install the Visual Studio SDK. Did you do that when you > initially installed VS 2015? > > On Thu, Sep 15, 2016 at 4:15 PM

Re: Upgrade and fix clang-format-vs

You may need to install the Visual Studio SDK. Did you do that when you initially installed VS 2015? On Thu, Sep 15, 2016 at 4:15 PM Hans Wennborg wrote: > Well, on my machine $(SDKToolsDir) doesn't work :-( I suspect the file > will need manual tweaking by whoever is trying

Re: Upgrade and fix clang-format-vs

Well, on my machine $(SDKToolsDir) doesn't work :-( I suspect the file will need manual tweaking by whoever is trying to build the plugin. Anyway, I've updated the solution to build with VS2015 in r281648 and confirmed that it can still be used with older VS versions too. Cheers, Hans On Thu,

Re: [PATCH] D22053: [Sema] Fix a C++1z bug where initializer for static constexpr data member was not instantiated

erik.pilkington added a comment. Ping, sorry for the delay. https://reviews.llvm.org/D22053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

erik.pilkington created this revision. erik.pilkington added reviewers: faisalv, rsmith. erik.pilkington added a subscriber: cfe-commits. Previously, clang emitted no diagnostic for the following: ``` auto f() { int loc; return [&] { return loc; }; } ``` The problem being that this returns a

Re: [PATCH] D20811: [analyzer] Model some library functions

dcoughlin added a comment. Thanks for adding the macros. I've provided some feedback inline. I think a good rule of thumb for readability is: suppose you are a maintainer and need to add a summary for a new function. Can you copy the the summary for an existing function and figure out what

[libcxx] r281673 - [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

Author: ericwf Date: Thu Sep 15 17:27:07 2016 New Revision: 281673 URL: http://llvm.org/viewvc/llvm-project?rev=281673=rev Log: [libc++] Fix and document visibility attributes for Clang, GCC and Windows. Summary: This patch fixes a number of problems with the visibility macros across GCC (on

Re: [PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

EricWF updated this revision to Diff 71570. EricWF added a comment. I'm going to go ahead and commit this w/o review because it's blocking more important changes. Post-commit comments on the documentation are appreciated. https://reviews.llvm.org/D24602 Files: CMakeLists.txt

Re: [PATCH] D6974: [libcxx] Attempt to fix undefined behavior in list, forward_list and __tree.

EricWF abandoned this revision. EricWF added a comment. Abandoning. All issues have been addressed by other commits. Comment at: include/memory:5452-5458 @@ +5451,9 @@ + { +return static_cast<_To>(_FromPtrTraits::pointer_to(__e)); + } + + _LIBCPP_INLINE_VISIBILITY +

r281669 - [Sema] Allow shifting a scalar operand by a vector operand.

Author: ahatanak Date: Thu Sep 15 17:19:25 2016 New Revision: 281669 URL: http://llvm.org/viewvc/llvm-project?rev=281669=rev Log: [Sema] Allow shifting a scalar operand by a vector operand. r278501 inadvertently introduced a bug in which it disallowed shifting scalar operands by vector operands

Re: [PATCH] D24467: Fix an error after D21678

This revision was automatically updated to reflect the committed changes. Closed by commit rL281669: [Sema] Allow shifting a scalar operand by a vector operand. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D24467?vs=71545=71569#toc Repository: rL LLVM

r281666 - Simplify Clang's version number configuration in CMake.

Author: dlj Date: Thu Sep 15 17:12:26 2016 New Revision: 281666 URL: http://llvm.org/viewvc/llvm-project?rev=281666=rev Log: Simplify Clang's version number configuration in CMake. Currently, the Clang version is computed as follows: 1. LLVM defines major, minor, and patch versions, all

r281665 - [sanitizer-coverage] make trace-pc-guard and indirect-call work together

Author: kcc Date: Thu Sep 15 17:11:08 2016 New Revision: 281665 URL: http://llvm.org/viewvc/llvm-project?rev=281665=rev Log: [sanitizer-coverage] make trace-pc-guard and indirect-call work together Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

EricWF resigned from this revision. EricWF removed a reviewer: EricWF. EricWF added a comment. After talking with @rmaprath we have agreed to go in a different direction. Resigning as reviewer to keep my queue clean. https://reviews.llvm.org/D23926

Re: [PATCH] D23765: Fix for clang PR 29087

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4227 @@ -4226,1 +4226,3 @@ continue; +// Using(Shadow)Decl itself is not a constructor +if (isa(ND) || isa(ND)) This isn't really right: a `UsingShadowDecl` whose

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

bkramer accepted this revision. bkramer added a comment. looks good from my side. https://reviews.llvm.org/D18462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23765: Fix for clang PR 29087

twoh updated this revision to Diff 71560. twoh added a comment. Tests added https://reviews.llvm.org/D23765 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/crash-has-nothrow-constructor.cpp test/SemaCXX/crash-has-nothrow-copy.cpp Index: test/SemaCXX/crash-has-nothrow-copy.cpp

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

EricWF added a comment. Thanks for working on this. That static initialization bug is ugly. My only concern with this patch is that adding `constexpr` to unconstrained constructors is going to result compile errors caused by Clang's eager instantiation. Also, unlike @mclow.lists, I think we

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4967 @@ +4966,3 @@ + + D->addAttr(::new (S.Context) + AMDGPUFlatWorkGroupSizeAttr(Attr.getLoc(), S.Context, Min, Max, Is it okay to supply `0, 0` as the min, max arguments?

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

blastrock added a comment. Seems fine to me, but I think you forgot to update the tests :) Repository: rL LLVM https://reviews.llvm.org/D24628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

aaron.ballman added a comment. Thank you for working on this check! A few comments: The patch is missing Sema tests for the attribute (that it only applies to declarations you expect, accepts no args, etc). Have you considered making this a type attribute on the return type of the function

[PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

andriigrynenko created this revision. andriigrynenko added reviewers: kcc, blastrock, dvyukov, filcab. andriigrynenko added a subscriber: cfe-commits. andriigrynenko set the repository for this revision to rL LLVM. Herald added a subscriber: kubabrecka. This patch extends

[PATCH] D24626: [OpenCL] Diagnose assignment to dereference of half type pointer

yaxunl created this revision. yaxunl added reviewers: Anastasia, bader. yaxunl added subscribers: cfe-commits, nhaustov, rampitec. Herald added a subscriber: yaxunl. https://reviews.llvm.org/D24626 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp

Re: [cfe-dev] [Static Analyzer] Retain count checker does not warn about parameters that might leak

- cfe-dev, + cfe-commits Hi Tobias, This is a great start. Thanks for the patch! > Not sure I know how to use the analyzer config flags yet. My patch > currently also still causes a segfault on Analysis/retain-release.m The segfault is because the diagnostics machinery expects a declaration

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl updated this revision to Diff 71545. https://reviews.llvm.org/D24467 Files: llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/CodeGen/vecshift.c llvm/tools/clang/test/Sema/vecshift.c Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/test/CodeGen/vecshift.c:43 @@ +42,3 @@ + vi8 = 1 << vi8; +// CHECK: [[t2:%.+]] = load <8 x i32>, <8 x i32>* @vi8, align 32 +// CHECK: shl <8 x i32> , [[t2]] ahatanak wrote: > This test fails on my

r281648 - clang-format VS plugin: upgrade the project files to VS2015

Author: hans Date: Thu Sep 15 14:44:49 2016 New Revision: 281648 URL: http://llvm.org/viewvc/llvm-project?rev=281648=rev Log: clang-format VS plugin: upgrade the project files to VS2015 The plugin itself runs on previous VS versions, but this enables it to be built with VS2015. Modified:

Re: [PATCH] D24467: Fix an error after D21678

ahatanak added a comment. LGTM with a nit in test case. Comment at: llvm/tools/clang/test/CodeGen/vecshift.c:43 @@ +42,3 @@ + vi8 = 1 << vi8; +// CHECK: [[t2:%.+]] = load <8 x i32>, <8 x i32>* @vi8, align 32 +// CHECK: shl <8 x i32> , [[t2]] This test fails on

Re: [PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

EricWF added a comment. In https://reviews.llvm.org/D24599#543849, @mclow.lists wrote: > Any reason we shouldn't just revert r280944, wait for the LLVM bug to be > fixed, and then re-apply it? I would like to put some time between fixing the Clang bug and re-introducing the reproducer into

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. Comment at: src/cxa_thread_atexit.cpp:70 @@ +69,3 @@ + + void run_dtors(void*) { +while (auto head = dtors) { Na I thought I

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL281641: [libc++] Avoid include in locale_win32.h (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24374?vs=70899=71530#toc Repository: rL LLVM

[libcxx] r281641 - [libc++] Avoid include in locale_win32.h

Author: smeenai Date: Thu Sep 15 13:36:13 2016 New Revision: 281641 URL: http://llvm.org/viewvc/llvm-project?rev=281641=rev Log: [libc++] Avoid include in locale_win32.h When `_LIBCPP_NO_EXCEPTIONS` is defined, we end up with compile errors when targeting MSVCRT: * Code includes `` * ``

Re: [PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. LGTM as well, thank you! https://reviews.llvm.org/D24289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

rnk added a comment. In https://reviews.llvm.org/D24289#543874, @thakis wrote: > Works for me if rnk likes it :-) Yep, looks good. > (We could bikeshed on if this should be one of the -Wmicrosoft warnings, but > the warning can't be both in -Wall and -Wmicrosoft, so let's don't). I also

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

loladiro updated this revision to Diff 71528. loladiro added a comment. Add private copy of forward (__forward) that is constexpr even in C++11 mode, use test suggested by @rsmith Repository: rL LLVM https://reviews.llvm.org/D24372 Files: include/memory

Re: [PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

thakis added a comment. Works for me if rnk likes it :-) (We could bikeshed on if this should be one of the -Wmicrosoft warnings, but the warning can't be both in -Wall and -Wmicrosoft, so let's don't). I do have a question about the test (the first commit below): Comment

r281632 - Reapply: Silence false positive diagnostics regarding passing an object of enumeration type to va_start().

Author: aaronballman Date: Thu Sep 15 13:07:51 2016 New Revision: 281632 URL: http://llvm.org/viewvc/llvm-project?rev=281632=rev Log: Reapply: Silence false positive diagnostics regarding passing an object of enumeration type to va_start(). The underlying type for an enumeration in C is either

[PATCH] D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard

davidsh created this revision. davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev. davidsh added a subscriber: cfe-commits. #pragma omp for { for(...) } This is technically not allowed by the standard, gcc doesnt allow such code. https://reviews.llvm.org/D24615

Re: [PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

mclow.lists added a comment. Any reason we shouldn't just revert r280944, wait for the LLVM bug to be fixed, and then re-apply it? https://reviews.llvm.org/D24599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23272: [analyzer][Rewrite] Fix boxes and shadows in HTML rewrites in Firefox.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281625: [analyzer] Fix HTMLRewriter style sheets to support non-webkit browsers. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23272?vs=67182=71517#toc Repository: rL

r281625 - [analyzer] Fix HTMLRewriter style sheets to support non-webkit browsers.

Author: dergachev Date: Thu Sep 15 11:25:42 2016 New Revision: 281625 URL: http://llvm.org/viewvc/llvm-project?rev=281625=rev Log: [analyzer] Fix HTMLRewriter style sheets to support non-webkit browsers. This fixes rounded corners and shadows of analyzer diagnostic pieces in browsers such as

Re: [PATCH] D20811: [analyzer] Model some library functions

NoQ updated this revision to Diff 71510. NoQ marked an inline comment as done. NoQ added a comment. Herald added subscribers: mgorny, beanz. Added a huge amount of macros in order to improve readability of function specs. Other inline comments should have been addressed before.

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator marked 5 inline comments as done. Comment at: src/cxa_thread_atexit.cpp:70 @@ +69,3 @@ +while (auto head = dtors) { + dtors = head->next; + head->dtor(head->obj); EricWF wrote: > tavianator wrote: > > EricWF wrote: > > > tavianator wrote:

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator updated this revision to Diff 71508. tavianator added a comment. Herald added subscribers: mgorny, beanz. Integrated @EricWF's expanded test case, and avoid an unneeded pthread_setspecific() call if the last thread_local's destructor initializes a new thread_local.

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:104 @@ +103,3 @@ + std::reverse(Namespaces.begin(), Namespaces.end()); + return Namespaces; +} Aha, I see. I misused the `findLocationAfterToken` previously. Comment at:

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 71506. hokein marked 2 inline comments as done. hokein added a comment. Herald added a subscriber: mgorny. Address review comments. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp

r281612 - Reverting r281609; it caused some build bots to break.

Author: aaronballman Date: Thu Sep 15 09:12:33 2016 New Revision: 281612 URL: http://llvm.org/viewvc/llvm-project?rev=281612=rev Log: Reverting r281609; it caused some build bots to break.

Re: [PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

sdardis closed this revision. sdardis added a comment. Committed as https://reviews.llvm.org/rL281610. https://reviews.llvm.org/D22679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r281610 - [mips][ias] Enable IAS by default for N64 on Debian mips64el.

Author: sdardis Date: Thu Sep 15 09:01:55 2016 New Revision: 281610 URL: http://llvm.org/viewvc/llvm-project?rev=281610=rev Log: [mips][ias] Enable IAS by default for N64 on Debian mips64el. Unfortunately we can't enable it for all N64 because it is not yet possible to distinguish N32 from N64

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

hokein added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:200 @@ +199,3 @@ + while (!NsSplitted.empty()) { +// FIXME: consider code style for comments. +Code = ("namespace " + NsSplitted.back() + " {\n" + Code + Doesn't

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r281609 https://reviews.llvm.org/D23921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r281609 - Silence false positive diagnostics regarding passing an object of enumeration type to va_start(). The underlying type for an enumeration in C is either char, signed int, or unsigned int. In

Author: aaronballman Date: Thu Sep 15 09:01:10 2016 New Revision: 281609 URL: http://llvm.org/viewvc/llvm-project?rev=281609=rev Log: Silence false positive diagnostics regarding passing an object of enumeration type to va_start(). The underlying type for an enumeration in C is either char,

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl updated this revision to Diff 71498. https://reviews.llvm.org/D24467 Files: llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/CodeGen/vecshift.c llvm/tools/clang/test/Sema/vecshift.c Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp

[PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo created this revision. mstorsjo added a reviewer: compnerd. mstorsjo added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. On ARM, there are multiple versions of each of the intrinsics, with acquire/relaxed/release barrier semantics. The 64 bit

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

ioeric added a comment. PIng https://reviews.llvm.org/D24183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

milianw accepted this revision. milianw added a comment. This revision is now accepted and ready to land. agreed, lgtm but someone else must accept this upstream https://reviews.llvm.org/D18462 ___ cfe-commits mailing list

Re: [PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

hokein added inline comments. Comment at: clang-tidy/ClangTidy.cpp:206 @@ +205,3 @@ +StringRef Code = Buffer.get()->getBuffer(); +format::FormatStyle Style = format::getLLVMStyle(); +llvm::Expected CleanReplacements = ioeric wrote: > Add a

Re: [PATCH] D24606: Recommit r281457 "Supports adding insertion around non-insertion replacements" and fix a bug in getAffectedRanges.

ioeric updated this revision to Diff 71495. ioeric added a comment. - Update comment in `getAffectedRanges`. https://reviews.llvm.org/D24606 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp Index:

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

ioeric added a comment. Ping https://reviews.llvm.org/D24380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r281603 - [libcxx] Allow sanitizing libcxx with ASan+UBSan simultaneously

Author: kuba.brecka Date: Thu Sep 15 06:04:53 2016 New Revision: 281603 URL: http://llvm.org/viewvc/llvm-project?rev=281603=rev Log: [libcxx] Allow sanitizing libcxx with ASan+UBSan simultaneously Allow building with LLVM_USE_SANITIZER=“Address;Undefined” (and “Undefined;Address”).

Re: [PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

sdardis added a comment. Ping. https://reviews.llvm.org/D21070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath added inline comments. Comment at: test/std/re/re.alg/re.alg.search/grep.pass.cpp:25 @@ -25,2 +24,3 @@ +#ifndef TEST_HAS_NO_EXCEPTIONS extern "C" void LLVMFuzzerTestOneInput(const char *data) EricWF wrote: > I prefer putting the `#if` on the inside of

Re: [PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

EricWF added inline comments. Comment at: include/__config:605 @@ +604,3 @@ +# if __has_attribute(__type_visibility__) +#define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS __attribute__ ((__visibility__("default"))) +# else Checking `__type_visibility__` and using

Re: [PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

EricWF updated this revision to Diff 71486. EricWF added a comment. Fix obvious errors in docs. https://reviews.llvm.org/D24602 Files: CMakeLists.txt docs/DesignDocs/VisibilityMacros.rst docs/index.rst include/__config include/__locale include/__string

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

kfunk added a comment. @other LLVM devs: Please review so we can finally ship this? Comment at: tools/libclang/CIndex.cpp:4311 @@ -4311,1 +4310,3 @@ + C.kind == CXCursor_ConversionFunction || + C.kind == CXCursor_FunctionDecl) { if (pieceIndex > 0)

[PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. This patch fixes a number of problems with the visibility macros across GCC (on Unix) and Windows (DLL import/export semantics). All of the

Re: [PATCH] D24245: [ARM] ARM-specific attributes should be accepted for big-endian

This revision was automatically updated to reflect the committed changes. Closed by commit rL281596: [ARM] ARM-specific attributes should be accepted for big-endian (authored by olista01). Changed prior to commit: https://reviews.llvm.org/D24245?vs=70364=71485#toc Repository: rL LLVM

  1   2   >