[PATCH] D26139: Tests for strings conversions under libcpp-no-exceptions

mclow.lists added a comment. > I think it might be better to add TEST_TRY and TEST_CATCH(...) macros > defined like @rogfer01 said at the top that he didn't want to add "a magical TEST_TRY macro" - and I agree. Someone tried that in another review, and I nixed it there.

[PATCH] D6833: Clang-format: Braces Indent Style Whitesmith

djasper added a comment. In case you still want to move forward with this, some more comments. Why have you opted for doing this in getNewLineColumn instead of the UnwrappedLineFormatter::formatFirstToken() function I suggested? I think the latter would be way easier, but there might be cases

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric updated this revision to Diff 76975. ioeric added a comment. - addressed comments. https://reviews.llvm.org/D26288 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp lib/Tooling/Refactoring.cpp unittests/Tooling/RefactoringTest.cpp Index:

[PATCH] D26138: [clang-tidy] Add modernize-use-equals-delete check

malcolm.parsons updated this revision to Diff 76971. malcolm.parsons added a comment. Check for non-public deleted methods. Remove imperfect FixItHint. Add FIXME comments. https://reviews.llvm.org/D26138 Files: clang-tidy/modernize/CMakeLists.txt

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric added a comment. In https://reviews.llvm.org/D26288#587513, @klimek wrote: > In https://reviews.llvm.org/D26288#586932, @ioeric wrote: > > > - Addressed comments: handle non-existing files. > > > We're not really handling them now though? We're just printing an error? > > My point is that

[PATCH] D26317: Fix use-of-temporary with StringRef in code coverage

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. I've made a note to clean this up. Repository: rL LLVM https://reviews.llvm.org/D26317 ___ cfe-commits mailing list

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

klimek added a comment. In https://reviews.llvm.org/D26288#586932, @ioeric wrote: > - Addressed comments: handle non-existing files. We're not really handling them now though? We're just printing an error? My point is that we might run the replacement generation on a distributed system, and

r286041 - clang-format: Better support for CUDA's triple brackets.

Author: djasper Date: Sat Nov 5 12:43:16 2016 New Revision: 286041 URL: http://llvm.org/viewvc/llvm-project?rev=286041=rev Log: clang-format: Better support for CUDA's triple brackets. Before: aaa< a, aa, aa><<

Re: [PATCH] Warning for main returning a bool.

+richard On Fri, Oct 14, 2016 at 10:18 AM Joshua Hurwitz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > See attached. > > Returning a bool from main is a special case of return type mismatch. The > common convention when returning a bool is that 'true' (== 1) indicates > success and

[PATCH] D26311: Use AnalyzerOptions::getRegisteredCheckers() instead of clang/StaticAnalyzer/Checkers/Checkers.inc

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D26311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26310: Add a method to get the list of registered static analyzer checkers.

zaks.anna added a comment. Thanks for fixing this! Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:39 +if (IncludeExperimental || +(!CheckName.startswith("debug.") && !CheckName.startswith("alpha."))) + Result.push_back(CheckName);

[PATCH] D26302: [OpenCL] Remove redundant test for OpenCL header file

Anastasia added a comment. LGTM! Thanks! Do you know the runtime of this test now? https://reviews.llvm.org/D26302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26138: [clang-tidy] Add modernize-use-equals-delete check

malcolm.parsons planned changes to this revision. malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:58 + << FixItHint::CreateInsertion(StartLoc, "public: ") + << FixItHint::CreateInsertion(AfterLoc, " private:"); +}

[PATCH] D26306: [AVX-512] Make VBMI instruction set enabling imply that the BWI instruction set is also enabled.

zvi added inline comments. Comment at: lib/Basic/Targets.cpp:3353 setSSELevel(Features, AVX512F, Enabled); +// Enable BWI instruction is VBMI is being enabled. +if (Name == "avx512vbmi" && Enabled) is -> if Comment at:

[PATCH] D26306: [AVX-512] Make VBMI instruction set enabling imply that the BWI instruction set is also enabled.

zvi accepted this revision. zvi added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25897: Add __no_instrument_function__ to _LIBCPP_INLINE_VISIBILITY and _LIBCPP_ALWAYS_INLINE

EricWF added a comment. I created a fix as described above. Could you please tell me if it works for you? It can be found here: https://reviews.llvm.org/D26324 https://reviews.llvm.org/D25897 ___ cfe-commits mailing list