[libcxxabi] r286337 - [libc++abi] Remove the test for checking using of fallback malloc in case of dynamic memory exhaustion.

Author: ikudrin Date: Tue Nov 8 22:14:31 2016 New Revision: 286337 URL: http://llvm.org/viewvc/llvm-project?rev=286337=rev Log: [libc++abi] Remove the test for checking using of fallback malloc in case of dynamic memory exhaustion. This test is too fragile and doesn't add significant value.

r286336 - Doxygen comments for avxintrin.h.

Author: kromanova Date: Tue Nov 8 21:58:30 2016 New Revision: 286336 URL: http://llvm.org/viewvc/llvm-project?rev=286336=rev Log: Doxygen comments for avxintrin.h. Added doxygen comments to avxintrin.h's intrinsics. As of now, around 75% of the intrinsics in this file are documented here. The

[libcxx] r286333 - [CMake] Check runtimes subdir when looking for libcxxabi

Author: phosek Date: Tue Nov 8 21:22:28 2016 New Revision: 286333 URL: http://llvm.org/viewvc/llvm-project?rev=286333=rev Log: [CMake] Check runtimes subdir when looking for libcxxabi The runtimes subdir is the new location for runtimes, we should include it when looking for libcxxabi headers.

[libcxxabi] r286332 - [CMake] Check runtimes subdir when looking for libcxx and libuwind

Author: phosek Date: Tue Nov 8 21:22:19 2016 New Revision: 286332 URL: http://llvm.org/viewvc/llvm-project?rev=286332=rev Log: [CMake] Check runtimes subdir when looking for libcxx and libuwind The runtimes subdir is the new location for runtimes, we should include it when looking for libcxx

[PATCH] D26150: [libc++abi] Fix test_exception_storage_nodynmem on MacOS

ikudrin added a comment. The test is too implementation-specific, and trying to override a function like `calloc` makes it fragile. Unfortunately, I didn't find a better way to test the library's behavior in case of memory exhaustion, but now I believe that this test doesn't add any

r286331 - [index] Fix issue with protocol name locations in conformance list of an ObjC class when they come from a typedef.

Author: akirtzidis Date: Tue Nov 8 20:47:07 2016 New Revision: 286331 URL: http://llvm.org/viewvc/llvm-project?rev=286331=rev Log: [index] Fix issue with protocol name locations in conformance list of an ObjC class when they come from a typedef. The ObjC class protocol list assumes there is an

[PATCH] D26109: Warn when 'assume_nonnull' infers nullability within an array.

jordan_rose added a dependency: D26108: Add -Wnullability-completeness-on-arrays.. jordan_rose added a comment. Depends on https://reviews.llvm.org/D26108 too, for the tests to apply cleanly. Repository: rL LLVM https://reviews.llvm.org/D26109

[PATCH] D26227: Don't require nullability on 'va_list'.

jordan_rose added a dependency: D26108: Add -Wnullability-completeness-on-arrays.. jordan_rose added a comment. Depends on https://reviews.llvm.org/D26108 too (for the tests to apply cleanly). Repository: rL LLVM https://reviews.llvm.org/D26227

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

jordan_rose added a comment. It works fine for me, though note the "depends on https://reviews.llvm.org/D25850;. The other patches in the series do seem to have been thrown off by https://reviews.llvm.org/D26226 landing first, though, so I'll update those. Repository: rL LLVM

[PATCH] D26431: [WebAssembly] Define __unix__ as part of the wasm target

dschuff added a comment. Yeah, I don't mean for this to be the final word; mostly this just matches asm.js. I do agree with you that the unixy stuff goes with the emscripten environment rather than wasm per se. I had thought we might define emscripten as an "OS" (i.e. the third or maybe even

[PATCH] D26435: Use unique_ptr for cached tokens for default arguments in C++.

dtarditi created this revision. dtarditi added a subscriber: cfe-commits. This changes pointers to cached tokens for default arguments in C++ from raw pointers to unique_ptrs. There was a fixme in the code where the cached tokens are created about using a smart pointer. The change is

[PATCH] D26431: [WebAssembly] Define __unix__ as part of the wasm target

jgravelle-google added a comment. I think you're right, it's the Emscripten embedding that's unixy, therefore Emscripten should be responsible for telling clang to be unixy. To play devil's advocate, it might be advantageous for all compile-to-wasm code to assume a common environment, and unix

[PATCH] D26423: [clang-move] Support template class.

hokein updated this revision to Diff 77292. hokein marked 3 inline comments as done. hokein added a comment. Add comments. https://reviews.llvm.org/D26423 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/template_class_test.cpp test/clang-move/Inputs/template_class_test.h

[PATCH] D26431: [WebAssembly] Define __unix__ as part of the wasm target

sunfish added a comment. The other main way we could provide __unix et al would be to add them to tools/shared.py in Emscripten (see the comment "wasm target does not automatically define emscripten stuff"). It's not clear to me whether that's better than adding the macros to clang itself or

r286322 - Emit debug info for global constants whose address is taken exactly once.

Author: adrian Date: Tue Nov 8 18:42:03 2016 New Revision: 286322 URL: http://llvm.org/viewvc/llvm-project?rev=286322=rev Log: Emit debug info for global constants whose address is taken exactly once. Add a check to the DeclCache before emitting debug info for a GlobalVariable a second time and

[PATCH] D26071: [CodeCompletion] Show block invocation result for block property setters

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D26071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26431: [WebAssembly] Define __unix__ as part of the wasm target

jgravelle-google added a comment. For the emscripten testsuite, specifically test_zlib relies on `#ifdef __unix__` to `#include `, which it needs. The rest of the unistd tests don't actually care. So we could make that test pass by explicitly adding a define for __unix__ for it, but I figure

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

alexfh added a comment. I also don't understand the use case for turning off only some checks for third-party headers. Either you care about third-party stuff or not, why only switch off certain checks? https://reviews.llvm.org/D26418 ___

[PATCH] D26431: [WebAssembly] Define __unix__ as part of the wasm target

sunfish added a comment. When adding new predefined macros, please also add the new macros to test/Preprocessor/init.c (and remove negative tests that no longer apply). Also though, I'd also like to understand this a little more. Even with emulation, there will be limits to how Unixy a Web

[PATCH] D26431: [WebAssembly] Define __unix__ as part of the wasm target

jgravelle-google created this revision. jgravelle-google added reviewers: dschuff, sunfish. jgravelle-google added a subscriber: cfe-commits. Herald added a subscriber: jfb. Unix is a convenient common denominator for embeddings to implement syscalls for. This makes it explicit that wasm is

r286313 - [CUDA] Use only the GVALinkage on function definitions.

Author: jlebar Date: Tue Nov 8 17:45:51 2016 New Revision: 286313 URL: http://llvm.org/viewvc/llvm-project?rev=286313=rev Log: [CUDA] Use only the GVALinkage on function definitions. Summary: Previously we'd look at the GVALinkage of whatever FunctionDecl you happened to be calling. This is

[PATCH] D26268: [CUDA] Use only the GVALinkage on function definitions.

This revision was automatically updated to reflect the committed changes. jlebar marked 2 inline comments as done. Closed by commit rL286313: [CUDA] Use only the GVALinkage on function definitions. (authored by jlebar). Changed prior to commit:

[PATCH] D26268: [CUDA] Use only the GVALinkage on function definitions.

jlebar marked 2 inline comments as done. jlebar added a comment. Thank you for the review! Submitting... Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:13-14 +// +// The trickiness here comes from the fact that the FunctionDecl bar() sees for +// foo() does not

[PATCH] D26340: [analyzer] Add SpinLockChecker for the Magenta kernel

khazem updated this revision to Diff 77277. khazem added a comment. If a double-lock or double-release is detected, path notes are now emitted on the _first_ lock or release event. Also updated the tests to check for these notes. https://reviews.llvm.org/D26340 Files:

[PATCH] D26268: [CUDA] Use only the GVALinkage on function definitions.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:13-14 +// +// The trickiness here comes from the fact that the FunctionDecl bar() sees for +// foo() does not

[PATCH] D26340: [analyzer] Add SpinLockChecker for the Magenta kernel

khazem updated this revision to Diff 77275. khazem added a comment. The strings for Spin{Unl,L}ockFuncName and LockErrorCategory are now initialized when constructing a SpinLockChecker object rather than being static globals, in order to avoid adverse effects on startup time. Also, the

[PATCH] D26340: [analyzer] Add SpinLockChecker for the Magenta kernel

khazem added a comment. Good to meet you too, thanks for the useful comments and pointers to helpful examples! I'm going to update the diff twice: the first one to address your first two comments, and the second one to address your last two. https://reviews.llvm.org/D26340

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

hfinkel added a comment. In https://reviews.llvm.org/D25403#590049, @jlebar wrote: > Use TEST_STD_VER macro. This is fine with me; @EricWF , @mclow.lists ? https://reviews.llvm.org/D25403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] r286308 - [CMake] Get libunwind building under LLVM/runtimes

Author: phosek Date: Tue Nov 8 17:02:49 2016 New Revision: 286308 URL: http://llvm.org/viewvc/llvm-project?rev=286308=rev Log: [CMake] Get libunwind building under LLVM/runtimes The new LLVM runtimes directory requires the same conventions to be followed across the runtime projects. These

[PATCH] D26268: [CUDA] Use only the GVALinkage on function definitions.

jlebar added a comment. Friendly ping https://reviews.llvm.org/D26268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25771: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL286307: [change-namespace] shorten namespace qualifier based on UsingDecl and… (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D25771?vs=77270=77272#toc Repository: rL LLVM

[clang-tools-extra] r286307 - [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

Author: ioeric Date: Tue Nov 8 16:44:17 2016 New Revision: 286307 URL: http://llvm.org/viewvc/llvm-project?rev=286307=rev Log: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl. Summary: when replacing symbol references in moved namespaces, trying to make

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

jlebar updated this revision to Diff 77271. jlebar added a comment. Use TEST_STD_VER macro. https://reviews.llvm.org/D25403 Files: libcxx/include/cmath libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp Index: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp

[PATCH] D25771: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

ioeric updated this revision to Diff 77270. ioeric marked an inline comment as done. ioeric added a comment. - Addressed comment. https://reviews.llvm.org/D25771 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h

[PATCH] D26373: [analyzer] Provide Contains() on ImmutableMap program state partial trait.

This revision was automatically updated to reflect the committed changes. Closed by commit rL286306: [analyzer] Provide Contains() on ImmutableMap program state partial trait. (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26373?vs=77109=77269#toc Repository: rL LLVM

r286306 - [analyzer] Provide Contains() on ImmutableMap program state partial trait.

Author: ddcc Date: Tue Nov 8 16:39:14 2016 New Revision: 286306 URL: http://llvm.org/viewvc/llvm-project?rev=286306=rev Log: [analyzer] Provide Contains() on ImmutableMap program state partial trait. Reviewers: zaks.anna, dcoughlin Subscribers: cfe-commits Differential Revision:

[PATCH] D25771: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM with one nit. Comment at: change-namespace/ChangeNamespace.cpp:275 + (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front())) + .str(); + auto

[PATCH] D26196: Add support for non-zero null pointers

rjmccall added a comment. In https://reviews.llvm.org/D26196#589493, @yaxunl wrote: > Fixed list initialization of large struct which are mostly initialized by 0 > through memset. > Added tests for casting literal 0 and non-literal integer to pointer. > > There are many more places need to be

[PATCH] D26373: [analyzer] Provide Contains() on ImmutableMap program state partial trait.

dcoughlin added a comment. In https://reviews.llvm.org/D26373#589614, @ddcc wrote: > Even though there isn't a performance difference, I think it is semantically > clearer since it is explicit that the value is unneeded. Makes sense to me! https://reviews.llvm.org/D26373

[PATCH] D26423: [clang-move] Support template class.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D26423 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/template_class_test.cpp test/clang-move/Inputs/template_class_test.h

[PATCH] D26196: Add support for non-zero null pointers

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1340 + return C; +return getNullPtr(PT, DestType); } yaxunl wrote: > efriedma wrote: > > yaxunl wrote: > > > yaxunl wrote: > > > > rjmccall wrote: > > > > >

[PATCH] D25771: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:275 + (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front())) + .str(); + auto IsInMovedNs = hokein wrote: > Using an

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

hfinkel added inline comments. Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:24 + +#if __cplusplus >= 201103L +constexpr bool a = std::__libcpp_isnan(0.); I think the preferred form here is: #if TEST_STD_VER >= 11

Re: [PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

Yes, some bots don't build all the targets. I think the test should go into Preprocessor/init.c. On Tue, Nov 8, 2016 at 2:07 PM, Stephen Hines wrote: > srhines added a comment. > > Reverted because this broke builds: > > clang-hexagon-elf >

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

srhines added a comment. Reverted because this broke builds: clang-hexagon-elf llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast clang-ppc64be-linux-multistage llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast It isn't clear from the logs why these builds failed, since I did a general build, but

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

This revision was automatically updated to reflect the committed changes. Closed by commit rL286298: Revert "Define __ANDROID_API__ for all Android builds." (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D26422?vs=77254=77256#toc Repository: rL LLVM

r286298 - Revert "Define __ANDROID_API__ for all Android builds."

Author: srhines Date: Tue Nov 8 15:54:49 2016 New Revision: 286298 URL: http://llvm.org/viewvc/llvm-project?rev=286298=rev Log: Revert "Define __ANDROID_API__ for all Android builds." Summary: This reverts commit a8804ddd9fe71304b28e5b834d134fe93e568ee0. Subscribers: cfe-commits, pirama,

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

srhines created this revision. srhines added subscribers: danalbert, eugenis, pirama, cfe-commits. Herald added a subscriber: tberghammer. This reverts commit a8804ddd9fe71304b28e5b834d134fe93e568ee0. https://reviews.llvm.org/D26422 Files: lib/Basic/Targets.cpp

[PATCH] D26196: Add support for non-zero null pointers

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1340 + return C; +return getNullPtr(PT, DestType); } efriedma wrote: > yaxunl wrote: > > yaxunl wrote: > > > rjmccall wrote:

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

Eugene.Zelenko added a comment. I think will be good idea to mention this in documentation and release notes. https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

srhines added a comment. Ugh, phabricator dropped my updated commit message, so that is completely wrong now. Oh well. I guess I will just use repo/gerrit for staging things in the future (and get consensus there) before asking for any upstream reviews. Repository: rL LLVM

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

This revision was automatically updated to reflect the committed changes. Closed by commit rL286295: Define __ANDROID_API__ for all Android builds. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D26385?vs=77236=77250#toc Repository: rL LLVM

r286295 - Define __ANDROID_API__ for all Android builds.

Author: srhines Date: Tue Nov 8 15:23:26 2016 New Revision: 286295 URL: http://llvm.org/viewvc/llvm-project?rev=286295=rev Log: Define __ANDROID_API__ for all Android builds. Summary: Bug: https://llvm.org/bugs/show_bug.cgi?id=30940 This macro (along with __ANDROID__) should always be defined

[PATCH] D26196: Add support for non-zero null pointers

efriedma added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1340 + return C; +return getNullPtr(PT, DestType); } yaxunl wrote: > yaxunl wrote: > > rjmccall wrote: > > > efriedma wrote: > > > > Consider code like the

[PATCH] D26418: Add '-suppress-checks-filter' option to suppress diagnostics from certain files

nkakuev created this revision. nkakuev added reviewers: malcolm.parsons, alexfh. nkakuev added a subscriber: cfe-commits. Currently clang-tidy doesn't provide a practical way to suppress diagnostics from headers you don't have control over. If using a function defined in such header causes a

[PATCH] D26196: Add support for non-zero null pointers

yaxunl updated this revision to Diff 77238. yaxunl marked 2 inline comments as done. yaxunl added a comment. Added isNullPtrZero to TargetCodeGenInfo. https://reviews.llvm.org/D26196 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExprAgg.cpp lib/CodeGen/CGExprConstant.cpp

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

eugenis accepted this revision. eugenis added a reviewer: eugenis. eugenis added a comment. LGTM https://reviews.llvm.org/D26385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24431: CodeGen: Start using inrange annotations on vtable getelementptr.

pcc added a comment. Ping https://reviews.llvm.org/D24431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

danalbert accepted this revision. danalbert added a reviewer: danalbert. danalbert added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

srhines updated this revision to Diff 77236. srhines added a comment. Switched to conditionally defining __ANDROID_API__ instead. https://reviews.llvm.org/D26385 Files: lib/Basic/Targets.cpp test/Driver/android-targets.cpp Index: test/Driver/android-targets.cpp

[PATCH] D25771: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

hokein added a comment. One more comment, otherwise looks good. Comment at: change-namespace/ChangeNamespace.cpp:275 + (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front())) + .str(); + auto IsInMovedNs = Using an invalid name `-` is

[PATCH] D26236: [clang-move] Move all code from old.h/cc directly when moving all class declarations from old.h.

This revision was automatically updated to reflect the committed changes. Closed by commit rL286281: [clang-move] Move all code from old.h/cc directly when moving all class… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D26236?vs=77223=77233#toc Repository: rL LLVM

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge created this revision. rSerge added reviewers: dberris, rengolin. rSerge added subscribers: iid_iunknown, cfe-commits. Herald added a subscriber: aemerson. This patch adds XRay support in Clang for AArch64 target. https://reviews.llvm.org/D26415 Files: lib/Driver/Tools.cpp

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

srhines added a comment. In https://reviews.llvm.org/D26385#589589, @eugenis wrote: > This is a good change, but I don't think it is the right fix for PR30940. > Instead of handling this in the NDK, we should change *::getIRStackGuard to > fallback to __stack_chk_guard when targeting an old

[PATCH] D26410: [CodeGen] Don't emit the same global block multiple times.

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rjmccall. george.burgess.iv added a subscriber: cfe-commits. https://reviews.llvm.org/D14274 makes our constexpr evaluator more aggressive with some variables marked `const`. This changes how we behave on code like the

[PATCH] D22296: CodeGen: New vtable group representation: struct of vtable arrays.

pcc added a comment. Ping https://reviews.llvm.org/D22296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

kastiglione updated this revision to Diff 77232. kastiglione added a comment. Added test https://reviews.llvm.org/D26406 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c test/SemaObjC/check-dup-objc-decls-1.m Index: test/SemaObjC/check-dup-objc-decls-1.m

[clang-tools-extra] r286281 - [clang-move] Move all code from old.h/cc directly when moving all class declarations from old.h.

Author: hokein Date: Tue Nov 8 13:55:13 2016 New Revision: 286281 URL: http://llvm.org/viewvc/llvm-project?rev=286281=rev Log: [clang-move] Move all code from old.h/cc directly when moving all class declarations from old.h. Summary: When moving all code to new.h/cc, these code also will be

[PATCH] D25771: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

ioeric updated this revision to Diff 77228. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressed comments. https://reviews.llvm.org/D25771 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h

Re: r286243 - [clang-format] Remove (SourceManager, FileID) variants

Fixed in r286279. On Tue, Nov 8, 2016 at 10:45 AM, Galina Kistanova wrote: > Hello Daniel, > > This commit broke at least one of our builders: > http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/234 > > Please have a look at this? > > Thanks > > Galina >

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

alexfh added a comment. > and generally frowned upon in many codebases (e.g. LLVM) Should it still be a part of google/? The old check was enforcing a part of the Google C++ style guide, but the new one seems to be somewhat broader. Am I mistaken? https://reviews.llvm.org/D23130

r286279 - Remove FormatContext from libClang as it is now unused.

Author: djasper Date: Tue Nov 8 13:47:19 2016 New Revision: 286279 URL: http://llvm.org/viewvc/llvm-project?rev=286279=rev Log: Remove FormatContext from libClang as it is now unused. Modified: cfe/trunk/include/clang/Index/CommentToXML.h cfe/trunk/lib/Index/CommentToXML.cpp Modified:

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

danalbert added a comment. > It is defines with a value of 0. This allows you to actually do something > better, IMO. Can we stick with undefined? That's historically how things have been, and I'm sure there's code out there depending on that (I had actually written a test that would depend

Re: r285946 - Using release to free memory is at best confusing -- one would expect

Ah, I see - your follow up in 285950 mentions that this unique_ptr was always null, so none of it really mattered/did anything. On Tue, Nov 8, 2016 at 11:42 AM David Blaikie wrote: > On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits < >

[PATCH] D26373: [analyzer] Provide Contains() on ImmutableMap program state partial trait.

ddcc added a comment. Even though there isn't a performance difference, I think it is semantically clearer since it is explicit that the value is unneeded. The interface of ProgramState provides a `contains()` function that calls into `Contains()` of the underlying partial traits as part of

Re: r285946 - Using release to free memory is at best confusing -- one would expect

On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chandlerc > Date: Thu Nov 3 12:42:32 2016 > New Revision: 285946 > > URL: http://llvm.org/viewvc/llvm-project?rev=285946=rev > Log: > Using release to free memory is at best confusing

[PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv updated this revision to Diff 77222. george.burgess.iv added a comment. Rebased and made the `__builtin_object_size` code a tiny bit cleaner. The blocks bugfix I mentioned will be up as a separate review in a few minutes. :) https://reviews.llvm.org/D14274 Files:

Re: r284272 - Implement no_sanitize_address for global vars

On Fri, Oct 14, 2016 at 3:55 PM, Douglas Katzman via cfe-commits wrote: > Author: dougk > Date: Fri Oct 14 14:55:09 2016 > New Revision: 284272 > > URL: http://llvm.org/viewvc/llvm-project?rev=284272=rev > Log: > Implement no_sanitize_address for global vars > >

[PATCH] D26236: [clang-move] Move all code from old.h/cc directly when moving all class declarations from old.h.

hokein updated this revision to Diff 77223. hokein marked 2 inline comments as done. hokein added a comment. Update test to check old header. https://reviews.llvm.org/D26236 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h test/clang-move/Inputs/test.h

[PATCH] D26196: Add support for non-zero null pointers

yaxunl added inline comments. Comment at: lib/CodeGen/CodeGenTypes.cpp:743 +auto NullPtr = CGM.getNullPtr(LLPT, T); +return isa(NullPtr); + } tony-tye wrote: > Is this correct if the target does not represent a NULL pointer as the > address with value

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

eugenis added a comment. This is a good change, but I don't think it is the right fix for PR30940. Instead of handling this in the NDK, we should change *::getIRStackGuard to fallback to __stack_chk_guard when targeting an old version. https://reviews.llvm.org/D26385

Re: r284272 - Implement no_sanitize_address for global vars

oh, sorry for missing this email. I'll say "no" - I was hoping you'd audit it! jyknight looked at it and gave me the suggestion to fail the attribute parsing if, in the non-deprecated syntax, _any_ of the no_sanitize modifiers are inapplicable to global vars. On Tue, Oct 25, 2016 at 7:19 PM,

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

aaron.ballman added inline comments. Comment at: clang-tidy/google/GlobalNamesCheck.cpp:77 +} +diag( +D->getLocStart(), Is this formatting that clang-format generates? Comment at: test/clang-tidy/google-global-names.cpp:13-14

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

srhines added a comment. In https://reviews.llvm.org/D26385#589534, @danalbert wrote: > > This macro (along with ANDROID) should always be defined for Android > > targets. > > What if only `arm-linux-androideabi` (without a version) is specified? We > should be falling back to the old behavior

[PATCH] D25771: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

hokein added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:233 + const DeclContext *DeclCtx, SourceLocation Loc) { + return SM.isBeforeInTranslationUnit(SM.getSpellingLoc(D->getLocation()), +

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

kastiglione added a comment. @arphaman I wondered whether this called for a test. I'm happy to add one just like that. https://reviews.llvm.org/D26406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

danalbert added a comment. > This macro (along with ANDROID) should always be defined for Android targets. What if only `arm-linux-androideabi` (without a version) is specified? We should be falling back to the old behavior (don't defined `__ANDROID_API__`) when that happens since that's what

[PATCH] D26196: Add support for non-zero null pointers

tony-tye added inline comments. Comment at: lib/CodeGen/CodeGenTypes.cpp:743 +auto NullPtr = CGM.getNullPtr(LLPT, T); +return isa(NullPtr); + } Is this correct if the target does not represent a NULL pointer as the address with value 0? Or should this

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added a comment. In https://reviews.llvm.org/D23130#588681, @alexfh wrote: > Benjamin, what's the plan here? I still think this check is useful, particularly for LLVM. I also don't think any of the existing review comments still apply or have ever applied in the first place, so I

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer updated this revision to Diff 77216. bkramer added a comment. Herald added subscribers: modocache, mgorny. Update to head https://reviews.llvm.org/D23130 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/GlobalNamesCheck.cpp clang-tidy/google/GlobalNamesCheck.h

Re: r286243 - [clang-format] Remove (SourceManager, FileID) variants

Hello Daniel, This commit broke at least one of our builders: http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/234 Please have a look at this? Thanks Galina On Tue, Nov 8, 2016 at 8:11 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper

r286264 - Revert "Remove now unnecessary FormatRewriterContext."

Author: djasper Date: Tue Nov 8 12:30:52 2016 New Revision: 286264 URL: http://llvm.org/viewvc/llvm-project?rev=286264=rev Log: Revert "Remove now unnecessary FormatRewriterContext." This reverts commit r286262. I accidentally committed it without all of the changes. Modified:

[clang-tools-extra] r286257 - Remove mentions of clang-analyzer-alpha

Author: alexfh Date: Tue Nov 8 12:12:56 2016 New Revision: 286257 URL: http://llvm.org/viewvc/llvm-project?rev=286257=rev Log: Remove mentions of clang-analyzer-alpha Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst clang-tools-extra/trunk/test/clang-tidy/static-analyzer.cpp

r286262 - Remove now unnecessary FormatRewriterContext.

Author: djasper Date: Tue Nov 8 12:29:19 2016 New Revision: 286262 URL: http://llvm.org/viewvc/llvm-project?rev=286262=rev Log: Remove now unnecessary FormatRewriterContext. Modified: cfe/trunk/lib/Index/CommentToXML.cpp Modified: cfe/trunk/lib/Index/CommentToXML.cpp URL:

[PATCH] D26196: Add support for non-zero null pointers

yaxunl retitled this revision from "[WIP] Add support for non-zero null pointers" to "Add support for non-zero null pointers". yaxunl updated this revision to Diff 77210. yaxunl added a comment. Fixed list initialization of large struct which are mostly initialized by 0 through memset. Added

[PATCH] D26304: [Power9] vector load/store with length - clang portion

kbarton accepted this revision. kbarton added a comment. This revision is now accepted and ready to land. With the suggestions above, this LGTM. https://reviews.llvm.org/D26304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26308: [PowerPC] Add vector conversion builtins to altivec.h - clang portion

kbarton accepted this revision. kbarton added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D26308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

kastiglione created this revision. kastiglione added a reviewer: cfe-commits. Expose a warning flag for `warn_duplicate_protocol_def`. This allows control over the severity of duplicate protocol definitions. For example `-Werror=duplicate-protocol` or `#pragma clang diagnostic ignored

Re: [PATCH] D26163: [clang-format] Fix PR30527: Regression when clang-format insert spaces in [] when in template

Friendly ping:) On Mon, Oct 31, 2016 at 10:16 PM, Branko Kokanovic wrote: > branko created this revision. > branko added a reviewer: djasper. > branko added a subscriber: cfe-commits. > Herald added a subscriber: klimek. > > Actual regression was introduced in r272668.

[PATCH] D26375: [libc++] Compare to libc++ source directory for out-of-source check

smeenai added a comment. In https://reviews.llvm.org/D26375#588949, @beanz wrote: > This patch doesn't make sense to me. > > In an in-tree build `CMAKE_SOURCE_DIR` would be the LLVM source directory > which shouldn't match your `CMAKE_BINARY_DIR`. > > In an out-of-tree build `CMAKE_SOURCE_DIR`

  1   2   >