[PATCH] D24688: Introduce "hosted" module flag.

mehdi_amini added a comment. In https://reviews.llvm.org/D24688#639158, @jyknight wrote: > Since this requires everyone generating llvm IR to add this module attribute > for optimal codegen, Not sure yet how it'll end up, I'll revamp this. See also:

Re: r291123 - CodeGen: plumb header search down to the IAS

On Sat, Jan 7, 2017 at 1:27 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I agree with Eric, I don't think that serializing the structure to > std::cout is the right way to handle this. > > What were you thinking of mocking? Wouldn't you really end up mocking the

r291382 - PR18402: work around bug in libstdc++4.8's detection of whether ::gets exists.

Author: rsmith Date: Sat Jan 7 22:01:15 2017 New Revision: 291382 URL: http://llvm.org/viewvc/llvm-project?rev=291382=rev Log: PR18402: work around bug in libstdc++4.8's detection of whether ::gets exists. This should allow clang to successfully compile libstdc++4.8's headers in C++14 mode.

[PATCH] D24688: Introduce "hosted" module flag.

jyknight added a comment. Since this requires everyone generating llvm IR to add this module attribute for optimal codegen, it should be documented in release notes and the LangRef, I think. I mean: it's unfortunate that it's needed at all, but at the very least it should be possible for

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

dylanmckay updated this revision to Diff 83544. dylanmckay added a comment. Lower the 'signal' attribute correctly I had forgotten to lower this attribute and so it would not have been lowered to IR at all. Now it works fine. https://reviews.llvm.org/D28451 Files:

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

dylanmckay created this revision. dylanmckay added a reviewer: aaron.ballman. dylanmckay added a subscriber: cfe-commits. This teaches clang how to parse and lower the 'interrupt' and 'naked' attributes. This allows interrupt signal handlers to be written. https://reviews.llvm.org/D28451

[PATCH] D28450: [libcxxabi] By default, enable test targets when building in standalone.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291378: [libcxxabi] Enable tests by default in standalone. (authored by bryant). Changed prior to commit: https://reviews.llvm.org/D28450?vs=83541=83542#toc Repository: rL LLVM

[PATCH] D28450: [libcxxabi] By default, enable test targets when building in standalone.

bryant created this revision. bryant added reviewers: compnerd, jroelofs, EricWF. bryant added subscribers: cfe-commits, llvm-commits. Herald added a subscriber: mgorny. This fixes the current buildbot failure:

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad added inline comments. Comment at: test/Driver/linux-ld.c:623 +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// RUN: --target=arm64-unknown-linux-gnu \ +// RUN: --gcc-toolchain="" \ rengolin wrote: > cryptoad wrote: > > rengolin

[PATCH] D27424: Add the diagnose_if attribute to clang.

EricWF added a comment. Awesome! I'm so excited for this! https://reviews.llvm.org/D27424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r291367 - [libcxxabi] Add flag to conditionally enable tests

Author: bryant Date: Sat Jan 7 16:14:04 2017 New Revision: 291367 URL: http://llvm.org/viewvc/llvm-project?rev=291367=rev Log: [libcxxabi] Add flag to conditionally enable tests Differential Revision: https://reviews.llvm.org/D28449 Modified: libcxxabi/trunk/CMakeLists.txt Modified:

[PATCH] D28449: [libcxxabi] Include flag to exclude test and fuzz subdirs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291367: [libcxxabi] Add flag to conditionally enable tests (authored by bryant). Changed prior to commit: https://reviews.llvm.org/D28449?vs=83536=83539#toc Repository: rL LLVM

Re: [libcxx] r291345 - Replace identifiers called `__out` because Windows.h #defines it.

Just a correction on the commit message: its not Windows.h that is defining `__out`. `__out` is a SAL keyword. Unfortunately, I don't know of a way to disable SAL. On Sat, Jan 7, 2017 at 3:27 AM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Sat

[PATCH] D28212: typeinfo: provide a partial implementation for Win32

compnerd added inline comments. Comment at: include/typeinfo:109 protected: +#if defined(_LIBCPP_HAS_MS_ABI_TYPEINFO) +#else EricWF wrote: > Don't we need a constructor here? No, we do not need a constructor since the emitted object is already a well formed

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

compnerd abandoned this revision. compnerd added a comment. We have a temporary workaround while a proper macro is considered by SD-6. Repository: rL LLVM https://reviews.llvm.org/D28383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r291331 - thread: implement sleep_for on Windows

Yup, that sounds better. I'll put up a patch soon. Cheers, / Asiri On 7 Jan 2017 9:18 p.m., "Saleem Abdulrasool" wrote: > I would really rather not introduce a `__libcpp_thread_nanosleep`. > Different systems may have different granularities for their sleep. A >

Re: r291123 - CodeGen: plumb header search down to the IAS

I agree with Eric, I don't think that serializing the structure to std::cout is the right way to handle this. What were you thinking of mocking? Wouldn't you really end up mocking the entire backend? That is the small wrinkle with the way that we deal with inline assembly. It really doesn't

Re: [libcxx] r291331 - thread: implement sleep_for on Windows

I would really rather not introduce a `__libcpp_thread_nanosleep`. Different systems may have different granularities for their sleep. A `__libcpp_sleep_for(std::chrono::duration)` sounds reasonable however. On Fri, Jan 6, 2017 at 11:53 PM, Asiri Rathnayake < asiri.rathnay...@gmail.com> wrote:

[PATCH] D28449: [libcxxabi] Include flag to exclude test and fuzz subdirs.

bryant updated this revision to Diff 83536. bryant added a comment. set default val to LLVM_INCLUDE_TESTS, like the others. https://reviews.llvm.org/D28449 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++

[PATCH] D28449: [libcxxabi] Include flag to exclude test and fuzz subdirs.

bryant created this revision. bryant added reviewers: compnerd, EricWF, jroelofs. bryant added subscribers: cfe-commits, llvm-commits. Herald added a subscriber: mgorny. LLVM_INCLUDE_TESTS CLANG_INCLUDE_TESTS LIBCXX_INCLUDE_TESTS ...and now this. https://reviews.llvm.org/D28449 Files:

r291360 - Fix buildbots.

Author: rsmith Date: Sat Jan 7 13:58:39 2017 New Revision: 291360 URL: http://llvm.org/viewvc/llvm-project?rev=291360=rev Log: Fix buildbots. Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp URL:

r291358 - Consistently use a ConstantEvaluated context for expressions in attributes,

Author: rsmith Date: Sat Jan 7 13:42:26 2017 New Revision: 291358 URL: http://llvm.org/viewvc/llvm-project?rev=291358=rev Log: Consistently use a ConstantEvaluated context for expressions in attributes, except for those with the "attributes are unevaluated contexts" flag. Modified:

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

rengolin added inline comments. Comment at: test/Driver/linux-ld.c:623 +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// RUN: --target=arm64-unknown-linux-gnu \ +// RUN: --gcc-toolchain="" \ cryptoad wrote: > rengolin wrote: > > shouldn't

[PATCH] D27424: Add the diagnose_if attribute to clang.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please point this out in the release notes as well. https://reviews.llvm.org/D27424 ___ cfe-commits mailing list

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

aaron.ballman added a comment. In https://reviews.llvm.org/D20693#639030, @hintonda wrote: > Matthias, I think you make a good point. While noexcept(expr) is valuable, > noexcept(false) adds no value. Therefore, I think we should do as you > suggest, i.e.: > > s/throw()/noexcept/ >

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Matthias, I think you make a good point. While noexcept(expr) is valuable, noexcept(false) adds no value. Therefore, I think we should do as you suggest, i.e.: s/throw()/noexcept/ s/throw(something)// Aaron, does this work for you?

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

smeenai added a comment. One potential issue with always forcing the non-debug msvcrt is that any apps that link against libc++ would also then need to use the non-debug CRT libraries, otherwise you'd get all sorts of fun runtime errors (e.g. cross-domain frees). I think the default Visual

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

hfinkel added a comment. > (IEEEdouble, IEEEdouble) -> (uint64_t, uint64_t) -> PPCDoubleDoubleImpl, then > run the old algorithm. We need to document in the code what is going on here and why it works. Just looking at a bunch of code like this: if (Semantics == ) { APFloat

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad added inline comments. Comment at: test/Driver/linux-ld.c:623 +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// RUN: --target=arm64-unknown-linux-gnu \ +// RUN: --gcc-toolchain="" \ rengolin wrote: > shouldn't you have used your

[PATCH] D26900: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available

mgorny retitled this revision from "[cmake] Obtain LLVM_CMAKE_PATH from llvm-config" to "[cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available". mgorny updated the summary for this revision. mgorny updated this revision to Diff 83527. mgorny added a comment. Updated to support fallback to

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

halyavin added inline comments. Comment at: lib/CMakeLists.txt:113 + add_library_flags(msvcrt) # C runtime startup files + add_library_flags(iso_stdio_wide_specifiers) +endif() EricWF wrote: > halyavin wrote: > > EricWF wrote: > > > smeenai wrote: > > > >

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

EricWF updated this revision to Diff 83526. EricWF added a comment. - Add comment explaining need for `iso_stdio_wide_specifiers.lib`. https://reviews.llvm.org/D28441 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake lib/CMakeLists.txt test/libcxx/test/config.py Index:

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

EricWF added inline comments. Comment at: lib/CMakeLists.txt:113 + add_library_flags(msvcrt) # C runtime startup files + add_library_flags(iso_stdio_wide_specifiers) +endif() halyavin wrote: > EricWF wrote: > > smeenai wrote: > > > Maybe add a comment

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

halyavin added inline comments. Comment at: lib/CMakeLists.txt:113 + add_library_flags(msvcrt) # C runtime startup files + add_library_flags(iso_stdio_wide_specifiers) +endif() EricWF wrote: > smeenai wrote: > > Maybe add a comment explaining the purpose of

[PATCH] D28295: [libunwind] [cmake] Support overriding LLVM_CMAKE_PATH

mgorny requested a review of this revision. mgorny added a comment. @EricWF suggests that it'd be better to wait a while before depending on newer llvm-config, so it'd probably be preferable to do this one instead first. https://reviews.llvm.org/D28295

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

EricWF added inline comments. Comment at: CMakeLists.txt:43 +if (WIN32 AND NOT MINGW) + set(LIBCXX_TARGETING_WINDOWS ON) +else() EricWF wrote: > smeenai wrote: > > Not the biggest fan of this name, since it's not obvious why MinGW > > shouldn't count as

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

halyavin added inline comments. Comment at: lib/CMakeLists.txt:112 + add_library_flags(vcruntime) # C++ runtime + add_library_flags(msvcrt) # C runtime startup files + add_library_flags(iso_stdio_wide_specifiers) halyavin wrote: > As far as I know,

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

halyavin added inline comments. Comment at: lib/CMakeLists.txt:112 + add_library_flags(vcruntime) # C++ runtime + add_library_flags(msvcrt) # C runtime startup files + add_library_flags(iso_stdio_wide_specifiers) As far as I know, applications shouldn't use

[libcxx] r291345 - Replace identifiers called `__out` because Windows.h #defines it.

Author: ericwf Date: Sat Jan 7 05:27:06 2017 New Revision: 291345 URL: http://llvm.org/viewvc/llvm-project?rev=291345=rev Log: Replace identifiers called `__out` because Windows.h #defines it. Windows is greedy and it defines the identifier `__out` as a macro. This patch renames all conflicting

[libcxx] r291344 - Added "Michael Park" to `CREDITS.TXT`.

Author: mpark Date: Sat Jan 7 04:19:24 2017 New Revision: 291344 URL: http://llvm.org/viewvc/llvm-project?rev=291344=rev Log: Added "Michael Park" to `CREDITS.TXT`. Summary: Test commit + give myself credit. Reviewers: EricWF Differential Revision: https://reviews.llvm.org/D28431 Modified:

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

EricWF added inline comments. Comment at: CMakeLists.txt:388 +# non-debug DLLs +remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1") + smeenai wrote: > cl (and presumably clang-cl) also accepts all these flags with a leading dash > instead of a leading

[libcxx] r291343 - [libc++] Implement terminate(), unexpected() and uncaught_exceptions() on Windows

Author: ericwf Date: Sat Jan 7 04:04:40 2017 New Revision: 291343 URL: http://llvm.org/viewvc/llvm-project?rev=291343=rev Log: [libc++] Implement terminate(), unexpected() and uncaught_exceptions() on Windows Summary: This patch implements the following functions on Windows by forwarding to

[PATCH] D28442: [libc++] Implement terminate(), unexpected() and uncaught_exceptions() on Windows

EricWF marked an inline comment as done. EricWF added a comment. In https://reviews.llvm.org/D28442#638862, @smeenai wrote: > Hooray for Microsoft for putting all these in msvcrt (their **C** runtime > library) instead of msvcprt (their C++ runtime library), I guess :p Although Boo to `eh.h`

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

rsmith added a comment. Can you add a test please? https://reviews.llvm.org/D28427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r291329 - Add _LIBCPP_ABI_[ITANIUM|MICROSOFT] macros.

On Sat, Jan 7, 2017 at 1:29 AM, Shoaib Meenai wrote: > Do you think it's worth also checking for the presence of cxxabi.h and > assuming the Itanium ABI if it's found, since the MS ABI shouldn't be using > any ABI library? > No I don't think we should check for `cxxabi.h`.It's

[libcxx] r291342 - Ensure Sleep(...) isn't passed the value 0 on Windows

Author: ericwf Date: Sat Jan 7 03:53:28 2017 New Revision: 291342 URL: http://llvm.org/viewvc/llvm-project?rev=291342=rev Log: Ensure Sleep(...) isn't passed the value 0 on Windows Modified: libcxx/trunk/src/thread.cpp Modified: libcxx/trunk/src/thread.cpp URL:

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

vlad.tsyrklevich created this revision. vlad.tsyrklevich added reviewers: zaks.anna, cfe-commits. While extending the GenericTaintChecker for my purposes I'm hitting a case where taint is not propagated where I believe it should be. Currently, the following example will propagate taint

Re: [libcxx] r291329 - Add _LIBCPP_ABI_[ITANIUM|MICROSOFT] macros.

Do you think it's worth also checking for the presence of cxxabi.h and assuming the Itanium ABI if it's found, since the MS ABI shouldn't be using any ABI library? (_LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY would have been ideal were it available persistently rather than only during the build of libc++

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

smeenai added inline comments. Comment at: lib/CMakeLists.txt:108-109 +if (LIBCXX_TARGETING_WINDOWS) + add_compile_flags(/Zl) + add_link_flags(/nodefaultlib) + add_library_flags(ucrt) # Universal C runtime halyavin wrote: > smeenai wrote: > > These should be