[PATCH] D28315: Update tools to use new getStyle API

amaiorano added a comment. In https://reviews.llvm.org/D28315#641032, @amaiorano wrote: > In https://reviews.llvm.org/D28315#639559, @ioeric wrote: > > > I ran `ninja check-all` with https://reviews.llvm.org/D28081 and > > https://reviews.llvm.org/D28315 (in Linux), and some lit tests failed,

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak added a comment. Richard, does the updated patch look OK? https://reviews.llvm.org/D24969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28018: AMD family 17h (znver1) enablement

This revision was automatically updated to reflect the committed changes. Closed by commit rL291544: AMD family 17h (znver1) enablement (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D28018?vs=83626=83779#toc Repository: rL LLVM https://reviews.llvm.org/D28018

r291545 - [X86] Add recent CPU strings to some of the tests that check other cpu names.

Author: ctopper Date: Tue Jan 10 00:02:16 2017 New Revision: 291545 URL: http://llvm.org/viewvc/llvm-project?rev=291545=rev Log: [X86] Add recent CPU strings to some of the tests that check other cpu names. Modified: cfe/trunk/test/Driver/x86-march.c

r291544 - AMD family 17h (znver1) enablement

Author: ctopper Date: Tue Jan 10 00:02:12 2017 New Revision: 291544 URL: http://llvm.org/viewvc/llvm-project?rev=291544=rev Log: AMD family 17h (znver1) enablement Summary: This patch enables the following 1. AMD family 17h architecture using "znver1" tune flag (-march, -mcpu). 2. ISAs that are

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

alexshap added inline comments. Comment at: lib/Format/Format.cpp:424 +llvm::Error make_string_error(const llvm::Twine ) { + return llvm::make_error(Message, amaiorano wrote: > ioeric wrote: > > Maybe make this `inline`? > Yes. regarding this function and

[PATCH] D28315: Update tools to use new getStyle API

amaiorano added a comment. In https://reviews.llvm.org/D28315#639559, @ioeric wrote: > I ran `ninja check-all` with https://reviews.llvm.org/D28081 and > https://reviews.llvm.org/D28315 (in Linux), and some lit tests failed, namely: > > Clang :: Format/style-on-command-line.cpp This was the

[PATCH] D28255: [OpenMP] support the 'is_device_ptr' clause with 'target parallel for' pragma

This revision was automatically updated to reflect the committed changes. Closed by commit rL291540: [OpenMP] Support the 'is_device_ptr' clause with 'target parallel for' pragma (authored by kli). Changed prior to commit: https://reviews.llvm.org/D28255?vs=82951=83774#toc Repository: rL

[PATCH] D28402: [OpenMP] support the 'is_device_ptr' clause with 'target parallel for simd' pragma

This revision was automatically updated to reflect the committed changes. Closed by commit rL291537: [OpenMP] Support the 'is_device_ptr' clause with 'target parallel for simd'… (authored by kli). Changed prior to commit: https://reviews.llvm.org/D28402?vs=83372=83772#toc Repository: rL

[libcxx] r291536 - threading_support: delete the critical section

Author: compnerd Date: Mon Jan 9 22:18:47 2017 New Revision: 291536 URL: http://llvm.org/viewvc/llvm-project?rev=291536=rev Log: threading_support: delete the critical section Although the CriticalSection itself doesnt need to be destroyed, there may be debug data associated with it. Plug a

[PATCH] D28018: AMD family 17h (znver1) enablement

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24688: Introduce "hosted" module flag.

mehdi_amini added a comment. Thanks, I'll investigate function attributes then! https://reviews.llvm.org/D24688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28495: [analyzer] Support inlining of '[self classMethod]' and '[[self class] classMethod]'

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:972 + Receiver == getSelfSVal().getAsRegion()) +return RuntimeDefinition(findDefiningRedecl(E->getMethodDecl())); + Here is a case where dispatching via the

[PATCH] D24688: Introduce "hosted" module flag.

pcc added a comment. In https://reviews.llvm.org/D24688#638836, @mehdi_amini wrote: > In https://reviews.llvm.org/D24688#638835, @pcc wrote: > > > Didn't we figure out in the end that this could be a function attribute > > instead? > > > We did? You wrote in PR30403: "I had a brief look at what

r291528 - Don't classify variable template names as type templates.

Author: rsmith Date: Mon Jan 9 20:15:49 2017 New Revision: 291528 URL: http://llvm.org/viewvc/llvm-project?rev=291528=rev Log: Don't classify variable template names as type templates. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp

[PATCH] D28505: CGDecl: Skip static variable initializers in unreachable code

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yes, this is correct; per [stmt.dcl]/5, the destructor only runs if the object was constructed. Repository: rL LLVM https://reviews.llvm.org/D28505

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 83758. xiangzhai marked 2 inline comments as done. xiangzhai added a comment. make II_g_*malloc*_n sense Repository: rL LLVM https://reviews.llvm.org/D28348 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index:

r291525 - [NFC] Rename RAII ExpressionEvaluationContext variable from Unevaluated to ConstantEvaluated when parsing a constant expression.

Author: faisalv Date: Mon Jan 9 19:29:41 2017 New Revision: 291525 URL: http://llvm.org/viewvc/llvm-project?rev=291525=rev Log: [NFC] Rename RAII ExpressionEvaluationContext variable from Unevaluated to ConstantEvaluated when parsing a constant expression. This renaming makes it consistent

RE: [PATCH] D28404: IRGen: Add optnone attribute on function during O0

(Re-add cfe-commits; otherwise same) > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Duncan P. N. Exon Smith via cfe-commits > Sent: Monday, January 09, 2017 4:10 PM > To: reviews+d28404+public+53e0f4655ef79...@reviews.llvm.org > Cc:

[PATCH] D28505: CGDecl: Skip static variable initializers in unreachable code

MatzeB created this revision. MatzeB added a reviewer: rsmith. MatzeB added a subscriber: cfe-commits. MatzeB set the repository for this revision to rL LLVM. Herald added a subscriber: mcrosier. This fixes http://llvm.org/PR31054 I don't know whether that is the correct fix: Are we actually

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood added a comment. In https://reviews.llvm.org/D28365#640859, @rnk wrote: > In https://reviews.llvm.org/D28365#640825, @hamzasood wrote: > > > In https://reviews.llvm.org/D28365#640775, @rnk wrote: > > > > > Can we revert the linker environment change from this patch? It'll be > > >

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640682, @mehdi_amini wrote: > > I'm now thinking along the lines of a `-foptimize-off` flag (bikesheds > > welcome) which would set the default for the pragma to 'off'. How is that > > different than what you wanted for `-O0`? It

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

rnk added a comment. In https://reviews.llvm.org/D28365#640825, @hamzasood wrote: > In https://reviews.llvm.org/D28365#640775, @rnk wrote: > > > Can we revert the linker environment change from this patch? It'll be > > easier to review separately. > > > Sure. But that'll break compiling for x86

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood added a comment. In https://reviews.llvm.org/D28365#640775, @rnk wrote: > Can we revert the linker environment change from this patch? It'll be easier > to review separately. Sure. But that'll break compiling for x86 on Visual Studio 2017, is that okay?

Re: [libcxx] r291466 - [Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW

Ops. Fixed in r291517! On Mon, Jan 9, 2017 at 2:13 PM, Reid Kleckner wrote: > This appears to have broken the Chromium build: > https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac/builds/12620/steps/gclient%20runhooks/logs/stdio > FAILED:

[libcxx] r291517 - [Chrono][Darwin] Include header for gettimeofday

Author: bruno Date: Mon Jan 9 18:51:02 2017 New Revision: 291517 URL: http://llvm.org/viewvc/llvm-project?rev=291517=rev Log: [Chrono][Darwin] Include header for gettimeofday Followup on r291466 and include the proper header. This fixes:

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

enyquist added a comment. Hey bmharper :) I've got a review open that conflicts with this one, just having a look to see what I'll need to refactor (https://reviews.llvm.org/D28462). In fact, I have a question-- the conflict is specifically in WhitespaceManager.cpp. Since I needed to detect PP

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

rnk added a comment. In https://reviews.llvm.org/D28365#639253, @hamzasood wrote: > - Added an option to set the environment in a clang::driver::Command, which > makes the environment modifying introduced in the last update a bit more > reliable. > > @rnk I looked into using the new MSVC

[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

rnk added a comment. In https://reviews.llvm.org/D20136#640689, @amccarth wrote: > > and folks have to manually add mincore.lib to their link. > > I could load the library dynamically on demand and use GetProcAddress, but I > suspect that would further degrade the performance. I could probably

r291513 - [coroutines] Sema: Allow co_return all by itself.

Author: gornishanov Date: Mon Jan 9 18:08:31 2017 New Revision: 291513 URL: http://llvm.org/viewvc/llvm-project?rev=291513=rev Log: [coroutines] Sema: Allow co_return all by itself. Reviewers: rsmith, EricWF Subscribers: mehdi_amini, llvm-commits, EricWF Differential Revision:

[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added a comment. > and folks have to manually add mincore.lib to their link. I could load the library dynamically on demand and use GetProcAddress, but I suspect that would further degrade the performance. I could probably write my own code to find the version in the binary, but I

Re: [PATCH] D28404: IRGen: Add optnone attribute on function during O0

This seems like a massive rehash of a discussion Peter Collingbourne and I had about passing -O0 to the linker for -flto=full. I had previously thought of LTO as "link time optimization", but in practice it's useful for (and required for correctness of some) non-optimization IR passes. In

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. > I'm now thinking along the lines of a `-foptimize-off` flag (bikesheds > welcome) which would set the default for the pragma to 'off'. How is that > different than what you wanted for `-O0`? It is defined in terms of an > existing pragma, which is WAY easier

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640588, @mehdi_amini wrote: > Actually, as mentioned before, I could be fine with making `O0` incompatible > with LTO, however security features like CFI (or other sort of whole-program > analyses/instrumentations) requires LTO.

[libcxx] r291508 - [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available

Author: mgorny Date: Mon Jan 9 17:41:38 2017 New Revision: 291508 URL: http://llvm.org/viewvc/llvm-project?rev=291508=rev Log: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available Use the new --cmakedir option to obtain LLVM_CMAKE_PATH straight from llvm-config. Fallback to local

[libcxxabi] r291506 - [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available

Author: mgorny Date: Mon Jan 9 17:31:05 2017 New Revision: 291506 URL: http://llvm.org/viewvc/llvm-project?rev=291506=rev Log: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available Use the new --cmakedir option to obtain LLVM_CMAKE_PATH straight from llvm-config. Fallback to local

[libunwind] r291505 - [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available

Author: mgorny Date: Mon Jan 9 17:27:04 2017 New Revision: 291505 URL: http://llvm.org/viewvc/llvm-project?rev=291505=rev Log: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available Use the new --cmakedir option to obtain LLVM_CMAKE_PATH straight from llvm-config. Fallback to local

[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

thakis added a comment. One consequence from this that I just realized is that linking a binary depending on clang stuff with (morally): c++ -o foo foo.o $($LLVMBUILD/bin/llvm-config --ldflags) -lclangFrontend -lclangDriver -lclangParse -lclangSema -lclangSerialization -lclangAnalysis

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. Actually, as mentioned before, I could be fine with making `O0` incompatible with LTO, however security features like CFI (or other sort of whole-program analyses/instrumentations) requires LTO. https://reviews.llvm.org/D28404

[PATCH] D28495: [analyzer] Support inlining of '[self classMethod]' and '[[self class] classMethod]'

zaks.anna created this revision. zaks.anna added reviewers: dergachev.a, dcoughlin. zaks.anna added a subscriber: cfe-commits. https://reviews.llvm.org/D28495 Files: lib/StaticAnalyzer/Core/CallEvent.cpp test/Analysis/inlining/InlineObjCClassMethod.m Index:

[libcxx] r291497 - Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY`

Author: bogner Date: Mon Jan 9 17:07:12 2017 New Revision: 291497 URL: http://llvm.org/viewvc/llvm-project?rev=291497=rev Log: Adorn __call_once_proxy with `inline` and `_LIBCPP_INLINE_VISIBILITY` As per discussion with mclow and EricWF on irc, this is small and simple enough to deserve being

r291495 - [cmake] Obtain LLVM_CMAKE_PATH from llvm-config

Author: mgorny Date: Mon Jan 9 17:06:39 2017 New Revision: 291495 URL: http://llvm.org/viewvc/llvm-project?rev=291495=rev Log: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config Use the new --cmakedir option to obtain LLVM_CMAKE_PATH straight from llvm-config instead of reconstructing it locally.

[PATCH] D26900: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available

mgorny added a comment. As discussed on IRC, I will commit the unconditional versions for projects that require the same version of LLVM (clang, lldb, lld) and the version with fallback for others (runtimes). https://reviews.llvm.org/D26900 ___

[PATCH] D26900: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available

This revision was automatically updated to reflect the committed changes. Closed by commit rL291495: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D26900?vs=83527=83718#toc Repository: rL LLVM

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640362, @probinson wrote: > In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > > > I don't follow: IMO if I generate a module with optnone and pipe it to `opt > > -O3` I expect no function IR to be touched. If it is not

r291493 - Add a test for diagnose_if.

Author: gbiv Date: Mon Jan 9 16:43:16 2017 New Revision: 291493 URL: http://llvm.org/viewvc/llvm-project?rev=291493=rev Log: Add a test for diagnose_if. Forgot to add this file as a part of r291418. Added: cfe/trunk/test/SemaCXX/diagnose_if-ext.cpp Added:

Re: Patch for Bug 22877

Perhaps you can check more explicitly that the destructor is called inside the loop? // CHECK: [[regex for LOOP_BODY]]: // CHECK: call void @_ZN3fooC1Ev // CHECK-NOT: br // CHECK: call void @_ZN3barC1E3foo // CHECK-NOT: br // CHECK: call void @_ZN3fooD1Ev // CHECK: br [[LOOP_BODY]] > On Jan 8,

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. Basically, I don't see why having clang always emit a real .o at -O0 would be a problem. I haven't gotten through the other-CFI documentation yet though. https://reviews.llvm.org/D28404 ___ cfe-commits mailing list

[libcxx] r291492 - Swap two lines in __mutex_base. On systems with high clock rates, we could mistakenly return no_timeout when a mutex had timed out if we got a tick between these two lines. Thanks t

Author: marshall Date: Mon Jan 9 16:32:11 2017 New Revision: 291492 URL: http://llvm.org/viewvc/llvm-project?rev=291492=rev Log: Swap two lines in __mutex_base. On systems with high clock rates, we could mistakenly return no_timeout when a mutex had timed out if we got a tick between these two

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen marked an inline comment as done. timshen added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:791 void makeNaN(bool SNaN, bool Neg, const APInt *fill) { -getIEEE().makeNaN(SNaN, Neg, fill); +if (usesLayout(getSemantics())) + return

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640284, @probinson wrote: > > > In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote: > > > > > In https://reviews.llvm.org/D28404#640170, @probinson wrote: > >

r291491 - Fixing test to work when the compiler defaults to a different C++ standard version.

Author: dyung Date: Mon Jan 9 16:20:10 2017 New Revision: 291491 URL: http://llvm.org/viewvc/llvm-project?rev=291491=rev Log: Fixing test to work when the compiler defaults to a different C++ standard version. Differential Revision: https://reviews.llvm.org/D28418 Modified:

[PATCH] D28418: Fixing test to work when the compiler defaults to a different C++ standard version

This revision was automatically updated to reflect the committed changes. Closed by commit rL291491: Fixing test to work when the compiler defaults to a different C++ standard… (authored by dyung). Changed prior to commit: https://reviews.llvm.org/D28418?vs=83447=83703#toc Repository: rL

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640284, @probinson wrote: > > > Upfront, it seemed peculiar to handle only one optimization level. After > > more thought, the whole idea of mixing -O0 and LTO seems

r291489 - MSVC seems to use (void) in __FUNCSIG__ for a zero-parameter function even in C++. Follow suit.

Author: rsmith Date: Mon Jan 9 16:16:16 2017 New Revision: 291489 URL: http://llvm.org/viewvc/llvm-project?rev=291489=rev Log: MSVC seems to use (void) in __FUNCSIG__ for a zero-parameter function even in C++. Follow suit. Modified: cfe/trunk/lib/AST/Expr.cpp

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen added a comment. In https://reviews.llvm.org/D27872#639020, @hfinkel wrote: > it is not at all obvious what is going on (i.e. why are we casting to > integers?). Maybe semPPCDoubleDoubleImpl needs a better name now? It seems > confusing to have semPPCDoubleDoubleImpl and

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen updated this revision to Diff 83700. timshen added a comment. Rename semPPCDoubleDoubleImpl to semPPCDoubleDoubleLegacy to reflect its use more accurately. https://reviews.llvm.org/D27872 Files: clang/test/CodeGen/ppc64-complex-parms.c llvm/include/llvm/ADT/APFloat.h

[PATCH] D28350: [Sema] Avoid -Wshadow warning when a "redefinition of " error is presented

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D28350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > You just wrote above that " mixing -O0 and LTO " is wrong, *if* I were to > agree with you at some point, then I'd make it a hard error. Yes, I was not clear that I meant that `-O0 -flto` on the same

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > I don't follow: IMO if I generate a module with optnone and pipe it to `opt > -O3` I expect no function IR to be touched. If it is not the case it is a bug. Your opinion and expectation are not

Re: [libcxx] r291466 - [Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW

This appears to have broken the Chromium build: https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac/builds/12620/steps/gclient%20runhooks/logs/stdio FAILED: projects/libcxx/lib/CMakeFiles/cxx_objects.dir/__/src/chrono.cpp.o

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

djasper accepted this revision. djasper added a comment. Just some nits. Thanks for working on this! Comment at: lib/Format/WhitespaceManager.cpp:158 +static bool IsPointerOrReference(tok::TokenKind Kind) { + return Kind == tok::star || Kind == tok::amp || Kind ==

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

rsmith added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:1214-1215 CXXRecordDecl::Create(Context, Kind, SemanticContext, KWLoc, NameLoc, Name, PrevClassTemplate? PrevClassTemplate->getTemplatedDecl() :

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. In https://reviews.llvm.org/D28404#640297, @probinson wrote: > Sorry, you lost me. CFI is part of DWARF and we do DWARF perfectly well > without LTO (and at O0). This CFI: http://clang.llvm.org/docs/ControlFlowIntegrity.html https://reviews.llvm.org/D28404

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

rnk added inline comments. Comment at: CMakeLists.txt:43 +if (WIN32 AND NOT MINGW) + set(LIBCXX_TARGETING_WINDOWS ON) +else() smeenai wrote: > EricWF wrote: > > EricWF wrote: > > > smeenai wrote: > > > > Not the biggest fan of this name, since it's not obvious

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Lex/HeaderSearch.cpp:1082 + auto TryEnterImported = [&](void) -> bool { +if (!ModulesEnabled) Maybe add a FIXME here indicating

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. In https://reviews.llvm.org/D28404#640284, @probinson wrote: > In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote: > > > In https://reviews.llvm.org/D28404#640170, @probinson wrote: > > > > > In https://reviews.llvm.org/D28404#640090, @mehdi_amini wrote: >

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added a comment. LGTM - @craig.topper any additional comments? https://reviews.llvm.org/D28018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640182, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote: > > > Also, that's not practicable: what if I have an LTO static library for > > which I don't have the source, now if I build my own file

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640170, @probinson wrote: > > > In https://reviews.llvm.org/D28404#640090, @mehdi_amini wrote: > > > > > In https://reviews.llvm.org/D28404#640046, @probinson wrote: > >

r291484 - PR31587: Fix handling of __FUNCSIG__ in C.

Author: rsmith Date: Mon Jan 9 15:40:40 2017 New Revision: 291484 URL: http://llvm.org/viewvc/llvm-project?rev=291484=rev Log: PR31587: Fix handling of __FUNCSIG__ in C. Fix crash if __FUNCSIG__ is used in a function without a prototype, and use "(void)" as parameter list instead of "()" for a

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291480: Allow constexpr construction of subobjects unconditionally, not just in C++14. (authored by dlj). Changed prior to commit: https://reviews.llvm.org/D28427?vs=83650=83686#toc Repository: rL

r291480 - Allow constexpr construction of subobjects unconditionally, not just in C++14.

Author: dlj Date: Mon Jan 9 15:38:07 2017 New Revision: 291480 URL: http://llvm.org/viewvc/llvm-project?rev=291480=rev Log: Allow constexpr construction of subobjects unconditionally, not just in C++14. Summary: Per https://wg21.link/CWG1677, the C++11 standard did not clarify that constant

[PATCH] D26900: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I figure we've waited a few days at this point. https://reviews.llvm.org/D26900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

ahatanak updated this revision to Diff 83680. ahatanak added a comment. Herald added a subscriber: mgorny. I added an AST analysis pass that is run before IRGen and decides which VarDecls need their lifetimes to be extended or disabled. It only looks at VarDecls which have their addresses taken

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

bruno added a comment. @rsmith ping! https://reviews.llvm.org/D26267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

dlj created this revision. dlj added a reviewer: mclow.lists. dlj added a subscriber: cfe-commits. Libcxx will define its own max_align_t when it is not available. However, the availability checks today only check for Clang's definition and GCC's definition. In particular, it does not check for

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

berenm added a comment. Pinging @djasper There's https://reviews.llvm.org/D27651 that will conflict with this one. https://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

berenm accepted this revision. berenm added a comment. This revision is now accepted and ready to land. Awesome! Pinging @djasper https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. Sounds good. Thanks! https://reviews.llvm.org/D28238 ___ cfe-commits mailing list

r291477 - [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

Author: mgorny Date: Mon Jan 9 14:54:20 2017 New Revision: 291477 URL: http://llvm.org/viewvc/llvm-project?rev=291477=rev Log: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin Correct the logic used to set ATOMIC_*_LOCK_FREE preprocessor macros not to rely on the ABI alignment

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rL291477: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D28213?vs=82791=83677#toc Repository: rL LLVM

Re: r291416 - [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions.

On 9 January 2017 at 03:44, Faisal Vali wrote: > On Mon, Jan 9, 2017 at 12:13 AM, Richard Smith > wrote: > > On 8 January 2017 at 19:02, Faisal Vali via cfe-commits > > wrote: > >> > >> Author: faisalv > >> Date: Sun Jan 8

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote: > Also, that's not practicable: what if I have an LTO static library for which > I don't have the source, now if I build my own file with -O0 -flto I can't > link anymore. Also: LTO is required for

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. In https://reviews.llvm.org/D28404#640170, @probinson wrote: > In https://reviews.llvm.org/D28404#640090, @mehdi_amini wrote: > > > In https://reviews.llvm.org/D28404#640046, @probinson wrote: > > > > > "I don't care" doesn't seem like much of a principle. > > > > >

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP updated this revision to Diff 83676. KP added a comment. Thanks for the review! Split declarations in test cases with PAS_Middle/PAS_Left. Add tests with references and rvalue references. https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640170, @probinson wrote: > In my experience, modifying source Note that the source modification consists of adding `#pragma clang optimize off` to the top of the file. It is not a complicated thing.

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640090, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640046, @probinson wrote: > > > "I don't care" doesn't seem like much of a principle. > > > Long version is: "There is no use-case, no users, so I don't have much >

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

efriedma requested changes to this revision. efriedma added a comment. This revision now requires changes to proceed. Missing regression test in test/SemaCXX/. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28477: Add LF_ prefix to LibFunc enums in TargetLibraryInfo.

dlj created this revision. dlj added a reviewer: rsmith. dlj added a subscriber: cfe-commits. The LibFunc::Func enum holds enumerators named for libc functions. Unfortunately, there are real situations, including libc implementations, where function names are actually macros (musl uses "#define

[PATCH] D28472: Move _PairT declaration out of __hash_combine to avoid warning under C++98

This revision was automatically updated to reflect the committed changes. Closed by commit rL291476: Move _PairT declaration out of __hash_combine to avoid warning under C++98 (authored by dim). Changed prior to commit: https://reviews.llvm.org/D28472?vs=83654=83672#toc Repository: rL LLVM

[libcxx] r291476 - Move _PairT declaration out of __hash_combine to avoid warning under C++98

Author: dim Date: Mon Jan 9 14:29:35 2017 New Revision: 291476 URL: http://llvm.org/viewvc/llvm-project?rev=291476=rev Log: Move _PairT declaration out of __hash_combine to avoid warning under C++98 Summary: Some parts of the FreeBSD tree are still compiled with C++98, and until rL288554 this

[libcxx] r291475 - Added XFAIL for the apple versions of clang as well

Author: marshall Date: Mon Jan 9 14:29:28 2017 New Revision: 291475 URL: http://llvm.org/viewvc/llvm-project?rev=291475=rev Log: Added XFAIL for the apple versions of clang as well Modified: libcxx/trunk/test/std/strings/string.view/string_view.literals/literal.pass.cpp

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

zaks.anna added a comment. Thanks for working on this! Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:443 + if (auto LCV = Val.getAs()) +return C.getSymbolManager().getRegionValueSymbol(LCV->getRegion()); + This might create a new symbol.

[PATCH] D28018: AMD family 17h (znver1) enablement

GGanesh added a comment. If Okay, can you please commit these on my behalf. I don't have write access. https://reviews.llvm.org/D28018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28018: AMD family 17h (znver1) enablement

GGanesh added a comment. Yes. True I mentioned that for the grouping or the order of the features enabled. These initFeatureMap are done based on the intrinsics and the CodeGen part. https://reviews.llvm.org/D28018 ___ cfe-commits mailing list

r291458 - [Lit Test] Make tests C++11 compatible - nothrow destructors

Author: lcharles Date: Mon Jan 9 12:24:16 2017 New Revision: 291458 URL: http://llvm.org/viewvc/llvm-project?rev=291458=rev Log: [Lit Test] Make tests C++11 compatible - nothrow destructors In C++11, a destructor's implicit exception-spec is nothrow. The IR for the destructor's invocation

Patch for Bug 22877

Hi,This is my first commit, please feel free to critique any of the code/new test since I'm not quite sure if this is in the correct format.The patch is for the bug https://llvm.org/bugs/show_bug.cgi?id=22877 regarding cleaning up default arguments in constructors while initializing an array.It

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. In https://reviews.llvm.org/D28404#640046, @probinson wrote: > In https://reviews.llvm.org/D28404#639887, @mehdi_amini wrote: > > > In https://reviews.llvm.org/D28404#639874, @probinson wrote: > > > > > Over the weekend I had a thought: Why is -O0 so special here?

  1   2   >