[PATCH] D30214: [Driver] Search for libc++ headers in ResourceDir

Hahnfeld abandoned this revision. Hahnfeld added a comment. http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html suggested to install runtime libraries (like libomp, but I think libc++ in certain cases may fall under the same category) to ResourceDir and I wanted the headers to be

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:23 +AST_MATCHER(QualType, isEnableIf) { + auto checkTemplate = [](const TemplateSpecializationType *Spec) { +if (!Spec || !Spec->getTemplateName().getAsTemplateDecl()) {

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

djasper requested changes to this revision. djasper added a comment. This revision now requires changes to proceed. So, while it might be convenient to view this all in one file, a test here is not convenient for me (or presumably other clang-format developers) to work with. You can make a

[PATCH] D29704: [XRay] [clang] Allow logging the first argument of a function call.

pelikan updated this revision to Diff 90431. pelikan marked an inline comment as done. pelikan added a comment. - clarify comment and rename variable so it'll all fit. https://reviews.llvm.org/D29704 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[libcxx] r296854 - Clean up more usages of _LIBCPP_HAS_NO_RVALUE_REFERENCES

Author: ericwf Date: Thu Mar 2 21:43:25 2017 New Revision: 296854 URL: http://llvm.org/viewvc/llvm-project?rev=296854=rev Log: Clean up more usages of _LIBCPP_HAS_NO_RVALUE_REFERENCES Modified:

[libcxx] r296851 - Fix sign-compare warning in test; Oddly this only appears on OS X

Author: ericwf Date: Thu Mar 2 20:02:07 2017 New Revision: 296851 URL: http://llvm.org/viewvc/llvm-project?rev=296851=rev Log: Fix sign-compare warning in test; Oddly this only appears on OS X Modified:

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:211 // Generate a report for this bug. - StringRef Desc = - describeUninitializedArgumentInCall(Call, IsFirstArgument); + std::string Desc = +

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

zaks.anna added a comment. > I’ve added the single file output option but I would like to keep the > multi-file option default This sounds good to me! I agree that this is a very useful addition. https://reviews.llvm.org/D30406 ___ cfe-commits

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

yaxunl updated this revision to Diff 90399. yaxunl added a comment. Make some arguments constant. https://reviews.llvm.org/D30551 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn.cl test/SemaOpenCL/builtins-amdgcn-error.cl

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:211 + + if (I + 1 != E) { +os << "getHashValue() Is there a cleaner way to do these two comparisons? https://reviews.llvm.org/D30406

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

vlad.tsyrklevich updated this revision to Diff 90417. vlad.tsyrklevich edited the summary of this revision. vlad.tsyrklevich added a comment. Updated the formatting to make the file split more obvious (padding/line break height) and added simple navigation across files, example here:

[PATCH] D30518: Fix msc-version.c test to handle _MSC_VER=1910

DaveBartolomeo closed this revision. DaveBartolomeo added a comment. 269843 https://reviews.llvm.org/D30518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r296843 - Fix msc-version.c test to handle _MSC_VER=1910

Author: dbartol Date: Thu Mar 2 18:08:55 2017 New Revision: 296843 URL: http://llvm.org/viewvc/llvm-project?rev=296843=rev Log: Fix msc-version.c test to handle _MSC_VER=1910 Previously, VC++ has always set _MSC_VER to a four-digit value with the two least significant digits set to zero.

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

ddcc reopened this revision. ddcc added a comment. This revision is now accepted and ready to land. Made a mistake with the last commit, I believe this should be fine now? Repository: rL LLVM https://reviews.llvm.org/D30373 ___ cfe-commits

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

arsenm added a comment. In https://reviews.llvm.org/D30551#691149, @b-sumner wrote: > mov_dpp should be under the VI+ comment Also should be made to use TARGET_BUILTIN and dependent on dpp feature https://reviews.llvm.org/D30551 ___ cfe-commits

[libcxx] r296840 - Work around test failure on 32 bit OS X

Author: ericwf Date: Thu Mar 2 17:18:40 2017 New Revision: 296840 URL: http://llvm.org/viewvc/llvm-project?rev=296840=rev Log: Work around test failure on 32 bit OS X Modified: libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_replace/size_size_T_size_size.pass.cpp

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

yaxunl added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398 + case AMDGPU::BI__builtin_amdgcn_ds_permute: +return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute); + case AMDGPU::BI__builtin_amdgcn_ds_bpermute: +return

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

arsenm added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398 + case AMDGPU::BI__builtin_amdgcn_ds_permute: +return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute); + case AMDGPU::BI__builtin_amdgcn_ds_bpermute: +return

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

b-sumner added a comment. mov_dpp should be under the VI+ comment https://reviews.llvm.org/D30551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

ddcc reopened this revision. ddcc added a comment. This revision is now accepted and ready to land. You're right about the failure being specific to Windows, I'll roll back to the original implementation in `lit.local.cfg` and just skip on Windows. Repository: rL LLVM

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

arsenm added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398 + case AMDGPU::BI__builtin_amdgcn_ds_permute: +return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute); + case AMDGPU::BI__builtin_amdgcn_ds_bpermute: +return

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:211 // Generate a report for this bug. - StringRef Desc = - describeUninitializedArgumentInCall(Call, IsFirstArgument); + std::string Desc = +

[libcxx] r296831 - remove max_size() extension from polymorphic_allocator. It is unneeded

Author: ericwf Date: Thu Mar 2 16:10:14 2017 New Revision: 296831 URL: http://llvm.org/viewvc/llvm-project?rev=296831=rev Log: remove max_size() extension from polymorphic_allocator. It is unneeded Removed:

[libcxx] r296830 - Fix libc++ test experimental/algorithms/alg.random.sample/sample.pass.cpp when ran in c++11 mode 32 bits

Author: mehdi_amini Date: Thu Mar 2 16:08:42 2017 New Revision: 296830 URL: http://llvm.org/viewvc/llvm-project?rev=296830=rev Log: Fix libc++ test experimental/algorithms/alg.random.sample/sample.pass.cpp when ran in c++11 mode 32 bits Modified:

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

dcoughlin added a comment. Thanks for sticking with this!! This looks good to me, although I would prefer if the definition of the AnalyzerTest class were moved to the bottom of the lit.cfg file. The other configuration and substitutions are far more important to the rest of clang -- people

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

yaxunl created this revision. Herald added subscribers: tpr, dstuttard, tony-tye, nhaehnle, wdng, kzhuravl. https://reviews.llvm.org/D30551 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn.cl Index:

[libcxxabi] r296823 - Work around GCC linking errors within libc++abi due to missing new/delete definitions

Author: ericwf Date: Thu Mar 2 15:55:17 2017 New Revision: 296823 URL: http://llvm.org/viewvc/llvm-project?rev=296823=rev Log: Work around GCC linking errors within libc++abi due to missing new/delete definitions Modified: libcxxabi/trunk/CMakeLists.txt Modified:

[libcxx] r296822 - Work around GCC linking errors within libc++abi due to missing new/delete definitions

Author: ericwf Date: Thu Mar 2 15:55:03 2017 New Revision: 296822 URL: http://llvm.org/viewvc/llvm-project?rev=296822=rev Log: Work around GCC linking errors within libc++abi due to missing new/delete definitions Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

JonasToth added a comment. please add the check in the release notes as well. https://reviews.llvm.org/D30547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r296813 - Fix test failures caused by new/delete calls getting optimized away

Author: ericwf Date: Thu Mar 2 15:16:35 2017 New Revision: 296813 URL: http://llvm.org/viewvc/llvm-project?rev=296813=rev Log: Fix test failures caused by new/delete calls getting optimized away Modified:

[PATCH] D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3

watsond added a comment. In https://reviews.llvm.org/D29858#690700, @alexfh wrote: > Do you need someone to commit the patch for you? I think so. This is my only LLVM patch, so I doubt I have permissions. Thanks in advance! https://reviews.llvm.org/D29858

[PATCH] D30015: Add arch-specific directory to search path

pirama updated this revision to Diff 90373. pirama added a comment. Add -rpath only when a runtime is included as a shared library. And, cleanup tests. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

JonasToth added a comment. added my thoughts. i like the check, seems really thought out :) Comment at: docs/clang-tidy/checks/misc-forwarding-reference-overload.rst:36 + +The check warns for constructors C1 and C2, because those can act like +described above. We suppress

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

leanil added inline comments. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:22 +// Check if the given type is related to std::enable_if. +AST_MATCHER(QualType, isEnableIf) { + auto checkTemplate = [](const TemplateSpecializationType *Spec) {

[PATCH] D30015: Add arch-specific directory to search path

pirama marked 2 inline comments as done. pirama added inline comments. Comment at: lib/Driver/Tools.cpp:289 + CmdArgs.push_back("-rpath"); + CmdArgs.push_back(Args.MakeArgString(CandidateRPath.c_str())); +} rnk wrote: > We shouldn't add rpath to

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

leanil created this revision. leanil added a project: clang-tools-extra. Herald added subscribers: JDevlieghere, mgorny. Perfect forwarding constructors are called instead of copy constructors if the forwarding reference provides a closer match (e.g. with non-const parameter). This can be

r296806 - Promote ConstantInitBuilder to be a public CodeGen API; it's

Author: rjmccall Date: Thu Mar 2 14:04:19 2017 New Revision: 296806 URL: http://llvm.org/viewvc/llvm-project?rev=296806=rev Log: Promote ConstantInitBuilder to be a public CodeGen API; it's a generally useful utility for other frontends. NFC. Added:

[PATCH] D30517: [libc++abi] Add option to enable definitions for the new/delete overloads.

EricWF added a comment. In https://reviews.llvm.org/D30517#690328, @mehdi_amini wrote: > LGTM. Comment at: CMakeLists.txt:416 +set(LIBCXXABI_HAS_UNDEFINED_SYMBOLS ((NOT LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS) +OR (LIBCXXABI_BUILD_EXTERNAL_THREAD_LIBRARY AND

[libcxx] r296802 - [libc++] Add option to disable new/delete overloads when libc++abi provides them.

Author: ericwf Date: Thu Mar 2 13:35:33 2017 New Revision: 296802 URL: http://llvm.org/viewvc/llvm-project?rev=296802=rev Log: [libc++] Add option to disable new/delete overloads when libc++abi provides them. Summary: Currently both libc++ and libc++abi provide definitions for operator

[libcxxabi] r296801 - [libc++abi] Add option to enable definitions for the new/delete overloads.

Author: ericwf Date: Thu Mar 2 13:34:35 2017 New Revision: 296801 URL: http://llvm.org/viewvc/llvm-project?rev=296801=rev Log: [libc++abi] Add option to enable definitions for the new/delete overloads. Summary: Currently both libc++ and libc++abi provide definitions for operator new/delete.

[libunwind] r296800 - Creating release candidate rc3 from release_400 branch

Author: hans Date: Thu Mar 2 13:31:35 2017 New Revision: 296800 URL: http://llvm.org/viewvc/llvm-project?rev=296800=rev Log: Creating release candidate rc3 from release_400 branch Added: libunwind/tags/RELEASE_400/rc3/ (props changed) - copied from r296799,

[libcxxabi] r296794 - Creating release candidate rc3 from release_400 branch

Author: hans Date: Thu Mar 2 13:31:16 2017 New Revision: 296794 URL: http://llvm.org/viewvc/llvm-project?rev=296794=rev Log: Creating release candidate rc3 from release_400 branch Added: libcxxabi/tags/RELEASE_400/rc3/ (props changed) - copied from r296793,

[libcxx] r296793 - Creating release candidate rc3 from release_400 branch

Author: hans Date: Thu Mar 2 13:31:13 2017 New Revision: 296793 URL: http://llvm.org/viewvc/llvm-project?rev=296793=rev Log: Creating release candidate rc3 from release_400 branch Added: libcxx/tags/RELEASE_400/rc3/ (props changed) - copied from r296792, libcxx/branches/release_40/

[libcxxabi] r296787 - [libc++abi] Update new/delete definitions to match libc++

Author: ericwf Date: Thu Mar 2 13:25:53 2017 New Revision: 296787 URL: http://llvm.org/viewvc/llvm-project?rev=296787=rev Log: [libc++abi] Update new/delete definitions to match libc++ Summary: Currently both libc++ and libc++abi provide definitions for new/delete. However libc++abi's

[PATCH] D30214: [Driver] Search for libc++ headers in ResourceDir

EricWF added a comment. In https://reviews.llvm.org/D30214#690774, @jroelofs wrote: > In https://reviews.llvm.org/D30214#690375, @Hahnfeld wrote: > > > In https://reviews.llvm.org/D30214#690010, @jroelofs wrote: > > > > > libc++ headers should not be installed in the resource dir. > > > > > >

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 90360. v.g.vassilev added a comment. Rebase + ping. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index: test/SemaCXX/warn-unused-filescoped.cpp

[PATCH] D26030: Add shebang.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r296781. Repository: rL LLVM https://reviews.llvm.org/D26030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r296781 - Add coding and shebang.

Author: vvassilev Date: Thu Mar 2 12:47:22 2017 New Revision: 296781 URL: http://llvm.org/viewvc/llvm-project?rev=296781=rev Log: Add coding and shebang. Reviewed by Artem Dergachev (D26030)! Modified: cfe/trunk/tools/scan-view/share/Reporter.py

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

arphaman added inline comments. Comment at: test/Misc/diag-template-diffing.cpp:27 // CHECK-ELIDE-NOTREE: no matching function for call to 'f' -// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from 'vector' to 'vector' for 1st argument +//

r296779 - Mark function as llvm dump method.

Author: vvassilev Date: Thu Mar 2 12:13:19 2017 New Revision: 296779 URL: http://llvm.org/viewvc/llvm-project?rev=296779=rev Log: Mark function as llvm dump method. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk/lib/Serialization/ASTReader.cpp URL:

r296776 - Document that code inlined into a nodebug function also won't get any

Author: adrian Date: Thu Mar 2 12:06:51 2017 New Revision: 296776 URL: http://llvm.org/viewvc/llvm-project?rev=296776=rev Log: Document that code inlined into a nodebug function also won't get any debug info. Suggested by Paul Robinson in feedback on r296488, thanks! Modified:

[PATCH] D30214: [Driver] Search for libc++ headers in ResourceDir

jroelofs added a comment. In https://reviews.llvm.org/D30214#690375, @Hahnfeld wrote: > In https://reviews.llvm.org/D30214#690010, @jroelofs wrote: > > > libc++ headers should not be installed in the resource dir. > > > They are currently not by default. But with https://reviews.llvm.org/D30015

r296769 - Serialization: use the PCH chain to check PCH mode

Author: compnerd Date: Thu Mar 2 11:37:11 2017 New Revision: 296769 URL: http://llvm.org/viewvc/llvm-project?rev=296769=rev Log: Serialization: use the PCH chain to check PCH mode When we are deciding whether we are creating a PCH or a module, we would check if the ModuleMgr had any elements to

[PATCH] D30514: [libc++abi] Update new/delete definitions to match libc++

mehdi_amini added a comment. In https://reviews.llvm.org/D30514#690702, @jroelofs wrote: > In https://reviews.llvm.org/D30514#690318, @mehdi_amini wrote: > > > LGTM. > > > > (It seems that having libc++ and libc++abi in the same repo would help > > sharing code like this) > > > I think it would

[PATCH] D30015: Add arch-specific directory to search path

rnk added inline comments. Comment at: include/clang/Driver/ToolChain.h:305 + // as OpenMP) to find arch-specific libraries. + const std::string getArchSpecificLibPath() const; + Why const qualify the std::string? Comment at:

[PATCH] D30538: Add documentation for -fno-strict-aliasing

dberlin added a comment. In https://reviews.llvm.org/D30538#690699, @hans wrote: > +1 for documenting this, but I have to leave it to the language lawyers for > how to fomulate it. > > > Enables/disables the strict aliasing assumption, which assumes that objects > > of different types do not

Re: r296656 - [PCH] Avoid VarDecl emission attempt if no owning module avaiable

Merged to 4.0 in r296762. On Wed, Mar 1, 2017 at 11:18 AM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Wed Mar 1 13:18:42 2017 > New Revision: 296656 > > URL: http://llvm.org/viewvc/llvm-project?rev=296656=rev > Log: > [PCH] Avoid VarDecl

[PATCH] D30514: [libc++abi] Update new/delete definitions to match libc++

jroelofs added a comment. In https://reviews.llvm.org/D30514#690318, @mehdi_amini wrote: > LGTM. > > (It seems that having libc++ and libc++abi in the same repo would help > sharing code like this) I think it would be a step backwards in terms of opening things up for layering violations. We

[PATCH] D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3

alexfh added a comment. Do you need someone to commit the patch for you? https://reviews.llvm.org/D29858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30538: Add documentation for -fno-strict-aliasing

hans added a comment. +1 for documenting this, but I have to leave it to the language lawyers for how to fomulate it. > Enables/disables the strict aliasing assumption, which assumes that objects > of different types do not share the same location in memory. I think it needs to say

Re: [PATCH] D30538: Add documentation for -fno-strict-aliasing

On Thu, Mar 02, 2017 at 04:20:47PM +, Simon Byrne via Phabricator via cfe-commits wrote: > simonbyrne created this revision. > > This is probably good to document, as the behaviour of `-fstrict-aliasing` > differs from gcc in a quite important way (see >

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. > What problem is this addressing, though? Have we frequently changed > formatting in a way that has negatively impacted Mozilla code? We are integrating more clang-format into gecko processes. About the reason, I believed I explained them in the comment above

[PATCH] D30538: Add documentation for -fno-strict-aliasing

simonbyrne created this revision. This is probably good to document, as the behaviour of `-fstrict-aliasing` differs from gcc in a quite important way (see https://bugs.llvm.org//show_bug.cgi?id=31928) . https://reviews.llvm.org/D30538 Files: docs/UsersManual.rst Index:

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

djasper added inline comments. Comment at: include/clang/Format/Format.h:309 + /// inheritance. + bool BreakInhertianceBeforeColonAndComma; + Hm. I am still not sure about this flag and it's name. Fundamentally, this is currently controlling two different

[clang-tools-extra] r296755 - [clang-tidy] google-readability-casting: detect redundant casts with top-level const

Author: alexfh Date: Thu Mar 2 09:47:28 2017 New Revision: 296755 URL: http://llvm.org/viewvc/llvm-project?rev=296755=rev Log: [clang-tidy] google-readability-casting: detect redundant casts with top-level const Modified: clang-tools-extra/trunk/clang-tidy/google/AvoidCStyleCastsCheck.cpp

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

djasper added a comment. Please don't add this as is. I don't usually run the file-based tests in my development workflow and suspect that I might be breaking this a lot. If you want something like this, please add it as unittest(s) in unittests/Format/... (either in a new file or in an

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

dcoughlin added a comment. In https://reviews.llvm.org/D30373#689613, @ddcc wrote: > With the first method, I'm not sure how to refer to the `AnalyzerTest` class > defined in `lit.cfg` from `lit.local.cfg`. It doesn't seem to be in scope, so > unless I store an instantiation in the `config`

[clang-tools-extra] r296753 - [clang-tidy] Fix a few more issues in google-readability-casting

Author: alexfh Date: Thu Mar 2 09:27:34 2017 New Revision: 296753 URL: http://llvm.org/viewvc/llvm-project?rev=296753=rev Log: [clang-tidy] Fix a few more issues in google-readability-casting * suggest static_cast instead of reinterpret_cast for casts from void* * top-level const doesn't need a

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

redm123 added a comment. Any idea how to continue with that? Should I add another reviewer? Whom? https://reviews.llvm.org/D29944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r296749 - Don't write to LLVMStyle.JavaScriptQuotes twice. No behavior change.

Author: nico Date: Thu Mar 2 08:51:54 2017 New Revision: 296749 URL: http://llvm.org/viewvc/llvm-project?rev=296749=rev Log: Don't write to LLVMStyle.JavaScriptQuotes twice. No behavior change. Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL:

[PATCH] D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3

etienneb accepted this revision. etienneb added a comment. thx for the improvement lgtm https://reviews.llvm.org/D29858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 90331. sylvestre.ledru added a comment. With the rst generation https://reviews.llvm.org/D30532 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: docs/ClangFormatStyleOptions.rst

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:218 + +#define A \ +int ; \ klimek wrote: > Do we really align these 3 spaces out? nope, bad copy and paste it seems. Sorry Comment at:

[PATCH] D30493: [change-namespace] avoid adding leading '::' when possible.

hokein added a comment. I like removing the leading "::" when possible. :) Comment at: change-namespace/ChangeNamespace.cpp:291 + assert(!SymbolSplitted.empty()); + SymbolSplitted.pop_back(); + Is this needed? Looks like you are removing the name of the

[PATCH] D30532: Add examples to clang-format configuration

klimek added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:218 + +#define A \ +int ; \ Do we really align these 3 spaces out? Comment at: docs/ClangFormatStyleOptions.rst:447 + SomeClass::Constructor() +

[PATCH] D30534: [analyzer] When creating a temporary object copy, properly copy the value into it.

NoQ created this revision. The test case provided demonstrates a regression due to my earlier attempt to fix temporaries in https://reviews.llvm.org/D26839. Neither before nor after, we did not properly copy the symbolic rvalue of the object to the newly created memory region; in different

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru added a comment. If you think it makes sense, I will do that for the rest of the options https://reviews.llvm.org/D30532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru created this revision. https://reviews.llvm.org/D30532 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: docs/ClangFormatStyleOptions.rst === --- docs/ClangFormatStyleOptions.rst +++

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. This isn't about testing individual issues. This is to make sure that the Mozilla coding style remains consistent and we don't regress specific coding style. I found that easy and simple to have a single file to check for the specificities. After

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

krasimir added a comment. My input: Maybe this CL is trying to solve a non-existing problem, as separate issues may be tracked as bugs, fixed, and unittests added for each of them as appropriate, as happens in https://reviews.llvm.org/D30487, which adds an option to break multiple inheritance

[PATCH] D30492: [clang-format] Allow all but the first string literal in a sequence to be put on a newline

djasper added a comment. As discussed offline, I think this solves the wrong problem. My guess is that breakProtrudingToken checks State.Stack.back().NoLinebreak, but I forget to make it also check NoLinebreakInOperand. https://reviews.llvm.org/D30492

[PATCH] D30516: [libc++] Add option to disable new/delete overloads when libc++abi provides them.

rmaprath added a comment. Thanks for these patches! We had some downstream hacks to workaround this, never got around to sort it out. Now it looks much better. https://reviews.llvm.org/D30516 ___ cfe-commits mailing list

[PATCH] D30492: [clang-format] Allow all but the first string literal in a sequence to be put on a newline

krasimir updated this revision to Diff 90312. krasimir added a comment. - Reformat newly added chunk of code https://reviews.llvm.org/D30492 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp unittests/Format/FormatTestObjC.cpp Index:

[PATCH] D30492: [clang-format] Allow all but the first string literal in a sequence to be put on a newline

krasimir updated this revision to Diff 90310. krasimir added a comment. - Remove DEBUG statement https://reviews.llvm.org/D30492 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D30492: [clang-format] Allow all but the first string literal in a sequence to be put on a newline

krasimir updated this revision to Diff 90309. krasimir added a comment. - Add missing test cases for commas and handling for Objective-C string literals https://reviews.llvm.org/D30492 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp

[clang-tools-extra] r296737 - [clangd] Fix a potential race by copying the FixIts out of ASTManager before releasing the lock.

Author: d0k Date: Thu Mar 2 04:25:00 2017 New Revision: 296737 URL: http://llvm.org/viewvc/llvm-project?rev=296737=rev Log: [clangd] Fix a potential race by copying the FixIts out of ASTManager before releasing the lock. Also document the locking semantics a bit better. Modified:

[PATCH] D30528: [clang-format] Use number of unwrapped lines for short namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rL296736: [clang-format] Use number of unwrapped lines for short namespace (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D30528?vs=90299=90302#toc Repository: rL LLVM

r296736 - [clang-format] Use number of unwrapped lines for short namespace

Author: krasimir Date: Thu Mar 2 03:54:44 2017 New Revision: 296736 URL: http://llvm.org/viewvc/llvm-project?rev=296736=rev Log: [clang-format] Use number of unwrapped lines for short namespace Summary: This patch makes the namespace comment fixer use the number of unwrapped lines that a

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

Abpostelnicu updated this revision to Diff 90300. Abpostelnicu marked an inline comment as done. Abpostelnicu added a comment. Updated patch with the proposed modifications. Repository: rL LLVM https://reviews.llvm.org/D30487 Files: docs/ClangFormatStyleOptions.rst

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

Abpostelnicu marked 9 inline comments as done. Abpostelnicu added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2398 +// Determine if the next token from the closing scope is an inheritance token +static bool hasMultipleInheritance(const FormatToken ) {

[PATCH] D30528: [clang-format] Use number of unwrapped lines for short namespace

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Please include the reasoning in the patch description, i.e. that otherwise clang-format might need to runs to add all the namespace comments. https://reviews.llvm.org/D30528

[PATCH] D30214: [Driver] Search for libc++ headers in ResourceDir

Hahnfeld updated this revision to Diff 90296. Hahnfeld edited the summary of this revision. Hahnfeld added a comment. Adapt and add tests. https://reviews.llvm.org/D30214 Files: lib/Driver/ToolChains.cpp test/Driver/Inputs/resource_dir_libcxx/include/c++/v1/.keep

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

Hahnfeld updated this revision to Diff 90295. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Reword comment https://reviews.llvm.org/D30087 Files: lib/Driver/Tools.cpp test/Driver/fopenmp.c Index: test/Driver/fopenmp.c

[PATCH] D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG unless Etienne has any concerns. https://reviews.llvm.org/D29858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r296734 - [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker

Author: alexfh Date: Thu Mar 2 02:28:55 2017 New Revision: 296734 URL: http://llvm.org/viewvc/llvm-project?rev=296734=rev Log: [clang-tidy] Function names configurable for cppcoreguidelines-nomalloc - checker Summary: Hello everybody, this is an incremental patch for the NoMalloc-Checker I