[PATCH] D30773: Make git-clang-format python 3 compatible

EricWF added a comment. In https://reviews.llvm.org/D30773#696349, @mgorny wrote: > In https://reviews.llvm.org/D30773#696301, @EricWF wrote: > > > There seem to be a couple cases where it's non-trivial to convert the > > output from `bytes` to `str`. I'll look into this further and update. > >

[PATCH] D30773: Make git-clang-format python 3 compatible

mgorny added a comment. In https://reviews.llvm.org/D30773#696301, @EricWF wrote: > There seem to be a couple cases where it's non-trivial to convert the output > from `bytes` to `str`. I'll look into this further and update. Generally bytes<->str conversion should be done using `.decode()`

[PATCH] D30775: [coroutines] Refactor SuspendExpr to create just one OpaqueValue (almost NFC)

GorNishanov created this revision. Herald added a subscriber: mehdi_amini. Create only one OpaqueValue for await_ready/await_suspend/await_resume. Store OpaqueValue used in the CoroutineSuspendExpr node, so that CodeGen does not have to hunt looking for it. https://reviews.llvm.org/D30775

r297363 - Remove a useless subsitution in doxygen2rst which was incorrectly replacing * by \*

Author: sylvestre Date: Thu Mar 9 00:41:08 2017 New Revision: 297363 URL: http://llvm.org/viewvc/llvm-project?rev=297363=rev Log: Remove a useless subsitution in doxygen2rst which was incorrectly replacing * by \* Summary: For example, "int\* a;" is displayed instead of "int* a;" Reviewers:

r297358 - [coroutines] Fix assertion in DependentCoawaitExpr when the argument is non-dependent.

Author: ericwf Date: Wed Mar 8 23:01:31 2017 New Revision: 297358 URL: http://llvm.org/viewvc/llvm-project?rev=297358=rev Log: [coroutines] Fix assertion in DependentCoawaitExpr when the argument is non-dependent. Summary: A `co_await arg` expression has a dependent type whenever the promise

[PATCH] D30772: [coroutines] Fix assertion in DependentCoawaitExpr when the argument is non-dependent.

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D30772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30773: Make git-clang-format python 3 compatible

EricWF planned changes to this revision. EricWF added a comment. There seem to be a couple cases where it's non-trivial to convert the output from `bytes` to `str`. I'll look into this further and update. https://reviews.llvm.org/D30773 ___

[PATCH] D30773: Make git-clang-format python 3 compatible

EricWF created this revision. This patch attempts to make `git-clang-format` both python2 and python3 compatible. Currently it only works in python2. https://reviews.llvm.org/D30773 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format

[PATCH] D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:116 + + if (auto Dtor = Result.Nodes.getNodeAs("dtor")) { +StoreMember(Dtor->isDefaulted() `const auto *Dtor` Comment at:

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:31 + ->getName() + .find("enable_if") !=

[PATCH] D30772: [coroutines] Fix assertion in DependentCoawaitExpr when the argument is non-dependent.

EricWF created this revision. Herald added a subscriber: mehdi_amini. A `co_await arg` expression has a dependent type whenever the promise type is still dependent, even if the argument to co_await is not. This is because we cannot attempt the `await_transform()` until after we know the promise

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov closed this revision. GorNishanov added a comment. Commited as: https://reviews.llvm.org/rL297356 https://reviews.llvm.org/D26316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r297356 - [coroutines] Build and pass coroutine_handle to await_suspend

Author: gornishanov Date: Wed Mar 8 21:09:43 2017 New Revision: 297356 URL: http://llvm.org/viewvc/llvm-project?rev=297356=rev Log: [coroutines] Build and pass coroutine_handle to await_suspend Summary: This patch adds passing a coroutine_handle object to await_suspend calls. It builds the

[PATCH] D30769: [coroutines] Build and pass coroutine_handle to await_suspend

This revision was automatically updated to reflect the committed changes. Closed by commit rL297356: [coroutines] Build and pass coroutine_handle to await_suspend (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D30769?vs=91121=91122#toc Repository: rL LLVM

[PATCH] D30769: [coroutines] Build and pass coroutine_handle to await_suspend

GorNishanov updated this revision to Diff 91121. GorNishanov added a comment. tweak SemaCXX/coreturn.cpp test to actually pass https://reviews.llvm.org/D30769 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp lib/Sema/SemaExprMember.cpp

[PATCH] D30769: [coroutines] Build and pass coroutine_handle to await_suspend

GorNishanov created this revision. Herald added subscribers: EricWF, mehdi_amini. This patch adds passing a coroutine_handle object to await_suspend calls. It builds the coroutine_handle using coroutine_handle::from_address(__builtin_coro_frame()). (a revision of https://reviews.llvm.org/D26316

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov updated this revision to Diff 91119. GorNishanov added a comment. preparing to land https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp lib/Sema/SemaExprMember.cpp test/CodeGenCoroutines/coro-alloc.cpp

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

EricWF closed this revision. EricWF added a comment. Committed in r297355. https://reviews.llvm.org/D30764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r297355 - Disable unsigned integer sanitizer for basic_string::replace(). Patch from tomche...@google.com

Author: ericwf Date: Wed Mar 8 19:54:13 2017 New Revision: 297355 URL: http://llvm.org/viewvc/llvm-project?rev=297355=rev Log: Disable unsigned integer sanitizer for basic_string::replace(). Patch from tomche...@google.com basic_string::replace() has the below line __sz += __n2 - __n1; which

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov updated this revision to Diff 91117. GorNishanov added a comment. - Addressed nits - Improved error messages even further - Merge on top of the trunk Preparing to land https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp

[PATCH] D27753: [analyzer] alpha.security.DirtyScalar Checker

zaks.anna added a comment. > All this leads to the need of several types of taintednesses (string > taintedness, array taintedness, general bound check taintedness) because the > cleansing can only take down one type of taintedness at a time. That would be > the only way for a checker to be

r297351 - Add a cmake cache file for a stage-2 build with ThinLTO

Author: mehdi_amini Date: Wed Mar 8 19:18:31 2017 New Revision: 297351 URL: http://llvm.org/viewvc/llvm-project?rev=297351=rev Log: Add a cmake cache file for a stage-2 build with ThinLTO This is intended to be targetted by a Green Dragon stage-2 bot I'm bringing up currently. WIP. Added:

[PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

ributzka created this revision. The VFS directory iterator and recursive directory iterator behave differently from the LLVM counterparts. Once the VFS iterators hit a broken symlink they immediately abort. The LLVM counterparts allow to recover from this issue by clearing the error code and

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

tomcherry added a comment. I don't have commit access, so please commit for me. Thank you https://reviews.llvm.org/D30764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r297349 - Fix handling of -fmodule-map-file=X where X has no directory component.

Author: rsmith Date: Wed Mar 8 18:58:22 2017 New Revision: 297349 URL: http://llvm.org/viewvc/llvm-project?rev=297349=rev Log: Fix handling of -fmodule-map-file=X where X has no directory component. Added: cfe/trunk/test/Modules/module_map_cwd.c Modified:

Re: r297298 - [ubsan] Detect UB loads from bitfields

Thank you, that was quick! On Wed, Mar 8, 2017 at 4:31 PM, Vedant Kumar wrote: > Reverted in r297331. > > vedant > >> On Mar 8, 2017, at 4:25 PM, Evgenii Stepanov >> wrote: >> >> This is crashing ubsan bootstrap: >> >>

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. @Tom Do you have commit acces or would you like me to commit this for you? https://reviews.llvm.org/D30764 ___ cfe-commits mailing list

[libunwind] r297347 - Creating release candidate final from release_400 branch

Author: hans Date: Wed Mar 8 18:40:17 2017 New Revision: 297347 URL: http://llvm.org/viewvc/llvm-project?rev=297347=rev Log: Creating release candidate final from release_400 branch Added: libunwind/tags/RELEASE_400/final/ (props changed) - copied from r297346,

[libcxx] r297340 - Creating release candidate final from release_400 branch

Author: hans Date: Wed Mar 8 18:39:56 2017 New Revision: 297340 URL: http://llvm.org/viewvc/llvm-project?rev=297340=rev Log: Creating release candidate final from release_400 branch Added: libcxx/tags/RELEASE_400/final/ (props changed) - copied from r297339,

[libcxxabi] r297341 - Creating release candidate final from release_400 branch

Author: hans Date: Wed Mar 8 18:39:59 2017 New Revision: 297341 URL: http://llvm.org/viewvc/llvm-project?rev=297341=rev Log: Creating release candidate final from release_400 branch Added: libcxxabi/tags/RELEASE_400/final/ (props changed) - copied from r297340,

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

tomcherry updated this revision to Diff 9. tomcherry added a comment. Moved comments to an appropriate line https://reviews.llvm.org/D30764 Files: include/string Index: include/string === --- include/string +++

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

EricWF added a comment. Side note: There are plenty of tests in the test-suite that trigger this overflow, so no new tests are needed. When I have time I'm going to enable `-fsanitize=unsigned-integer-overflow` once I have time to clean up any existing failures.

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

EricWF added inline comments. Comment at: include/string:2559 // replace +// __sz += __n2 - __n1; in the two functions below can cause unsigned integer overflow, +// but this is a safe operation, so we disable the check. Please put this comment inside one of

Re: r297298 - [ubsan] Detect UB loads from bitfields

Reverted in r297331. vedant > On Mar 8, 2017, at 4:25 PM, Evgenii Stepanov > wrote: > > This is crashing ubsan bootstrap: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/962/steps/build%20clang%2Fubsan/logs/stdio > > clang-5.0: >

r297331 - Revert "[ubsan] Detect UB loads from bitfields"

Author: vedantk Date: Wed Mar 8 18:18:53 2017 New Revision: 297331 URL: http://llvm.org/viewvc/llvm-project?rev=297331=rev Log: Revert "[ubsan] Detect UB loads from bitfields" This reverts commit r297298. It breaks the self-host on this bot:

[libcxx] r297330 - [libc++] Avoid double defining macro on Windows

Author: smeenai Date: Wed Mar 8 18:18:00 2017 New Revision: 297330 URL: http://llvm.org/viewvc/llvm-project?rev=297330=rev Log: [libc++] Avoid double defining macro on Windows Put proper guards around _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS. No functional change on non-Windows.

r297329 - Driver/ToolChains: Remove extra semicolons. NFC

Author: kzhuravl Date: Wed Mar 8 18:14:57 2017 New Revision: 297329 URL: http://llvm.org/viewvc/llvm-project?rev=297329=rev Log: Driver/ToolChains: Remove extra semicolons. NFC Modified: cfe/trunk/lib/Driver/ToolChains/Haiku.cpp cfe/trunk/lib/Driver/ToolChains/TCE.cpp

Re: r297298 - [ubsan] Detect UB loads from bitfields

This is crashing ubsan bootstrap: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/962/steps/build%20clang%2Fubsan/logs/stdio clang-5.0: /mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/IR/Instructions.h:1110: void

[PATCH] D30762: [ubsan] Add a nullability sanitizer

vsk updated this revision to Diff 91100. vsk added reviewers: aprantl, arphaman. vsk added a comment. - Improve the wording of the docs. - Drop a weak test from 'ubsan-null-retval.m'. https://reviews.llvm.org/D30762 Files: docs/UndefinedBehaviorSanitizer.rst

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

This revision was automatically updated to reflect the committed changes. Closed by commit rL297323: [analyzer] Teach the MallocChecker about about Glib API (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D28348?vs=89825=91101#toc Repository: rL LLVM

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

This revision was automatically updated to reflect the committed changes. Closed by commit rL297326: [analyzer] Extend taint propagation and checking to support LazyCompoundVal (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D28445?vs=90868=91104#toc Repository: rL

[PATCH] D30589: [ExprInspectionChecker] Improve usability for C

This revision was automatically updated to reflect the committed changes. Closed by commit rL297325: [analyzer] Improve usability of ExprInspectionChecker (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D30589?vs=90527=91103#toc Repository: rL LLVM

[PATCH] D30289: [Analyzer] Add bug visitor for taint checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL297324: [analyzer] Add bug visitor for taint checker. (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D30289?vs=89497=91102#toc Repository: rL LLVM

r297326 - [analyzer] Extend taint propagation and checking to support LazyCompoundVal

Author: zaks Date: Wed Mar 8 18:01:16 2017 New Revision: 297326 URL: http://llvm.org/viewvc/llvm-project?rev=297326=rev Log: [analyzer] Extend taint propagation and checking to support LazyCompoundVal A patch by Vlad Tsyrklevich! Differential Revision: https://reviews.llvm.org/D28445

r297325 - [analyzer] Improve usability of ExprInspectionChecker

Author: zaks Date: Wed Mar 8 18:01:10 2017 New Revision: 297325 URL: http://llvm.org/viewvc/llvm-project?rev=297325=rev Log: [analyzer] Improve usability of ExprInspectionChecker Some of the magic functions take arguments of arbitrary type. However, for semantic correctness, the compiler still

r297323 - [analyzer] Teach the MallocChecker about about Glib API

Author: zaks Date: Wed Mar 8 18:01:01 2017 New Revision: 297323 URL: http://llvm.org/viewvc/llvm-project?rev=297323=rev Log: [analyzer] Teach the MallocChecker about about Glib API A patch by Leslie Zhai! Differential Revision: https://reviews.llvm.org/D28348 Added:

r297324 - [analyzer] Add bug visitor for taint checker.

Author: zaks Date: Wed Mar 8 18:01:07 2017 New Revision: 297324 URL: http://llvm.org/viewvc/llvm-project?rev=297324=rev Log: [analyzer] Add bug visitor for taint checker. Add a bug visitor to the taint checker to make it easy to distinguish where the tainted value originated. This is especially

[PATCH] D30762: [ubsan] Add a nullability sanitizer

aprantl added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:98 + pointer as a function parameter which is annotated with ``_Nonnull``, + or assigning null to a lvalue marked ``_Nonnull``. You can enable + just the return value check with

r297322 - Defensively ensure that GetExternalDeclStmt protects itself from nested deserialization

Author: dblaikie Date: Wed Mar 8 17:57:08 2017 New Revision: 297322 URL: http://llvm.org/viewvc/llvm-project?rev=297322=rev Log: Defensively ensure that GetExternalDeclStmt protects itself from nested deserialization Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified:

r297321 - [DebugInfo] Add address space when creating DIDerivedTypes

Author: kzhuravl Date: Wed Mar 8 17:56:48 2017 New Revision: 297321 URL: http://llvm.org/viewvc/llvm-project?rev=297321=rev Log: [DebugInfo] Add address space when creating DIDerivedTypes Differential Revision: https://reviews.llvm.org/D29671 Added:

[PATCH] D30766: Add support for attribute "enum_extensibility"

ahatanak created this revision. This patch adds support for a new attribute that will be used to distinguish between extensible and inextensible enums. The attribute was discussed on cfe-dev a few weeks ago and I've made a few modifications to the original proposal based on the feedback I

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

srhines added a comment. You probably want to remove the Change-Id section above in your description (or at least drop that when you finally submit this to libc++). https://reviews.llvm.org/D30764 ___ cfe-commits mailing list

[PATCH] D30765: Reexport operator new / delete from libc++abi

mehdi_amini added a comment. Note: this is already shipping like this for ~2 years in our OSes. https://reviews.llvm.org/D30765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30765: Reexport operator new / delete from libc++abi

mehdi_amini created this revision. Both libc++ and libc++abi export a weak definition of operator new/delete. On Darwin, this can often cause dirty __DATA in the shared cache when having to switch from one to the other. Instead, libc++ should reexport libc++abi's implementation of these symbols.

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF added a comment. @GorNishanov You forgot to update `test/SemaCXX/coreturn.cpp`. https://reviews.llvm.org/D26316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30762: [ubsan] Add a nullability sanitizer

vsk created this revision. Teach UBSan how to detect violations of the _Nonnull annotation when passing arguments to callees, in assignments, and in return stmts. Because _Nonnull does not affect IRGen, the new checks are disabled by default. The new driver flags are:

r297316 - Take into account C++17's noexcept function types during merging -- it should

Author: rsmith Date: Wed Mar 8 17:00:26 2017 New Revision: 297316 URL: http://llvm.org/viewvc/llvm-project?rev=297316=rev Log: Take into account C++17's noexcept function types during merging -- it should be possible to merge a declaration with an unresolved function type against one with a

[PATCH] D30740: Remove a useless subsitution in doxygen2rst which was incorrectly replacing * by \*

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D30740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r297312 - Driver/ToolChains: Mips -> MipsLinux

Author: kzhuravl Date: Wed Mar 8 16:36:04 2017 New Revision: 297312 URL: http://llvm.org/viewvc/llvm-project?rev=297312=rev Log: Driver/ToolChains: Mips -> MipsLinux - Mips is architecture, not a toolchain - Might help eliminate the confusion in the future by not having header files with

[PATCH] D30753: Driver/ToolChains: Mips -> MipsLinux

This revision was automatically updated to reflect the committed changes. Closed by commit rL297312: Driver/ToolChains: Mips -> MipsLinux (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D30753?vs=91060=91078#toc Repository: rL LLVM https://reviews.llvm.org/D30753

[clang-tools-extra] r297311 - [clang-tidy] readability-function-size: remove default param count threshold

Author: alexfh Date: Wed Mar 8 16:19:55 2017 New Revision: 297311 URL: http://llvm.org/viewvc/llvm-project?rev=297311=rev Log: [clang-tidy] readability-function-size: remove default param count threshold Modified: clang-tools-extra/trunk/clang-tidy/readability/FunctionSizeCheck.cpp

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. On second thought if @rsmith already reviewed most of this offline then I feel comfortable giving it the thumbs up. https://reviews.llvm.org/D26316

[PATCH] D22862: [analyzer] Fix for PR15623: eliminate unwanted ProgramState checker data propagation.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thi has been committed in r290505. https://reviews.llvm.org/D22862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF added a comment. This LGTM, but I don't know enough Clang to be 100% on it. Perhaps somebody else could give it a quick second look? Comment at: lib/Sema/SemaCoroutine.cpp:157 + if (S.RequireCompleteType(Loc, CoroHandleType, +

r297308 - [scan-build-py] move argument parsing into separate module

Author: rizsotto Date: Wed Mar 8 15:22:32 2017 New Revision: 297308 URL: http://llvm.org/viewvc/llvm-project?rev=297308=rev Log: [scan-build-py] move argument parsing into separate module Forgot to add the new module. Added: cfe/trunk/tools/scan-build-py/libscanbuild/arguments.py Added:

r297307 - [scan-build-py] move argument parsing into separate module

Author: rizsotto Date: Wed Mar 8 15:18:51 2017 New Revision: 297307 URL: http://llvm.org/viewvc/llvm-project?rev=297307=rev Log: [scan-build-py] move argument parsing into separate module Differential Revision: https://reviews.llvm.org/D30601 Modified:

[PATCH] D25402: [Driver] Pass -lunwind along with compiler-rt when necessary on Linux

mgorny added a comment. @compnerd, I presume that the option would do nothing when using `-rtlib=libgcc`, correct? Or do we support combining libgcc with another unwinder? https://reviews.llvm.org/D25402 ___ cfe-commits mailing list

[PATCH] D30753: Driver/ToolChains: Mips -> MipsLinux

kzhuravl created this revision. Herald added subscribers: mgorny, wdng, sdardis. - Mips is architecture, not a toolchain - Might help eliminate the confusion in the future by not having header files with the same name https://reviews.llvm.org/D30753 Files: lib/Driver/CMakeLists.txt

[libcxx] r297306 - Fix PR32183 - Wrap GCC exception implementation in missing namespace std

Author: ericwf Date: Wed Mar 8 14:06:01 2017 New Revision: 297306 URL: http://llvm.org/viewvc/llvm-project?rev=297306=rev Log: Fix PR32183 - Wrap GCC exception implementation in missing namespace std Modified: libcxx/trunk/src/support/runtime/exception_glibcxx.ipp

[PATCH] D30551: [AMDGPU] Add builtin functions readlane ds_permute mov_dpp

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30748: [Lexer] Finding beginning of token with escaped new line

idlecode created this revision. Lexer::GetBeginningOfToken produced invalid location when backtracking across escaped new lines. This fixes PR26228 https://reviews.llvm.org/D30748 Files: lib/Lex/Lexer.cpp unittests/Lex/LexerTest.cpp Index: unittests/Lex/LexerTest.cpp

[PATCH] D30650: [clang-tidy] misc-use-after-move: Fix failing assertion

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D30650#695350, @klimek wrote: > In https://reviews.llvm.org/D30650#693165, @Eugene.Zelenko wrote: > > > I think we should refactor this check as part of Static Analyzer, since > > it's path-sensitive. > > > Are you saying it should be

[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

sammccall added a comment. Thanks for the comments! Comment at: include-fixer/SymbolIndexManager.cpp:106 // Match the identifier name without qualifier. - if (Symbol.getName() == Names.back()) { -bool IsMatched = true; hokein wrote: > Just

[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

sammccall updated this revision to Diff 91042. sammccall marked 4 inline comments as done. sammccall added a comment. Address review comments. https://reviews.llvm.org/D30720 Files: include-fixer/CMakeLists.txt include-fixer/FuzzySymbolIndex.cpp include-fixer/FuzzySymbolIndex.h

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

This revision was automatically updated to reflect the committed changes. Closed by commit rL297298: [ubsan] Detect UB loads from bitfields (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D30423?vs=90869=91041#toc Repository: rL LLVM https://reviews.llvm.org/D30423

r297298 - [ubsan] Detect UB loads from bitfields

Author: vedantk Date: Wed Mar 8 11:38:57 2017 New Revision: 297298 URL: http://llvm.org/viewvc/llvm-project?rev=297298=rev Log: [ubsan] Detect UB loads from bitfields It's possible to load out-of-range values from bitfields backed by a boolean or an enum. Check for UB loads from bitfields.

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli updated this revision to Diff 91035. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Changes: - fixed formatting; - added two tests that were missing. https://reviews.llvm.org/D30739 Files: lib/Basic/Targets.cpp lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

vsk added a comment. In https://reviews.llvm.org/D30423#695608, @filcab wrote: > LGTM since my issue is only an issue on ObjC platforms and it seems those are > the semantics it should have there. Thanks for the review. > P.S: If it documented that the only possible values for BOOL are YES

[PATCH] D30685: [include-fixer] Remove line number from Symbol identity

bkramer accepted this revision. bkramer added a comment. lg https://reviews.llvm.org/D30685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

filcab added a comment. LGTM since my issue is only an issue on ObjC platforms and it seems those are the semantics it should have there. Comment at: test/CodeGenObjC/ubsan-bool.m:26 + // OBJC: [[ICMP:%.*]] = icmp ule i8 [[ASHR]], 1, !nosanitize + // OBJC: call void

[PATCH] D30729: [ubsan] Skip range checks for width-limited values

vsk updated this revision to Diff 91030. vsk added a comment. - Make check-not's a bit stricter per Filipe's comment. - Add a negative test for fixed enums. https://reviews.llvm.org/D30729 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/ubsan-bitfields.cpp

[PATCH] D30729: [ubsan] Skip range checks for width-limited values

vsk added a comment. In https://reviews.llvm.org/D30729#695463, @arphaman wrote: > You should also add a test for `enum E : unsigned`. Ubsan doesn't try to infer the range of enums with a fixed, underlying type. I'll add a test case to make sure we don't insert a check.

[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

hokein added inline comments. Comment at: include-fixer/FuzzySymbolIndex.cpp:138 +return llvm::errorCodeToError(Buffer.getError()); + return std::unique_ptr(new MemSymbolIndex( + find_all_symbols::ReadSymbolInfosFromYAML(Buffer.get()->getBuffer(;

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

vsk added inline comments. Comment at: test/CodeGenObjC/ubsan-bool.m:26 + // OBJC: [[ICMP:%.*]] = icmp ule i8 [[ASHR]], 1, !nosanitize + // OBJC: call void @__ubsan_handle_load_invalid_value + filcab wrote: > jroelofs wrote: > > vsk wrote: > > > jroelofs

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fhahn added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6664 + + static void + emitTargetDeclareSimdFunction(const FunctionDecl *FD, llvm::Function *Fn, Shouldn't this indentation be on the same level as namespace{}?

Re: [libunwind] r297174 - Improve readability and correctness of the OS specific libunwind bits.

@Renato: What's your take on Ed's idea? We use phab for all sorts of reviews, but it should be possible to figure out which repository a review is intended to land on and add cfe-commits or llvm-commits appropriately. Although, for throw-away reviews, it might generate too much spam. Cheers, /

[PATCH] D30685: [include-fixer] Remove line number from Symbol identity

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM once Ben has no other comments. Be careful before submitting it (this patch also changes the interface). https://reviews.llvm.org/D30685

[PATCH] D30740: Remove a useless subsitution in doxygen2rst which was incorrectly replacing * by \*

sylvestre.ledru created this revision. For example, "int\* a;" is displayed instead of "int* a;" https://reviews.llvm.org/D30740 Files: docs/ClangFormatStyleOptions.rst docs/tools/dump_format_style.py Index: docs/ClangFormatStyleOptions.rst

[PATCH] D30729: [ubsan] Skip range checks for width-limited values

filcab added inline comments. Comment at: test/CodeGenCXX/ubsan-bitfields.cpp:39 + // CHECK-NOT: !nosanitize + return s->e3; +} Add checks/check-nots to make sure the thing you don't want isn't emitted, not just `!nosanitize` The checks help document what

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli created this revision. Herald added subscribers: rengolin, aemerson. This patch enables the code generation of vector function names that are described by attaching a "#pragma omp declare simd" directive to the scalar function definition/declaration, for the Advanced SIMD (NEON)

[libunwind] r297291 - DARWF: silence some warnings about conversions

Author: compnerd Date: Wed Mar 8 10:03:27 2017 New Revision: 297291 URL: http://llvm.org/viewvc/llvm-project?rev=297291=rev Log: DARWF: silence some warnings about conversions Add a check for an overflow and explicitly cast the value. We would have silently overflowed previously. Modified:

[PATCH] D30735: Add missing implementation for AtomicChange::replace(...)

This revision was automatically updated to reflect the committed changes. Closed by commit rL297289: Add missing implementation for AtomicChange::replace(...) (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D30735?vs=91010=91020#toc Repository: rL LLVM

r297289 - Add missing implementation for AtomicChange::replace(...)

Author: ioeric Date: Wed Mar 8 09:53:10 2017 New Revision: 297289 URL: http://llvm.org/viewvc/llvm-project?rev=297289=rev Log: Add missing implementation for AtomicChange::replace(...) Summary: Just realized the implementation is missing... Reviewers: klimek Reviewed By: klimek Subscribers:

[PATCH] D30735: Add missing implementation for AtomicChange::replace(...)

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D30735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

filcab added inline comments. Comment at: test/CodeGenObjC/ubsan-bool.m:26 + // OBJC: [[ICMP:%.*]] = icmp ule i8 [[ASHR]], 1, !nosanitize + // OBJC: call void @__ubsan_handle_load_invalid_value + jroelofs wrote: > vsk wrote: > > jroelofs wrote: > > > vsk

[PATCH] D30675: [clangd] Fix not being able to attach a debugger on macOS

malaperle-ericsson added a comment. In https://reviews.llvm.org/D30675#695370, @bkramer wrote: > Generally makes sense. Is there any reason for the #ifdef? Windows has errno > and EINTR too. I have no reasonable expectation that getline will produce a EINTR on Windows. But perhaps there's no

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL297283: [analyzer] Clarify 'uninitialized function argument' messages (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D30341?vs=90471=91012#toc Repository: rL LLVM

r297283 - [analyzer] Clarify 'uninitialized function argument' messages

Author: danielmarjamaki Date: Wed Mar 8 09:22:24 2017 New Revision: 297283 URL: http://llvm.org/viewvc/llvm-project?rev=297283=rev Log: [analyzer] Clarify 'uninitialized function argument' messages Differential Revision: https://reviews.llvm.org/D30341 Modified:

[PATCH] D30729: [ubsan] Skip range checks for width-limited values

arphaman added a comment. You should also add a test for `enum E : unsigned`. https://reviews.llvm.org/D30729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libunwind] r297174 - Improve readability and correctness of the OS specific libunwind bits.

Hi Asiri, 2017-03-07 20:42 GMT+01:00 Asiri Rathnayake : > Could you please always include cfe-commits as a subscriber in you phab > reviews? > > We would like to be aware of these changes in advance before they land. Sure thing! I'll try to do that from now on. That

  1   2   >