Re: [libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

Hi Eric, I fixed the build for darwin in r297703, let me know if you have any comments. Thanks, On Mon, Mar 13, 2017 at 3:04 PM, Bruno Cardoso Lopes wrote: > Hi Eric, > >> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR >> @@ -62,12 +66,7 @@ if (APPLE

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama marked 3 inline comments as done. pirama added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:369 if (A->getOption().matches(options::OPT_O4) || -A->getOption().matches(options::OPT_Ofast)) +

[libcxx] r297703 - Fix cmake to find the compiler-rt libs on darwin

Author: bruno Date: Mon Mar 13 23:12:29 2017 New Revision: 297703 URL: http://llvm.org/viewvc/llvm-project?rev=297703=rev Log: Fix cmake to find the compiler-rt libs on darwin Followup for r297553, which left darwin in a broken state

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama updated this revision to Diff 91671. pirama added a comment. Address review comments https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c ===

Re: Patch for Bug 30413, including test case

Committed r297702. > On Mar 13, 2017, at 10:02 AM, Lobron, David wrote: > > Yes, please, if you don't mind! I'd like to commit both the path and the > unit test, if possible. > > Thanks, > > David > >> On Mar 13, 2017, at 12:47 PM, Akira Hatanaka

r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

Author: ahatanak Date: Mon Mar 13 23:00:52 2017 New Revision: 297702 URL: http://llvm.org/viewvc/llvm-project?rev=297702=rev Log: [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded correctly. This fixes PR30413. Patch by David Lobron. Added:

[PATCH] D30762: [ubsan] Add a nullability sanitizer

This revision was automatically updated to reflect the committed changes. Closed by commit rL297700: [ubsan] Add a nullability sanitizer (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D30762?vs=91382=91658#toc Repository: rL LLVM https://reviews.llvm.org/D30762

r297700 - [ubsan] Add a nullability sanitizer

Author: vedantk Date: Mon Mar 13 20:56:34 2017 New Revision: 297700 URL: http://llvm.org/viewvc/llvm-project?rev=297700=rev Log: [ubsan] Add a nullability sanitizer Teach UBSan to detect when a value with the _Nonnull type annotation assumes a null value. Call expressions, initializers,

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

mehdi_amini added a comment. Agree with @pcc. Unless anyone has a need to have "perfect" support for Os, this is the right direction. https://reviews.llvm.org/D30920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pcc added a comment. In https://reviews.llvm.org/D30920#700077, @tejohnson wrote: > Until everything is converted to using size attributes, it seems like a > correct fix for the bug is to accept these options in the gold-plugin and > pass through the LTO API to the PassManagerBuilder. Not

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

rnk updated this revision to Diff 91653. rnk marked an inline comment as done. rnk added a comment. - Actually make this warning off by default https://reviews.llvm.org/D30923 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

rnk marked an inline comment as done. rnk added inline comments. Comment at: test/Sema/warn-bitfield-enum-conversion.c:3 + +enum TwoBits { Hi1 = 3 } two_bits; +enum TwoBitsSigned { Lo2 = -2, Hi2 = 1 } two_bits_signed; thakis wrote: > can you add an enum with an

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

rnk updated this revision to Diff 91652. rnk added a comment. - Make test C++, add fixed type enum https://reviews.llvm.org/D30923 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

thakis added inline comments. Comment at: test/Sema/warn-bitfield-enum-conversion.c:3 + +enum TwoBits { Hi1 = 3 } two_bits; +enum TwoBitsSigned { Lo2 = -2, Hi2 = 1 } two_bits_signed; can you add an enum with an explicit underlying type? will this warning always

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! https://reviews.llvm.org/D30700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r297696 - clang-format: Make it very slighly more expensive to wrap between "= {".

Author: djasper Date: Mon Mar 13 19:40:32 2017 New Revision: 297696 URL: http://llvm.org/viewvc/llvm-project?rev=297696=rev Log: clang-format: Make it very slighly more expensive to wrap between "= {". This prevents unwanted fallout from r296664. Specifically in proto formatting, this changed:

r297694 - Fix crash with interrupt attribute on ARM.

Author: efriedma Date: Mon Mar 13 19:18:29 2017 New Revision: 297694 URL: http://llvm.org/viewvc/llvm-project?rev=297694=rev Log: Fix crash with interrupt attribute on ARM. An indirect call has no associated function declaration. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp

r297693 - Reapply [VFS] Ignore broken symlinks in the directory iterator.

Author: ributzka Date: Mon Mar 13 19:14:40 2017 New Revision: 297693 URL: http://llvm.org/viewvc/llvm-project?rev=297693=rev Log: Reapply [VFS] Ignore broken symlinks in the directory iterator. Modified the tests to accept any iteration order, to run only on Unix, and added additional error

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

tejohnson added a comment. Interested in pcc's thoughts, as https://bugs.llvm.org/show_bug.cgi?id=32155 mentioned you already discussed with him. Note that some of the passes that check PassManagerBuilder::sizeLevel are added during the ThinLTO back end (e.g. populateModulePassManager which

[PATCH] D30923: Warn on enum assignment to bitfields that can't fit all values

rnk created this revision. This adds -Wbitfield-enum-conversion, which warns on implicit conversions that happen on bitfield assignment that change the value of some enumerators. Values of enum type typically take on a very small range of values, so they are frequently stored in bitfields.

[PATCH] D30922: [Builtins] Synchronize the definition of fma/fmaf/fmal in Builtins.def with the implementation in CGBuiltins.cpp

craig.topper created this revision. The fma libcalls are defined in Builtins.def using the 'e' attribute that says that its only const if -fno-math-errno. It was apparently marked this way because that's what the posix spec says. This determines whether the call gets marked as const or not in

Re: LLVM Lab SVN mirror is behind

A quick update. The SVN mirror got corrupted by r297634. Svnsync does not like huge commits. I'm in the middle of restoring and synch-ing up the mirror. Too soon to give any ETA, unfortunately. Thank you for your patience. Thanks Galina On Mon, Mar 13, 2017 at 12:36 PM, Galina Kistanova

[PATCH] D30809: [coroutines] Add codegen for await and yield expressions

majnemer added inline comments. Comment at: lib/CodeGen/CGCoroutine.cpp:85 + unsigned No = 0; + StringRef AwaitKindStr = 0; + switch (Kind) { I'd just let the default constructor do its thing. https://reviews.llvm.org/D30809

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama created this revision. Herald added a subscriber: mehdi_amini. Address PR32155: Skip passing -Os and -Oz to the Gold plugin using -plugin-opt. https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c

r297680 - Widen AST bitfields too small to represent all enumerators

Author: rnk Date: Mon Mar 13 17:33:04 2017 New Revision: 297680 URL: http://llvm.org/viewvc/llvm-project?rev=297680=rev Log: Widen AST bitfields too small to represent all enumerators All of these were found by a new warning that I am prototyping, -Wbitfield-enum-conversion.

r297681 - Fix -Wunused-lambda-capture warning in new code

Author: rnk Date: Mon Mar 13 17:33:07 2017 New Revision: 297681 URL: http://llvm.org/viewvc/llvm-project?rev=297681=rev Log: Fix -Wunused-lambda-capture warning in new code Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp URL:

[PATCH] D30733: [Driver] Add arch-specific rpath for libc++

pirama added inline comments. Comment at: lib/Driver/ToolChain.cpp:652 +// libc++ may be installed per arch. +addArchSpecificRPath(*this, Args, CmdArgs); break; Hahnfeld wrote: > pirama wrote: > > `addArchSpecificRPath` is a static function in

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama updated this revision to Diff 91635. pirama added a comment. *Actually* add the command line flags. https://reviews.llvm.org/D30700 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/arch-specific-libdir-rpath.c

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

rnk added a comment. In https://reviews.llvm.org/D30700#695358, @Hahnfeld wrote: > No build system will ever set `-frtlib-add-rpath` to enable this "feature". > I'm for keeping this opt-out until we have configuration files to set this by > default. Making it opt-in would weaken its main

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama updated this revision to Diff 91633. pirama added a comment. - Rebase - Added command line flag and updated tests. https://reviews.llvm.org/D30700 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/arch-specific-libdir-rpath.c test/Driver/arch-specific-libdir.c test/lit.cfg

[PATCH] D30896: [Clang-tidy] add check misc-prefer-switch-for-enums

aaron.ballman added a comment. I'm curious what kind of results you get when running this over a large code base. There are definitely times when using == or != for a specific value is *way* cleaner than using a switch statement, and I worry about this being so chatty that it needs to be

[PATCH] D30915: Canonicalize the path provided by -fmodules-cache-path

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Frontend/CompilerInvocation.cpp:1434 + + // Canonicalize -fmodules-cache-path before storing it. + SmallString<128>

[PATCH] D30766: Add support for attribute "enum_extensibility"

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1969 + let Content = [{ +Attribute ``enum_extensibility`` is used to distinguish between enum definitions that are extensible and those that are not. The attribute can take either ``closed`` or

[PATCH] D30915: Canonicalize the path provided by -fmodules-cache-path

aprantl created this revision. This fixes lookup mismatches that could previously happen when the module cache path contained a '/./' component. In combination with https://reviews.llvm.org/D28299 this bug can cause a use-after-free. rdar://problem/30413458 https://reviews.llvm.org/D30915

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20 +///\brief Warns about using throw in function declared as noexcept. +/// It complains about every throw, even if it is caught later. +class ThrowWithNoexceptCheck : public

Re: [libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

Hi Eric, > if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR > @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER) > message(WARNING "LLVM_USE_SANITIZER=${LLVM_USE_SANITIZER} is not > supported on OS X") >endif() >if (LIBFILE) > -execute_process(COMMAND

[PATCH] D29923: PPCallbacks::MacroUndefined, change signature and add test.

marsupial updated this revision to Diff 91627. marsupial retitled this revision from "Add test for PPCallbacks::MacroUndefined" to "PPCallbacks::MacroUndefined, change signature and add test.". marsupial edited the summary of this revision. Herald added a subscriber: nemanjai.

[PATCH] D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r297671, thanks! https://reviews.llvm.org/D30610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r297671 - Add the 'AllowSoleDefaultDtor' and 'AllowMissingMoveFunctions' options to the cppcoreguidelines-special-member-functions check.

Author: aaronballman Date: Mon Mar 13 16:39:00 2017 New Revision: 297671 URL: http://llvm.org/viewvc/llvm-project?rev=297671=rev Log: Add the 'AllowSoleDefaultDtor' and 'AllowMissingMoveFunctions' options to the cppcoreguidelines-special-member-functions check. Patch by Florian Gross. Added:

[PATCH] D30898: Add new -fverbose-asm that enables source interleaving

andreybokhanko added a comment. Hi Roger, I'm very glad to see you started to work on this! A somewhat obvious comment: no chance for this to be accepted without LIT tests. I understand you have your doubts on the best approach to testing -- and it's OK to ask either here or on llvm-dev --

[PATCH] D30810: Preserve vec3 type.

jaykang10 added a comment. In https://reviews.llvm.org/D30810#699695, @bruno wrote: > Hi JinGu, > > I just read the discussion on cfe-dev, some comments: > > > My colleague and I are implementing a transformation pass between LLVM IR > > and another IR and we want to keep the 3-component vector

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich updated this revision to Diff 91615. vlad.tsyrklevich added a comment. Fix a stray assert(), correctly this time.. https://reviews.llvm.org/D30909 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich updated this revision to Diff 91614. vlad.tsyrklevich added a comment. Fix a stray assert() https://reviews.llvm.org/D30909 Files: lib/StaticAnalyzer/Core/ProgramState.cpp Index: lib/StaticAnalyzer/Core/ProgramState.cpp

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich created this revision. This is the second part of https://reviews.llvm.org/D28445, it extends taint propagation to cases where the tainted region is a sub-region and we can't taint a conjured symbol entirely. This required adding a new map in the GDM that maps tainted parent

[PATCH] D29877: Warn about unused static file scope function template declarations.

rsmith added inline comments. Comment at: lib/Sema/Sema.cpp:472-477 +// If this is a function template, we should remove if it has no +// specializations. +if (FunctionTemplateDecl *Template = FD->getDescribedFunctionTemplate()) { + if

[PATCH] D30881: Track skipped files in dependency scanning

bruno added a comment. Hi Pete, Comment at: lib/Frontend/DependencyFile.cpp:191 + const Token , + SrcMgr::CharacteristicKind FileType) override; + Is there any `FileSkipped` callback invocation that might trigger an unwanted

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Hi Pete, thanks for working on this! LGTM with the minor comments below. Comment at: include/clang/Lex/PPCallbacks.h:264 + virtual void HasInclude(SourceLocation Loc, const

[PATCH] D30810: Preserve vec3 type.

bruno added a reviewer: bruno. bruno added a comment. Hi JinGu, I just read the discussion on cfe-dev, some comments: > My colleague and I are implementing a transformation pass between LLVM IR and > another IR and we want to keep the 3-component vector types in our target IR Why can't you go

r297659 - AMDGPU: Make 0 the private nullptr value

Author: arsenm Date: Mon Mar 13 14:47:53 2017 New Revision: 297659 URL: http://llvm.org/viewvc/llvm-project?rev=297659=rev Log: AMDGPU: Make 0 the private nullptr value We can't actually pretend that 0 is valid for address space 0. r295877 added a workaround to stop allocating user objects

[PATCH] D30810: Preserve vec3 type.

jaykang10 added a comment. In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation > accordingly to make things consistent? Probably, No... the load/store with vec3 generates vec4 temporarily to be aligned

LLVM Lab SVN mirror is behind

Hello everyone, The SVN mirror in the LLVM Lab seems behind with the changes. I'm looking at the issue. Thank you for understanding. Thanks ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

dexonsmith closed this revision. dexonsmith marked 3 inline comments as done. dexonsmith added a comment. Thanks for the review Richard! Committed in r297655 with those changes. Sorry for the long delay on this. Somehow I missed until today the review after my ultimate ping. I'd like to

r297655 - Modules: Use hash of PCM content for SIGNATURE

Author: dexonsmith Date: Mon Mar 13 13:45:08 2017 New Revision: 297655 URL: http://llvm.org/viewvc/llvm-project?rev=297655=rev Log: Modules: Use hash of PCM content for SIGNATURE Change ASTFileSignature from a random 32-bit number to the hash of the PCM content. - Move definition

[PATCH] D30743: enable -save-temps with -finclude-defult-header

guansong updated this revision to Diff 91600. https://reviews.llvm.org/D30743 Files: lib/Driver/Tools.cpp test/Driver/include-default-header.cl Index: test/Driver/include-default-header.cl === --- /dev/null +++

r297654 - Widen bitfield for type specifiers for OpenCL types

Author: rnk Date: Mon Mar 13 13:42:30 2017 New Revision: 297654 URL: http://llvm.org/viewvc/llvm-project?rev=297654=rev Log: Widen bitfield for type specifiers for OpenCL types Added a static_assert to catch this issue at compile time. Modified: cfe/trunk/include/clang/Basic/Specifiers.h

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

Anastasia added a comment. In https://reviews.llvm.org/D28136#697844, @bader wrote: > > Why do you think this is a bug? It seems to follow standard behavior in C > > to promote char to int if required. Just like if you would have a C code: > > > > int as_int(int i); > > void foo() { > >

[PATCH] D30896: [CLANG-TIDY] add check misc-prefer-switch-for-enums

JonasToth added a comment. alright. then i have a good check for myself to write ;) https://reviews.llvm.org/D30896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r297649 - [Linker] Provide callback for internalization

Author: jdevlieghere Date: Mon Mar 13 13:08:11 2017 New Revision: 297649 URL: http://llvm.org/viewvc/llvm-project?rev=297649=rev Log: [Linker] Provide callback for internalization Differential Revision: https://reviews.llvm.org/D30738 Modified:

[PATCH] D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check

fgross added a comment. No commit access, could someone please take care of this? Thanks! https://reviews.llvm.org/D30610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error<

[PATCH] D30896: [CLANG-TIDY] add check misc-prefer-switch-for-enums

jbcoe marked 2 inline comments as done. jbcoe added a comment. Handling enum Kind k = Kind::a; if (k == 3) { /* something */ } is intentionally out of scope for now as the author is doing something that I can't trivially replace with a switch. Comment at:

[PATCH] D30743: enable -save-temps with -finclude-defult-header

Anastasia added inline comments. Comment at: lib/Driver/Tools.cpp:5288 // parser. - Args.AddAllArgValues(CmdArgs, options::OPT_Xclang); + if (C.getDriver().isSaveTempsEnabled() && + !isa(JA)) { It would be nice to add a comment around here explaining

[PATCH] D30896: [CLANG-TIDY] add check misc-prefer-switch-for-enums

jbcoe updated this revision to Diff 91588. jbcoe added a comment. Minor edits in response to review comments. A few questions outstanding. https://reviews.llvm.org/D30896 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D30875: [X86] Add checking of the scale argument to scatter/gather builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL297642: [X86] Add checking of the scale argument to scatter/gather builtins (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D30875?vs=91508=91586#toc Repository: rL LLVM

r297642 - [X86] Add checking of the scale argument to scatter/gather builtins

Author: ctopper Date: Mon Mar 13 12:16:50 2017 New Revision: 297642 URL: http://llvm.org/viewvc/llvm-project?rev=297642=rev Log: [X86] Add checking of the scale argument to scatter/gather builtins The only valid values for scale immediate of scatter/gather builtins are 1, 2, 4, or 8. This patch

Re: Patch for Bug 30413, including test case

Yes, please, if you don't mind! I'd like to commit both the path and the unit test, if possible. Thanks, David > On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote: > > Do you need someone to commit this patch for you? > >> On Mar 10, 2017, at 6:44 AM, Lobron, David

Re: Patch for Bug 30413, including test case

Do you need someone to commit this patch for you? > On Mar 10, 2017, at 6:44 AM, Lobron, David wrote: > > Hi Akira, > > Thank you very much! Please let me know if I need to take any further steps > beyond this email to cfe-commits in order for the patch and the unit test

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation accordingly to make things consistent? https://reviews.llvm.org/D30810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30816: [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL

Anastasia added inline comments. Comment at: test/SemaOpenCL/overload-scalar-widening.cl:4 + +typedef short short4 __attribute__((ext_vector_type(4))); + I am thinking could this be a CodeGen test instead and we could check that the right overload is selected

[PATCH] D30766: Add support for attribute "enum_extensibility"

ahatanak added inline comments. Comment at: test/Sema/enum-attr.c:27 + +enum __attribute__((enum_extensibility(arg1))) EnumInvalidArg { // expected-warning{{'enum_extensibility' attribute argument not supported: 'arg1'}} + G arphaman wrote: > Should this be

[PATCH] D30766: Add support for attribute "enum_extensibility"

ahatanak updated this revision to Diff 91577. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address Alex's review comments. https://reviews.llvm.org/D30766 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D30898: Add new -fverbose-asm that enables source interleaving

rogfer01 created this revision. This is the clang side of the RFC in http://lists.llvm.org/pipermail/cfe-dev/2017-February/052549.html Note that in contrast to the original suggestion `-fsource-asm` here we use the preferred `-fverbose-asm`. Basically explicitly saying `-fverbose-asm` in the

[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL297630: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D30720?vs=91042=91570#toc Repository:

[clang-tools-extra] r297630 - [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

Author: sammccall Date: Mon Mar 13 10:55:59 2017 New Revision: 297630 URL: http://llvm.org/viewvc/llvm-project?rev=297630=rev Log: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly. Summary: Add fuzzy SymbolIndex, where identifier needn't match exactly. The purpose

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

jroelofs added a comment. In https://reviews.llvm.org/D30158#699132, @madsravn wrote: > In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D30158#696534, @madsravn wrote: > > > > > Any updates on this? > > > > > > Have you run it over the test

[PATCH] D30896: [CLANG-TIDY] add check misc-prefer-switch-for-enums

JonasToth added a comment. I like that check. But I think it could take another feature. In my opinion it would be valueable to check if enums are compared against ints as well. For example enum Kind k = Kind::a; if (k == 3) { /* something */ } This usecase is not specially considered

[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

bkramer accepted this revision. bkramer added a comment. lg as a prototype. https://reviews.llvm.org/D30720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r297628 - [CodeCompletion] Format block parameter placeholders in implicit property

Author: arphaman Date: Mon Mar 13 10:43:42 2017 New Revision: 297628 URL: http://llvm.org/viewvc/llvm-project?rev=297628=rev Log: [CodeCompletion] Format block parameter placeholders in implicit property setters using the block type information that's obtained from the property rdar://12604235

[PATCH] D30896: [CLANG-TIDY] add check misc-prefer-switch-for-enums

jbcoe created this revision. jbcoe added a project: clang-tools-extra. Herald added subscribers: JDevlieghere, mgorny. Add a check to find enums used in `==` or `!=` expressions. Using a switch statement leads to more easily maintained code. Repository: rL LLVM

[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

sammccall added a comment. bkramer: ping https://reviews.llvm.org/D30720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30831: [ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL297627: [ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D30831?vs=91541=91567#toc Repository: rL LLVM

r297627 - [ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands

Author: xazax Date: Mon Mar 13 10:32:24 2017 New Revision: 297627 URL: http://llvm.org/viewvc/llvm-project?rev=297627=rev Log: [ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands Patch by Zoltan Gera! Differential Revision: https://reviews.llvm.org/D30831 Modified:

[PATCH] D30831: [ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Looks good, thank you! https://reviews.llvm.org/D30831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29923: Add test for PPCallbacks::MacroUndefined

marsupial updated this revision to Diff 91563. marsupial retitled this revision from "Send UndefMacroDirective to MacroDefined callback" to "Add test for PPCallbacks::MacroUndefined". marsupial edited the summary of this revision. https://reviews.llvm.org/D29923 Files:

r297623 - [clang-format] Add more examples and fix a bug in the py generation script

Author: sylvestre Date: Mon Mar 13 09:42:47 2017 New Revision: 297623 URL: http://llvm.org/viewvc/llvm-project?rev=297623=rev Log: [clang-format] Add more examples and fix a bug in the py generation script Reviewers: djasper Reviewed By: djasper Subscribers: cfe-commits, klimek Differential

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @rsmith ping... https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20 +///\brief Warns about using throw in function declared as noexcept. +/// It complains about every throw, even if it is caught later. +class ThrowWithNoexceptCheck : public ClangTidyCheck {

[PATCH] D30884: When diagnosing taking address of packed members skip __unaligned-qualified expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL297620: When diagnosing taking address of packed members skip __unaligned-qualified… (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D30884?vs=91531=91548#toc Repository:

r297620 - When diagnosing taking address of packed members skip __unaligned-qualified expressions

Author: rogfer01 Date: Mon Mar 13 08:18:21 2017 New Revision: 297620 URL: http://llvm.org/viewvc/llvm-project?rev=297620=rev Log: When diagnosing taking address of packed members skip __unaligned-qualified expressions Given that we have already explicitly stated in the qualifier that the

r297619 - [analyzer] Fix a rare crash for valist check.

Author: xazax Date: Mon Mar 13 07:48:26 2017 New Revision: 297619 URL: http://llvm.org/viewvc/llvm-project?rev=297619=rev Log: [analyzer] Fix a rare crash for valist check. It looks like on some host-triples the result of a valist related expr can be a LazyCompoundVal. Handle that case in the

[PATCH] D30831: [ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands

gerazo marked an inline comment as done. gerazo added inline comments. Comment at: lib/AST/ASTImporter.cpp:5221 IdentifierInfo *ToII = Importer.Import(S->getOutputIdentifier(I)); -if (!ToII) - return nullptr; +// ToII is nullptr when no symbolic name is given

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

bader added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error<

[PATCH] D30831: [ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands

gerazo updated this revision to Diff 91541. gerazo added a comment. Better check not letting a real import problem passing through https://reviews.llvm.org/D30831 Files: lib/AST/ASTImporter.cpp test/ASTMerge/asm/Inputs/asm-function.cpp test/ASTMerge/asm/test.cpp Index:

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added a comment. In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote: > In https://reviews.llvm.org/D30158#696534, @madsravn wrote: > > > Any updates on this? > > > Have you run it over the test suite on the revision before random_shuffle was > removed from libc++? I

[PATCH] D30884: When diagnosing taking address of packed members skip __unaligned-qualified expressions

rogfer01 added a comment. Thanks for the review @aaron.ballman! https://reviews.llvm.org/D30884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30884: When diagnosing taking address of packed members skip __unaligned-qualified expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D30884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

echuraev updated this revision to Diff 91536. https://reviews.llvm.org/D30643 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp test/Parser/opencl-atomics-cl20.cl test/SemaOpenCL/atomic-init.cl Index: test/SemaOpenCL/atomic-init.cl

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MiscTidyModule.cpp:70 +CheckFactories.registerCheck( +"misc-forwarding-reference-overload"); CheckFactories.registerCheck("misc-misplaced-const"); xazax.hun wrote: >

[PATCH] D30183: Add -iframeworkwithsysroot compiler option

This revision was automatically updated to reflect the committed changes. Closed by commit rL297614: Add -iframeworkwithsysroot compiler option (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D30183?vs=89152=91534#toc Repository: rL LLVM

r297614 - Add -iframeworkwithsysroot compiler option

Author: arphaman Date: Mon Mar 13 06:17:41 2017 New Revision: 297614 URL: http://llvm.org/viewvc/llvm-project?rev=297614=rev Log: Add -iframeworkwithsysroot compiler option This commit adds support for a new -iframeworkwithsysroot compiler option which allows the user to specify a framework path

  1   2   >