rogfer01 created this revision.
Given that we have already explicitly stated in the qualifier that the
expression is `__unaligned`,
it makes little sense to diagnose that the address of the packed member may not
be aligned.
https://reviews.llvm.org/D30884
Files:
lib/Sema/SemaChecking.cpp
Hi Galina,
Thanks for reporting it! I believe the issue is fixed in r297530.
Cheers,
Anastasia
From: Galina Kistanova [mailto:gkistan...@gmail.com]
Sent: 10 March 2017 20:29
To: Anastasia Stulova
Cc: cfe-commits
Subject: Re: r297468 - [OpenCL] Fix type compatibility check and generic AS
bader added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: docs/tools/dump_format_style.py:67
def __str__(self):
-return '* ``%s`` %s' % (self.name, doxygen2rst(self.comment))
+return '\n* ``%s``
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297607: clang-format: [JS] do not wrap @see tags. (authored
by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D30883?vs=91527=91529#toc
Repository:
rL LLVM
Author: mprobst
Date: Mon Mar 13 04:39:23 2017
New Revision: 297607
URL: http://llvm.org/viewvc/llvm-project?rev=297607=rev
Log:
clang-format: [JS] do not wrap @see tags.
Summary:
@see is special among JSDoc tags in that it is commonly followed by URLs. The
JSDoc spec suggests that users should
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D30883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xazax.hun added inline comments.
Comment at: clang-tidy/misc/MiscTidyModule.cpp:70
+CheckFactories.registerCheck(
+"misc-forwarding-reference-overload");
CheckFactories.registerCheck("misc-misplaced-const");
malcolm.parsons wrote:
>
mprobst created this revision.
Herald added a subscriber: klimek.
@see is special among JSDoc tags in that it is commonly followed by URLs. The
JSDoc spec suggests that users should wrap URLs in an additional {@link url...}
tag (@see http://usejsdoc.org/tags-see.html), but this is very commonly
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/MiscTidyModule.cpp:70
+CheckFactories.registerCheck(
+"misc-forwarding-reference-overload");
CheckFactories.registerCheck("misc-misplaced-const");
aaron.ballman wrote:
> leanil
a.sidorin added a comment.
Hello Zoltan,
Thank you for the patch. There is an inline comment.
Comment at: lib/AST/ASTImporter.cpp:5221
IdentifierInfo *ToII = Importer.Import(S->getOutputIdentifier(I));
-if (!ToII)
- return nullptr;
+// ToII is nullptr when no
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297606: clang-format: [JS] allow breaking after non-null
assertions. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D30705?vs=90988=91526#toc
Repository:
rL LLVM
Author: mprobst
Date: Mon Mar 13 04:14:23 2017
New Revision: 297606
URL: http://llvm.org/viewvc/llvm-project?rev=297606=rev
Log:
clang-format: [JS] allow breaking after non-null assertions.
Summary:
Previously clang-format would not break after any !. However in TypeScript, !
can be used as a
JDevlieghere abandoned this revision.
JDevlieghere added a comment.
In https://reviews.llvm.org/D30792#697802, @mehdi_amini wrote:
> Off topic, but since this is a rev lock change with LLVM, you can to all of
> in a single revision with:
>
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good from my side.
https://reviews.llvm.org/D30720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jaykang10 marked an inline comment as done.
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#699006, @ahatanak wrote:
> Could you elaborate on the motivation for this change?
>
> I was wondering why clang (CodeGen) needed the help of a command line option
> to decide whether vec3
pete created this revision.
Herald added a subscriber: nemanjai.
This adds a PP callback for the __has_include and __has_include_next directives.
Checking for the presence of a header should add it to the list of header
dependencies so this overrides the callback in the dependency scanner.
I
igorb accepted this revision.
igorb added a comment.
This revision is now accepted and ready to land.
LGTM,
Could you please add test that check scale and hint parameter errors for
BI__builtin_ia32_gatherpfdpd for example.
https://reviews.llvm.org/D30875
ahatanak added a comment.
Could you elaborate on the motivation for this change?
I was wondering why clang (CodeGen) needed the help of a command line option to
decide whether vec3 should be converted to vec4. Can it just preserve vec3 when
the architecture is spir?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297605: clang-format: [JS] do not wrap after interface and
type. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D30874?vs=91500=91519#toc
Repository:
rL LLVM
Author: mprobst
Date: Mon Mar 13 02:10:18 2017
New Revision: 297605
URL: http://llvm.org/viewvc/llvm-project?rev=297605=rev
Log:
clang-format: [JS] do not wrap after interface and type.
Summary:
`interface` and `type` are pseudo keywords and cause automatic semicolon
insertion when followed by a
pete created this revision.
Its possible for a header to be a symlink to another header. In this case,
both are actually the same underlying file, and will both have the same include
guards.
Because of this, if we #include the header, then #include the symlink, or vice
versa, then one will
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D30874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
101 - 123 of 123 matches
Mail list logo
