[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

danielmarjamaki added a comment. > I hold the view that I need to respect original developers' code, and it need > a Global Patch for Capital variable, just like KDE's Use nullptr everywhere Yes I was too picky. Please respect the original developers' code. Comment at:

[PATCH] D32248: CodeGen: Cast alloca to expected address space

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1118 +AddrTy->getElementType()->getPointerTo(ExpectedAddrSpace)), +address.getAlignment()); + } This is a lot of work to be doing in a pretty common routine for the benefit of

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95887. xiangzhai added a comment. Hi Artem, Thanks for your review! I updated my patch, please review it. Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

What would be the status of these buildbots? Is it for your private usage? Otherwise having “project' bots” using a non-official mirror may sound like a strange situation to me. — Mehdi > On Apr 19, 2017, at 5:04 PM, Eric Fiselier via llvm-dev > wrote: > > Adding

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

NoQ added a comment. Yay, now that's a lot cleaner! Regarding style, recently we tend to ask for updating the style in the new code, and i don't think the Golden Rule (http://llvm.org/docs/CodingStandards.html#introduction) does much in our case, but i don't have a strong opinion on that.

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

xiangzhai created this revision. Hi LLVM developers, I am a Linux engineer of operating system department at iSOFT , I want to add iSOFTLinux to GNU ToolChains X86Triple, please review my patch, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM

[PATCH] D31975: [Analyzer] Iterator Checkers

NoQ added a comment. I think for this case it'd be great to (instead) add comments all over the place (especially in checker callbacks, eg. `check[Pre|Post]Call()` function bodies) to indicate what check every piece of code is for. That'd be equally easy to review, at least for me, but it'd

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95880. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c === ---

[PATCH] D32248: CodeGen: Cast alloca to expected address space

yaxunl added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1105-1119 + // Alloca always returns a pointer in alloca address space, which may + // be different from the type defined by the language. For example, + // in C++ the auto variables are in the default address

[libcxx] r300820 - Disable the filesystem library on Windows by default

Author: ericwf Date: Wed Apr 19 23:24:29 2017 New Revision: 300820 URL: http://llvm.org/viewvc/llvm-project?rev=300820=rev Log: Disable the filesystem library on Windows by default Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

[PATCH] D29827: [AVR] Add -mmcu option to the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL300818: [AVR] Add -mmcu option to the driver (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D29827?vs=95707=95879#toc Repository: rL LLVM https://reviews.llvm.org/D29827

r300818 - [AVR] Add -mmcu option to the driver

Author: xiangzhai Date: Wed Apr 19 23:23:24 2017 New Revision: 300818 URL: http://llvm.org/viewvc/llvm-project?rev=300818=rev Log: [AVR] Add -mmcu option to the driver A patch by Peter Wu! Reviewers: jroelofs, xiangzhai Reviewed By: jroelofs, dylanmckay, xiangzhai Subscribers: dlj,

[libcxx] r300817 - Rename the static version of libc++ on Windows.

Author: ericwf Date: Wed Apr 19 23:19:02 2017 New Revision: 300817 URL: http://llvm.org/viewvc/llvm-project?rev=300817=rev Log: Rename the static version of libc++ on Windows. Previously both the static version of libc++ and the import library for the DLL had the same name, 'c++.lib'. This

[PATCH] D32260: [TBAA] Vector types should (only) alias with their element types

hfinkel abandoned this revision. hfinkel added a comment. @rjmccall said, on this topic, in https://reviews.llvm.org/D31885: > The root problem there is that the design of vector types and vector > interfaces is generally quite bad; you cannot rely on things like vectors > being stored with an

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

smeenai resigned from this revision. smeenai edited reviewers, added: compnerd; removed: smeenai. smeenai added a comment. This looks good to me, but I'm not familiar enough with this part of clang to be comfortable accepting. https://reviews.llvm.org/D32265

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

hfinkel added a comment. In https://reviews.llvm.org/D31561#731498, @dexonsmith wrote: > Marshall, that's what I assumed originally, but I figured Hal had some > non-standard-but-worth-supporting use case in mind. In this case, future-proofing and mathematical precision seemed aligned. I

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

EricWF created this revision. Herald added subscribers: dschuff, jfb. Libc++ currently implements the `ATOMIC__LOCK_FREE` macros using the `__GCC_ATOMIC__LOCK_FREE` macros. However these are not available when MSVC compatibility is enabled even though C11 `_Atomic` is. This prevents libc++

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95874. xiangzhai added a comment. Hi David, Thanks for your review! I updated my patch as you suggested! Please review it, thanks a lot! but I argue that: > I have the feeling this should be renamed. Since its purpose is to calculate > the total size

r300814 - [ODRHash] clean up test and add new examples. NFC

Author: rtrieu Date: Wed Apr 19 21:53:53 2017 New Revision: 300814 URL: http://llvm.org/viewvc/llvm-project?rev=300814=rev Log: [ODRHash] clean up test and add new examples. NFC Use a macro to generate the struct with all decls. Previously, four identical changes would be needed to update this

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

dexonsmith added a comment. Eric: somehow I never got an email notification for your review :/. If Marshall is okay with the current state, I'll document that before commit. https://reviews.llvm.org/D31561 ___ cfe-commits mailing list

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

dexonsmith added a comment. Marshall, that's what I assumed originally, but I figured Hal had some non-standard-but-worth-supporting use case in mind. Hal, what do you think? https://reviews.llvm.org/D31561 ___ cfe-commits mailing list

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith added a comment. Ping. https://reviews.llvm.org/D31856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r300809 - Make linker errors verbose on Windows

Author: ericwf Date: Wed Apr 19 20:50:39 2017 New Revision: 300809 URL: http://llvm.org/viewvc/llvm-project?rev=300809=rev Log: Make linker errors verbose on Windows Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL:

[PATCH] D32263: Preprocessor: Suppress -Wnonportable-include-path for header maps

dexonsmith created this revision. If a file search involves a header map, suppress -Wnonportable-include-path. It's firing lots of false positives for framework authors internally, and it's not trivial to fix. Consider a framework called "Foo" with a main (installed) framework header

[libcxx] r300808 - Fix dllimport on a class template

Author: ericwf Date: Wed Apr 19 20:45:15 2017 New Revision: 300808 URL: http://llvm.org/viewvc/llvm-project?rev=300808=rev Log: Fix dllimport on a class template Modified: libcxx/trunk/include/utility Modified: libcxx/trunk/include/utility URL:

r300805 - PR32673: Don't wrap parameter packs in SubstTemplateTypeParmPackType nodes when forming implicit deduction guides.

Author: rsmith Date: Wed Apr 19 20:15:31 2017 New Revision: 300805 URL: http://llvm.org/viewvc/llvm-project?rev=300805=rev Log: PR32673: Don't wrap parameter packs in SubstTemplateTypeParmPackType nodes when forming implicit deduction guides. Doing so thwarts template type deduction. Instead,

[PATCH] D32213: [Sema] Use MSVC inner class behavior on Itanium

This revision was automatically updated to reflect the committed changes. Closed by commit rL300804: [Sema] Use MSVC inner class behavior on Itanium (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D32213?vs=95689=95867#toc Repository: rL LLVM

r300804 - [Sema] Use MSVC inner class behavior on Itanium

Author: smeenai Date: Wed Apr 19 20:11:42 2017 New Revision: 300804 URL: http://llvm.org/viewvc/llvm-project?rev=300804=rev Log: [Sema] Use MSVC inner class behavior on Itanium Windows Itanium aims to use MSVC export and import semantics. Inner class members shouldn't be exported on a dllexport

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

rsmith added a comment. > As I've currently implemented it, both reads and writes set the type of > previously-unknown storage, and after that it says fixed (unless you memcpy > to it, memset it, or its lifetime ends (the type gets reset on > lifetime.start/end and for malloc/allocas/etc.).

[PATCH] D18478: python bindings: expose the clang version string

compnerd accepted this revision. compnerd added a subscriber: jbcoe. compnerd added a comment. This revision is now accepted and ready to land. This would ideally wait for the change that @jbcoe has in the works to enable python 3, but the change itself is fine. https://reviews.llvm.org/D18478

[PATCH] D31568: Add Python 3 support to clang.cindex

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. I think it would've been nice to split this up into the changes for map/filter rather than group it together. But sure, this looks reasonable. Repository: rL LLVM

Re: r300762 - Fix assertion failure in codegen on non-template deduction guide.

Sorry about that, target triple added in r300803. On 19 April 2017 at 17:12, Galina Kistanova wrote: > Hello Richard, > > This commit broke one of our builders: > > Failing Tests (1): > Clang :: CodeGenCXX/cxx1z-class-deduction.cpp > >

r300803 - Add a triple to codegen test.

Author: rsmith Date: Wed Apr 19 20:02:29 2017 New Revision: 300803 URL: http://llvm.org/viewvc/llvm-project?rev=300803=rev Log: Add a triple to codegen test. Modified: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp Modified: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp URL:

[PATCH] D32192: Enable leak sanitizer builds for darwin

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Please add a test case. The change itself looks reasonable. https://reviews.llvm.org/D32192 ___ cfe-commits mailing list

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#731306, @hfinkel wrote: > In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > > > > > > ... > > > > > > >> (And the nonsensicality of the standard very much continues. The code that > >> we've all agreed is obviously being

[PATCH] D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 300802. Repository: rL LLVM https://reviews.llvm.org/D32237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32251: Implement DR1601 - Promotion of enumeration with fixed underlying type

rsmith added inline comments. Comment at: lib/Sema/SemaOverload.cpp:3850-3853 // In Microsoft mode, prefer an integral conversion to a // floating-to-integral conversion if the integral conversion // is between types of the same size. // For example:

r300802 - [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

Author: cbertol Date: Wed Apr 19 19:39:39 2017 New Revision: 300802 URL: http://llvm.org/viewvc/llvm-project?rev=300802=rev Log: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for https://reviews.llvm.org/D32237 This patch prepares sema with additional fields

[PATCH] D32260: [TBAA] Vector types should (only) alias with their element types

hfinkel created this revision. Herald added a subscriber: mcrosier. Currently, all of our builtin vector types are equivalent to char for TBAA purposes. It would be useful to make this less conservative. This patch makes vector types equivalent to their element types for type-aliasing purposes.

Re: r300762 - Fix assertion failure in codegen on non-template deduction guide.

Hello Richard, This commit broke one of our builders: Failing Tests (1): Clang :: CodeGenCXX/cxx1z-class-deduction.cpp http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1267 Please have a look at this? Thanks Galina On Wed, Apr 19, 2017 at 2:15 PM,

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#731332, @rsmith wrote: > > ! In https://reviews.llvm.org/D32199#731252, @hfinkel wrote: > > > >> How about renaming this to something more like `-fsanitize=type`? > > > > I'm fine with that. Do you like TypeSanitizer or

Re: Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

Adding cfe-dev list... On Wed, Apr 19, 2017 at 5:50 PM, Eric Fiselier wrote: > Hi Will, > > I would like to request collaborator permissions for the Libc++ github > mirror. > > I plan to use the access to setup Appveyor buildbots for libc++. In order > to do this I need to be

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:1464 + /// Determine if \p D abd \p Suggested have a structurally compatibale + /// layout as described in C11 6.2.7/1. Typo 'abd' Comment at:

[libcxx] r300788 - change what branches Appveyor builds

Author: ericwf Date: Wed Apr 19 18:27:48 2017 New Revision: 300788 URL: http://llvm.org/viewvc/llvm-project?rev=300788=rev Log: change what branches Appveyor builds Modified: libcxx/trunk/appveyor.yml Modified: libcxx/trunk/appveyor.yml URL:

[libcxx] r300786 - Add appveyor.yml config for a future Windows bot.

Author: ericwf Date: Wed Apr 19 18:26:21 2017 New Revision: 300786 URL: http://llvm.org/viewvc/llvm-project?rev=300786=rev Log: Add appveyor.yml config for a future Windows bot. I'm currently trying to get a libc++ Windows builder working on appveyor. This patch adds the configuration file

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

rsmith added a comment. > ! In https://reviews.llvm.org/D32199#731252, @hfinkel wrote: > >> How about renaming this to something more like `-fsanitize=type`? > > I'm fine with that. Do you like TypeSanitizer or TypeAccessSantizer or > TypeAliasingSanitizer best? I think calling it a type

[PATCH] D31885: Remove TBAA information from LValues representing union members

hfinkel added a comment. In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > ... > > >> (And the nonsensicality of the standard very much continues. The code that >> we've all agreed is obviously being miscompiled here is still a strict >> violation of the "improved" union rules

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#731249, @hfinkel wrote: > In https://reviews.llvm.org/D32199#731144, @rsmith wrote: > > > > > > ... > > > I would also expect that we will extend this in future to assign types to > > storage even in cases where there is no store (for

[PATCH] D32248: CodeGen: Cast alloca to expected address space

t-tye added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1105-1119 + // Alloca always returns a pointer in alloca address space, which may + // be different from the type defined by the language. For example, + // in C++ the auto variables are in the default address

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#731144, @rsmith wrote: > ... > I would also expect that we will extend this in future to assign types to > storage even in cases where there is no store (for instance, we should be > able to catch `float f() { int n; return

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

pcc added a comment. I won't stand in the way here if others feel strongly that the flag should be passed via a constructor. It will just mean more work to be done if/when this flag is ever changed to be passed via some other mechanism, but that's a relatively minor detail. Repository: rL

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

eugenis added a comment. The ultimate solution would be a function attribute - if we want this thing to work correctly with LTO. But it sounds a bit like overkill, plus none of the settings it depends on (integrated-as, data-sections) work with LTO anway: the former is ignored and the second

r300776 - [sanitizer-coverage] trim down the docs

Author: kcc Date: Wed Apr 19 17:25:30 2017 New Revision: 300776 URL: http://llvm.org/viewvc/llvm-project?rev=300776=rev Log: [sanitizer-coverage] trim down the docs Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

ahatanak added a comment. In https://reviews.llvm.org/D32210#730777, @rjmccall wrote: > The rule we actually want is that no reference to the block derived from the > parameter value will survive after the function returns. You can include > examples of things that would cause potential

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

ahatanak added a comment. In https://reviews.llvm.org/D32210#730553, @jroelofs wrote: > This doesn't forbid assigning them to block properties... is that intentional? > > typedef void (^Block)(int); > > @interface Foo > @property Block B; > @end > > void foo(Foo *f, Block

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

joshz updated this revision to Diff 95833. joshz marked 3 inline comments as done. joshz added a comment. Clean up IsBinaryOrTernary Repository: rL LLVM https://reviews.llvm.org/D31542 Files: clang-tidy/readability/ContainerSizeEmptyCheck.cpp clang-tidy/utils/ASTUtils.cpp

[libcxx] r300770 - Fix typo in Windows test configuration code

Author: ericwf Date: Wed Apr 19 16:52:08 2017 New Revision: 300770 URL: http://llvm.org/viewvc/llvm-project?rev=300770=rev Log: Fix typo in Windows test configuration code Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL:

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

rsmith added a comment. I don't like calling this a "TBAA sanitizer". What we're sanitizing is the object model and effective type rules; it seems irrelevant which specific compiler analysis passes would result in your program misbehaving if you break the rules. I would also expect that we

[PATCH] D32248: CodeGen: Cast alloca to expected address space

yaxunl created this revision. Alloca always returns a pointer in alloca address space, which may be different from the type defined by the language. For example, in C++ the auto variables are in the default address space. Therefore cast alloca to the expected address space when necessary.

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel updated this revision to Diff 95829. hfinkel added a comment. Updated per review comments (use only no_sanitize("tbaa") instead of adding no_sanitize_tbaa and don't touch freebsd for now). https://reviews.llvm.org/D32199 Files: include/clang/Basic/Sanitizers.def

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

rnk added a subscriber: chandlerc. rnk added a comment. In https://reviews.llvm.org/D32064#728683, @pcc wrote: > In https://reviews.llvm.org/D32064#728629, @rnk wrote: > > > In https://reviews.llvm.org/D32064#726861, @pcc wrote: > > > > > I think it would be better to move this logic to the

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#730716, @filcab wrote: > Missing a `sanitizer-ld.c` test for freebsd. Thanks for pointing this out. I'm going to remove the freebsd change for now. I suspect it works, but I've not tested it yet. Comment at:

r300767 - [sanitizer-coverage] deprecate -fsanitize-coverage=trace-bb

Author: kcc Date: Wed Apr 19 16:31:11 2017 New Revision: 300767 URL: http://llvm.org/viewvc/llvm-project?rev=300767=rev Log: [sanitizer-coverage] deprecate -fsanitize-coverage=trace-bb Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c Modified:

[PATCH] D32207: Corrrect warn_unused_result attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL300764: Corrrect warn_unused_result attribute (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D32207?vs=95807=95823#toc Repository: rL LLVM

r300764 - Corrrect warn_unused_result attribute

Author: erichkeane Date: Wed Apr 19 16:24:55 2017 New Revision: 300764 URL: http://llvm.org/viewvc/llvm-project?rev=300764=rev Log: Corrrect warn_unused_result attribute The original idea was that if the attribute on an operator, that the return-value unused-ness wouldn't matter. However, all

r300762 - Fix assertion failure in codegen on non-template deduction guide.

Author: rsmith Date: Wed Apr 19 16:15:45 2017 New Revision: 300762 URL: http://llvm.org/viewvc/llvm-project?rev=300762=rev Log: Fix assertion failure in codegen on non-template deduction guide. Added: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp Modified:

r300756 - [CodeGen] Use preincrement version of APInt::operator++ instead of postincrement to avoid creating and immediately discarding a temporary APInt.

Author: ctopper Date: Wed Apr 19 16:02:45 2017 New Revision: 300756 URL: http://llvm.org/viewvc/llvm-project?rev=300756=rev Log: [CodeGen] Use preincrement version of APInt::operator++ instead of postincrement to avoid creating and immediately discarding a temporary APInt. This is preparation

r300755 - Fix a leak in tools/driver/cc1as_main.cpp

Author: kcc Date: Wed Apr 19 15:57:13 2017 New Revision: 300755 URL: http://llvm.org/viewvc/llvm-project?rev=300755=rev Log: Fix a leak in tools/driver/cc1as_main.cpp Summary: For some reason, the asan bot has recently started reporting this leak even though it existed for ages. Reviewers: pcc

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730958, @dberlin wrote: > In https://reviews.llvm.org/D31885#730936, @rjmccall wrote: > > > In https://reviews.llvm.org/D31885#730920, @dberlin wrote: > > > > > Just so i understand: Ignoring everything else (we can't actually make >

[PATCH] D32243: Fix a leak in tools/driver/cc1as_main.cpp

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32243: Fix a leak in tools/driver/cc1as_main.cpp

kcc created this revision. For some reason, the asan bot has recently started reporting this leak even though it existed for ages. https://reviews.llvm.org/D32243 Files: tools/driver/cc1as_main.cpp Index: tools/driver/cc1as_main.cpp

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

malaperle-ericsson updated this revision to Diff 95811. malaperle-ericsson added a comment. Add test https://reviews.llvm.org/D32238 Files: clangd/Protocol.cpp test/clangd/completion.test Index: test/clangd/completion.test

[PATCH] D32234: [Clangd] Support Authority-less URIs

malaperle-ericsson updated this revision to Diff 95809. malaperle-ericsson added a comment. Add test https://reviews.llvm.org/D32234 Files: clangd/Protocol.cpp test/clangd/completion.test Index: test/clangd/completion.test

r300744 - [sanitizer-coverage] deprecate -fsanitize-coverage=8bit-counters

Author: kcc Date: Wed Apr 19 15:15:58 2017 New Revision: 300744 URL: http://llvm.org/viewvc/llvm-project?rev=300744=rev Log: [sanitizer-coverage] deprecate -fsanitize-coverage=8bit-counters Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c

[libcxx] r300743 - [libc++] Use _LIBCPP_ABI_MICROSOFT instead of _MSC_VER

Author: smeenai Date: Wed Apr 19 15:11:04 2017 New Revision: 300743 URL: http://llvm.org/viewvc/llvm-project?rev=300743=rev Log: [libc++] Use _LIBCPP_ABI_MICROSOFT instead of _MSC_VER _LIBCPP_ABI_MICROSOFT is more appropriate to use here, since the conditionals are controlling Microsoft

[PATCH] D32207: Corrrect warn_unused_result attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r300741 - Parse backend options during thinlto backend compile actions

Author: dblaikie Date: Wed Apr 19 15:08:21 2017 New Revision: 300741 URL: http://llvm.org/viewvc/llvm-project?rev=300741=rev Log: Parse backend options during thinlto backend compile actions Added: cfe/trunk/test/CodeGen/thinlto-backend-option.ll Modified:

[PATCH] D32207: Corrrect warn_unused_result attribute

erichkeane updated this revision to Diff 95807. erichkeane marked 3 inline comments as done. erichkeane added a comment. Added the tests, plus the two formatting changes. https://reviews.llvm.org/D32207 Files: include/clang/AST/Decl.h lib/AST/Decl.cpp test/SemaCXX/warn-unused-result.cpp

r300738 - [sanitizer-coverage] deprecate some of the stale coverage variants

Author: kcc Date: Wed Apr 19 14:57:16 2017 New Revision: 300738 URL: http://llvm.org/viewvc/llvm-project?rev=300738=rev Log: [sanitizer-coverage] deprecate some of the stale coverage variants Modified: cfe/trunk/docs/SanitizerCoverage.rst cfe/trunk/lib/Driver/SanitizerArgs.cpp

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. In https://reviews.llvm.org/D31885#730936, @rjmccall wrote: > In https://reviews.llvm.org/D31885#730920, @dberlin wrote: > > > Just so i understand: Ignoring everything else (we can't actually make > > likelyalias work, i think the code in the bugs makes that very

[PATCH] D32234: [Clangd] Support Authority-less URIs

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This is fine. Test case would be nice though. Repository: rL LLVM https://reviews.llvm.org/D32234 ___ cfe-commits mailing list

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

bkramer added a comment. A test case would be nice. Repository: rL LLVM https://reviews.llvm.org/D32238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730920, @dberlin wrote: > Just so i understand: Ignoring everything else (we can't actually make > likelyalias work, i think the code in the bugs makes that very clear), None of the code in the bugs I've seen makes that very clear,

[PATCH] D32207: Corrrect warn_unused_result attribute

aaron.ballman added a comment. I'm surprised this change didn't cause any other tests to need to be updated. A few small formatting nits and a request for another test, but otherwise looking good. Comment at: test/SemaCXX/warn-unused-result.cpp:166 +// C++ Methods should

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. In https://reviews.llvm.org/D31885#730909, @rjmccall wrote: > In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > > > > There was a deliberate decision to make TBAA conservative about type > > > punning in LLVM because, in practice, the strict form of TBAA you

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > > There was a deliberate decision to make TBAA conservative about type > > punning in LLVM because, in practice, the strict form of TBAA you think we > > should follow has proven to be a failed optimization

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. > Your proposal to we simply drop TBAA from all accesses related to unions is > extremely conservative. It means that an access through a union has to be > treated as potentially aliasing every other visible access, at least in terms > of their types. That level of

[PATCH] D31975: [Analyzer] Iterator Checkers

zaks.anna added a comment. @baloghadamsoftware Thanks for working on this! However, this patch is getting too big. Could you, please, split it into incremental patches so that it would be easier to review? More motivation of why this is very important is here

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730799, @dberlin wrote: > In https://reviews.llvm.org/D31885#730766, @rjmccall wrote: > > > In https://reviews.llvm.org/D31885#730539, @dberlin wrote: > > > > > In https://reviews.llvm.org/D31885#730072, @rjmccall wrote: > > > > > > >

[PATCH] D32207: Corrrect warn_unused_result attribute

erichkeane updated this revision to Diff 95797. erichkeane added a comment. As discussed, removed the exception for postfix operators. It seems like the right thing to do.I didn't add the [[nodiscard]] test, since it is the same intended behavior now. https://reviews.llvm.org/D32207 Files:

[PATCH] D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D32237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31885: Remove TBAA information from LValues representing union members

hfinkel added a comment. In https://reviews.llvm.org/D31885#730728, @kparzysz wrote: > In https://reviews.llvm.org/D31885#730038, @hfinkel wrote: > > > I'm somewhat concerned that this patch is quadratic in the AST. > > > I'd be happy to address this, but I'm not sure how. Memoizing results

[PATCH] D31885: Remove TBAA information from LValues representing union members

hfinkel added a comment. > There was a deliberate decision to make TBAA conservative about type punning > in LLVM because, in practice, the strict form of TBAA you think we should > follow has proven to be a failed optimization paradigm: it just leads users > to globally disable TBAA, which is

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

aaron.ballman added inline comments. Comment at: clang-tidy/utils/ASTUtils.cpp:28 +bool IsBinaryOrTernary(const Expr *expr) { + if (clang::isa(expr->IgnoreImpCasts()) || + clang::isa(expr->IgnoreImpCasts())) { Rather than call `IgnoreImpCasts()` three

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. In https://reviews.llvm.org/D31885#730766, @rjmccall wrote: > In https://reviews.llvm.org/D31885#730539, @dberlin wrote: > > > In https://reviews.llvm.org/D31885#730072, @rjmccall wrote: > > > > > Thanks for CC'ing me. There are two problems here. > > > > > > The second

[PATCH] D32144: [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679)

This revision was automatically updated to reflect the committed changes. Closed by commit rL300723: [Coverage] Don't emit mappings for functions in dependent contexts (fixes… (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D32144?vs=95513=95783#toc Repository: rL

r300723 - [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679)

Author: vedantk Date: Wed Apr 19 12:58:30 2017 New Revision: 300723 URL: http://llvm.org/viewvc/llvm-project?rev=300723=rev Log: [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679) The coverage implementation marks functions which won't be emitted as 'deferred',

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

rjmccall added a comment. The rule we actually want is that no reference to the block derived from the parameter value will survive after the function returns. You can include examples of things that would cause potential escapes, but trying to actually lock down the list seems ill-advised.

[PATCH] D32187: [CodeGen][ObjC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL300722: [Sema][ObjC] Disallow jumping into ObjC fast enumeration loops. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D32187?vs=95667=95781#toc Repository: rL LLVM

r300722 - [Sema][ObjC] Disallow jumping into ObjC fast enumeration loops.

Author: ahatanak Date: Wed Apr 19 12:54:08 2017 New Revision: 300722 URL: http://llvm.org/viewvc/llvm-project?rev=300722=rev Log: [Sema][ObjC] Disallow jumping into ObjC fast enumeration loops. rdar://problem/31635406 Differential Revision: https://reviews.llvm.org/D32187 Modified:

  1   2   >