[PATCH] D35824: [Sema] Implicitly apply the may_alias attribute to std::byte

rsmith added a comment. I would prefer to handle `std::byte` explicitly in the places where it matters, rather than adding an attribute to it and otherwise treating it like any other enumeration. We're going to want to be able to identify `std::byte` for warning emission and probably other

r308948 - [NFC] Use RAII to un-poison and then re-poison __VA_ARGS__

Author: faisalv Date: Mon Jul 24 20:15:36 2017 New Revision: 308948 URL: http://llvm.org/viewvc/llvm-project?rev=308948=rev Log: [NFC] Use RAII to un-poison and then re-poison __VA_ARGS__ - This will also be used for the forthcoming __VA_OPT__ feature approved for C++2a. - recommended by

Re: [PATCH v3] [PPC64]: Add support for Swift calling convention

On Mon, 2017-07-24 at 09:32 +0200, Ulrich Weigand wrote: > > Andrew Jeffery wrote on 24.07.2017 03:54:05: > > > > > > +  bool shouldPassIndirectlyForSwift(CharUnits totalSize, > > > > > +ArrayRef scalars, > > > > > +   

[PATCH] D35782: [C++2a][Preprocessor] Implement p0306 __VA_OPT__ (Comma omission and comma deletion)

rsmith added a comment. I think we need more consideration of what the end result of `__VA_OPT__` should be, and particularly how it should affect the `SourceLocation` data. It seems there are two models: 1. Model `__VA_OPT__` following the specification in the standard: form an imaginary

[PATCH] D35824: [Sema] Implicitly apply the may_alias attribute to std::byte

majnemer created this revision. std::byte, when defined as an enum, needs to be given special treatment with regards to its aliasing properties. An array of std::byte is allowed to be used as storage for other types. This fixes PR33916. https://reviews.llvm.org/D35824 Files:

r308938 - Debug Info: Avoid completing class types when a definition is in a module.

Author: adrian Date: Mon Jul 24 16:48:51 2017 New Revision: 308938 URL: http://llvm.org/viewvc/llvm-project?rev=308938=rev Log: Debug Info: Avoid completing class types when a definition is in a module. This patch adds an early exit to CGDebugInfo::completeClassData() when compiling with

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

thomasanderson added a comment. Hm.. is there anyone else who might be able to review? https://reviews.llvm.org/D35388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

ahatanak updated this revision to Diff 107993. ahatanak marked an inline comment as done. ahatanak added a comment. Herald added a subscriber: javed.absar. Address review comments. https://reviews.llvm.org/D32210 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

ahatanak marked an inline comment as done. ahatanak added a comment. In https://reviews.llvm.org/D32210#810508, @rjmccall wrote: > In https://reviews.llvm.org/D32210#810292, @ahatanak wrote: > > > Address review comments. > > > > - Allow attaching "noescape" to pointers other than block

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM. Perhaps there should be a test. Repository: rL LLVM https://reviews.llvm.org/D35820 ___ cfe-commits mailing list

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

phosek created this revision. Herald added a subscriber: dberris. This makes it possible to print the name of compiler-rt libraries by using simply clang -print-file-name=libclang_rt.${runtime}-${arch}.so same as other libraries, without having to know the details of the resource directory

[PATCH] D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option

szepet updated this revision to Diff 107976. szepet added a subscriber: cfe-commits. szepet added a comment. Accidentally left typo removed. OK so I am not sure but am I allowed to commit it again? I mean I made some notable changes. Not on the functionality of the feature but the stored data.

[PATCH] D34649: Remove addtional parameters in function std::next() and std::prev()

This revision was automatically updated to reflect the committed changes. Closed by commit rL308932: Remove addtional parameters in function std::next() and std::prev() (authored by rcraik). Changed prior to commit: https://reviews.llvm.org/D34649?vs=104030=107977#toc Repository: rL LLVM

[libcxx] r308932 - Remove addtional parameters in function std::next() and std::prev()

Author: rcraik Date: Mon Jul 24 15:17:05 2017 New Revision: 308932 URL: http://llvm.org/viewvc/llvm-project?rev=308932=rev Log: Remove addtional parameters in function std::next() and std::prev() Creating a function pointer with proper parameters pointing to std::next() or std::prev() should

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

t.p.northover updated this revision to Diff 107970. t.p.northover added a comment. Sorry, uploaded version with slightly wrong tests. https://reviews.llvm.org/D35817 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

t.p.northover created this revision. Herald added a subscriber: mcrosier. As part of preparing Clang for a C++14 default we noticed that code like this was accepted and did horrible things in C++11 or earlier modes (i.e. where 1.0if is a `_Complex float` rather than a UDL): std::complex var

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

rsmith added inline comments. Comment at: lib/AST/DeclCXX.cpp:1476 + + data().HasNonDeletedCopyOrMoveConstructor = !CopyOrMoveDeleted; } This is wrong. "Has a non-deleted copy or move constructor" is not the same thing as "does not have a deleted copy or move

[PATCH] D35426: [clang] Add abi-breaking-checks support to clang

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial added a comment. Ping. https://reviews.llvm.org/D35103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r308926 - Revert "[X86][InlineAsm][Ms Compatibility]Prefer variable name over a register when the two collides"

Author: rnk Date: Mon Jul 24 13:48:15 2017 New Revision: 308926 URL: http://llvm.org/viewvc/llvm-project?rev=308926=rev Log: Revert "[X86][InlineAsm][Ms Compatibility]Prefer variable name over a register when the two collides" This reverts r308867 and r308866. It broke the sanitizer-windows

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

aoli updated this revision to Diff 107954. aoli added a comment. Remove test code. Sorry for the noise. https://reviews.llvm.org/D33561 Files: cmake/caches/Android-stage2.cmake cmake/caches/Android.cmake Index: cmake/caches/Android.cmake

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

aoli updated this revision to Diff 107953. aoli added a comment. Remove test code. https://reviews.llvm.org/D33561 Files: cmake/caches/Android-stage2.cmake cmake/caches/Android.cmake Index: cmake/caches/Android.cmake === ---

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

aoli updated this revision to Diff 107951. aoli added a comment. Add `STAGE2_` prefix to pass stage2 variables. Add `ANDROID_RUNTIMES_BUILD_TYPE`, `ANDROID_RUNTIMES_ENABLE_ASSERTIONS`, and `ANDROID_BUILTINS_BUILD_TYPE`. https://reviews.llvm.org/D33561 Files:

[PATCH] D35483: clang-format: fix block OpeningLineIndex around preprocessor

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! Thanks! Please rebase with master before committing since we've been touching the same lines in `UnwrappedLineParser.cpp`. https://reviews.llvm.org/D35483

[PATCH] D35426: [clang] Add abi-breaking-checks support to clang

mgrang added a comment. Ping 2 for reviews please! https://reviews.llvm.org/D35426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r308918 - [clang-format] Reorder assignments, NFC

Author: krasimir Date: Mon Jul 24 12:52:49 2017 New Revision: 308918 URL: http://llvm.org/viewvc/llvm-project?rev=308918=rev Log: [clang-format] Reorder assignments, NFC Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp URL:

[PATCH] D35383: [coroutines] Add serialization/deserialization of coroutines

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Serialization/ASTWriterStmt.cpp:320-321 + +static void serializeSuspendExpr(ASTStmtWriter , ASTRecordWriter , +

[PATCH] D34992: Emit static constexpr member as available_externally definition

mehdi_amini added a comment. Weekly ping! (@rsmith) https://reviews.llvm.org/D34992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

NoQ accepted this revision. NoQ added a comment. These comments of mine are mostly random ideas for follow-up patches, i agree with Gabor this patch is good to land. https://reviews.llvm.org/D33672 ___ cfe-commits mailing list

[PATCH] D33900: Print registered targets in clang's version information

thakis added a comment. In https://reviews.llvm.org/D33900#819234, @dim wrote: > In https://reviews.llvm.org/D33900#818957, @thakis wrote: > > > Sorry, I just noticed this weeks later. Why are we adding this to > > `--version` instead of adding some new flag for printing this? When I pass > >

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

bruno added a comment. Hi Peter, Please add a testcase for this change, it also seems that you should update the comment. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [clang-tools-extra] r308738 - [clangd] Replace ASTUnit with manual AST management.

Hi Ilya, Your change seems to be causing the test 'clangd/definitions.test' to fail on the PS4 Windows bot. Can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11222 FAIL: Clang Tools :: clangd/definitions.test (11935 of 34225)

[PATCH] D33900: Print registered targets in clang's version information

dim added a comment. Also note that it is only added to the `--version` output, not the `-v` output (the former is really a "verbose" version of the latter): $ clang -v clang version 5.0.0 (trunk 308421) Target: x86_64-unknown-freebsd12.0 Thread model: posix InstalledDir:

[PATCH] D33900: Print registered targets in clang's version information

dim added a comment. In https://reviews.llvm.org/D33900#818957, @thakis wrote: > Sorry, I just noticed this weeks later. Why are we adding this to `--version` > instead of adding some new flag for printing this? When I pass `--version`, > I'm usually interested in clang's version and don't

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

bruno added a comment. Hi Strahinja, Does GCC already has a similar option? If so, does this share the same name? https://reviews.llvm.org/D34878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35661: [clang] Implement P0704: "Fixing const-qualified pointers to members"

AntonBikineev added a comment. ping.. https://reviews.llvm.org/D35661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

NoQ added a comment. Did the checker flag any intentionally underpopulated enums, eg. enum { Unset = -1 } NumberOfChickens = 15; (such code is bad, but it is not necessarily buggy - as far as i understand from the CERT rule, we're talking about "unspecified behavior" which some

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

NoQ added a comment. Yeah, this looks good. How does this compare to `alpha.core.BoolConversion`, should we maybe merge them? Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:84 +void EnumCastOutOfRangeChecker::reportWarning(CheckerContext ) const { + if

[PATCH] D35383: [coroutines] Add serialization/deserialization of coroutines

GorNishanov added a comment. @rsmith, ping. Would be good to get this in for clang 5.0 https://reviews.llvm.org/D35383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 updated this revision to Diff 107923. https://reviews.llvm.org/D27918 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp

r308899 - [CodeGen] Propagate dllexport to thunks

Author: smeenai Date: Mon Jul 24 10:16:27 2017 New Revision: 308899 URL: http://llvm.org/viewvc/llvm-project?rev=308899=rev Log: [CodeGen] Propagate dllexport to thunks Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

This revision was automatically updated to reflect the committed changes. Closed by commit rL308899: [CodeGen] Propagate dllexport to thunks (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D34972 Files: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 updated this revision to Diff 107921. https://reviews.llvm.org/D27918 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp

r308898 - AArch64 & ARM: move TargetInfo functions from .h to .cpp file. NFC.

Author: tnorthover Date: Mon Jul 24 10:06:23 2017 New Revision: 308898 URL: http://llvm.org/viewvc/llvm-project?rev=308898=rev Log: AArch64 & ARM: move TargetInfo functions from .h to .cpp file. NFC. Most of them are virtual anyway, and the few remaining ones can move to the .cpp for

RE: [PATCH] D34158: For standards compatibility, preinclude if the file is available

@jyknight I've removed the check on nostdinc. AFAIK, I've addressed all the feedback which I've received on the patch, is it OK to commit? --Melanie -Original Message- From: James Y Knight via Phabricator [mailto:revi...@reviews.llvm.org] Sent: Monday, July 10, 2017 11:57 AM To:

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 added a comment. Hello, After experimentation the following AST difference between the mock and the standard library implementation still stands (which necessitates the special handling of the complex manipulators). Example: // The different behaviour of the AST is illustrated on

Re: r308897 - Work around an MSVC2017 update 3 codegen bug.

We probably want this in 5.0. On Mon, Jul 24, 2017 at 12:54 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nico > Date: Mon Jul 24 09:54:11 2017 > New Revision: 308897 > > URL: http://llvm.org/viewvc/llvm-project?rev=308897=rev > Log: > Work around an MSVC2017

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

thakis closed this revision. thakis added a comment. r308897. https://reviews.llvm.org/D35757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r308897 - Work around an MSVC2017 update 3 codegen bug.

Author: nico Date: Mon Jul 24 09:54:11 2017 New Revision: 308897 URL: http://llvm.org/viewvc/llvm-project?rev=308897=rev Log: Work around an MSVC2017 update 3 codegen bug. C2017 update 3 produces a clang that crashes when compiling clang. Disabling optimizations for

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

yawanng added a comment. Ping https://reviews.llvm.org/D35372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D35757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35726: unguarded availability: add a fixit for the "annotate '...' with an availability attribute to silence" note

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this! Comment at: lib/Sema/SemaDeclAttr.cpp:7230 +return; + for (const auto : S.getPreprocessor().macros()) { +

[PATCH] D35787: [clang-tidy] Ignore vector in inefficient-vector-operation.

alexfh added a comment. In https://reviews.llvm.org/D35787#819007, @alexfh wrote: > Should we look at whether the size is statically known? (and small enough) https://reviews.llvm.org/D35787 ___ cfe-commits mailing list

[PATCH] D35787: [clang-tidy] Ignore vector in inefficient-vector-operation.

alexfh added a comment. Should we look at whether the size is statically known? https://reviews.llvm.org/D35787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. A few more nits. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h:68 bool IgnoreArrays; + // Whether fix-its for initializers of fundamental

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33900: Print registered targets in clang's version information

mehdi_amini added a comment. Here is the current output: clang version 5.0.0 Target: x86_64-apple-darwin16.6.0 Thread model: posix InstalledDir: /Users/mamini/projects/llvm/./clangDebug/bin Registered Targets: aarch64- AArch64 (little endian) aarch64_be - AArch64

[PATCH] D35790: [clang-tidy] Handle incomplete types in bugprone-undefined-memory-manipulation check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you for the fix! https://reviews.llvm.org/D35790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33900: Print registered targets in clang's version information

thakis added a comment. Sorry, I just noticed this weeks later. Why are we adding this to `--version` instead of adding some new flag for printing this? When I pass `--version`, I'm usually interested in clang's version and don't need a screenful of other information below it (which makes the

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35577#818936, @kparzysz wrote: > In https://reviews.llvm.org/D35577#817944, @echristo wrote: > > > "Should this just be part of the tuning for the hexagon backend and not > > options at all" > > > > > I don't think we need separate

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

sgundapa added a comment. If it is okay for the reviewers, I have no problem using -fno-jump-tables to this effect. I need to update https://reviews.llvm.org/D35578 and https://reviews.llvm.org/D35579 https://reviews.llvm.org/D35577 ___

Re: [PATCH] D24933: Enable configuration files in clang

I am thinking about reducing the patch further to leave only the ability to include config file when clang is called as `target-clang-drivermode`. It is still useful for cross compilation tasks because: - It is a convenient way to switch between supported targets, - SDK producer can ship compiler

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

kparzysz added a comment. In https://reviews.llvm.org/D35577#817944, @echristo wrote: > "Should this just be part of the tuning for the hexagon backend and not > options at all" The ultimate decision as to what kind of code to generate out of a switch statement belongs to the customer. The

[PATCH] D35794: [clang-format] Fix comment levels between '} else {' and PPDirective.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308882: [clang-format] Fix comment levels between '} else {' and PPDirective. (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D35794 Files:

r308883 - [OPENMP] Fix the restrictions for in_reduction clause.

Author: abataev Date: Mon Jul 24 07:52:13 2017 New Revision: 308883 URL: http://llvm.org/viewvc/llvm-project?rev=308883=rev Log: [OPENMP] Fix the restrictions for in_reduction clause. This patch allows to use in_reduction clause even if the innermost directive is not taskgroup. Modified:

r308882 - [clang-format] Fix comment levels between '} else {' and PPDirective.

Author: krasimir Date: Mon Jul 24 07:51:59 2017 New Revision: 308882 URL: http://llvm.org/viewvc/llvm-project?rev=308882=rev Log: [clang-format] Fix comment levels between '} else {' and PPDirective. Summary: This fixes a regression exposed by r307795 and rL308725 in which the level of a comment

[PATCH] D35794: [clang-format] Fix comment levels between '} else {' and PPDirective.

krasimir updated this revision to Diff 107904. krasimir added a comment. - Address review comments https://reviews.llvm.org/D35794 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTestComments.cpp Index:

[PATCH] D35794: [clang-format] Fix comment levels between '} else {' and PPDirective.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/UnwrappedLineParser.h:126 bool eof() const; - void nextToken(); + // LevelDifference is the difference of levels after and before this token.

[PATCH] D35726: unguarded availability: add a fixit for the "annotate '...' with an availability attribute to silence" note

arphaman marked 3 inline comments as done. arphaman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7230 +return; + for (const auto : S.getPreprocessor().macros()) { +if (M.first->getName() != "API_AVAILABLE") erik.pilkington

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35726: unguarded availability: add a fixit for the "annotate '...' with an availability attribute to silence" note

arphaman updated this revision to Diff 107903. arphaman marked 2 inline comments as done. arphaman added a comment. Addressed Erik's comments Repository: rL LLVM https://reviews.llvm.org/D35726 Files: lib/Sema/SemaDeclAttr.cpp test/FixIt/fixit-availability.c

[PATCH] D35794: [clang-format] Fix comment levels between '} else {' and PPDirective.

krasimir updated this revision to Diff 107901. krasimir added a comment. - Remove unused import https://reviews.llvm.org/D35794 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTestComments.cpp Index:

[PATCH] D35794: [clang-format] Fix comment levels between '} else {' and PPDirective.

krasimir updated this revision to Diff 107900. krasimir added a comment. - Switch to relative levels https://reviews.llvm.org/D35794 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTestComments.cpp Index:

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

sgundapa added a comment. > "Should this just be part of the tuning for the hexagon backend and not > options at all" This will be useful to all the backends/archs that support a tightly coupled memory. AFAIK, hexagon is not the only target that has a TCM. https://reviews.llvm.org/D35577

[libcxx] r308880 - make sure that we don't call basic_streambuf::gbump with a value bigger than INT_MAX, since it only takes an int. Related to, but not quite the same as PR33725

Author: marshall Date: Mon Jul 24 07:05:10 2017 New Revision: 308880 URL: http://llvm.org/viewvc/llvm-project?rev=308880=rev Log: make sure that we don't call basic_streambuf::gbump with a value bigger than INT_MAX, since it only takes an int. Related to, but not quite the same as PR33725

[PATCH] D35550: [mips] Add support for -m(no-)extern-data.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308879: [mips] Add support for -m(no-)extern-data. (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D35550?vs=107073=107897#toc Repository: rL LLVM

r308879 - [mips] Add support for -m(no-)extern-data.

Author: sdardis Date: Mon Jul 24 07:02:09 2017 New Revision: 308879 URL: http://llvm.org/viewvc/llvm-project?rev=308879=rev Log: [mips] Add support for -m(no-)extern-data. Add support for -m(no-)extern-data when using -mgpopt in the driver. It is enabled by default in the backend. Reviewers:

[PATCH] D35794: [clang-format] Fix comment levels between '} else {' and PPDirective.

krasimir updated this revision to Diff 107896. krasimir added a comment. - Make the closing brace use the same thing https://reviews.llvm.org/D35794 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h

[PATCH] D35735: [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

arphaman added a comment. You might also want to mention the fact that `-fsanitizer=vptr` requires `null` in the release notes. https://reviews.llvm.org/D35735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35736: [ubsan] -fsanitize=vptr now requires -fsanitize=null, update tests

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko updated this revision to Diff 107894. m.ostapenko added a comment. Rebased and removed a bunch of stale changes. Also added a check for goto's: if we see GotoStmt and have cfg-scopes == true, make badCFG = true and retry without scopes enabled. This check will be removed once

[PATCH] D35735: [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/CodeGenCXX/ubsan-devirtualized-calls.cpp:67 static_cast(badp)->f1(); //< No devirt, test 'badp isa Base1'. + // We were able to skip the null

[PATCH] D35796: [analyzer] Misused polymorphic object checker

rnkovacs created this revision. Herald added subscribers: baloghadamsoftware, xazax.hun, whisperity, mgorny. This check warns if a derived type object is deleted through a base pointer with a non-virtual destructor in its base class. It also places a note at the last point where the

[PATCH] D35483: clang-format: fix block OpeningLineIndex around preprocessor

Typz added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:464 + for (const auto : PPStack) { +hash_combine(h, i.Kind); +hash_combine(h, i.Line); krasimir wrote: > When I patch this, I get an `UnwrappedLineParser.cpp:457:16 error:

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

xazax.hun accepted this revision. xazax.hun added reviewers: dcoughlin, NoQ, a.sidorin. xazax.hun added a comment. This revision is now accepted and ready to land. Looks good to me. Did you run it on a codebase to check the results? https://reviews.llvm.org/D33672

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

gamesh411 marked 2 inline comments as done. gamesh411 added inline comments. Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:104 + // Check whether the cast type is an enum. + const auto ED = dyn_cast_or_null(T->getAsTagDecl()); + // If it is not an

r308867 - [X86][InlineAsm][Ms Compatibility]Prefer variable name over a register when the two collides

Author: coby Date: Mon Jul 24 00:06:37 2017 New Revision: 308867 URL: http://llvm.org/viewvc/llvm-project?rev=308867=rev Log: [X86][InlineAsm][Ms Compatibility]Prefer variable name over a register when the two collides On MS-style, the following snippet: int eax; __asm mov eax, ebx should

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic added a comment. ping https://reviews.llvm.org/D34878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

gamesh411 updated this revision to Diff 107886. gamesh411 added a comment. Fixed the naming convention issues. Also applied the suggested modifications inside the overridden checker method. https://reviews.llvm.org/D33672 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D35783: Ignore shadowing for declarations coming from within macros.

djasper added a comment. Like this? https://reviews.llvm.org/D35783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35783: Ignore shadowing for declarations coming from within macros.

djasper updated this revision to Diff 107885. djasper added a comment. Updated to be a bit more strict (warn if declarations from the same context get shadowed). https://reviews.llvm.org/D35783 Files: lib/Sema/SemaDecl.cpp test/SemaCXX/warn-shadow.cpp Index: test/SemaCXX/warn-shadow.cpp

[PATCH] D35783: Ignore shadowing for declarations coming from within macros.

klimek added a comment. Could we perhaps only suppress the warning when we shadow a variable within the same declcontext? Generally, with macros, shadowing local variables is more surprising. https://reviews.llvm.org/D35783 ___ cfe-commits

[PATCH] D35794: [clang-format] Fix comment levels between '} else {' and PPDirective.

krasimir created this revision. Herald added a subscriber: klimek. This fixes a regression exposed by r307795 and https://reviews.llvm.org/rL308725 in which the level of a comment line between '} else {' and a preprocessor directive is incorrectly set as the level of the '} else {' line. For

[PATCH] D34748: [clang-diff] improve mapping accuracy, HTML side-by-side diff.

arphaman added a comment. Some comments: - I had to make a couple of post-commit fixes to appease the buildbots when I committed your first patch, so it looks like this one doesn't apply cleanly anymore. Can you please rebase it? - Let's separate the addition of HTML output and the

[PATCH] D35783: Ignore shadowing for declarations coming from within macros.

djasper added a comment. I don't understand how my patch description says that. I am trying to be very explicit about that fact that it doesn't, see last paragraph. I have thought about what you are suggesting, but - A DeclContext doesn't have getEndLoc(). - The DeclContext NewDC here is

[PATCH] D35674: [analyzer] Treat C++ throw as sink during CFG-based suppress-on-sink.

NoQ updated this revision to Diff 107873. NoQ added a comment. Bring back the test that was accidentally lost. https://reviews.llvm.org/D35674 Files: lib/StaticAnalyzer/Core/BugReporter.cpp test/Analysis/max-nodes-suppress-on-sink.cpp Index: test/Analysis/max-nodes-suppress-on-sink.cpp

[PATCH] D35674: [analyzer] Treat C++ throw as sink during CFG-based suppress-on-sink.

NoQ updated this revision to Diff 107872. NoQ added a comment. Rebase. Turn the comment into a FIXME. https://reviews.llvm.org/D35674 Files: lib/StaticAnalyzer/Core/BugReporter.cpp test/Analysis/max-nodes-suppress-on-sink.cpp Index: test/Analysis/max-nodes-suppress-on-sink.cpp

[PATCH] D35673: [analyzer] A better CFG-based suppress-on-sink.

NoQ updated this revision to Diff 107871. NoQ added a comment. Reduce stack operations as Alexey suggested. https://reviews.llvm.org/D35673 Files: lib/StaticAnalyzer/Core/BugReporter.cpp test/Analysis/max-nodes-suppress-on-sink.c Index: test/Analysis/max-nodes-suppress-on-sink.c

[libunwind] r308871 - [libunwind] Handle .ARM.exidx tables without sentinel last entry

Author: chill Date: Mon Jul 24 02:19:32 2017 New Revision: 308871 URL: http://llvm.org/viewvc/llvm-project?rev=308871=rev Log: [libunwind] Handle .ARM.exidx tables without sentinel last entry UnwindCursor::getInfoFromEHABISection assumes the last entry in the index table never corresponds

[PATCH] D35051: [clang-tidy] Add bugprone-undefined-memory-manipulation check.

rnkovacs added a comment. Dependent types seem to work, but we did manage to produce a crash on incomplete types. I created https://reviews.llvm.org/D35790 for that. I hope it's the same problem you encountered. Repository: rL LLVM https://reviews.llvm.org/D35051

  1   2   >