[PATCH] D35137: [Driver] Honor -isysroot for Linux targets

yan12125 added a comment. Bump. Anything missing on this patch? Repository: rL LLVM https://reviews.llvm.org/D35137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

rjmccall added a comment. Could you just implement this in SimplifyLibCalls? I assume there's some way to fill in TargetLibraryInfo appropriately for a platform. Is that too late for your linking requirements? https://reviews.llvm.org/D36327

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

vsk created this revision. This patch teaches the preprocessor to report more precise source ranges for code that is skipped due to conditional directives. The new behavior includes the '#' from the opening directive and the full text of the line containing the closing directive in the skipped

[PATCH] D36641: [index] Update indexing to handle CXXDeductionGuideDecls properly

nathawes created this revision. CXXDeductionGuideDecls can't be referenced so there's no need to output a symbol occurrence for them. Also handle DeducedTemplateSpecializationTypeLocs in the TypeIndexer so we don't miss the symbol occurrences of the corresponding template decls.

Re: r310776 - PR34163: Don't cache an incorrect key function for a class if queried between

Hi Hans, I'd like to get this into Clang 5, but it's not entirely risk-free. Perhaps we could leave it in the tree for a little while and then merge if it seems OK? On 11 August 2017 at 18:46, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Aug 11

r310776 - PR34163: Don't cache an incorrect key function for a class if queried between

Author: rsmith Date: Fri Aug 11 18:46:03 2017 New Revision: 310776 URL: http://llvm.org/viewvc/llvm-project?rev=310776=rev Log: PR34163: Don't cache an incorrect key function for a class if queried between the class becoming complete and its inline methods being parsed. This replaces the hack of

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

On Fri, Aug 11, 2017 at 9:27 PM, Richard Smith wrote: > On 11 August 2017 at 16:51, Bruno Cardoso Lopes via cfe-commits > wrote: >> >> On Thu, Aug 10, 2017 at 5:36 PM, Richard Smith >> wrote: >> > On 10 August 2017 at

r310775 - Revert "[Modules] Prevent #import to reenter header if not building a module."

Author: bruno Date: Fri Aug 11 18:38:26 2017 New Revision: 310775 URL: http://llvm.org/viewvc/llvm-project?rev=310775=rev Log: Revert "[Modules] Prevent #import to reenter header if not building a module." This reverts commit r310605. Richard pointed out a better way to achieve this, which I'll

r310774 - Add a Dockerfile for clang-proto-fuzzer

Author: kcc Date: Fri Aug 11 18:27:10 2017 New Revision: 310774 URL: http://llvm.org/viewvc/llvm-project?rev=310774=rev Log: Add a Dockerfile for clang-proto-fuzzer Summary: Add a Dockerfile for clang-proto-fuzzer Reviewers: morehouse, vitalybuka Reviewed By: morehouse Subscribers: hintonda,

[PATCH] D35955: clang-format: Add preprocessor directive indentation

mzeren-vmw added a comment. Daniel's right. We need need substantially more tests! Comment at: docs/ClangFormatStyleOptions.rst:1199 + * ``PPDIS_AfterHash`` (in configuration: ``AfterHash``) +Indents directives after the hash, counting the hash as a column. +

Re: r310706 - [modules] Set the lexical DC for dummy tag decls that refer to hidden

On 11 August 2017 at 17:20, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Alex, > > On Fri, Aug 11, 2017 at 9:06 AM, Alex Lorenz via cfe-commits > wrote: > > Author: arphaman > > Date: Fri Aug 11 05:06:52 2017 > > New Revision: 310706 >

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

On 11 August 2017 at 16:51, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Aug 10, 2017 at 5:36 PM, Richard Smith > wrote: > > On 10 August 2017 at 10:42, Hans Wennborg via cfe-commits > > wrote: > >> > >>

Re: r310706 - [modules] Set the lexical DC for dummy tag decls that refer to hidden

Hi Alex, On Fri, Aug 11, 2017 at 9:06 AM, Alex Lorenz via cfe-commits wrote: > Author: arphaman > Date: Fri Aug 11 05:06:52 2017 > New Revision: 310706 > > URL: http://llvm.org/viewvc/llvm-project?rev=310706=rev > Log: > [modules] Set the lexical DC for dummy tag

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

rjmccall added inline comments. Comment at: lib/CodeGen/CGAtomic.cpp:696 +if (S != Default) + SI->addCase(Builder.getInt32(static_cast(S)), B); + t-tye wrote: > rjmccall wrote: > > t-tye wrote: > > > Is it documented in the SyncScope enum that the

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

hintonda added a comment. > I'd avoid such extra complexity, after all this is just an example. Understood... LGTM > BTW, my old svn (1.8.8, Ubuntu 14.04) does't have "info --show-item revision" Guess my new macbook pro spoiled me... https://reviews.llvm.org/D36635

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

On Thu, Aug 10, 2017 at 5:36 PM, Richard Smith wrote: > On 10 August 2017 at 10:42, Hans Wennborg via cfe-commits > wrote: >> >> Sounds good to me. >> >> Richard, what do you think? >> >> On Thu, Aug 10, 2017 at 9:38 AM, Bruno Cardoso Lopes >>

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839728, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 > > failed on r310718, please fix. > > > > > In

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

kcc added a comment. I'd avoid such extra complexity, after all this is just an example. One can force the full rebuild with --no-cache. It'll take just a bit more time since most of the time is consumed by the compiler builds. BTW, my old svn (1.8.8, Ubuntu 14.04) does't have "info

r310772 - Disabling openmp-offload.c on linux until it is stabilized on all local configurations.

Author: alekseyshl Date: Fri Aug 11 16:10:39 2017 New Revision: 310772 URL: http://llvm.org/viewvc/llvm-project?rev=310772=rev Log: Disabling openmp-offload.c on linux until it is stabilized on all local configurations. Differential revision: https://reviews.llvm.org/D29660 Modified:

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM other than suggested documentation and static_assert/unreachable comments. Comment at: lib/CodeGen/CGAtomic.cpp:696 +if (S != Default) +

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 > failed on r310718, please fix. In https://reviews.llvm.org/D29660#839647, @gtbercea wrote: > In

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

hintonda added a comment. You may want to add an ARG statement to force docker to rerun the svn commands each time you invoke `docker build`. Otherwise it will reuse the cache since docker only looks at the RUN text, not it's result. To get around that, you can add an `ARG REVISION`

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

aheejin added a comment. Looks OK to me, but I haven't worked on this part of code either, so I think someone else should approve it. https://reviews.llvm.org/D36555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

rjmccall added inline comments. Comment at: include/clang/Basic/SyncScope.h:46 + Scopes.push_back(SyncScope::OpenCLSubGroup); + return Scopes; +} t-tye wrote: > Should there be an assert/static_assert in case SyncScope enum grows due to > other languages? It

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 > failed on r310718, please fix. Couldn't fix/find the actual error so for now, just moving the flag patch tests to

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

kcc added inline comments. Comment at: tools/clang-fuzzer/Dockerfile:22 +# Get LLVM +RUN svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm +RUN cd llvm/tools && svn co http://llvm.org/svn/llvm-project/cfe/trunk clang -r $(cd ../ && svn info | grep Revision | awk '{print

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

kcc updated this revision to Diff 110810. kcc added a comment. fix 'svn co' command (apparently it did not matter though) https://reviews.llvm.org/D36635 Files: tools/clang-fuzzer/Dockerfile tools/clang-fuzzer/README.txt Index: tools/clang-fuzzer/README.txt

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

morehouse added inline comments. Comment at: tools/clang-fuzzer/Dockerfile:22 +# Get LLVM +RUN svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm +RUN cd llvm/tools && svn co http://llvm.org/svn/llvm-project/cfe/trunk clang -r $(cd ../ && svn info | grep Revision | awk

[libcxx] r310760 - [libcxx] [test] Rename __x to x. NFCI.

Author: stl_msft Date: Fri Aug 11 13:54:06 2017 New Revision: 310760 URL: http://llvm.org/viewvc/llvm-project?rev=310760=rev Log: [libcxx] [test] Rename __x to x. NFCI. This improves readability and (theoretically) improves portability, as __ugly names are reserved. Modified:

[libcxx] r310761 - [libcxx] [test] Rename _Up to U, etc. NFCI.

Author: stl_msft Date: Fri Aug 11 13:54:09 2017 New Revision: 310761 URL: http://llvm.org/viewvc/llvm-project?rev=310761=rev Log: [libcxx] [test] Rename _Up to U, etc. NFCI. This improves readability and (theoretically) improves portability, as _Ugly names are reserved. This performs additional

[libcxx] r310758 - [libcxx] [test] Rename _Tp to T. NFCI.

Author: stl_msft Date: Fri Aug 11 13:53:53 2017 New Revision: 310758 URL: http://llvm.org/viewvc/llvm-project?rev=310758=rev Log: [libcxx] [test] Rename _Tp to T. NFCI. This improves readability and (theoretically) improves portability, as _Ugly names are reserved. Modified:

[libcxx] r310759 - [libcxx] [test] Rename __c to ch. NFCI.

Author: stl_msft Date: Fri Aug 11 13:54:01 2017 New Revision: 310759 URL: http://llvm.org/viewvc/llvm-project?rev=310759=rev Log: [libcxx] [test] Rename __c to ch. NFCI. This improves readability and (theoretically) improves portability, as __ugly names are reserved. Modified:

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

t-tye added inline comments. Comment at: include/clang/Basic/SyncScope.h:46 + Scopes.push_back(SyncScope::OpenCLSubGroup); + return Scopes; +} Should there be an assert/static_assert in case SyncScope enum grows due to other languages?

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#839275, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#839209, @gtbercea wrote: > > > I have re-enabled the previous offloading tests and moved the new GPU > > offloading tests to a new file which is disabled for linux (for

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 110799. JonasToth marked an inline comment as done. JonasToth added a comment. address review comments from aaron https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth marked 5 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:230 +<< BadOwnerInitialization->getSourceRange(); +// FIXME FixitHint to rewrite the type if possible +

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Hi, I've noticed that the code in compiler-rt/lib/builtins/gcc_personality_v0.c refers to _Unwind_Exception as "struct _Unwind_Exception". With this change, it is not a struct anymore on ARM. Should that code be fixed, or is it a problem in this change?

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

kcc created this revision. Add a Dockerfile for clang-proto-fuzzer https://reviews.llvm.org/D36635 Files: tools/clang-fuzzer/Dockerfile tools/clang-fuzzer/README.txt Index: tools/clang-fuzzer/README.txt === ---

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 failed on r310718, please fix. Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:188 +diag(OwnerAssignment->getLocStart(), + "assigning neither an owner nor a recognized resource") +<< SourceRange(OwnerAssignment->getLocStart(),

[PATCH] D36572: Implemented P0409R2 - Allow lambda capture [=, this]

hamzasood updated this revision to Diff 110776. hamzasood added a comment. @rjmccall The warning is emitted, but you're right that there's no test to ensure that actually happens; test/CXX/expr/expr.prim/expr.prim.lambda/p8.cpp used Wno-c++2a-extensions to suppress the warning. I've changed it

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

rjmccall added inline comments. Comment at: include/clang/Basic/SyncScope.h:47 + return Scopes; +} + You could just return an ArrayRef to a static const array. Comment at: lib/CodeGen/CGAtomic.cpp:687 + + auto *SC =

[PATCH] D36572: Implemented P0409R2 - Allow lambda capture [=, this]

rjmccall added inline comments. Comment at: test/FixIt/fixit-cxx0x.cpp:57 (void)[&, , ]{}; // expected-error 2{{'&' cannot precede a capture when the capture default is '&'}} - (void)[=, this]{ this->g(5); }; // expected-error{{'this' cannot be explicitly captured}}

r310733 - Add -fsanitize=fuzzer-no-link flag to the driver.

Author: george.karpenkov Date: Fri Aug 11 10:22:58 2017 New Revision: 310733 URL: http://llvm.org/viewvc/llvm-project?rev=310733=rev Log: Add -fsanitize=fuzzer-no-link flag to the driver. The flag will perform instrumentation necessary to the fuzzing, but will NOT link libLLVMFuzzer.a library.

[PATCH] D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module.

yawanng updated this revision to Diff 110758. https://reviews.llvm.org/D35362 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecAcceptCheck.cpp clang-tidy/android/CloexecAcceptCheck.h docs/ReleaseNotes.rst

[PATCH] D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module.

yawanng updated this revision to Diff 110755. https://reviews.llvm.org/D35363 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecAccept4Check.cpp clang-tidy/android/CloexecAccept4Check.h docs/ReleaseNotes.rst

[PATCH] D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module.

yawanng added inline comments. Comment at: clang-tidy/android/CloexecCheck.h:91 + /// Helper function to get the spelling of a particular argument. + StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult , + int N) const;

[PATCH] D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module.

yawanng updated this revision to Diff 110753. yawanng marked an inline comment as done. https://reviews.llvm.org/D35364 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h

[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

yawanng updated this revision to Diff 110752. https://reviews.llvm.org/D35365 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecEpollCreate1Check.cpp clang-tidy/android/CloexecEpollCreate1Check.h docs/ReleaseNotes.rst

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

yawanng updated this revision to Diff 110750. yawanng marked 2 inline comments as done. https://reviews.llvm.org/D35368 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecInotifyInit1Check.cpp

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839209, @gtbercea wrote: > I have re-enabled the previous offloading tests and moved the new GPU > offloading tests to a new file which is disabled for linux (for now). > > 310718 > > Alex thanks so much for the logs, they have been

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

yawanng updated this revision to Diff 110751. https://reviews.llvm.org/D35367 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecEpollCreateCheck.cpp clang-tidy/android/CloexecEpollCreateCheck.h docs/ReleaseNotes.rst

[PATCH] D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

yawanng updated this revision to Diff 110749. yawanng marked an inline comment as done. https://reviews.llvm.org/D35370 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecInotifyInitCheck.cpp

[clang-tools-extra] r310732 - Enable exceptions for this test case to speculatively fix the build bots.

Author: aaronballman Date: Fri Aug 11 09:46:45 2017 New Revision: 310732 URL: http://llvm.org/viewvc/llvm-project?rev=310732=rev Log: Enable exceptions for this test case to speculatively fix the build bots. Hopefully corrects:

Re: r310704 - Revert r302670 for the upcoming 5.0.0 release

Merged to 5.0 in r310728. On Fri, Aug 11, 2017 at 4:39 AM, Stefan Maksimovic via cfe-commits wrote: > Author: smaksimovic > Date: Fri Aug 11 04:39:07 2017 > New Revision: 310704 > > URL: http://llvm.org/viewvc/llvm-project?rev=310704=rev > Log: > Revert r302670 for

[clang-tools-extra] r310727 - Add hicpp-exception-baseclass to the HIC++ module.

Author: aaronballman Date: Fri Aug 11 09:31:51 2017 New Revision: 310727 URL: http://llvm.org/viewvc/llvm-project?rev=310727=rev Log: Add hicpp-exception-baseclass to the HIC++ module. This enforces that throwing an exception in C++ requires that exception to inherit from std::exception. Patch

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

mikhail.ramalho added a comment. Should I update the other tests in QualTypeNamesTest.cpp to use multiline strings as well? https://reviews.llvm.org/D36610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes

ruiu added a comment. Hans already merged it in r310723. Repository: rL LLVM https://reviews.llvm.org/D36567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

saugustine accepted this revision. saugustine added a comment. This revision is now accepted and ready to land. This is a good change as far as functionality, but I defer to others on the style and other details. https://reviews.llvm.org/D36610

[PATCH] D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes

ruiu added a comment. Yuka, You seem to have committed a release note for 5.0 to SVN trunk. What you should've done is to do that to the 5.0 branch. I'll correct the error for you. Repository: rL LLVM https://reviews.llvm.org/D36567 ___

Re: r310700 - [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes

Merged to 5.0 in r310723. Thanks! On Fri, Aug 11, 2017 at 2:44 AM, Yuka Takahashi via cfe-commits wrote: > Author: yamaguchi > Date: Fri Aug 11 02:44:42 2017 > New Revision: 310700 > > URL: http://llvm.org/viewvc/llvm-project?rev=310700=rev > Log: >

Re: r310694 - Implement latest feature test macro recommendations, P0096R4.

Thanks! I've merged r309054 in r310721 to make it apply cleanly, and this one in r310722. On Thu, Aug 10, 2017 at 8:42 PM, Richard Smith wrote: > Hi Hans, this should go onto the Clang 5 branch. Thanks! > > On 10 August 2017 at 20:39, Richard Smith via cfe-commits >

Re: r310692 - PR33850: Update cxx_dr_status for Clang 5 branch.

Merged to 5.0 in r310720. On Thu, Aug 10, 2017 at 8:14 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Aug 10 20:14:20 2017 > New Revision: 310692 > > URL: http://llvm.org/viewvc/llvm-project?rev=310692=rev > Log: > PR33850: Update cxx_dr_status

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. I have re-enabled the previous offloading tests and moved the new GPU offloading tests to a new file which is disabled for linux (for now). 310718 Alex thanks so much for the logs, they have been very useful to understand what's going on. Aleksey, I have since tried

Re: r310691 - PR33489: A function-style cast to a deduced class template specialization type is type-dependent if it can't be resolved due to a type-dependent argument.

Thanks! r310719. On Thu, Aug 10, 2017 at 7:08 PM, Richard Smith wrote: > Hi Hans, this fixes a bug you wanted to treat as a 5.0 release blocker, so > should be ported to the branch :) > > On 10 August 2017 at 19:04, Richard Smith via cfe-commits >

[PATCH] D36186: [clang-diff] Improve and test getNodeValue

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:428 +Value += getRelativeName(V) + "(" + V->getType().getAsString(TypePP) + ")"; +if (auto *C = dyn_cast(D)) { + for (auto *Init : C->inits()) { It looks like you're doing a

[PATCH] D35948: [CommonOptionsParser] Expose ArgumentsAdjustingCompilationDatabase

arphaman added a reviewer: klimek. arphaman added a comment. @klimek Ping. https://reviews.llvm.org/D35948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36184: [clang-diff] Filter AST nodes

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/Tooling/clang-diff-ast.cpp:68 +// nodes from other files are excluded +// CHECK-NOT {{.}} +#include "clang-diff-ast.cpp" johannes

r310715 - [mips] Add missing mips-registered-target to mips test.

Author: sdardis Date: Fri Aug 11 08:23:23 2017 New Revision: 310715 URL: http://llvm.org/viewvc/llvm-project?rev=310715=rev Log: [mips] Add missing mips-registered-target to mips test. Modified: cfe/trunk/test/Driver/mips-abi.c Modified: cfe/trunk/test/Driver/mips-abi.c URL:

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 110731. JonasToth added a comment. remove manual source range creation, where i forgot it before https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:188 +diag(OwnerAssignment->getLocStart(), + "assigning neither an owner nor a recognized resource") +<<

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 110730. JonasToth marked 6 inline comments as done. JonasToth added a comment. - order release notes - address aarons comments - adjust diagnostic for function arguments https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D36315: [mips] Support implicit gpopt with N64 when using -fno-pic

sdardis added a comment. Thanks for the review and spotting this bug that lead me to finding the other bug. Repository: rL LLVM https://reviews.llvm.org/D36315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36315: [mips] Support implicit gpopt with N64 when using -fno-pic

This revision was automatically updated to reflect the committed changes. Closed by commit rL310714: [mips] Support implicit gpopt with N64 when using -fno-pic (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D36315 Files: cfe/trunk/lib/Driver/ToolChains/Clang.cpp

r310714 - [mips] Support implicit gpopt with N64 when using -fno-pic

Author: sdardis Date: Fri Aug 11 08:01:34 2017 New Revision: 310714 URL: http://llvm.org/viewvc/llvm-project?rev=310714=rev Log: [mips] Support implicit gpopt with N64 when using -fno-pic As clang defaults to -mno-abicalls when using -fno-pic for N64, implicitly use -mgpopt in that case.

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed. Follow @atanasyan 's suggestion and post a patch that renames that enum along with other changes. One comment inlined. Comment at:

[PATCH] D35624: Removal of microMIPS64R6

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. One nit inlined, you can address it when committing. Comment at: Basic/Targets/Mips.cpp:206 bool MipsTargetInfo::validateTarget(DiagnosticsEngine ) const { + if

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

bcraig added a comment. ping https://reviews.llvm.org/D32411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34170: [libcxx] Moving compiler specific test infrastructure to compiler.py

bcraig added a comment. ping https://reviews.llvm.org/D34170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module.

hokein added inline comments. Comment at: clang-tidy/android/CloexecCheck.h:91 + /// Helper function to get the spelling of a particular argument. + StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult , + int N) const;

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

hokein added inline comments. Comment at: clang-tidy/android/CloexecInotifyInit1Check.cpp:28 +void CloexecInotifyInit1Check::check(const MatchFinder::MatchResult ) { + insertMacroFlag(Result, "IN_CLOEXEC", /*ArgPos=*/0); +} nit: `/*MarcoFlag=*/`

[PATCH] D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

hokein added inline comments. Comment at: clang-tidy/android/CloexecInotifyInitCheck.cpp:27 + replaceFunc(Result, + "prefer inotify_init() to inotify_init1() " + "because inotify_init1() allows IN_CLOEXEC", The parameter 2 and 3 are

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

yaxunl added a comment. John, do you have any comments? Thanks. https://reviews.llvm.org/D36327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36614: [clang-format] Refine trailing comment detection

krasimir created this revision. Herald added a subscriber: klimek. This patch fixes an non-idempotency issue connected with detection of trailing comments. Consider formatting the following code with column limit at `V`: V const /* comment comment */ A = B; The comment

[PATCH] D36397: [clangd] Fixed a data race.

ilya-biryukov added a comment. A follow-up after discussion offline: we should make an attempt to simplify the threading code in `ClangdUnit.h` by moving the async worker loop of `CppFile` into the class itself, rather than relying on external scheduling to do the right thing. @klimek, are

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc planned changes to this revision. mibintc added a comment. Need TO FIX: We should be stripping the new arg as well: add "-fsystem-include-if-exists" argument to the list of include things in the skipArgs() function in lib/Driver/Job.cpp https://reviews.llvm.org/D34158

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Well, these are ASAN tests, I'm not sure how that would interact with Valgrind. Anyway, I'll try to reproduce the environment, I'm guessing it would be best to catch this in gdb so I can actually see what's going on. On 11 August 2017 at 15:21, Vassil Vassilev wrote: >

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

That's really strange. It looks like some random behavior. Did you run some memory checker like valgrind? Do the environment provided by the test runner and yours match? Sent from my phone. Please excuse my brevity. > On 11 Aug 2017, at 15:58, Diana Picus wrote: > >

[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

alexfh added a comment. In https://reviews.llvm.org/D35941#838633, @rsmith wrote: > In https://reviews.llvm.org/D35941#823524, @alexfh wrote: > > > IIUC, most cases where -Wshadow warnings are issued is when a declaration > > from an enclosing scope would be accessible if there was no

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:149 + // Deletion of non-owners, with `delete variable;` + if (DeletedVariable != nullptr) { +assert(DeleteStmt != nullptr && aaron.ballman wrote: > Can

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

arphaman added inline comments. Comment at: unittests/Tooling/QualTypeNamesTest.cpp:247 + "struct (anonymous struct at input.cc:1:1)"; + PrintingPolicy.runOver( + "struct\n" You should probably use multiline string here, i.e. R(" ... ")

[PATCH] D36611: Implemented P0683R1 - Default member initializers for bit-fields

hamzasood created this revision. This patch implements P0683R1 . Member initialisers are allowed pre-C++11 as an extension. So I've also allowed bitfield member initialisers pre-C++2a as an extension (with appropriate warnings) for consistency.

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Hi again, I finally got the debug build, but unfortunately the stack traces that the tests print look the same. My suspicion is that this is because the addresses printed by the tests are funny (i.e. odd numbers instead of divisible by 4). I tried to follow those addresses in an objdump of the

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

mikhail.ramalho created this revision. Herald added a subscriber: klimek. In our user case, we need to generate unique names for every tag, including anonymous structs/unions. This adds a custom PrintingPolicy option to getFullyQualifiedName and the test case shows that different names are

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:149 + // Deletion of non-owners, with `delete variable;` + if (DeletedVariable != nullptr) { +assert(DeleteStmt != nullptr && Can `DeletedVariable` ever be

[clang-tools-extra] r310707 - Implement hicpp-braces-around-statements as an alias to readability-braces-around-statements.

Author: aaronballman Date: Fri Aug 11 05:12:36 2017 New Revision: 310707 URL: http://llvm.org/viewvc/llvm-project?rev=310707=rev Log: Implement hicpp-braces-around-statements as an alias to readability-braces-around-statements. Patch by Jonas Toth. Added:

Re: r310706 - [modules] Set the lexical DC for dummy tag decls that refer to hidden

Hi Hans & Richard, Is it possible to get this merged into LLVM 5.0? Cheers, Alex On 11 August 2017 at 13:06, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Fri Aug 11 05:06:52 2017 > New Revision: 310706 > > URL:

r310706 - [modules] Set the lexical DC for dummy tag decls that refer to hidden

Author: arphaman Date: Fri Aug 11 05:06:52 2017 New Revision: 310706 URL: http://llvm.org/viewvc/llvm-project?rev=310706=rev Log: [modules] Set the lexical DC for dummy tag decls that refer to hidden declarations that are made visible after the dummy is parsed and ODR verified Prior to this

r310704 - Revert r302670 for the upcoming 5.0.0 release

Author: smaksimovic Date: Fri Aug 11 04:39:07 2017 New Revision: 310704 URL: http://llvm.org/viewvc/llvm-project?rev=310704=rev Log: Revert r302670 for the upcoming 5.0.0 release This is causing failures when compiling clang with -O3 as one of the structures used by clang is passed by value and

r310702 - Revert r310057

Author: smaksimovic Date: Fri Aug 11 04:03:54 2017 New Revision: 310702 URL: http://llvm.org/viewvc/llvm-project?rev=310702=rev Log: Revert r310057 Bring back changes which r304953 introduced since they were in fact not the cause of failures described in r310057 commit message. Added:

  1   2   >