[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik updated this revision to Diff 128491. nik added a comment. Had to rebase. Repository: rC Clang https://reviews.llvm.org/D40072 Files: include/clang-c/Index.h test/Index/print-type-size.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. New year, new hope - ping :) https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: trivial_abi

> On Jan 2, 2018, at 10:43 PM, Richard Smith wrote: > > On 2 January 2018 at 19:02, John McCall via cfe-commits > > wrote: > >> On Jan 2, 2018, at 9:15 PM, Akira Hatanaka >

[libcxx] r321689 - Mark LWG2824 as complete. We already did it, but I added a test to be sure

Author: marshall Date: Tue Jan 2 20:37:30 2018 New Revision: 321689 URL: http://llvm.org/viewvc/llvm-project?rev=321689=rev Log: Mark LWG2824 as complete. We already did it, but I added a test to be sure Modified: libcxx/trunk/test/std/containers/sequences/list/list.ops/sort_comp.pass.cpp

[libcxx] r321687 - Mark issue #2866 as "nothing to do"

Author: marshall Date: Tue Jan 2 19:43:32 2018 New Revision: 321687 URL: http://llvm.org/viewvc/llvm-project?rev=321687=rev Log: Mark issue #2866 as "nothing to do" Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

Re: trivial_abi

On 2 January 2018 at 19:02, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: > > > > On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On 2 January 2018

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

thakis added a comment. FWIW we build with -Wall -Wextra and we disable this warning since it's in our (chromium's) opinion not useful on large real-world code. So I'm not sure it should be in -Wextra. (Also, I believe clang has historically tried to keep -Wall and -Wextra pretty similar?)

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:239 + bit IncludeC = includeC; +} I have no objection to allowing ObjC attributes to be spelled in [[clang::objc_whatever]] style. We can debate giving them a more appropriate standard

Re: trivial_abi

> On Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: > > > >> On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits >> > wrote: >> >> On 2 January 2018 at 15:33, John McCall via cfe-commits >>

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast added a comment. I'll commit with `cp -R` tomorrow then; thanks. Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r321686 - PR35697: look at the first declaration when determining whether a function or

Author: rsmith Date: Tue Jan 2 18:34:35 2018 New Revision: 321686 URL: http://llvm.org/viewvc/llvm-project?rev=321686=rev Log: PR35697: look at the first declaration when determining whether a function or variable is extern "C" in linkage calculations. Modified: cfe/trunk/lib/AST/Decl.cpp

[libcxx] r321685 - Implement p0258r2: has_unique_object_representations

Author: marshall Date: Tue Jan 2 18:32:28 2018 New Revision: 321685 URL: http://llvm.org/viewvc/llvm-project?rev=321685=rev Log: Implement p0258r2: has_unique_object_representations Added:

Re: trivial_abi

> On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits > wrote: > > On 2 January 2018 at 15:33, John McCall via cfe-commits > > wrote: > Hey, Richard et al. Akira and I were talking about the

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticGroups.td:438 def StrncatSize : DiagGroup<"strncat-size">; +def TautologicalTypeLimitCompare :

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

vsapsai added a comment. A few approaches that I've considered but decided not to pursue: - Change code completion in comment so we don't exit file early but more gracefully. Decided not to do it because I believe early exit is important for code completion performance. And

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

vsapsai created this revision. vsapsai added reviewers: akyrtzi, doug.gregor. Herald added subscribers: kbarton, nemanjai. This fixes PR32732 by updating CurLexerKind to reflect available lexers. We were hitting null pointer in Preprocessor::Lex because CurLexerKind was CLK_Lexer but CurLexer was

Re: trivial_abi

On 2 January 2018 at 15:33, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hey, Richard et al. Akira and I were talking about the right ABI rule for > deciding can-pass-in-registers-ness for structs in the presence of > trivial_abi, and I think I like Akira's approach but

[PATCH] D41151: [analyzer] Adding LoopContext and improve loop modeling

NoQ added a comment. //*asked stuff in https://reviews.llvm.org/D39398 regarding how indirect gotos are supported*// https://reviews.llvm.org/D41151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases

NoQ added a comment. Herald added subscribers: dkrupp, a.sidorin, rnkovacs. These CFGs make perfect sense to me so far, and i guess this is a must-have. Thank you! > Note: In case of IndirectGotoStmt, it could happen that we generate LoopExit > elements even for loops which is not exited by

[PATCH] D41562: [CodeGen] Generate TBAA info on passing arguments and returning values

rjmccall added a comment. Aren't these always loads and stores from allocas? I would expect TBAA to be useless here because it's always strictly less informative than basic-AA, which knows that the access doesn't alias with anything. Repository: rL LLVM https://reviews.llvm.org/D41562

[PATCH] D41660: [cmake] Add new linux toolchain file

hintonda abandoned this revision. hintonda added a comment. Thanks for all your suggestions. Planning to rework and move the toolchain specific part to llvm/cmake/platform and abandon the cache part altogether. Repository: rC Clang https://reviews.llvm.org/D41660

[PATCH] D41547: [CodeGen] Fix TBAA info for accesses to members of base classes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Ok. Repository: rL LLVM https://reviews.llvm.org/D41547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

rjmccall added a comment. You're sure you just want a single TBAA tag on memcpy's? I would think that it might be useful to encode separate path information for the two operands. https://reviews.llvm.org/D41539 ___ cfe-commits mailing list

[PATCH] D40398: Remove ValueDependent assertions on ICE checks.

mattd abandoned this revision. mattd added a comment. Abandoning as this is no longer a problem with release builds. https://reviews.llvm.org/D40398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer

NoQ added a comment. (edited my comment: fixed the suggested change to mention the right block) https://reviews.llvm.org/D41150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer

NoQ added a comment. Because it wasn't immediately obvious to me how to apply both this patch and https://reviews.llvm.org/D39398 (there are a couple of minor conflicts between them), i wanted to post a few pictures for the reference, because `debug.ViewCFG` graphs are much easier to

[PATCH] D41545: Replace cp -a in various Clang tests

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Hi Hubert, Thanks for fixing this. `cp -R` is sufficient IMO. LGTM Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits

r321683 - Fix and simplify handling of return type for (generic) lambda conversion function to function pointer.

Author: rsmith Date: Tue Jan 2 15:52:42 2018 New Revision: 321683 URL: http://llvm.org/viewvc/llvm-project?rev=321683=rev Log: Fix and simplify handling of return type for (generic) lambda conversion function to function pointer. Previously, we would: * compute the type of the conversion

trivial_abi

Hey, Richard et al. Akira and I were talking about the right ABI rule for deciding can-pass-in-registers-ness for structs in the presence of trivial_abi, and I think I like Akira's approach but wanted to get your input. The current definition in Itanium is: non-trivial for the purposes of

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

efriedma added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2252 + TM.tm_isdst = -1; + mktime(); + Opts.FixedDateTime = TM; Does using mktime like this depend on the local timezone? https://reviews.llvm.org/D23934

r321682 - [analyzer] do not crash with assertion on processing locations of bodyfarmed functions

Author: george.karpenkov Date: Tue Jan 2 15:05:47 2018 New Revision: 321682 URL: http://llvm.org/viewvc/llvm-project?rev=321682=rev Log: [analyzer] do not crash with assertion on processing locations of bodyfarmed functions This addresses an issue introduced in r183451: since

[PATCH] D41680: [analyzer] do not crash with assertion on processing locations of bodyfarmed functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC321682: [analyzer] do not crash with assertion on processing locations of bodyfarmed… (authored by george.karpenkov, committed by ). Repository: rC Clang https://reviews.llvm.org/D41680 Files:

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

vsapsai added a comment. Cannot tell for sure from code but looks like we are still emitting `-Wdate-time` "expansion of date or time macro is not reproducible" with this flag. At least it's not covered by tests. And another similar warning is `-Wpch-date-time`.

[PATCH] D33563: Track whether a unary operation can overflow

efriedma added inline comments. Comment at: include/clang/AST/Expr.h:1728 + UnaryOperator(Expr *input, Opcode opc, QualType type, ExprValueKind VK, +ExprObjectKind OK, SourceLocation l, bool CanOverflow = false) + : Expr(UnaryOperatorClass, type, VK, OK,

[PATCH] D41680: [analyzer] do not crash with assertion on processing locations of bodyfarmed functions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yep, so it still doesn't answer if `removePiecesWithInvalidLocations()` was dead code to begin with (considering that the assertion in `adjustCallLocations()` says that everything but call

[PATCH] D41680: [analyzer] do not crash with assertion on processing locations of bodyfarmed functions

george.karpenkov added a comment. The error is triggered when analyzer finds a bug *inside* the callable captured by the body farm. Probably we didn't see the crash in the wild because either a) the clang build did not have assertions enabled or b) the HTML output was not enabled and the bug

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

lebedev.ri updated this revision to Diff 128470. lebedev.ri added a comment. Actually update the diagnostic flag :) I'm going to hold off committing just yet, and wait for @rsmith to sign off. Repository: rC Clang https://reviews.llvm.org/D41512 Files:

[libunwind] r321680 - Reland [PPC64] Port to ppc64le - initial version

Author: mstorsjo Date: Tue Jan 2 14:11:30 2018 New Revision: 321680 URL: http://llvm.org/viewvc/llvm-project?rev=321680=rev Log: Reland [PPC64] Port to ppc64le - initial version Initial working version of libunwind for PowerPC 64. Tested on little-endian ppc64 host only. Based on the existing

[libunwind] r321679 - Don't use a strict larger-than comparison in the check_fit/does_fit static assert

Author: mstorsjo Date: Tue Jan 2 14:11:22 2018 New Revision: 321679 URL: http://llvm.org/viewvc/llvm-project?rev=321679=rev Log: Don't use a strict larger-than comparison in the check_fit/does_fit static assert For builds that only target one architecture, this was required to be an exact

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

rsmith added a comment. This is looking like a really good start; we'll still want to do something about partial specializations, but this should already help a lot. Can you produce some sample performance numbers for this change? This is replacing a linear-time algorithm (with a high

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

timshen added a comment. In https://reviews.llvm.org/D41386#966189, @mstorsjo wrote: > In https://reviews.llvm.org/D41386#966187, @timshen wrote: > > > The static_assert on line 1189 fails with the following build on x86: > > > > cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON > >

[libunwind] r321678 - Revert `rL321667: [PPC64] Port to ppc64le - initial version`

Author: timshen Date: Tue Jan 2 14:04:03 2018 New Revision: 321678 URL: http://llvm.org/viewvc/llvm-project?rev=321678=rev Log: Revert `rL321667: [PPC64] Port to ppc64le - initial version` Differential Revision: https://reviews.llvm.org/D41386 Modified:

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

mstorsjo added a comment. In https://reviews.llvm.org/D41386#966187, @timshen wrote: > The static_assert on line 1189 fails with the following build on x86: > > cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON > -DLLVM_PATH=$PATH_TO_LLVM $PATH_TO_LIBUNWIND && ninja libunwind.a > > > It

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

timshen added a comment. The static_assert on line 1189 fails with the following build on x86: cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON -DLLVM_PATH=$PATH_TO_LLVM $PATH_TO_LIBUNWIND && ninja libunwind.a It seems that 136 in `# define _LIBUNWIND_CONTEXT_SIZE 136` is too small.

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:92 for (unsigned I = 0, Size = Record.readInt(); I != Size; ++I) -IDs.push_back(ReadDeclID()); +IDs.push_back(LazySpecializationInfo(ReadDeclID(), Record.readInt()));

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 128465. v.g.vassilev added a comment. Teach `ASTReader::CompleteRedeclChain` to load only the template specializations with the same template argument list. https://reviews.llvm.org/D41416 Files: include/clang/AST/DeclTemplate.h

[PATCH] D41421: Eliminate a magic number. NFC.

mattd added a comment. Ping :) I would like someone to commit this on my behalf, thanks! https://reviews.llvm.org/D41421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

elsteveogrande updated this revision to Diff 128466. elsteveogrande edited the summary of this revision. elsteveogrande added a comment. Fixed local var names. Using `arc diff` which hopefully submits latest changes w/ full context Repository: rC Clang https://reviews.llvm.org/D38320

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

lebedev.ri updated this revision to Diff 128462. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. Renamed `TautologicalRangeCompare` to `TautologicalInRangeCompare`. Given that previous version of this differential was already previously accepted, and the fact that this

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:440 def TautologicalUnsignedEnumZeroCompare : DiagGroup<"tautological-unsigned-enum-zero-compare">; +def TautologicalRangeCompare : DiagGroup<"tautological-constant-range-compare">; def

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 128460. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address inline comments: order the read operations. https://reviews.llvm.org/D41416 Files: include/clang/AST/DeclTemplate.h lib/AST/DeclTemplate.cpp

[PATCH] D41680: [analyzer] do not crash with assertion on processing locations of bodyfarmed functions

george.karpenkov created this revision. george.karpenkov added reviewers: dcoughlin, NoQ. Herald added subscribers: a.sidorin, szepet, kristof.beyls, xazax.hun, aemerson. This addresses an issue introduced in r183451: since `removePiecesWithInvalidLocations` is called *after*

r321676 - [WinEH] Allow for multiple terminatepads

Author: rnk Date: Tue Jan 2 13:34:16 2018 New Revision: 321676 URL: http://llvm.org/viewvc/llvm-project?rev=321676=rev Log: [WinEH] Allow for multiple terminatepads Fixes verifier errors with Windows EH and OpenMP, which injects a terminate scope around parallel blocks. Fixes PR35778

[PATCH] D41677: Change memcpy/memove/memset to have dest and source alignment attributes.

dneilson added a comment. In https://reviews.llvm.org/D41677#966094, @rjmccall wrote: > I'm glad to hear that progress is finally happening on this. > > The change to CGBuilder looks good to me. I'm going to take your word for it > that the test changes are all just obvious updates; if there's

[PATCH] D41677: Change memcpy/memove/memset to have dest and source alignment attributes.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I'm glad to hear that progress is finally happening on this. The change to CGBuilder looks good to me. I'm going to take your word for it that the test changes are all just obvious

[PATCH] D41520: smmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rL321671: [DOXYGEN] Fix doxygen and content issues in smmintrin.h (authored by dyung, committed by ). Changed prior to commit: https://reviews.llvm.org/D41520?vs=127949=128449#toc Repository: rL LLVM

r321671 - [DOXYGEN] Fix doxygen and content issues in smmintrin.h

Author: dyung Date: Tue Jan 2 12:45:29 2018 New Revision: 321671 URL: http://llvm.org/viewvc/llvm-project?rev=321671=rev Log: [DOXYGEN] Fix doxygen and content issues in smmintrin.h - Fix formatting issue due to hyphenated terms at line breaks. - Fix typo This patch was made by Craig Flores

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

elsteveogrande added a comment. Hi @arphaman, thanks very much! Sorry, I didn't notice there was activity on this old patch until now. I'll make these changes as suggested and re-send it with full context. Repository: rL LLVM https://reviews.llvm.org/D38320

[PATCH] D41518: pmmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rL321670: [DOXYGEN] Fix doxygen and content issues in pmmintrin.h (authored by dyung, committed by ). Changed prior to commit: https://reviews.llvm.org/D41518?vs=127947=128448#toc Repository: rL LLVM

r321670 - [DOXYGEN] Fix doxygen and content issues in pmmintrin.h

Author: dyung Date: Tue Jan 2 12:42:53 2018 New Revision: 321670 URL: http://llvm.org/viewvc/llvm-project?rev=321670=rev Log: [DOXYGEN] Fix doxygen and content issues in pmmintrin.h - Fix incorrect wording in various intrinsic descriptions. Previously the descriptions used "low-order" and

[PATCH] D41516: emmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rL321669: [DOXYGEN] Fix doxygen and content issues in emmintrin.h (authored by dyung, committed by ). Changed prior to commit: https://reviews.llvm.org/D41516?vs=127939=128447#toc Repository: rL LLVM

r321669 - [DOXYGEN] Fix doxygen and content issues in emmintrin.h

Author: dyung Date: Tue Jan 2 12:39:29 2018 New Revision: 321669 URL: http://llvm.org/viewvc/llvm-project?rev=321669=rev Log: [DOXYGEN] Fix doxygen and content issues in emmintrin.h - Fixed innaccurate instruction mappings for various intrinsics. - Fixed description of NaN handling in

[PATCH] D41660: [cmake] Add new linux toolchain file

hintonda added a comment. In https://reviews.llvm.org/D41660#966023, @phosek wrote: > @hintonda I think this should be a platform file in > https://github.com/llvm-mirror/llvm/tree/master/cmake/platforms rather than > Clang cache file. Platform files are concerned with the host platform >

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

STL_MSFT added a comment. Ping? (And happy new year!) https://reviews.llvm.org/D41213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

This revision was automatically updated to reflect the committed changes. Closed by commit rL321667: [PPC64] Port to ppc64le - initial version (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D41386?vs=127516=128445#toc Repository: rL LLVM

[libunwind] r321667 - [PPC64] Port to ppc64le - initial version

Author: mstorsjo Date: Tue Jan 2 12:10:54 2018 New Revision: 321667 URL: http://llvm.org/viewvc/llvm-project?rev=321667=rev Log: [PPC64] Port to ppc64le - initial version Initial working version of libunwind for PowerPC 64. Tested on little-endian ppc64 host only. Based on the existing PowerPC

[PATCH] D41677: Change memcpy/memove/memset to have dest and source alignment attributes.

dneilson created this revision. dneilson added a reviewer: rjmccall. Herald added subscribers: fedor.sergeev, kbarton, aheejin, sbc100, javed.absar, nhaehnle, nemanjai, jyknight. Upstream LLVM is changing the the prototypes of the @llvm.memcpy/memmove/memset intrinsics. This change updates the

[PATCH] D41660: [cmake] Add new linux toolchain file

phosek added a comment. @hintonda I think this should be a platform file in https://github.com/llvm-mirror/llvm/tree/master/cmake/platforms rather than Clang cache file. Platform files are concerned with the host platform (including cross-compilation), while cache files are related to the

[PATCH] D15935: Improve diagnostics for literal conversion to Boolean

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3147-3149 +def warn_impcast_literal_to_bool : Warning< + "implicit conversion from %0 to %1; will always evaluate to " + "'%select{false|true}2'">, InGroup; Warning groups are

[libcxx] r321666 - One more (should be) inline variable that is defined in the dylib

Author: marshall Date: Tue Jan 2 11:23:30 2018 New Revision: 321666 URL: http://llvm.org/viewvc/llvm-project?rev=321666=rev Log: One more (should be) inline variable that is defined in the dylib Modified: libcxx/trunk/include/__mutex_base Modified: libcxx/trunk/include/__mutex_base URL:

[PATCH] D41660: [cmake] Add new linux toolchain file

hintonda added a comment. In https://reviews.llvm.org/D41660#965935, @hintonda wrote: > In https://reviews.llvm.org/D41660#965877, @beanz wrote: > > > You should split the CMake cache file you created into two files, (1) a > > CMake Cache to manage the build configuration and (2) a tool chain

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

Quuxplusone added a comment. @weimingz: Since your platform supports `srand(0)`, is it possible to look at how your platform implements `srand(0)` and "inline" that implementation into `random_device`? That seems like it would be more in keeping with the other ifdefs in this file. I'm

r321665 - Suppress undefined-template warnings when the pattern is declared in a system header.

Author: nicholas Date: Tue Jan 2 11:10:12 2018 New Revision: 321665 URL: http://llvm.org/viewvc/llvm-project?rev=321665=rev Log: Suppress undefined-template warnings when the pattern is declared in a system header. The way to fix an undefined-template warning is to add lines to the header file

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

khuttun marked 7 inline comments as done. khuttun added a comment. In https://reviews.llvm.org/D41655#965551, @JonasToth wrote: > I think it would be more user friendly if the configured list can be a list > and the `|` concatenation is done within your code. What do you exactly mean by list?

[PATCH] D40850: suppress undefined-template warnings when the pattern is declared in a system header

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, I agree with your reasoning. https://reviews.llvm.org/D40850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r321664 - Un-inline a few more variables that are exported from the dylib.

Author: marshall Date: Tue Jan 2 11:01:45 2018 New Revision: 321664 URL: http://llvm.org/viewvc/llvm-project?rev=321664=rev Log: Un-inline a few more variables that are exported from the dylib. Modified: libcxx/trunk/include/__functional_base libcxx/trunk/include/functional Modified:

[libcxx] r321663 - Temporarily revert the inlining of 'piecewise_construct' because it is exported from the dylib.

Author: marshall Date: Tue Jan 2 10:57:47 2018 New Revision: 321663 URL: http://llvm.org/viewvc/llvm-project?rev=321663=rev Log: Temporarily revert the inlining of 'piecewise_construct' because it is exported from the dylib. Modified: libcxx/trunk/include/utility Modified:

[PATCH] D40850: suppress undefined-template warnings when the pattern is declared in a system header

nlewycky added a comment. Ping! https://reviews.llvm.org/D40850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

rsmith added a comment. I think you should track lazy partial specializations separately from lazy full specializations -- we need to load all the partial specializations when doing partial specialization selection, and don't want to load all full specializations at the same time.

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

weimingz added a comment. Should we go with current patch? or provide a srand/rand based implementation as an option? Repository: rCXX libc++ https://reviews.llvm.org/D41316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r321661 - A couple more inlined variables that I missed the first time

Author: marshall Date: Tue Jan 2 10:41:01 2018 New Revision: 321661 URL: http://llvm.org/viewvc/llvm-project?rev=321661=rev Log: A couple more inlined variables that I missed the first time Modified: libcxx/trunk/include/type_traits libcxx/trunk/www/cxx1z_status.html Modified:

[PATCH] D41660: [cmake] Add new linux toolchain file

hintonda added a comment. In https://reviews.llvm.org/D41660#965877, @beanz wrote: > You should split the CMake cache file you created into two files, (1) a CMake > Cache to manage the build configuration and (2) a tool chain file for > targeting Linux. As @semeenai pointed out we absolutly

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

xgsa updated this revision to Diff 128431. xgsa added a comment. Rename the check `nolint-usage` => `readability-nolint-usage` for consistency. Update diagnostics message according to the review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41326 Files:

Re: [PATCH] D41414: [analyzer] Add keyboard j/k navigation to HTML reports

Sure, this is post-commit review feedback. vim with dvorak works in the sense that it's not unusable, but it's pretty awkward (see, for example, discussions like this: http://vim.wikia.com/wiki/Using_Vim_with_the_Dvorak_keyboard_layout ) On Tue, Jan 2, 2018 at 10:03 AM George Karpenkov

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

lebedev.ri added a comment. @aaron.ballman, @smeenai, thank you for feedback! Comment at: include/clang/Basic/DiagnosticGroups.td:440 def TautologicalUnsignedEnumZeroCompare : DiagGroup<"tautological-unsigned-enum-zero-compare">; +def TautologicalRangeCompare :

[PATCH] D41528: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL321660: [Sema] Dont emit the -Wstrict-prototypes warning for variadic functions. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41528?vs=127965=128430#toc

Re: [PATCH] D41414: [analyzer] Add keyboard j/k navigation to HTML reports

This patch has already landed — also IIRC e.g. vim on dvorak also uses hjkl navigation with no issues. > On Dec 25, 2017, at 11:21 AM, David Blaikie wrote: > > any chance this can be implemented based on keyboard layout, so it's good for > dvorak users as well? (maybe it

r321660 - [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.

Author: vsapsai Date: Tue Jan 2 10:02:19 2018 New Revision: 321660 URL: http://llvm.org/viewvc/llvm-project?rev=321660=rev Log: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions. rdar://problem/33251668 Reviewers: arphaman, ahatanak Reviewed By: arphaman Subscribers:

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

smeenai added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:440 def TautologicalUnsignedEnumZeroCompare : DiagGroup<"tautological-unsigned-enum-zero-compare">; +def TautologicalRangeCompare : DiagGroup<"tautological-constant-range-compare">; def

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:440 def TautologicalUnsignedEnumZeroCompare : DiagGroup<"tautological-unsigned-enum-zero-compare">; +def TautologicalRangeCompare : DiagGroup<"tautological-constant-range-compare">; def

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

On Tue, Dec 19, 2017 at 9:43 PM Akira Hatanaka wrote: > On Tue, Dec 12, 2017 at 12:12 PM, John McCall wrote: > >> On Tue, Dec 12, 2017 at 1:45 PM, David Blaikie >> wrote: >> >>> On Mon, Dec 11, 2017 at 5:38 PM John McCall

[PATCH] D41239: Turn a config macro (_LIBCPP_HAS_NO_INLINE_VARIABLES) into an attribute macro (_LIBCPP_INLINE_VAR)

mclow.lists abandoned this revision. mclow.lists added a comment. This was committed as part of r321658 https://reviews.llvm.org/D41239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r321658 - Implement most of P0607: Inline Variables for the Standard Library. This involved marking a lot of variables as inline (but only for C++17 and later).

Author: marshall Date: Tue Jan 2 09:17:01 2018 New Revision: 321658 URL: http://llvm.org/viewvc/llvm-project?rev=321658=rev Log: Implement most of P0607: Inline Variables for the Standard Library. This involved marking a lot of variables as inline (but only for C++17 and later). Modified:

[PATCH] D41668: [clangd] Add static index for the global code completion.

hokein created this revision. hokein added reviewers: sammccall, ioeric. Herald added subscribers: ilya-biryukov, klimek. Use the YAML-format symbols (generated by the global-symbol-builder tool) to do the global code completion. It is **experimental** only , but it allows us to experience global

[PATCH] D41660: [cmake] Add new linux toolchain file

beanz added a comment. You should split the CMake cache file you created into two files, (1) a CMake Cache to manage the build configuration and (2) a tool chain file for targeting Linux. As @semeenai pointed out we absolutly want the behavior of the toolchain file being loaded multiple times.

[PATCH] D41660: [cmake] Add new linux toolchain file

smeenai added a comment. In https://reviews.llvm.org/D41660#965686, @hintonda wrote: > In https://reviews.llvm.org/D41660#965656, @smeenai wrote: > > > > > > Cache files are preferred since they are only loaded once Isn't that precisely the behavior needed for cross-compilation though? You

[PATCH] D33563: Track whether a unary operation can overflow

aaron.ballman added a comment. Post-holiday ping. https://reviews.llvm.org/D33563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

aaron.ballman added a comment. Post-holiday ping. https://reviews.llvm.org/D41553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15935: Improve diagnostics for literal conversion to Boolean

aaron.ballman added a comment. Post-holiday ping. https://reviews.llvm.org/D15935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41317: Infrastructure for adding C attributes

aaron.ballman added a comment. Post-holiday ping. https://reviews.llvm.org/D41317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >