[PATCH] D43660: [OpenMP] Add OpenMP data sharing infrastructure using global memory

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D43660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43660: [OpenMP] Add OpenMP data sharing infrastructure using global memory

gtbercea updated this revision to Diff 136528. Repository: rC Clang https://reviews.llvm.org/D43660 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp lib/CodeGen/CGOpenMPRuntimeNVPTX.h

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

alexfh added a comment. In https://reviews.llvm.org/D43847#1023642, @Eugene.Zelenko wrote: > May be //abseil// is better name for module? I'd also go for "abseil". I'll try to get abseil folks to review this. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43847

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. Hi Aaron. It occurs to me now that this patch has grown rather large and, in some places, a little subtle. Would it help the review if I were to break it up into a patch series that introduces ParamIdx to each attribute, one at a time? I'm not trying to rush you, but

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136520. juliehockett marked 14 inline comments as done. juliehockett added a comment. Fixing comments and adding tests https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

djasper added a comment. Are you sure that you are even addressing an important case? I have done some research on our codebase and this is something that happens incredibly rarely. The reason is that you have to have a very specific combination of line length, where the last parameter does

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

djasper added a comment. In https://reviews.llvm.org/D42684#1022219, @Typz wrote: > Indeed, seems to apply to classes as well. Maybe I was mislead by my testing, > where I did not get the case (possibly because we use > `ConstructorInitializerAllOnOneLineOrOnePerLine=true`, so the continuation

Re: [PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

Resubmitted as r326439. Sorry for all the trouble. We need to hack around the Analyses.def being required by Frontend, but it would nice to remove this dependency upstream. On Thu, Mar 1, 2018 at 3:34 PM Benjamin Kramer wrote: > Frontend depends on StaticAnalyzerCore by >

r326439 - Resubmit [analyzer] Support for naive cross translation unit analysis

Author: ibiryukov Date: Thu Mar 1 06:54:16 2018 New Revision: 326439 URL: http://llvm.org/viewvc/llvm-project?rev=326439=rev Log: Resubmit [analyzer] Support for naive cross translation unit analysis Originally submitted as r326323 and r326324. Reverted in r326432. Reverting the commit was a

Re: r326434 - UsersManual: beef up the clang-cl text a little

Thanks! Added in r326438. On Thu, Mar 1, 2018 at 3:05 PM, Nico Weber via cfe-commits wrote: > Should we also mention /p:CLToolExe for just swapping out the compiler > without using a full toolset? > > Also, should we include some notes on cmake usage? I.e. -G "Visual

r326438 - UsersManual: improve the clang-cl text some more

Author: hans Date: Thu Mar 1 06:48:19 2018 New Revision: 326438 URL: http://llvm.org/viewvc/llvm-project?rev=326438=rev Log: UsersManual: improve the clang-cl text some more Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: [PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

Frontend depends on StaticAnalyzerCore by including "clang/StaticAnalyzer/Core/Analyses.def". That's a clear layering violation, but cmake doesn't model header dependencies. Maybe Analyses.def should move into its own library. On Thu, Mar 1, 2018 at 3:07 PM Gábor Horváth via llvm-commits <

Re: [PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

I am away from my workstation so I would really appreciate if you could recommit. Thanks in advance, Gábor 2018. márc. 1. 15:28 ezt írta ("Ilya Biryukov" ): > You're right. We have this extra dependency in our internal build files > for some reason and I missed that. >

Re: [PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

You're right. We have this extra dependency in our internal build files for some reason and I missed that. It's totally my fault. Should I resubmit the patch that I reverted or you would rather do it yourself? On Thu, Mar 1, 2018 at 3:07 PM Gábor Horváth wrote: > > >

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

Eugene.Zelenko added a comment. By the word, may be similar check for std::string::rfind() and std::string::ends_with() (does abseil have analog) should be added too? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43847 ___

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D43847#1023452, @hokein wrote: > In https://reviews.llvm.org/D43847#1021967, @aaron.ballman wrote: > > > I need a bit more context because I'm unfamiliar with `absl`. What is this > > module's intended use? > > > As `absl` has been

[PATCH] D43817: [x86] wbnoinvd intrinsic

GBuella updated this revision to Diff 136510. GBuella edited the summary of this revision. GBuella added a comment. Added Ice Lake Server architecture. Removed wbinvd related code. https://reviews.llvm.org/D43817 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def

Re: [PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2018. márc. 1. 14:58 ezt írta ("Ilya Biryukov" ): I replied to a commit in the wrong thread (https://reviews.llvm.org/rL326323), sorry. Here are the important bits: This change introduced the following cyclic dependency in the build system: StaticAnalyzerCore -> CrossTU ->

[PATCH] D43869: [clangd] Support include canonicalization in symbol leve.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/CanonicalIncludes.h:47 + /// Sets the canonical include for any symbol with \p QualifiedName. + /// Header mappings are ignored if \p

Re: r326434 - UsersManual: beef up the clang-cl text a little

Should we also mention /p:CLToolExe for just swapping out the compiler without using a full toolset? Also, should we include some notes on cmake usage? I.e. -G "Visual Studio 14 2015" -T "LLVM-vs2014" for the MSVS generator, and -DCMAKE_C_COMPILER=/path/to/llvm/bin/clang-cl.exe

r326434 - UsersManual: beef up the clang-cl text a little

Author: hans Date: Thu Mar 1 06:00:19 2018 New Revision: 326434 URL: http://llvm.org/viewvc/llvm-project?rev=326434=rev Log: UsersManual: beef up the clang-cl text a little Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: [PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

I replied to a commit in the wrong thread (https://reviews.llvm.org/rL326323), sorry. Here are the important bits: This change introduced the following cyclic dependency in the build system: StaticAnalyzerCore -> CrossTU -> Frontend -> StaticAnalyzerCore. I'm sorry, but I had to revert the commit

[PATCH] D43928: [analyzer] Correctly measure array size in security.insecureAPI.strcpy

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D43928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

lebedev.ri updated this revision to Diff 136503. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. Reworked stuff via new `CXX98CompatExtraSemi` diag group. As expected, passing `-Wno-c++98-compat-pedantic` disables the extra-semi diag, which exactly the opposite from

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

alexfh added inline comments. Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54 + } else if (const auto *const Call = + Result.Nodes.getNodeAs("ptr_fun_call")) { +diag(Call->getLocStart(), Message) << "'std::ptr_fun'"; + } else if (const

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

alexfh added inline comments. Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54 + } else if (const auto *const Call = + Result.Nodes.getNodeAs("ptr_fun_call")) { +diag(Call->getLocStart(), Message) << "'std::ptr_fun'"; + } else if (const

[PATCH] D43572: [Sema] Improve test coverage of narrowing conversion diagnostics

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks! https://reviews.llvm.org/D43572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

hokein added inline comments. Comment at: clang-tidy/absl/StringFindStartswithCheck.cpp:1 +#include "StringFindStartswithCheck.h" + nit: We need a LICENSE comment at the top of the file. Comment at:

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

xazax.hun added a reviewer: ilya-biryukov. xazax.hun added a subscriber: ilya-biryukov. xazax.hun added a comment. @ilya-biryukov Could you please provide some more details where the cyclic dependency is? I cannot reproduce the problem and usually cmake fails when there is a cyclic dependency

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

a.sidorin reopened this revision. a.sidorin added a comment. The changes were reverted: http://llvm.org/viewvc/llvm-project?rev=326432=rev Gabor, could you take a look? Repository: rC Clang https://reviews.llvm.org/D30691 ___ cfe-commits

r326432 - Revert "[analyzer] Support for naive cross translation unit analysis"

Author: ibiryukov Date: Thu Mar 1 04:43:39 2018 New Revision: 326432 URL: http://llvm.org/viewvc/llvm-project?rev=326432=rev Log: Revert "[analyzer] Support for naive cross translation unit analysis" Also revert "[analyzer] Fix a compiler warning" This reverts commits r326323 and r326324.

[PATCH] D43108: Support for the mno-stack-arg-probe flag

aemerson added a comment. In https://reviews.llvm.org/D43108#1023300, @nruslan wrote: > By default, stack probes are enabled (i.e., -mstack-arg-probe is the default > behavior) and have the size of 4K in x86. This part what I wanted to clarify, `-mstack-probe-arg` is enabling stack probes if

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

This revision was automatically updated to reflect the committed changes. Closed by commit rC326426: [clang-format] Add SpaceBeforeColon option (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D32525?vs=136305=136483#toc Repository: rC Clang

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

This revision was automatically updated to reflect the committed changes. Closed by commit rL326426: [clang-format] Add SpaceBeforeColon option (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D32525 Files:

r326426 - [clang-format] Add SpaceBeforeColon option

Author: typz Date: Thu Mar 1 02:09:13 2018 New Revision: 326426 URL: http://llvm.org/viewvc/llvm-project?rev=326426=rev Log: [clang-format] Add SpaceBeforeColon option Summary: When disabled, this option allows removing the space before colon, making it act more like the semi-colon. When

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

hokein added a comment. In https://reviews.llvm.org/D43847#1021967, @aaron.ballman wrote: > I need a bit more context because I'm unfamiliar with `absl`. What is this > module's intended use? As `absl` has been open-sourced (https://github.com/abseil/abseil-cpp), I think there will be more

[PATCH] D43869: [clangd] Support include canonicalization in symbol leve.

ioeric added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:83 + static const std::vector SymbolMap = { + // Map symbols in to their preferred includes. + {"std::basic_filebuf", ""}, hokein wrote: > Looks like the list

[PATCH] D43869: [clangd] Support include canonicalization in symbol leve.

hokein added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:83 + static const std::vector SymbolMap = { + // Map symbols in to their preferred includes. + {"std::basic_filebuf", ""}, Looks like the list only contains

[PATCH] D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. This rst file is generated from include/clang/Format/Format.h using docs/tools/dump_format_style.py. Update it there and run the tool to regenerate the .rst file. Repository:

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

ftingaud added inline comments. Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:21 +: MakeSmartPtrCheck(Name, Context, "std::make_unique"), + MinimumLanguageVersion(Options.get("MakeUniqueLanguageVersion", +

[PATCH] D43928: [analyzer] Correctly measure array size in security.insecureAPI.strcpy

leanil updated this revision to Diff 136474. leanil added a comment. `getQuantity()` returns a signed type https://reviews.llvm.org/D43928 Files: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp Index: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp

[PATCH] D43928: [analyzer] Correctly measure array size in security.insecureAPI.strcpy

leanil created this revision. leanil added reviewers: dcoughlin, xazax.hun, NoQ. Herald added subscribers: a.sidorin, rnkovacs, szepet. Herald added a reviewer: george.karpenkov. This will handle those platforms that don't have 8-bit chars. This is a follow up fix to review

[PATCH] D43908: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC

mstorsjo updated this revision to Diff 136471. mstorsjo edited the summary of this revision. mstorsjo added a comment. Added an error-by-default diagnostic (just like the existing warn_cxx_ms_struct) for this case, trigger it on all targets other than mingw (where the situation is quite likely

<    1   2