[libcxx] r328182 - Fix dynarray test failures after changing __libcpp_allocate/deallocate

Author: ericwf Date: Wed Mar 21 22:44:48 2018 New Revision: 328182 URL: http://llvm.org/viewvc/llvm-project?rev=328182=rev Log: Fix dynarray test failures after changing __libcpp_allocate/deallocate Modified: libcxx/trunk/include/experimental/dynarray Modified:

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

dpayne added a comment. I'll make sure to do the full diff in the future. I did that for the first patch but forgot to do it in the follow up patch, I won't make that mistake in the future. I do not have commit access so I cannot merge myself. When you have the time could you merge this

[libcxx] r328180 - Fix PR22634 - std::allocator doesn't respect over-aligned types.

Author: ericwf Date: Wed Mar 21 21:42:56 2018 New Revision: 328180 URL: http://llvm.org/viewvc/llvm-project?rev=328180=rev Log: Fix PR22634 - std::allocator doesn't respect over-aligned types. This patch fixes std::allocator, and more specifically, all users of __libcpp_allocate and

r328173 - Improve -Winfinite-recursion

Author: codafi Date: Wed Mar 21 20:16:23 2018 New Revision: 328173 URL: http://llvm.org/viewvc/llvm-project?rev=328173=rev Log: Improve -Winfinite-recursion Summary: Rewrites -Winfinite-recursion to remove the state dictionary and explore paths in loops - especially infinite loops. The new

[PATCH] D44597: [CFG] [analyzer] Add C++17-specific variable and return value construction contexts.

dcoughlin accepted this revision. dcoughlin added a comment. LGTM. I really appreciate the extra documentation you've added, too. https://reviews.llvm.org/D44597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

This revision was automatically updated to reflect the committed changes. Closed by commit rL328175: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r328175 - [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

Author: benhamilton Date: Wed Mar 21 20:25:22 2018 New Revision: 328175 URL: http://llvm.org/viewvc/llvm-project?rev=328175=rev Log: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic Summary: We received reports of the Objective-C style guesser getting a false negative on

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

benhamilton updated this revision to Diff 139410. benhamilton marked an inline comment as done. benhamilton added a comment. Remove assert Repository: rC Clang https://reviews.llvm.org/D44632 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D44692: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl

This revision was automatically updated to reflect the committed changes. Closed by commit rL328174: [clang-format] Dont insert space between r_paren and new in ObjC decl (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r328174 - [clang-format] Don't insert space between r_paren and 'new' in ObjC decl

Author: benhamilton Date: Wed Mar 21 20:23:53 2018 New Revision: 328174 URL: http://llvm.org/viewvc/llvm-project?rev=328174=rev Log: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl Summary: Previously, clang-format would insert a space between the closing parenthesis and

[PATCH] D43737: Improve -Winfinite-recursion

This revision was automatically updated to reflect the committed changes. Closed by commit rL328173: Improve -Winfinite-recursion (authored by CodaFi, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43737?vs=139325=139408#toc

[clang-tools-extra] r328172 - Revert "[clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework""

Author: juliehockett Date: Wed Mar 21 19:05:51 2018 New Revision: 328172 URL: http://llvm.org/viewvc/llvm-project?rev=328172=rev Log: Revert "[clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework"" This reverts commit r328150 until we can fix the test that are failing on the Windows

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

rsmith added a comment. @fedor.sergeev Can you review this for correctness? Thanks! Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r328171 - [Frontend] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Wed Mar 21 17:53:26 2018 New Revision: 328171 URL: http://llvm.org/viewvc/llvm-project?rev=328171=rev Log: [Frontend] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

compnerd added a comment. I may be a bit biased but I agree with @bob.wilson and @steven_wu. The current names are better from the user’s perspective. GCC’s build is a very bad example as it has runtime components built as part of it (libgcc). When building any code, even in a Canadian

[PATCH] D44765: PR36643 Make clang-format support more generic TMarcos

obfuscated created this revision. obfuscated added a reviewer: krasimir. Herald added a subscriber: klimek. This patch changes the check for _T to detect TMarcos with a more generic check. This makes it possible to format wxWidgets projects (where wxT is used a lot) correctly. Patch by Teodor

[PATCH] D44764: [clangd] Move GTest printers to separate file

malaperle created this revision. Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple, ilya-biryukov, klimek. This mitigates a possible issue in tests that print objects on failure. It is possible that there will be two different instantiations of the printer template for a

[PATCH] D44763: [analyzer] Add C++17-specific constructor-initializer construction contexts.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. `CXXCtorInitializer`-based constructors are apparently also affected by the C++17 mandatory copy elision, like variable constructors and

[PATCH] D44725: [analyzer] NFC: Move construction context allocation into a helper method.

NoQ added a comment. > E.g. we have `llvm::make_shared<>()`, so we could also have > `Allocator::make_obj<...>(...)` I like your thinking, but that'd require me to make the allocator my friend class (: https://reviews.llvm.org/D44725 ___

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp:17 }; extern A x; // expected-error {{requires an initializer}} +static A y;

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen updated this revision to Diff 139393. timshen marked 7 inline comments as done. timshen added a comment. Address comments. https://reviews.llvm.org/D41148 Files: libcxx/include/experimental/__config libcxx/include/experimental/simd

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen added inline comments. Comment at: libcxx/include/experimental/simd:669 + +#if _LIBCPP_STD_VER > 14 && !defined(_LIBCPP_HAS_NO_VARIABLE_TEMPLATES) +template mclow.lists wrote: > Isn't the parallelism TS based on C++17? > I intended to have a C++11 (and

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. @steven_wu Maybe there is something outside of "build" "host" or "target" that won't suffer from these problems of vantage point? `__will_be_built_for_*` for a very lengthy example, but hopefully something shorter too? Repository: rC Clang

[PATCH] D44725: [analyzer] NFC: Move construction context allocation into a helper method.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM, but would actually make even more sense as a static function for the allocator. E.g. we have `llvm::make_shared<>()`, so we could also have

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. ping^3 Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44725: [analyzer] NFC: Move construction context allocation into a helper method.

NoQ updated this revision to Diff 139389. NoQ added a comment. I'd rather keep the helper method within the class. This allows us to keep constructors private, which is something i forgot to do originally. https://reviews.llvm.org/D44725 Files: include/clang/Analysis/ConstructionContext.h

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

eugenis added inline comments. Comment at: lib/Driver/SanitizerArgs.cpp:33 NotAllowedWithMinimalRuntime = Vptr, - RequiresPIE = DataFlow | Scudo, + RequiresPIE = DataFlow | HWAddress | Scudo, NeedsUnwindTables = Address | HWAddress | Thread | Memory | DataFlow,

[PATCH] D43737: Improve -Winfinite-recursion

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. Looks good. Ready to commit. https://reviews.llvm.org/D43737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

mclow.lists added a comment. I'm going to stop here, because all the things I've noted are ticky-tack; formatting and minor changes. More substantial comments coming soon. Comment at: libcxx/include/experimental/simd:40 +template inline constexpr bool is_abi_tag_v =

[PATCH] D41217: [Concepts] Concept Specialization Expressions

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprCXX.cpp:1478 + { +// We do not want error diagnostics escaping here. +Sema::SFINAETrap Trap(S); saar.raz wrote: > hubert.reinterpretcast wrote: > > saar.raz wrote: > > > faisalv

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

steven_wu added a comment. I am not trying to discuss which english word is best here. My point is simply: 1. macros are evaluated during compile time 2. "host"means either the platform you compiled on during compile time or the platform you run on during the runtime 3. __is_host_* is not a

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai added inline comments. Comment at: libcxx/include/functional:1722-1733 if (__f.__f_ == 0) __f_ = 0; else if ((void *)__f.__f_ == &__f.__buf_) { __f_ = __as_base(&__buf_); __f.__f_->__clone(__f_); } Here is

r328166 - Fix for LLVM change (Transforms/Utils/Local.h -> Analysis/Utils/Local.h)

Author: dblaikie Date: Wed Mar 21 15:34:27 2018 New Revision: 328166 URL: http://llvm.org/viewvc/llvm-project?rev=328166=rev Log: Fix for LLVM change (Transforms/Utils/Local.h -> Analysis/Utils/Local.h) Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp

[PATCH] D44691: [CUDA] Disable LTO for device-side compilations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328161: [CUDA] Disable LTO for device-side compilations. (authored by tra, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r328161 - [CUDA] Disable LTO for device-side compilations.

Author: tra Date: Wed Mar 21 15:22:59 2018 New Revision: 328161 URL: http://llvm.org/viewvc/llvm-project?rev=328161=rev Log: [CUDA] Disable LTO for device-side compilations. This fixes host-side LTO during CUDA compilation. Before, LTO pipeline construction was clashing with CUDA pipeline

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. > I'm sure I could fine a GCC example FWIW https://github.com/gcc-mirror/gcc/blob/master/gcc/config/aarch64/aarch64.c vs https://github.com/gcc-mirror/gcc/blob/master/gcc/common/config/aarch64/aarch64-common.c @steven_wu > It is not about matching command line

[PATCH] D44755: [analyzer] Suppress more C++17-related crashes.

NoQ updated this revision to Diff 139378. NoQ added a comment. Add a comment for the confusing part. https://reviews.llvm.org/D44755 Files: lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Core/ExprEngineCXX.cpp test/Analysis/lifetime-extension.cpp

r328158 - [NVPTX] Make tensor shape part of WMMA intrinsic's name.

Author: tra Date: Wed Mar 21 14:55:02 2018 New Revision: 328158 URL: http://llvm.org/viewvc/llvm-project?rev=328158=rev Log: [NVPTX] Make tensor shape part of WMMA intrinsic's name. This is needed for the upcoming implementation of the new 8x32x16 and 32x8x16 variants of WMMA instructions

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

steven_wu added a comment. It is not about matching command line name to builtin marco name. "target" is the platform we are compiling for, whether it is host or device or something else. It is a different concept when you talking about cross-compiling, which "target" is strictly not host and

[PATCH] D44710: Set dso_local on builtin functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. @steven_wu but what you say is directly contradicted by the GHC example. I'm sure I could fine a GCC example too where some macro with "target" is in the name affects the target of the compiler being built. In the vast majority of programs, no more than one

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

rjmccall added a comment. In https://reviews.llvm.org/D44747#1044916, @yaxunl wrote: > In https://reviews.llvm.org/D44747#1044893, @rjmccall wrote: > > > Is there a reason for this to be done as a special case in IRGen instead of > > just implicitly applying the calling convention in Sema? > >

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. One that that might make my position clearer is to substitute the name "build", "host", and "target" for "build", "run", and "emit". [A colleague of mine proposed these alternative names and I do think they are vastly more human friendly.] Then if we write int

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

steven_wu added a comment. I disagree. I think "target" is the correct name, even for cross compiling. For something compiled with -target foo, we are consistent calling it "target" during compile time. It only becomes appropriate to call it "host" during the runtime of the executable. There

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

This revision was automatically updated to reflect the committed changes. Closed by commit rC328153: [Modules] Fix creating fake definition data for lambdas. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D43494?vs=138059=139372#toc Repository: rC

r328153 - [Modules] Fix creating fake definition data for lambdas.

Author: vsapsai Date: Wed Mar 21 14:28:54 2018 New Revision: 328153 URL: http://llvm.org/viewvc/llvm-project?rev=328153=rev Log: [Modules] Fix creating fake definition data for lambdas. During reading C++ definition data for lambda we can access CXXRecordDecl representing lambda before we

[clang-tools-extra] r328150 - [clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework"

Author: juliehockett Date: Wed Mar 21 14:21:45 2018 New Revision: 328150 URL: http://llvm.org/viewvc/llvm-project?rev=328150=rev Log: [clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework" Fixing the the failing Windows tests. Added:

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

mclow.lists added a comment. A few small comments... Comment at: libcxx/include/functional:1821 { -if ((void *)__f_ == &__buf_) -__f_->destroy(); -else if (__f_) -__f_->destroy_deallocate(); -__f_ = 0; +function::operator=(nullptr); if

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. In https://reviews.llvm.org/D44753#1044935, @bob.wilson wrote: > Sorry that I missed your earlier comment about this. The confusion could only > arise in the context of a tool (like a compiler) that is being used for > cross-compilation. That is a small fraction of

[PATCH] D44755: [analyzer] Suppress more C++17-related crashes.

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:480 } + CC = dyn_cast( + RTCElem->getConstructionContext()); I'm a bit confused as to what is going on here; maybe a short comment would be helpful?

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai updated this revision to Diff 139369. vsapsai edited the summary of this revision. vsapsai added a comment. - Implement the same functionality for C++98 and C++03. - Use `DoNotOptimize` instead of `asm`. Didn't move the tests as the standard doesn't require assignment operator to be

[clang-tools-extra] r328149 - [clangd][nfc] Correct header name in comment

Author: jkorous Date: Wed Mar 21 14:04:10 2018 New Revision: 328149 URL: http://llvm.org/viewvc/llvm-project?rev=328149=rev Log: [clangd][nfc] Correct header name in comment Modified: clang-tools-extra/trunk/clangd/index/Index.h Modified: clang-tools-extra/trunk/clangd/index/Index.h URL:

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

eugenis added a comment. This was fixed in https://reviews.llvm.org/D44655 https://reviews.llvm.org/D44645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44634: [clang-format] Detect Objective-C for #import

Wizard added a comment. For some ObjC headers it uses #import to import other headers instead of system framework, so I think we should also detect #import "*.h" as well. The only usage of #import in C++ is to import type library, which won't have suffix of ".h". Repository: rC Clang

Re: r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

Not sure either, but I think the ignored warning is used for pragmas that clang fails to parse, so maybe unsupported is better. On Wed, Mar 21, 2018 at 9:33 PM, Nico Weber wrote: > Ah! Hm, maybe that's the better group for this anyway? Not sure. > > On Wed, Mar 21, 2018,

Re: [PATCH] D44634: [clang-format] Detect Objective-C for #import

#import is perfectly legal in C and C++, it's just not commonly used. On Wed, Mar 21, 2018, 14:27 Yan Zhang via Phabricator < revi...@reviews.llvm.org> wrote: > Wizard added a comment. > > Why do we only detect system framework? I think any #import could indicate > ObjC header. > > > Repository:

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF updated this revision to Diff 139363. EricWF marked an inline comment as done. EricWF added a comment. - Launder types with subobjects of dynamic class type. - Improve diagnostic selection using `llvm::Optional`. - Add comment about LTO ABI concerns to test file. - Merge with master.

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF marked 2 inline comments as done. EricWF added inline comments. Comment at: test/CodeGenCXX/builtin-launder.cpp:93-96 +/// The test cases in this namespace technically need to be laundered according +/// to the language in the standard (ie they have const or reference

Re: r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

Ah! Hm, maybe that's the better group for this anyway? Not sure. On Wed, Mar 21, 2018, 9:03 PM Hans Wennborg wrote: > Aw, rats. I put it under -Wignored-pragmas rather than > -Wunsupported-pragmas, because I was looking at #pragma intrinsic. > > I'll take a look at this again

[PATCH] D44755: [analyzer] Suppress more C++17-related crashes.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This is assertion removal. The assertion was saying that a function's return value is always a temporary object - which is not true when

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

bob.wilson added a comment. Sorry that I missed your earlier comment about this. The confusion could only arise in the context of a tool (like a compiler) that is being used for cross-compilation. That is a small fraction of the audience for Clang, and we should design this in a way that makes

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:1947-1948 +const auto *Record = ArgTy->getAsCXXRecordDecl(); +if (CGM.getCodeGenOpts().StrictVTablePointers && Record && +Record->isDynamicClass()) +

[PATCH] D44634: [clang-format] Detect Objective-C for #import

Wizard added a comment. Why do we only detect system framework? I think any #import could indicate ObjC header. Repository: rC Clang https://reviews.llvm.org/D44634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

yaxunl added a comment. In https://reviews.llvm.org/D44747#1044893, @rjmccall wrote: > Is there a reason for this to be done as a special case in IRGen instead of > just implicitly applying the calling convention in Sema? The calling convention is not used in Sema, therefore it seems simpler

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

yaxunl updated this revision to Diff 139359. yaxunl added a comment. Upload diff with full context. https://reviews.llvm.org/D44747 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCUDA/kernel-amdgcn.cu Index: test/CodeGenCUDA/kernel-amdgcn.cu

Re: r327959 - [ms] Parse #pragma optimize and ignore it behind its own flag

Aw, rats. I put it under -Wignored-pragmas rather than -Wunsupported-pragmas, because I was looking at #pragma intrinsic. I'll take a look at this again tomorrow. On Wed, Mar 21, 2018 at 5:18 PM, Nico Weber via cfe-commits wrote: > From the bot changes, it seems that

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

rjmccall added a comment. Is there a reason for this to be done as a special case in IRGen instead of just implicitly applying the calling convention in Sema? https://reviews.llvm.org/D44747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 created this revision. Ericson2314 added reviewers: arphaman, compnerd, dexonsmith, bob.wilson, steven_wu. Herald added subscribers: cfe-commits, javed.absar. Per my belated [reply] to the mailing list, I believe the "target" nomenclature incorrect for cross compilation. [reply]:

[PATCH] D44272: [clangd] Support incremental document syncing

simark updated this revision to Diff 139355. simark marked an inline comment as done. simark added a comment. Address review comments I failed to address previously Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44272 Files: clangd/ClangdLSPServer.cpp clangd/DraftStore.cpp

[PATCH] D44272: [clangd] Support incremental document syncing

simark marked 6 inline comments as done. simark added inline comments. Herald added a subscriber: MaskRay. Comment at: unittests/clangd/DraftStoreTests.cpp:27 + +static int rangeLength(StringRef Code, const Range ) { + size_t Start = positionToOffset(Code, Rng.start);

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added inline comments. Comment at: clangd/FuzzyMatch.h:61 bool allowMatch(int P, int W) const; - int skipPenalty(int W, Action Last) const; - int matchBonus(int P, int W, Action Last) const; + int missScore(int W, Action Last) const; + int matchScore(int P, int W,

[PATCH] D43047: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328134: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual… (authored by EricWF, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43047: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC328134: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual… (authored by EricWF, committed by ). Repository: rC Clang https://reviews.llvm.org/D43047 Files:

r328134 - [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

Author: ericwf Date: Wed Mar 21 12:19:48 2018 New Revision: 328134 URL: http://llvm.org/viewvc/llvm-project?rev=328134=rev Log: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions. Summary: Libc++'s default allocator uses

[PATCH] D43047: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

EricWF added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:3458 + } + TheCall->getCallee()->setType(OperatorNewOrDelete->getType()); + rsmith wrote: > It would be nice to assert that the callee you're setting the type of is an > ImplicitCastExpr doing

[PATCH] D43047: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

EricWF updated this revision to Diff 139347. EricWF marked an inline comment as done. EricWF added a comment. - Merge with upstream. - Add requested assertion. https://reviews.llvm.org/D43047 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D44272: [clangd] Support incremental document syncing

ilya-biryukov added inline comments. Comment at: unittests/clangd/DraftStoreTests.cpp:27 + +static int rangeLength(StringRef Code, const Range ) { + size_t Start = positionToOffset(Code, Rng.start); ilya-biryukov wrote: > no need for `static`, since function is

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

mclow.lists added a comment. Sorry I've let this lie fallow for so long. Comment at: include/charconv:234 +to_chars(char* __first, char* __last, _Tp __value, int __base) +-> to_chars_result +{ Why use the trailing return type here? I don't see any

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} aaron.ballman wrote: > lebedev.ri wrote: > > aaron.ballman wrote: > > > lebedev.ri

[PATCH] D44541: [OpenMP][Clang] Move device global stack init before master-workers split

gtbercea abandoned this revision. gtbercea added a comment. This leads to usage of statically allocated shared data before their initialization in runtime structures by master thread in kernel_init() function. New patch available with worker and master-side initialization. Repository: rC

[PATCH] D44749: [OpenMP][Clang] Add call to global data sharing stack initialization on the workers side

gtbercea created this revision. gtbercea added reviewers: ABataev, grokos, carlo.bertolli, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. The workers also need to initialize the global stack. The call to the initialization function needs to happen after the kernel_init()

[clang-tools-extra] r328131 - Reland "[lit] Adding config initialization to lit tests in clang-tools-extra"

Author: juliehockett Date: Wed Mar 21 11:50:26 2018 New Revision: 328131 URL: http://llvm.org/viewvc/llvm-project?rev=328131=rev Log: Reland "[lit] Adding config initialization to lit tests in clang-tools-extra" Adding the config initialization to clang-tools-extra so that tests that use

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54 + } else if (const auto *const Call = + Result.Nodes.getNodeAs("ptr_fun_call")) { +diag(Call->getLocStart(), Message) << "'std::ptr_fun'"; + } else if

[PATCH] D44747: [AMDGPU] Set calling convention for CUDA kernel

yaxunl created this revision. yaxunl added reviewers: rjmccall, arsenm. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. This patch sets the calling convention for CUDA kernels required by AMDGPU target. Patch by Greg Rodgers. Lit test added by Yaxun Liu.

[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

juliehockett closed this revision. juliehockett added a comment. Committed in r328127. https://reviews.llvm.org/D44743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r328127 - [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

Author: juliehockett Date: Wed Mar 21 11:03:41 2018 New Revision: 328127 URL: http://llvm.org/viewvc/llvm-project?rev=328127=rev Log: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows After changes to lit.site.cfg.in, the test is now running (and failing) on windows, so

[PATCH] D44559: [Sema] Wrong width of result of mul operation

rjmccall added a comment. In https://reviews.llvm.org/D44559#1044653, @aaron.ballman wrote: > In https://reviews.llvm.org/D44559#1044639, @rjmccall wrote: > > > In https://reviews.llvm.org/D44559#1044186, @avt77 wrote: > > > > > >> In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote: > >

[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

erik.pilkington added a comment. Hi Volodymyr, thanks for working on this! Overall this looks good, I just have a few nits. Comment at: clang/include/clang/Basic/SourceLocation.h:202 +/// Can be used transparently in places where SourceLocation is expected. +class

[PATCH] D44272: [clangd] Support incremental document syncing

simark updated this revision to Diff 139328. simark added a comment. Add lit test case Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44272 Files: clangd/ClangdLSPServer.cpp clangd/DraftStore.cpp clangd/DraftStore.h clangd/Protocol.cpp clangd/Protocol.h

[PATCH] D44533: [AMDGPU] Fix codegen for inline assembly

yaxunl added a comment. Ping https://reviews.llvm.org/D44533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43737: Improve -Winfinite-recursion

CodaFi updated this revision to Diff 139325. https://reviews.llvm.org/D43737 Files: lib/Sema/AnalysisBasedWarnings.cpp test/SemaCXX/warn-infinite-recursion.cpp Index: test/SemaCXX/warn-infinite-recursion.cpp === ---

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

alekseyshl created this revision. alekseyshl added a reviewer: eugenis. Herald added a subscriber: cryptoad. Porting HWASan to Linux x86-64, the third of the three patches, clang part. Repository: rC Clang https://reviews.llvm.org/D44745 Files: lib/Driver/SanitizerArgs.cpp

[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

juliehockett created this revision. juliehockett added reviewers: zturner, phosek. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. After changes to lit.site.cfg.in, the test is now running (and failing) on windows, so temporarily marking it unsupported. See

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

alexfh added inline comments. Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54 + } else if (const auto *const Call = + Result.Nodes.getNodeAs("ptr_fun_call")) { +diag(Call->getLocStart(), Message) << "'std::ptr_fun'"; + } else if (const

[PATCH] D44272: [clangd] Support incremental document syncing

simark updated this revision to Diff 139321. simark added a comment. Remove draft if update fails Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44272 Files: clangd/ClangdLSPServer.cpp clangd/DraftStore.cpp clangd/DraftStore.h clangd/Protocol.cpp clangd/Protocol.h

[PATCH] D44694: [clang-tidy] Use :doc: for check links in Release Notes

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE328115: [clang-tidy] Use :doc: for check links in Release Notes. (authored by eugenezelenko, committed by ). Changed prior to commit: https://reviews.llvm.org/D44694?vs=139167=139320#toc Repository:

[clang-tools-extra] r328115 - [clang-tidy] Use :doc: for check links in Release Notes.

Author: eugenezelenko Date: Wed Mar 21 10:06:13 2018 New Revision: 328115 URL: http://llvm.org/viewvc/llvm-project?rev=328115=rev Log: [clang-tidy] Use :doc: for check links in Release Notes. Differential revision: https://reviews.llvm.org/D44694 Modified:

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added inline comments. Comment at: clangd/FuzzyMatch.cpp:96 return None; return ScoreScale * std::min(PerfectBonus * PatN, std::max(0, Best)); } I also don't understand why it clamps the value to zero here. Negative values are also meaningful

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added inline comments. Comment at: clangd/FuzzyMatch.h:61 bool allowMatch(int P, int W) const; - int skipPenalty(int W, Action Last) const; - int matchBonus(int P, int W, Action Last) const; + int missScore(int W, Action Last) const; + int matchScore(int P, int W,

  1   2   >