[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

Hahnfeld added a comment. In https://reviews.llvm.org/D45212#1066842, @rjmccall wrote: > I'd still prefer if someone with more driver-design expertise weighed in, but > we might not have any specialists there. I think you should at least give @tra the possibility to take a look. Last time we

[clang-tools-extra] r329994 - [clang-tidy] [bugprone-parent-virtual-call] Minor cosmetic changes. NFC

Author: zinovy.nis Date: Fri Apr 13 00:46:27 2018 New Revision: 329994 URL: http://llvm.org/viewvc/llvm-project?rev=329994&view=rev Log: [clang-tidy] [bugprone-parent-virtual-call] Minor cosmetic changes. NFC Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp M

[PATCH] D45257: [X86] Introduce cldemote intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL329993: [X86] Introduce cldemote intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45257?vs=142340&id=142345#toc

[PATCH] D45319: [Atomics] warn about misaligned atomic accesses using libcalls

t.p.northover added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45578: Add a command line option 'fregister_dtor_with_atexit' to register destructor functions annotated with __attribute__((destructor)) using __cxa_atexit or atexit.

rjmccall added inline comments. Comment at: include/clang/Driver/Options.td:1613 +def fregister_dtor_with_atexit : Flag<["-"], "fregister-dtor-with-atexit">, Group, Flags<[CC1Option]>, + HelpText<"Use atexit or __cxa_atexit to register destructors">; def fuse_init_array : Flag

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I'd still prefer if someone with more driver-design expertise weighed in, but we might not have any specialists there. LGTM, although you might consider changing your tests a bit: FileChec

[PATCH] D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table

rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2342 + if (isa(Ty)) +return false; return true; I agree with your analysis that this shouldn't be a substitution candidate. However, I think this probably needs an ABI-compatibi

[PATCH] D45257: [X86] Introduce cldemote intrinsic

GBuella updated this revision to Diff 142340. GBuella added a comment. Rebase. https://reviews.llvm.org/D45257 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/Headers/cldemote

[PATCH] D44984: [HIP] Add hip file type and codegen for kernel launching

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:98 +std::string CGNVCUDARuntime::addPrefixToName(CodeGenModule &CGM, + std::string FuncName) const { + if (CGM.getLangOpts().HIP) Can you take these

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

shiva0217 updated this revision to Diff 142338. shiva0217 added a comment. Add help text for -mrelax, -mno-relax flags as Alex's comments. Repository: rL LLVM https://reviews.llvm.org/D44888 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-f

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

(Sorry for the delay in responding — I'm actually on vacation.) On Tue, Apr 10, 2018 at 1:52 PM, David Blaikie wrote: > On Tue, Apr 10, 2018 at 10:20 AM John McCall wrote: > >> Do you think they’re bad precedent? > > > Somewhat, yes - though -Wparens is perhaps conflating a few cases too. I > t

<    1   2