Author: tzik
Date: Mon Jun 18 22:35:30 2018
New Revision: 335022
URL: http://llvm.org/viewvc/llvm-project?rev=335022=rev
Log:
Revert r335019 "Update NRVO logic to support early return (Attempt 2)"
Removed:
cfe/trunk/test/CodeGenCXX/nrvo-noopt.cpp
cfe/trunk/test/SemaCXX/nrvo-ast.cpp
Author: ahatanak
Date: Mon Jun 18 22:04:44 2018
New Revision: 335021
URL: http://llvm.org/viewvc/llvm-project?rev=335021=rev
Log:
[Sema] Produce diagnostics for attribute 'trivial_abi' that appears
after the closing brace of a class declaration.
Merge the two call sites of
Author: tzik
Date: Mon Jun 18 21:39:07 2018
New Revision: 335019
URL: http://llvm.org/viewvc/llvm-project?rev=335019=rev
Log:
Update NRVO logic to support early return (Attempt 2)
Summary:
This is the second attempt of r333500 (Update NRVO logic to support early
return).
The previous one was
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335019: Update NRVO logic to support early return (Attempt
2) (authored by tzik, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47586?vs=151847=151848#toc
Repository:
rC Clang
tzik added inline comments.
Comment at: test/CodeGenCXX/nrvo-noopt.cpp:1
+// RUN: %clang_cc1 -emit-llvm -O0 -o - %s | FileCheck %s
+
rsmith wrote:
> You don't need the `-O0` here; that's the default.
Thanks! Done.
Repository:
rC Clang
tzik updated this revision to Diff 151847.
tzik marked an inline comment as done.
tzik added a comment.
drop an unneeded -O0
Repository:
rC Clang
https://reviews.llvm.org/D47586
Files:
include/clang/AST/Decl.h
include/clang/Sema/Scope.h
lib/Sema/Scope.cpp
lib/Sema/SemaDecl.cpp
thakis updated this revision to Diff 151844.
thakis marked 2 inline comments as done.
thakis added a comment.
comments
https://reviews.llvm.org/D48296
Files:
clang/lib/Sema/SemaInit.cpp
clang/test/SemaCXX/ms-initlist-narrowing.cpp
Index: clang/test/SemaCXX/ms-initlist-narrowing.cpp
thakis added a comment.
Thanks! I'd keep it DefaultIgnored: I'd be annoyed if I'd get these by default
in C++98 mode.
https://reviews.llvm.org/D48296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Quuxplusone added a comment.
@EricWF ping; is this a reasonable solution to LWG 2843 on platforms without
aligned new and delete?
Repository:
rCXX libc++
https://reviews.llvm.org/D47344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ added a comment.
Also, great, and can i has tests?^^
Like a simple code snippet with two `// RUN: ... -analyzer-output=text` lines
and different expected-warnings/notes under `#if`s.
Repository:
rC Clang
https://reviews.llvm.org/D48285
___
Quuxplusone planned changes to this revision.
Quuxplusone added inline comments.
Comment at: src/experimental/memory_resource.cpp:240
+bool allocation_contains(const char *p) const {
+// TODO: This part technically relies on undefined behavior.
+return
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:696
void ento::registerUninitializedObjectChecker(CheckerManager ) {
auto Chk = Mgr.registerChecker();
Chk->IsPedantic = Mgr.getAnalyzerOptions().getBooleanOption(
dberris added a comment.
I'm really excited by this clang-tidy check and I think it's worth having. I do
think there's more work needed to bring it up to a level of quality that would
be helpful to more users.
Comment at:
morehouse requested changes to this revision.
morehouse added inline comments.
This revision now requires changes to proceed.
Comment at: tools/clang-fuzzer/CMakeLists.txt:72
+ # Build the lllvm protobuf fuzzer
+ add_clang_executable(clang-llvm-proto-fuzzer
rjmccall added a comment.
In https://reviews.llvm.org/D47988#1135929, @rnk wrote:
> In https://reviews.llvm.org/D47988#1135533, @rjmccall wrote:
>
> > In general, it's unfortunate that this has to leave so many
> > C++-runtime-specific tendrils in the ObjC code. Unlike the EH type patch,
> >
Hello everyone,
Below are some buildbot numbers for the last week of 6/10/2018 - 6/16/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Hello everyone,
Below are some buildbot numbers for the week of 5/27/2018 - 6/2/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the week of 6/3/2018 - 6/9/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
rnk added a comment.
In https://reviews.llvm.org/D47988#1135533, @rjmccall wrote:
> In general, it's unfortunate that this has to leave so many
> C++-runtime-specific tendrils in the ObjC code. Unlike the EH type patch,
> though, I'm not sure I can see a great alternative here, especially
pcc added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:423
+llvm::sys::path::native(Dwo_Dir, DwoDir);
+llvm::sys::path::append(DwoDir, Twine(Output.getFilename()) + "_dwo");
+CmdArgs.push_back(
I think that if I pass
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D47341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
emmettneyman updated this revision to Diff 151801.
emmettneyman added a comment.
- removed unnecessary includes and linked libs
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp
vsapsai added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:374-377
+ IsBaseFound = AddGnuCPlusPlusIncludePaths("/usr/include/c++/4.2.1",
+"powerpc-apple-darwin10", "",
+
emmettneyman updated this revision to Diff 151798.
emmettneyman added a comment.
Implemented HandleLLVM fuzz target
-HandleLLVM function compiles LLVM IR
-ExampleClangLLVMProtoFuzzer wraps the fuzz target
-Next step is to compile at different opt levels and run the executables
arphaman added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:491
} else {
- AddDefaultCPlusPlusIncludePaths(triple, HSOpts);
+ AddDefaultCPlusPlusIncludePaths(Lang, triple, HSOpts);
}
bruno wrote:
> If we happen to suggest
bruno added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:491
} else {
- AddDefaultCPlusPlusIncludePaths(triple, HSOpts);
+ AddDefaultCPlusPlusIncludePaths(Lang, triple, HSOpts);
}
If we happen to suggest libc++, but it's
rnk added a comment.
Do you think we should go ahead and remove the `DefaultIgnore` on these
warnings as well? At this point, approximately nobody will see them.
Comment at: clang/lib/Sema/SemaInit.cpp:8367-8370
+bool DiagErr =
+S.getLangOpts().CPlusPlus11 &&
+
arphaman created this revision.
arphaman added reviewers: bruno, vsapsai.
Xcode 10 removes support for libstdc++, but the users just get a confusing
include not file warning when including an STL header (when building for iOS6
which uses libstdc++ by default for example).
This patch adds a new
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334982: IRgen: Mark aliases of ctors and dtors as
unnamed_addr. (authored by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48206?vs=151455=151787#toc
Repository:
rC Clang
Author: pcc
Date: Mon Jun 18 13:58:54 2018
New Revision: 334982
URL: http://llvm.org/viewvc/llvm-project?rev=334982=rev
Log:
IRgen: Mark aliases of ctors and dtors as unnamed_addr.
This is not only semantically correct but ensures that they will not
be marked as address-significant once D48155
rsmith added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:3973
Args.AddLastArg(CmdArgs, options::OPT_fheinous_gnu_extensions);
+ Args.AddLastArg(CmdArgs, options::OPT_fdigraphs, options::OPT_fno_digraphs);
Args.AddLastArg(CmdArgs,
thakis created this revision.
thakis added a reviewer: rnk.
Diagnostics for narrowing conversions in initializer lists are currently
DefaultIgnored in Microsoft mode. But MSVC 2015 did add warnings about
narrowing conversions (C2397), so clang-cl can remove its special case code if
rsmith added a comment.
The right way to handle this is to pass both the ultimately-selected
declaration and the declaration found by name lookup into the calls to
`MarkAnyDeclReferenced` and friends. We should mark the selected declaration as
`Used` (when appropriate), and mark the found
jtbandes updated this revision to Diff 151771.
jtbandes added a comment.
Added `-fdigraphs`. I kept it as a cc1 option because it seemed awkward to
"check whether the last arg was -fno-digraphs and pass only that arg to cc1"
(if just directly forwarding all args, there would be an unrecognized
jtbandes marked an inline comment as done.
jtbandes added inline comments.
Comment at: include/clang/Driver/Options.td:1337-1338
Flags<[CC1Option]>, Group;
+def fno_digraphs : Flag<["-"], "fno-digraphs">, Group,
Flags<[CC1Option]>,
+ HelpText<"Disallow alternative token
RKSimon added a comment.
Is there any llvm side fast isel tests for these?
Comment at: cfe/trunk/lib/Headers/avx512fintrin.h:9855
+ __v8di __t6 = (__v8di)_mm512_##op(__t4, __t5); \
+ return __t6[0];
craig.topper wrote:
> RKSimon wrote:
> > Would it be dumb
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/CodeGenCXX/nrvo-noopt.cpp:1
+// RUN: %clang_cc1 -emit-llvm -O0 -o - %s | FileCheck %s
+
You don't need the `-O0` here; that's the
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please add documentation and release notes for this flag too.
https://reviews.llvm.org/D48155
___
cfe-commits mailing list
rsmith created this revision.
rsmith added reviewers: EricWF, mclow.lists.
Herald added a subscriber: cfe-commits.
Teach libcxx to stop using various deprecated __has_* type traits, in favor of
the ("modern", C++11 era) __is_* type traits.
This is mostly just a simplification, but fixes at
And, as soon as I sent that, I realized what was up. Apparently
auto-complete is driven by the parser, and delayed template parsing means
we don't parse templates. That seems like a serious issue that should get
fixed eventually.
Anyway, I landed a crummy workaround in r334973 to green the bots.
Author: rnk
Date: Mon Jun 18 11:55:10 2018
New Revision: 334973
URL: http://llvm.org/viewvc/llvm-project?rev=334973=rev
Log:
Fix clangd test to pass when delayed template parsing is on by default
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified:
Author: nico
Date: Mon Jun 18 11:50:35 2018
New Revision: 334972
URL: http://llvm.org/viewvc/llvm-project?rev=334972=rev
Log:
Don't let test/Driver/no-canonical-prefixes.c form a symlink cycle the second
time it runs.
The test makes %t.fake a symlink to %t.real by running `ln -sf %t.real
thakis closed this revision.
thakis added a comment.
r334972, thanks!
https://reviews.llvm.org/D48224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This test has been failing on Windows since it has been added:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12549
I took a look at the unittest code, but I'm not familiar enough with this
code to debug it. Can you take a look at this?
On Fri, Jun 15, 2018 at 1:35 AM Ilya
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D48224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall added a comment.
In general, it's unfortunate that this has to leave so many
C++-runtime-specific tendrils in the ObjC code. Unlike the EH type patch,
though, I'm not sure I can see a great alternative here, especially because of
the semantic restrictions required by outlining.
rjmccall added inline comments.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Looks good overall, but some nits inline.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:682
+StringRef
smeenai added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D47988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D47233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: george.karpenkov
Date: Mon Jun 18 10:59:03 2018
New Revision: 334965
URL: http://llvm.org/viewvc/llvm-project?rev=334965=rev
Log:
[analyzer] Remove accidentally committed lines.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp
Modified:
george.karpenkov added a comment.
@alexfh apologies, fixed.
Repository:
rC Clang
https://reviews.llvm.org/D47670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, george.karpenkov, NoQ, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
Repository:
rC Clang
https://reviews.llvm.org/D48291
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334964: Fix a bug introduced by rL334850 (authored by
tkrupa, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48288?vs=151742=151752#toc
Repository:
rC Clang
Author: tkrupa
Date: Mon Jun 18 10:57:05 2018
New Revision: 334964
URL: http://llvm.org/viewvc/llvm-project?rev=334964=rev
Log:
Fix a bug introduced by rL334850
Summary: All *_sqrt_round_s[s|d] intrinsics should execute a square root on
zeroth element from B (Ops[1]) and insert in to A (Ops[0]),
xazax.hun added a comment.
I wonder if this could be done when plist is emitted generally, independent of
any checks.
Repository:
rC Clang
https://reviews.llvm.org/D48285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric created this revision.
ioeric added reviewers: sammccall, malaperle.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Some URI schemes require a hint path to be provided, and workspace root
path seems to be a good fit.
Repository:
rCTE Clang Tools Extra
yaxunl updated this revision to Diff 151748.
yaxunl added a comment.
Correct comments in test.
https://reviews.llvm.org/D48287
Files:
lib/Frontend/CompilerInvocation.cpp
test/CodeGenCUDA/flush-denormals.cu
Index: test/CodeGenCUDA/flush-denormals.cu
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM provided the nit on passing arguments is fixed.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:696
void
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
leonardchan added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:1248
+ bool RHSFixed = RHSType->isFixedPointType();
+
+ if (LHSFixed && RHSFixed) {
ebevhan wrote:
> ebevhan wrote:
> > leonardchan wrote:
> > > leonardchan wrote:
> > > > ebevhan wrote:
> >
leonardchan updated this revision to Diff 151744.
leonardchan added a comment.
- Removed CK_IntegralToFixedPoint to be added to later patch addressing
conversion
- Create CXString for FixedPointLiteral
Repository:
rC Clang
https://reviews.llvm.org/D46915
Files:
include/clang-c/Index.h
tkrupa created this revision.
tkrupa added a reviewer: itaraban.
Herald added a subscriber: cfe-commits.
All *_sqrt_round_s[s|d] intrinsics should execute a square root on zeroth
element from B (Ops[1]) and insert in to A (Ops[0]), not the other way around.
Repository:
rC Clang
JDevlieghere added a comment.
In https://reviews.llvm.org/D48241#1134985, @labath wrote:
> This is not true. (Unlike the .apple_*** tables, ) .debug_names allows you to
> specify a different schema for every entry in the acelerator table. The
> schema is specifing using abbreviations in much
Author: abataev
Date: Mon Jun 18 10:11:45 2018
New Revision: 334962
URL: http://llvm.org/viewvc/llvm-project?rev=334962=rev
Log:
[OPENMP, NVPTX] Emit simple reduction if requested.
If simple reduction is requested, use the simple reduction instead of
the runtime functions calls.
Modified:
yaxunl created this revision.
yaxunl added reviewers: b-sumner, tra.
yaxunl added a reviewer: scchan.
https://reviews.llvm.org/D48287
Files:
lib/Frontend/CompilerInvocation.cpp
test/CodeGenCUDA/flush-denormals.cu
Index: test/CodeGenCUDA/flush-denormals.cu
Higuoxing updated this revision to Diff 151736.
Higuoxing added a comment.
test case has been passed
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
===
---
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs,
whisperity.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet.
For Plist consumers that don't support notes just yet, this flag can be used to
convert them into
Higuoxing added a comment.
In https://reviews.llvm.org/D47687#1135284, @dexonsmith wrote:
> Did you miss this comment from my previous review?
>
> > I would like to see tests like the following:
> >
> > NESTING_VOID_WRAPPER(&&, ||, i, i, i && i); // no warning.
> > NESTING_VOID_WRAPPER(||,
craig.topper added a comment.
We should probably just leave them around. Leave a NOTE so they don't get
deleted.
https://reviews.llvm.org/D45616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
baloghadamsoftware added a comment.
I added extra assertion into the test for the difference. Interestingly, it
also works if I assert `n-m` is in the range instead of `m-n`.
https://reviews.llvm.org/D35110
___
cfe-commits mailing list
probinson added a comment.
Style comments.
The two new Sema methods (for namespaces and using references) are C++
specific, so SemaDeclCXX.cpp would seem like a more appropriate home for them.
Comment at: lib/Sema/Sema.cpp:1879
+void
dexonsmith added a comment.
Did you miss this comment from my previous review?
> I would like to see tests like the following:
>
> NESTING_VOID_WRAPPER(&&, ||, i, i, i && i); // no warning.
> NESTING_VOID_WRAPPER(||, &&, i, i, i || i); // no warning.
Comment at:
baloghadamsoftware updated this revision to Diff 151720.
baloghadamsoftware added a comment.
-(-2^n) == -2^n
https://reviews.llvm.org/D35110
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
ebevhan added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:1248
+ bool RHSFixed = RHSType->isFixedPointType();
+
+ if (LHSFixed && RHSFixed) {
leonardchan wrote:
> leonardchan wrote:
> > ebevhan wrote:
> > > ebevhan wrote:
> > > > leonardchan wrote:
> >
alexfh added inline comments.
Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:2613
+ jj++;
+ assert(jj<10);
// Get a clean copy of all the visitors.
Was this meant to be committed? I see this assertion firing on a ton of files.
Repository:
mikerice added a comment.
Ping. This can significantly improve compile time for projects that use the
common /Yc /Yu PCH mechanism.
https://reviews.llvm.org/D46652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
GBuella updated this revision to Diff 151710.
https://reviews.llvm.org/D45616
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
test/CodeGen/avx-cmp-builtins.c
test/CodeGen/avx2-builtins.c
test/CodeGen/avx512f-builtins.c
test/CodeGen/avx512vl-builtins.c
Index:
GBuella added a comment.
The question still left is, should we remove, auto upgrade the LLVM intrinsics
not used anymore, or keep them around for when the signal behaviour is going to
matter?
https://reviews.llvm.org/D45616
___
cfe-commits
Author: probinson
Date: Mon Jun 18 05:22:17 2018
New Revision: 334936
URL: http://llvm.org/viewvc/llvm-project?rev=334936=rev
Log:
Update copyright year to 2018.
Modified:
libunwind/trunk/LICENSE.TXT
Modified: libunwind/trunk/LICENSE.TXT
URL:
Author: probinson
Date: Mon Jun 18 05:22:17 2018
New Revision: 334936
URL: http://llvm.org/viewvc/llvm-project?rev=334936=rev
Log:
Update copyright year to 2018.
Modified:
cfe/trunk/LICENSE.TXT
cfe/trunk/tools/clang-format-vs/ClangFormat/license.txt
Modified: cfe/trunk/LICENSE.TXT
URL:
Author: probinson
Date: Mon Jun 18 05:22:17 2018
New Revision: 334936
URL: http://llvm.org/viewvc/llvm-project?rev=334936=rev
Log:
Update copyright year to 2018.
Modified:
libclc/trunk/LICENSE.TXT
Modified: libclc/trunk/LICENSE.TXT
URL:
Author: probinson
Date: Mon Jun 18 05:22:17 2018
New Revision: 334936
URL: http://llvm.org/viewvc/llvm-project?rev=334936=rev
Log:
Update copyright year to 2018.
Modified:
clang-tools-extra/trunk/LICENSE.TXT
clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/license.txt
Modified:
Author: probinson
Date: Mon Jun 18 05:22:17 2018
New Revision: 334936
URL: http://llvm.org/viewvc/llvm-project?rev=334936=rev
Log:
Update copyright year to 2018.
Modified:
libcxxabi/trunk/LICENSE.TXT
Modified: libcxxabi/trunk/LICENSE.TXT
URL:
krytarowski added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D47814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334935: [analyzer] Checker for uninitialized C++ objects
(authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45532
Files:
Author: szelethus
Date: Mon Jun 18 04:50:17 2018
New Revision: 334935
URL: http://llvm.org/viewvc/llvm-project?rev=334935=rev
Log:
[analyzer] Checker for uninitialized C++ objects
This checker analyzes C++ constructor calls, and reports uninitialized fields.
Due to the nature of this problem
Szelethus updated this revision to Diff 151685.
Szelethus added a comment.
Whoo! Thank you all for helping me with the reviews. Very excited about the
upcoming fixes, I have some neat ideas for some already.
- Rebased to 8186139d6aa0619e2057ae617c074e486a7b2f2b (revision 334929),
- Added a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334930: [ASTMatchers] Add support for matching the type of a
friend decl. (authored by dlj, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: dlj
Date: Mon Jun 18 02:23:08 2018
New Revision: 334930
URL: http://llvm.org/viewvc/llvm-project?rev=334930=rev
Log:
[ASTMatchers] Add support for matching the type of a friend decl.
This allows matchers like:
friendDecl(hasType(cxxRecordDecl(...)))
klimek accepted this revision.
klimek added a comment.
lg, thx
Repository:
rC Clang
https://reviews.llvm.org/D48242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dlj added a comment.
Ping for Manuel...
Repository:
rC Clang
https://reviews.llvm.org/D48242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
labath added a comment.
I also don't want to get involved too much, but here are my 2c: :)
In https://reviews.llvm.org/D48241#1134342, @JDevlieghere wrote:
> Putting it in a separate column is also a bad idea, because that means the
> column is present for all the entries, including the ones
Author: dlj
Date: Mon Jun 18 01:59:16 2018
New Revision: 334929
URL: http://llvm.org/viewvc/llvm-project?rev=334929=rev
Log:
[ASTMatchers] Don't assert-fail in specifiesTypeLoc().
The specifiesTypeLoc() matcher narrows a nestedNameSpecifier matcher based on a
typeloc within the NNS. However, the
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D48269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dlj created this revision.
dlj added a reviewer: klimek.
dlj added a project: clang.
Herald added a subscriber: cfe-commits.
The specifiesTypeLoc() matcher narrows a nestedNameSpecifier matcher based on a
typeloc within the NNS. However, the matcher does not guard against NNS which
are a
baloghadamsoftware updated this revision to Diff 151666.
baloghadamsoftware added a comment.
New warning message, more detailed docs.
https://reviews.llvm.org/D33537
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
Higuoxing updated this revision to Diff 151661.
Higuoxing marked 12 inline comments as done.
Higuoxing removed a reviewer: echristo.
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
Author: vitalybuka
Date: Sun Jun 17 23:43:55 2018
New Revision: 334926
URL: http://llvm.org/viewvc/llvm-project?rev=334926=rev
Log:
Fix libcxxabi tests after clang r334924
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
Modified: libcxxabi/trunk/test/libcxxabi/test/config.py
URL:
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeCompletionStrings.cpp:172
// get this declaration, so we don't show documentation in that case.
if (Result.Kind !=
1 - 100 of 104 matches
Mail list logo
