[PATCH] D48933: [clangd] Treat class constructor as in the same scope as the class in ranking.

ioeric updated this revision to Diff 154182. ioeric added a comment. - Refactored findAnyDecl. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48933 Files: clangd/Quality.cpp unittests/clangd/QualityTests.cpp unittests/clangd/TestTU.cpp unittests/clangd/TestTU.h Index:

[PATCH] D48947: [clangd] Added a test for preambles and -isystem

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/ClangdTests.cpp:45 namespace { +// FIXME: This is copied from CodeCompleteTests.cpp. Share the code instead. +MATCHER_P(Named, Name,

[PATCH] D48946: [Preamble] Check system dependencies in preamble too

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems like it might be a nontrivial performance hit (it's going to result in `stat`ing all these files, right?). Agreed it's important for correctness, it's possible someone wants

[PATCH] D48943: [clangd] Do not write comments into Preamble PCH

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Very nice! Comment at: clangd/ClangdUnit.cpp:327 CI.getFrontendOpts().SkipFunctionBodies = true; + // We don't want to write comments into PCH. They are racy and

[PATCH] D48940: [clangd] Wait for first preamble before code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice fix! Possible test: add a file with complicated preamble (billion laughs?) and immediately schedule 5 preamble actions. They should all get a non-null preamble and the pointers

r336308 - [Power9] Update fp128 as a valid homogenous aggregate base type

Author: lei Date: Wed Jul 4 21:32:01 2018 New Revision: 336308 URL: http://llvm.org/viewvc/llvm-project?rev=336308=rev Log: [Power9] Update fp128 as a valid homogenous aggregate base type Update clang to treat fp128 as a valid base type for homogeneous aggregate passing and returning.

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Please, wait a couple of days before committing to give a chance to someone else to weigh in. Repository: rC Clang https://reviews.llvm.org/D48916

[PATCH] D48933: [clangd] Treat class constructor as in the same scope as the class in ranking.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/QualityTests.cpp:218 + + // `findDecl` would return the implicit injected class for "Foo::Foo"; simply + // look for a constructor

[PATCH] D47846: [clangd] Implementation of textDocument/documentSymbol

sammccall added a comment. (Reasoning for not using SymbolCollector totally makes sense, thanks for the breakdown!) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48827: [clang-format ]Extend IncludeCategories regex documentation

WimLeflere updated this revision to Diff 154176. WimLeflere added a comment. Added the documentation to the header file. Also had to update dump_format_style.py because it was not loading the IncludeStyle header file. Repository: rC Clang https://reviews.llvm.org/D48827 Files:

[PATCH] D48628: [AST] Structural equivalence of methods

balazske marked an inline comment as done. balazske added inline comments. Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489 + +TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) { + auto t = makeNamedDecls( a_sidorin wrote: > Could you add a

[PATCH] D48628: [AST] Structural equivalence of methods

balazske updated this revision to Diff 154175. balazske added a comment. - Added comment into test StructuralEquivalenceRecordTest.DISABLED_Methods. Repository: rC Clang https://reviews.llvm.org/D48628 Files: lib/AST/ASTImporter.cpp lib/AST/ASTStructuralEquivalence.cpp

[PATCH] D47846: [clangd] Implementation of textDocument/documentSymbol

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, I thought I'd accepted this already! Comment at: clangd/ClangdServer.cpp:467 + }; + WorkScheduler.runWithAST("Hover", File, Bind(Action, std::move(CB))); +}

[libcxxabi] r336312 - [demangler] Avoid alignment warning

Author: sepavloff Date: Wed Jul 4 23:24:29 2018 New Revision: 336312 URL: http://llvm.org/viewvc/llvm-project?rev=336312=rev Log: [demangler] Avoid alignment warning The alignment specified by a constant for the field `BumpPointerAllocator::InitialBuffer` exceeded the alignment guaranteed by

[PATCH] D48938: [clangd] Track origins of symbols (various indexes, Sema).

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE336309: [clangd] Track origins of symbols (various indexes, Sema). (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D48938?vs=154105=154168#toc Repository:

[clang-tools-extra] r336309 - [clangd] Track origins of symbols (various indexes, Sema).

Author: sammccall Date: Wed Jul 4 23:20:41 2018 New Revision: 336309 URL: http://llvm.org/viewvc/llvm-project?rev=336309=rev Log: [clangd] Track origins of symbols (various indexes, Sema). Summary: Surface it in the completion items C++ API, and when a flag is set. Reviewers: ioeric

[PATCH] D48938: [clangd] Track origins of symbols (various indexes, Sema).

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL336309: [clangd] Track origins of symbols (various indexes, Sema). (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed

<    1   2