Re: r338165 - [Sema] Use a TreeTransform to extract deduction guide parameter types

Thank you Erik! Thanks Galina On Fri, Jul 27, 2018 at 7:35 PM, Erik Pilkington wrote: > Okay, the bot can now compile this file, but it looks like somebody else > broke it again in the meantime... > > > FAIL: LLVM :: CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll (17518 of 39837) >

[PATCH] D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping.

This revision was automatically updated to reflect the committed changes. Closed by commit rC338189: [Sema][ObjC] Warn when a method declared in a protocol takes a (authored by ahatanak, committed by ). Repository: rC Clang https://reviews.llvm.org/D49119 Files:

[libcxxabi] r338190 - [demangler] Fix an oss-fuzz bug from r338138

Author: epilk Date: Fri Jul 27 21:06:30 2018 New Revision: 338190 URL: http://llvm.org/viewvc/llvm-project?rev=338190=rev Log: [demangler] Fix an oss-fuzz bug from r338138 Stack overflow on invalid. While collapsing references, we were skipping over a cycle check in ForwardTemplateReference

r338189 - [Sema][ObjC] Warn when a method declared in a protocol takes a

Author: ahatanak Date: Fri Jul 27 21:06:13 2018 New Revision: 338189 URL: http://llvm.org/viewvc/llvm-project?rev=338189=rev Log: [Sema][ObjC] Warn when a method declared in a protocol takes a non-escaping parameter but the implementation's method takes an escaping parameter.

[PATCH] D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

yaxunl added a comment. LGTM. Thanks. Repository: rC Clang https://reviews.llvm.org/D49930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49953: [compiler-rt] Add a routine to specify the mode used when creating profile dirs.

mattd created this revision. mattd added a reviewer: void. Herald added a subscriber: dberris. This patch introduces `llvm_profile_set_dir_mode` and `llvm_profile_get_dir_mode` to the compiler-rt profile API. Originally, profile data was placed into a directory that was created with a

[PATCH] D49723: [OpenCL] Check for invalid kernel arguments in array types

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rC Clang https://reviews.llvm.org/D49723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r338188 - [CUDA][HIP] Allow function-scope static const variable

Author: yaxunl Date: Fri Jul 27 20:05:25 2018 New Revision: 338188 URL: http://llvm.org/viewvc/llvm-project?rev=338188=rev Log: [CUDA][HIP] Allow function-scope static const variable CUDA 8.0 E.3.9.4 says: Within the body of a __device__ or __global__ function, only __shared__ variables or

[PATCH] D49931: [CUDA][HIP] Allow function-scope static const variable

This revision was automatically updated to reflect the committed changes. Closed by commit rC338188: [CUDA][HIP] Allow function-scope static const variable (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D49931 Files:

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

erik.pilkington added inline comments. Comment at: test/CodeGenCXX/empty-struct-init-list.cpp:1-4 +// RUN: %clang_cc1 -std=c++11 %s +// RUN: %clang_cc1 -std=c++14 %s +// RUN: %clang_cc1 -std=c++17 %s +// expected-no-diagnostics You should add -emit-llvm, or

Re: r338165 - [Sema] Use a TreeTransform to extract deduction guide parameter types

Okay, the bot can now compile this file, but it looks like somebody else broke it again in the meantime... FAIL: LLVM :: CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll (17518 of 39837) TEST 'LLVM :: CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll' FAILED

r338187 - [AST] Add a convenient getter from QualType to RecordDecl

Author: george.karpenkov Date: Fri Jul 27 19:16:13 2018 New Revision: 338187 URL: http://llvm.org/viewvc/llvm-project?rev=338187=rev Log: [AST] Add a convenient getter from QualType to RecordDecl Differential Revision: https://reviews.llvm.org/D49951 Modified:

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

rjmccall added a comment. I think the right fix here is to ensure that `DestType` is non-null at a higher level. Older branches of the compiler seem to be able to correctly emit this, probably because the initializer generated for this field ends up having type `a[0]`. Maybe we've just done

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D49656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r338165 - [Sema] Use a TreeTransform to extract deduction guide parameter types

This should be fixed by r338186. I'll keep an eye on this bot to make sure that this is the case. Thanks! Erik On 2018-07-27 5:46 PM, Galina Kistanova wrote: C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\tools\clang\lib\Sema\SemaTemplate.cpp : fatal error C1128: number of

r338186 - Compile SemaTemplate.cpp with /bigobj on MSVC

Author: epilk Date: Fri Jul 27 18:29:31 2018 New Revision: 338186 URL: http://llvm.org/viewvc/llvm-project?rev=338186=rev Log: Compile SemaTemplate.cpp with /bigobj on MSVC This should fix some bot failures introduced by r338165. Modified: cfe/trunk/lib/Sema/CMakeLists.txt Modified:

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

bviyer created this revision. bviyer added reviewers: arphaman, dexonsmith, ahatanak, rjmccall. While emitting Array Constant, if the destination type is null-pointer, it will cause an assert. This patch will check if the destination type is null, and if so then it will just return nullptr as

r338183 - [CFG] Remove duplicate function/class names at the beginning of comments

Author: maskray Date: Fri Jul 27 17:48:05 2018 New Revision: 338183 URL: http://llvm.org/viewvc/llvm-project?rev=338183=rev Log: [CFG] Remove duplicate function/class names at the beginning of comments Some functions/classes have renamed while the comments still use the old names. Delete them

Re: r338165 - [Sema] Use a TreeTransform to extract deduction guide parameter types

Hello Erik, This commit broke build step on one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/11300 . . . FAILED: tools/clang/lib/Sema/CMakeFiles/clangSema.dir/SemaTemplate.cpp.obj C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

efriedma added inline comments. Comment at: lib/Sema/SemaLambda.cpp:1447 +getFrontendFunctionTimeCtx()->startFrontendTimer( +{LSI.CallOperator, 0.0}); + } This seems sort of late? You're starting the timer after the body has already been parsed.

[PATCH] D49548: [clangd] XPC WIP

arphaman requested changes to this revision. arphaman added a comment. FYI, this patch can't be applied because of the broken file paths (some diffs include /clangd prefix, some don't, while the test diffs are missing '/test'). Repository: rCTE Clang Tools Extra

[PATCH] D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping.

ahatanak updated this revision to Diff 157815. ahatanak added a comment. - Produce a note that tells users where the class extension conforming to the protocol containing the non-escaping method is declared. - Add a class method that has the same name as the instance method and check that no

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:192 - if (Call.isCalled(CStrFn) || Call.isCalled(DataFn)) { -SVal RawPtr = Call.getReturnValue(); -if (SymbolRef Sym = RawPtr.getAsSymbol(/*IncludeBaseRegions=*/true)) { -

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

rnkovacs added inline comments. Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:192 - if (Call.isCalled(CStrFn) || Call.isCalled(DataFn)) { -SVal RawPtr = Call.getReturnValue(); -if (SymbolRef Sym = RawPtr.getAsSymbol(/*IncludeBaseRegions=*/true)) { -

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

rnkovacs updated this revision to Diff 157809. rnkovacs marked an inline comment as done. https://reviews.llvm.org/D49656 Files: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/inner-pointer.cpp Index:

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D49466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

mcgrathr added a comment. I think this wants to be a hard error rather than a warning. Though since we use -Werror anyway if others feel strongly contrary I won't object. Repository: rC Clang https://reviews.llvm.org/D49511 ___ cfe-commits

[PATCH] D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping.

ahatanak added a comment. Thanks, I'll update the patch and commit it today. In https://reviews.llvm.org/D49119#1176139, @vsapsai wrote: > In https://reviews.llvm.org/D49119#1176047, @ahatanak wrote: > > > In https://reviews.llvm.org/D49119#1164285, @vsapsai wrote: > > > > > Also I had a few

[PATCH] D49945: [Fixed Point Arithmetic] Fix for FixedPointValueToString

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich, ebevhan, rjmccall. leonardchan added a project: clang. Herald added a subscriber: mgorny. - Print negative numbers correctly - Handle APInts of different sizes - Add formal unit tests for

[PATCH] D49210: [CFG] [analyzer] NFC: Enumerate construction context layer kinds and re-use their code for ExprEngine keys.

NoQ updated this revision to Diff 157789. NoQ added a comment. A better `ConstructedObjectKey::print()`. https://reviews.llvm.org/D49210 Files: include/clang/Analysis/ConstructionContext.h include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/Analysis/CFG.cpp

[PATCH] D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping.

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. Any further improvements are up to you. Repository: rC Clang https://reviews.llvm.org/D49119 ___ cfe-commits mailing list

[PATCH] D49941: [ARM] Add ARMv8.2-A FP16 scalar intrinsic

az created this revision. az added a reviewer: SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, kristof.beyls. This patch adds the fp16 scalar intrinsic for ARM as described in the ARM ACLE document. Only the frontend work is done here and some

[PATCH] D49931: [CUDA][HIP] Allow function-scope static const variable

yaxunl updated this revision to Diff 157778. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Artem's comments. https://reviews.llvm.org/D49931 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenModule.cpp lib/Sema/SemaDecl.cpp

[PATCH] D49848: Parse a possible trailing postfix expression suffix after a fold expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL338170: Parse a possible trailing postfix expression suffix after a fold expression (authored by Rakete, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r338170 - Parse a possible trailing postfix expression suffix after a fold expression

Author: rakete Date: Fri Jul 27 14:55:12 2018 New Revision: 338170 URL: http://llvm.org/viewvc/llvm-project?rev=338170=rev Log: Parse a possible trailing postfix expression suffix after a fold expression Summary: This patch allows the parsing of a postfix expression involving a fold

[PATCH] D49931: [CUDA][HIP] Allow function-scope static const variable

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11923-11930 + if (getLangOpts().CUDA && + !(VD->hasAttr() || +(VD->getType().isConstQualified() && + !VD->hasAttr() && +

[PATCH] D49931: [CUDA][HIP] Allow function-scope static const variable

tra added a comment. Looks OK overall except for the huge `if` below. Comment at: lib/Sema/SemaDecl.cpp:11923-11930 + if (getLangOpts().CUDA && + !(VD->hasAttr() || +(VD->getType().isConstQualified() && + !VD->hasAttr() && +

[PATCH] D49439: [Sema] Fix a crash while converting constructors to deduction guides

This revision was automatically updated to reflect the committed changes. Closed by commit rC338165: [Sema] Use a TreeTransform to extract deduction guide parameter types (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D49439?vs=157309=157767#toc

r338165 - [Sema] Use a TreeTransform to extract deduction guide parameter types

Author: epilk Date: Fri Jul 27 14:23:48 2018 New Revision: 338165 URL: http://llvm.org/viewvc/llvm-project?rev=338165=rev Log: [Sema] Use a TreeTransform to extract deduction guide parameter types Previously, we just canonicalized the type, but this lead to crashes with parameter types that

[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

arphaman updated this revision to Diff 157762. arphaman marked 2 inline comments as done. arphaman added a comment. Updated patch to address review comments: - The compilation database updated are used only when '-in-memory-compile-commands' flag is used. - It's now possible to set the working

[PATCH] D49650: Targets/AMDGPU: Don't set fp32-denormals feature for r600

jvesely abandoned this revision. jvesely added a comment. In https://reviews.llvm.org/D49650#1177323, @jvesely wrote: > In https://reviews.llvm.org/D49650#1176336, @arsenm wrote: > > > In https://reviews.llvm.org/D49650#1175461, @jvesely wrote: > > > > > In

[PATCH] D47618: __c11_atomic_load's _Atomic can be const

jfb marked an inline comment as done. jfb added a comment. Give the comments, I think this is ready to commit. Repository: rC Clang https://reviews.llvm.org/D47618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47618: __c11_atomic_load's _Atomic can be const

jfb updated this revision to Diff 157761. jfb added a comment. - Add constant AS pointer test. Repository: rC Clang https://reviews.llvm.org/D47618 Files: lib/Sema/SemaChecking.cpp test/Sema/atomic-ops.c test/SemaOpenCL/atomic-ops.cl Index: test/SemaOpenCL/atomic-ops.cl

[PATCH] D49848: Parse a possible trailing postfix expression suffix after a fold expression

Rakete updated this revision to Diff 157759. Rakete added a comment. Addressed review comments :) Repository: rC Clang https://reviews.llvm.org/D49848 Files: include/clang/Parse/Parser.h lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expressions.cpp Index:

[PATCH] D49899: Force test/Driver/fuchsia.c(pp) to use lld

greened added a comment. In https://reviews.llvm.org/D49899#1178545, @ruiu wrote: > > The Fuchsia driver relies on lld so invoke clang with -fuse-ld=lld. This > > gets the test passing when the clang default linker is something other than > > lld. > > Does it work if lld is not installed at

[PATCH] D49931: [CUDA][HIP] Allow function-scope static const variable

yaxunl added a comment. In https://reviews.llvm.org/D49931#1178720, @tra wrote: > > This patch also allows function-scope static const variable without device > > memory qualifier and emits it as a global variable in constant address > > space. > > What does NVCC do with local static const

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

ldionne added a comment. In https://reviews.llvm.org/D49317#1178767, @Quuxplusone wrote: > @ldionne: I don't know if your "LGTM" is necessarily sufficient to commit > this or not; but either way, I don't have commit privs, so could I ask you > (or someone else) to commit this on my behalf?

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone added a comment. @ldionne: I don't know if your "LGTM" is necessarily sufficient to commit this or not; but either way, I don't have commit privs, so could I ask you (or someone else) to commit this on my behalf? Thanks! Repository: rCXX libc++ https://reviews.llvm.org/D49317

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/vector:296 +_LIBCPP_INLINE_VISIBILITY +inline void +__copy_construct_forward(_Alloc& __a, _Iter __begin1, _Iter __end1,

[PATCH] D49848: Parse a possible trailing postfix expression suffix after a fold expression

rsmith added a comment. Thanks, I like this approach a lot more. Comment at: include/clang/Parse/Parser.h:1658 +CastExpr,// Also allow '(' type-name ')' +FoldExpr // Also allow fold-expression }; This should be reordered up nearer

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone marked an inline comment as done. Quuxplusone added inline comments. Comment at: include/vector:296 +_LIBCPP_INLINE_VISIBILITY +inline void +__copy_construct_forward(_Alloc& __a, _Iter __begin1, _Iter __end1, ldionne wrote: > Do you really need

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen added inline comments. Comment at: libcxx/include/experimental/simd:1341 // [simd.class] // TODO: implement simd template timshen wrote: > mclow.lists wrote: > > Is this TODO still necessary? > I think so, as some operations are still not

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen added a comment. I'm not going to rebase all the succeeding patches immediately onto this one, as it is painful and spamming emails. Rather, I'll only rebase the next patch in the line. So if you review more than one patch ahead (as you already did), you may see some stale patch

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen added inline comments. Comment at: libcxx/include/experimental/simd:726 +#if defined(_LIBCPP_COMPILER_CLANG) +#define _SPECIALIZE_VEC_EXT(_TYPE, _NUM_ELEMENT) \ + template <>

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen updated this revision to Diff 157751. timshen marked 6 inline comments as done. timshen added a comment. Update based on the comments. https://reviews.llvm.org/D41376 Files: libcxx/include/__config libcxx/include/experimental/__config libcxx/include/experimental/simd

r338158 - [DEBUG_INFO] Fix tests, NFC.

Author: abataev Date: Fri Jul 27 13:16:44 2018 New Revision: 338158 URL: http://llvm.org/viewvc/llvm-project?rev=338158=rev Log: [DEBUG_INFO] Fix tests, NFC. Modified: cfe/trunk/test/Driver/cuda-unsupported-debug-options.cu cfe/trunk/test/Driver/openmp-unsupported-debug-options.c

[PATCH] D49931: [CUDA][HIP] Allow function-scope static const variable

tra added a comment. > This patch also allows function-scope static const variable without device > memory qualifier and emits it as a global variable in constant address space. What does NVCC do with local static const variables? https://reviews.llvm.org/D49931

[PATCH] D49927: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4

This revision was automatically updated to reflect the committed changes. Closed by commit rL338157: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib 2.4 (authored by rupprecht, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[libcxx] r338157 - [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4

Author: rupprecht Date: Fri Jul 27 13:02:58 2018 New Revision: 338157 URL: http://llvm.org/viewvc/llvm-project?rev=338157=rev Log: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4 Summary: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4 r338122 changed

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

ldionne added a comment. It would be nice if all the TMP required to determine whether to call `__move_construct_forward(..., true_type)` or `__move_construct_forward(..., false_type)` was done in `__move_construct_forward` itself (or a helper). This way, callers wouldn't have to do it

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC338155: [DEBUGINFO] Disable unsupported debug info options for NVPTX target. (authored by ABataev, committed by ).

r338155 - [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

Author: abataev Date: Fri Jul 27 12:45:14 2018 New Revision: 338155 URL: http://llvm.org/viewvc/llvm-project?rev=338155=rev Log: [DEBUGINFO] Disable unsupported debug info options for NVPTX target. Summary: Some targets support only default set of the debug options and do not support additional

[PATCH] D49931: [CUDA][HIP] Allow function-scope static const variable

yaxunl updated this revision to Diff 157740. yaxunl edited the summary of this revision. yaxunl added a comment. update diagnostic message. https://reviews.llvm.org/D49931 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenModule.cpp lib/Sema/SemaDecl.cpp

[PATCH] D49931: [CUDA][HIP] Allow function-scope static const variable

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. CUDA 8.0 E.3.9.4 says: Within the body of a __device__ or __global__ function, only __shared__ variables or variables without any device memory qualifiers may be declared with static storage class. It is unclear how a

[PATCH] D49927: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4

rupprecht added a comment. In https://reviews.llvm.org/D49927#1178659, @ldionne wrote: > Just to make sure I understand properly: this means we will use newlib's > implementation of `iswcntrl_l` & friends instead of our own emulation (which > is an ODR violation currently going unnoticed)? And

[PATCH] D49927: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Typo in commit message? They were added to 2.5, not 2.4 (the code is right, just the comment is wrong). Repository: rCXX libc++ https://reviews.llvm.org/D49927

[PATCH] D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

scott.linder created this revision. scott.linder added reviewers: Anastasia, echristo. Herald added subscribers: cfe-commits, JDevlieghere, aprantl, yaxunl. OpenCL block literal structs have different fields which are now correctly identified in the debug info. Repository: rC Clang

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

ABataev added a comment. Eric accepted the patch offline. Repository: rC Clang https://reviews.llvm.org/D49148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49927: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4

ldionne added a comment. Just to make sure I understand properly: this means we will use newlib's implementation of `iswcntrl_l` & friends instead of our own emulation (which is an ODR violation currently going unnoticed)? And this is OK because newlib provides `iswcntrl_l` & friends starting

[PATCH] D43745: Fix cppcoreguidelines-pro-bounds-pointer-arithmetic not working for functions with auto return specifier.

mgehre added a comment. Does it also work with lambdas (being implicitly auto) that return pointers? A test case for that would be nice. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43745 ___ cfe-commits mailing list

[PATCH] D49927: [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4

rupprecht created this revision. rupprecht added reviewers: ldionne, rsmith. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, christof. [libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4 r338122 changed the linkage of some methods which revealed an

[PATCH] D49920: [clangd] [WIP] Find references of local symbols

malaperle planned changes to this revision. malaperle added a comment. Needs tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49920: [clangd] [WIP] Find references of local symbols

malaperle updated this revision to Diff 157732. malaperle added a comment. Fix silly bug I introduced in last minute clean-up. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49920 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

rsmith added a comment. In https://reviews.llvm.org/D49511#1170693, @leonardchan wrote: > Done. I opted for not using `ExpressionEvaluationContextRecord` because I > don't think I was using it correctly. A few other tests in sema failed when I > tried pushing and popping from the stack holding

[PATCH] D49766: Fix a crash when an error occurs in Template and the initializer is a nullptr for C++17

bviyer updated this revision to Diff 157730. bviyer added a comment. Fixed the comment as you suggested. I do not have check in rights yet. Can you please check it in for me? Repository: rC Clang https://reviews.llvm.org/D49766 Files: include/clang/AST/TemplateBase.h

[PATCH] D49439: [Sema] Fix a crash while converting constructors to deduction guides

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:1899-1907 // Canonicalize the type. This (for instance) replaces references to // typedef members of the current

[PATCH] D49899: Force test/Driver/fuchsia.c(pp) to use lld

ruiu added a comment. > The Fuchsia driver relies on lld so invoke clang with -fuse-ld=lld. This gets > the test passing when the clang default linker is something other than lld. Does it work if lld is not installed at all? I believe if the driver cannot find a specified linker, it reports an

[PATCH] D49766: Fix a crash when an error occurs in Template and the initializer is a nullptr for C++17

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Do you have your commit rights yet? Comment at: include/clang/AST/TemplateBase.h:469 + +// Allow more additional argument kinds for the

Re: r337746 - [clang-cl] Expose -fblocks and -fno-builtin as driver flags

On Wed, Jul 25, 2018 at 4:39 AM Nico Weber wrote: > I thought about adding -fblocks when that thread happened, but since > there's no runtime for them that just works exposing it doesn't seem very > helpful. Maybe we should instead change the warning text to not suggest > -fblocks when building

[PATCH] D49914: [libc++] Add the _LIBCPP_HIDE_FROM_ABI_AFTER_V1 macro

ldionne added inline comments. Comment at: libcxx/include/__config:798 -// Just so we can migrate to _LIBCPP_HIDE_FROM_ABI gradually. -#define _LIBCPP_INLINE_VISIBILITY _LIBCPP_HIDE_FROM_ABI - -#ifndef _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY -# if

r338149 - [analyzer] Extend NoStoreFuncVisitor to insert a note on IVars

Author: george.karpenkov Date: Fri Jul 27 11:26:40 2018 New Revision: 338149 URL: http://llvm.org/viewvc/llvm-project?rev=338149=rev Log: [analyzer] Extend NoStoreFuncVisitor to insert a note on IVars The note is added in the following situation: - We are throwing a nullability-related warning

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

rsmith added a comment. Thanks, this is definitely a step in the right direction. Comment at: include/clang/AST/Expr.h:3257-3261 + // Get the FENV_ACCESS status of this operator. Only meaningful for + // operations on floating point types. + bool isFENVAccessOn() const { +

[PATCH] D49766: Fix a crash when an error occurs in Template and the initializer is a nullptr for C++17

bviyer updated this revision to Diff 157721. bviyer added a comment. I have fixed all the changes requested by Erik along with shortening the test case. Repository: rC Clang https://reviews.llvm.org/D49766 Files: include/clang/AST/TemplateBase.h

Re: r338139 - [OPENMP] Static variables on device must be externally visible.

Hi Alexey, from what I can see this change can't handle the case where there are static variables with the same name in multiple TUs. (The same problem exists for static CUDA kernels with -fcuda-rdc. I found that nvcc mangles the function names in this case, but didn't have time yet to

[PATCH] D49922: [P0936R0] add [[clang::lifetimebound]] attribute

rsmith added inline comments. Comment at: include/clang/AST/TypeLoc.h:96-97 /// Convert to the specified TypeLoc type, returning a null TypeLoc if - /// this TypeLock is not of the desired type. It will consider type - /// adjustments from a type that wad written as a T to

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

juliehockett added a comment. any further thoughts on this? https://reviews.llvm.org/D48341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49922: [P0936R0] add [[clang::lifetimebound]] attribute

rsmith created this revision. rsmith added a reviewer: aaron.ballman. Herald added a reviewer: javed.absar. Herald added a subscriber: kristof.beyls. This patch adds support for a new attribute, [[clang::lifetimebound]], that indicates that the lifetime of a function result is related to one of

r338141 - Fix typos in comment.

Author: rsmith Date: Fri Jul 27 11:06:54 2018 New Revision: 338141 URL: http://llvm.org/viewvc/llvm-project?rev=338141=rev Log: Fix typos in comment. Modified: cfe/trunk/include/clang/AST/TypeLoc.h Modified: cfe/trunk/include/clang/AST/TypeLoc.h URL:

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor planned changes to this revision. teemperor marked an inline comment as done. teemperor added a comment. (Just marking this as "Plan changes" because otherwise it's just stuck in my "Waiting on review" queue). https://reviews.llvm.org/D43871

[PATCH] D49920: [clangd] [WIP] Find references of local symbols

malaperle created this revision. Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ioeric, ilya-biryukov. We do not have a global index of references but we can find the references of local symbols within the AST in the mean time. Also, since we will not record local

r338140 - [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration

Author: george.karpenkov Date: Fri Jul 27 10:40:59 2018 New Revision: 338140 URL: http://llvm.org/viewvc/llvm-project?rev=338140=rev Log: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration ObjCIvarExpr is *not* a subclass of MemberExpr, and a separate matcher

r338139 - [OPENMP] Static variables on device must be externally visible.

Author: abataev Date: Fri Jul 27 10:37:32 2018 New Revision: 338139 URL: http://llvm.org/viewvc/llvm-project?rev=338139=rev Log: [OPENMP] Static variables on device must be externally visible. Do not mark static variable as internal on the device as they must be visible from the host to be

[PATCH] D49589: [UBSan] Strengthen pointer checks in 'new' expressions

sepavloff added a comment. @rjmccall Thank you! Repository: rC Clang https://reviews.llvm.org/D49589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r338138 - [demangler] Support for reference collapsing

Author: epilk Date: Fri Jul 27 10:27:40 2018 New Revision: 338138 URL: http://llvm.org/viewvc/llvm-project?rev=338138=rev Log: [demangler] Support for reference collapsing llvm.org/PR38323 Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp

r338137 - [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration.

Author: george.karpenkov Date: Fri Jul 27 10:26:11 2018 New Revision: 338137 URL: http://llvm.org/viewvc/llvm-project?rev=338137=rev Log: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration. ObjCIvarExpr is *not* a subclass of MemberExpr, and a separate

[PATCH] D49701: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL338137: [ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting its… (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D47154: Try to make builtin address space declarations not useless

yaxunl added a comment. In https://reviews.llvm.org/D47154#1108813, @tra wrote: > CUDA does not expose explicit AS on clang size. All pointers are treated as > generic and we infer specific address space only in LLVM. > `__nvvm_atom_*_[sg]_*` builtins should probably be removed as they are >

[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

arphaman added a comment. In https://reviews.llvm.org/D49758#1178056, @ilya-biryukov wrote: > In https://reviews.llvm.org/D49758#1177747, @arphaman wrote: > > > In https://reviews.llvm.org/D49758#1174629, @ilya-biryukov wrote: > > > > > The mode of operation where compile commands come from the

Re: [PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

LGTM Jon On Thu, Jul 26, 2018 at 10:12 PM David Greene via Phabricator < revi...@reviews.llvm.org> wrote: > greened created this revision. > greened added reviewers: jroelofs, hans, probinson, ismail, rtrieu. > Herald added a subscriber: cfe-commits. > > This test fails if clang is configure

  1   2   >