r338839 - clang-format-diff: Make it work with python3 too

2018-08-03 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Fri Aug 3 03:04:58 2018 New Revision: 338839 URL: http://llvm.org/viewvc/llvm-project?rev=338839=rev Log: clang-format-diff: Make it work with python3 too Summary: It is not necessary, but would be nice if the script run on python3 as well (as opposed to only python2,

[PATCH] D48098: clang-format-diff: Make it work with python3 too

2018-08-03 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL338839: clang-format-diff: Make it work with python3 too (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r338837 - clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Martin Probst via cfe-commits
Author: mprobst Date: Fri Aug 3 02:34:41 2018 New Revision: 338837 URL: http://llvm.org/viewvc/llvm-project?rev=338837=rev Log: clang-format: [JS] don't break comments before any '{' Summary: Previously, clang-format would avoid breaking before the first `{` found, but then happily break before

[PATCH] D50230: clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Martin Probst via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC338837: clang-format: [JS] dont break comments before any { (authored by mprobst, committed by ). Changed prior to commit: https://reviews.llvm.org/D50230?vs=158946=158957#toc Repository: rC Clang

[PATCH] D50230: clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Great! Thanks! Repository: rC Clang https://reviews.llvm.org/D50230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50189: Fully qualify the renamed symbol if the shortened name is ambiguous.

2018-08-03 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL338832: Fully qualify the renamed symbol if the shortened name is ambiguous. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r338832 - Fully qualify the renamed symbol if the shortened name is ambiguous.

2018-08-03 Thread Eric Liu via cfe-commits
Author: ioeric Date: Fri Aug 3 02:16:07 2018 New Revision: 338832 URL: http://llvm.org/viewvc/llvm-project?rev=338832=rev Log: Fully qualify the renamed symbol if the shortened name is ambiguous. Summary: For example, when renaming `a::b::x::foo` to `y::foo` below, replacing `x::foo()` with

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

2018-08-03 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus marked 2 inline comments as done. Szelethus added a comment. It looks like I won't be back in office until Monday, so I can't finish this one until then :( >> but I haven't seen the current version of the checker crash due to pointer >> chasing. > > @NoQ saw quite a few crashes

[PATCH] D50230: clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Martin Probst via Phabricator via cfe-commits
mprobst updated this revision to Diff 158946. mprobst added a comment. Also handle multiple numbered list tokens. Repository: rC Clang https://reviews.llvm.org/D50230 Files: lib/Format/BreakableToken.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

[PATCH] D50230: clang-format: [JS] don't break comments before any '{'

2018-08-03 Thread Martin Probst via Phabricator via cfe-commits
mprobst created this revision. mprobst added a reviewer: krasimir. Previously, clang-format would avoid breaking before the first `{` found, but then happily break before subsequent '{'s on the line. This change fixes that by looking for the first location that has no opening curly, if any.

[PATCH] D50229: +fp16fml feature for ARM and AArch64

2018-08-03 Thread Bernard Ogden via Phabricator via cfe-commits
bogden created this revision. bogden added a reviewer: SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, kristof.beyls. v8.4-A adds a few fp16 instructions that can optionally be implemented in CPUs of v8.2-A and above. This patch adds a feature to

[PATCH] D50189: Fully qualify the renamed symbol if the shortened name is ambiguous.

2018-08-03 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D50189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50179: [AArch64][ARM] Context sensitive meaning of option "crypto"

2018-08-03 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. Hi Eli, thanks for the feedback. > Yes, this logic should be in TargetParser, not here. Trying to rewrite the > target features afterwards is messy at best. (Actually, the target feature > list generated by TargetParser probably shouldn't contain the string

[PATCH] D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa.

2018-08-03 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Thanks for the change! Overall LG, mostly NITs about the tests. Comment at: clangd/CodeComplete.cpp:959 bool Incomplete = false; // Would more be available with a higher limit? - llvm::Optional Filter; // Initialized once Sema runs. -

[PATCH] D50189: Fully qualify the renamed symbol if the shortened name is ambiguous.

2018-08-03 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: lib/Tooling/Core/Lookup.cpp:139 +const NamespaceDecl *NS = *I; +auto LookupRes = NS->lookup(DeclarationName((Head))); +if (!LookupRes.empty()) { ilya-biryukov wrote: > This will not take using namespaces into

[PATCH] D50189: Fully qualify the renamed symbol if the shortened name is ambiguous.

2018-08-03 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 158941. ioeric marked 2 inline comments as done. ioeric added a comment. - address review comments. Repository: rC Clang https://reviews.llvm.org/D50189 Files: lib/Tooling/Core/Lookup.cpp unittests/Tooling/LookupTest.cpp Index:

[PATCH] D50102: [clang-tidy] Use ExprMutationAnalyzer in performance-unnecessary-value-param

2018-08-03 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:108 return; + if (const auto *Ctor = dyn_cast(Function)) { +for (const auto *Init :

[PATCH] D50226: [DebugInfo] Use DbgVariableIntrinsic as the base class of variables.

2018-08-03 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: aprantl, probinson, dblaikie. Herald added subscribers: cfe-commits, JDevlieghere. After refactoring DbgInfoIntrinsic class hierarchy, we use DbgVariableIntrinsic as the base class of variable debug info. In resolveTopLevelMetadata() in

<    1   2   3