Re: [clang-tools-extra] r341375 - [clangd] Define a compact binary serialization fomat for symbol slab/index.

On 09/05/2018 03:26 PM, Sam McCall wrote: Ah, thanks! Fixed in r341467. I'd guess this was a GCC bug, because GCC >=6 accepts it: https://godbolt.org/z/Yb5gBT Yep works now. Thanks! /Mikael On Wed, Sep 5, 2018 at 2:21 PM Mikael Holmén > wrote:

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

ilya-biryukov added a comment. I would stamp this from my side, but concerns whether we should recommend YCM's LSP-based completer instead are probably still there. @sammccall, WDYT? https://reviews.llvm.org/D51297 ___ cfe-commits mailing list

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

mgorny added a comment. Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for everyone who has LLVM configured. Repository: rC Clang https://reviews.llvm.org/D51714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

tstellar created this revision. tstellar added reviewers: chandlerc, beanz, mgorny, chapuni. Herald added subscribers: dexonsmith, mehdi_amini. clang currently uses llvm-config to determine the installation paths for llvm's headers and binaries. clang is also using LLVM's cmake files to

[PATCH] D32577: CMake: Replace open-coded find_package

tstellar updated this revision to Diff 164141. tstellar added a comment. Rebase on trunk. Repository: rC Clang https://reviews.llvm.org/D32577 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++

[PATCH] D51608: [modules] when deserializing method, ensure it has correct exception spec

elsteveogrande abandoned this revision. elsteveogrande added a comment. that's great news, thanks! Repository: rC Clang https://reviews.llvm.org/D51608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50947: lambdas in modules: make PendingFakeDefinitionData a set

elsteveogrande abandoned this revision. elsteveogrande added a comment. I'll drop this one, since this is not the logic change we want. Repository: rC Clang https://reviews.llvm.org/D50947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

srhines added a comment. http://b/32510864 was the internal bug request, so I am noting it here for future reference, but I think that the patch itself is pretty self-explanatory (rather than filing a distinct upstream bug about this issue). Repository: rC Clang

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

srhines added a comment. This was discovered in the Android build system (which passes -fomit-frame-pointer by default for ARM configurations. This leads to the inability to specify -pg, since there is no way to override the mere presence of -fomit-frame-pointer. Repository: rC Clang

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

srhines created this revision. Herald added a subscriber: cfe-commits. srhines added a subscriber: nickdesaulniers. Previously, any instance of -fomit-frame-pointer would make it such that -pg was an invalid flag combination. If -fno-omit-frame-pointer is passed later on the command line (such

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 164136. leonardchan added a comment. - Push and pop a new ExpressionEvaluationContext when we enter and exit a compound statement. - Remove Start/StopCheckingNoderef functions since we can now warn whenever we pop Repository: rC Clang

Re: r335081 - Recommit r335063: [Darwin] Add a warning for missing include path for libstdc++

Sorry for the late response, On Sat, 18 Aug 2018 at 20:10, Nico Weber wrote: > Also, the diag text should probably say "pass '-stdlib=libc++' " not "pass > '-std=libc++' "? > Good catch, thanks! I'll commit a fixup for it. > > On Sat, Aug 18, 2018 at 11:06 PM Nico Weber wrote: > >> Should

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

dexonsmith added a comment. In https://reviews.llvm.org/D51440#1225318, @steven_wu wrote: > I do prefer the current approach especially on Darwin. Some concerns of > switching to use "-L + -l" are: > > 1. clang and compiler-rt are rev-locked. Inferring the compiler-rt from > resource-dir and

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

steven_wu added a comment. I do prefer the current approach especially on Darwin. Some concerns of switching to use "-L + -l" are: 1. clang and compiler-rt are rev-locked. Inferring the compiler-rt from resource-dir and passing to linker with the full path can prevent mistakes of mixing them

[PATCH] D51608: [modules] when deserializing method, ensure it has correct exception spec

rsmith added a comment. Fixed in r341499. Repository: rC Clang https://reviews.llvm.org/D51608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r341499 - PR38627: Fix handling of exception specification adjustment for

Author: rsmith Date: Wed Sep 5 15:30:37 2018 New Revision: 341499 URL: http://llvm.org/viewvc/llvm-project?rev=341499=rev Log: PR38627: Fix handling of exception specification adjustment for destructors. We previously tried to patch up the exception specification after completing the class,

r341498 - Remove unnecessary options from test RUN lines.

Author: rtrieu Date: Wed Sep 5 15:14:46 2018 New Revision: 341498 URL: http://llvm.org/viewvc/llvm-project?rev=341498=rev Log: Remove unnecessary options from test RUN lines. These tests do not check the color printing, so color options should not be used when running them. Modified:

Re: r341475 - Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

On Wed, Sep 05, 2018 at 02:56:21PM -, Diogo N. Sampaio via cfe-commits wrote: > Author: dnsampaio > Date: Wed Sep 5 07:56:21 2018 > New Revision: 341475 > > URL: http://llvm.org/viewvc/llvm-project?rev=341475=rev > Log: > Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

[PATCH] D51608: [modules] when deserializing method, ensure it has correct exception spec

rsmith added a comment. I had a look at fixing this, and it... snowballed into a much larger change than I was expecting. I have a patch on the way. Repository: rC Clang https://reviews.llvm.org/D51608 ___ cfe-commits mailing list

[PATCH] D50947: lambdas in modules: make PendingFakeDefinitionData a set

elsteveogrande abandoned this revision. elsteveogrande added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:1760-1765 - if (PFDI != Reader.PendingFakeDefinitionData.end() && - PFDI->second == ASTReader::PendingFakeDefinitionKind::Fake) { + if (PFDI !=

Re: r341421 - [ODRHash] Extend hash to support all Type's.

Galina, Thank you for letting me know. The test case used an enum with default type which has different behavior on Window systems. I've added a triple in r341496 which should fix the test. Richard On Wed, Sep 5, 2018 at 1:45 PM Galina Kistanova wrote: > Hello Richard, > > This commit added

r341496 - Add triple to test case.

Author: rtrieu Date: Wed Sep 5 14:55:09 2018 New Revision: 341496 URL: http://llvm.org/viewvc/llvm-project?rev=341496=rev Log: Add triple to test case. This test uses enums, which have different behavior when targeting different systems. Specifying a triple will give predictable behavior to

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 

benhamilton added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:35 + // non-standard capitalized character sequences including acronyms, + // initialisms, and prefixes of symbols (e.g., UIColorFromNSString). For this + // reason, the regex only

Re: r341475 - Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

Hello Diogo, This commit added couple of broken tests to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win . . . Failing Tests (5): Clang :: Headers/arm-fp16-header.c Clang :: Headers/arm-neon-header.c . . . Please have a look? The builder was

Re: r341421 - [ODRHash] Extend hash to support all Type's.

Hello Richard, This commit added broken test to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/12240 . . . Failing Tests (3): Clang :: Modules/odr_hash.cpp LLVM :: CodeGen/AMDGPU/mubuf-legalize-operands.ll LLVM ::

r341492 - Revert "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)"

Author: labath Date: Wed Sep 5 13:20:28 2018 New Revision: 341492 URL: http://llvm.org/viewvc/llvm-project?rev=341492=rev Log: Revert "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)" This reverts commit r341472 due to breakage in green dragon bots.

[PATCH] D51676: [clangd] Use TopN instead of std::priority_queue

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! I believe this will result in the results from MemIndex being returned in best -> worst order, rather than worst -> best. The contract says callers

[PATCH] D51691: [clangd] NFC: Document URIDistance

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FileDistance.h:66 // Supports lookups to find the minimum distance to a file from any source. -// This object should be

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/URI.cpp:200 + return make_string_error("Couldn't convert " + AbsolutePath + + " to any given scheme.");

[PATCH] D45319: [Atomics] warn about misaligned atomic accesses using libcalls

rsmith added a comment. Herald added a subscriber: jfb. There's still something wrong here: in the cases where we produce these warnings, we still produce calls to `__atomic_*_` library functions. Those functions are specified to only work on properly-aligned inputs, so that's wrong. And there

[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

rjmccall closed this revision. rjmccall added a comment. Committed as r341491. https://reviews.llvm.org/D51426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r341491 - Forbid address spaces on compound literals in local scope.

Author: rjmccall Date: Wed Sep 5 12:22:40 2018 New Revision: 341491 URL: http://llvm.org/viewvc/llvm-project?rev=341491=rev Log: Forbid address spaces on compound literals in local scope. Patch by Bevin Hansson! Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

kbobyrev added inline comments. Comment at: clang-tools-extra/unittests/clangd/DexIndexTests.cpp:623 + + auto I = DexIndex::build(std::move(Builder).build(), URISchemes); + ioeric wrote: > We could use the constructor that doesn't take ownership e.g. >

[PATCH] D51649: [Sema] Don't warn about omitting unavailable enum constants in a switch

This revision was automatically updated to reflect the committed changes. Closed by commit rL341490: [Sema] Dont warn about omitting unavailable enum constants in a switch (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r341490 - [Sema] Don't warn about omitting unavailable enum constants in a switch

Author: epilk Date: Wed Sep 5 12:13:27 2018 New Revision: 341490 URL: http://llvm.org/viewvc/llvm-project?rev=341490=rev Log: [Sema] Don't warn about omitting unavailable enum constants in a switch rdar://42717026 Differential revision: https://reviews.llvm.org/D51649 Added:

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

rjmccall closed this revision. rjmccall added a comment. Committed as r341489. Repository: rC Clang https://reviews.llvm.org/D44539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r341489 - Add -Wobjc-property-assign-on-object-type.

Author: rjmccall Date: Wed Sep 5 12:02:00 2018 New Revision: 341489 URL: http://llvm.org/viewvc/llvm-project?rev=341489=rev Log: Add -Wobjc-property-assign-on-object-type. This is a warning about using 'assign' instead of 'unsafe_unretained' in Objective-C property declarations. It's off by

[clang-tools-extra] r341488 - [clang-tidy] minor bug fix to AbseilMatcher.h

Author: ioeric Date: Wed Sep 5 12:01:34 2018 New Revision: 341488 URL: http://llvm.org/viewvc/llvm-project?rev=341488=rev Log: [clang-tidy] minor bug fix to AbseilMatcher.h This missing directory is not yet released, but is causing some problems internally. It's gonna be released eventually and

[PATCH] D51655: [analyzer] Remove traces of ubigraph visualization

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I actually thought it's just a different name for graphviz :/ I've definitely never heard of anybody using ubigraph for this purpose. And it's an analyzer-specific feature. Let's remove.

[PATCH] D51300: [analyzer][UninitializedObjectChecker] No longer using nonloc::LazyCompoundVal

NoQ added a comment. Very easy: 1. Put preprocessed file that crashes into `repro.cpp` (`.c`, `.m`, whatever). 2. Write `repro.sh` as follows: #!/bin/bash blah/blah/path/to/clang -cc1 -analyze -blah-blah-arguments-you-need-to-cause-a-crash repro.cpp 2>&1 | grep "Any assertion message or

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

george.karpenkov added a comment. The code looks fine to me; @mgrang What evaluation steps have you performed? You note there are a few notable false positives, do you have ideas for suppressing those? https://reviews.llvm.org/D50488 ___

[PATCH] D51697: [Sema] Clean up some __builtin_*_chk diagnostics

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rsmith. Herald added subscribers: kristina, dexonsmith. Namely, print the likely macro name when it's used, and include the actual computed sizes in the diagnostic message, which are sometimes not obvious.

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

george.karpenkov added a comment. Why explicitly skip C projects? We would not be able to match `std::X` functions anyway. https://reviews.llvm.org/D50488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus added a comment. > How then do you think I should try matching the IntPointerArray example? I am > now leaning towards not doing this via AST Matchers as I am not sure if I can > easily match more complex cases. I've sadly reached the end of my knowledge on AST based analysis, but

[PATCH] D51680: [analyzer][UninitializedObjectChecker] New flag to ignore union-like constructs

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:468 +static bool isUnionLike(const RecordDecl *RD) { + llvm::Regex ContainsKindOrTag("[kK]ind|[tT]ag"); + 1. Since you are using

[PATCH] D51388: [analyzer] NFC: Legalize state manager factory injection.

george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h:33 /// introduce a type named \c NameTy. - /// The macro should

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 164086. mgrang added a comment. Enabled checker only for C++. https://reviews.llvm.org/D50488 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp

[PATCH] D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: include/clang/AST/Decl.h:977 + +unsigned EscapingByref : 1; }; ahatanak wrote: > rjmccall wrote: > > This doesn't actually seem

[PATCH] D51300: [analyzer][UninitializedObjectChecker] No longer using nonloc::LazyCompoundVal

Szelethus planned changes to this revision. Szelethus added a comment. > Sounds like a test case would be great to have. Aye. I'd be good to land this with that testcase. There are a variety of other projects I'm working on (related to the checker), and none of them depend on this patch, so

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In https://reviews.llvm.org/D50488#1224480, @martong wrote: > From this little information I have hear are my thoughts: > > > match callExpr(allOf (callee(functionDecl(hasName("std::sort"))), > > hasArgument(0, > >

[PATCH] D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't

ahatanak added inline comments. Comment at: include/clang/AST/Decl.h:977 + +unsigned EscapingByref : 1; }; rjmccall wrote: > This doesn't actually seem to be initialized anywhere. VarDecl's constructor in Decl.cpp initializes it to false. ``` AllBits =

[PATCH] D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't

ahatanak updated this revision to Diff 164069. ahatanak marked 11 inline comments as done. ahatanak added a comment. Address review comments. Fix bugs in the handling of `__block` variables that have reference types. Repository: rC Clang https://reviews.llvm.org/D51564 Files:

[PATCH] D51691: [clangd] NFC: Document URIDistance

kbobyrev created this revision. kbobyrev added reviewers: sammccall, ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. `URIDistance` constructor should mention that `Sources` must contain *absolute paths*, not

[PATCH] D51690: [clangd] NFC: mark single-parameter constructors explicit

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Code health: prevent implicit conversions to user-defined types.

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

ABataev added a comment. In https://reviews.llvm.org/D51554#1224049, @echristo wrote: > The change in name here from "line tables" to "directives only" feels a bit > confusing. "Limited" seems to be a bit more clear, or even remaining line > tables only. Can you explain where you were going

[PATCH] D48896: [libcxx][c++17] P0083R5: Splicing Maps and Sets Part 2: merge

erik.pilkington updated this revision to Diff 164064. erik.pilkington added a comment. Ping! In the new patch: - Uncomment __cpp_lib_node_extract, reverting r340544 - Rebase/Clean up the diff a bit https://reviews.llvm.org/D48896 Files: libcxx/include/__hash_table

r341484 - Test Commit for git-svn-cleanup comment.

Author: erichkeane Date: Wed Sep 5 10:14:21 2018 New Revision: 341484 URL: http://llvm.org/viewvc/llvm-project?rev=341484=rev Log: Test Commit for git-svn-cleanup comment. Removes the class name for the Expr class, which isn't necessary. Modified: cfe/trunk/include/clang/AST/Expr.h

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

ABataev accepted this revision. ABataev added a comment. LG https://reviews.llvm.org/D51378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

kbobyrev updated this revision to Diff 164062. kbobyrev marked 18 inline comments as done. kbobyrev added a comment. Address a round of comments https://reviews.llvm.org/D51481 Files: clang-tools-extra/clangd/FileDistance.h clang-tools-extra/clangd/URI.cpp clang-tools-extra/clangd/URI.h

r341483 - [OPENMP][NVPTX] Disable runtime-type info for CUDA devices.

Author: abataev Date: Wed Sep 5 10:10:30 2018 New Revision: 341483 URL: http://llvm.org/viewvc/llvm-project?rev=341483=rev Log: [OPENMP][NVPTX] Disable runtime-type info for CUDA devices. RTTI is not supported by the NVPTX target. Added: cfe/trunk/test/OpenMP/nvptx_target_rtti_messages.cpp

[PATCH] D51688: [clangd] Set SymbolID for sema macros so that they can be merged with index macros.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/AST.h:41 +/// Gets the symbol ID for a macro, if possible. +llvm::Optional getSymbolID(const IdentifierInfo , +

[PATCH] D51689: [clangd] Dense posting lists proof-of-concept

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. This uses a bitmap representation instead of a list if the density of the list is high enough (at least 1 in 32, which is the

[PATCH] D50947: lambdas in modules: make PendingFakeDefinitionData a set

elsteveogrande added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:1766 + +// FIXME: handle serialized lambdas assert(!DD.IsLambda && !MergeDD.IsLambda && "faked up lambda definition?"); rsmith wrote: > Did you mean to add this FIXME?

[PATCH] D51688: [clangd] Set SymbolID for sema macros so that they can be merged with index macros.

ioeric updated this revision to Diff 164055. ioeric added a comment. - Set name for the test symbol. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51688 Files: clangd/AST.cpp clangd/AST.h clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp

[PATCH] D51688: [clangd] Set SymbolID for sema macros so that they can be merged with index macros.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51688 Files: clangd/AST.cpp clangd/AST.h clangd/CodeComplete.cpp

[PATCH] D37310: [Atomic] Merge alignment information from Decl and from Type when emit atomic expression.

twoh added a comment. Herald added subscribers: llvm-commits, jfb. Hello, I observed a case where atomic builtin generates libcall when the corresponding sync builtin generates an atomic instruction (https://bugs.llvm.org/show_bug.cgi?id=38846). It seems that the alignment checking for

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 

benhamilton requested changes to this revision. benhamilton added a comment. This revision now requires changes to proceed. Thanks for this! Let's consolidate this with the property name checker (either simplify the logic there and allow `arBiTRAryCapSAnYWHere` or apply the same registered

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D50901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

lebedev.ri added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D50250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51544: [OpenCL] Split opencl-c.h header

asavonic added a comment. In https://reviews.llvm.org/D51544#1224730, @Anastasia wrote: > It seems generally good to partition this big header but I am trying to > understand what problem is it trying to solve now? Main motivation is to reduce memory footprint by factoring out everything that

[PATCH] D51680: [analyzer][UninitializedObjectChecker] New flag to ignore union-like constructs

Szelethus updated this revision to Diff 164050. Szelethus added a comment. Added doc to `www/analyzer/alpha_checks.html`. https://reviews.llvm.org/D51680 Files: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

joerg added inline comments. Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412 - OS << "#define __ai static inline __attribute__((__always_inline__, " + OS << "#define __ai static __inline __attribute__((__always_inline__, " "__nodebug__))\n\n";

[PATCH] D51686: [OpenMP] Improve search for libomptarget-nvptx

Hahnfeld created this revision. Hahnfeld added reviewers: gtbercea, ABataev. Herald added subscribers: cfe-commits, guansong. When looking for the bclib Clang considered the default library path first while it preferred directories in LIBRARY_PATH when constructing the invocation of nvlink. The

[PATCH] D51544: [OpenCL] Split opencl-c.h header

Anastasia added a comment. It seems generally good to partition this big header but I am trying to understand what problem is it trying to solve now? The unsupported declarations are guarded out by `#if defined(ext_name)` and therefore won't be parsed and put into PCH is extensions are not

[PATCH] D51675: [Sema] Store MacroInfo in CodeCompletionResult for macro results.

This revision was automatically updated to reflect the committed changes. Closed by commit rL341476: [Sema] Store MacroInfo in CodeCompletionResult for macro results. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r341476 - [Sema] Store MacroInfo in CodeCompletionResult for macro results.

Author: ioeric Date: Wed Sep 5 07:59:17 2018 New Revision: 341476 URL: http://llvm.org/viewvc/llvm-project?rev=341476=rev Log: [Sema] Store MacroInfo in CodeCompletionResult for macro results. Summary: This provides information about the macro definition. For example, it can be used to compute

r341475 - Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

Author: dnsampaio Date: Wed Sep 5 07:56:21 2018 New Revision: 341475 URL: http://llvm.org/viewvc/llvm-project?rev=341475=rev Log: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89 Summary: The inline attribute is not valid for C standard 89. Replace the argument in the

[PATCH] D51675: [Sema] Store MacroInfo in CodeCompletionResult for macro results.

ioeric added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:847 + /// If the result is RK_Macro, this can store the information about the macro + /// definition. sammccall wrote: > Let's not make this maybe/optional: `If the result is

[PATCH] D51675: [Sema] Store MacroInfo in CodeCompletionResult for macro results.

ioeric updated this revision to Diff 164044. ioeric added a comment. - update comment about missing MacroInfo. Repository: rC Clang https://reviews.llvm.org/D51675 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp tools/libclang/CXCursor.cpp Index:

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

This revision was automatically updated to reflect the committed changes. Closed by commit rL341475: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89 (authored by dnsampaio, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

Anastasia added inline comments. Comment at: include/clang/Basic/OpenCLExtensionTypes.def:1 +//===-- OpenCLExtensionTypes.def - Metadata about BuiltinTypes --*- C++ -*-===// +// I am confused about the purpose of this file. Is it supposed to contain intel

[PATCH] D51576: Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)

This revision was automatically updated to reflect the committed changes. Closed by commit rL341472: Enable DWARF accelerator tables by default when tuning for lldb (-glldb =… (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r341472 - Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)

Author: labath Date: Wed Sep 5 07:38:44 2018 New Revision: 341472 URL: http://llvm.org/viewvc/llvm-project?rev=341472=rev Log: Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames) Summary: DWARF v5 accelerator tables provide a considerable performance

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rC Clang https://reviews.llvm.org/D51683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster updated this revision to Diff 164037. patricklyster added a comment. Previous implementation only supported immediately nested declare targets such as below: #pragma omp declare target #pragma omp declare target int foo(); #pragma omp end declare target int

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

ioeric requested changes to this revision. ioeric added a comment. This revision now requires changes to proceed. This should be the last round! ;) Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:45 +std::vector> +createPathIterators(llvm::ArrayRef ProximityPaths,

RE: D51354: Fix the -print-multi-directory flag to print the selected multilib.

Understood, The test worked for me because I have both 64 bit and 32 bit libs installed on my default sysroot. Otherwise might fail indeed. Will amend the test with an explicit sysroot, > -Original Message- > From: Tim Shen via Phabricator [mailto:revi...@reviews.llvm.org] > Sent:

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

dnsampaio created this revision. dnsampaio added reviewers: pbarrio, SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, kristof.beyls. The **inline** attribute is not valid for C standard 89. Replace the argument in the generation of header files

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

yaxunl added a comment. In https://reviews.llvm.org/D51411#1224615, @Anastasia wrote: > In https://reviews.llvm.org/D51411#1217477, @yaxunl wrote: > > > Is this a feature requested by users? > > > > I can understand that this may be useful to pinpoint some conversions which > > are potentially

[PATCH] D32905: [Analyzer] Iterator Checker - Part 9: Evaluation of std::find-like calls

baloghadamsoftware added inline comments. Herald added subscribers: Szelethus, mikhail.ramalho. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1584-1588 + auto stateFound = state->BindExpr(CE, LCtx, RetVal); + auto stateNotFound = state->BindExpr(CE, LCtx,

[PATCH] D51675: [Sema] Store MacroInfo in CodeCompletionResult for macro results.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Sema/CodeCompleteConsumer.h:847 + /// If the result is RK_Macro, this can store the information about the macro + /// definition.

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

Anastasia added a comment. In https://reviews.llvm.org/D51411#1217477, @yaxunl wrote: > Is this a feature requested by users? > > I can understand that this may be useful to pinpoint some conversions which > are potentially harmful to performance. However such conversions can often be >

Zurich LLVM Compiler Social, Tech-Talks: Compilers meet Isabelle & The Lean Theorem Prover (Thursday 13th)

Dear LLVM and compiler interested people, next Thursday, 19:00, we will have two exciting tech-talks at the LLVM compiler social! # The Lean Theorem Prover Lean is a new theorem prover using dependent type theory (DTT). Lean 3 gained support for meta programming, employing dependent types not

[PATCH] D51608: [modules] when deserializing method, ensure it has correct exception spec

elsteveogrande added a comment. Hi @rsmith ! Thanks for taking a look at this. I'd much prefer to fix the underlying problem and not swat at these symptoms, so thanks for the analysis of what's actually going on here. :) Let me take a stab at fixing the real problem in the manner you

[clang-tools-extra] r341467 - [clangd] Fix type/variable name conflict on some compilers

Author: sammccall Date: Wed Sep 5 06:22:11 2018 New Revision: 341467 URL: http://llvm.org/viewvc/llvm-project?rev=341467=rev Log: [clangd] Fix type/variable name conflict on some compilers Modified: clang-tools-extra/trunk/clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp Modified:

[clang-tools-extra] r341466 - [clangd] Fix references.test assertions

Author: sammccall Date: Wed Sep 5 06:17:51 2018 New Revision: 341466 URL: http://llvm.org/viewvc/llvm-project?rev=341466=rev Log: [clangd] Fix references.test assertions Modified: clang-tools-extra/trunk/test/clangd/references.test Modified:

[clang-tools-extra] r341465 - [clangd] make zlib compression optional for binary format

Author: sammccall Date: Wed Sep 5 06:17:47 2018 New Revision: 341465 URL: http://llvm.org/viewvc/llvm-project?rev=341465=rev Log: [clangd] make zlib compression optional for binary format Modified: clang-tools-extra/trunk/clangd/index/Serialization.cpp Modified:

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

kbobyrev updated this revision to Diff 164024. kbobyrev added a comment. Keep 2 minor refactorings out of the scope of this patch. https://reviews.llvm.org/D51481 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/FileDistance.h

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

kbobyrev updated this revision to Diff 164023. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address another round of comments. https://reviews.llvm.org/D51481 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/FileDistance.h

Re: [clang-tools-extra] r341375 - [clangd] Define a compact binary serialization fomat for symbol slab/index.

On 09/05/2018 12:41 PM, Sam McCall wrote: Thanks. Unclear to me whether it's the enum class or the anonymous namespace that's triggering this (I believe) compiler bug, but r341459 may help... Still doesn't work. In file included from

  1   2   >