[PATCH] D52253: Fix an assert in the implementation of -Wquoted-include-in-framework-header

erik.pilkington updated this revision to Diff 166070. erik.pilkington added a comment. Sure, the new patch moves the test to double-quotes.m and gives it a more meaningful name. Thanks! https://reviews.llvm.org/D52253 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

gaijiading created this revision. gaijiading added reviewers: jlebar, Hahnfeld, dlj, tra. gaijiading added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, when a system has the CUDA toolkit already installed to its default locations in /usr/local/cuda, there will be

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang updated this revision to Diff 166068. shuaiwang marked 7 inline comments as done. shuaiwang added a comment. [WIP] Addressed some of review comments. Repository: rC Clang https://reviews.llvm.org/D52219 Files: include/clang/Analysis/Analyses/ExprMutationAnalyzer.h

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang added a comment. In https://reviews.llvm.org/D52219#1238423, @JonasToth wrote: > Do you think it would be possible to the analysis for `>const?< int > ***`-cases? (recursively checking through the pointer levels) I think that should be possible, will do after single-layer pointee

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang updated this revision to Diff 166065. shuaiwang added a comment. Rebase Repository: rC Clang https://reviews.llvm.org/D52219 Files: include/clang/Analysis/Analyses/ExprMutationAnalyzer.h lib/Analysis/ExprMutationAnalyzer.cpp unittests/Analysis/ExprMutationAnalyzerTest.cpp

[PATCH] D51868: [libcxx] Build and test fixes for Windows

STL_MSFT added inline comments. Comment at: test/support/test_macros.h:147 -# elif defined(_WIN32) -#if defined(_MSC_VER) && !defined(__MINGW32__) -# define TEST_HAS_C11_FEATURES // Using Microsoft's C Runtime library compnerd wrote: > I think that the

r342525 - [NFC] Fix uncompilable test cases of ExprMutationAnalyzer.

Author: shuaiwang Date: Tue Sep 18 20:50:03 2018 New Revision: 342525 URL: http://llvm.org/viewvc/llvm-project?rev=342525=rev Log: [NFC] Fix uncompilable test cases of ExprMutationAnalyzer. And ensure future test cases doesn't have compile errors. Modified:

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

wuzish added a comment. Herald added a subscriber: jsji. Please help me to commit this patch. Thanks a lot. Repository: rC Clang https://reviews.llvm.org/D52074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51868: [libcxx] Build and test fixes for Windows

mclow.lists added inline comments. Comment at: test/support/verbose_assert.h:24 : (IsStreamable::value ? 2 : -1))> -struct SelectStream { +struct SelectErrStream { static_assert(ST == -1, "specialization required for ST != -1"); Why the renaming

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

rjmccall added a comment. In https://reviews.llvm.org/D52200#1239007, @aaronpuchert wrote: > I think it should be possible to get rid of `self->` in the warning message > if we want to, after all `this->` is omitted in C++ as well. Hmm. It would be consistent to apply the same rule to both

[PATCH] D52253: Fix an assert in the implementation of -Wquoted-include-in-framework-header

bruno added a comment. Hi Erik, Thanks for catching this. Can you rename the test and the input file path to something more meaningful? Better yet if you remove the radar bits. I think you can actually squeeze this test in test/Modules/double-quotes.m. Repository: rC Clang

[PATCH] D51120: clang-format Additional Indent for class blocks

dpayne updated this revision to Diff 166057. dpayne added a comment. Adding the missing Style member variable. Repository: rC Clang https://reviews.llvm.org/D51120 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D52253: Fix an assert in the implementation of -Wquoted-include-in-framework-header

erik.pilkington added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:670 if (IsIncludeeInFramework) { NewInclude += StringRef(ToFramework).drop_back(10); // drop .framework NewInclude += "/"; Crash was here, if ToFramework is

[PATCH] D52253: Fix an assert in the implementation of -Wquoted-include-in-framework-header

erik.pilkington created this revision. erik.pilkington added a reviewer: bruno. Herald added a subscriber: dexonsmith. rdar://43692300 Repository: rC Clang https://reviews.llvm.org/D52253 Files: clang/lib/Lex/HeaderSearch.cpp

r342519 - Thread safety analysis: Fix crash for function pointers

Author: aaronpuchert Date: Tue Sep 18 17:19:38 2018 New Revision: 342519 URL: http://llvm.org/viewvc/llvm-project?rev=342519=rev Log: Thread safety analysis: Fix crash for function pointers For function pointers, the FunctionDecl of the callee is unknown, so getDirectCallee will return nullptr.

[PATCH] D51808: [CUDA] Ignore uncallable functions when we check for usual deallocators.

tra updated this revision to Diff 166053. tra added a comment. Renamed last instance of 'Matches' -> 'PreventedBy'. https://reviews.llvm.org/D51808 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/Sema.h clang/lib/AST/DeclCXX.cpp clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

rnk added a comment. This is pretty cool. The process launching APIs in LLVM were pretty basic, left a lot to be desired, returned ints, etc etc. This addresses a lot of that. Comment at: clang/trunk/lib/Driver/Driver.cpp:3030 +if (Arg *A =

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. I think it should be possible to get rid of `self->` in the warning message if we want to, after all `this->` is omitted in C++ as well. Comment at: test/SemaObjCXX/warn-thread-safety-analysis.mm:42

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaronpuchert updated this revision to Diff 166051. aaronpuchert added a comment. Detect ObjC pointer types as well as ordinary pointers. Repository: rC Clang https://reviews.llvm.org/D52200 Files: include/clang/Analysis/Analyses/ThreadSafetyCommon.h lib/Analysis/ThreadSafetyCommon.cpp

[PATCH] D51808: [CUDA] Ignore uncallable functions when we check for usual deallocators.

tra updated this revision to Diff 166050. tra marked an inline comment as done. tra added a comment. Updated assertion message. https://reviews.llvm.org/D51808 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/Sema.h clang/lib/AST/DeclCXX.cpp

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

zturner added a comment. In https://reviews.llvm.org/D52193#1238978, @aganea wrote: > In https://reviews.llvm.org/D52193#1238944, @zturner wrote: > > > In https://reviews.llvm.org/D52193#1238923, @aganea wrote: > > > > > The goal of this change is frictionless compilation into VS2017 when > > >

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaronpuchert added a comment. I found something that would theoretically work: P->setArrow((isa(ME->getBase()) && Ctx && Ctx->SelfArg) ? Ctx->SelfArrow : ME->isArrow()); So if we have `this` and a context that tells us we have to replace `this` by something else, then we check

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. In https://reviews.llvm.org/D52193#1238944, @zturner wrote: > In https://reviews.llvm.org/D52193#1238923, @aganea wrote: > > > The goal of this change is frictionless compilation into VS2017 when using > > `clang-cl` as a compiler. We've realized that compiling Clang+LLD

r342517 - Add a callback for `__has_include` and use it for dependency scanning.

Author: vsapsai Date: Tue Sep 18 16:27:02 2018 New Revision: 342517 URL: http://llvm.org/viewvc/llvm-project?rev=342517=rev Log: Add a callback for `__has_include` and use it for dependency scanning. This adds a preprocessor callback for the `__has_include` and `__has_include_next` directives.

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

This revision was automatically updated to reflect the committed changes. Closed by commit rL342517: Add a callback for `__has_include` and use it for dependency scanning. (authored by vsapsai, committed by ). Herald added subscribers: llvm-commits, jsji. Changed prior to commit:

r342516 - [MS] Defer dllexport inline friend functions like other inline methods

Author: rnk Date: Tue Sep 18 16:16:30 2018 New Revision: 342516 URL: http://llvm.org/viewvc/llvm-project?rev=342516=rev Log: [MS] Defer dllexport inline friend functions like other inline methods This special case was added in r264841, but the code breaks our invariants by calling

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

zturner added a reviewer: thakis. zturner added a comment. That said, the numbers are pretty convincing These two rows alone: MSBuild, Clang + LLD(29min 12sec) 32 parallel msbuild MSBuild, Clang /MP + LLD(9min 22sec)32 parallel msbuild Are enough to make this patch worthy of

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

zturner added a comment. In https://reviews.llvm.org/D52193#1238923, @aganea wrote: > The goal of this change is frictionless compilation into VS2017 when using > `clang-cl` as a compiler. We've realized that compiling Clang+LLD with Clang > generates a faster executable that with MSVC (even

[PATCH] D52252: Driver: render arguments for the embedded bitcode correctly

compnerd created this revision. compnerd added a reviewer: steven_wu. When embedding bitcode, only a subset of the arguments should be recorded into the bitcode compilation command line. The frontend job is split into two jobs, one which will generate the bitcode. Ensure that the arguments for

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. The goal of this change is frictionless compilation into VS2017 when using `clang-cl` as a compiler. We've realized that compiling Clang+LLD with Clang generates a faster executable that with MSVC (even latest one). I currently can't see a good way of generating the

[PATCH] D50948: lambdas in modules: change storage for LambdaDefinitionData

elsteveogrande added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:1771 auto *Def = DD.Definition; DD = std::move(MergeDD); DD.Definition = Def; Hi @rsmith, thanks again for looking! This is the part that I was concerned

[PATCH] D51868: [libcxx] Build and test fixes for Windows

compnerd added inline comments. Herald added a subscriber: libcxx-commits. Comment at: include/filesystem:1396 - _LIBCPP_FUNC_VIS void __create_what(int __num_paths); This possibly changes the meaning on other targets. What was the error that this

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 166044. JonasToth added a comment. - minor adjustments, add fixmes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/IsolateDeclCheck.cpp

r342515 - Driver: extract a local variable for the Toolchain (NFC)

Author: compnerd Date: Tue Sep 18 15:14:50 2018 New Revision: 342515 URL: http://llvm.org/viewvc/llvm-project?rev=342515=rev Log: Driver: extract a local variable for the Toolchain (NFC) Create and store a reference to the current toolchain rather than calling `getToolChain` throughout the

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342514: [clang-tidy] Replace redundant checks with an assert(). (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D52179?vs=165841=166042#toc Repository: rCTE

[clang-tools-extra] r342514 - [clang-tidy] Replace redundant checks with an assert().

Author: tra Date: Tue Sep 18 14:51:02 2018 New Revision: 342514 URL: http://llvm.org/viewvc/llvm-project?rev=342514=rev Log: [clang-tidy] Replace redundant checks with an assert(). findStyleKind is only called if D is an explicit identifier with a name, so the checks for operators will never

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 166041. JonasToth added a comment. - Merge branch 'master' into experiment_isolate_decl - further work on isolate decl, fix tokenizing bug with templates - include big test-suite and make them run Repository: rCTE Clang Tools Extra

[PATCH] D52250: [clangd] expose MergedIndex class

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. This allows inheriting from it, so index() can ga away and allowing TestTU::index) to be fixed. Repository: rCTE Clang Tools Extra

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

vsapsai added a comment. Thanks for the fix. Repository: rL LLVM https://reviews.llvm.org/D52191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r342512 - Driver: hoist `-mlimit-float-precision` (NFC)

Author: compnerd Date: Tue Sep 18 14:12:39 2018 New Revision: 342512 URL: http://llvm.org/viewvc/llvm-project?rev=342512=rev Log: Driver: hoist `-mlimit-float-precision` (NFC) Move the floating point argument handling into the RenderFloatingPointOptions helper. This relocation just puts the

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166035. nickdesaulniers added a comment. git-clang-format HEAD~ Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89.c Index: test/Sema/gnu89.c

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers created this revision. nickdesaulniers added reviewers: srhines, gbiv. Herald added a reviewer: george.burgess.iv. Herald added a subscriber: cfe-commits. nickdesaulniers removed a reviewer: gbiv. Fixes PR32985. Repository: rC Clang https://reviews.llvm.org/D52248 Files:

Re: [PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

Seems that it was fixed earlier today. Thanks, Yvan On Tue, 18 Sep 2018 at 19:31, Yvan Roux wrote: > > Hi Sam, > > It took a very long time to identify it, but this commit broke ARMv7 > bots, where this test hangs. Logs are available here (initial ones > are too old): > >

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. In https://reviews.llvm.org/D50901#1238795, @lebedev.ri wrote: > @vsk thanks for taking a look! /me can't read :) That was supposed to be @vitalybuka, of course (: Repository: rC Clang https://reviews.llvm.org/D50901

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. @vsk thanks for taking a look! Comment at: lib/CodeGen/CGExprScalar.cpp:305 enum ImplicitConversionCheckKind : unsigned char { -ICCK_IntegerTruncation = 0, +ICCK_IntegerTruncation = 0, // Legacy, no longer used. +

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

vitalybuka added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:305 enum ImplicitConversionCheckKind : unsigned char { -ICCK_IntegerTruncation = 0, +ICCK_IntegerTruncation = 0, // Legacy, no longer used. +ICCK_UnsignedIntegerTruncation = 1,

Re: r342501 - Fix logic around determining use of frame pointer with -pg.

r342510 by dblaikie fixed this. Thanks, Steve On Tue, Sep 18, 2018 at 1:18 PM Stephen Hines wrote: > Sure, I'm looking now. > > Thanks, > Steve > > On Tue, Sep 18, 2018 at 1:02 PM wrote: > >> Hi Stephen, >> >> Your change is causing a test failure on the PS4 linux bot, can you >> please take

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

srhines added a comment. Thanks @dblaikie for the quick fixup. I must have accidentally dropped the '!', because I did run check-all to test the change. Repository: rL LLVM https://reviews.llvm.org/D52191 ___ cfe-commits mailing list

Re: r342501 - Fix logic around determining use of frame pointer with -pg.

Sure, I'm looking now. Thanks, Steve On Tue, Sep 18, 2018 at 1:02 PM wrote: > Hi Stephen, > > Your change is causing a test failure on the PS4 linux bot, can you please > take a look? > > >

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

dblaikie added a subscriber: srhines. dblaikie added a comment. Fixed in r342510 with the solution I mentioned up-thread. Repository: rL LLVM https://reviews.llvm.org/D52191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

Fixed in r342510 with the solution I mentioned up-thread. On Tue, Sep 18, 2018 at 1:10 PM Volodymyr Sapsai via Phabricator < revi...@reviews.llvm.org> wrote: > vsapsai added a comment. > > Confirm that reverting the change locally fixes the tests. If nobody beats > me to it, I plan to revert the

r342510 - Fix fomit-frame-pointe+pg error

Author: dblaikie Date: Tue Sep 18 13:11:45 2018 New Revision: 342510 URL: http://llvm.org/viewvc/llvm-project?rev=342510=rev Log: Fix fomit-frame-pointe+pg error Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL:

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

vsapsai added a comment. Confirm that reverting the change locally fixes the tests. If nobody beats me to it, I plan to revert the change in 30-60 minutes. @srhines, if you want to fix it in another way and need more time, please let me know. Repository: rL LLVM

RE: r342501 - Fix logic around determining use of frame pointer with -pg.

Hi Stephen, Your change is causing a test failure on the PS4 linux bot, can you please take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/36712/steps/test/logs/stdio FAIL: Clang :: Driver/clang_f_opts.c (8141 of 44013) TEST

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

rdhindsa added a comment. It seems that following tests are broken with this change: clang/test/Driver/clang_f_opts.c clang/test/Frontend/gnu-mcount.c Repository: rL LLVM https://reviews.llvm.org/D52191 ___ cfe-commits mailing list

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. @rsmith - ping. This one should be rather uncontroversial i think? Is this moving in the direction you suggested? :) Repository: rC Clang https://reviews.llvm.org/D50901 ___ cfe-commits mailing list

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

vsapsai added a comment. Seems like this change causes 2 test failures: Clang :: Driver/clang_f_opts.c Clang :: Frontend/gnu-mcount.c Some of the failing bots are http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/15363/

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaronpuchert planned changes to this revision. aaronpuchert added a comment. Thanks to both of you for the reviews. I'll see what I can do about the arrows. My gut feeling is that using `{Member,ObjCIVarRef}Expr::isArrow` is the right way, but it's not yet obvious to me how.

Re: [clang-tools-extra] r342227 - [clangd] NFC: Fix IndexBenchmark CLI arguments handling

Thanks for the explanation! I didn’t know that benchmark’s Initialize does that, that was probably the source of my confusion. The suggestion looks reasonable, I should try this approach, it looks to be cleaner. -Kirill > On 18 Sep 2018, at 21:16, Roman Lebedev wrote: > > On Tue, Sep 18,

Re: [clang-tools-extra] r342227 - [clangd] NFC: Fix IndexBenchmark CLI arguments handling

On Tue, Sep 18, 2018 at 10:09 PM, Kirill Bobyrev wrote: > Hi Roman, > > Is there any benefit of doing so? Also, I’m not sure whether I understood you > correctly. Consuming benchmark options *before* trimming would probably not > be the desired behaviour since the first two arguments arguments

Re: [clang-tools-extra] r342227 - [clangd] NFC: Fix IndexBenchmark CLI arguments handling

Hi Roman, Is there any benefit of doing so? Also, I’m not sure whether I understood you correctly. Consuming benchmark options *before* trimming would probably not be the desired behaviour since the first two arguments arguments are passed directly to the tool driver. I might have

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

dblaikie added a comment. In https://reviews.llvm.org/D52191#1238648, @srhines wrote: > In https://reviews.llvm.org/D52191#1238628, @dblaikie wrote: > > > Sure, looks good. Though my other/vague concern is why does this case error > > about fomit-frame-pointer having no effect, but other things

[clang-tools-extra] r342505 - [clangd] Fix error handling for SymbolID parsing (notably YAML and dexp)

Author: sammccall Date: Tue Sep 18 12:00:59 2018 New Revision: 342505 URL: http://llvm.org/viewvc/llvm-project?rev=342505=rev Log: [clangd] Fix error handling for SymbolID parsing (notably YAML and dexp) Modified: clang-tools-extra/trunk/clangd/index/Index.cpp

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

This revision was automatically updated to reflect the committed changes. Closed by commit rC342501: Fix logic around determining use of frame pointer with -pg. (authored by srhines, committed by ). Changed prior to commit: https://reviews.llvm.org/D52191?vs=165826=166007#toc Repository: rL

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342501: Fix logic around determining use of frame pointer with -pg. (authored by srhines, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52191

r342501 - Fix logic around determining use of frame pointer with -pg.

Author: srhines Date: Tue Sep 18 11:34:33 2018 New Revision: 342501 URL: http://llvm.org/viewvc/llvm-project?rev=342501=rev Log: Fix logic around determining use of frame pointer with -pg. Summary: As part of r342165, I rewrote the logic to check whether -fno-omit-frame-pointer was passed after

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

srhines added a comment. In https://reviews.llvm.org/D52191#1238628, @dblaikie wrote: > Sure, looks good. Though my other/vague concern is why does this case error > about fomit-frame-pointer having no effect, but other things (like using > -fomit-frame-pointer on a target that requires frame

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sure, looks good. Though my other/vague concern is why does this case error about fomit-frame-pointer having no effect, but other things (like using -fomit-frame-pointer on a target that

[PATCH] D52084: [clangd] Improve PostingList iterator string representation

kbobyrev added a comment. In https://reviews.llvm.org/D52084#1238537, @sammccall wrote: > This change seems fine but... > > This representation with the raw DocIDs and position dumped seems mostly > useful for debugging buggy iterator implementations, but not really useful > for understanding

Re: [PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

Hi Sam, It took a very long time to identify it, but this commit broke ARMv7 bots, where this test hangs. Logs are available here (initial ones are too old):

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

rjmccall added a comment. In https://reviews.llvm.org/D51789#1238410, @ldionne wrote: > In https://reviews.llvm.org/D51789#1238396, @rjmccall wrote: > > > That may work for libc++'s purposes, but it's clearly inappropriate as a > > compiler rule. There are good reasons why something with

[PATCH] D51910: [Modules] Add platform feature to requires clause

This revision was automatically updated to reflect the committed changes. Closed by commit rL342499: [Modules] Add platform and environment features to requires clause (authored by bruno, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51910: [Modules] Add platform feature to requires clause

This revision was automatically updated to reflect the committed changes. Closed by commit rC342499: [Modules] Add platform and environment features to requires clause (authored by bruno, committed by ). Changed prior to commit: https://reviews.llvm.org/D51910?vs=165861=165998#toc Repository:

r342499 - [Modules] Add platform and environment features to requires clause

Author: bruno Date: Tue Sep 18 10:11:13 2018 New Revision: 342499 URL: http://llvm.org/viewvc/llvm-project?rev=342499=rev Log: [Modules] Add platform and environment features to requires clause Allows module map writers to add build requirements based on platform/os. This helps when target

[PATCH] D52084: [clangd] Improve PostingList iterator string representation

sammccall accepted this revision. sammccall added a comment. This change seems fine but... This representation with the raw DocIDs and position dumped seems mostly useful for debugging buggy iterator implementations, but not really useful for understanding query structure and behavior. I

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

stryku added a comment. Friendly ping (: https://reviews.llvm.org/D50766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51372: FENV_ACCESS support for libm-style constrained intrinsics

kpn updated this revision to Diff 165995. kpn added a comment. Rebase. Correct obvious error with powi. Fix test and test both C and (partial) C++. Ping. https://reviews.llvm.org/D51372 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h lib/AST/ASTImporter.cpp

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. To use in a git pre-commit I wanted to use the flags: -warnings-as-errors=* -header-filter=.* I wanted that the script returned an error value for my selected checks, even if they are just warnings. Repository: rCTE Clang Tools Extra

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. In https://reviews.llvm.org/D52058#1237868, @JDevlieghere wrote: > Generally this looks good, but I'd like for the other to have a look first > (at this and the other patch) before accepting. Sounds good. Thanks for your comments! Comment at:

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

JonasToth added a comment. Looks like a good start! I think getting the pointers right will be most difficult, because of the multiple levels of indirection they allow. Do you think it would be possible to the analysis for `>const?< int ***`-cases? (recursively checking through the pointer

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

rjmccall added inline comments. Comment at: lib/Analysis/ThreadSafetyCommon.cpp:362 + til::Project *P = new (Arena) til::Project(E, D); + if (hasCppPointerType(BE)) +P->setArrow(true); aaron.ballman wrote: > I feel like this will always return false.

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne added a comment. In https://reviews.llvm.org/D51789#1238396, @rjmccall wrote: > That may work for libc++'s purposes, but it's clearly inappropriate as a > compiler rule. There are good reasons why something with hidden visibility > would need to be explicitly instantiated. I take

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh added a comment. This is intended, IIUC. The syntax of the clang-tidy-diff.py mirrors the syntax of clang-tidy itself, and the `--` option is used in the same way as in clang-tidy - to denote the start of compiler arguments (and switch to the fixed compilation database). Do you have a

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

cfe-commits added a comment. - F7238787: msg-7222-125.txt Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

rjmccall added a comment. That may work for libc++'s purposes, but it's clearly inappropriate as a compiler rule. There are good reasons why something with hidden visibility would need to be explicitly instantiated. For many programmers, hidden visibility means "this is private to my

Re: [PATCH] D52078: [clangd] Store preamble macros in dynamic index.

On Tue, Sep 18, 2018, 16:28 Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: > ioeric added a comment. > > In https://reviews.llvm.org/D52078#1238301, @sammccall wrote: > > > Something not listed in cons: because macros aren't namespaced and we > don't have lots of signals, they can be

[PATCH] D50948: lambdas in modules: change storage for LambdaDefinitionData

rsmith added a comment. We don't want to allocate storage for the lambda fields for non-lambda classes, which is why we use distinct base classes. Is the problem you're trying to solve here that we fake a definition in AST deserialization before we know whether the class is a lambda? If so,

r342484 - [index] Enhance indexing for module references

Author: akirtzidis Date: Tue Sep 18 08:02:56 2018 New Revision: 342484 URL: http://llvm.org/viewvc/llvm-project?rev=342484=rev Log: [index] Enhance indexing for module references * Create a USR for the occurrences of the 'module' symbol kind * Record module references for each identifier in an

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

ioeric added a comment. In https://reviews.llvm.org/D52078#1238301, @sammccall wrote: > Something not listed in cons: because macros aren't namespaced and we don't > have lots of signals, they can be really spammy. > Potentially, offering macros that aren't in the TU could be a loss even if

[PATCH] D52084: [clangd] Improve PostingList iterator string representation

kbobyrev updated this revision to Diff 165973. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D52084 Files: clang-tools-extra/clangd/index/dex/Iterator.h clang-tools-extra/clangd/index/dex/PostingList.cpp clang-tools-extra/unittests/clangd/DexTests.cpp Index:

[PATCH] D52233: [dexp] Allow users to dump JSON representations of fuzzy find requests

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous. This might be useful for benchmark construction. https://reviews.llvm.org/D52233 Files:

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

sammccall accepted this revision. sammccall added a comment. Something not listed in cons: because macros aren't namespaced and we don't have lots of signals, they can be really spammy. Potentially, offering macros that aren't in the TU could be a loss even if it's a win for other types of

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

ioeric updated this revision to Diff 165969. ioeric added a comment. - added lit test Repository: rC Clang https://reviews.llvm.org/D52079 Files: include/clang/Sema/CodeCompleteOptions.h lib/Sema/SemaCodeComplete.cpp test/Index/complete-pch-skip.cpp Index:

[PATCH] D52084: [clangd] NFC: Update documentation of Iterator's dump format

ioeric accepted this revision. ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/dex/PostingList.cpp:66 + OS << "... "; if (Index != std::end(Documents)) + OS << *Index << " ..."; nit: should we drop the trailing `...` if

[PATCH] D51340: [WIP] Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta updated this revision to Diff 165966. takuto.ikuta edited the summary of this revision. takuto.ikuta added a comment. Current implementation cannot build chrome when pch is enabled. undefined symbol error happens during linking blink_modules.dll https://reviews.llvm.org/D51340

[PATCH] D52084: [clangd] NFC: Update documentation of Iterator's dump format

kbobyrev updated this revision to Diff 165964. kbobyrev added a comment. @ioeric does this format look better? https://reviews.llvm.org/D52084 Files: clang-tools-extra/clangd/index/dex/Iterator.h clang-tools-extra/clangd/index/dex/PostingList.cpp

[PATCH] D52047: [clangd] Add a "benchmark" for tracking memory

kbobyrev updated this revision to Diff 165962. kbobyrev marked an inline comment as done. kbobyrev added a comment. Rebase on top of master, move logging to symbol index `build()` caller side. https://reviews.llvm.org/D52047 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

ioeric updated this revision to Diff 165959. ioeric added a comment. - merge with origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52078 Files: clangd/index/FileIndex.cpp unittests/clangd/CodeCompleteTests.cpp unittests/clangd/FileIndexTests.cpp Index:

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

ioeric added inline comments. Comment at: clangd/index/FileIndex.h:77 + /// Update symbols from main file \p Path with symbols in \p TopLevelDecls. + void updateMain(PathRef Path, ASTContext , + std::shared_ptr PP, sammccall wrote: > sammccall

[clang-tools-extra] r342473 - [clangd] Get rid of Decls parameter in indexMainDecls. NFC

Author: ioeric Date: Tue Sep 18 06:35:16 2018 New Revision: 342473 URL: http://llvm.org/viewvc/llvm-project?rev=342473=rev Log: [clangd] Get rid of Decls parameter in indexMainDecls. NFC It's already available in ParsedAST. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp

  1   2   >