[clang-tools-extra] r344016 - [clang-tidy][docs] Update docs for `--check-suffixes`

Author: zinovy.nis Date: Mon Oct 8 22:48:57 2018 New Revision: 344016 URL: http://llvm.org/viewvc/llvm-project?rev=344016=rev Log: [clang-tidy][docs] Update docs for `--check-suffixes` Differential Revision: https://reviews.llvm.org/D52971 Modified:

[PATCH] D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL344015: [clang-tidy] The patch extends the existing command line option -check-suffix (authored by zinovy.nis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r344015 - [clang-tidy] The patch extends the existing command line option -check-suffix

Author: zinovy.nis Date: Mon Oct 8 22:40:03 2018 New Revision: 344015 URL: http://llvm.org/viewvc/llvm-project?rev=344015=rev Log: [clang-tidy] The patch extends the existing command line option -check-suffix (with alias -check-suffixes) to accept multiple comma-separated FileCheck prefixes.

[PATCH] D52983: [analyzer] Support Reinitializes attribute in MisusedMovedObject check

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay, these look useful. Is there also an attribute for methods that should never be called on a 'moved-from' object? Repository: rC Clang https://reviews.llvm.org/D52983

[PATCH] D52969: [analyzer][www] Update alpha_checks.html

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Comment at: www/analyzer/alpha_checks.html:450 - -Variable Argument Alpha Checkers - I think these are missing on the available checkers list, so we

[PATCH] D52993: [analyzer][www] Add more useful links

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx! Comment at: www/analyzer/checker_dev_manual.html:703-704 Useful Links +http://lcs.ios.ac.cn/~xuzb/canalyze/memmodel.pdf;>Xu, Zhongxing & Maybe merge

[PATCH] D52984: [analyzer] Checker reviewer's checklist

NoQ added inline comments. Comment at: www/analyzer/checker_dev_manual.html:708 +Checker Reviewer Checklist + I think we actually need two separate checklists: * for common bugs (careful use of non-fatal error nodes, etc. - stuff we check for on every review)

[PATCH] D52445: [Index] Use locations to uniquify function-scope BindingDecl USR

This revision was automatically updated to reflect the committed changes. Closed by commit rC344010: [Index] Use locations to uniquify function-scope BindingDecl USR (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D52445?vs=168704=168740#toc Repository:

r344010 - [Index] Use locations to uniquify function-scope BindingDecl USR

Author: maskray Date: Mon Oct 8 18:02:56 2018 New Revision: 344010 URL: http://llvm.org/viewvc/llvm-project?rev=344010=rev Log: [Index] Use locations to uniquify function-scope BindingDecl USR Summary: This makes BindingDecl's of the same name have different USRs, so that references can be

Buildbot numbers for the last week of 9/30/2018 - 10/06/2018

Hello everyone, Below are some buildbot numbers for the last week of 9/30/2018 - 10/06/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 9/23/2018 - 9/29/2018

Hello everyone, Below are some buildbot numbers for the week of 9/23/2018 - 9/29/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

r344009 - [WebAssembly][NFC] Rename test functions for builtins

Author: tlively Date: Mon Oct 8 17:42:13 2018 New Revision: 344009 URL: http://llvm.org/viewvc/llvm-project?rev=344009=rev Log: [WebAssembly][NFC] Rename test functions for builtins Reviewers: aheejin, dschuff Subscribers: sbc100, jgravelle-google, sunfish, jfb, kristina, cfe-commits

[PATCH] D53007: [WebAssembly][NFC] Rename test functions for builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL344009: [WebAssembly][NFC] Rename test functions for builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53007 Files:

[PATCH] D53009: [WebAssembly] Saturating float-to-int builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on https://reviews.llvm.org/D52959 and https://reviews.llvm.org/D53004. Repository: rC Clang https://reviews.llvm.org/D53009

[PATCH] D53007: [WebAssembly][NFC] Rename test functions for builtins

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. A lot better this way! Thanks. Repository: rC Clang https://reviews.llvm.org/D53007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53007: [WebAssembly][NFC] Rename test functions for builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, jfb, sunfish, jgravelle-google, sbc100. Repository: rC Clang https://reviews.llvm.org/D53007 Files: test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins-wasm.c

[PATCH] D53001: [Driver] check for exit code from SIGPIPE

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Digging through `tools/driver/driver.cpp` this seems to be the right thing. Maybe leave it open for a bit so others can chime in (if say they have other drivers or whatever?). Thanks for fixing!

[PATCH] D53001: [Driver] check for exit code from SIGPIPE

nickdesaulniers updated this revision to Diff 168733. nickdesaulniers added a comment. - return error code 74 (EX_IOERR) if observed Repository: rC Clang https://reviews.llvm.org/D53001 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

[PATCH] D53001: [Driver] check for exit code from SIGPIPE

nickdesaulniers updated this revision to Diff 168728. nickdesaulniers added a comment. - prefer EX_IOERR from sysexits.h Repository: rC Clang https://reviews.llvm.org/D53001 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

[PATCH] D53001: [Driver] check for exit code from SIGPIPE

jfb added a comment. Just to be sure: what's the exit code from the driver? If we don't diagnose I'm fine with it... but the exit code still needs to reflect the failure! Repository: rC Clang https://reviews.llvm.org/D53001 ___ cfe-commits

[PATCH] D53001: [Driver] check for exit code from SIGPIPE

jfb added inline comments. Comment at: lib/Driver/Driver.cpp:1406 +// for SIGPIPE. Do not print diagnostics for this case. +if (Res == 71) + continue; nickdesaulniers wrote: > jfb wrote: > > jfb wrote: > > > Ditto on magical number in a header. > >

[PATCH] D53001: [Driver] check for exit code from SIGPIPE

nickdesaulniers added inline comments. Comment at: lib/Driver/Driver.cpp:1406 +// for SIGPIPE. Do not print diagnostics for this case. +if (Res == 71) + continue; jfb wrote: > jfb wrote: > > Ditto on magical number in a header. > I think you want to

[PATCH] D53001: [Driver] check for exit code from SIGPIPE

jfb added a comment. What's the return code of the driver when the pipe is broken that way? Comment at: lib/Driver/Driver.cpp:1406 +// for SIGPIPE. Do not print diagnostics for this case. +if (Res == 71) + continue; Ditto on magical number in a

Re: [clang-tools-extra] r* - [clangd]*

Hi all, Just wanted to attract attention to the clangd test failure at http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/12782/ Buildbots were down recently, so I guess this one was very easy to miss. ___ cfe-commits mailing list

[PATCH] D52920: Introduce code_model macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL344000: Introduce code_model macros (authored by tamur, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52920 Files:

r344000 - Introduce code_model macros

Author: tamur Date: Mon Oct 8 15:25:20 2018 New Revision: 344000 URL: http://llvm.org/viewvc/llvm-project?rev=344000=rev Log: Introduce code_model macros Summary: gcc defines macros such as __code_model_small_ based on the user passed command line flag -mcmodel. clang accepts a flag with the

[PATCH] D52990: [MinGW] Allow using ubsan

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:266 + // directives in the object files, but the static library needs + // -lpsapi unless the sanitizer was built targeting >= win7. + CmdArgs.push_back("-lpsapi");

[PATCH] D53001: [DRIVER] check for exit code from SIGPIPE

nickdesaulniers created this revision. nickdesaulniers added a reviewer: jfb. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D53000 adds a special exit code for SIGPIPE (writing to a closed reader), and rather than print a fatal warning, skips printing the error. Fixes

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

zturner added a comment. It's not enough to just set `_HAS_EXCEPTIONS=1`, it has to match whatever the value of `/EH` is passed to the compiler. So if we need to be able to throw catch exceptions, then you should pass `/EHsc` and not touch `_HAS_EXCEPTIONS` (technically you could set it to 1

Re: [libcxx] r342073 - Implement the infrastructure for feature-test macros. Very few actual feature test macros, though. Reviewed as: https://reviews.llvm.org/D51955

On Thu, Oct 4, 2018 at 8:41 AM Richard Smith wrote: > Perhaps libc++ could provide a __version file that contains the headers, > and use #include <__version> internally? We'd still need a header > that just includes <__version> for conformance, but that should be after > user headers on the

[PATCH] D52990: [MinGW] Allow using ubsan

smeenai added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:266 + // directives in the object files, but the static library needs + // -lpsapi unless the sanitizer was built targeting >= win7. + CmdArgs.push_back("-lpsapi");

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews added a comment. Thanks for the information Zachary. @lebedev.ri I do not know how benchmark library developers need/want to handle exceptions in MSVC STL. If these need to be enabled when BENCHMARK_ENABLE_EXCEPTIONS is true, I think we can just modify _HAS_EXCEPTIONS in

[PATCH] D52854: Use is.constant intrinsic for __builtin_constant_p

void updated this revision to Diff 168712. Repository: rC Clang https://reviews.llvm.org/D52854 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h include/clang/Sema/Sema.h lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGBuiltin.cpp lib/Parse/ParseDecl.cpp

[PATCH] D52990: [MinGW] Allow using ubsan

rnk added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:266 + // directives in the object files, but the static library needs + // -lpsapi unless the sanitizer was built targeting >= win7. + CmdArgs.push_back("-lpsapi");

[PATCH] D52990: [MinGW] Allow using ubsan

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:266 + // directives in the object files, but the static library needs + // -lpsapi unless the sanitizer was built targeting >= win7. + CmdArgs.push_back("-lpsapi");

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

zturner added subscribers: eandrews, zturner. zturner added a comment. `_HAS_EXCEPTIONS=0` is an undocumented STL specific thing that the library implementation uses to mean "don't write code that does `throw X;`, do something else instead". https://reviews.llvm.org/D52998

[PATCH] D52990: [MinGW] Allow using ubsan

smeenai added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:266 + // directives in the object files, but the static library needs + // -lpsapi unless the sanitizer was built targeting >= win7. + CmdArgs.push_back("-lpsapi");

Re: [PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

`_HAS_EXCEPTIONS=0` is an undocumented STL specific thing that the library implementation uses to mean "don't write code that does `throw X;`, do something else instead". On Mon, Oct 8, 2018 at 2:27 PM Elizabeth Andrews via Phabricator < revi...@reviews.llvm.org> wrote: > eandrews added a

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews added a comment. I do not think defining _HAS_EXCEPTIONS=0 affects C++ exceptions in the application. I thought it only affected the STL. I will verify this and update you. https://reviews.llvm.org/D52998 ___ cfe-commits mailing list

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

lebedev.ri added a comment. Are those warnings about C++ exceptions, or some windows-specific exception stuff? It seems the C++ exceptions are used in tests e.g. https://github.com/google/benchmark/search?q=throw_q=throw https://github.com/google/benchmark/search?q=catch_q=catch

[PATCH] D52854: Use is.constant intrinsic for __builtin_constant_p

void updated this revision to Diff 168708. void added a comment. I updated the patch that implements putting the "can delay evaluation" bit into the CallExprBitfields. PTAL. Repository: rC Clang https://reviews.llvm.org/D52854 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews created this revision. eandrews added reviewers: rnk, kbobyrev, omtcyfz, lebedev.ri, erichkeane. Herald added a subscriber: mgorny. Define _HAS_EXCEPTIONS=0, when compiling benchmark files, to disable exceptions in Microsoft STL. Windows builds were failing due to C4530 warnings (C++

[PATCH] D52937: [clangd] Add clangd.serverInfo command to inspect server state.

MaskRay added a comment. Rather than use a `workspace/executeCommand` command, you may consider making it a custom request message whose method name starts with `$/` https://microsoft.github.io/language-server-protocol/specification > Notification and requests whose methods start with ‘$/’ are

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

mclow.lists added a comment. In https://reviews.llvm.org/D42242#1257428, @mgorny wrote: > @mclow.lists , ping. Any chance to get a proper version upstream? I'd rather > not pull patches from Fedora when we can have something official. I gave up on this patch several months ago, because no one

[PATCH] D52445: [Index] Use locations to uniquify function-scope BindingDecl USR

MaskRay updated this revision to Diff 168704. MaskRay added a comment. Use isLocal Repository: rC Clang https://reviews.llvm.org/D52445 Files: lib/Index/USRGeneration.cpp test/Index/Core/index-source.cpp Index: test/Index/Core/index-source.cpp

[PATCH] D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes

lebedev.ri added a comment. In https://reviews.llvm.org/D52971#1258086, @zinovy.nis wrote: > In https://reviews.llvm.org/D52971#1257702, @JonasToth wrote: > > > I think it would make sense to migrate one test already, to use the new > > capability > > > This change was inspired by @lebedev.ri,

[PATCH] D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes

zinovy.nis added a comment. In https://reviews.llvm.org/D52971#1257702, @JonasToth wrote: > I think it would make sense to migrate one test already, to use the new > capability This change was inspired by Roman Lebedev (lebedev.ri), so we expect him to provide us with such a test soon ;-)

[PATCH] D52920: Introduce code_model macros

tamur added inline comments. Comment at: lib/Basic/Targets/X86.cpp:865 + if (CodeModel == "default") +// When the user has not explicitly specified anything, +// the default code model to use is small. MaskRay wrote: > I'm not sure if the comment is

[PATCH] D52920: Introduce code_model macros

tamur updated this revision to Diff 168700. Repository: rC Clang https://reviews.llvm.org/D52920 Files: include/clang/Basic/TargetOptions.h lib/Basic/Targets/X86.cpp lib/Frontend/CompilerInvocation.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D52854: Use is.constant intrinsic for __builtin_constant_p

void added a comment. Here's a WIP patch to show what I'm talking about.F7375980: example.diff Repository: rC Clang https://reviews.llvm.org/D52854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52854: Use is.constant intrinsic for __builtin_constant_p

void added a comment. No, I understood that. But the issue is that you then need to specify this new expression class in over 23 different files: various macros, switch statements, etc. Repository: rC Clang https://reviews.llvm.org/D52854 ___

[PATCH] D52891: [AMDGPU] Add -fvisibility-amdgpu-non-kernel-functions

scott.linder added a comment. I will update the patch to modify the HIP toolchain and to add tests for global variables. As far as the semantics are concerned, are we OK with this being AMDGPU only? I do not see a means of determining what is a "kernel" in a language-agnostic way other than

[PATCH] D52854: Use is.constant intrinsic for __builtin_constant_p

efriedma added a comment. I don't think that was the approach @rsmith was suggesting; you don't need to wrap every possible kind of expression. Rather, at the point where the expression is required to be constant, add a single expression which wraps the entire expression tree to indicate

[PATCH] D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes

zinovy.nis updated this revision to Diff 168690. zinovy.nis added a comment. - Fixed diagnostics; - Interchangeable alias introduced: `-check-suffixes` for `-check-suffix`. https://reviews.llvm.org/D52971 Files: test/clang-tidy/check_clang_tidy.cpp test/clang-tidy/check_clang_tidy.py

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343990: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON. (authored by cdavis, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[libunwind] r343990 - [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

Author: cdavis Date: Mon Oct 8 11:35:00 2018 New Revision: 343990 URL: http://llvm.org/viewvc/llvm-project?rev=343990=rev Log: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON. Summary: If `-nodefaultlibs` is given, we weren't actually linking to it. This was true irrespective of

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

steveire added a comment. Can I convince someone to be interested enough in this to approve it? I have a talk coming up and I'd like to be able to say that you don't have to switch between `dump` mode and `diag` mode all the time. I also want to enable other relevant outputting features in

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter

AntonBikineev added a comment. @rsmith do you have any comments or suggestions? https://reviews.llvm.org/D46441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

cdavis5x updated this revision to Diff 168687. cdavis5x added a comment. - Detect libgcc. Repository: rUNW libunwind https://reviews.llvm.org/D51657 Files: cmake/config-ix.cmake src/CMakeLists.txt Index: src/CMakeLists.txt

[PATCH] D52598: [OpenCL] Fixed address space cast in C style cast of C++ parsing

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Sema/SemaCast.cpp:2288 + SrcType->isPointerType()) { +const PointerType *DestPtr = DestType->getAs(); +if

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter

rjmccall accepted this revision. rjmccall added a comment. LGTM. Comment at: lib/CodeGen/CGCall.cpp:2049 +// from the constructor’s this pointer, the value of the object or +// subobject thus obtained is unspecified. +unsigned ThisIRArg, NumIRArgs;

[PATCH] D52993: [analyzer][www] Add more useful links

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, dcoughlin. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. This bothered me for a while, but finding literature about static analysis is very difficult.

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

elsteveogrande accepted this revision. elsteveogrande added a comment. This revision is now accepted and ready to land. lgtm! Repository: rC Clang https://reviews.llvm.org/D52956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r343982 - [clang-move] Dump whether a declaration is templated.

Author: ioeric Date: Mon Oct 8 10:22:50 2018 New Revision: 343982 URL: http://llvm.org/viewvc/llvm-project?rev=343982=rev Log: [clang-move] Dump whether a declaration is templated. Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp clang-tools-extra/trunk/clang-move/ClangMove.h

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

george.karpenkov added a comment. Checking for asserts makes sense, but as a rough estimate will suppress roughly zero false positives I have seen. In general, LLVM codebase is exceptional in its use of asserts, and most projects, unfortunately, don't really know how to use them.

[PATCH] D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:118 + + Checks for numerical unsigned constants that are equal to '-1' or '~0' + and substitutes them with 'std::numeric_limits::max()'. Wrong kind of quotes were used. Should be `.

[PATCH] D52991: [clangd] Avoid cache main file status in preamble.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Main file can certainly change when reusing preamble. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52991 Files:

[PATCH] D52990: [MinGW] Allow using ubsan

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Turns out that ubsan actually already was supported for msvc mode as well; it just didn't require any code in lib/Driver/ToolChains/MSVC.cpp, Repository: rC Clang https://reviews.llvm.org/D52990 Files:

[PATCH] D52989: [clang-tidy] Fix handling of parens around new expressions in make_ checks.

alexfh created this revision. alexfh added a reviewer: hokein. Herald added a subscriber: xazax.hun. Extra parentheses around a new expression result in incorrect code after applying fixes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52989 Files:

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:519 + +if (FirstAccess->getBeginLoc() < FirstGuard->getBeginLoc()) + return true; xazax.hun wrote: > I am not sure if this is a

[PATCH] D52988: [analyzer][PlistMacroExpansion] Part 5.: Support for # and ##

Szelethus created this revision. Szelethus added reviewers: xazax.hun, NoQ, george.karpenkov, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, whisperity. >From what I can see, this should be the last patch needed to replicate macro

[PATCH] D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits

lebedev.ri added inline comments. Comment at: clang-tidy/readability/NumericalCostantsToMaxIntCheck.h:25 +/// +class NumericalCostantsToMaxIntCheck : public ClangTidyCheck { +public: I feel like the name is overly vague. This *only* handles the cases of `-1` and

[PATCH] D52984: [analyzer] Checker reviewer's checklist

Szelethus added a comment. LGTM! I can think of a couple more, like - making sure that `clang-format` was run on the new files, - not forgetting header guards, - making sure that variables and functions only intended for use within an `assert` call are handled in a way that release build bots

[PATCH] D46975: Implement deduction guides for `std::deque`

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Committed as r332785 https://reviews.llvm.org/D46975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52986: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, xazax.hun, NoQ, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, whisperity. Thanks to @donat.nagy for spotting this! Repository: rC Clang

[PATCH] D52984: [analyzer] Checker reviewer's checklist

xazax.hun updated this revision to Diff 168664. xazax.hun added a comment. - Added the ideas from Kristof. https://reviews.llvm.org/D52984 Files: www/analyzer/checker_dev_manual.html Index: www/analyzer/checker_dev_manual.html

[PATCH] D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits

IdrissRio updated this revision to Diff 168662. IdrissRio marked 22 inline comments as done. IdrissRio edited the summary of this revision. IdrissRio added a comment. Update with the suggestion proposed by @Eugene.Zelenko and @JonasToth Repository: rCTE Clang Tools Extra

[PATCH] D52984: [analyzer] Checker reviewer's checklist

Szelethus added a comment. I love the idea. I got a couple more: Is `-analyzer-checker=core` included in all `RUN:` lines? Is the description in `Checkers.td` clear to a regular user? Is `Checkers.td` and the CMakeLists file alphabetically sorted? Repository: rC Clang

[PATCH] D52984: [analyzer] Checker reviewer's checklist

xazax.hun created this revision. xazax.hun added reviewers: NoQ, george.karpenkov, Szelethus, rnkovacs, szepet, dcoughlin, a.sidorin, MTC. xazax.hun added a project: clang. Herald added subscribers: mikhail.ramalho, dkrupp, baloghadamsoftware, whisperity. This is a first proposal to have a

[PATCH] D52983: [analyzer] Support Reinitializes attribute in MisusedMovedObject check

xazax.hun created this revision. xazax.hun added reviewers: NoQ, szepet, george.karpenkov. xazax.hun added a project: clang. Herald added subscribers: Szelethus, mikhail.ramalho, a.sidorin, dkrupp, rnkovacs, baloghadamsoftware, whisperity. Support the same attribute that the tidy version of this

[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

lebedev.ri added a comment. That's it! Hopefully last portion of nits. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:65-66 has(varDecl(hasLocalStorage(), - hasType(matchers::isExpensiveToCopy()),

[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

baloghadamsoftware updated this revision to Diff 168646. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D52727 Files: clang-tidy/performance/ForRangeCopyCheck.cpp clang-tidy/performance/ForRangeCopyCheck.h

[PATCH] D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes

zinovy.nis added a comment. In https://reviews.llvm.org/D52971#1257705, @alexfh wrote: > Looks good with a comment. It can break the compatibility. May be it worth to add an alias "-check-suffixes" for this option? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52971

[PATCH] D52979: [clangd] Add removeFile interface in FileIndex.

hokein added inline comments. Comment at: clangd/index/FileIndex.h:78 + /// Remove all index data associated with the file \p Path. + void removeFile(PathRef Path); + ioeric wrote: > should we use this somewhere? E.g. when file is closed in ClangdServer? Yes,

[PATCH] D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes

zinovy.nis added a comment. In https://reviews.llvm.org/D52971#1257702, @JonasToth wrote: > The change looks good in principle. I think it would make sense to migrate > one test already, to use the new capability and check if everything works as > expected. The current tests still run fine?

[PATCH] D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a comment. Comment at: test/clang-tidy/check_clang_tidy.py:52 parser.add_argument('temp_file_name') + parser.add_argument('-check-suffix', default=[],

[PATCH] D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes

JonasToth added a comment. The change looks good in principle. I think it would make sense to migrate one test already, to use the new capability and check if everything works as expected. The current tests still run fine? Comment at: test/clang-tidy/check_clang_tidy.py:112

[PATCH] D52979: [clangd] Add removeFile interface in FileIndex.

ioeric added inline comments. Comment at: clangd/index/FileIndex.h:78 + /// Remove all index data associated with the file \p Path. + void removeFile(PathRef Path); + should we use this somewhere? E.g. when file is closed in ClangdServer? Repository: rCTE

[PATCH] D52598: [OpenCL] Fixed address space cast in C style cast of C++ parsing

Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2288 + SrcType->isPointerType()) { +const PointerType *DestPtr = DestType->getAs(); +if (!DestPtr->isAddressSpaceOverlapping(*SrcType->getAs())) { rjmccall wrote: > Anastasia wrote:

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. In https://reviews.llvm.org/D50901#1257651, @filcab wrote: > Sorry about that. I’m away today but I don’t think you’ve answered my > questions about “why not support standalone UBSan in tests”. Sorry if I > missed the answers if you did. I did answer that question

Re: [PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

Sorry about that. I’m away today but I don’t think you’ve answered my questions about “why not support standalone UBSan in tests”. Sorry if I missed the answers if you did. Will review the latest tomorrow. Thank you, Filipe On Mon, 8 Oct 2018 at 07:48, Roman Lebedev via Phabricator <

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

filcab added a subscriber: aizatsky. filcab added a comment. Sorry about that. I’m away today but I don’t think you’ve answered my questions about “why not support standalone UBSan in tests”. Sorry if I missed the answers if you did. Will review the latest tomorrow. Thank you, Filipe

[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343963: [clangd] Update the out-of-date yaml-symbol-file flag in clangd. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r343963 - [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

Author: hokein Date: Mon Oct 8 03:44:54 2018 New Revision: 343963 URL: http://llvm.org/viewvc/llvm-project?rev=343963=rev Log: [clangd] Update the out-of-date yaml-symbol-file flag in clangd. Summary: The flag is stale due to the recent changes of clangd indexer, this patch renames the flag to

[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

hokein updated this revision to Diff 168639. hokein added a comment. address comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52976 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.cpp

[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

hokein added a comment. In https://reviews.llvm.org/D52976#1257614, @sammccall wrote: > Hmm, I wonder if we should remove "experimental" text and the hidden bit. Or > wait to see if we want to move to automatic index entirely? Our plan seems unclear at the moment, so I would suggest not doing

[PATCH] D52979: [clangd] Add removeFile interface in FileIndex.

hokein updated this revision to Diff 168638. hokein added a comment. clang-format. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52979 Files: clangd/index/FileIndex.cpp clangd/index/FileIndex.h unittests/clangd/FileIndexTests.cpp Index:

[PATCH] D52979: [clangd] Add removeFile interface in FileIndex.

hokein created this revision. hokein added reviewers: ioeric, sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Currently we don't cleanup dynamic index if a file is closed in clangd, which may result in large memory consumption in clangd (if we open many

[PATCH] D52598: [OpenCL] Fixed address space cast in C style cast of C++ parsing

Anastasia updated this revision to Diff 168633. Anastasia added a comment. - Changed to pass `QualType` by value. - Improved description of new method. - Added a comment about the OpenCL rules. https://reviews.llvm.org/D52598 Files: lib/Sema/SemaCast.cpp

[PATCH] D52976: [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Hmm, I wonder if we should remove "experimental" text and the hidden bit. Or wait to see if we want to move to automatic index entirely? May want to mention "must have been created by a

  1   2   >