MTC added a comment.
In https://reviews.llvm.org/D52949#1268640, @xbolva00 wrote:
> Second thought, I don't think we should recommend std::size here (maybe it
> should be okay for clang static analyzers)
>
> uint32_t data[] = {10, 20, 30, 40};
> len = sizeof(data)/sizeof(*data); // "warn" on
asavonic closed this revision.
asavonic added a comment.
Committed revision 345044
https://reviews.llvm.org/D51402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: asavonic
Date: Tue Oct 23 09:13:16 2018
New Revision: 345044
URL: http://llvm.org/viewvc/llvm-project?rev=345044=rev
Log:
[OpenCL] Add cl_intel_planar_yuv extension
Just adding a preprocessor #define for the extension.
Patch by Alexey Sotkin and Dmitry Sidorov
Phabricator review:
vglavnyy updated this revision to Diff 170663.
vglavnyy added a comment.
A twice-format problem: the format of format isn't format.
This commit surface an instability problem in clang-format at unit-tests level.
The patch adds double-checking format method for all test and adds a stub for
tests
ioeric added inline comments.
Comment at: clangd/index/IndexAction.h:33
+std::function RefsCallback,
+std::function FileDigestsCallback);
sammccall wrote:
> thinking about what we eventually want here:
> - the index action needs to tell the
ioeric updated this revision to Diff 170664.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- address review comments
- merged with origin/master
- Cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53433
Files:
clangd/index/Background.cpp
hwright added inline comments.
Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.h:19
+
+/// Prefer integer Duration factories when possible.
+///
JonasToth wrote:
> Please add more to the doc here, like `This check finds ... and transforms
> these calls
atanasyan added a comment.
In https://reviews.llvm.org/D52418#1271779, @brad wrote:
> How is it going with regard to N32 fixes / testing?
I'm in the process of building/testing LLVM/Clang binaries for N32 ABI.
Repository:
rC Clang
https://reviews.llvm.org/D52418
hwright updated this revision to Diff 170659.
hwright marked 5 inline comments as done.
hwright added a comment.
Address reviewer comments
https://reviews.llvm.org/D53339
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
AlexeySachkov marked 2 inline comments as done.
AlexeySachkov added inline comments.
Comment at: lib/Headers/opencl-c.h:16197
+#ifdef cl_intel_device_side_avc_motion_estimation
+#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : enable
+
AlexeySachkov updated this revision to Diff 170657.
AlexeySachkov added a comment.
Applied comments. Rebased to ToT
https://reviews.llvm.org/D51484
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Basic/OpenCLExtensionTypes.def
calixte created this revision.
calixte added a reviewer: vsk.
Herald added a subscriber: cfe-commits.
After patch https://reviews.llvm.org/D51974 has landed, this one is required to
fix a test.
Repository:
rC Clang
https://reviews.llvm.org/D53578
Files:
test/CodeGen/code-coverage.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345038: [OpenCL][NFC] Unify ZeroToOCL* cast types (authored
by asavonic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52654
Files:
include/clang/AST/OperationKinds.def
Author: asavonic
Date: Tue Oct 23 08:19:20 2018
New Revision: 345038
URL: http://llvm.org/viewvc/llvm-project?rev=345038=rev
Log:
[OpenCL][NFC] Unify ZeroToOCL* cast types
Reviewers: Anastasia, yaxunl
Reviewed By: Anastasia
Subscribers: asavonic, cfe-commits
Differential Revision:
djasper added inline comments.
Comment at: unittests/Format/FormatTest.cpp:11604
+ " x.end(), //\n"
+ " [&](int, int) { return 1; });\n"
"}\n");
oleg.smolsky wrote:
> krasimir wrote:
> > This looks a bit
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53577
Files:
clangd/index/Index.h
Index: clangd/index/Index.h
scott.linder added a comment.
In https://reviews.llvm.org/D53153#1263882, @rsmith wrote:
> In https://reviews.llvm.org/D53153#1263848, @scott.linder wrote:
>
> > Beyond constructors/destructors I believe an API which we implement through
> > access to dynamic symbols for global variable is
> >
aaron.ballman added a comment.
In https://reviews.llvm.org/D52857#1272420, @steveire wrote:
> Yep, that's the suggestion. That will result in commands such as:
>
> - `enable output detailed-ast`
> - `disable output detailed-ast`
> - `set output detailed-ast`
> - `enable output diag`
> - `disable
steveire added a comment.
Yep, that's the suggestion. That will result in commands such as:
- `enable output detailed-ast`
- `disable output detailed-ast`
- `set output detailed-ast`
- `enable output diag`
- `disable output diag`
- `set output diag`
etc, which I think addresses all concerns.
sammccall added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:277
+
+/// Code completion occurred where an existing name is expected.
+CCC_ExistingName,
It's not obvious what "name" means here, e.g. what distinguishes this from
scott.linder updated this revision to Diff 170637.
scott.linder added a comment.
Don't mark namespace-scope global variable declarations in OpenCL with explicit
default visibility
https://reviews.llvm.org/D53153
Files:
lib/AST/Decl.cpp
test/CodeGenOpenCL/visibility.cl
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345031: [clangd] Lazily create CDB, remove
setCompileCommandsDir. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53572
Author: sammccall
Date: Tue Oct 23 07:19:54 2018
New Revision: 345031
URL: http://llvm.org/viewvc/llvm-project?rev=345031=rev
Log:
[clangd] Lazily create CDB, remove setCompileCommandsDir.
Summary:
The only way to actually set the directory is at initialize time,
so now CDB is lazy we can pass
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
The only way to actually set the directory is at initialize time,
so now CDB is lazy we can pass it to the constructor.
kadircet updated this revision to Diff 170634.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53192
Files:
clangd/CodeComplete.cpp
clangd/index/SymbolCollector.cpp
MTC added inline comments.
Comment at: test/Analysis/NewDelete-custom.cpp:7
-#if !(LEAKS && !ALLOCATOR_INLINING)
// expected-no-diagnostics
Should we continue to keep this line?
Comment at: test/Analysis/NewDelete-sized-deallocation.cpp:1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345029: [clang] Fix a null pointer dereference. (authored by
kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53561
Files:
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
These are available via qualifiers, but signal to noise level is low.
Keep required quailifier machinery around though, for cross-ns
Author: kadircet
Date: Tue Oct 23 06:49:37 2018
New Revision: 345029
URL: http://llvm.org/viewvc/llvm-project?rev=345029=rev
Log:
[clang] Fix a null pointer dereference.
Summary:
Sometimes expression inside switch statement can be invalid, for
example type might be incomplete. In those cases
I found another assert (two really) caused by this patch. Reproducer
for one of them here:
https://bugs.chromium.org/p/chromium/issues/detail?id=898160#c3
On Tue, Oct 23, 2018 at 6:19 AM, Hans Wennborg wrote:
> This broke Chromium again. I've reverted in rr345026
>
> See
kadircet updated this revision to Diff 170631.
kadircet added a comment.
- Add comments.
Repository:
rC Clang
https://reviews.llvm.org/D53191
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Frontend/ASTUnit.cpp
lib/Sema/CodeCompleteConsumer.cpp
lib/Sema/SemaCodeComplete.cpp
AlexeySachkov updated this revision to Diff 170630.
AlexeySachkov added a comment.
Rebase to the ToT
https://reviews.llvm.org/D52654
Files:
include/clang/AST/OperationKinds.def
include/clang/Sema/Initialization.h
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/CodeGen/CGExpr.cpp
kadircet added a comment.
There are still some contexts where both a new name and an existing name is
permissible, going to add a comment on those to leave some traces for the next
person who cares
Repository:
rC Clang
https://reviews.llvm.org/D53191
kadircet updated this revision to Diff 170628.
kadircet added a comment.
Herald added a subscriber: arphaman.
- Use new types
- Rebase
Repository:
rC Clang
https://reviews.llvm.org/D53191
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Frontend/ASTUnit.cpp
kadircet updated this revision to Diff 170626.
kadircet added a comment.
- Rebase and take in new changes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53192
Files:
clangd/CodeComplete.cpp
clangd/index/SymbolCollector.cpp
unittests/clangd/CodeCompleteTests.cpp
Index:
This broke Chromium again. I've reverted in rr345026
See https://bugs.chromium.org/p/chromium/issues/detail?id=898152#c1
for the reproducer.
On Tue, Oct 23, 2018 at 1:06 AM, Hsiangkai Wang via cfe-commits
wrote:
> Author: hsiangkai
> Date: Tue Oct 23 01:06:21 2018
> New Revision: 345009
>
>
Author: hans
Date: Tue Oct 23 06:17:13 2018
New Revision: 345026
URL: http://llvm.org/viewvc/llvm-project?rev=345026=rev
Log:
Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix
PR39094)"
This broke the Chromium build. See
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345024: [clangd] Remove caching of compilation database
commands. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: sammccall
Date: Tue Oct 23 06:14:02 2018
New Revision: 345024
URL: http://llvm.org/viewvc/llvm-project?rev=345024=rev
Log:
[clangd] Remove caching of compilation database commands.
Summary:
The CDB implementations used in open-source code are fast, and our private
slow CDB will soon do
aaron.ballman added a comment.
In https://reviews.llvm.org/D52857#1272276, @steveire wrote:
> I prefer the API from Peter. I think it's a good additional step from where
> Aaron and I reached in IRC discussion (this patch currently).
>
> I can change the patch to use that later if you agree
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from minor commenting nits.
Comment at: clang-query/Query.h:17
#include "llvm/ADT/Optional.h"
+
#include
Spurious newline, or
hokein added a comment.
Could you also update the check documentation
`clang-tidy/checks/cppcoreguidelines-narrowing-conversions.rst`?
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:83
+ } else {
+llvm_unreachable("Invalid state");
}
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with some fixes to the wording.
Comment at: clang-query/Query.cpp:57
+" detailed-ast "
+"Detailed AST output for
steveire added a comment.
I prefer the API from Peter. I think it's a good additional step from where
Aaron and I reached in IRC discussion (this patch currently).
I can change the patch to use that later if you agree Aaron?
Repository:
rCTE Clang Tools Extra
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor wording nits.
Comment at: clang-query/Query.cpp:53
+" print "
+"pretty-print bound
hans added a comment.
In https://reviews.llvm.org/D51340#1266312, @takuto.ikuta wrote:
> Hans, I addressed all your comments.
> How do you think about current implementation?
Just a few questions, but I think it's pretty good.
Comment at:
Szelethus added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:182
+ /// constraint being changed.
+ bool isChanged(const Stmt *Cond, StringRef Message) {
+ConstraintMap::iterator I = Constraints.find(Cond);
hans added a comment.
In https://reviews.llvm.org/D53457#1271046, @neerajksingh wrote:
> In https://reviews.llvm.org/D53457#1269769, @hans wrote:
>
> > I'm not completely convinced that we want this. So far we've used the
> > strategy of promoting clang options that are also useful in clang-cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345022: [clangd] Support passing a relative path to
-compile-commands-dir (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
kadircet updated this revision to Diff 170608.
kadircet added a comment.
Herald added a subscriber: arphaman.
- Add tests.
Repository:
rC Clang
https://reviews.llvm.org/D53561
Files:
lib/Sema/SemaCodeComplete.cpp
test/Index/complete-switch.c
Index: test/Index/complete-switch.c
grimar added a comment.
Maybe `-gno-dwo`? So we would write `-genable-split-dwarf -gno-dwo`?
https://reviews.llvm.org/D52296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sammccall
Date: Tue Oct 23 04:54:36 2018
New Revision: 345022
URL: http://llvm.org/viewvc/llvm-project?rev=345022=rev
Log:
[clangd] Support passing a relative path to -compile-commands-dir
Summary: This is useful when using clangd with CMake based projects in Visual
Studio Code since
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345020: Fix range length comparison in
DraftStore::UpdateDraft when Unicode characters… (authored by sammccall,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
hans accepted this revision.
hans added a comment.
Looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D53476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sammccall
Date: Tue Oct 23 04:51:53 2018
New Revision: 345020
URL: http://llvm.org/viewvc/llvm-project?rev=345020=rev
Log:
Fix range length comparison in DraftStore::UpdateDraft when Unicode characters
are removed from the document
Summary:
See
sammccall added a comment.
Ping - this seems straightforward, and blocks further cleanups.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
gchatelet updated this revision to Diff 170605.
gchatelet marked 2 inline comments as done.
gchatelet added a comment.
- Addressing comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
Files:
clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DaanDeMeyer added a comment.
You can commit them. Thanks for all the quick responses!
https://reviews.llvm.org/D53481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DaanDeMeyer updated this revision to Diff 170603.
DaanDeMeyer added a comment.
Update diff according to comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53527
Files:
clangd/DraftStore.cpp
clangd/SourceCode.cpp
clangd/SourceCode.h
AlexeySachkov updated this revision to Diff 170601.
AlexeySachkov added a comment.
Updated tests
https://reviews.llvm.org/D53200
Files:
lib/Serialization/ASTWriter.cpp
test/SemaOpenCL/extension-begin.cl
test/SemaOpenCL/extension-begin.h
Index: test/SemaOpenCL/extension-begin.h
filcab added a comment.
Ping!
Thank you,
Filipe
Repository:
rC Clang
https://reviews.llvm.org/D52615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
It looks like these are your first couple of LLVM patches.
So, welcome :-) And do you want me to commit them for you?
Typically your first few patches get landed by someone else, and then you ask
for commit access:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for the fix! Just comment nits.
Comment at: clangd/DraftStore.cpp:85
+
+// The difference between EndIndex and StartIndex gives the range length in
+//
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice!
Can you construct an example and add a simple lit test?
https://reviews.llvm.org/rL344133 is a recent similar change.
Repository:
rC Clang
https://reviews.llvm.org/D53561
sammccall updated this revision to Diff 170593.
sammccall added a comment.
Make ReplyOnce move-only.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53399
Files:
clangd/ClangdLSPServer.cpp
Index: clangd/ClangdLSPServer.cpp
kadircet created this revision.
kadircet added reviewers: sammccall, ioeric, hokein.
Herald added a subscriber: cfe-commits.
Sometimes expression inside switch statement can be invalid, for
example type might be incomplete. In those cases code were causing a null
pointer dereference. This patch
mstorsjo reopened this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
So, this failed due to some tests expecting to find the exact same path
substring in different parts of the output (used with FileCheck captured
variables):
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345012: [AST] Do not align virtual bases in
`MicrosoftRecordLayoutBuilder` when (authored by aleksandr.urakov, committed by
).
Repository:
rC Clang
https://reviews.llvm.org/D53497
Files:
tpr created this revision.
Herald added subscribers: cfe-commits, jholewinski.
tpr added reviewers: yaxunl, kzhuravl.
Repository:
rC Clang
https://reviews.llvm.org/D53558
Files:
include/clang/Basic/Cuda.h
lib/Basic/Cuda.cpp
lib/Basic/Targets/NVPTX.cpp
Index:
Author: aleksandr.urakov
Date: Tue Oct 23 01:23:22 2018
New Revision: 345012
URL: http://llvm.org/viewvc/llvm-project?rev=345012=rev
Log:
[AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when
an external layout is used
Summary:
The patch removes alignment of virtual bases
aleksandr.urakov added a comment.
Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D53497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345009: [DebugInfo] Generate debug information for labels.
(After fix PR39094) (authored by HsiangKai, committed by ).
Author: hsiangkai
Date: Tue Oct 23 01:06:21 2018
New Revision: 345009
URL: http://llvm.org/viewvc/llvm-project?rev=345009=rev
Log:
[DebugInfo] Generate debug information for labels. (After fix PR39094)
Generate DILabel metadata and call llvm.dbg.label after label
statement to associate the
AlexeySotkin added a comment.
In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote:
> In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote:
> >
> > > Sorry for digging up an old commit...
> > >
> > > Apparently this
sberg added a comment.
> I've silenced this scenario in r344898, thank you for raising the issue!
thanks! works fine for me
https://reviews.llvm.org/D52400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: mstorsjo
Date: Tue Oct 23 00:01:55 2018
New Revision: 345005
URL: http://llvm.org/viewvc/llvm-project?rev=345005=rev
Log:
Revert "[Driver] Use forward slashes in most linker arguments"
This reverts commit r345004, as it broke tests when actually run
on windows; see e.g.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345004: [Driver] Use forward slashes in most linker
arguments (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345003: [MinGW] Link to correct openmp library (authored by
mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53397
Files:
Author: mstorsjo
Date: Mon Oct 22 23:33:22 2018
New Revision: 345003
URL: http://llvm.org/viewvc/llvm-project?rev=345003=rev
Log:
[MinGW] Link to correct openmp library
Patch by Peiyuan Song!
Differential Revision: https://reviews.llvm.org/D53397
Modified:
Author: mstorsjo
Date: Mon Oct 22 23:33:26 2018
New Revision: 345004
URL: http://llvm.org/viewvc/llvm-project?rev=345004=rev
Log:
[Driver] Use forward slashes in most linker arguments
libtool inspects the output of $CC -v to detect what object files and
libraries are linked in by default. When
101 - 182 of 182 matches
Mail list logo
