[PATCH] D54373: [clang]: Correct naming conventions and 80 col rule violation in CGDeclCXX.cpp. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL346582: Correct naming conventions and 80 col rule violation in CGDeclCXX.cpp. NFC. (authored by kristina, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r346582 - Correct naming conventions and 80 col rule violation in CGDeclCXX.cpp. NFC.

Author: kristina Date: Fri Nov 9 23:53:47 2018 New Revision: 346582 URL: http://llvm.org/viewvc/llvm-project?rev=346582=rev Log: Correct naming conventions and 80 col rule violation in CGDeclCXX.cpp. NFC. Differential Revision: https://reviews.llvm.org/D54373 Modified:

[PATCH] D54373: [clang]: Correct naming conventions and 80 col rule violation in CGDeclCXX.cpp. NFC.

kristina created this revision. kristina added a reviewer: clang. Herald added a subscriber: cfe-commits. Noticed while working with that area of code, NFC. Repository: rC Clang https://reviews.llvm.org/D54373 Files: lib/CodeGen/CGDeclCXX.cpp Index: lib/CodeGen/CGDeclCXX.cpp

[PATCH] D54344: [Clang][CodeGen][CXX]: Workaround __attribute((no_destroy)) crash/incorrect code generation.

kristina added a comment. This seems to be a peculiar side effect of weird combinations of previous uses of attributes `no_destroy`, `used`, and `section`, as well as complex macros used to create metaclass-like systems (through the use of said attributes). It seems that there is a serious bug

[PATCH] D53522: [Frontend] Include module map header declaration in dependency file output

vsapsai added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:1198-1203 +// If the header in the module map refers to a symlink, Header.Entry +// refers to the actual file. The callback should be notified of both. +if (!FullPathAsWritten.empty() && +

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

dblaikie added a comment. OK - thanks for that. I'm going to make an executive decision on the naming. Let's go with -gsplit-dwarf[=single] (or explicitly -gsplit-dwarf=split, which is the default value when -gsplit-dwarf is specified). Saves adding a new name/flag, avoids the use of the word

[PATCH] D18860: [analyzer] Fix the "Zombie symbols" issue.

NoQ added a comment. The manual region cleanup is removed from `MisusedMovedObjectChecker` in https://reviews.llvm.org/D54372. > Another thing, since we're directly testing the functionality of > `SymbolReaper`, maybe it'd be worth to also include unit tests. Sounds like a great idea, and/or

[PATCH] D54372: [analyzer] MisusedMovedObject: NFC: Remove dead code after D18860

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, baloghadamsoftware. Since https://reviews.llvm.org/D18860 addresses the problem that some

[PATCH] D18860: [analyzer] Fix the "Zombie symbols" issue.

NoQ updated this revision to Diff 173487. NoQ added a comment. Add an interesting test for the `MisusedMovedObject` checker that demonstrates one more potential source of false positives caused by the zombie symbol problem. In this test there are, well, //no symbols//. Therefore, there are no

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

NoQ added a comment. Thanks! I don't have much to add to the review, but i very much approve this check. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

aaron.ballman added a comment. What do you think about code like: #if FOO == 4 #if FOO == 4 #endif #endif #if defined(FOO) #if defined(FOO) #endif #endif #if !defined(FOO) #if !defined(FOO) #endif #endif #if defined(FOO) #if !defined(FOO) #endif #endif

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

vmiklos updated this revision to Diff 173468. vmiklos edited the summary of this revision. https://reviews.llvm.org/D54349 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantPreprocessorCheck.cpp

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

vmiklos added a comment. > preprocessor directives? Same in documentation. Done. https://reviews.llvm.org/D54349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

vmiklos added a comment. > I think that name is not very descriptive for the user of clang-tidy. `pp` > should be `preprocessor` or some other constellation that makes it very clear > its about the preprocessor. Done, renamed to readability-redundant-preprocessor. > you are in namespace

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

vmiklos updated this revision to Diff 173465. vmiklos retitled this revision from "[clang-tidy] new check 'readability-redundant-pp'" to "[clang-tidy] new check 'readability-redundant-preprocessor'". https://reviews.llvm.org/D54349 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

pcc added inline comments. Comment at: docs/LTOVisibility.rst:9 unit's *LTO unit* is the subset of the linkage unit that is linked together -using link-time optimization; in the case where LTO is not being used, the -linkage unit's LTO unit is empty. Each linkage unit has only

[PATCH] D53522: [Frontend] Include module map header declaration in dependency file output

erik.pilkington added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:1198-1203 +// If the header in the module map refers to a symlink, Header.Entry +// refers to the actual file. The callback should be notified of both. +if (!FullPathAsWritten.empty() && +

[PATCH] D54344: [Clang][CodeGen][CXX]: Workaround __attribute((no_destroy)) crash/incorrect code generation.

kristina added a comment. In https://reviews.llvm.org/D54344#1293643, @aaron.ballman wrote: > In https://reviews.llvm.org/D54344#1293468, @erik.pilkington wrote: > > > Have you tried running creduce on the preprocessed source? We should really > > have a real reproducer for this, otherwise its

[PATCH] D53995: [analyzer] Drastically simplify the tblgen files used for checkers

Szelethus added a comment. > I agree that it's aesthetically satisfying, but it is (1) inconvenient to > write because that's the whole new syntax you need to memorize, i.e. all > those <> and semicolons and (2) not cooperating when i want to look up > checker name by source file (have to scan

[PATCH] D54288: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method.

This revision was automatically updated to reflect the committed changes. Closed by commit rC346566: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when… (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D54288?vs=173258=173457#toc

[PATCH] D54288: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method.

This revision was automatically updated to reflect the committed changes. Closed by commit rL346566: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r346566 - Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method.

Author: wizard Date: Fri Nov 9 15:19:14 2018 New Revision: 346566 URL: http://llvm.org/viewvc/llvm-project?rev=346566=rev Log: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method. Summary: The issue is that for array

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

ztamas added a comment. In https://reviews.llvm.org/D53974#1293268, @JonasToth wrote: > LGTM. > Did you run this check in its final form against a bigger project? These > results would be interesting. I'll run it on LibreOffice code again and we'll see. > Do you have commit access? Commit

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

NoQ added a comment. In https://reviews.llvm.org/D53692#1293778, @Szelethus wrote: > Did you know that clang unit tests do not run with check-clang-analysis? Well, *some* unit tests definitely do run under check-clang-analysis. Repository: rC Clang https://reviews.llvm.org/D53692

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus marked an inline comment as done. Szelethus added a comment. Thanks! This patch was the last for a while directly related to non-checker config options, I'm currently stuck on them as I unearthed countless bugs that I have to fix beforehand. (Did you know that clang unit tests do not

[PATCH] D53995: [analyzer] Drastically simplify the tblgen files used for checkers

NoQ accepted this revision. NoQ added a comment. Thx!! Burn it. > tblgen files look awesome. I get that this isn't a very strong point, but > it's a pretty sight compared to a .def file. I agree that it's aesthetically satisfying, but it is (1) inconvenient to write because that's the whole

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, this is really wonderful. Comment at: test/Analysis/analyzer-config.cpp:1 // RUN: %clang_analyze_cc1 -triple x86_64-apple-darwin10 %s -o /dev/null

[PATCH] D52984: [analyzer] Checker reviewer's checklist

NoQ added a comment. Thx!! Tiny nits. Comment at: www/analyzer/checker_dev_manual.html:720 +User facing documentation is important for adoption! Make sure the check list updated +at the homepage of the analyzer. Also ensure that the description is good quality in +

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void added a comment. This has https://reviews.llvm.org/D54356 integrated into it. https://reviews.llvm.org/D54356 should be reviewed and submitted first, even though it's out of order. Repository: rC Clang https://reviews.llvm.org/D54355 ___

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void updated this revision to Diff 173445. void added a comment. Herald added a subscriber: jfb. Adding ConstantExpr visitor. Repository: rC Clang https://reviews.llvm.org/D54355 Files: include/clang/AST/Expr.h lib/AST/ASTImporter.cpp lib/AST/Expr.cpp lib/AST/ExprConstant.cpp

[PATCH] D54356: Convert CheckICE into a statment visitor

void created this revision. void added reviewers: rsmith, shafik. Herald added a subscriber: jfb. This cleans up the code somewhat and allows us conditionally to act on different types of nodes depending on their context. E.g., if we're checking for an ICE in a constant context. Repository:

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void created this revision. void added a reviewer: rsmith. Herald added subscribers: cfe-commits, kristina. Herald added a reviewer: shafik. A __builtin_constant_p may end up with a constant after inlining. Use the is.constant intrinsic if it's a variable that's in a context where it may resolve

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-pp'

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:73 + + Finds potentially redundant preprocessor usage. + preprocessor directives? Same in documentation. Comment at: docs/clang-tidy/checks/readability-redundant-pp.rst:8

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-pp'

vmiklos added a comment. In https://reviews.llvm.org/D54349#1293622, @lebedev.ri wrote: > No one will know for sure what "pp" in "readability-redundant-pp" means. > I'd highly recommend to fully spell it out. Will do. > Also, i'd like to see some analysis of the false-positives. Things I

[PATCH] D54344: [Clang][CodeGen][CXX]: Workaround __attribute((no_destroy)) crash/incorrect code generation.

aaron.ballman added a comment. In https://reviews.llvm.org/D54344#1293468, @erik.pilkington wrote: > Have you tried running creduce on the preprocessed source? We should really > have a real reproducer for this, otherwise its really hard to tell what the > underlying problem is. I'm going to

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-pp'

JonasToth added a comment. Hi vmiklos, thank you for working on this patch! I added a few comments. Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:83 "readability-misplaced-array-index"); +CheckFactories.registerCheck("readability-redundant-pp");

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-pp'

lebedev.ri added a comment. No one will know for sure what "pp" in "readability-redundant-pp" means. I'd highly recommend to fully spell it out. Also, i'd like to see some analysis of the false-positives. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54349

[PATCH] D54344: [Clang][CodeGen][CXX]: Workaround __attribute((no_destroy)) crash/incorrect code generation.

kristina added a comment. In https://reviews.llvm.org/D54344#1293468, @erik.pilkington wrote: > Have you tried running creduce on the preprocessed source? We should really > have a real reproducer for this, otherwise its really hard to tell what the > underlying problem is. Unable to build

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-pp'

vmiklos added a comment. I've used this check originally on LibreOffice (core, online) code and it found a handful of not necessary ifdef / ifndef lines. It seemed it's simple and generic enough that it would make sense to upstream this. Repository: rCTE Clang Tools Extra

r346556 - Revert "Revert rL346454: Fix a use-after-free introduced by r344915."

Author: adrian Date: Fri Nov 9 13:17:38 2018 New Revision: 346556 URL: http://llvm.org/viewvc/llvm-project?rev=346556=rev Log: Revert "Revert rL346454: Fix a use-after-free introduced by r344915." This un-reverts commit 346454 with a relaxed CHECK for Windows. Added:

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-pp'

vmiklos created this revision. vmiklos added reviewers: JonasToth, alexfh. Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai. Finds potentially redundant preprocessor usage. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54349 Files:

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 

aaron.ballman added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:55 + // to use. + if (Decl->getStorageClass() != SC_Static) { +return FixItHint(); Elide braces. Comment at:

[PATCH] D54281: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

This revision was automatically updated to reflect the committed changes. Closed by commit rL346555: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds… (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D54281: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

JonasToth updated this revision to Diff 173425. JonasToth added a comment. - fix comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54281 Files: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp

[clang-tools-extra] r346555 - [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

Author: jonastoth Date: Fri Nov 9 12:57:28 2018 New Revision: 346555 URL: http://llvm.org/viewvc/llvm-project?rev=346555=rev Log: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay Summary: The fix to the issue that `const char* p = ("foo")`

[PATCH] D54307: [ASTMatchers] overload ignoringParens for Expr

This revision was automatically updated to reflect the committed changes. Closed by commit rC346554: [ASTMatchers] overload ignoringParens for Expr (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D54307?vs=173422=173424#toc Repository: rC Clang

[PATCH] D54281: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

JonasToth updated this revision to Diff 173423. JonasToth added a comment. - use ignoringParens instead Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54281 Files: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp

r346554 - [ASTMatchers] overload ignoringParens for Expr

Author: jonastoth Date: Fri Nov 9 12:54:06 2018 New Revision: 346554 URL: http://llvm.org/viewvc/llvm-project?rev=346554=rev Log: [ASTMatchers] overload ignoringParens for Expr Summary: This patch allows fixing PR39583. Reviewers: aaron.ballman, sbenza, klimek Reviewed By: aaron.ballman

[PATCH] D54307: [ASTMatchers] overload ignoringParens for Expr

JonasToth updated this revision to Diff 173422. JonasToth added a comment. - add unit test Repository: rC Clang https://reviews.llvm.org/D54307 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

Re: r346491 - [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

Ah cool. But the diagnostic is "option /dllexportInlines- is ignored when /fallback happens" – shouldn't it be ignored regardless of if fallback happens? Does that happen and the warning text is wrong? On Fri, Nov 9, 2018 at 11:20 AM Hans Wennborg wrote: > On Fri, Nov 9, 2018 at 4:53 PM, Nico

Re: [clang-tools-extra] r346461 - Ignore implicit things like ConstantExpr.

This fix was submitted because a test was failing without it. :-) On Thu, Nov 8, 2018 at 10:08 PM Roman Lebedev wrote: > Test? > > On Fri, Nov 9, 2018 at 4:34 AM Bill Wendling via cfe-commits > wrote: > > > > Author: void > > Date: Thu Nov 8 17:32:30 2018 > > New Revision: 346461 > > > > URL:

[PATCH] D54344: [Clang][CodeGen][CXX]: Workaround __attribute((no_destroy)) crash/incorrect code generation.

erik.pilkington added a reviewer: erik.pilkington. erik.pilkington added a comment. Have you tried running creduce on the preprocessed source? We should really have a real reproducer for this, otherwise its really hard to tell what the underlying problem is. https://reviews.llvm.org/D54344

[PATCH] D54307: [clang] overload ignoringParens for Expr

JonasToth added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:814 /// would match the declaration for fp. -AST_MATCHER_P(QualType, ignoringParens, - internal::Matcher, InnerMatcher) { +AST_MATCHER_P_OVERLOAD(QualType, ignoringParens,

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

rnk added a comment. Threading a new options argument through mangleType that includes QualifierMangleMode as well as these obj-c options seems reasonable. Repository: rC Clang https://reviews.llvm.org/D52674 ___ cfe-commits mailing list

[PATCH] D54344: [Clang][CodeGen][CXX]: Workaround __attribute((no_destroy)) crash/incorrect code generation.

kristina updated this revision to Diff 173411. kristina added a comment. Revised (style/ordering). https://reviews.llvm.org/D54344 Files: lib/CodeGen/CGDeclCXX.cpp Index: lib/CodeGen/CGDeclCXX.cpp === ---

[PATCH] D33029: [clang-format] add option for dangling parenthesis

sciencemanx added a comment. @djasper bump -- this feature is also really important to our team. https://reviews.llvm.org/D33029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54344: [Clang][CodeGen][CXX]: Workaround __attribute((no_destroy)) crash/incorrect code generation.

kristina created this revision. kristina added reviewers: rsmith, clang, JonasToth, EricWF, aaron.ballman. Herald added subscribers: dexonsmith, mehdi_amini. Herald added a reviewer: jfb. Difficult to reproduce crash, attempted it in the test, it appears to not trigger it. I can consistently

r346551 - [OPENMP][NVPTX]Extend number of constructs executed in SPMD mode.

Author: abataev Date: Fri Nov 9 12:03:19 2018 New Revision: 346551 URL: http://llvm.org/viewvc/llvm-project?rev=346551=rev Log: [OPENMP][NVPTX]Extend number of constructs executed in SPMD mode. If the statements between target|teams|distribute directives does not require execution in master

[PATCH] D54307: [clang] overload ignoringParens for Expr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: include/clang/ASTMatchers/ASTMatchers.h:814 /// would match the declaration for fp. -AST_MATCHER_P(QualType, ignoringParens, -

[PATCH] D54307: [clang] overload ignoringParens for Expr

sbenza added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:814 /// would match the declaration for fp. -AST_MATCHER_P(QualType, ignoringParens, - internal::Matcher, InnerMatcher) { +AST_MATCHER_P_OVERLOAD(QualType, ignoringParens,

Re: r346548 - Use the correct address space when bitcasting func pointer to int pointer

The codegen change can't be tested? On Fri, Nov 9, 2018 at 10:44 PM Dylan McKay via cfe-commits wrote: > > Author: dylanmckay > Date: Fri Nov 9 11:42:05 2018 > New Revision: 346548 > > URL: http://llvm.org/viewvc/llvm-project?rev=346548=rev > Log: > Use the correct address space when bitcasting

r346549 - Revert rL346454: Fix a use-after-free introduced by r344915.

Author: rksimon Date: Fri Nov 9 11:42:53 2018 New Revision: 346549 URL: http://llvm.org/viewvc/llvm-project?rev=346549=rev Log: Revert rL346454: Fix a use-after-free introduced by r344915. r344915 added a call to ApplyDebugLocation to the sanitizer check function emitter. Some of the sanitizers

r346548 - Use the correct address space when bitcasting func pointer to int pointer

Author: dylanmckay Date: Fri Nov 9 11:42:05 2018 New Revision: 346548 URL: http://llvm.org/viewvc/llvm-project?rev=346548=rev Log: Use the correct address space when bitcasting func pointer to int pointer When we cast a function pointer to an int pointer, at some pointer later it gets bitcasted

r346547 - Allow a double-underscore spelling of Clang attributes using double square bracket syntax.

Author: aaronballman Date: Fri Nov 9 11:37:18 2018 New Revision: 346547 URL: http://llvm.org/viewvc/llvm-project?rev=346547=rev Log: Allow a double-underscore spelling of Clang attributes using double square bracket syntax. This matches a similar behavior with GCC accepting [[gnu::__attr__]]

[PATCH] D54307: [clang] overload ignoringParens for Expr

aaron.ballman added reviewers: sbenza, klimek. aaron.ballman added a comment. Adding a few other reviewers in case they have ideas on how to use the polymorphic matcher rather than the overload. If they don't have a better idea, then I think the overload approach is fine. Repository: rC

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai added a comment. In https://reviews.llvm.org/D52674#1293180, @rjmccall wrote: > In https://reviews.llvm.org/D52674#1291284, @smeenai wrote: > > > In https://reviews.llvm.org/D52674#1281747, @rjmccall wrote: > > > > > In https://reviews.llvm.org/D52674#1271814, @smeenai wrote: > > > > > >

r346542 - Fix a nondeterminism in the debug info for VLA size expressions.

Author: adrian Date: Fri Nov 9 11:17:56 2018 New Revision: 346542 URL: http://llvm.org/viewvc/llvm-project?rev=346542=rev Log: Fix a nondeterminism in the debug info for VLA size expressions. The artificial variable describing the array size is supposed to be called "__vla_expr", but this was

[PATCH] D54307: [clang] overload ignoringParens for Expr

JonasToth updated this revision to Diff 173391. JonasToth marked 3 inline comments as done. JonasToth added a comment. - add unit test Repository: rC Clang https://reviews.llvm.org/D54307 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D54307: [clang] overload ignoringParens for Expr

JonasToth added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:814 /// would match the declaration for fp. -AST_MATCHER_P(QualType, ignoringParens, - internal::Matcher, InnerMatcher) { +AST_MATCHER_P_OVERLOAD(QualType, ignoringParens,

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay created this revision. dylanmckay added reviewers: aaron.ballman, kparzysz, asb, hfinkel. This patch modifies the AVR toolchain so that if avr-gcc and avr-libc are detected during compilation, the CRT, libgcc, libm, and libc anre linked. This matches avr-gcc's default behaviour, and

[PATCH] D54325: [AST] Pack CXXBoolLiteralExpr, CXXNullPtrLiteralExpr and CXXThisExpr

riccibruno updated this revision to Diff 173383. riccibruno added a comment. Fix some typos in the added comments in `Stmt.h` Repository: rC Clang https://reviews.llvm.org/D54325 Files: include/clang/AST/ExprCXX.h include/clang/AST/Stmt.h Index: include/clang/AST/Stmt.h

[PATCH] D54275: [HIP] Remove useless sections in linked files

This revision was automatically updated to reflect the committed changes. Closed by commit rC346536: [HIP] Remove useless sections in linked files (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D54275 Files: lib/Driver/ToolChains/CommonArgs.cpp Index:

r346536 - [HIP] Remove useless sections in linked files

Author: yaxunl Date: Fri Nov 9 10:52:05 2018 New Revision: 346536 URL: http://llvm.org/viewvc/llvm-project?rev=346536=rev Log: [HIP] Remove useless sections in linked files clang-offload-bundler creates __CLANG_OFFLOAD_BUNDLE__* sections in the bundles, which get into the linked files. These

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. Did you run this check in its final form against a bigger project? These results would be interesting. Do you have commit access? Repository: rCTE Clang Tools Extra

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:36 +GetScaleForFactory(llvm::StringRef FactoryName) { + static const auto *ScaleMap = + new std::unordered_map( hokein wrote: > aaron.ballman wrote: > >

[PATCH] D54307: [clang] overload ignoringParens for Expr

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:814 /// would match the declaration for fp. -AST_MATCHER_P(QualType, ignoringParens, - internal::Matcher, InnerMatcher) { +AST_MATCHER_P_OVERLOAD(QualType, ignoringParens,

[PATCH] D54307: [clang] overload ignoringParens for Expr

JonasToth added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:814 /// would match the declaration for fp. -AST_MATCHER_P(QualType, ignoringParens, - internal::Matcher, InnerMatcher) { +AST_MATCHER_P_OVERLOAD(QualType, ignoringParens,

[PATCH] D53995: [analyzer] Drastically simplify the tblgen files used for checkers

Szelethus added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D53995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

ztamas updated this revision to Diff 173372. ztamas added a comment. - Make local functions `static` Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53974 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:108-113 + if (T.isSignedInteger()) +return {llvm::APSInt::getMinValue(Context.getTypeSize(), false), +llvm::APSInt::getMaxValue(Context.getTypeSize(),

[PATCH] D54330: Driver: Make -fsanitize=shadow-call-stack compatible with -fsanitize-minimal-runtime.

This revision was automatically updated to reflect the committed changes. Closed by commit rL346526: Driver: Make -fsanitize=shadow-call-stack compatible with -fsanitize-minimal… (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D54330?vs=173367=173368#toc

r346526 - Driver: Make -fsanitize=shadow-call-stack compatible with -fsanitize-minimal-runtime.

Author: pcc Date: Fri Nov 9 09:54:49 2018 New Revision: 346526 URL: http://llvm.org/viewvc/llvm-project?rev=346526=rev Log: Driver: Make -fsanitize=shadow-call-stack compatible with -fsanitize-minimal-runtime. Differential Revision: https://reviews.llvm.org/D54330 Modified:

[PATCH] D54330: Driver: Make -fsanitize=shadow-call-stack compatible with -fsanitize-minimal-runtime.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D54330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

aaron.ballman added a comment. In https://reviews.llvm.org/D54258#1292129, @richardmembarth wrote: > I think it's not so easy to provide such tests for CUDA. > CUDA memory space specifiers are implemented via attributes, e.g. `#define > __shared__ __attribute__((shared))`. > As a result of

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

rjmccall added a comment. In https://reviews.llvm.org/D52674#1291284, @smeenai wrote: > In https://reviews.llvm.org/D52674#1281747, @rjmccall wrote: > > > In https://reviews.llvm.org/D52674#1271814, @smeenai wrote: > > > > > @rjmccall I prototyped the ForRTTI parameter approach in > > >

[PATCH] D54330: Driver: Make -fsanitize=shadow-call-stack compatible with -fsanitize-minimal-runtime.

pcc created this revision. pcc added a reviewer: eugenis. Herald added subscribers: llvm-commits, cryptoad. Repository: rL LLVM https://reviews.llvm.org/D54330 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/fsanitize.c Index: clang/test/Driver/fsanitize.c

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

rjmccall added inline comments. Comment at: lib/AST/Expr.cpp:1609 case CK_AddressSpaceConversion: -assert(getType()->isPointerType() || getType()->isBlockPointerType()); -assert(getSubExpr()->getType()->isPointerType() || -

[clang-tools-extra] r346524 - [clangd] Fix clang-tidy warnings.

Author: kadircet Date: Fri Nov 9 09:33:48 2018 New Revision: 346524 URL: http://llvm.org/viewvc/llvm-project?rev=346524=rev Log: [clangd] Fix clang-tidy warnings. Modified: clang-tools-extra/trunk/unittests/clangd/TestTU.cpp Modified: clang-tools-extra/trunk/unittests/clangd/TestTU.cpp

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov added a comment. In https://reviews.llvm.org/D54310#1292924, @sammccall wrote: > If you know of a good reviewer for this, you may want a second opinion! This would definitely be nice, but I also don't know who'd be the proper person to review this. I'll take a pause until

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov updated this revision to Diff 173364. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Update the comment. Repository: rC Clang https://reviews.llvm.org/D54310 Files: include/clang/Lex/HeaderSearchOptions.h

[PATCH] D53700: Support _Clang as a scoped attribute identifier

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews -- I've commit in r346521. https://reviews.llvm.org/D53700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r346521 - Introduce the _Clang scoped attribute token.

Author: aaronballman Date: Fri Nov 9 09:19:45 2018 New Revision: 346521 URL: http://llvm.org/viewvc/llvm-project?rev=346521=rev Log: Introduce the _Clang scoped attribute token. Currently, we only accept clang as the scoped attribute identifier for double square bracket attributes provided by

r346520 - Use the correct address space when emitting the ctor function list

Author: dylanmckay Date: Fri Nov 9 09:15:06 2018 New Revision: 346520 URL: http://llvm.org/viewvc/llvm-project?rev=346520=rev Log: Use the correct address space when emitting the ctor function list This patch modifies clang so that, if compiling for a target that explicitly specifies a nonzero

[PATCH] D54326: [AST] Pack CXXThrowExpr, CXXDefaultArgExpr and CXXDefaultInitExpr

riccibruno created this revision. riccibruno added a reviewer: rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno added a dependency: D54325: [AST] Pack CXXBoolLiteralExpr, CXXNullPtrLiteralExpr and CXXThisExpr. Use the newly available space in the

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:292 + bool IsDebugEnabled = !A || A->getOption().matches(options::OPT_O0) || +Args.hasFlag(options::OPT_cuda_noopt_device_debug, +

[PATCH] D54204: [clangd] Initial clang-tidy diagnostics support.

sammccall added inline comments. Comment at: clangd/ClangdUnit.cpp:175 +CTFactories.createChecks(CTContext.getPointer(), CTChecks); +for (const auto : CTChecks) { + Check->registerPPCallbacks(*Clang); hokein wrote: > Maybe add the check names to

[PATCH] D54325: [AST] Pack CXXBoolLiteralExpr, CXXNullPtrLiteralExpr and CXXThisExpr

riccibruno created this revision. riccibruno added a reviewer: rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Use the newly available space in the bit-fields of `Stmt` to store some data from `CXXBoolLiteralExpr`, `CXXNullPtrLiteralExpr` and `CXXThisExpr`.

[PATCH] D54281: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor commenting nit. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-array-to-pointer-decay.cpp:44 +const char *g2() { +return

[PATCH] D54204: [clangd] Initial clang-tidy diagnostics support.

sammccall updated this revision to Diff 173357. sammccall marked an inline comment as done. sammccall added a comment. Address comments and rebase on https://reviews.llvm.org/D54309, addressing performance issues. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54204 Files:

[PATCH] D54324: [AST] Store the value of CharacterLiteral inline if possible

riccibruno created this revision. riccibruno added a reviewer: rsmith. riccibruno added a project: clang. Herald added a reviewer: shafik. Herald added a subscriber: cfe-commits. The vast majority of `CharacterLiteral`s have a value which fits into 8 bits (in the 2666 `CharacterLiteral`s in all

  1   2   >