Re: r348276 - [AST][NFC] Make ArrayTypeTraitExpr non polymorphic

Hi, On 12/11/18 5:49 PM, Bruno Ricci wrote: > Hi Mikael, > > I can indeed reproduce this with gcc 5.5.0 when doing a Release > build with assertions. I cannot reproduce this with gcc 6.5.0 > (also with a Release build with assertions), nor can I reproduce > this with clang 7 (also with a Release

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

echristo accepted this revision. echristo added a comment. LGTM. I'm quite a bit happier with this now. Thanks for going through the back and forth. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51554/new/ https://reviews.llvm.org/D51554

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

smeenai added a comment. I'd tried this exact same patch back in https://reviews.llvm.org/D44619, but I was running into a bunch of check-clang failures with it, and I was never able to figure them out. It looks like it works now though, so I'm glad :) Richard's comment from that diff might

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

smeenai abandoned this revision. smeenai added a comment. https://reviews.llvm.org/D55543 does the same thing Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44619/new/ https://reviews.llvm.org/D44619 ___ cfe-commits

r348911 - [CodeGen] Fix -DBUILD_SHARED_LIBS=on build after rC348907

Author: maskray Date: Tue Dec 11 22:07:33 2018 New Revision: 348911 URL: http://llvm.org/viewvc/llvm-project?rev=348911=rev Log: [CodeGen] Fix -DBUILD_SHARED_LIBS=on build after rC348907 Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt URL:

[PATCH] D55229: [COFF] Statically link certain runtime library functions

compnerd added inline comments. Comment at: CodeGen/CodeGenModule.cpp:2957-2958 !getCodeGenOpts().LTOVisibilityPublicStd && - !getTriple().isWindowsGNUEnvironment()) { + !getTriple().isWindowsGNUEnvironment() && +

[PATCH] D55525: [Driver] Add support for -fembed-bitcode for assembly file

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Please do clang-format this. If this is already in the wild, then, I suppose that we don't have the option, but, this seems like something that should be written by the author of the

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

rjmccall added a comment. Nice catch. This also fixes problems where there might be cleanups entered by `EmitParmDecl`, e.g. in ObjC++ with a parameter of type `struct A { __strong id x; }`; could you please add a test for that and verify that the parameter is destroyed at an appropriate

[PATCH] D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type

rjmccall added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3441 + Value); +} APSInt LHS = HandleIntToIntCast(Info, E, PromotedLHSType, Can we more fundamentally restructure this entire handler so that, if

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: docs/LibASTMatchersReference.html:2579-2581 +y(x); Matches +NS::y(x); Doesn't match +y(42); Doesn't match. aaron.ballman wrote: > EricWF wrote: > > aaron.ballman

r348907 - Move PCHContainerOperations from Frontend to Serialization

Author: rtrieu Date: Tue Dec 11 18:53:59 2018 New Revision: 348907 URL: http://llvm.org/viewvc/llvm-project?rev=348907=rev Log: Move PCHContainerOperations from Frontend to Serialization Fix a layering violation. Frontend depends on Serialization, so anything used by both should be in

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

hgabii marked 4 inline comments as done. hgabii added inline comments. Comment at: docs/ReleaseNotes.rst:139 + + Warns for cases when pointer is cast and the pointed to type is + incompatible with allocated memory area type. This may lead to access memory

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

hgabii updated this revision to Diff 177812. hgabii added a comment. Highlight type names in documentation. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48866/new/ https://reviews.llvm.org/D48866 Files: clang-tidy/misc/CMakeLists.txt

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

hgabii added a comment. Check for different size and alignment as well. Tests migrated from D33826 . Warning in case of `reinterpret_cast`, but options is added to be able to turn it off. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:139 + + Warns for cases when pointer is cast and the pointed to type is + incompatible with allocated memory area type. This may lead to access memory Please wrap up to 80 characters. Same

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

hgabii updated this revision to Diff 177810. hgabii marked an inline comment as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48866/new/ https://reviews.llvm.org/D48866 Files: clang-tidy/misc/CMakeLists.txt

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return false; +

[PATCH] D54604: Automatic variable initialization

rsmith added a comment. For the record: I'm OK with this direction. (I somewhat prefer removing the `-enable-long-wordy-thing` option and instead automatically disabling the `zero` option for clang release builds, but I'm OK with either approach.) Comment at:

Re: r346789 - DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use.

(tiny factoid: turns out gold's 64 bit gdb-index support is also broken in a different, more subtle way... - so best folks don't use this flag except with lld, it seems, if you're using gdb-index) On Tue, Nov 13, 2018 at 12:10 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote:

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai marked an inline comment as done. vsapsai added a comment. In D48753#1323248 , @ldionne wrote: > 2. Also, before this patch, the allocator's `construct` and `destroy` were > NEVER called in C++03, but were called when available in C++11. After

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

Quuxplusone added inline comments. Comment at: libcxx/include/memory:1726 +#else // _LIBCPP_HAS_NO_VARIADICS +template +_LIBCPP_INLINE_VISIBILITY vsapsai wrote: > ldionne wrote: > > Here, > > > > ``` > > template >

Buildbot numbers for the week of 12/02/2018 - 12/08/2018

Hello everyone, Below are some buildbot numbers for the last week of 12/02/2018 - 12/08/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 11/25/2018 - 12/01/2018

Hello everyone, Below are some buildbot numbers for the week of 11/25/2018 - 12/01/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai marked 3 inline comments as done. vsapsai added a comment. Regarding the tests. I've moved most of new tests for custom allocators to test/libcxx/*. And in destroy.pass.cpp I'm just checking `_LIBCPP_VERSION` to avoid copying the test to a different file. Comment at:

Buildbot numbers for the week of 11/18/2018 - 11/24/2018

Hello everyone, Below are some buildbot numbers for the week of 11/18/2018 - 11/24/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai updated this revision to Diff 177803. vsapsai added a comment. - Update `__has_construct`, `__has_destroy` according to review comments. - Tighten tests: custom allocators aren't mandated by C++03 but libc++ has the support. CHANGES SINCE LAST ACTION

[PATCH] D55525: [Driver] Add support for -fembed-bitcode for assembly file

steven_wu added a comment. In D55525#1327742 , @compnerd wrote: > This really feels odd. Why not expect that the developer will add the > content themselves? I'm not sure I understand the motivation for this change. The main motivation for

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return

[PATCH] D55229: [COFF] Statically link certain runtime library functions

rnk added a comment. Thanks. I think what we really want to do here is reconsider our default for applying dllimport. Leaving things unannotated is a good safe default for every environment. In the absence of any flags, clang should assume runtime functions are statically linked. The linker

[PATCH] D53238: [Driver] Add -static-{rtlib, stdlib} and make -static-{libgcc, libstdc++} their aliases

rnk added a comment. (sub) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53238/new/ https://reviews.llvm.org/D53238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177796. hubert.reinterpretcast added a comment. Recast representation-sensitive tests as SemaCXX tests using array bounds Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55510/new/

[PATCH] D55546: [clang] Add AST matcher for block expressions 

stephanemoore added a comment. Please let me know if I missed anything as part of this proposed change. I tried my best to determine how to make this change appropriately based on previous submissions and documentation but I recognize that I could have missed things  Repository: rC Clang

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 

stephanemoore updated this revision to Diff 177795. stephanemoore marked 5 inline comments as done. stephanemoore added a comment. Changes: • Drop const on local bool variable. • Adopt the term "function in global namespace" in diagnostic messages. CHANGES SINCE LAST ACTION

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 

stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:115 diag(MatchedDecl->getLocation(), - "function name %0 not using function naming conventions described by " - "Google Objective-C style guide") - << MatchedDecl <<

[PATCH] D55586: Basic: make `int_least64_t` and `int_fast64_t` match on Darwin

compnerd created this revision. compnerd added reviewers: ahatanak, rjmccall. The Darwin targets use `int64_t` and `uint64_t` to define the `int_least64_t` and `int_fast64_t` types. The underlying type is actually a `long long`. Match the types to allow the printf specifiers to work properly

[PATCH] D55229: [COFF] Statically link certain runtime library functions

compnerd added a subscriber: theraven. compnerd added inline comments. Comment at: CodeGen/CodeGenModule.cpp:2957-2958 !getCodeGenOpts().LTOVisibilityPublicStd && - !getTriple().isWindowsGNUEnvironment()) { + !getTriple().isWindowsGNUEnvironment() &&

[PATCH] D55525: [Driver] Add support for -fembed-bitcode for assembly file

compnerd added a comment. This really feels odd. Why not expect that the developer will add the content themselves? I'm not sure I understand the motivation for this change. I think that this should be easy to write a test case for as well. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55566: [analyzer] LiveVariables: Fix a zombie expression problem, add testing infrastructure.

Szelethus added a comment. Makes sense! I like the summary a lot, and the fact that you added a new debug checker. I feel like I'm not yet qualified to give meaningful feedback though, but if you are not in a hurry, I'll happily play around with this patch next week, and both learn a bit and

[PATCH] D55229: [COFF] Statically link certain runtime library functions

rnk added a comment. Sorry, I was out sick for a week. We should ask @smeenai about this change, since he has been doing more work in this area recently. Comment at: CodeGen/CodeGenModule.cpp:2957-2958 !getCodeGenOpts().LTOVisibilityPublicStd && -

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

Quuxplusone added a comment. @courbet: On the cpplang Slack, Peter Feichtinger mentioned that defaulted template arguments should perhaps be treated differently. Is there any way to suppress the `, std::allocator` part of this diagnostic? https://godbolt.org/z/TM0UHc Before your patches:

[PATCH] D55527: Normalize GlobalDecls when used with CPUDispatch

erichkeane marked 4 inline comments as done. erichkeane added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:910 Out << ".resolver"; } rsmith wrote: > Hmm, it looks like we don't have a unique name for a `GlobalDecl` naming the > `CPUOrdinal

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return

r348899 - Replace Const-Member checking with non-recursive version.

Author: erichkeane Date: Tue Dec 11 13:54:52 2018 New Revision: 348899 URL: http://llvm.org/viewvc/llvm-project?rev=348899=rev Log: Replace Const-Member checking with non-recursive version. As reported in PR39946, these two implementations cause stack overflows to occur when a type recursively

[PATCH] D55527: Normalize GlobalDecls when used with CPUDispatch

rsmith marked an inline comment as done. rsmith added a comment. Thanks, this makes a lot of sense to me. Comment at: lib/CodeGen/CodeGenModule.cpp:907 +if (CGM.getTarget().supportsIFunc()) +Out << ".ifunc"; + } else if (CGM.getTarget().supportsIFunc())

[PATCH] D55576: [libcxx] [test] [support] Use socket()+bind() to create unix sockets portably

mgorny created this revision. mgorny added reviewers: EricWF, krytarowski. Herald added subscribers: libcxx-commits, ldionne, emaste. Replace the mknod() call with socket() + bind() for creating unix sockets. The mknod() method is not portable and does not work on NetBSD while binding the socket

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert added a comment. Thanks for the feedback. Once we decided on the style of the annotation, I will implement that and change the tests/documentation accordingly. Comment at: include/clang/Basic/Attr.td:1204 + VariadicUnsignedArgument<"PayloadIndices">];

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 11. jdoerfert marked 11 inline comments as done. jdoerfert added a comment. Fix and improve documentation Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files:

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

joerg added a comment. This header is used on systems without glibc. So please don't argue about behavior based only on that. Granted, most other libc implementation are less annoying when it comes to `free` and `malloc`, but still. CHANGES SINCE LAST ACTION

[PATCH] D55527: Normalize GlobalDecls when used with CPUDispatch

erichkeane updated this revision to Diff 177767. erichkeane marked 8 inline comments as done. erichkeane added a comment. Thanks @aaron.ballman . This should fix all of your complaints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55527/new/ https://reviews.llvm.org/D55527 Files:

[PATCH] D55562: Atomics: support min/max orthogonally

t.p.northover added a comment. > What does it do with floating-point inputs? Same as all the other atomics: run screaming for the hills (or error out, in more reasonable terms). The only way to implement floating atomics in LLVM IR would be with a compare-exchange loop and Clang doesn't expose

[PATCH] D55527: Normalize GlobalDecls when used with CPUDispatch

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:896 let AdditionalMembers = [{ -IdentifierInfo *getCPUName(unsigned Index) const { - return *(cpus_begin() + Index); +// gets the ordinal of the requested CPU name, or 0 if it isn't in

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1204 + VariadicUnsignedArgument<"PayloadIndices">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; jdoerfert wrote: > aaron.ballman

[PATCH] D54921: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

NoQ added a comment. That is, it is modified within the recursive call. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54921/new/ https://reviews.llvm.org/D54921 ___ cfe-commits mailing list

[PATCH] D54921: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

NoQ added a comment. I think that it is modified, at least, when `Memoization[C]` is evaluated. The object needs to be created and put into the map in order to obtain a reference to it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54921/new/

[PATCH] D54921: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

george.karpenkov added a comment. @NoQ thanks, interesting! But I thought the underlying map is not actually modified while the reference is alive? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54921/new/ https://reviews.llvm.org/D54921

[PATCH] D54921: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

NoQ added a comment. Hmm, i think i get it. `Cached` is a reference. Changing `Memoization` will invalidate references because `DenseMap` doesn't provide the respective guarantee. Here's how the code should have looked: ~ 77 Optional Cached = Memoization[C]; ~ 78 if (!Cached) {

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail Eugene.Zelenko wrote: > Naysh wrote: > >

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return MakeCXType(ATT->getModifiedType(), TU);

[PATCH] D55566: [analyzer] LiveVariables: Fix a zombie expression problem, add testing infrastructure.

NoQ updated this revision to Diff 177753. NoQ added a comment. Add documentation, fix checker help message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55566/new/ https://reviews.llvm.org/D55566 Files: docs/analyzer/DebugChecks.rst include/clang/Analysis/Analyses/LiveVariables.h

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF marked an inline comment as done. EricWF added a comment. I think this is good to go. Any more comments? Comment at: include/clang/Sema/Sema.h:2758 bool AllowExplicit = false, +bool IsADLCandidate = false,

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF updated this revision to Diff 177752. EricWF marked 3 inline comments as done. EricWF added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55534/new/ https://reviews.llvm.org/D55534 Files: docs/LibASTMatchersReference.html

[PATCH] D51211: [Sema] Emit -Wformat properly for bitfield promotions.

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I had to revert the commit as the changes caused some test failures.

r348892 - Revert r348889; it fails some tests.

Author: aaronballman Date: Tue Dec 11 11:42:04 2018 New Revision: 348892 URL: http://llvm.org/viewvc/llvm-project?rev=348892=rev Log: Revert r348889; it fails some tests. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/40784 Removed:

[PATCH] D55566: [analyzer] LiveVariables: Fix a zombie expression problem, add testing infrastructure.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, szepet, rnkovacs, Szelethus. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, baloghadamsoftware. For the first time in years, there seems to be a bug in our

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF marked 13 inline comments as done. EricWF added inline comments. Comment at: include/clang/Sema/Sema.h:2758 bool AllowExplicit = false, +bool IsADLCandidate = false,

[PATCH] D55561: Stop stripping comments from AST matcher example code

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r348891. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55561/new/ https://reviews.llvm.org/D55561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r348891 - Stop stripping comments from AST matcher example code.

Author: aaronballman Date: Tue Dec 11 11:30:49 2018 New Revision: 348891 URL: http://llvm.org/viewvc/llvm-project?rev=348891=rev Log: Stop stripping comments from AST matcher example code. The AST matcher documentation dumping script was being a bit over-zealous about stripping comment markers,

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hwright updated this revision to Diff 177749. hwright marked 6 inline comments as done. hwright added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55245/new/ https://reviews.llvm.org/D55245 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hwright added inline comments. Comment at: test/clang-tidy/abseil-duration-subtraction.cpp:12 + // CHECK-FIXES: absl::ToDoubleSeconds(d - absl::Seconds(1)) + x = absl::ToDoubleSeconds(d) - absl::ToDoubleSeconds(d1); + // CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform

Re: r348889 - Emit -Wformat properly for bit-field promotions.

On Tue, Dec 11, 2018 at 2:21 PM Aaron Ballman via cfe-commits wrote: > > Author: aaronballman > Date: Tue Dec 11 11:18:01 2018 > New Revision: 348889 > > URL: http://llvm.org/viewvc/llvm-project?rev=348889=rev > Log: > Emit -Wformat properly for bit-field promotions. > > Only explicitly look

[PATCH] D51211: [Sema] Emit -Wformat properly for bitfield promotions.

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r348889, thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51211/new/ https://reviews.llvm.org/D51211 ___ cfe-commits mailing list

r348889 - Emit -Wformat properly for bit-field promotions.

Author: aaronballman Date: Tue Dec 11 11:18:01 2018 New Revision: 348889 URL: http://llvm.org/viewvc/llvm-project?rev=348889=rev Log: Emit -Wformat properly for bit-field promotions. Only explicitly look through integer and floating-point promotion where the result type is actually a promotion,

[PATCH] D55561: Stop stripping comments from AST matcher example code

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55561/new/ https://reviews.llvm.org/D55561 ___ cfe-commits mailing list

[PATCH] D55488: Add utility for dumping a label with child nodes

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:89 void dumpDecl(const Decl *D); -void dumpStmt(const Stmt *S); +void dumpStmt(const Stmt *S, const std::string = {}); steveire wrote: > aaron.ballman wrote: > > Label > > >

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177746. dmaclach added a comment. Updated to fix Stephane's good catch of Objective C vs Objective-C Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177744. dmaclach marked an inline comment as done. dmaclach added a comment. Full Diffs as requested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst

[PATCH] D55544: Warning: objc-encodings-larger-than=

arphaman added a comment. Thanks for working on this! Could you please post a patch with full context (git diff -U)? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 ___

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

This revision was automatically updated to reflect the committed changes. Closed by commit rL348884: [analyzer][CStringChecker] evaluate explicit_bzero (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r348884 - [analyzer][CStringChecker] evaluate explicit_bzero

Author: devnexen Date: Tue Dec 11 10:57:07 2018 New Revision: 348884 URL: http://llvm.org/viewvc/llvm-project?rev=348884=rev Log: [analyzer][CStringChecker] evaluate explicit_bzero - explicit_bzero has limited scope/usage only for security/crypto purposes but is non-optimisable version of

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

jyknight added a comment. In D54355#1327237 , @craig.topper wrote: > Here's the test case that we have https://reviews.llvm.org/P8123 gcc seems > to accept it at O0 Smaller test case: extern unsigned long long __sdt_unsp; void foo() {

[PATCH] D55562: Atomics: support min/max orthogonally

jfb added a comment. What does it do with floating-point inputs? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55562/new/ https://reviews.llvm.org/D55562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor added a comment. @joerg Yeah, we saw the commit explaining why the original fwd declaration patch was reverted. However, from what I can see, we only have three ways to fix the cyclic dependency between glibc and Clang's internal module: 1. We say that we don't support including

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 

aaron.ballman added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:113 + const bool IsGlobal = MatchedDecl->getStorageClass() != SC_Static; diag(MatchedDecl->getLocation(), Drop the top-level `const` qualifier, please.

[PATCH] D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD

bruno added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54923/new/ https://reviews.llvm.org/D54923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks good, thanks! Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2216 + // In this case we just return. + if (StateZeroSize && !StateNonZeroSize) { +

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

craig.topper added a comment. Here's the test case that we have https://reviews.llvm.org/P8123 gcc seems to accept it at O0 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54355/new/ https://reviews.llvm.org/D54355

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

riccibruno added inline comments. Comment at: lib/AST/Expr.cpp:1267 : Expr(SC, Empty), NumArgs(NumArgs) { + CallExprBits.UsesADL = false; CallExprBits.NumPreArgs = NumPreArgs; riccibruno wrote: > I believe that msan can cope with bit level operations

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh added a comment. Hello! I'm pinging since it's been a week. If someone can commit this patch on my behalf, that would be great. Thank you :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:2758 bool AllowExplicit = false, +bool IsADLCandidate = false, ConversionSequenceList EarlyConversions = None);

Re: r348858 - Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"

On Tue, Dec 11, 2018 at 12:07 PM Stefan Pintilie wrote: > > Hi Aaron, > > Sorry about giving so little info. No worries! > The commit was reverted because it broke two test cases on an internal > buildbot. The reason this was reverted so late was because this failure was > buried underneath

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

riccibruno added inline comments. Comment at: lib/AST/Expr.cpp:1267 : Expr(SC, Empty), NumArgs(NumArgs) { + CallExprBits.UsesADL = false; CallExprBits.NumPreArgs = NumPreArgs; I believe that msan can cope with bit level operations just fine. What I am

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach added a comment. In D55544#1326956 , @theraven wrote: > It would probably be a good idea to have a similar check on properties, as > property encoding strings contain the type encoding (plus extra stuff). Properties are already picked up based

[PATCH] D55562: Atomics: support min/max orthogonally

t.p.northover created this revision. t.p.northover added reviewers: delena, yaxunl. Herald added subscribers: jfb, mcrosier. We seem to have been gradually growing support for atomic min/max operations (exposing longstanding IR atomicrmw instructions). But until now there have been gaps in the

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177732. dmaclach added a comment. Added some spacing around early exit as requested by theraven. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst

[PATCH] D55561: Stop stripping comments from AST matcher example code

aaron.ballman created this revision. aaron.ballman added reviewers: JonasToth, klimek. The AST matcher documentation dumping script was being a bit over-zealous about stripping comment markers, which ended up causing comments in example code to stop being comments. This patch fixes that by only

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

aaron.ballman added inline comments. Comment at: docs/LibASTMatchersReference.html:2579-2581 +y(x); Matches +NS::y(x); Doesn't match +y(42); Doesn't match. EricWF wrote: > aaron.ballman wrote: > > This is not your bug to fix, but it seems the

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF marked 3 inline comments as done. EricWF added a comment. Address more inline comments. Comment at: docs/LibASTMatchersReference.html:2579-2581 +y(x); Matches +NS::y(x); Doesn't match +y(42); Doesn't match. aaron.ballman wrote: > This is not

Re: r348858 - Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"

Hi Aaron, Sorry about giving so little info. The commit was reverted because it broke two test cases on an internal buildbot. The reason this was reverted so late was because this failure was buried underneath another set of failures on that same buildbot which initially hid the problem. I'm

r348866 - Remove CGDebugInfo::getOrCreateFile() and use TheCU->getFile() directly.

Author: adrian Date: Tue Dec 11 08:58:46 2018 New Revision: 348866 URL: http://llvm.org/viewvc/llvm-project?rev=348866=rev Log: Remove CGDebugInfo::getOrCreateFile() and use TheCU->getFile() directly. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h

r348865 - Reuse code from CGDebugInfo::getOrCreateFile() when creating the file

Author: adrian Date: Tue Dec 11 08:58:43 2018 New Revision: 348865 URL: http://llvm.org/viewvc/llvm-project?rev=348865=rev Log: Reuse code from CGDebugInfo::getOrCreateFile() when creating the file for the DICompileUnit. This addresses post-commit feedback for D55085. Without this patch, a main

  1   2   >