r353922 - [test] Fix the test from SVN r353917 when running without lld available

Author: mstorsjo Date: Tue Feb 12 23:50:21 2019 New Revision: 353922 URL: http://llvm.org/viewvc/llvm-project?rev=353922=rev Log: [test] Fix the test from SVN r353917 when running without lld available These tests still relies on the default linker not to be overridden via e.g.

[PATCH] D58107: [MinGW] Add the profiling library when necessary

This revision was automatically updated to reflect the committed changes. Closed by commit rL353917: [MinGW] Add the profiling library when necessary (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r353917 - [MinGW] Add the profiling library when necessary

Author: mstorsjo Date: Tue Feb 12 23:26:54 2019 New Revision: 353917 URL: http://llvm.org/viewvc/llvm-project?rev=353917=rev Log: [MinGW] Add the profiling library when necessary Profiling still doesn't seem to work properly, but this at least hooks up the library and eases completing whatever

[PATCH] D58106: [compiler-rt] [profile] Provide lprofGetHostName for all windows environments

This revision was automatically updated to reflect the committed changes. Closed by commit rL353918: [profile] Provide lprofGetHostName for all windows environments (authored by mstorsjo, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

lebedev.ri added subscribers: cfe-commits, lebedev.ri. lebedev.ri added a comment. cfe-commits (if cfe-dev proper) should probably also be part of this disscussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58157/new/ https://reviews.llvm.org/D58157

[PATCH] D58165: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the _Unwind_Word / _Unwind_SWord definitions

atanasyan created this revision. atanasyan added reviewers: rnk, thakis, craig.topper. Herald added subscribers: jrtc27, arichardson, sdardis. Herald added a project: clang. The rationale of this change is to fix _Unwind_Word / _Unwind_SWord definitions for MIPS N32 ABI. This ABI uses 32-bit

[libunwind] r353915 - [CMake] Don't cache LLVM_MAIN_SRC_DIR

Author: phosek Date: Tue Feb 12 23:09:26 2019 New Revision: 353915 URL: http://llvm.org/viewvc/llvm-project?rev=353915=rev Log: [CMake] Don't cache LLVM_MAIN_SRC_DIR If we're not in a standalone build, this variable should be already set, so there's no need to set it again or to cache it.

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); efriedma wrote: > trong wrote: > > trong wrote: > > > phosek wrote: > > > > trong

[PATCH] D58164: Block+lambda: allow reference capture

jfb created this revision. jfb added reviewers: rjmccall, ahatanak. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Capturing a C++ object by reference wasn't quite working when mixing block and lambda. Repository: rC Clang

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:543 + return CB(InpAST.takeError()); +CB(clangd::getTypeHierarchy(InpAST->AST, Item.range.start, Resolve, +

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek updated this revision to Diff 186583. phosek marked 5 inline comments as done. phosek edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56305/new/ https://reviews.llvm.org/D56305 Files:

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1395425 , @brzycki wrote: > This works for everything I could throw at it. If you think it's reasonable I > can open another ticket and have the code reviewed as a separate fix. Sounds good to me, although I think it'd

[PATCH] D58163: [CUDA][HIP] Use device side kernel and variable names when registering them

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. Herald added subscribers: jdoerfert, tpr. `__hipRegisterFunction` and `__hipRegisterVar` need to accept device side kernel and variable names so that HIP runtime can associate kernel stub functions in host code with kernel

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/Inputs/Headers/stdio.h:1 +#ifndef _STDIO_H_ +#define _STDIO_H_ stephanemoore wrote: > I noticed that some of the other example

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:543 + return CB(InpAST.takeError()); +CB(clangd::getTypeHierarchy(InpAST->AST, Item.range.start, Resolve, +Direction)); nridge wrote:

[PATCH] D58161: Print a note to the called macro when diagnosing err_embedded_directive

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:497 + Args = ReadMacroCallArgumentList(Identifier, MI, ExpansionEnd); rnk wrote: > Can this re-enter, something like: >

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge marked an inline comment as done. nridge added inline comments. Herald added a subscriber: jdoerfert. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:543 + return CB(InpAST.takeError()); +CB(clangd::getTypeHierarchy(InpAST->AST, Item.range.start, Resolve, +

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

rsmith updated this revision to Diff 186578. rsmith added a comment. Combine WithinStmtExpr flag with AllowedStmtKinds into a more general statement context. In doing so, fix some bugs where the OpenMP context was not being propagated properly through labels and expression-statements starting

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 186577. jyu2 added a comment. Cleanup CFG code, remove obj-lifetime code when build CFE for asm-goto. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h

[PATCH] D58161: Print a note to the called macro when diagnosing err_embedded_directive

rnk added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:497 + Args = ReadMacroCallArgumentList(Identifier, MI, ExpansionEnd); Can this re-enter, something like: MACRO1(MACRO2(a1), MACRO3( #include "asdf" ) In this case, I think

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13477 +if (!SegArg->isIntegerConstantExpr(SegConst, getContext())) + llvm_unreachable("Constant arg isn't actually

[PATCH] D54978: Move the SMT API to LLVM

thakis added a comment. In D54978#1395136 , @brzycki wrote: > The following patch: > > diff --git a/llvm/cmake/modules/CrossCompile.cmake > b/llvm/cmake/modules/CrossCompile.cmake > index bc3b210f018..0c30b88f80f 100644 > ---

[PATCH] D58161: Print a note to the called macro when diagnosing err_embedded_directive

thakis created this revision. thakis added a reviewer: rnk. Fixes PR40713, see there for the motivation for this. https://reviews.llvm.org/D58161 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPDirectives.cpp

[PATCH] D57080: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore updated this revision to Diff 186572. stephanemoore added a comment. Herald added a project: clang. Migrated patch to LLVM monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57080/new/ https://reviews.llvm.org/D57080 Files:

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright updated this revision to Diff 186569. hwright marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58137/new/ https://reviews.llvm.org/D58137 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-objc-function-naming.m:10 +// function would be declared in a system header. +int printf(const char *, ...); // NOLINT(google-objc-function-naming) + aaron.ballman wrote:

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore updated this revision to Diff 186567. stephanemoore marked 2 inline comments as done. stephanemoore added a comment. Add a comment to the new stdio.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58095/new/

[PATCH] D58160: Fix runtime problem from //bugs.llvm.org/show_bug.cgi?id=40323

jyu2 created this revision. jyu2 added reviewers: cfe-commits, rnk, majnemer, erichkeane. Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM. A MS only run time problem, because the init function for template static member is not getting called when the template

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore updated this revision to Diff 186566. stephanemoore added a comment. Create a new header stdio.h under //test/clang-tidy/Inputs/Headers/ to contain declaration of `printf` and import the new header to `google-objc-function-naming.m`. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for fixing this regression (sorry, I caused it). Doesn't regress the tests I added. You'll probably want to request to Hans that this gets picked up for the 8.0

[PATCH] D58153: [Driver] Default all Android ARM targets to NEON.

efriedma added a comment. The official documentation still says "Your app must perform runtime detection to confirm that NEON-capable machine code can be run on the target device" (https://developer.android.com/ndk/guides/cpu-arm-neon#runtime_detection). Is that wrong? Repository: rG LLVM

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

comex added a comment. Oh, forgot to mention in the initial submission: I don't have commit access so I'll need someone else to commit this. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58089/new/ https://reviews.llvm.org/D58089

[PATCH] D58122: Restore Check for Unreachable Exit Block in -Winfinite-recursion

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58122/new/ https://reviews.llvm.org/D58122 ___ cfe-commits

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. In D54978#1395561 , @brzycki wrote: > In D54978#1395476 , @mikhail.ramalho > wrote: > > > I'm wondering if we can remove the binary requirement all together: is it > > possible to

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. In D54978#1395476 , @mikhail.ramalho wrote: > I'm wondering if we can remove the binary requirement all together: is it > possible to run a small program that would return EXIT_SUCCESS if the library > is the correct version?

[PATCH] D58154: Add support for -fpermissive.

rsmith created this revision. rsmith added a reviewer: jyknight. Herald added a subscriber: jdoerfert. Herald added a project: clang. The intent is to provide similar functionality to GCC's -fpermissive. For Clang's approach to diagnostics, this means that we remap all extension diagnostics to no

[PATCH] D58153: [Driver] Default all Android ARM targets to NEON.

danalbert created this revision. danalbert added reviewers: srhines, pirama, kristof.beyls. danalbert added a project: clang. Herald added a subscriber: javed.absar. There are an insignificant number of ARM Android devices that don't support NEON. Default to using NEON since that will improve

[PATCH] D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, arphaman, erichkeane. Herald added subscribers: jdoerfert, dexonsmith, jkorous. Herald added a project: clang. We ran into some source breaking changes to do with the attribute reordering changes that recently

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

efriedma added a comment. This looks essentially fine, but I'd like to see some basic test coverage for the changes to warnings and constant evaluation. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. Reviving this now that I have some cycles to work on this. So I tried running this on csa-testbench projects but I didn't have much success. I always run into a bunch of build/env related errors: 15:05:20 [libcxx] Checking out project... [ERROR] Unknown option:

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 186549. Herald added subscribers: jdoerfert, baloghadamsoftware. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. Looks like my last email got lost: I'm wondering if we can remove the binary requirement all together: is it possible to run a small program that would return EXIT_SUCCESS if the library is the correct version? Something like: #include int main() {

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. I found a `CHECK_CXX_SOURCE_COMPILES`, which seems to be used in a number of places in LLVM. I'll give it a try. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

rnk added a comment. I reverted this in rC353893 because it was still causing test failures. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977

r353893 - Revert r353880 "[HIP] Handle compile -m options and propagate into LLC"

Author: rnk Date: Tue Feb 12 14:51:54 2019 New Revision: 353893 URL: http://llvm.org/viewvc/llvm-project?rev=353893=rev Log: Revert r353880 "[HIP] Handle compile -m options and propagate into LLC" This was still causing test failures in the clang test suite. Removed:

Re: [PATCH] D54978: Move the SMT API to LLVM

Hi, Thank you for the discussion, I was finally able to reproduce the error. > Hello @ddcc. > I agree with your reasoning here and developed a patch based on this line > of thought: > > diff --git a/llvm/cmake/modules/FindZ3.cmake > b/llvm/cmake/modules/FindZ3.cmake > index

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

arsenm added a comment. I think this breaks the attributes already listed in the functions on the IR since -mattr overrides those. I think we need to stop using subtarget features to communicate this Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/

r353890 - docs: Update the ShadowCallStack documentation.

Author: pcc Date: Tue Feb 12 14:45:23 2019 New Revision: 353890 URL: http://llvm.org/viewvc/llvm-project?rev=353890=rev Log: docs: Update the ShadowCallStack documentation. - Remove most of the discussion of the x86_64 implementation; link to an older version of the documentation for details

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); trong wrote: > trong wrote: > > phosek wrote: > > > trong wrote: > > > > What

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne created this revision. ldionne added reviewers: jfb, eli.friedman. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Previously, those #defines were only provided in C or when GNU extensions were enabled. We need those #defines in C++11 and above,

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. In D54978#1395288 , @ddcc wrote: > In D54978#1395268 , @brzycki wrote: > > > I think I found why others are struggling to recreate this issue. I did not > > have the package `z3/bionic`

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

craig.topper added a comment. Thanks for the fix @rnk, I've added some MSVC command lines to some of the other test files too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57961/new/ https://reviews.llvm.org/D57961

r353887 - [X86] Follow up to r353878, add MSVC compatibility command lines to other intrinsic tests that uses packed structs to control alignment.

Author: ctopper Date: Tue Feb 12 14:12:19 2019 New Revision: 353887 URL: http://llvm.org/viewvc/llvm-project?rev=353887=rev Log: [X86] Follow up to r353878, add MSVC compatibility command lines to other intrinsic tests that uses packed structs to control alignment. r353878 fixed a bug in

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai added a comment. I've checked and seems like other places where we `EmitAnnotationCall` should be safe. We do that for globals, function parameters, fields (`FieldDecl`) and early return isn't applicable in those cases. We can do that for any expressions with `__builtin_annotation` but

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

rjmccall resigned from this revision. rjmccall added a comment. Herald added a subscriber: jdoerfert. Sorry, this is deep in the loop analysis code, and I don't remember anything about this stuff, so I'm not sure I'm going to be a useful reviewer. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai created this revision. vsapsai added a reviewer: rjmccall. Herald added subscribers: dexonsmith, jkorous, aprantl. When we have an annotated local variable after a function returns, we generate IR that fails verification with the error > Instruction referencing instruction not embedded

[PATCH] D58060: Fix diagnostic for addr spaces in static_cast

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1830 + "binding value %diff{of type $ to reference to type $|to reference}0,1 " + "changes address space">; def err_reference_bind_failed : Error< We say that references

[PATCH] D58057: Allow bundle size to be 0 in clang-offload-bundler

rjmccall added a comment. I really don't understand this well enough to review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58057/new/ https://reviews.llvm.org/D58057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r353885 - [HIP] Fix hip-toolchain-rdc tests

Author: aaronenyeshi Date: Tue Feb 12 14:01:19 2019 New Revision: 353885 URL: http://llvm.org/viewvc/llvm-project?rev=353885=rev Log: [HIP] Fix hip-toolchain-rdc tests Since we removed changed the way HIP Toolchain will propagate -m options into LLC, we need to remove from these older tests.

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57965: Clean up ObjCPropertyDecl printing

benlangmuir added a comment. > @property(attr, attr2) instead of @property ( attr,attr2 ). The style I see most often is `@property (attr, attr2)`, which is in between those two. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/

[PATCH] D57965: Clean up ObjCPropertyDecl printing

benlangmuir added subscribers: akyrtzi, benlangmuir. benlangmuir added a comment. @arphaman @akyrtzi could you take a look at this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965

r353882 - Make ModuleDependencyCollector's method virtual (NFC)

Author: jdevlieghere Date: Tue Feb 12 13:45:14 2019 New Revision: 353882 URL: http://llvm.org/viewvc/llvm-project?rev=353882=rev Log: Make ModuleDependencyCollector's method virtual (NFC) For reproducers in LLDB we want to hook up into the existing clang infrastructure. To make that happen we

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL353882: Make ModuleDependencyCollectors method virtual (NFC) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, rsmith, nickdesaulniers. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. DiagnoseFloatingImpCast expects an integer type, but the changes introduced in D50467

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/ https://reviews.llvm.org/D58072 ___ cfe-commits

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57948/new/ https://reviews.llvm.org/D57948

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

This revision was automatically updated to reflect the committed changes. Closed by commit rC353880: [HIP] Handle compile -m options and propagate into LLC (authored by aaronenyeshi, committed by ). Changed prior to commit: https://reviews.llvm.org/D57977?vs=186528=186534#toc Repository: rC

r353880 - [HIP] Handle compile -m options and propagate into LLC

Author: aaronenyeshi Date: Tue Feb 12 13:21:06 2019 New Revision: 353880 URL: http://llvm.org/viewvc/llvm-project?rev=353880=rev Log: [HIP] Handle compile -m options and propagate into LLC Allow the compile options for -m such as -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc,

r353878 - [X86] Use __m128_u for _mm_loadu_ps after r353555

Author: rnk Date: Tue Feb 12 13:04:21 2019 New Revision: 353878 URL: http://llvm.org/viewvc/llvm-project?rev=353878=rev Log: [X86] Use __m128_u for _mm_loadu_ps after r353555 Add secondary triple to existing SSE test for it. I audited other uses of __attribute__((__packed__)) in the intrinsic

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

JDevlieghere added a comment. Alright, I'll split this up in two patches Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/ https://reviews.llvm.org/D58072 ___ cfe-commits mailing list

[PATCH] D56927: Disable PIC/PIE for MSP430 target

This revision was automatically updated to reflect the committed changes. Closed by commit rL353877: Disable PIC/PIE for MSP430 target (authored by asl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r353877 - Disable PIC/PIE for MSP430 target

Author: asl Date: Tue Feb 12 12:46:00 2019 New Revision: 353877 URL: http://llvm.org/viewvc/llvm-project?rev=353877=rev Log: Disable PIC/PIE for MSP430 target Relocatable code generation is meaningless on MSP430, as the platform is too small to use shared libraries. Patch by Dmitry Mikushev!

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM. Please make sure to update your commit message as your patch processes all m options now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 added a comment. Yes, but it will need this PR: https://github.com/ROCm-Developer-Tools/HIP/pull/910 So that the default is set. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Is it still code object v2 by default? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1395268 , @brzycki wrote: > I think I found why others are struggling to recreate this issue. I did not > have the package `z3/bionic` installed. This provides the `/usr/bin/z3` > executable which

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 updated this revision to Diff 186528. ashi1 added a comment. I've added a lit test to check for options such as -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/

r353875 - [NFC] typo

Author: jfb Date: Tue Feb 12 12:19:16 2019 New Revision: 353875 URL: http://llvm.org/viewvc/llvm-project?rev=353875=rev Log: [NFC] typo Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL:

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. I think I found why others are struggling to recreate this issue. I did not have the package `z3/bionic` installed. This provides the `/usr/bin/z3` executable which `llvm/cmake/modules/FindZ3.cmake` relies upon to determine the correct `Z3_VERSION_STRING`. If I

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk added a comment. I audited all the intrin header uses of __packed__, and I think this was the only one that was missing, so I'll try to fix forward. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57961/new/ https://reviews.llvm.org/D57961

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk added a comment. Herald added a subscriber: jdoerfert. Hm, looks like this broke a bunch of code in chromium: bad build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTWin%28dbg%29/2342 good build:

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:91 + + Finds and fixes `absl::Time` subtraction expressions to do subtraction + in the Time domain instead of the numeric domain. Please use two not one ` for language constructs.

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

bruno added a comment. I missed that the `DependencyCollector` already marks them virtual, you are just making it obvious here. I think you can omit the ones that are already virtual and only add to the ones that are on the intend of this patch. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58062: Support framework import/include auto-completion

dgoldman updated this revision to Diff 186524. dgoldman marked 9 inline comments as done. dgoldman added a comment. Herald added a subscriber: jdoerfert. - Misc fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

kkwli0 added inline comments. Comment at: include/clang/AST/OpenMPClause.h:4077 + /// C++ nested name specifier for the assoicated user-defined mapper. + NestedNameSpecifierLoc MapperQualifierLoc; assoicated -> associated Comment at:

[PATCH] D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it.

vsapsai updated this revision to Diff 186522. vsapsai added a comment. Herald added a subscriber: jdoerfert. - Use `%select` per Steven's recommendation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57991/new/ https://reviews.llvm.org/D57991 Files:

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Can you add some tests? Preferably with -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 updated this revision to Diff 186519. ashi1 added a comment. Herald added a subscriber: jdoerfert. Changed patch to us handleTargetFeatures, to consume all -m options passed into clang. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1074 + if (NameKind == LookupOMPMapperName) { +// Skip out-of-scope declarations. lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > > > lildmh wrote: > > > > >

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1074 + if (NameKind == LookupOMPMapperName) { +// Skip out-of-scope declarations. ABataev wrote: > lildmh wrote: > > ABataev wrote: > > > lildmh

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

zinovy.nis updated this revision to Diff 186514. zinovy.nis added a comment. `-j` and `-export-fixes` were made mutually exclusive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 Files: clang-tidy/tool/clang-tidy-diff.py Index:

[PATCH] D58106: [compiler-rt] [profile] Provide lprofGetHostName for all windows environments

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58106/new/ https://reviews.llvm.org/D58106 ___

[PATCH] D58107: [MinGW] Add the profiling library when necessary

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58107/new/ https://reviews.llvm.org/D58107 ___ cfe-commits mailing

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL353870: [AMDGPU] Require at least protected visibility for certain symbols (authored by scott.linder, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

Re: [PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

On Tue, 12 Feb 2019, 05:28 Aaron Ballman via Phabricator via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > aaron.ballman added a comment. > > Considering that this has been fertile ground for buggy edge cases, should > we revert my original changes from the 8.0 branch to give this more time

r353870 - [AMDGPU] Require at least protected visibility for certain symbols

Author: scott.linder Date: Tue Feb 12 10:30:38 2019 New Revision: 353870 URL: http://llvm.org/viewvc/llvm-project?rev=353870=rev Log: [AMDGPU] Require at least protected visibility for certain symbols This allows the global visibility controls to be restrictive while still populating the dynamic

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. The following patch: diff --git a/llvm/cmake/modules/CrossCompile.cmake b/llvm/cmake/modules/CrossCompile.cmake index bc3b210f018..0c30b88f80f 100644 --- a/llvm/cmake/modules/CrossCompile.cmake +++ b/llvm/cmake/modules/CrossCompile.cmake @@ -53,6 +53,7 @@

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright created this revision. hwright added reviewers: ioeric, hokein, JonasToth, aaron.ballman. hwright added a project: clang-tools-extra. Herald added subscribers: cfe-commits, jdoerfert, xazax.hun, mgorny. Herald added a project: clang. Repository: rCTE Clang Tools Extra

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1074 + if (NameKind == LookupOMPMapperName) { +// Skip out-of-scope declarations. lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > > > lildmh wrote: > > > > >

  1   2   >