[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added a comment. I think this is in good shape. Comment at: lib/Sema/JumpDiagnostics.cpp:675 + // asm-goto. + //if (!IsAsmGoto && IndirectJumpTargets.empty()) { + if (JumpTargets.empty()) { Commented-out code? We probably don't need a diagnostic

[PATCH] D58134: [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop

This revision was automatically updated to reflect the committed changes. Closed by commit rL354102: [Analysis] -Wunreachable-code shouldnt fire on the increment of a foreach loop (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r354102 - [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop

Author: sammccall Date: Thu Feb 14 23:16:11 2019 New Revision: 354102 URL: http://llvm.org/viewvc/llvm-project?rev=354102=rev Log: [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop Summary: The idea is that the code here isn't written, so doesn't indicate a bug.

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 186963. steleman added a comment. Addressed comments from Renato: - Diagnostic for unsupported argument to -fveclib= is now: error: unsupported option '' for target '' - Added check and diagnostic for SVML on non-Intel ISA's. Repository: rC Clang

[PATCH] D58164: Block+lambda: allow reference capture

ahatanak requested changes to this revision. ahatanak added a comment. This revision now requires changes to proceed. Sorry, I didn't mean to accept this yet. I think this is something that is better fixed in Sema. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58164: Block+lambda: allow reference capture

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. Sorry, I was misunderstanding the problem. I was trying to understand why the crash goes away if I change the generic lambda to a non-generic one. What I found was that, when the lambda

[PATCH] D58269: [clang] Add build and install targets for clang libraries

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58269/new/ https://reviews.llvm.org/D58269

[PATCH] D58268: [clang] Create install targets for non-shared libraries

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58268/new/ https://reviews.llvm.org/D58268

Re: r354091 - Fix implementation of [temp.local]p4.

I reverted this temporarily in r354097. > On Feb 14, 2019, at 6:35 PM, Francis Visoiu Mistrih > wrote: > > Hi Richard, > > This seems to now emit an error when building the sanitizer tests: > http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/53965/consoleFull > >

r354097 - Revert "Fix implementation of [temp.local]p4."

Author: thegameg Date: Thu Feb 14 19:06:15 2019 New Revision: 354097 URL: http://llvm.org/viewvc/llvm-project?rev=354097=rev Log: Revert "Fix implementation of [temp.local]p4." This reverts commit 40bd10b770813bd1471d46f514545437516aa4ba. This seems to now emit an error when building the

[PATCH] D58269: [clang] Add build and install targets for clang libraries

smeenai added a comment. A couple of things I noticed while writing this patch: - clang guards its install target creation with `CMAKE_CONFIGURATION_TYPES`, whereas LLVM uses `LLVM_ENABLE_IDE`. Should clang be switched over to be consistent with LLVM? - I realize we create the

[PATCH] D58269: [clang] Add build and install targets for clang libraries

smeenai updated this revision to Diff 186957. smeenai added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58269/new/ https://reviews.llvm.org/D58269 Files: clang/CMakeLists.txt clang/cmake/modules/AddClang.cmake

[PATCH] D58269: [clang] Add build and install targets for clang libraries

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. This is modeled after the existing llvm-libraries target. It's a convenient way to include all clang libraries in a distribution. This differs slightly from

[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58254/new/ https://reviews.llvm.org/D58254 ___ cfe-commits mailing list

[PATCH] D58268: [clang] Create install targets for non-shared libraries

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. I don't see a reason for these to not have install targets created, which in turn allows them to be bundled in distributions. This doesn't affect the "install"

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58218/new/ https://reviews.llvm.org/D58218 ___

Re: r354091 - Fix implementation of [temp.local]p4.

Hi Richard, This seems to now emit an error when building the sanitizer tests: http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/53965/consoleFull . I managed to reproduce it locally and when reverting

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

jfb added a comment. In D58218#1398251 , @rjmccall wrote: > In D58218#1398124 , @jfb wrote: > > > In D58218#1398096 , @rjmccall > > wrote: > > > > > Well, you can always

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

jfb updated this revision to Diff 186950. jfb added a comment. - Fix polarity Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58218/new/ https://reviews.llvm.org/D58218 Files: lib/CodeGen/CGDecl.cpp test/CodeGenCXX/trivial-auto-var-init.cpp Index:

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 186947. nridge added a comment. Fix a test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

ab added inline comments. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. Comment at: cfe/trunk/test/CodeGen/aarch64-neon-fp16fml.c:12 + +float32x2_t test_vfmlal_low_u32(float32x2_t a, float16x4_t b, float16x4_t c) { +// CHECK-LABEL: define <2 x float>

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354090: PR40642: Fix determination of whether the final statement of a statement (authored by rsmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D57984?vs=186731=186945#toc

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/unittests/clangd/XRefsTests.cpp:1604 + dyn_cast((AST, "Parent"))->getTemplatedDecl(); + // TODO: This fails because findDecl() doesn't support template-ids + // const

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 186944. nridge added a comment. - Rework tests to test the lower-level functions like typeAncestors() - Remove support for typeHierarchy/resolve Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/

r354091 - Fix implementation of [temp.local]p4.

Author: rsmith Date: Thu Feb 14 16:29:04 2019 New Revision: 354091 URL: http://llvm.org/viewvc/llvm-project?rev=354091=rev Log: Fix implementation of [temp.local]p4. When a template-name is looked up, we need to give injected-class-name declarations of class templates special treatment, as they

r354090 - PR40642: Fix determination of whether the final statement of a statement

Author: rsmith Date: Thu Feb 14 16:27:53 2019 New Revision: 354090 URL: http://llvm.org/viewvc/llvm-project?rev=354090=rev Log: PR40642: Fix determination of whether the final statement of a statement expression is a discarded-value expression. Summary: We used to get this wrong in three ways:

Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

I don't think Hans ended up getting added to the recipients? (Unless Outlook is being silly or it was a BCC, in which case I apologize for the spam.) On 2/14/19, 3:16 PM, "cfe-commits on behalf of Erik Pilkington via cfe-commits" wrote: Hans, can you merge this diagnostic regression fix

r354089 - Fixed failure on Darwin due to r354064

Author: apazos Date: Thu Feb 14 16:19:45 2019 New Revision: 354089 URL: http://llvm.org/viewvc/llvm-project?rev=354089=rev Log: Fixed failure on Darwin due to r354064 Summary: instrprof-darwin-exports.c test fails on Darwin due to r354064. Updated clang list of exported symbols to fix the

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM too, I agree this should be NFC with the parent commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57075/new/ https://reviews.llvm.org/D57075

[PATCH] D57270: [ObjC] Fix non-canonical types preventing type arguments substitution.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57270/new/ https://reviews.llvm.org/D57270 ___ cfe-commits

[PATCH] D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354084: [Driver][Darwin] Emit an error when using -pg on OS without support for it. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r354084 - [Driver][Darwin] Emit an error when using -pg on OS without support for it.

Author: vsapsai Date: Thu Feb 14 15:50:44 2019 New Revision: 354084 URL: http://llvm.org/viewvc/llvm-project?rev=354084=rev Log: [Driver][Darwin] Emit an error when using -pg on OS without support for it. Instead of letting a program fail at runtime, emit an error during compilation.

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. Here's my proposed logic as actual CMake code. @mikhail.ramalho if you can get your code to emit the version string I made a `TODO` placeholder for it in the 3rd block below. diff --git a/llvm/cmake/modules/FindZ3.cmake b/llvm/cmake/modules/FindZ3.cmake index

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. In D54978#1397354 , @ddcc wrote: > In D54978#1397316 , @mikhail.ramalho > wrote: > > > I just sent the first prototype of the solution. All the magic happens > > inside the

Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

Hans, can you merge this diagnostic regression fix into LLVM 8? Thanks! > On Feb 14, 2019, at 2:48 PM, Erik Pilkington via cfe-commits > wrote: > > Author: epilk > Date: Thu Feb 14 14:48:01 2019 > New Revision: 354074 > > URL: http://llvm.org/viewvc/llvm-project?rev=354074=rev > Log: >

r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Author: jkorous Date: Thu Feb 14 15:02:35 2019 New Revision: 354075 URL: http://llvm.org/viewvc/llvm-project?rev=354075=rev Log: [clang][FileManager] fillRealPathName even if we aren't opening the file The pathname wasn't previously filled when the getFile() method was called with openFile =

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

This revision was automatically updated to reflect the committed changes. jkorous marked an inline comment as done. Closed by commit rC354075: [clang][FileManager] fillRealPathName even if we arent opening the file (authored by jkorous, committed by ). Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354074: [Sema] Fix-up a -Wfloat-conversion diagnostic (authored by epilk, committed by ). Herald added a project: LLVM.

r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

Author: epilk Date: Thu Feb 14 14:48:01 2019 New Revision: 354074 URL: http://llvm.org/viewvc/llvm-project?rev=354074=rev Log: [Sema] Fix-up a -Wfloat-conversion diagnostic We were warning on valid ObjC property reference exprs, and passing in the wrong arguments to DiagnoseFloatingImpCast

[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10634 + // warning. + else if (ResultBT->isFloatingPoint() && ResultBT->getKind() < RBT->getKind() && + // We don't want to warn for

[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, nickdesaulniers. Herald added subscribers: jdoerfert, dexonsmith, jkorous. ...instead of just comparing rank. Also, fix a bad warning about `_Float16`, since its declared out of order in BuiltinTypes.def, meaning

[clang-tools-extra] r354069 - [clang-tidy] Mention language version in test explicitly.

Author: vsapsai Date: Thu Feb 14 14:37:30 2019 New Revision: 354069 URL: http://llvm.org/viewvc/llvm-project?rev=354069=rev Log: [clang-tidy] Mention language version in test explicitly. "modernize-use-using" check is applicable only to C++11 and later. Spell it out to avoid relying on default

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. But what we've just been talking about is not a validity rule, it's an overload-resolution rule. It's not *invalid* to use a device function as a template argument to a host function template (or to a class template, which of course is neither host nor device). All

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh updated this revision to Diff 186912. lildmh added a comment. Introduce a structure `OMPMappableExprListSizeTy` within `OMPMappableExprListClause` to aggregate all 4 sizes needed by such clause, and thus reduce the number of parameters when creating a map clause. This can also be used

r354063 - Further relax restriction in tests to include where "-E" and "-S" must appear.

Author: dyung Date: Thu Feb 14 13:37:19 2019 New Revision: 354063 URL: http://llvm.org/viewvc/llvm-project?rev=354063=rev Log: Further relax restriction in tests to include where "-E" and "-S" must appear. Also updated a few instances of "-emit-llvm-bc" and "-emit-obj" that were missed in the

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58213/new/ https://reviews.llvm.org/D58213 ___ cfe-commits mailing list

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous marked 4 inline comments as done. jkorous added a comment. Updated the patch. Comment at: unittests/Basic/FileManagerTest.cpp:349 +// rdar://problem/47536127 +TEST_F(FileManagerTest, getFileDontOpenRealPath) { arphaman wrote: > jkorous wrote: > >

[PATCH] D58062: Support framework import/include auto-completion

dgoldman marked 3 inline comments as done. dgoldman added a comment. added test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 ___ cfe-commits mailing list

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous updated this revision to Diff 186906. jkorous added a comment. - comments - explicit openFile = false in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58213/new/ https://reviews.llvm.org/D58213 Files: lib/Basic/FileManager.cpp unittests/Basic/FileManagerTest.cpp

[PATCH] D58062: Support framework import/include auto-completion

dgoldman updated this revision to Diff 186904. dgoldman added a comment. - Add test and fix subfolder bug Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58062/new/ https://reviews.llvm.org/D58062 Files: lib/Sema/SemaCodeComplete.cpp

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1398329 , @rjmccall wrote: > In D56411#1398328 , @rjmccall wrote: > > > In D56411#1398291 , @tra wrote: > > > > > >> That said, does CUDA

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

arphaman added inline comments. Comment at: unittests/Basic/FileManagerTest.cpp:349 +// rdar://problem/47536127 +TEST_F(FileManagerTest, getFileDontOpenRealPath) { jkorous wrote: > arphaman wrote: > > Please leave this comment out > Sure, no problem. > > Just

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. I guess I hadn't sourced the CodeChecker venv correctly. Now that I did source it and started the CodeChecker server I seem to be progressing. The error I get now is compiler related (which I will dig into). 12:51:35 [bitcoin] Checking out project... [ERROR]

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

arphaman added inline comments. Comment at: lib/Basic/FileManager.cpp:271 + } else if (!openFile) { +// Since we didn't return early after getStatValue() call the file exists. +fillRealPathName(, InterndFileName); jkorous wrote: > arphaman wrote: > > I

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous marked an inline comment as done. jkorous added inline comments. Comment at: unittests/Basic/FileManagerTest.cpp:349 +// rdar://problem/47536127 +TEST_F(FileManagerTest, getFileDontOpenRealPath) { arphaman wrote: > Please leave this comment out Sure,

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1397721 , @xazax.hun wrote: > In D50488#1395483 , @mgrang wrote: > > > Reviving this now that I have some cycles to work on this. > > > > So I tried running this on csa-testbench

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

jkorous marked 2 inline comments as done. jkorous added a comment. Thanks for taking a look! Comment at: lib/Basic/FileManager.cpp:214 return nullptr; } If we can't stat the file we return here. Comment at:

[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

arphaman added inline comments. Comment at: lib/Basic/FileManager.cpp:271 + } else if (!openFile) { +// Since we didn't return early after getStatValue() call the file exists. +fillRealPathName(, InterndFileName); I don't really understand what this

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

This revision was automatically updated to reflect the committed changes. Closed by commit rL354057: Stop enabling clang-tools-extra automatically when clang is in… (authored by nico, committed by ). Herald added a project: LLVM. Changed prior to commit:

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

This revision was automatically updated to reflect the committed changes. Closed by commit rC354056: [CodeGenObjC] Emit [[X alloc] init] as objc_alloc_init(X) when available (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D57936?vs=186784=186894#toc

r354056 - [CodeGenObjC] Emit [[X alloc] init] as objc_alloc_init(X) when available

Author: epilk Date: Thu Feb 14 11:58:37 2019 New Revision: 354056 URL: http://llvm.org/viewvc/llvm-project?rev=354056=rev Log: [CodeGenObjC] Emit [[X alloc] init] as objc_alloc_init(X) when available This provides a code size win on the caller side, since the init message send is done in the

[PATCH] D57986: [ProfileData] Remove non-determinism: Change DenseMap to MapVector

dblaikie added a comment. In D57986#1398271 , @vsk wrote: > I think this could roughly double the memory utilization of the writer, which > might be problematic because the number of records to write can be high. > (@dblaikie did some work on reducing

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17444/new/ https://reviews.llvm.org/D17444 ___ cfe-commits mailing list

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/Parse/ParseStmt.cpp:1090-1091 +R = handleExprStmt(Res, SubStmtCtx); +if (R.isUsable()) + R =

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1398291 , @tra wrote: > >> That said, does CUDA have a general rule resolving `__host__` vs. > >> `__device__` overloads based on context? And does it allow overloading > >> based solely on `__host__` vs. `__device__`?

r354053 - [X86] Add clang support for X86 flag output parameters.

Author: niravd Date: Thu Feb 14 11:27:25 2019 New Revision: 354053 URL: http://llvm.org/viewvc/llvm-project?rev=354053=rev Log: [X86] Add clang support for X86 flag output parameters. Summary: Add frontend support and expected flags for X86 inline assembly flag parameters. Reviewers:

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. In D56411#1398328 , @rjmccall wrote: > In D56411#1398291 , @tra wrote: > > > >> That said, does CUDA have a general rule resolving `__host__` vs. > > >> `__device__` overloads based on

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. In D56411#1398291 , @tra wrote: > >> That said, does CUDA have a general rule resolving `__host__` vs. > >> `__device__` overloads based on context? And does it allow overloading > >> based solely on `__host__` vs.

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: test/SemaOpenCL/address-spaces.cl:89 + __local int * __global * __private * lll; + lll = gg; // expected-warning {{incompatible pointer types assigning to '__local int *__global **' from

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

tra added a comment. >> That said, does CUDA have a general rule resolving `__host__` vs. >> `__device__` overloads based on context? And does it allow overloading >> based solely on `__host__` vs. `__device__`? NVCC does not. Clang does. See https://goo.gl/EXnymm for the details. AFAICT,

[PATCH] D57986: [ProfileData] Remove non-determinism: Change DenseMap to MapVector

vsk added subscribers: dblaikie, vsk. vsk added a comment. I think this could roughly double the memory utilization of the writer, which might be problematic because the number of records to write can be high. (@dblaikie did some work on reducing memory usage in this area, he might have hard

[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

nickdesaulniers added a comment. > Fix this by just directly calling DiagnoseImpCast, since we don't really need > anything DiagnoseFloatingImpCast does anyways. Good catch; thanks for fixing and improving the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58145/new/

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

rjmccall added a comment. In D58218#1398124 , @jfb wrote: > In D58218#1398096 , @rjmccall wrote: > > > Well, you can always make a variable with a more directly-applicable name > > than `capturedByInit` and update

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:4193 ArrayRef MapModifiersLoc, +NestedNameSpecifierLoc MapperQualifierLoc, +DeclarationNameInfo MapperIdInfo,

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh marked an inline comment as done. lildmh added a comment. Sure I'll add a codegen test with mapper. Thanks! Comment at: include/clang/AST/OpenMPClause.h:4193 ArrayRef MapModifiersLoc, +NestedNameSpecifierLoc

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added a comment. In D58074#1398187 , @lildmh wrote: > Hi Alexey, > > Again thanks for your review! The codegen completely ignores any mapper > related info for now, so it should not crash map clause codegen. It also > passed the regression test,

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

ABataev created this revision. ABataev added a reviewer: rjmccall. Herald added subscribers: jdoerfert, guansong. Herald added a project: clang. Added the ability to emit target-specific builtin assembler error messages only in case if the function is really is going to be emitted for the device.

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

lildmh marked an inline comment as done. lildmh added a comment. Hi Alexey, Again thanks for your review! The codegen completely ignores any mapper related info for now, so it should not crash map clause codegen. It also passed the regression test, so map clause codegen should be fine.

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

ABataev added a comment. Check, please, that adding this to the map clause does not crash the codegen. Would be good to ignore this construct in codegen for now, if it is used in the code. Comment at: include/clang/AST/OpenMPClause.h:4193 ArrayRef

[PATCH] D57986: [ProfileData] Remove non-determinism: Change DenseMap to MapVector

mgrang added a comment. Ping for reviews please. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57986/new/ https://reviews.llvm.org/D57986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1398103 , @rjmccall wrote: > In D56411#1398097 , @yaxunl wrote: > > > In D56411#1365878 , @yaxunl wrote: > > > > > In D56411#1365745

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

jfb updated this revision to Diff 186853. jfb added a comment. - Update with John's suggestion. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58218/new/ https://reviews.llvm.org/D58218 Files: lib/CodeGen/CGDecl.cpp test/CodeGenCXX/trivial-auto-var-init.cpp

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

jfb added a comment. In D58218#1398096 , @rjmccall wrote: > Well, you can always make a variable with a more directly-applicable name > than `capturedByInit` and update it as appropriate, like `locIsByrefHeader`. Sounds good. I made it `const` too, to

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. In D56411#1398097 , @yaxunl wrote: > In D56411#1365878 , @yaxunl wrote: > > > In D56411#1365745 , @rjmccall > > wrote: > > > > > In D56411#1365727

[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

rjmccall added a comment. Well, you can always make a variable with a more directly-applicable name than `capturedByInit` and update it as appropriate, like `locIsByrefHeader`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58218/new/

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1365878 , @yaxunl wrote: > In D56411#1365745 , @rjmccall wrote: > > > In D56411#1365727 , @yaxunl wrote: > > > > > In D56411#1360010

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

rjmccall added a comment. Okay. Is it acceptable for the annotation to simply disappear in this case? I don't really understand the purposes of annotations well enough to judge. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58147/new/ https://reviews.llvm.org/D58147

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Multiple diagnostics can be caused by the same unresolved name or incomplete type, especially

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

This revision was automatically updated to reflect the committed changes. Closed by commit rC354035: [Sema] Fix a regression introduced in [AST][Sema] Remove CallExpr::setNumArgs (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan created this revision. ebevhan added reviewers: Anastasia, rjmccall. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. The semantics for converting nested pointers between address spaces are not very well defined. Some conversions which do not really carry

r354035 - [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

Author: brunoricci Date: Thu Feb 14 07:43:17 2019 New Revision: 354035 URL: http://llvm.org/viewvc/llvm-project?rev=354035=rev Log: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs" D54902 removed CallExpr::setNumArgs in preparation of tail-allocating the arguments

[PATCH] D47127: [RISCV] Default enable RISCV linker relaxation

asb edited subscribers, added: cfe-commits; removed: llvm-commits. asb added a comment. Removing llvm-commits and adding cfe-commits. This patch is mistakenly marked as targeting the LLVM repo rather than Clang. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted)

JonasToth added inline comments. Herald added a subscriber: jdoerfert. Comment at: test/clang-tidy/readability-identifier-naming-camelback-or-case.cpp:97 +class aB_def +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: invalid case style +{ why no test for fixing?

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL354027: [ASTImporter] Check visibility/linkage of functions and variables (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong added a comment. @shafik Thanks for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r354027 - [ASTImporter] Check visibility/linkage of functions and variables

Author: martong Date: Thu Feb 14 05:07:03 2019 New Revision: 354027 URL: http://llvm.org/viewvc/llvm-project?rev=354027=rev Log: [ASTImporter] Check visibility/linkage of functions and variables Summary: During import of a global variable with external visibility the lookup will find variables

r353990 - [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug.

Author: hctim Date: Wed Feb 13 15:14:54 2019 New Revision: 353990 URL: http://llvm.org/viewvc/llvm-project?rev=353990=rev Log: [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug. Summary: Provided rule of thumb percentage chances of miss for 4 and 8 bit tag

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1592 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +

  1   2   >