[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

rsmith added a comment. In D60539#1464097 , @sammccall wrote: > Adding `-std=c++14` doesn't work in general as it has side-effects: `clang > -std=c++14 foo.c` is a warning, `clang -std=c++14 -x c-header foo.h` is an > error. It would be nice if clang

r358326 - [verify] Add support for location markers in directives.

Author: rsmith Date: Fri Apr 12 21:33:39 2019 New Revision: 358326 URL: http://llvm.org/viewvc/llvm-project?rev=358326=rev Log: [verify] Add support for location markers in directives. A marker (matching /#[A-Za-z0-9_-]/) is specified by attaching a comment containing the marker to the line at

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 194998. stephanemoore added a comment. Fix some formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/ https://reviews.llvm.org/D59806 Files:

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 194997. stephanemoore marked 4 inline comments as done. stephanemoore added a comment. Check if either the receiver or selector are in macro locations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 194996. stephanemoore marked 3 inline comments as done. stephanemoore added a comment. Add `CHECK-FIXES` to verify code is preserved for scenarios that should not have fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 194995. stephanemoore added a comment. Update check to avoid emitting a fix if the expression is in a macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/ https://reviews.llvm.org/D59806

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

hintonda added a comment. In D60629#1464945 , @Eugene.Zelenko wrote: > Please use check for consistency with rest of Clang-tidy. Thanks for taking a look — I’ll Fix that on the next upload. So are you okay with llvm_check? I sorta like it, but happy

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358321: [analyzer] Escape pointers stored into top-level parameters with destructors. (authored by dergachev, committed by ). Changed prior to commit:

r358321 - [analyzer] Escape pointers stored into top-level parameters with destructors.

Author: dergachev Date: Fri Apr 12 19:01:45 2019 New Revision: 358321 URL: http://llvm.org/viewvc/llvm-project?rev=358321=rev Log: [analyzer] Escape pointers stored into top-level parameters with destructors. Writing stuff into an argument variable is usually equivalent to writing stuff to a

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added inline comments. Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future, it would be great to add support for other STL and +non-STL containers, and most notably,

Buildbot numbers for the last week of 03/31/2019 - 04/06/2019

Hello everyone, Below are some buildbot numbers for the last week of 03/31/2019 - 04/06/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 03/24/2019 - 03/30/2019

Hello everyone, Below are some buildbot numbers for the week of 03/24/2019 - 03/30/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

NoQ added a comment. This new approach is clearly useful to other checkers as well, not only the Taint checker. I believe we should strongly consider generalizing it somehow, it's just too awesome to restrict to a single checker. There's also a closely related technology called "API Notes"

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

Bigcheese requested changes to this revision. Bigcheese added a comment. This revision now requires changes to proceed. I have a bit more review to do, but this is what I've found so far. The naming comments are just suggestions, but the digit separators' are actually an issue.

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

saar.raz updated this revision to Diff 194984. saar.raz added a comment. Rebase onto trunk Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41284/new/ https://reviews.llvm.org/D41284 Files: include/clang/AST/DeclTemplate.h

[PATCH] D60626: [clang] Aligned allocation is actually supported in macosx 10.13

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60626/new/ https://reviews.llvm.org/D60626

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 194979. saar.raz added a comment. Fix wrong patch uploaded Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41217/new/ https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 194978. saar.raz added a comment. Add new CodeSynthesisContexts to switch where they were missing Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41217/new/ https://reviews.llvm.org/D41217 Files:

[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:173 + } + + // Builds of compiler-rt on bare-metal targets are specialized by specific Would it be possible to support the [per-target runtimes directory

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang marked an inline comment as done. mgrang added a comment. In D60349#1462638 , @ostannard wrote: > The document you linked in the LLVM change > (https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2019#return-values) >

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 194954. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/arm64-microsoft-arguments.cpp

r358307 - Relanding r357928 with fixed debuginfo check.

Author: akhuang Date: Fri Apr 12 13:25:30 2019 New Revision: 358307 URL: http://llvm.org/viewvc/llvm-project?rev=358307=rev Log: Relanding r357928 with fixed debuginfo check. [MS] Add metadata for __declspec(allocator) Original summary: Emit !heapallocsite in the metadata for calls to functions

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

Eugene.Zelenko added a comment. Please use check for consistency with rest of Clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 ___ cfe-commits

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:80 +// \endcode +struct TextChange { + // The (bound) id of the node whose source will be replaced. This id should ilya-biryukov wrote: > ymandel wrote: > >

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 194944. ymandel marked 8 inline comments as done. ymandel added a comment. Responses to comments, including renaming TextChange and applyRewriteRule. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

hintonda updated this revision to Diff 194940. hintonda added a comment. - Remove leftover comments, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files:

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1062 + bool sretInX0 = (CGM.getTarget().getTriple().getArch() == + llvm::Triple::aarch64) && !RD->isPOD(); + ostannard wrote: > This should also check aarch64_be.

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

hintonda updated this revision to Diff 194941. hintonda added a comment. - Add missing 'clang'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

hintonda created this revision. hintonda added reviewers: alexfh, aaron.ballman. Herald added a subscriber: xazax.hun. Herald added a project: clang. Change the namespace for llvm checkers from 'llvm' to 'llvm_checker', and modify add_new_check.py and rename_check.py to support the new namespace.

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

hintonda abandoned this revision. hintonda added a comment. Replaced by D60629 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60151/new/ https://reviews.llvm.org/D60151

[PATCH] D60627: [MSVC] Use the correct casing of HostX64/HostX86

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a project: clang. If accessing the MSVC installation root directly on a case sensitive filesystem, these details matter. Repository: rC Clang https://reviews.llvm.org/D60627 Files: lib/Driver/ToolChains/MSVC.cpp

[PATCH] D60094: [MSVC] If unable to find link.exe from a MSVC installation, look for link.exe next to cl.exe

mstorsjo updated this revision to Diff 194928. mstorsjo added a comment. Removed other local experiments from the patch context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60094/new/ https://reviews.llvm.org/D60094 Files: lib/Driver/ToolChains/MSVC.cpp Index:

[PATCH] D40577: Clang support for simd functions

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615 + + std::string Buffer; + if (Fn->hasFnAttribute("vector-variants")) { mmasten wrote: > ABataev wrote: > > 1. Why this change is required? > > 2. Why not a `SmallString`? >

[PATCH] D60094: [MSVC] If unable to find link.exe from a MSVC installation, look for link.exe next to cl.exe

mstorsjo updated this revision to Diff 194926. mstorsjo retitled this revision from "[MSVC] If unable to find link.exe relative to MSVC, look for link.exe in the path" to "[MSVC] If unable to find link.exe from a MSVC installation, look for link.exe next to cl.exe". mstorsjo edited the summary

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

riccibruno added a comment. In D60561#1464740 , @Tyker wrote: > @rsmith i don't think collecting theses values is expansive compared to > evaluating the expression. > but i agree that we can disable the collection of these values when no > diagnostics

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:552 +const tooling::CompileCommand ::getCurrentCompileCommand() const { + return FileInputs.CompileCommand; +} ioeric wrote: > ilya-biryukov wrote: > >

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:552 +const tooling::CompileCommand ::getCurrentCompileCommand() const { + return FileInputs.CompileCommand; +} ilya-biryukov wrote: > ioeric wrote: > >

RE: r357877 - [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413

Hi Owen, FYI, putting a URL in the headline of the commit message takes up space and doesn't really describe the fix to a casual reader. The subject line of your Phabricator review looks like it would have been perfectly fine to use for the commit as well. Citing the bug in the body of the

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker added a comment. @rsmith i don't think collecting theses values is expansive compared to evaluating the expression. but i agree that we can disable the collection of these values when it isn't needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60561/new/

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 194925. ztamas marked an inline comment as done. ztamas added a comment. Documentation fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 Files:

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas marked 13 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-self-assignment.rst:10 + +This check corresponds to the CERT C++ Coding Standard rule +`OOP54-CPP. Gracefully handle self-copy

[libunwind] r358301 - [NFC] Move the export attribute after extern "C".

Author: rakete Date: Fri Apr 12 11:34:19 2019 New Revision: 358301 URL: http://llvm.org/viewvc/llvm-project?rev=358301=rev Log: [NFC] Move the export attribute after extern "C". Not all compilers support attributes before `extern "C"`. gcc is the main one that doesn't support it. Modified:

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-self-assignment.rst:6 + +"cert-oop54-cpp" redirects here as an alias for this check. + Please use back-tick to highlight cert-oop54-cpp.

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 194921. ztamas added a comment. Updated the code based on reviewer comments: - Alphabetical order in `BugproneTidyModule.cpp` - Handling of `auto_ptr` - Test cases for template classes (I made the check ignore these case otherwise this can lead to false

[PATCH] D40577: Clang support for simd functions

mmasten marked 2 inline comments as done. mmasten added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615 + + std::string Buffer; + if (Fn->hasFnAttribute("vector-variants")) { ABataev wrote: > 1. Why this change is required? > 2. Why not

[PATCH] D60626: [clang] Aligned allocation is actually supported in macosx 10.13

ldionne created this revision. ldionne added a reviewer: ahatanak. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. In r350649, I changed aligned allocation from being available starting in macosx10.13 to macosx10.14. However, aligned allocation is indeed

[PATCH] D40577: Clang support for simd functions

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615 + + std::string Buffer; + if (Fn->hasFnAttribute("vector-variants")) { 1. Why this change is required? 2. Why not a `SmallString`? Comment at:

[PATCH] D40577: Clang support for simd functions

mmasten updated this revision to Diff 194917. mmasten added a comment. Rebased and updated test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40577/new/ https://reviews.llvm.org/D40577 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_simd_codegen.cpp Index:

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:552 +const tooling::CompileCommand ::getCurrentCompileCommand() const { + return FileInputs.CompileCommand; +} ioeric wrote: > ilya-biryukov wrote: > > ioeric wrote: > > > ilya-biryukov

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:552 +const tooling::CompileCommand ::getCurrentCompileCommand() const { + return FileInputs.CompileCommand; +} ilya-biryukov wrote: > ioeric wrote: > >

[PATCH] D60620: [HIP] Support -offloading-target-id

tra added a subscriber: arsenm. tra added a comment. @arsenm Matt, FYI, this patch seems to be a continuation of D59863 you've commented on. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620

[PATCH] D60620: [HIP] Support -offloading-target-id

tra added a subscriber: echristo. tra added a comment. It looks like you are solving two problems here. a) you want to create multiple device passes for the same GPU, but with different options. b) you may want to pass different compiler options to different device compilations. The patch

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:552 +const tooling::CompileCommand ::getCurrentCompileCommand() const { + return FileInputs.CompileCommand; +} ioeric wrote: > ilya-biryukov wrote: > > ioeric wrote: > > > ilya-biryukov

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ilya-biryukov added a comment. In D60408#1464364 , @ymandel wrote: > I've done that as far as I can tell. Please let me know if I've missed > anything. Many thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:80 +// \endcode +struct TextChange { + // The (bound) id of the node whose source will be replaced. This id should ymandel wrote: > ilya-biryukov wrote: > >

Re: [clangd] Print template arguments helper

Thanks Bruno, sent out rL358293 to address the issue. On Fri, Apr 12, 2019 at 5:21 PM Bruno Ricci wrote: > Hi, > > It seems that one of r358272, r358273 or r358274 is causing some asan > failure on my machine. Not sure why it is not spotted by the bots. > > Failure log attached. > > Bruno >

[clang-tools-extra] r358293 - [clangd] Fix an overflow inside a test

Author: kadircet Date: Fri Apr 12 09:40:54 2019 New Revision: 358293 URL: http://llvm.org/viewvc/llvm-project?rev=358293=rev Log: [clangd] Fix an overflow inside a test Modified: clang-tools-extra/trunk/unittests/clangd/PrintASTTests.cpp Modified:

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expression.

riccibruno added a comment. Friendly ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60513: [HIP] Use -mlink-builtin-bitcode to link device library

This revision was automatically updated to reflect the committed changes. Closed by commit rL358290: [HIP] Use -mlink-builtin-bitcode to link device library (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r358290 - [HIP] Use -mlink-builtin-bitcode to link device library

Author: yaxunl Date: Fri Apr 12 09:23:31 2019 New Revision: 358290 URL: http://llvm.org/viewvc/llvm-project?rev=358290=rev Log: [HIP] Use -mlink-builtin-bitcode to link device library Use -mlink-builtin-bitcode instead of llvm-link to link device library so that device library bitcode and user

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

compnerd added inline comments. Comment at: lld/ELF/InputFiles.cpp:662 } + case SHT_LLVM_DEPLIBS: { +if (Config->Relocatable) Can you make the flag here reflect the name as well? (`SHT_LLVM_DEPENDENT_LIBRARIES`) Comment at:

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 194899. hintonda added a comment. - Fix comments and add isDefaultOption per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 Files:

[PATCH] D60620: [HIP] Support -offloading-target-id

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner, ashi1, scchan, t-tye. Herald added a subscriber: mgorny. This patch introduces a new option -offloading-target-id for HIP. Offloading target id is a generalization of CUDA/HIP GPU arch. It is a device name plus optional feature

[PATCH] D60029: Add const children() accessors to all AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358288: [AST][NFC] Add const children() accessors to all AST nodes (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D60029?vs=193288=194897#toc Repository:

r358288 - [AST][NFC] Add const children() accessors to all AST nodes

Author: brunoricci Date: Fri Apr 12 08:36:02 2019 New Revision: 358288 URL: http://llvm.org/viewvc/llvm-project?rev=358288=rev Log: [AST][NFC] Add const children() accessors to all AST nodes Systematically add the const-qualified version of children() to all statement/expression nodes.

Re: [clangd] Print template arguments helper

Hi, It seems that one of r358272, r358273 or r358274 is causing some asan failure on my machine. Not sure why it is not spotted by the bots. Failure log attached. Bruno FAIL: Extra Tools Unit Tests :: clangd/./ClangdTests/ASTUtilsTests/ASTUtils.PrintTemplateArgs/1 (878 of 1313)

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:338 + Barrier(Barrier), Done(false) { + FileInputs.CompileCommand = CDB.getFallbackCommand(FileName); +} ilya-biryukov wrote: > ioeric wrote: > > ilya-biryukov wrote: > > > The command is

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 194891. ioeric marked 5 inline comments as done. ioeric added a comment. - address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files:

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:473 + /// atomic_default_mem_order seq_cst clause. + OMP_REQ_ATOMIC_DEFAULT_SEQ_CST = 0x008, + /// atomic_default_mem_order acq_rel clause. YOu don't need al these flags, add only

[PATCH] D60029: Add const children() accessors to all AST nodes.

nicolas added a comment. Yes, thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

bader accepted this revision. bader added inline comments. Comment at: clang/test/SemaSYCL/device-attributes-on-non-sycl.cpp:5 + +#if defined(EXPECT_WARNINGS) +// expected-warning@+8 {{'sycl_kernel' attribute ignored}} I think you can use `__SYCL_DEVICE_ONLY__`

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 194887. ymandel added a comment. Final code shifting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408 Files: clang/include/clang/Tooling/Refactoring/Transformer.h

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel added a comment. In D60408#1463909 , @ilya-biryukov wrote: > Sorry for the delay. > There seem to be a few changes that are unrelated to the actual patch. Could > we separate various non-functional changes (moving code around, etc.) into a >

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 194886. ymandel added a comment. More code movement (putting things back). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408 Files:

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 194883. ymandel marked 2 inline comments as done. ymandel added a comment. Restore code ordering for unrelated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 194878. Fznamznon added a comment. Applied comments from @aaron.ballman and @keryell - Introduce a C++11 and C2x style spelling in the clang namespace I didn't find path to add two namespaces to attribute (like [[clang::sycl::device]] so

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: test/CXX/basic/basic.lookup/basic.lookup.argdep/p2-associated-namespaces-classes.cpp:304 +static_assert(f(g3) == 4, "");// FIXME: Also well-formed from the union rule. +

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:338 + Barrier(Barrier), Done(false) { + FileInputs.CompileCommand = CDB.getFallbackCommand(FileName); +} ioeric wrote: > ilya-biryukov wrote: > > The command is filled with a fallback

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358285: [asan] Add gcc 8s driver option -fsanitize=pointer-compare and… (authored by pgousseau, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

pgousseau marked an inline comment as done. pgousseau added inline comments. Comment at: test/Driver/fsanitize.c:837 +// RUN: %clang -target x86_64-linux-gnu -fsanitize=pointer-compare -fno-sanitize=pointer-compare %s -### 2>&1 | FileCheck %s

r358285 - [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

Author: pgousseau Date: Fri Apr 12 07:14:58 2019 New Revision: 358285 URL: http://llvm.org/viewvc/llvm-project?rev=358285=rev Log: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract. Disabled by default as this is still an experimental feature.

[PATCH] D60123: [AST] Forbid copy/move of statements/types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358283: [AST] Forbid copy/move of statements/types (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/

r358283 - [AST] Forbid copy/move of statements/types

Author: brunoricci Date: Fri Apr 12 06:26:55 2019 New Revision: 358283 URL: http://llvm.org/viewvc/llvm-project?rev=358283=rev Log: [AST] Forbid copy/move of statements/types Statements, expressions and types are not supposed to be copied/moved, and trying to do so is only going to result in

[PATCH] D60029: Add const children() accessors to all AST nodes.

riccibruno added a comment. Sorry for the delay. Thanks a lot for the patch! Some of these casts are rather questionable. However this has nothing to do with your patch since you are just adding the const-qualified version of `children()`. Therefore I believe this patch looks good. Do you want

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

AlexEichenberger requested changes to this revision. AlexEichenberger added a comment. This revision now requires changes to proceed. see note above; apologies if it is already done and hiding somewhere I did not see Comment at: lib/CodeGen/CGOpenMPRuntime.h:641 + ///

[PATCH] D60560: [clangd] Enable clang-tidy by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358282: [clangd] Enable clang-tidy by default. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r358282 - [clangd] Enable clang-tidy by default.

Author: hokein Date: Fri Apr 12 06:07:48 2019 New Revision: 358282 URL: http://llvm.org/viewvc/llvm-project?rev=358282=rev Log: [clangd] Enable clang-tidy by default. Summary: We have turned on the flag internally for a while, and we don't receive complains. Should be good to turn it on now.

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall updated this revision to Diff 194855. sammccall added a comment. Unit tests. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/ https://reviews.llvm.org/D60605 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:338 + Barrier(Barrier), Done(false) { + FileInputs.CompileCommand = CDB.getFallbackCommand(FileName); +} ilya-biryukov wrote: > The command is filled with a fallback by `ClangdServer`, right?

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 194850. ioeric marked 7 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files:

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 194851. ioeric added a comment. - Add missing comment to TUScheduler.h Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files: clangd/ClangdServer.cpp

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan updated this revision to Diff 194844. yvvan retitled this revision from "[clang-format] Introduce the flag which allows not to shrink lines" to "[clang-format] Create a new tool for IDEs based on clang-format". yvvan edited the summary of this revision. yvvan added a reviewer: arphaman.

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. Use native llvm JSON library update: https://reviews.llvm.org/D60609 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing

Re: r357340 - Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps.

I haven't tried -ftime-report here. I tried it in the past and found it difficult to interpret, as the blog post you link to correctly says :) I thought -ftime-trace was supposed to be more usable, so I figured I'd try that instead. And for frontend stuff, it does look much better! Ideas on how

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added a comment. This is long overdue Comment at: clangd/TUScheduler.cpp:338 + Barrier(Barrier), Done(false) { + FileInputs.CompileCommand = CDB.getFallbackCommand(FileName); +} The command is filled with a fallback by `ClangdServer`,

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Herald added a subscriber: jsji. I don't think this is a suitable fix :-( There are lots of places where we construct command-lines in tests, it may be true today that this is

[PATCH] D60257: [Lookup] Invisible decls should not be ambiguous when renaming.

ioeric updated this revision to Diff 194841. ioeric marked 2 inline comments as done. ioeric added a comment. - Add test comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60257/new/ https://reviews.llvm.org/D60257 Files:

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

Quuxplusone added inline comments. Comment at: test/CXX/basic/basic.lookup/basic.lookup.argdep/p2-associated-namespaces-classes.cpp:304 +static_assert(f(g3) == 4, "");// FIXME: Also well-formed from the union rule. + //

[PATCH] D60257: [Lookup] Invisible decls should not be ambiguous when renaming.

ioeric added inline comments. Comment at: unittests/Tooling/LookupTest.cpp:215 + + // Potentially ambiguous symbols that are not visible at reference location + // are not considered ambiguous. hokein wrote: > The test seems hard to understand what it actually

[PATCH] D60316: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc.

ioeric requested changes to this revision. ioeric added a comment. This revision now requires changes to proceed. in case you missed this patch :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60316/new/ https://reviews.llvm.org/D60316

  1   2   >