[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

jdoerfert added a comment. In D60907#1483615 , @hfinkel wrote: > In D60907#1479370 , @gtbercea wrote: > > > In D60907#1479142 , @hfinkel wrote: > > > > > In D60907#1479118

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

jdoerfert added a comment. In D47849#1435770 , @hfinkel wrote: > We need to make progress on this, and I'd like to suggest a path forward... > > First, we have a fundamental problem here: Using host headers to declare > functions for the device execution

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483480 , @jakehehrlich wrote: > In D60974#1483399 , @plotfi wrote: > > > In D60974#1483265 , @jakehehrlich > > wrote: > > > > > In

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

hfinkel added a comment. In D60907#1479370 , @gtbercea wrote: > In D60907#1479142 , @hfinkel wrote: > > > In D60907#1479118 , @gtbercea > > wrote: > > > > > Ping @hfinkel

[PATCH] D61015: [LibTooling] Change Transformer's TextGenerator to a partial function.

ymandel updated this revision to Diff 197255. ymandel added a comment. Updates comments on Transformer to make explicit the error reporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61015/new/ https://reviews.llvm.org/D61015 Files:

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

This revision was automatically updated to reflect the committed changes. Closed by commit rC359531: [analyzer] Treat functions without run-time branches as small. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61051?vs=197248=197253#toc Repository:

[PATCH] D61015: [LibTooling] Change Transformer's TextGenerator to a partial function.

ymandel updated this revision to Diff 197250. ymandel added a comment. Herald added a subscriber: jfb. Add test for new behavior. In the process, tweak the handling of errors from TextGenerators in Transformer: instead of printing to `llvm::errs`, we set the error in the AtomicChange.

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359530: [analyzer] SmartPtrModeling: Fix a null dereference. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61285?vs=197222=197251#toc Repository: rC

r359531 - [analyzer] Treat functions without run-time branches as "small".

Author: dergachev Date: Mon Apr 29 20:01:02 2019 New Revision: 359531 URL: http://llvm.org/viewvc/llvm-project?rev=359531=rev Log: [analyzer] Treat functions without run-time branches as "small". Currently we always inline functions that have no branches, i.e. have exactly three CFG blocks:

r359530 - [analyzer] SmartPtrModeling: Fix a null dereference.

Author: dergachev Date: Mon Apr 29 20:00:57 2019 New Revision: 359530 URL: http://llvm.org/viewvc/llvm-project?rev=359530=rev Log: [analyzer] SmartPtrModeling: Fix a null dereference. Don't crash when trying to model a call in which the callee is unknown in compile time, eg. a pointer-to-member

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

NoQ added a comment. The whole AST consists in passing raw unannotated pointers around and i suspect it'll be annoying to deal with `Stmt &`s and `Decl &`s specifically in the Analyzer when all AST APIs accept pointers. I guess we'll have to go with some sort of nullability annotations, yeah.

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

jdoerfert added subscribers: xtian, gregrodgers, ddibyend. jdoerfert added a comment. Herald added a subscriber: ormris. Could you sketch for me how this will (potentially) work if we have multiple target vendors? The fatbin solution seems tailored to NVIDIA, but maybe I'm wrong here. In any

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ updated this revision to Diff 197248. NoQ added a comment. Crystallize the `isHuge()` function and document more stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 Files: clang/include/clang/Analysis/CFG.h

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

tstellar updated this revision to Diff 197244. tstellar marked an inline comment as done. tstellar added a comment. Make sure to install the generated files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ https://reviews.llvm.org/D61220

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

jdoerfert added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1159 + getToolChain().getTriple().isNVPTX()) +getToolChain().AddMathDeviceFunctions(Args, CmdArgs); + Here is another "NVPTX" specialization that I don't think we need. At

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek updated this revision to Diff 197241. phosek retitled this revision from "[runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/" to "[runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++". phosek edited the summary of this revision. phosek

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

xazax.hun accepted this revision. xazax.hun added a comment. LG! These mistakes are so easy to make. Maybe we should add nullability annotations (or use optionals) in the future? (Or just make every non-null pointer a reference and make it a convention to always check for nulls?) Repository:

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

vzakhari added a comment. OK, this should work while clang_generate_header() is used for plain files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ https://reviews.llvm.org/D61220 ___

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. With respect to group handeling. I think we should just check that the details of every symbol across all unmerged files that are being merged are consistent and then ignore duplicates. For symbols that are not defined in sections that are a part of a comdat group

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1483399 , @plotfi wrote: > In D60974#1483265 , @jakehehrlich > wrote: > > > In D60974#1483240 , @plotfi wrote: > > > > > Me and

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1483380 , @plotfi wrote: > Also, curious on the lack of denoting the sections and which symbols go in > which sections? Do you just assume that "Type: Object" goes into .data? You don't need that information and

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

tstellar updated this revision to Diff 197233. tstellar added a comment. - Fix install directory - Use a separate install targets for each sub-directory like it was done before r355253. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/

[PATCH] D61264: Fix inconsistency in calculating DIAG_START values

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Thanks for thefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61264/new/ https://reviews.llvm.org/D61264

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 added a comment. GCC warns even for for that case, so this patch implements GCC's behaviour for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61288/new/ https://reviews.llvm.org/D61288 ___ cfe-commits mailing list

[PATCH] D61142: Set LoopInterleaved in the PassManagerBuilder.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, maybe add a comment here to archive some of the reasoning? (IE, that when unrolling is disabled we disable both literal unrolling but also interleaving for historical reasons)

[PATCH] D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997)

riccibruno added a comment. @rsmith Do you have an opinion on whether this ADL rule should be implemented ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60665/new/ https://reviews.llvm.org/D60665 ___ cfe-commits

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith marked 2 inline comments as done. rsmith added a comment. Thanks, this is looking really good. (Lots of comments but they're mostly mechanical at this point.) Comment at: clang/include/clang/AST/DeclBase.h:1539-1541 +uint64_t NumCtorInitializers : 64 -

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

riccibruno added a comment. Is it intentional to warn even if all the cases are covered ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61288/new/ https://reviews.llvm.org/D61288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483265 , @jakehehrlich wrote: > In D60974#1483240 , @plotfi wrote: > > > Me and @compnerd had discussed a more abstracted format like this but > > decided it was best to just

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator

riccibruno marked 3 inline comments as done. riccibruno added inline comments. Comment at: test/CXX/dcl.dcl/dcl.enum/p11-enumerator_scope.cpp:107 enum { typedef_type };// expected-error {{redefinition of 'typedef_type'}} }; riccibruno

r359524 - [NFC] typo

Author: jfb Date: Mon Apr 29 17:19:43 2019 New Revision: 359524 URL: http://llvm.org/viewvc/llvm-project?rev=359524=rev Log: [NFC] typo Modified: cfe/trunk/lib/Sema/Sema.cpp Modified: cfe/trunk/lib/Sema/Sema.cpp URL:

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 updated this revision to Diff 197229. xbolva00 added a comment. Removed redundant line in DiagnosticGroups CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61288/new/ https://reviews.llvm.org/D61288 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator

riccibruno updated this revision to Diff 197225. riccibruno retitled this revision from "[Sema] Fix the lookup for a declaration conflicting with an enumerator (bogus use of LookupResult::getAsSingle)" to "[Sema] Fix the lookup for a declaration conflicting with an enumerator". riccibruno edited

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 created this revision. xbolva00 added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D61288 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticIDs.h

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483209 , @jakehehrlich wrote: > I think I know the format that I'd like *roughly*. I haven't worked out how > to handle COMDAT and section groups yet. Roland seems to think that COMDAT > and section groups will be

r359523 - [NFC] typo

Author: jfb Date: Mon Apr 29 17:11:53 2019 New Revision: 359523 URL: http://llvm.org/viewvc/llvm-project?rev=359523=rev Log: [NFC] typo Modified: cfe/trunk/include/clang/AST/ASTContext.h cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/include/clang/AST/ASTContext.h URL:

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. When I see `->*` I go mad, but we should handle unknown stuff, cool patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61285/new/

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:667 if (Name == "avx512bw" && !Enabled) Features["avx512vbmi"] = Features["avx512vbmi2"] = Features["avx512bitalg"] = false; craig.topper wrote: > Need to also disable

[PATCH] D59843: [PowerPC] Add support for __dcbf builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rC359517: Add __builtin_dcbf support for PPC (authored by saghir, committed by ). Herald added subscribers: cfe-commits, kristina. Herald added a project: clang. Changed prior to commit:

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rC359516: [Diagnostics] Support -Wtype-limits for GCC compatibility (authored by xbolva00, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/

r359516 - [Diagnostics] Support -Wtype-limits for GCC compatibility

Author: xbolva00 Date: Mon Apr 29 16:24:00 2019 New Revision: 359516 URL: http://llvm.org/viewvc/llvm-project?rev=359516=rev Log: [Diagnostics] Support -Wtype-limits for GCC compatibility Summary: GCC's -Wtype-limits (part of -Wextra): Warn if a comparison is always true or always false due to

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 updated this revision to Diff 197216. xbolva00 added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 Files: include/clang/Basic/DiagnosticGroups.td test/Sema/compare.c test/Sema/tautological-constant-compare.c

[PATCH] D59520: [WebAssembly] Address review comments on r352930

sunfish updated this revision to Diff 197215. sunfish added a comment. Implemented proper diagnostics for import_name/import_module on functions with definitions, and updated the test. I'm unsure of the `DIAG_SIZE_SEMA` change, but without it, the build fails with this error:

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added inline comments. Comment at: clang/include/clang/Driver/Types.def:91 TYPE("ast", AST, INVALID, "ast", "u") +TYPE("ifso", IFSO, INVALID, "ifso", "u") TYPE("pcm",

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. > I think the !tbd-elf-v1 versioning can help with any changes or alterations > we want to make along the way too. I think this is good. I kind of glanced over it and mentioned a Version field. Version is handled explicitly by a VersionTuple in llvm-elfabi. I

[PATCH] D55229: [COFF] Statically link certain runtime library functions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC359513: Re-land r359250, [COFF] Statically link certain runtime library functions (authored by rnk, committed by ).

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

rsmith added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/include/clang/AST/Type.h:4174 +/// Sugar type that represents a type that was defined in a macro. +class MacroQualifiedType : public Type { This comment is out of date. "[...]

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1483240 , @plotfi wrote: > Me and @compnerd had discussed a more abstracted format like this but decided > it was best to just use the same names that are in the ELF already. > Is there any compelling reason not

r359513 - Re-land r359250, [COFF] Statically link certain runtime library functions

Author: rnk Date: Mon Apr 29 16:05:47 2019 New Revision: 359513 URL: http://llvm.org/viewvc/llvm-project?rev=359513=rev Log: Re-land r359250, [COFF] Statically link certain runtime library functions Reverts the revert of r359251, this time with fixed tests. Differential Revision:

[PATCH] D55229: [COFF] Statically link certain runtime library functions

rnk updated this revision to Diff 197211. rnk added a comment. - update test to check IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55229/new/ https://reviews.llvm.org/D55229 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

Szelethus added a comment. I think you can commit this. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59279/new/ https://reviews.llvm.org/D59279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus updated this revision to Diff 197210. Szelethus added a comment. Uploaded the correct diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 Files: test/Analysis/checker-plugins.c test/Analysis/plugins/CMakeLists.txt

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

TomTan updated this revision to Diff 197208. TomTan added a comment. Herald added a subscriber: jholewinski. Added test cases and also merged this alignment adjustment to `getMinGlobalAlign` in `MicrosoftARM64TargetInfo`. Repository: rC Clang CHANGES SINCE LAST ACTION

r359512 - Make test more robust by writing stdout/stderr to different files.

Author: dyung Date: Mon Apr 29 15:57:15 2019 New Revision: 359512 URL: http://llvm.org/viewvc/llvm-project?rev=359512=rev Log: Make test more robust by writing stdout/stderr to different files. Our internal build bots were failing this test randomly as the stderr output was emitted to the file

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

Szelethus updated this revision to Diff 197209. Szelethus added a comment. Add `TODO:`s about missing warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61246/new/ https://reviews.llvm.org/D61246 Files: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h

[PATCH] D61136: [Analyzer] IteratorChecker - Ensure end()>=begin() and refactor begin and end symbol creation

NoQ added a comment. In D61136#1480023 , @baloghadamsoftware wrote: > Abstract iterator positions are represented by symbolic expressions because > we must be able to do simple calculations with them. This has nothing to do > with iterator objects

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483209 , @jakehehrlich wrote: > I think I know the format that I'd like *roughly*. I haven't worked out how > to handle COMDAT and section groups yet. Roland seems to think that COMDAT > and section groups will be

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

craig.topper added a comment. The main reason that we used inline assembly is due to the fixed register allocation for these instructions. We would have had to write out the register rules in the backend as a special case as seen in the getInstrWFourImplicitOps in

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483210 , @jakehehrlich wrote: > In D60974#1483164 , @plotfi wrote: > > > So, @compnerd and I have discussed and we'd like to propose a yaml schema > > that can express what we

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. To clarify my format is for the unmerged format. The merged format should be the ELFStub internal representation found in llvm's TextAPI. The plan is to have at minimum .tbe and ELF stubs. I'm actively working on getting the ELF stub output which can then be

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1483164 , @plotfi wrote: > So, @compnerd and I have discussed and we'd like to propose a yaml schema > that can express what we need for ifsos for the Sections and the Symbols. > > ... Can you clarify is this is

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. I think I know the format that I'd like *roughly*. I haven't worked out how to handle COMDAT and section groups yet. Roland seems to think that COMDAT and section groups will be an issue but I'm working out the details with him to make sure I understand it. I'll

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

NoQ added inline comments. Comment at: test/Analysis/cxx-uninitialized-object.cpp:1155 +void __vector_size__LongTest() { + VectorSizeLong v; +} gribozavr wrote: > gribozavr wrote: > > gribozavr wrote: > > > Could you also add tests where the vector member is

[PATCH] D58321: Support for relative vtables

leonardchan updated this revision to Diff 197196. leonardchan marked an inline comment as done. leonardchan retitled this revision from "[WIP] Support for relative vtables" to "Support for relative vtables". leonardchan added a comment. Ok. Formally requesting for code reviews now. - Made the

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

vsapsai added a comment. I see you've ended up implementing the intrinsics with inline assembly but are there any reasons not to do it with builtins like in this patch? The problem with inline assembly is that for some Apple platforms we require developers to emit bitcode. And inline assembly

[PATCH] D60910: [WIP] Dumping the AST to JSON

steveire added a comment. Thanks for doing this! I'm glad you were able to do it without needing to change the traverser class. That's a good indicator. I think it would be great if there were somewhere to document the non-stability of the format and content here. Comment

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. So, @compnerd and I have discussed and we'd like to propose a yaml schema that can express what we need for ifsos for the Sections and the Symbols. For the Symbols we want: Symbols: - Name:_dataA Type:STT_OBJECT Section:

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D58841#1483128 , @xbolva00 wrote: > Thanks for the review! If the patch is fine, please approve it. Sure thing! (Phab doesn't permit approving a

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 added a comment. Ok, reclaiming patch. Thanks for the review! If the patch is fine, please approve it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 ___ cfe-commits mailing list

[PATCH] D61278: Simplify exclusion of nested classes from extern template instantiation, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL359507: Simplify exclusion of nested classes from extern template instantiation, NFC (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r359507 - Simplify exclusion of nested classes from extern template instantiation, NFC

Author: rnk Date: Mon Apr 29 14:32:05 2019 New Revision: 359507 URL: http://llvm.org/viewvc/llvm-project?rev=359507=rev Log: Simplify exclusion of nested classes from extern template instantiation, NFC Summary: This simplifies three checks for MS ABI, Win Itanium, or Win GNU to just "is

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

rsmith added a comment. > xbolva00 abandoned this revision. Do you not want to pursue this any more? This seems reasonable to me, and is in line with other cases where we have diagnostic flags as aliases to GCC's similar-but-not-quite-the-same flags (eg, GCC's `-Wnoexcept-type` doesn't fire

[PATCH] D61274: [Sema][AST] Explicit visibility for OpenCL/CUDA kernels/variables

tra added a comment. A kernel functions in CUDA is actually two different functions. One is the real kernel we compile for the GPU, another is a host-side stub that launches the device-side kernel. On device side both clang and nvcc currently silently ignore `hidden` visibility and force the

[PATCH] D61217: Fix PCH skipping to handle all Lexers

This revision was automatically updated to reflect the committed changes. Closed by commit rC359506: When skipping code at the start of a file during PCH use, Preprocessor::Lex (authored by mikerice, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION

r359506 - When skipping code at the start of a file during PCH use, Preprocessor::Lex

Author: mikerice Date: Mon Apr 29 14:21:17 2019 New Revision: 359506 URL: http://llvm.org/viewvc/llvm-project?rev=359506=rev Log: When skipping code at the start of a file during PCH use, Preprocessor::Lex is not used since it consumes all preprocessor directives until it returns a real token.

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

jfb created this revision. jfb added reviewers: glider, pcc, kcc. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. C guarantees that brace-init with fewer initializers than members in the aggregate will initialize the rest of the aggregate as-if it were

[PATCH] D61281: [clang-format] Fixed self assignment

xbolva00 created this revision. xbolva00 added a reviewer: MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D61281 Files: lib/Format/FormatTokenLexer.cpp Index: lib/Format/FormatTokenLexer.cpp

[PATCH] D61278: Simplify exclusion of nested classes from extern template instantiation, NFC

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61278/new/ https://reviews.llvm.org/D61278

[PATCH] D61278: Simplify exclusion of nested classes from extern template instantiation, NFC

rnk created this revision. rnk added reviewers: hans, mstorsjo. Herald added a project: clang. This simplifies three checks for MS ABI, Win Itanium, or Win GNU to just "is Windows". The question remains, however, if this is really the correct thing to do. We could, for example, only not consider

[PATCH] D61175: [MinGW] Don't let template instantiation declarations cover nested classes

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lib/Sema/SemaTemplateInstantiate.cpp:2687-2689 if ((Context.getTargetInfo().getCXXABI().isMicrosoft() || - Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment())

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359502: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. (authored by teemperor, committed by ). Changed prior to commit:

[PATCH] D61175: [MinGW] Don't let template instantiation declarations cover nested classes

rnk added inline comments. Comment at: lib/Sema/SemaTemplateInstantiate.cpp:2687-2689 if ((Context.getTargetInfo().getCXXABI().isMicrosoft() || - Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment()) && +

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor added a comment. I'll land this as it seems only the tests are subject to change and I want to also land the dependencies of this patch. Please let me know if you want any other changes changes to the test and thanks for the review! CHANGES SINCE LAST ACTION

r359502 - [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

Author: teemperor Date: Mon Apr 29 14:02:35 2019 New Revision: 359502 URL: http://llvm.org/viewvc/llvm-project?rev=359502=rev Log: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. Summary: We are currently implementing support in LLDB that reconstructs the STL

[PATCH] D61217: Fix PCH skipping to handle all Lexers

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61217/new/ https://reviews.llvm.org/D61217 ___ cfe-commits mailing list

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. So, @compnerd and I have discussed and we'd like to propose a yaml schema that can express what we need for ifsos for the Sections and the Symbols. Something like: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

riccibruno added a comment. Since this is target-specific, is it right to put this here ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61225/new/ https://reviews.llvm.org/D61225 ___ cfe-commits mailing list

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

owenpan created this revision. owenpan added reviewers: klimek, sammccall, MyDeveloperDay, djasper, krasimir. owenpan added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes PR41213 . Repository: rC Clang

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

craig.topper added a comment. We seem to be missing test cases in test/Driver/x86-target-feature.c to test the command line options work. And test/Preprocessor/x86_target_features.c to make sure -mavx512bf16 enables avx512vl and avx512bw. Also need tests to make sure "-mavx512bf16

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

efriedma added subscribers: mgrang, rsmith. efriedma added a comment. I was going to ask if local variables are also supposed to be aligned this way... but I guess there's no way for standard C++ code to tell without explicitly making weird alignment assumptions, so let's not worry about that.

[PATCH] D61271: [clangd][xpc] Fix XPC unittests

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE359489: [clangd][xpc] Fix XPC unittests (authored by jkorous, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra CHANGES SINCE

[clang-tools-extra] r359489 - [clangd][xpc] Fix XPC unittests

Author: jkorous Date: Mon Apr 29 12:41:30 2019 New Revision: 359489 URL: http://llvm.org/viewvc/llvm-project?rev=359489=rev Log: [clangd][xpc] Fix XPC unittests Fix build after recent changes in clangd tests & add xpc unittests to check-clangd target. Differential Revision:

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added a comment. I'd like to see a few more tests to cover the interesting cases that came up during development of this patch: 1. The user-provided constructor issue: there should be testcases with an explicit user-provided constructor, a non-trivial constructor that's explicitly

[PATCH] D61274: [Sema][AST] Explicit visibility for OpenCL/CUDA kernels/variables

scott.linder created this revision. scott.linder added reviewers: Anastasia, tra, yaxunl, rjmccall. Herald added subscribers: cfe-commits, tpr. Herald added a project: clang. For AMDGPU the visibility of these symbols (OpenCL kernels, CUDA `__global__` functions, and CUDA `__device__` variables)

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

RKSimon added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:249 + Identifier->ColumnWidth += Question->ColumnWidth; + Identifier->Type = Identifier->Type; + Tokens.erase(Tokens.end() - 1); @MyDeveloperDay Should this be ``` Identifier->Type =

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ added a comment. In D61051#1481976 , @Charusso wrote: > Great patch! There is only a design problem: > You have negated every `isSmall()` condition looks like you could write > `isLarge()` instead but there is no connection between these functions.

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang added a comment. Thanks @richard.townsend.arm . I have updated the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 197158. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/AST/DeclCXX.h include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

vzakhari added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:176 install( - DIRECTORY ${output_dir} + FILES ${install_files} DESTINATION ${header_install_dir} vzakhari wrote: > This is going to flatten the headers' install directory

  1   2   >