[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1487100 , @erik.pilkington wrote: > It seems like the most common sense interpretation here is to just treat the > initialization of `G` as completed at the point when the constructor finishes > (this appears to be

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

jdoerfert added inline comments. Comment at: lib/Headers/openmp_wrappers/__clang_openmp_math.h:29 + +#define __forceinline__ __attribute__((always_inline)) + I think this is a leftover we forgot to remove. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D61304: [OpenCL][PR41609] Deduce static data members to __global addr space

keryell added a comment. In D61304#1485814 , @Anastasia wrote: > In D61304#1485125 , @rjmccall wrote: > > > Presumably a similar rule would apply to thread-locals if you supported > > them. > > > We don't support

[PATCH] D61418: Another attempt to fix "could not find clang-check" lit warning in analyzer-less builds

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. r359717 added clang-check as a dep of check-clang unconditionally because I had missed lit.local.cfg in test/Tooling. Instead, only add

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek abandoned this revision. phosek added a comment. No longer needed, this was done as part of D60926 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60235/new/ https://reviews.llvm.org/D60235

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 197681. mwyman marked 7 inline comments as done. mwyman added a comment. Updated per review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files:

r359746 - Diagnose non-dependent qualified friend function template declarations

Author: rsmith Date: Wed May 1 17:49:05 2019 New Revision: 359746 URL: http://llvm.org/viewvc/llvm-project?rev=359746=rev Log: Diagnose non-dependent qualified friend function template declarations that don't match any existing declaration. Don't get confused and treat such declarations as

r359747 - Replace ad-hoc tracking of pattern for an instantiated class-scope

Author: rsmith Date: Wed May 1 17:49:14 2019 New Revision: 359747 URL: http://llvm.org/viewvc/llvm-project?rev=359747=rev Log: Replace ad-hoc tracking of pattern for an instantiated class-scope explicit function specialization with the MemberSpecializationInfo used everywhere else. Not NFC: the

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL359744: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI (authored by TomTan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r359744 - [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

Author: tomtan Date: Wed May 1 17:38:14 2019 New Revision: 359744 URL: http://llvm.org/viewvc/llvm-project?rev=359744=rev Log: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI According to alignment section in below ARM64 ABI document, MSVC could increase alignment of global data

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp:16 +#include "llvm/Support/FormatVariadic.h" + +#include Unnecessary empty line. Comment at:

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. In D61165#1485514 , @rjmccall wrote: > Hmm. You know, there's another case where the destructor can be called even > for a non-array: if constructing the object requires a temporary, I believe > an exception thrown from

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

dyung added a comment. In D61187#1486249 , @probinson wrote: > FYI, we had to disable clangd entirely after this patch, getting a weird > problem with lit that we haven't figured out yet. > In case anybody else has seen something like this, and knows

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61225/new/ https://reviews.llvm.org/D61225 ___

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 197660. mwyman marked 6 inline comments as done. mwyman added a comment. Fixes per review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files:

r359740 - Consume unexpected "template" keywords after "using"

Author: rtrieu Date: Wed May 1 16:33:49 2019 New Revision: 359740 URL: http://llvm.org/viewvc/llvm-project?rev=359740=rev Log: Consume unexpected "template" keywords after "using" The parser was dealing with unexpected "template" keywords after "using" keywords too late and putting the parser

r359739 - Revert r359717, "Make check-clang depend on the clang-check binary always"

Author: nico Date: Wed May 1 16:32:38 2019 New Revision: 359739 URL: http://llvm.org/viewvc/llvm-project?rev=359739=rev Log: Revert r359717, "Make check-clang depend on the clang-check binary always" The Tooling tests do have a lit.local.cfg with if not config.root.clang_staticanalyzer:

[PATCH] D61408: Use primary template parameter names for variable template debug info

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems totally reasonable to me & it's what we do for other templates (function and class), it seems. Might want to check alias templates too? Repository: rG LLVM Github Monorepo

[PATCH] D61389: Bump DIAG_SIZE_SEMA up to 4000

sunfish abandoned this revision. sunfish added a comment. Cool :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61389/new/ https://reviews.llvm.org/D61389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

rnk added a comment. Nice, this is way less complicated than we thought originally. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:572 CGF.CGM.EmitExplicitCastExprType(E, ); + return VisitCastExpr(E); Please revert unrelated whitespace changes.

[PATCH] D61408: Use primary template parameter names for variable template debug info

rnk created this revision. rnk added reviewers: JDevlieghere, aprantl, ormris, dblaikie. Herald added a project: clang. Fixes PR41677 Consider: template constexpr bool is_same_v = false; template constexpr bool is_same_v = true; template constexpr bool is_same_v; Before this change,

[PATCH] D61366: [libcxx] [test] Don't assert that moved-from containers with non-POCMA allocators are empty.

BillyONeal updated this revision to Diff 197653. BillyONeal added a comment. Also fixed vector test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61366/new/ https://reviews.llvm.org/D61366 Files: test/std/containers/associative/map/map.cons/move_assign.pass.cpp

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang updated this revision to Diff 197651. akhuang added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61407 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D61104: [clang][ASTContext] Try to avoid sorting comments for code completion

jkorous planned changes to this revision. jkorous added a comment. @gribozavr thanks for the feedback. I'm rewriting the patch now as I figured out my detection of comments preceding declarations is unsound. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 197645. plotfi added a comment. - change "ifso" for intermediate files to "ifo" - Updated schemas. I have both our own proposal and the proposal that resembles elfeabi here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D42642: [CUDA] Detect installation in PATH

Hi, I had my own difficulties with this. It depends on how the repository containing the symlink has been checked-out. For instance: 1. Using a windows git (such as git extensions, mingw-git, git for windows) 2. Using git inside wsl on a drvfs mount (i.e. a windows folder mounted into the Unix

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

jdoerfert added a comment. For the record, this is an implementation of the scheme proposed in https://reviews.llvm.org/D60907#1484756. There are drawbacks, see the TODO, but it will give most people a short term solution until we get OpenMP 5.0 variants. Finally, there is a remote chance this

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm The only remaining change I find questionable is the R600 backend change, but on the whole I think it's fine and you don't need to wait for more review. Better to fix the warnings and people

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

yaxunl added a comment. LGTM too. Thanks Michael for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 197638. gtbercea edited the summary of this revision. gtbercea added a comment. - Minor fixes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files:

r359727 - [analyzer] Fix buildbot failures caused by a forgotten initialization

Author: szelethus Date: Wed May 1 14:09:32 2019 New Revision: 359727 URL: http://llvm.org/viewvc/llvm-project?rev=359727=rev Log: [analyzer] Fix buildbot failures caused by a forgotten initialization Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h Modified:

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea created this revision. gtbercea added reviewers: hfinkel, caomhin, ABataev, tra. Herald added subscribers: cfe-commits, guansong, mgorny. Herald added a project: clang. In this patch we propose a temporary solution to resolving math functions for the NVPTX toolchain, temporary until

[PATCH] D42642: [CUDA] Detect installation in PATH

aganea added a subscriber: rnk. aganea added a comment. So it turns out this is a symlink issue. The file `clang/trunk/test/Driver/Inputs/CUDA-symlinks/usr/bin/ptxas` has been synchronized on my Windows 10 PC as a regular text file, not a symlink. It looks like TortoiseSVN doesn't implement

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. In D61396#1486706 , @tra wrote: > LGTM, but I've added @rsmith who is way more familiar with this code. sure, no rush, let's wait for comments from @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

tra added a comment. LGTM, but I've added @rsmith who is way more familiar with this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added a comment. And with those modifications, everything seems to work correctly. I'd be fine with the LLVM portion landing at this stage, but one more rev and another test cycle for this patch would be ideal. Comment at:

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee added a comment. In D61239#1486634 , @aaron.ballman wrote: > LGTM, thank you! That's strange that clang-format would remove the newline > from the end of the file. I don't get that behavior when I try it, so it > makes me wonder what's

r359722 - Make clang/utils/creduce-clang-crash.py executable

Author: rnk Date: Wed May 1 13:15:39 2019 New Revision: 359722 URL: http://llvm.org/viewvc/llvm-project?rev=359722=rev Log: Make clang/utils/creduce-clang-crash.py executable Modified: cfe/trunk/utils/creduce-clang-crash.py (props changed) Propchange:

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - For template arguments ending with `>>>`, we should cease lookahead and treat it as type-id firstly, so that deduction could work properly. Repository: rG

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rnk added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:919 /// IsX86_MMXType - Return true if this is an MMX type. bool IsX86_MMXType(llvm::Type *IRType) { - // Return true if the type is an MMX type <2 x i32>, <4 x i16>, or <8 x i8>. wxiao3 wrote:

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:9361 // Only consider converting constructors. -if (GD->isExplicit()) +if (!GD->isMaybeNotExplicit()) continue; Tyker wrote: > rsmith wrote: > > Tyker

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

This revision was automatically updated to reflect the committed changes. Closed by commit rL359720: [analyzer] Dont display implementation checkers under -analyzer-checker-help… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r359720 - [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Author: szelethus Date: Wed May 1 12:56:47 2019 New Revision: 359720 URL: http://llvm.org/viewvc/llvm-project?rev=359720=rev Log: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden During my work on analyzer

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! That's strange that clang-format would remove the newline from the end of the file. I don't get that behavior when I try it, so it makes me wonder what's

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61097/new/ https://reviews.llvm.org/D61097 ___ cfe-commits

[PATCH] D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer

kpet updated this revision to Diff 197617. kpet added a comment. Replaced the AST dump test with an IR test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61319/new/ https://reviews.llvm.org/D61319 Files: lib/Sema/SemaOverload.cpp

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1486384 , @compnerd wrote: > @jakehehrlich - unfortunately, removing the attributes on the sections will > make the content look different with `nm` which is something we do need to > appear proper for consumers

[PATCH] D61324: Make check-clang depend on the clang-check binary always

This revision was automatically updated to reflect the committed changes. Closed by commit rL359717: Make check-clang depend on the clang-check binary always (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D61324?vs=197370=197614#toc Repository: rL LLVM

r359717 - Make check-clang depend on the clang-check binary always

Author: nico Date: Wed May 1 12:34:00 2019 New Revision: 359717 URL: http://llvm.org/viewvc/llvm-project?rev=359717=rev Log: Make check-clang depend on the clang-check binary always check-clang (the target that runs all clang tests) used to only depend on clang-check (a binary like clang-tidy,

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Szelethus updated this revision to Diff 197609. Szelethus edited the summary of this revision. Szelethus added a comment. Hide `security.insecureAPI.SecuritySyntaxChecker` by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60925/new/ https://reviews.llvm.org/D60925 Files:

[PATCH] D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times.

This revision was automatically updated to reflect the committed changes. Closed by commit rL359713: [Parser] Avoid correcting delayed typos in array subscript multiple times. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Rakete added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2579 +assert( +!ES.getExpr() || +CXXConstructorDeclBits.HasTrailingExplicitSpecifier && Tyker wrote: > Rakete wrote: > > Your or needs parens or the

r359713 - [Parser] Avoid correcting delayed typos in array subscript multiple times.

Author: vsapsai Date: Wed May 1 12:24:50 2019 New Revision: 359713 URL: http://llvm.org/viewvc/llvm-project?rev=359713=rev Log: [Parser] Avoid correcting delayed typos in array subscript multiple times. We correct some typos in `ActOnArraySubscriptExpr` and `ActOnOMPArraySectionExpr`, so when

[PATCH] D61389: Bump DIAG_SIZE_SEMA up to 4000

riccibruno added a comment. Already done in r359702 :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61389/new/ https://reviews.llvm.org/D61389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61392: [clang] Handle lround/llround builtins

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Looks fine, once the LLVM changes are settled. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61392/new/ https://reviews.llvm.org/D61392

[PATCH] D61392: [clang] Handle lround/llround builtins

zatrazz created this revision. zatrazz added reviewers: efriedma, rengolin, javed.absar, huntergr, SjoerdMeijer, t.p.northover, echristo, evandro. zatrazz added a project: clang. Herald added subscribers: kristina, kristof.beyls. As for other floating-point rounding builtins that can be

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added a comment. Ping! Is this good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r359711 - [clang-format] Fix a bug in AlignConsecutiveDeclarations.

Author: owenpan Date: Wed May 1 11:23:44 2019 New Revision: 359711 URL: http://llvm.org/viewvc/llvm-project?rev=359711=rev Log: [clang-format] Fix a bug in AlignConsecutiveDeclarations. Fixes PR37175 Differential Revision: https://reviews.llvm.org/D61222 Modified:

[PATCH] D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL359711: [clang-format] Fix a bug in AlignConsecutiveDeclarations. (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58321: Support for relative vtables

pcc added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:531 +/// \brief Whether the class uses the relative C++ vtable ABI. +unsigned IsRelativeCXXABI : 1; + rjmccall wrote: > Should we proactively generalize this as a "CXXABIVariant"

[PATCH] D61324: Make check-clang depend on the clang-check binary always

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61324/new/ https://reviews.llvm.org/D61324 ___ cfe-commits mailing list

[PATCH] D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations

owenpan updated this revision to Diff 197566. owenpan added a comment. Removed a redundant test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61222/new/ https://reviews.llvm.org/D61222 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:51 + DiagnosticBuilder Diag = diag(RootLoc, Message); + for (const tooling::Transformation : *Transformations) { +Diag <<

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 197597. ymandel marked an inline comment as done. ymandel added a comment. reinstated an auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files:

[PATCH] D58321: Support for relative vtables

rjmccall added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:531 +/// \brief Whether the class uses the relative C++ vtable ABI. +unsigned IsRelativeCXXABI : 1; + Should we proactively generalize this as a "CXXABIVariant" enum, which for

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:51 + DiagnosticBuilder Diag = diag(RootLoc, Message); + for (const tooling::Transformation : *Transformations) { +Diag << FixItHint::CreateReplacement(T.Range,

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:22 + // Verify the existence and validity of the AST node that roots this rule. + auto = Result.Nodes.getMap(); + auto Root =

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 197589. ymandel added a comment. Reduced use of auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files: clang-tools-extra/clang-tidy/utils/CMakeLists.txt

[PATCH] D58321: Support for relative vtables

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61389: Bump DIAG_SIZE_SEMA up to 4000

sunfish created this revision. sunfish added a reviewer: aaron.ballman. Herald added a subscriber: aheejin. Herald added a project: clang. https://reviews.llvm.org/D59520 adds a few new diagnostics, which happens to run into a limit with DIAG_SIZE_SEMA. As suggested here

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. @jakehehrlich - unfortunately, removing the attributes on the sections will make the content look different with `nm` which is something we do need to appear proper for consumers of the interface libraries. Versioning has a number of problems inherent to it

[PATCH] D61318: [Sema] Prevent binding references with mismatching address spaces to temporaries

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4836 + if (T1Quals.hasAddressSpace()) { +if (!T1Quals.isAddressSpaceSupersetOf(cv1T1IgnoreAS.getQualifiers())) { + Sequence.SetFailed( Anastasia wrote: > rjmccall wrote: > > Isn't

[PATCH] D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer

kpet added a comment. Ok, I'll replace the test with an IR-level test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61319/new/ https://reviews.llvm.org/D61319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61304: [OpenCL][PR41609] Deduce static data members to __global addr space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. This seems reasonable to me, then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61304/new/ https://reviews.llvm.org/D61304

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197583. JornVernee marked 3 inline comments as done. JornVernee added a comment. Removed spurious newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 Files: test/Index/print-type-size.c

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:22 + // Verify the existence and validity of the AST node that roots this rule. + auto = Result.Nodes.getMap(); + auto Root = NodesMap.find(tooling::RewriteRule::RootId);

[PATCH] D61383: [Driver] Explicitly request platform rtlib in the Driver pic test

This revision was automatically updated to reflect the committed changes. Closed by commit rL359706: [Driver] Explicitly request platform rtlib in the Driver pic test (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r359706 - [Driver] Explicitly request platform rtlib in the Driver pic test

Author: phosek Date: Wed May 1 09:52:45 2019 New Revision: 359706 URL: http://llvm.org/viewvc/llvm-project?rev=359706=rev Log: [Driver] Explicitly request platform rtlib in the Driver pic test This test checks whether crtbegin.o and crtend.o appear on the link line, but names of these files may

r359702 - Bump DIAG_SIZE_SEMA, as we've hit it.

Author: scott.linder Date: Wed May 1 09:45:49 2019 New Revision: 359702 URL: http://llvm.org/viewvc/llvm-project?rev=359702=rev Log: Bump DIAG_SIZE_SEMA, as we've hit it. $ grep 'DIAG_SIZE_SEMA =' include/clang/Basic/DiagnosticIDs.h DIAG_SIZE_SEMA = 4000, $ grep DIAG

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel created this revision. ymandel added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This revision introduces an adaptor from Transformer's rewrite rules (`clang::tooling::RewriteRule`) to `ClangTidyCheck`. For example,

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

scott.linder updated this revision to Diff 197570. scott.linder added a comment. Use distinct sema diagnostic and do not return early. I am going to bump `DIAG_SIZE_SEMA` in another patch, as it seems like we have hit the current limit. CHANGES SINCE LAST ACTION

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

probinson added a comment. FYI, we had to disable clangd entirely after this patch, getting a weird problem with lit that we haven't figured out yet. In case anybody else has seen something like this, and knows what's going on, please let us know. Running all regression tests

[PATCH] D61383: [Driver] Explicitly request platform rtlib in the Driver pic test

phosek created this revision. phosek added a reviewer: juliehockett. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test checks whether crtbegin.o and crtend.o appear on the link line, but names of these files may be affected by the choice of the rtlib, specifically

r359692 - [analyzer][tests][NFC] Add EOF newlines, normalize reference expected files

Author: hubert.reinterpretcast Date: Wed May 1 08:57:00 2019 New Revision: 359692 URL: http://llvm.org/viewvc/llvm-project?rev=359692=rev Log: [analyzer][tests][NFC] Add EOF newlines, normalize reference expected files Reference expected files not ending with a newline are normalized to have

r359691 - [analyzer][tests] Use diff_plist, correct order of arguments for missed cases; NFC

Author: hubert.reinterpretcast Date: Wed May 1 08:53:56 2019 New Revision: 359691 URL: http://llvm.org/viewvc/llvm-project?rev=359691=rev Log: [analyzer][tests] Use diff_plist, correct order of arguments for missed cases; NFC For various files under `clang/test/Analysis`, D52036 applied

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added a comment. In case anyone else runs into this: When doing incremental builds, the old ClangdTests binary stays around in `./tools/clang/tools/unittests/clangd` and is still run by `check-clang-tools`. In case you don't want that (it makes the old test target slower; or maybe your

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197557. JornVernee marked an inline comment as done. JornVernee added a comment. - Removed const& QualType and passing by-value instead - Ran print-type-size.c through clang-format FWIW, clang-format was removing the newline at the end of the file, so I

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

owenpan added a comment. @MyDeveloperDay In theory, any whitespace character other than a blank might trigger the bug, but in practice, we only need to handle the tab, IMO. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276

[PATCH] D61297: [clang-format] Fix bug that misses some function-like macro usages

This revision was automatically updated to reflect the committed changes. Closed by commit rL359687: [clang-format] Fix bug that misses some function-like macro usages (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r359687 - [clang-format] Fix bug that misses some function-like macro usages

Author: owenpan Date: Wed May 1 08:03:41 2019 New Revision: 359687 URL: http://llvm.org/viewvc/llvm-project?rev=359687=rev Log: [clang-format] Fix bug that misses some function-like macro usages Fixes PR41483 Differential Revision: https://reviews.llvm.org/D61297 Modified:

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

aaron.ballman added inline comments. Comment at: test/Index/print-type-size.c:6 + // CHECK: FieldDecl=size:4:7 (Definition) [type=int] [typekind=Int] [sizeof=4] [alignof=4] [offsetof=0] + void* data[]; + // CHECK: FieldDecl=data:6:9 (Definition) [type=void *[]]

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197543. JornVernee marked an inline comment as done. JornVernee added a comment. - Replaced plane predicates with helper methods describing their function. - Fixed test file indentation Changing the logic for `clang_Type_getAlignOf` was not needed after

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

aaron.ballman added a comment. In D61288#1486034 , @xbolva00 wrote: > I am not familiar with clang-tidy’s codebase and I personally prefer good > compiler warnings than dependency on another tool (clang-tidy). I mean the > cases when diagnostic check is

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee marked 4 inline comments as done. JornVernee added a comment. In D61239#1486005 , @aaron.ballman wrote: > In D61239#1485994 , @JornVernee > wrote: > > > - holding of on adding helper method until

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 added a comment. I am not familiar with clang-tidy’s codebase and I personally prefer good compiler warnings than dependency on another tool (clang-tidy). I mean the cases when diagnostic check is easy to do in the compiler. And in semaexpr we have all we need and it is simple to do

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

lebedev.ri added a comment. In D61288#1486008 , @aaron.ballman wrote: > In D61288#1486006 , @xbolva00 wrote: > > > Some coding guidelines may require switch to have always default label. > > Even if devs know

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

aaron.ballman added a comment. In D61288#1486006 , @xbolva00 wrote: > Some coding guidelines may require switch to have always default label. Even > if devs know that default is not reachable, they can add default: abort(); or > assert to increase

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 added a comment. Some coding guidelines may require switch to have always default label. Even if devs know that default is not reachable, they can add default: abort(); or assert to increase safety (and warning will be silenced). Yes, it not suitable to be enabled by default, but I

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

aaron.ballman added a comment. In D61239#1485994 , @JornVernee wrote: > - holding of on adding helper method until hearing back. My rationale for wanting a helper method is because we already have two places were incompleteness is important but has

  1   2   >