[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

kimgr added a comment. Also, consider `././Inputs/empty.h`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

kimgr added a comment. I was thinking about a testcase like: // RUN: %clang -H -fsyntax-only %s 2>&1 | FileCheck %s #include "..\Index\Inputs\empty.h" #include ".\Inputs\empty.h" // CHECK: . // CHECK-SAME: ??? // CHECK: . // CHECK-NOT: ??? // CHECK-SAME: ??? with some

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song updated this revision to Diff 200639. yonghong-song retitled this revision from "[BPF] Preserve debuginfo array/union/struct type name/access index" to "[BPF] Preserve debuginfo array/union/struct type/access index". yonghong-song edited the summary of this revision. yonghong-song

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 200637. yaqiji edited the summary of this revision. yaqiji added a comment. Removed other mdodified file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 

stephanemoore planned changes to this revision. stephanemoore added a comment. > Out of curiosity, how invasive is Option 2 within our own code base? I am still working on getting something working but I don't anticipate anything notably invasive. > Does that option require fixing a lot of

[PATCH] D62232: [Clang][Driver] recheck for nullptr

nickdesaulniers created this revision. nickdesaulniers added reviewers: rsmith, sfantao. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was flagged in https://www.viva64.com/en/b/0629/ under "Snippet No. 47". Looks like TC is checked for nullptr once, but not the

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan marked an inline comment as done. skan added inline comments. Comment at: lib/Frontend/HeaderIncludeGen.cpp:55 + // Simplify Filename that starts with "./" + if (Filename.startswith("./")); +Filename=Filename.substr(2); lebedev.ri wrote: > skan wrote:

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan updated this revision to Diff 200634. skan added a comment. add a test for including headfile outside current directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 Files: lib/Frontend/HeaderIncludeGen.cpp

[PATCH] D62230: [CGDebugInfo] return early on failed dyn_cast

nickdesaulniers added a comment. Also of note is that no existing test covers this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62230/new/ https://reviews.llvm.org/D62230 ___ cfe-commits

[PATCH] D62230: [CGDebugInfo] return early on failed dyn_cast

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers added a comment. Also of note is that no existing test covers this case. This was flagged in https://www.viva64.com/en/b/0629/

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt marked an inline comment as done. trixirt added inline comments. Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:30 +} +std::string BugproneHeaderGuardCheck::getHeaderGuard(StringRef Filename, + StringRef OldGuard)

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 200630. trixirt added a comment. Add a newline to separate functions Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61508/new/ https://reviews.llvm.org/D61508 Files: clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D62202: Work around a Visual C++ bug

probinson added a comment. // FIXME: Change the following functions from anonymous namespace to static // after the minimum _MSC_VER >= 1915 (equivalent to Visual Studio version // of 15.8 or higher). Works around a bug in earlier versions. ? Also happy to include the hyperlink to the

[PATCH] D62045: Do not emit fixes for extern global constants in google-objc-global-variable-declaration check.

stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed. Many thanks for being patient with me  I think there are just two more things ✌️ ❧ Sorry, I think my earlier description was understated. Maybe this would be a

Re: r361278 - [clang][Darwin] Refactor header search path logic into the driver

Hello Louis, This commit broke few tests on the next builder: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/17776 Please have a look ASAP? . . . Failing Tests (4): Clang :: Driver/darwin-header-search-libcxx.cpp Clang ::

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/ https://reviews.llvm.org/D55463 ___ cfe-commits mailing list

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361344: [clang-tidy] remove default header-filter for run-clang-tidy (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D61747?vs=198877=200620#toc Repository:

[clang-tools-extra] r361344 - [clang-tidy] remove default header-filter for run-clang-tidy

Author: dhinton Date: Tue May 21 18:01:11 2019 New Revision: 361344 URL: http://llvm.org/viewvc/llvm-project?rev=361344=rev Log: [clang-tidy] remove default header-filter for run-clang-tidy Summary: run-clang-tidy.py was enforcing '-header-filter' parameter with an unfortunate default value when

[PATCH] D62138: [Docs] Increase Doxygen cache size

This revision was automatically updated to reflect the committed changes. Closed by commit rC361343: [Docs] Increase Doxygen cache size (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62138?vs=200261=200617#toc Repository: rC Clang CHANGES SINCE

r361343 - [Docs] Increase Doxygen cache size

Author: dhinton Date: Tue May 21 17:56:42 2019 New Revision: 361343 URL: http://llvm.org/viewvc/llvm-project?rev=361343=rev Log: [Docs] Increase Doxygen cache size Summary: When building Doxygen docs for llvm and clang, it helpfully prints a warning at the end noting that the `LOOKUP_CACHE_SIZE`

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rC361340: [Analysis] Link library dependencies to Analysis plugins (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62174?vs=200405=200615#toc Repository: rC

r361340 - [Analysis] Link library dependencies to Analysis plugins

Author: phosek Date: Tue May 21 17:47:37 2019 New Revision: 361340 URL: http://llvm.org/viewvc/llvm-project?rev=361340=rev Log: [Analysis] Link library dependencies to Analysis plugins These are needed to avoid undefined symbols which aren't satisfied by Clang itself. Differential Revision:

RE: r361278 - [clang][Darwin] Refactor header search path logic into the driver

Hi Louis, The three tests you added all seem to be failing when run on Windows. I suspect the reason is because you define TOOLCHAIN as an argument to FileCheck, which causes the line separators to be escaped, which then causes the FileCheck to fail. For example, see this test output

[PATCH] D62045: Do not emit fixes for extern global constants in google-objc-global-variable-declaration check.

yaqiji updated this revision to Diff 200614. yaqiji added a comment. Removed extra space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt

[PATCH] D62045: Do not emit fixes for extern global constants in google-objc-global-variable-declaration check.

yaqiji updated this revision to Diff 200613. yaqiji marked 4 inline comments as done. yaqiji added a comment. Restored fix. Added test case for extern Cap+Number prefixes. Restored reformatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

rsmith added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1753-1758 +// Describes whether the current context is a context where an implicit +// typename is allowed (C++2a [temp.res]p5]). +enum ImplicitTypenameContext { + ITC_Never, + ITC_Yes, +};

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

echristo added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105 // which is just that always inlining occurs. - MPM.addPass(AlwaysInlinerPass()); + // We always pass false here since according to the legacy PM logic for + // enabling

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

eugenis added inline comments. Comment at: compiler-rt/lib/gwp_asan/platform_specific/mutex_posix.cpp:43 + +Mutex::Mutex() : PImpl(new Impl) {} +Mutex::~Mutex() { delete PImpl; } This is a dependency on libc++ / libstdc++. I'm not sure about using malloc()

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed. Almost there. I think everything looks good after we resolve this last round of comments. Can you also update the commit description. I believe that the current

[PATCH] D61643: [PragmaHandler] Expose `#pragma` location

This revision was automatically updated to reflect the committed changes. Closed by commit rC361335: [PragmaHandler] Expose `#pragma` location (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D61643?vs=198489=200608#toc Repository: rC Clang CHANGES

[PATCH] D61643: [PragmaHandler] Expose `#pragma` location

jdenny added a comment. In D61643#1510815 , @Meinersbur wrote: > +1 > > Such a solution also came up in https://bugs.llvm.org/show_bug.cgi?id=41514#c1 Cool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r361335 - [PragmaHandler] Expose `#pragma` location

Author: jdenny Date: Tue May 21 16:51:38 2019 New Revision: 361335 URL: http://llvm.org/viewvc/llvm-project?rev=361335=rev Log: [PragmaHandler] Expose `#pragma` location Currently, a pragma AST node's recorded location starts at the namespace token (such as `omp` in the case of OpenMP) after the

r361334 - Fix target property to make BUILD_SHARED_LIBS work

Author: cbieneman Date: Tue May 21 16:50:15 2019 New Revision: 361334 URL: http://llvm.org/viewvc/llvm-project?rev=361334=rev Log: Fix target property to make BUILD_SHARED_LIBS work Public and Private link libraries get merged in the LINK_LIBRARIES property instead of being kept separate. With

[PATCH] D62116: [Sema] raise nullptr check to cover additional uses

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:557-558 +dyn_cast_or_null(ND->getDeclContext()); +CXXThisScopeRAII ThisScope(*this, ThisContext, Qualifiers(), +

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan created this revision. leonardchan added reviewers: chandlerc, echristo, phosek, serge-sans-paille. leonardchan added a project: clang. Herald added subscribers: kristof.beyls, javed.absar. This is a patch that should go on top of D58375 which

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. In D61909#1510975 , @E5ten wrote: > @beanz But if libclang_shared is intended to be a shippable binary and > BUILD_SHARED_LIBS is only intended to be an option used in developer builds, > and libclang_shared while not causing

r361328 - Refactor: split Uninitialized state on APValue into an "Absent" state

Author: rsmith Date: Tue May 21 16:15:18 2019 New Revision: 361328 URL: http://llvm.org/viewvc/llvm-project?rev=361328=rev Log: Refactor: split Uninitialized state on APValue into an "Absent" state representing no such object, and an "Indeterminate" state representing an uninitialized object. The

r361329 - [c++20] P1330R0: permit simple-assignments that change the active member

Author: rsmith Date: Tue May 21 16:15:20 2019 New Revision: 361329 URL: http://llvm.org/viewvc/llvm-project?rev=361329=rev Log: [c++20] P1330R0: permit simple-assignments that change the active member of a union within constant expression evaluation. Modified:

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200604. hctim marked an inline comment as done. hctim added a comment. - Updated to use pointer-to-impl to abstract implementation behaviour away from header files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200602. plotfi added a comment. fixing support for static functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang marked an inline comment as done. akhuang added a subscriber: dblaikie. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( +

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

eugenis added inline comments. Comment at: compiler-rt/lib/gwp_asan/mutex.h:27 +private: +#include "gwp_asan/platform_specific/mutex_members.inc" +}; What's the point of this include? You are leaking platform details into this common header anyway. We can make

r361325 - Rename identifiers to spell out analyze; NFC.

Author: aaronballman Date: Tue May 21 15:43:48 2019 New Revision: 361325 URL: http://llvm.org/viewvc/llvm-project?rev=361325=rev Log: Rename identifiers to spell out analyze; NFC. Modified: cfe/trunk/test/SemaCXX/attr-no-sanitize-address.cpp

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200600. hctim added a comment. Changed GWP-ASan to use platform specific mutexes. For now, we only target Android and Linux, and subsequently only need the pthread_mutex variant for POSIX. Kept around the mutex unittests as it's an easy assertion that the

[PATCH] D61909: Add Clang shared library with C++ exports

E5ten added a comment. @beanz But if libclang_shared is intended to be a shippable binary and BUILD_SHARED_LIBS is only intended to be an option used in developer builds, and libclang_shared while not causing conflicts (thanks for the info on how that works by the way) would be redundant in a

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. In D61909#1510955 , @E5ten wrote: > @beanz Well I took libclang_shared as effectively an equivalent to the > libLLVM.so that's created with that dylib option, and when BUILD_SHARED_LIBS > is enabled that library is not created, in

[PATCH] D61909: Add Clang shared library with C++ exports

E5ten added a comment. @beanz Well I took libclang_shared as effectively an equivalent to the libLLVM.so that's created with that dylib option, and when BUILD_SHARED_LIBS is enabled that library is not created, in fact the option to create that library conflicts with BUILD_SHARED_LIBS. Also

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin added a comment. I see. LGTM either way  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62047/new/ https://reviews.llvm.org/D62047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57930: [Driver] Verify GCCInstallation is valid

This revision was automatically updated to reflect the committed changes. Closed by commit rC361314: [Driver] Verify GCCInstallation is valid (authored by nickdesaulniers, committed by ). Changed prior to commit: https://reviews.llvm.org/D57930?vs=200580=200586#toc Repository: rC Clang

r361314 - [Driver] Verify GCCInstallation is valid

Author: nickdesaulniers Date: Tue May 21 14:21:35 2019 New Revision: 361314 URL: http://llvm.org/viewvc/llvm-project?rev=361314=rev Log: [Driver] Verify GCCInstallation is valid Summary: Values returned by GCCInstallation.getParentLibPath() and GCCInstallation.getTriple() are not valid unless

Re: [PATCH] D61909: Add Clang shared library with C++ exports

I don't want building libclang_shared to be disabled when `BUILD_SHARED_LIBS=On`. libclang_shared fulfills a completely different purpose from `BUILD_SHARED_LIBS`. -Chris > On May 21, 2019, at 12:20 PM, Ethan Sommer via Phabricator > wrote: > > E5ten added a comment. > > @beanz Wouldn't

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

beanz added a comment. Adding "libcxxabi" to `LLVM_ENABLE_RUNTIMES` is fine, but the other changes to the DistributionExample are only needed because you chose to use gold, which is a configuration-specific decision that is not representative of how most people will build, therefore it

[PATCH] D59841: [Gnu Driver] Let -static-pie win if it is specified along with -pie or -static.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361312: Let -static-pie win if it is specified along with -pie or -static. (authored by sivachandra, committed by ). Changed prior to commit: https://reviews.llvm.org/D59841?vs=200577=200584#toc

r361312 - Let -static-pie win if it is specified along with -pie or -static.

Author: sivachandra Date: Tue May 21 14:09:05 2019 New Revision: 361312 URL: http://llvm.org/viewvc/llvm-project?rev=361312=rev Log: Let -static-pie win if it is specified along with -pie or -static. Also, disallow specifying -no-pie/-nopie along with -static-pie. Differential Revision:

[PATCH] D57930: [Driver] Verify GCCInstallation is valid

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks for picking this up and finishing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57930/new/ https://reviews.llvm.org/D57930

[PATCH] D57930: [Driver] Verify GCCInstallation is valid

nickdesaulniers updated this revision to Diff 200580. nickdesaulniers added a comment. Herald added a subscriber: ormris. - add unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57930/new/ https://reviews.llvm.org/D57930 Files:

[PATCH] D62214: Remove extra if case.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Testing offline showed that it was impossible to reach the return with a real global variable with an enumeration type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62167: CodeView - add static data members to global variable debug info.

rnk added a comment. This needs a clang-side test to show that clang generates the expected IR for static data members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/ https://reviews.llvm.org/D62167

[PATCH] D59841: [Gnu Driver] Let -static-pie win if it is specified along with -pie or -static.

sivachandra marked an inline comment as done. sivachandra added a comment. PTAL Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || - Args.hasArg(options::OPT_r)) +

[PATCH] D59841: [Gnu Driver] Let -static-pie win if it is specified along with -pie or -static.

sivachandra updated this revision to Diff 200577. sivachandra added a comment. Let -static-pie win if specified along with -pie or -static. Also, treat specifying -nopie/-no-pie along with -static-pie as an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: r361278 - [clang][Darwin] Refactor header search path logic into the driver

Awesome! But... this resulted in two test failures for me. I've fixed them in r361301, can you check that's correct? On Tue, 21 May 2019 at 10:45, Louis Dionne via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ldionne > Date: Tue May 21 10:48:04 2019 > New Revision: 361278 > > URL:

r361302 - Remove unicode character from test

Author: leonardchan Date: Tue May 21 13:12:00 2019 New Revision: 361302 URL: http://llvm.org/viewvc/llvm-project?rev=361302=rev Log: Remove unicode character from test Modified: cfe/trunk/test/SemaObjC/nullability_macro.m Modified: cfe/trunk/test/SemaObjC/nullability_macro.m URL:

r361301 - Fix test failures after r361278 on non-Darwin platforms and when

Author: rsmith Date: Tue May 21 13:10:52 2019 New Revision: 361301 URL: http://llvm.org/viewvc/llvm-project?rev=361301=rev Log: Fix test failures after r361278 on non-Darwin platforms and when CLANG_DEFAULT_STDLIB is defined to libstdc++. Modified:

r361300 - [c++20] P0780R2: Support pack-expansion of init-captures.

Author: rsmith Date: Tue May 21 13:10:50 2019 New Revision: 361300 URL: http://llvm.org/viewvc/llvm-project?rev=361300=rev Log: [c++20] P0780R2: Support pack-expansion of init-captures. This permits an init-capture to introduce a new pack: template auto x = [...a = T()] { /* a is a pack */ };

[PATCH] D57930: [Driver] Verify GCCInstallation is valid

nickdesaulniers added a comment. @danielmentz thanks for this patch! Some teammates are running into issues that would be fixed by this patch. I think @srhines is asking for a test similar to what I wrote in r344941

[PATCH] D62202: Work around a Visual C++ bug

dblaikie added a comment. In D62202#1510835 , @rnk wrote: > In D62202#1510522 , @dblaikie wrote: > > > Yeah, if we're going this way I'd certainly advocate having a comment of > > some kind explaining why it's

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

winksaville added a comment. This may not "correct" but I had to do these to get `ninja stage2-distribution` to complete on my computer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62215/new/ https://reviews.llvm.org/D62215

[PATCH] D62200: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs-profile-generate

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62200/new/ https://reviews.llvm.org/D62200 ___

[PATCH] D62202: Work around a Visual C++ bug

rnk added a comment. In D62202#1510522 , @dblaikie wrote: > Yeah, if we're going this way I'd certainly advocate having a comment of some > kind explaining why it's this way so it doesn't regress. In the past, I've found these sorts of comments to be

[PATCH] D62202: Work around a Visual C++ bug

rnk added a comment. I'd go ahead and commit the workaround, even if it goes against the style guide. This problem will go away in two years or so. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62202/new/ https://reviews.llvm.org/D62202

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61643: [PragmaHandler] Expose `#pragma` location

Meinersbur added a comment. +1 Such a solution also came up in https://bugs.llvm.org/show_bug.cgi?id=41514#c1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61643/new/ https://reviews.llvm.org/D61643

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

winksaville created this revision. winksaville added a reviewer: beanz. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Add runtime libcxxabi, use gold linker and create LLVMgold.so. Tested with on monorepo with: mkdir build && cd build && \

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rL361298: [OpenMP] Add support for registering requires directives with the runtime (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

r361298 - [OpenMP] Add support for registering requires directives with the runtime

Author: gbercea Date: Tue May 21 12:42:01 2019 New Revision: 361298 URL: http://llvm.org/viewvc/llvm-project?rev=361298=rev Log: [OpenMP] Add support for registering requires directives with the runtime Summary: This patch adds support for the registration of the requires directives with the

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

This revision was automatically updated to reflect the committed changes. Closed by commit rC361296: [DebugInfo] Dont emit checksums when compiling a preprocessed CPP (authored by aganea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/

r361296 - [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

Author: aganea Date: Tue May 21 12:40:28 2019 New Revision: 361296 URL: http://llvm.org/viewvc/llvm-project?rev=361296=rev Log: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP Fixes PR41215 Differential Revision: https://reviews.llvm.org/D60283 Added:

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7951 + // they don't have to write out memcpy() for simple cases. For that reason, + // it's very limited in what it will detect. + // We don't always lower struct copies to memcpy();

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

efriedma added a comment. We don't necessarily need to block the clang changes on the backend error reporting actually being implemented, I guess, if the architecture we want is settled. With this patch, do we pass the general-regs-only attribute to the backend? If so, would that be the

[PATCH] D61909: Add Clang shared library with C++ exports

E5ten added a comment. @beanz Wouldn't fixing this by adding OR BUILD_SHARED_LIBS to if(ARG_SHARED) in AddClang.cmake and to if (NOT LLVM_ENABLE_PIC) in clang-shlib/CMakeLists.txt to prevent making libclang_shared when BUILD_SHARED_LIBS is enabled make more sense? Repository: rC Clang

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel added a comment. In D61386#1510690 , @MyDeveloperDay wrote: > Just a passing comment, Is this: > > a) a different type of check that would be used for a different type of check > than previous clang-tidy checks > b) or is this a replacement on

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Oh, I see, ABIInfo::computeInfo() uses the canonical type to compute the calling convention, and that throws away alignment attributes because alignment attributes on non-struct are

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:52 + +void e() { + int pipefd[2]; srhines wrote: > I'm not all that familiar with writing clang-tidy-specific tests,

[PATCH] D62201: [LibTooling] Address post-commit feedback for r361152

This revision was automatically updated to reflect the committed changes. Closed by commit rC361285: [LibTooling] Address post-commit feedback for r361152 (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D62201?vs=200514=200559#toc Repository: rC Clang

[PATCH] D62214: Remove extra if case.

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62214 Files: clang/lib/CodeGen/CGDebugInfo.cpp Index: clang/lib/CodeGen/CGDebugInfo.cpp

r361285 - [LibTooling] Address post-commit feedback for r361152

Author: ymandel Date: Tue May 21 11:48:58 2019 New Revision: 361285 URL: http://llvm.org/viewvc/llvm-project?rev=361285=rev Log: [LibTooling] Address post-commit feedback for r361152 Fixes a redundant dependency and moves another to its proper place. Reviewers: thakis Subscribers: mgorny,

[PATCH] D62201: [LibTooling] Adjust dependencies for unittests.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Maybe say "address post-commit feedback for r" in the description. (But as-is is fine too.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62202: Work around a Visual C++ bug

probinson added a comment. The helper is passed as a template parameter to a class ctor, and that instantiated class calls the helper from operator(), so I suppose maybe enough indirection through lambdas but this seems kind of involved for getting my builds to work. Repository: rC

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

srhines added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:52 + +void e() { + int pipefd[2]; I'm not all that familiar with writing clang-tidy-specific tests, but should these tests here denote that a diagnostic

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

MyDeveloperDay added a comment. Just a passing comment, Is this: a) a different type of check that would be used for a different type of check than previous clang-tidy checks b) or is this a replacement on the previous style? Is there any documentation about the benefits of this method vs the

r361283 - [OPENMP]Use the attributes for dso locality when building for device.

Author: abataev Date: Tue May 21 11:20:08 2019 New Revision: 361283 URL: http://llvm.org/viewvc/llvm-project?rev=361283=rev Log: [OPENMP]Use the attributes for dso locality when building for device. Currently, we ignore all dso locality attributes/info when building for the device and thus all

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Couple more nitpicks, but otherwise good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4468 } +static void analyzeParametersModification( /// Analyzes each function parameter to determine whether it is constant throughout the function body. Comment at:

[PATCH] D58033: Add option for emitting dbg info for call site parameters

aprantl accepted this revision. aprantl added a comment. LGTM, with an additional testcase. Comment at: test/CodeGenCXX/dbg-info-all-calls-described.cpp:23 +// RUN: | FileCheck %s -check-prefix=HAS-ATTR \ +// RUN: -implicit-check-not=DIFlagAllCallsDescribed +

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 200547. jcai19 added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files: clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/android-cloexec-pipe2.rst:19 + + pipe2(pipefd, O_CLOEXEC); srhines wrote: > Shouldn't this be "O_NONBLOCK | O_CLOEXEC" instead? Why drop

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

tlively added a comment. In D62047#1505878 , @aheejin wrote: > How about using `multi_value`/`multi-value`/`MultiValue`/`MULTI-VALUE` > (depending on positions)? The repo name is also multi-value. > https://github.com/WebAssembly/multi-value >

[PATCH] D61963: [clang][Darwin] Refactor header search path logic into the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rC361278: [clang][Darwin] Refactor header search path logic into the driver (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D61963?vs=200311=200539#toc

r361278 - [clang][Darwin] Refactor header search path logic into the driver

Author: ldionne Date: Tue May 21 10:48:04 2019 New Revision: 361278 URL: http://llvm.org/viewvc/llvm-project?rev=361278=rev Log: [clang][Darwin] Refactor header search path logic into the driver Summary: This commit moves the logic for determining system, resource and C++ header search paths

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 4 inline comments as done. ymandel added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___ cfe-commits

  1   2   >