[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

ed accepted this revision. ed added a comment. This revision is now accepted and ready to land. The patch looks pretty good as far as I can see. That said, I've been out of the loop for quite a while, so do take my approval with a grain of salt. Thanks for working on this! \o/ Repository:

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361601: [clang-tidy] Add option LiteralInitializers to cppcoreguidelines-pro-type… (authored by mgehre, committed by ).

[clang-tools-extra] r361601 - [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

Author: mgehre Date: Thu May 23 22:46:57 2019 New Revision: 361601 URL: http://llvm.org/viewvc/llvm-project?rev=361601=rev Log: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init Differential Revision: D24892 Added:

[PATCH] D60162: [ThinLTO] Add module flags for TargetLibraryInfoImpl and use in LTO backends

tejohnson abandoned this revision. tejohnson added a comment. As per D61634 , we are going to use function attributes instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60162/new/

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. In D61634#1512020 , @gchatelet wrote: > AFAIU here is a coarse plan of what needs to happen > > 1. Add a `no-builtin` clang function attribute that has the same semantic as > the `no-builtin` cmd line argument >

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361598: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on… (authored by ikudrin, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

r361598 - Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

Author: ikudrin Date: Thu May 23 21:46:22 2019 New Revision: 361598 URL: http://llvm.org/viewvc/llvm-project?rev=361598=rev Log: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows. If the source file path contains directory junctions, and we resolve them when

r361592 - [analyzer] NFC: Prevent multi-file plist test from spamming up the build folder.

Author: dergachev Date: Thu May 23 19:29:18 2019 New Revision: 361592 URL: http://llvm.org/viewvc/llvm-project?rev=361592=rev Log: [analyzer] NFC: Prevent multi-file plist test from spamming up the build folder. It was producing an HTML report with a random name on every tests run and never

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 6 inline comments as done. jkorous added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:131 + // the async event handling picks them up. Can make this test flaky. +

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 201114. jkorous added a comment. Reimplemented tests with std::futures which allowed to use more generous timeout while not slowing down the happy paths. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418

[PATCH] D61815: [CFG] NFC: Modernize test/Analysis/initializers-cfg-output.cpp.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361587: [CFG] NFC: Modernize a test file for constructor initializer CFGs. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61815?vs=199118=201113#toc

[PATCH] D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361586: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r361587 - [CFG] NFC: Modernize a test file for constructor initializer CFGs.

Author: dergachev Date: Thu May 23 18:34:26 2019 New Revision: 361587 URL: http://llvm.org/viewvc/llvm-project?rev=361587=rev Log: [CFG] NFC: Modernize a test file for constructor initializer CFGs. Move FileCheck directives around so that it was easy to understand what tests what and what effect

r361588 - Factor out repeated code to build 'this' expressions and mark them

Author: rsmith Date: Thu May 23 18:35:07 2019 New Revision: 361588 URL: http://llvm.org/viewvc/llvm-project?rev=361588=rev Log: Factor out repeated code to build 'this' expressions and mark them referenced. Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Sema/SemaExprCXX.cpp

r361586 - [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *.

Author: dergachev Date: Thu May 23 18:34:22 2019 New Revision: 361586 URL: http://llvm.org/viewvc/llvm-project?rev=361586=rev Log: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *. Turn it into a variant class instead. This conversion does indeed save some code but there's a

[PATCH] D62363: Enable intrinsics that convert float and bf16 data to each other

skan created this revision. skan added reviewers: xiangzhangllvm, LuoYuanke, craig.topper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Scalar version : `_mm_cvtsbh_ss` , `_mm_cvtness_sbh` Vector version: `_mm512_cvtpbh_ps` , `_mm256_cvtpbh_ps`

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. from kernel, libbpf, tooling and user experience points of view this approach looks the best to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: test/CodeGen/bpf-offsetreloc.c:2-4 +// RUN: grep "llvm.preserve.struct.access.index" %t1 +// RUN: grep "llvm.preserve.array.access.index" %t1 +// RUN: grep

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 201104. plotfi added a comment. Improving visibility extraction for class template specializations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files:

Re: r361340 - [Analysis] Link library dependencies to Analysis plugins

Hi Petr, This seems to have caused Analysis/checker-plugins.c to fail. Can you investigate it or revert your commit? http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6381/consoleFull#-5275661368254eaf0-7326-4999-85b0-388101f2d404 > On May 21, 2019, at 5:47 PM, Petr Hosek via

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8003 +!isRValueOfIllegalType(E) && +E->isConstantInitializer(S.getASTContext(), /*ForRef=*/false)) { + resetDiagnosticState(InitialState); george.burgess.iv wrote: >

[PATCH] D62094: [analyzer] List checker/plugin options in 3 categories: released, alpha, developer

Szelethus added a comment. Alright, builbots don't seem to complain just yet. Thank you so much for all the help!!! This patch concludes the analyzer configuration project for good :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62094/new/ https://reviews.llvm.org/D62094

r361571 - Fix hang during constant evaluation of union assignment.

Author: ericwf Date: Thu May 23 16:34:43 2019 New Revision: 361571 URL: http://llvm.org/viewvc/llvm-project?rev=361571=rev Log: Fix hang during constant evaluation of union assignment. HandleUnionActiveMemberChange forgot to walk over a nop implicit conversion node and got stuck in the process.

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan updated this revision to Diff 201089. leonardchan edited the summary of this revision. Herald added a subscriber: aprantl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62225/new/ https://reviews.llvm.org/D62225 Files:

[PATCH] D62094: [analyzer] List checker/plugin options in 3 categories: released, alpha, developer

Szelethus added a comment. Ops, committed in rC361566 with the wrong revision name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62094/new/ https://reviews.llvm.org/D62094 ___ cfe-commits mailing

[PATCH] D62093: [analyzer] List checkers in 3 categories: released, alpha, developer

Szelethus added a comment. rC361566 is incorrectly marked for this revision instead of D62094 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62093/new/ https://reviews.llvm.org/D62093

r361566 - [analyzer] List checker/plugin options in 3 categories: released, alpha, developer

Author: szelethus Date: Thu May 23 15:52:09 2019 New Revision: 361566 URL: http://llvm.org/viewvc/llvm-project?rev=361566=rev Log: [analyzer] List checker/plugin options in 3 categories: released, alpha, developer Same patch as D62093, but for checker/plugin options, the only difference being

r361564 - [OPENMP]Do not crash for const firstprivates.

Author: abataev Date: Thu May 23 15:30:43 2019 New Revision: 361564 URL: http://llvm.org/viewvc/llvm-project?rev=361564=rev Log: [OPENMP]Do not crash for const firstprivates. If the variable is a firstprivate variable and it was not emitted beause this a constant variable with the constant

[PATCH] D61839: [analyzer] Hide developer-only checker/package options by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC361561: [analyzer] Hide developer-only checker/package options by default (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61839/new/

r361562 - Use clang_cc1 instead of clang in CodeGen test.

Author: asbirlea Date: Thu May 23 15:07:37 2019 New Revision: 361562 URL: http://llvm.org/viewvc/llvm-project?rev=361562=rev Log: Use clang_cc1 instead of clang in CodeGen test. Modified: cfe/trunk/test/CodeGen/loop-vectorize.c Modified: cfe/trunk/test/CodeGen/loop-vectorize.c URL:

r361561 - [analyzer] Hide developer-only checker/package options by default

Author: szelethus Date: Thu May 23 15:07:16 2019 New Revision: 361561 URL: http://llvm.org/viewvc/llvm-project?rev=361561=rev Log: [analyzer] Hide developer-only checker/package options by default These options are now only visible under -analyzer-checker-option-help-developer. Differential

[PATCH] D62320: Fix LLVM_LINK_LLVM_DYLIB build after rC361285

sbc100 abandoned this revision. sbc100 added a comment. This was fixed in https://reviews.llvm.org/D62333 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62320/new/ https://reviews.llvm.org/D62320 ___

Re: [PATCH] D62279: Use LTO capable linker

> On May 23, 2019, at 2:40 PM, Wink Saville via Phabricator > wrote: > > winksaville added a comment. > > In D62279#1514596 , @beanz wrote: > >> @winksaville I've figured out how to resolve the `gtest` issue, but >> unfortunately that isn't good

r361558 - [analyzer] List checkers in 3 categories: released, alpha, developer

Author: szelethus Date: Thu May 23 14:46:51 2019 New Revision: 361558 URL: http://llvm.org/viewvc/llvm-project?rev=361558=rev Log: [analyzer] List checkers in 3 categories: released, alpha, developer Previously, the only way to display the list of available checkers was to invoke the analyzer

[PATCH] D62093: [analyzer] List checkers in 3 categories: released, alpha, developer

This revision was automatically updated to reflect the committed changes. Closed by commit rL361558: [analyzer] List checkers in 3 categories: released, alpha, developer (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D62279: Use LTO capable linker

winksaville added a comment. In D62279#1514596 , @beanz wrote: > @winksaville I've figured out how to resolve the `gtest` issue, but > unfortunately that isn't good enough to get the `check-runtimes` target > working. A change went in back in February

r361557 - [X86] Split multi-line chained assignments into single lines to avoid making clang-format create triangle shaped indentation. Simplify one if statement to remove a bunch of string matches. N

Author: ctopper Date: Thu May 23 14:34:36 2019 New Revision: 361557 URL: http://llvm.org/viewvc/llvm-project?rev=361557=rev Log: [X86] Split multi-line chained assignments into single lines to avoid making clang-format create triangle shaped indentation. Simplify one if statement to remove a

[PATCH] D62343: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC]

hintonda created this revision. hintonda added reviewers: mikhail.ramalho, beanz. Herald added a subscriber: mgorny. Herald added a project: clang. This file was moved to llvm in D54978 , r356929, but the old file was never removed. Repository: rG LLVM Github

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361552: [analyzer] Add a new frontend flag to display all checker options (authored by Szelethus, committed by ). Herald

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 marked 3 inline comments as done. boga95 added a comment. I already thought about it. It would make the code much cleaner, but it would have a little performance impact (Does it matter?). It's straightforward to read the supported functions from another yaml file. Besides that, it can

r361552 - [analyzer] Add a new frontend flag to display all checker options

Author: szelethus Date: Thu May 23 13:47:28 2019 New Revision: 361552 URL: http://llvm.org/viewvc/llvm-project?rev=361552=rev Log: [analyzer] Add a new frontend flag to display all checker options Add the new frontend flag -analyzer-checker-option-help to display all checker/package options.

[PATCH] D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361550: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment (authored by ztamas, committed by ). Changed prior to commit:

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

rnk added inline comments. Comment at: test/CodeGen/loop-vectorize.c:1 +// RUN: %clang -target x86_64 -S -c -O1 -fvectorize -emit-llvm -o - %s | FileCheck %s -check-prefix=CHECK-ENABLE-VECT +// RUN: %clang -target x86_64 -S -c -O1 -fno-vectorize -emit-llvm -o - %s | FileCheck

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

NoQ added a comment. Ok! This looks like there isn't that much code, so it should be fine to duplicate. Do you have plans to eliminate the existing switch and instead use yaml for *all* supported functions while shipping a default .yaml file with the analyzer? I'm still in doubts on how to

[clang-tools-extra] r361550 - [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment

Author: ztamas Date: Thu May 23 13:29:04 2019 New Revision: 361550 URL: http://llvm.org/viewvc/llvm-project?rev=361550=rev Log: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment Summary: Added WarnOnlyIfThisHasSuspiciousField option to allow to catch any copy

[PATCH] D62279: Use LTO capable linker

beanz added a comment. @winksaville I've figured out how to resolve the `gtest` issue, but unfortunately that isn't good enough to get the `check-runtimes` target working. A change went in back in February (rL353601 ), which breaks running compiler-rt's tests

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv added a comment. Thanks for the feedback! > With this patch, do we pass the general-regs-only attribute to the backend? > If so, would that be the attribute we'd want to check to emit errors from the > backend from any "accidental" floating-point operations? Yeah, the

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv updated this revision to Diff 201047. george.burgess.iv marked 10 inline comments as done. george.burgess.iv added a comment. Addressed feedback, modulo the constant foldable comment thread. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38479/new/

[clang-tools-extra] r361545 - Fix sphinx unknown document error

Author: rksimon Date: Thu May 23 13:07:27 2019 New Revision: 361545 URL: http://llvm.org/viewvc/llvm-project?rev=361545=rev Log: Fix sphinx unknown document error Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

[PATCH] D61839: [analyzer] Hide developer-only checker/package options by default

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Next! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61839/new/ https://reviews.llvm.org/D61839 ___ cfe-commits mailing list

[PATCH] D62094: [analyzer] List checker/plugin options in 3 categories: released, alpha, developer

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thank you. This formalization work made things a lot easier and safer to deal with. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62094/new/ https://reviews.llvm.org/D62094

r361542 - Update breaking test.

Author: asbirlea Date: Thu May 23 12:51:16 2019 New Revision: 361542 URL: http://llvm.org/viewvc/llvm-project?rev=361542=rev Log: Update breaking test. Modified: cfe/trunk/test/CodeGen/loop-vectorize.c Modified: cfe/trunk/test/CodeGen/loop-vectorize.c URL:

[PATCH] D62340: [clang-tidy] In TransformerClangTidyCheck, require Explanation field.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a subscriber: xazax.hun. Herald added a project: clang. In general, the `Explanation` field is optional in `RewriteRule` cases. But, because the primary purpose of clang-tidy checks is to provide users with

[PATCH] D62279: Use LTO capable linker

beanz added a comment. In D62279#1514467 , @winksaville wrote: > Even with both gtest patches it still isn't working, `ninja check-all` is > failing as before :( I wouldn't expect your gtest patch to resolve the issue. The `CLANG_BOOTSTRAP_TARGETS`

[PATCH] D62093: [analyzer] List checkers in 3 categories: released, alpha, developer

NoQ added a comment. Thx!~ Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:527-530 +// developer checkers even in the alpha output. For example, +// alpha.cplusplus.IteratorModeling is a modeling checker, hence it's hidden +// by default, and users

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

This revision was automatically updated to reflect the committed changes. Closed by commit rL361536: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D62279: Use LTO capable linker

winksaville added a comment. > Are you still having that issue after rL361436 > ? That should have resolved that problem. > The issue isn't that gtest is missing from the bootstrap, but rather that it > was missing from the dependencies for the runtime

r361536 - Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

Author: tlively Date: Thu May 23 11:55:00 2019 New Revision: 361536 URL: http://llvm.org/viewvc/llvm-project?rev=361536=rev Log: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests Summary: Add correct cmake dependencies so that `ToolingTests` link successfully. Patch

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

This revision was automatically updated to reflect the committed changes. Closed by commit rC361534: [NewPassManager] Add tuning option: SLPVectorization [clang-change] (authored by asbirlea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61617?vs=198587=201033#toc

r361534 - [NewPassManager] Add tuning option: SLPVectorization [clang-change]

Author: asbirlea Date: Thu May 23 11:51:02 2019 New Revision: 361534 URL: http://llvm.org/viewvc/llvm-project?rev=361534=rev Log: [NewPassManager] Add tuning option: SLPVectorization [clang-change] Summary: NewPassManager is not using CodeGenOpts values before this patch. [to be coupled with

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

rjmccall added inline comments. Comment at: include/clang/Sema/Overload.h:977 + +void setDestAS(LangAS AS) { DestAS = AS; } }; Can this assert that `Kind == CSK_InitByConstructor || Kind == CSK_InitByUserDefinedConversion`? Comment at:

[PATCH] D62335: [OpenCL][PR41963] Add overloads of old atomics with generic pointer type in C++ mode

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, jfb, yaxunl. The direction is to allow it as an extension to the kernel language 2.0 and above. https://github.com/KhronosGroup/OpenCL-Docs/issues/66 For the published OpenCL C spec there

[PATCH] D62270: [Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rC361530: [Driver] Move the -o OUT -x TYPE SRC.c flags to the end of -cc1 (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D62270?vs=200827=201026#toc Repository: rC

r361530 - [Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1

Author: rnk Date: Thu May 23 11:35:43 2019 New Revision: 361530 URL: http://llvm.org/viewvc/llvm-project?rev=361530=rev Log: [Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1 New -cc1 arguments, such as -faddrsig, have started appearing after the input name. I personally find it

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

quantum created this revision. quantum added reviewers: tlively, aheejin. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Add correct cmake dependencies so that `ToolingTests` link successfully. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62333

[PATCH] D61716: [libclang] Expose AtomicType

slowhog edited projects, added clang-c; removed clang. slowhog removed reviewers: yvvan, jbcoe. slowhog added a comment. Herald added a project: clang. Hi, We use libclang in OpenJDK project Panama for a tool, jextract, to read C header files and generate Java bindings. It's critical for us to

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

srhines added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:52 + +void e() { + int pipefd[2]; jcai19 wrote: > srhines wrote: > > I'm not all that familiar with writing clang-tidy-specific tests, but > > should these

[PATCH] D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD361518: lld-link, clang: Treat non-existent input files as possible spellos for option… (authored by nico, committed by ). Changed prior to commit:

r361518 - lld-link, clang: Treat non-existent input files as possible spellos for option flags

Author: nico Date: Thu May 23 10:58:33 2019 New Revision: 361518 URL: http://llvm.org/viewvc/llvm-project?rev=361518=rev Log: lld-link, clang: Treat non-existent input files as possible spellos for option flags OptTable treats arguments starting with / that aren't a known option as filenames.

[PATCH] D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags

rnk accepted this revision. rnk added a comment. Thanks, this has been a longstanding issue! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62276/new/ https://reviews.llvm.org/D62276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags

thakis marked 5 inline comments as done. thakis added a comment. Thanks! Landing with comments addressed. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:177 def warn_drv_unknown_argument_clang_cl_with_suggestion : Warning< - "unknown argument ignored in

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

penzn marked an inline comment as done. penzn added inline comments. Comment at: cfe/trunk/lib/Tooling/Refactoring/RangeSelector.cpp:229 +RangeSelector tooling::statements(StringRef ID) { + return RelativeSelector(ID); +} penzn wrote: > Sorry for posting here,

[PATCH] D62156: [Sema] Diagnose addr space mismatch while constructing objects

Anastasia updated this revision to Diff 201011. Anastasia added a comment. - Switched back to loop over all method qualifiers - Moved addr space check into `AddOverloadCandidate` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62156/new/ https://reviews.llvm.org/D62156 Files:

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/stdint.h:16 +#endif // _STD_TYPES_T /* mclow.lists wrote: > I don't think that this will do what you want it to. > Is this a supported use case? > > ``` > #include > #define

[PATCH] D62279: Use LTO capable linker

beanz added a comment. In D62279#1514046 , @winksaville wrote: > I've add gtest_main and gtest to CLANG_BOOTSTRAP_TARGETS as a guess, because > that's where check-all is defined: > ... > My guess is likely wrong, what do you advise? Are you still

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

lebedev.ri resigned from this revision. lebedev.ri added a comment. Don't think i will be of any help here. Comment at: test/CodeGen/bpf-offsetreloc.c:2-4 +// RUN: grep "llvm.preserve.struct.access.index" %t1 +// RUN: grep "llvm.preserve.array.access.index" %t1 +// RUN: grep

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

This revision was automatically updated to reflect the committed changes. Closed by commit rL361516: [WebAssembly] Add multivalue and tail-call target features (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D62047?vs=199941=201010#toc Repository: rL

r361516 - [WebAssembly] Add multivalue and tail-call target features

Author: tlively Date: Thu May 23 10:26:47 2019 New Revision: 361516 URL: http://llvm.org/viewvc/llvm-project?rev=361516=rev Log: [WebAssembly] Add multivalue and tail-call target features Summary: These features will both be implemented soon, so I thought I would save time by adding the

[PATCH] D62312: [ASTImporter] Added visibility context check for CXXRecordDecl.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62312/new/ https://reviews.llvm.org/D62312 ___ cfe-commits

[PATCH] D62328: [LibTooling] Fix dangling references in RangeSelector.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361514: [LibTooling] Fix dangling references in RangeSelector. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().getTranslationUnitDecl()), TheCU);

r361514 - [LibTooling] Fix dangling references in RangeSelector.

Author: ymandel Date: Thu May 23 10:11:33 2019 New Revision: 361514 URL: http://llvm.org/viewvc/llvm-project?rev=361514=rev Log: [LibTooling] Fix dangling references in RangeSelector. Summary: RangeSelector had a number of cases of capturing a StringRef in a lambda, which lead to dangling

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang updated this revision to Diff 201004. akhuang added a comment. Add llvm IR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/ https://reviews.llvm.org/D62167 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

beanz added a comment. In D62215#1512849 , @winksaville wrote: > IIRC, on linux if LTO is ON I had to use `ld.gold` for both stage 1 and 2, > although that maybe > just the way it ended up and it wasn't necessary. But I'll test whatever you > come up

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

mclow.lists added inline comments. Comment at: libcxx/include/stdint.h:16 +#endif // _STD_TYPES_T /* I don't think that this will do what you want it to. Is this a supported use case? ``` #include #define _STD_TYPES_T #include ``` Repository: rG LLVM

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

Either way looks good. If we go with function_ref, we should definitely store a comment why storing function_ref is fine there. Or use a function pointer to make it even clearer that nothing cheesy is going on there. On Thu, May 23, 2019 at 5:28 PM Yitzhak Mandelbaum wrote: > Actually, someone

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL361511: [Index] Fix reported references in presence of template type aliases (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r361511 - [Index] Fix reported references in presence of template type aliases

Author: ibiryukov Date: Thu May 23 09:48:47 2019 New Revision: 361511 URL: http://llvm.org/viewvc/llvm-project?rev=361511=rev Log: [Index] Fix reported references in presence of template type aliases Summary: See the added test for an example. Reviewers: kadircet Reviewed By: kadircet

[clang-tools-extra] r361511 - [Index] Fix reported references in presence of template type aliases

Author: ibiryukov Date: Thu May 23 09:48:47 2019 New Revision: 361511 URL: http://llvm.org/viewvc/llvm-project?rev=361511=rev Log: [Index] Fix reported references in presence of template type aliases Summary: See the added test for an example. Reviewers: kadircet Reviewed By: kadircet

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

ilya-biryukov added inline comments. Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:140 + bool IsTypeAlias) { +if (ResolvedClass) { + // In presence of type aliases, the resolved class was never written in

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

ilya-biryukov updated this revision to Diff 201002. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Address a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62303/new/ https://reviews.llvm.org/D62303 Files:

[PATCH] D62328: [LibTooling] Fix dangling references in RangeSelector.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62328/new/ https://reviews.llvm.org/D62328

[PATCH] D62312: [ASTImporter] Added visibility context check for CXXRecordDecl.

shafik added a comment. Minor comments, I am going to run `check-lldb` now. Comment at: unittests/AST/ASTImporterVisibilityTest.cpp:34 }; +struct GetClassPattern { + using DeclTy = CXXRecordDecl; `GetCXXRecordPattern` feels more consistent.

r361510 - [CodeComplete] Only show lambda completions if patterns are requested

Author: ibiryukov Date: Thu May 23 09:39:26 2019 New Revision: 361510 URL: http://llvm.org/viewvc/llvm-project?rev=361510=rev Log: [CodeComplete] Only show lambda completions if patterns are requested This is a trivial follow-up to r361461, so sending without review. Modified:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. After landing this, will try to add new presentation options for completion items here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. I think that's a good step forward, although not yet ideal. The typed chunk now contains everything starting function name and ending with `override`, so one gets both nice prefix match scores when typing a function

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201000. ilya-biryukov added a comment. Herald added subscribers: arphaman, jkorous. - Make first letter of the helper function lowercase - New model: everything before name is a text chunk, everything after it is typed chunk - Test the filter text

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet updated this revision to Diff 200998. gchatelet added a comment. - Use no-builtin instead of no-runtime-for. - Use one attribute per runtime function to make merging easier. The patch is still WIP and needs more work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Structural equivalence did not handle dependent template args properly when the arg

[PATCH] D62328: [LibTooling] Fix dangling references in RangeSelector.

ymandel created this revision. ymandel added reviewers: ilya-biryukov, gribozavr. Herald added a project: clang. RangeSelector had a number of cases of capturing a StringRef in a lambda, which lead to dangling references. This change converts all uses in the API of `StringRef` to `std::string` to

  1   2   >