Re: [PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

The alignment check can just be removed. On Mon., May 27, 2019, 7:57 p.m. Ulrich Weigand via Phabricator, < revi...@reviews.llvm.org> wrote: > uweigand added a comment. > > Looks like this test is failing on SystemZ since it was added, making all > our build bots red: > > >

[PATCH] D62367: [X86] VP2INTERSECT clang

craig.topper added inline comments. Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39 + +static __inline__ void __DEFAULT_FN_ATTRS256 +_mm256_2intersect_epi32(__m256i __a, __m256i __b, __mmask8 *__m0, __mmask8 *__m1) { xiangzhangllvm wrote: > craig.topper

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm marked an inline comment as done. xiangzhangllvm added inline comments. Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39 + +static __inline__ void __DEFAULT_FN_ATTRS256 +_mm256_2intersect_epi32(__m256i __a, __m256i __b, __mmask8 *__m0, __mmask8 *__m1) {

[PATCH] D62367: [X86] VP2INTERSECT clang

craig.topper added inline comments. Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39 + +static __inline__ void __DEFAULT_FN_ATTRS256 +_mm256_2intersect_epi32(__m256i __a, __m256i __b, __mmask8 *__m0, __mmask8 *__m1) { Can you add doxygen comments for the

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm updated this revision to Diff 201611. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62367/new/ https://reviews.llvm.org/D62367 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/CMakeLists.txt:141-147 - if (LLVM_WITH_Z3) -add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver" -

[PATCH] D62509: [Driver] Render -fuse-init-array for -fembed-bitcode

MaskRay created this revision. MaskRay added reviewers: compnerd, rsmith, t.p.northover. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modern ELF platforms use -fuse-init-array to emit .init_array instead of .ctors . ld.bfd and gold merge .init_array and .ctors into

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/CMakeLists.txt:141-147 - if (LLVM_WITH_Z3) -add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver" -

[PATCH] D62445: [test] Fix plugin tests

NoQ added subscribers: mikhail.ramalho, ddcc. NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! I think we're losing the Z3 constraint manager test suite this way after all (details inline), but i feel we should downprioritize this when

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

skan updated this revision to Diff 201605. skan added a comment. make comments for `_mm_cvtsbh_ss` and `_mm_cvtness_sbh` better CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62363/new/ https://reviews.llvm.org/D62363 Files: include/clang/Basic/BuiltinsX86.def

[PATCH] D62479: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay, cool! Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2388-2390 - if (Tag->getTagDescription() != "cplusplus.SelfAssignment") -return nullptr; -

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

craig.topper added inline comments. Comment at: lib/Headers/avx512bf16intrin.h:37 +/// +/// This intrinsic corresponds to the EmitX86CvtBF16ToFloatExpr +/// function. skan wrote: > craig.topper wrote: > > This needs to be a comment that's useful to user's of

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

dexonsmith added a comment. This doesn’t look okay to me, because this would prevent building for Darwin when running on Windows. I added a couple of reviewers that have Windows experience and might have ideas for how to fix the tests without breaking the portability of the driver.

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

skan marked an inline comment as done. skan added inline comments. Comment at: lib/Headers/avx512bf16intrin.h:37 +/// +/// This intrinsic corresponds to the EmitX86CvtBF16ToFloatExpr +/// function. craig.topper wrote: > This needs to be a comment that's useful

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

craig.topper added inline comments. Comment at: lib/Headers/avx512bf16intrin.h:37 +/// +/// This intrinsic corresponds to the EmitX86CvtBF16ToFloatExpr +/// function. This needs to be a comment that's useful to user's of the compiler not compiler developers.

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

skan marked 3 inline comments as done. skan added inline comments. Comment at: lib/Headers/avx512bf16intrin.h:52 +/// +/// \headerfile +/// RKSimon wrote: > \headerfile fixed in updated patch Comment at: lib/Headers/avx512bf16intrin.h:66 +///

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62470/new/ https://reviews.llvm.org/D62470

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

skan updated this revision to Diff 201601. skan added a comment. rm clang-format fix in this patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62363/new/ https://reviews.llvm.org/D62363 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

rsmith added a comment. Thanks, looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62470/new/ https://reviews.llvm.org/D62470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

FireBurn added a comment. Could this commit be causing the following build failure of Chromium, this same version build a few days ago with clang from git: FAILED: obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/v8_feature_policy.o clang++ -MMD -MF

[PATCH] D62429: Fix linkage of _ZTS strings for types involving incomplete classes to match the Itanium ABI rules.

rsmith added a comment. In D62429#1518602 , @EricWF wrote: > I think this is llvm.org/PR37398 > > I tried fixing this a while back in r332028 but the fix got reverted for > causing llvm.org/PR37545. Looks like I had a fix for that in

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. Hello, this embeds an absolute path into the generated .obj file, which means the output now is no longer deterministic (since it depends on the absolute path to clang_rt.profile-x86_64.lib). This means the output will be different on different machines, which breaks

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

uweigand added a comment. Looks like this test is failing on SystemZ since it was added, making all our build bots red: /home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/tools/clang/test/CodeGenCXX/builtin_FUNCTION.cpp:9:11: error: CHECK: expected string not found in input // CHECK:

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert updated this revision to Diff 201597. aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Put the important part first, and the rest in a separate sentence. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62470/new/

[PATCH] D62469: [Driver] Change layout of per-target runtimes to resemble multiarch

This revision was automatically updated to reflect the committed changes. Closed by commit rL361784: [Driver] Change layout of per-target runtimes to resemble multiarch (authored by phosek, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D62429: Fix linkage of _ZTS strings for types involving incomplete classes to match the Itanium ABI rules.

EricWF added a comment. I think this is llvm.org/PR37398 I tried fixing this a while back in r332028 but the fix got reverted for causing llvm.org/PR37545. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62429/new/ https://reviews.llvm.org/D62429

r361784 - [Driver] Change layout of per-target runtimes to resemble multiarch

Author: phosek Date: Mon May 27 16:23:50 2019 New Revision: 361784 URL: http://llvm.org/viewvc/llvm-project?rev=361784=rev Log: [Driver] Change layout of per-target runtimes to resemble multiarch This is a follow up to r361432, changing the layout of per-target runtimes to more closely resemble

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

ldionne added a comment. A few notes: - I did setup a Windows machine and run the tests on it - I'd welcome a better way to solve this problem than ripping out the use of `llvm::sys::path::append`, but I wasn't able to find anything in `FileCheck` that would do it Repository: rG LLVM

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

ldionne created this revision. ldionne added reviewers: jfb, rsmith. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Otherwise, the unit tests seem to be confused on Windows. Note that it would in theory be better to always use the platform's path,

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert marked 3 inline comments as done. aaronpuchert added inline comments. Comment at: docs/InternalsManual.rst:426-428 +* Fix-it hints on a warning should only clarify the meaning of the existing + code, not change it. Examples for such hints are added parentheses in

[PATCH] D62469: [Driver] Change layout of per-target runtimes to resemble multiarch

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62469/new/ https://reviews.llvm.org/D62469

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaron.ballman added inline comments. Comment at: docs/InternalsManual.rst:426-428 +* Fix-it hints on a warning should only clarify the meaning of the existing + code, not change it. Examples for such hints are added parentheses in cases + of counter-intuitive precedence, when

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Thanks for the review, Alex. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361779: [Preprocessor] Fix crash emitting note with framework location for file not… (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit:

r361779 - [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

Author: vsapsai Date: Mon May 27 12:15:30 2019 New Revision: 361779 URL: http://llvm.org/viewvc/llvm-project?rev=361779=rev Log: [Preprocessor] Fix crash emitting note with framework location for "file not found" error. A filename can be remapped with a header map to point to a framework header

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert marked 2 inline comments as done. aaronpuchert added inline comments. Comment at: docs/InternalsManual.rst:426-428 +* Fix-it hints on a warning should only clarify the meaning of the existing + code, not change it. Examples for such hints are added parentheses in

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:6970 +if (Proto->hasExceptionSpec()) + return true; + erichkeane wrote: > aaron.ballman wrote: > > I think we should diagnose that the `nothrow` is ignored in this case to > >

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62490: clang-cl: Fix mangling of catchable types with names longer than 4kiB

thakis created this revision. thakis added a reviewer: rnk. The mangling used to contain the MD5 name of both the RTTI type descriptor and the name of the copy ctor in MSVC2013, but it changed to just the former in 2015. It looks like it changed back to the old mangling in VS2017 version 15.7 and

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 201543. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files:

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:6970 +if (Proto->hasExceptionSpec()) + return true; + aaron.ballman wrote: > I think we should diagnose that the `nothrow` is ignored

[PATCH] D62487: [clang] Respect TerseOutput when printing lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rL361771: [clang] Respect TerseOutput when printing lambdas (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r361771 - [clang] Respect TerseOutput when printing lambdas

Author: kadircet Date: Mon May 27 09:20:45 2019 New Revision: 361771 URL: http://llvm.org/viewvc/llvm-project?rev=361771=rev Log: [clang] Respect TerseOutput when printing lambdas Reviewers: ilya-biryukov, hokein, sammccall Subscribers: cfe-commits Tags: #clang Differential Revision:

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 201535. Tyker marked 13 inline comments as done. Tyker retitled this revision from "[C++20] add consteval specifier" to "[C++20] add Basic consteval specifier". Tyker edited the summary of this revision. Tyker added a comment. Herald added a subscriber: eraman.

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall added a comment. Still LG I forgot to mention - it would be nice to clang-format the definition, what do you think? Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:592 +)cpp", + {/*NamespaceScope=*/std::string("ns1::ns2"), +

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10471 + bool IsConstantContext = S.ExprEvalContexts.back().isConstantEvaluated(); + rsmith wrote: > Are the changes to this file really specific to `consteval` evaluation? They > look

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 201536. kadircet marked 10 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files:

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet marked 10 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:567 +const HoverInfo Expected; + } // namespace + Cases[] = { sammccall wrote: > namespace?! > > might be a

[PATCH] D62487: [clang] Respect TerseOutput when printing lambdas

kadircet created this revision. kadircet added reviewers: ilya-biryukov, hokein, sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet added a child revision: D61497: [clangd] Introduce a structured hover response. Repository: rG LLVM Github Monorepo

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. It seems that the functional changes are missing from the patch -- all I see are formatting changes; have I missed something? Comment at:

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:227 + /** + * The cursor has a declspec(nothrow) exception specification. + */ `__declspec(nothrow)` Comment at:

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaron.ballman added a comment. Thank you for working on this! Comment at: docs/InternalsManual.rst:426-428 +* Fix-it hints on a warning should only clarify the meaning of the existing + code, not change it. Examples for such hints are added parentheses in cases + of

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2638 + // Check if the node is a C++ struct/union/class. + if (const auto *RecordDecl = dyn_cast()) +return Finder->classIsDerivedFrom(RecordDecl, Base, Builder);

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { +

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

madsravn added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { + addUsage(NamingCheckFailures, Typedef->getDecl(), + Value->getSourceRange());

r361769 - When dumping the AST to JSON, dump the type information from a typeid expression with a type operand.

Author: aaronballman Date: Mon May 27 07:34:31 2019 New Revision: 361769 URL: http://llvm.org/viewvc/llvm-project?rev=361769=rev Log: When dumping the AST to JSON, dump the type information from a typeid expression with a type operand. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h

r361768 - When dumping the AST to JSON, dump whether a function is variadic or not.

Author: aaronballman Date: Mon May 27 07:29:10 2019 New Revision: 361768 URL: http://llvm.org/viewvc/llvm-project?rev=361768=rev Log: When dumping the AST to JSON, dump whether a function is variadic or not. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp

r361767 - When dumping the AST to JSON, dump the declared name of a MemberExpr operand.

Author: aaronballman Date: Mon May 27 07:25:04 2019 New Revision: 361767 URL: http://llvm.org/viewvc/llvm-project?rev=361767=rev Log: When dumping the AST to JSON, dump the declared name of a MemberExpr operand. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added a comment. In D60455#1513499 , @Anastasia wrote: > //**Design question**//: since you are not aware what functions are to be run > on a device while parsing them, at what point do you plan to diagnose the > invalid behavior from the standard

r361766 - When dumping the AST to JSON, dump the argument name to a sizeof pack expression.

Author: aaronballman Date: Mon May 27 07:17:32 2019 New Revision: 361766 URL: http://llvm.org/viewvc/llvm-project?rev=361766=rev Log: When dumping the AST to JSON, dump the argument name to a sizeof pack expression. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h

[PATCH] D62389: [clangd] Place cursor better after completing patterns

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62389/new/ https://reviews.llvm.org/D62389

[PATCH] D57795: [RISCV] Add FreeBSD targets

emaste added inline comments. Comment at: lib/Basic/Targets.cpp:379 return new LinuxTargetInfo(Triple, Opts); -return new RISCV32TargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); My usual

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske updated this revision to Diff 201521. balazske added a comment. - Import BraceRange of EnumDecl. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 Files: lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporter.cpp

[PATCH] D62484: [ASTImporter] Added visibility context check for EnumDecl.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter makes now difference between enums with same name

[PATCH] D62389: [clangd] Place cursor better after completing patterns

ilya-biryukov added a comment. In D62389#1518030 , @hokein wrote: > How about adding one more test in CodeCompleteTests.cpp, we already have a > snippet test there, and it seems more straightforward. Done! Repository: rG LLVM Github Monorepo

[PATCH] D62389: [clangd] Place cursor better after completing patterns

ilya-biryukov updated this revision to Diff 201517. ilya-biryukov added a comment. - Add a code completion test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62389/new/ https://reviews.llvm.org/D62389 Files:

[PATCH] D62483: [CUDA][HIP] Emit dependent libs for host only

yaxunl created this revision. yaxunl added a reviewer: tra. Recently D60274 was introduced to allow lld to handle dependent libs. However current usage of dependent libs (e.g. pragma comment(lib, *) in windows header files) are intended for host only. Emitting

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 201503. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td lib/CodeGen/BackendUtil.cpp

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 201505. djtodoro added a comment. -Rebase -Add a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h

[PATCH] D62389: [clangd] Place cursor better after completing patterns

hokein added a comment. In D62389#1517907 , @ilya-biryukov wrote: > In D62389#1517844 , @hokein wrote: > > > I'm not sure the new behavior suits all cases, it seems to me that this > > will change a typical

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a few NITs and a few questions about the possibility of moving this to `clang-format` at some point in the future. From what I can to simplify the calling, we need to:

[PATCH] D62197: [OpenCL] Fix file-scope const sampler variable for 2.0

This revision was automatically updated to reflect the committed changes. Closed by commit rC361757: [OpenCL] Fix file-scope const sampler variable for 2.0 (authored by yaxunl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION

r361757 - [OpenCL] Fix file-scope const sampler variable for 2.0

Author: yaxunl Date: Mon May 27 04:19:07 2019 New Revision: 361757 URL: http://llvm.org/viewvc/llvm-project?rev=361757=rev Log: [OpenCL] Fix file-scope const sampler variable for 2.0 OpenCL spec v2.0 s6.13.14: Samplers can also be declared as global constants in the program source using the

[PATCH] D62479: Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: NoQ. baloghadamsoftware added a project: clang. Herald added subscribers: gamesh411, rnkovacs. The `cplusplus.SelfAssignment` checker has a visitor that is added to every `BugReport` to mark the to branch of the self

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

ilya-biryukov updated this revision to Diff 201493. ilya-biryukov added a comment. - Fix parsing of a client capability, add a test for a capability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62476/new/ https://reviews.llvm.org/D62476 Files:

[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC361753: [CodeComplete] Complete return true/false in boolean functions (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62391?vs=201240=201489#toc Repository:

[PATCH] D62459: [clangd] Serialization support for RelationSlab

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:29 + +llvm::Expected symbolRoleToRelationKind(index::SymbolRole Role) { + // SymbolRole is used to record relations in the index. no need for errors, use

r361753 - [CodeComplete] Complete 'return true/false' in boolean functions

Author: ibiryukov Date: Mon May 27 02:52:09 2019 New Revision: 361753 URL: http://llvm.org/viewvc/llvm-project?rev=361753=rev Log: [CodeComplete] Complete 'return true/false' in boolean functions Reviewers: kadircet Reviewed By: kadircet Subscribers: cfe-commits Tags: #clang Differential

[PATCH] D62312: [ASTImporter] Added visibility context check for CXXRecordDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361752: [ASTImporter] Added visibility context check for CXXRecordDecl. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D62389: [clangd] Place cursor better after completing patterns

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.h:41 /// *Signature = "(size_type) const" -/// *Snippet = "(${0:size_type})" +/// *Snippet = "(${1:size_type})" /// If set,

[PATCH] D62389: [clangd] Place cursor better after completing patterns

ilya-biryukov added a comment. In D62389#1517844 , @hokein wrote: > I'm not sure the new behavior suits all cases, it seems to me that this will > change a typical behavior (usually when users invoke function calls). > > Imaging a case: > > void

r361752 - [ASTImporter] Added visibility context check for CXXRecordDecl.

Author: balazske Date: Mon May 27 02:36:00 2019 New Revision: 361752 URL: http://llvm.org/viewvc/llvm-project?rev=361752=rev Log: [ASTImporter] Added visibility context check for CXXRecordDecl. Summary: ASTImporter makes now difference between classes with same name in different translation

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, I think you're right about all of this. Implementation looks OK too. Please add TODOs for the cases where we're punting to later vs deciding not to fix. In D61497#1512003

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

ilya-biryukov updated this revision to Diff 201487. ilya-biryukov added a comment. - Fix compilation when assertions are enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62476/new/ https://reviews.llvm.org/D62476 Files:

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Added to LSP in version 3.14 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62476 Files:

[PATCH] D62471: [clangd] SymbolCollector support for relations

kadircet added a comment. Can you also add some tests ? we have some tests in `unittests/SymbolCollectorTests.cpp` Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:298 + + processRelations(*ND, *ID, Relations); + why do we want to process these

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete marked an inline comment as done. Rakete added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3377-3379 // FIXME: This is not quite correct recovery as we don't transform SS // into the corresponding dependent form (and we don't

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { + addUsage(NamingCheckFailures, Typedef->getDecl(), + Value->getSourceRange());

[PATCH] D62389: [clangd] Place cursor better after completing patterns

hokein added a comment. I'm not sure the new behavior suits all cases, it seems to me that this will change a typical behavior (usually when users invoke function calls). Imaging a case: void foo(int a, int b); void call() { fo^ } - before, the final cursor is at the end of the

Re: r361518 - lld-link, clang: Treat non-existent input files as possible spellos for option flags

Want to put a note in ReleaseNotes.rst? This is fixing something that a lot of users have run in to, so seems worth mentioning :-) On Thu, May 23, 2019 at 7:55 PM Nico Weber via cfe-commits wrote: > > Author: nico > Date: Thu May 23 10:58:33 2019 > New Revision: 361518 > > URL:

[PATCH] D62412: [clang-tidy] Fix unused-variable warning after r361647.

hokein added a comment. I have commit this patch on behalf of @ymandel, as this warning blocks our internal integration. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62412/new/ https://reviews.llvm.org/D62412

[PATCH] D62412: [clang-tidy] Fix unused-variable warning after r361647.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361749: [clang-tidy] Fix unused-variable warning after r361647. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D62412?vs=201289=201481#toc Repository: rCTE

[clang-tools-extra] r361749 - [clang-tidy] Fix unused-variable warning after r361647.

Author: hokein Date: Mon May 27 01:09:02 2019 New Revision: 361749 URL: http://llvm.org/viewvc/llvm-project?rev=361749=rev Log: [clang-tidy] Fix unused-variable warning after r361647. Summary: A range-for was added in r361647 where the range variable was only used in an assertion. As a result,

[PATCH] D59407: [clangd] Add RelationSlab

sammccall accepted this revision. sammccall added a comment. Awesome, thank you! Comment at: clang-tools-extra/clangd/index/Relation.h:75 + private: +std::vector Relations; + }; kadircet wrote: > maybe use a set so that we can be sure that there won't be

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

J-Camilleri added a comment. In D61861#1517812 , @madsravn wrote: > This patch has now been merged. > https://github.com/llvm/llvm-project/commit/bd324fa2273778430a4fdf8371fec5d64d2231bb Great, thanks. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62391/new/ https://reviews.llvm.org/D62391

[PATCH] D37813: clang-format: better handle namespace macros

klimek added inline comments. Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:526 EXPECT_EQ("namespace A {\n" " int i;\n" "} // namespace A", Typz wrote: > Should I also fix these tests? > > They already existed

[PATCH] D59407: [clangd] Add RelationSlab

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, except the duplication issue. Thanks! Comment at: clang-tools-extra/clangd/index/Relation.h:75 + private: +std::vector Relations; + }; maybe

[PATCH] D62412: [clang-tidy] Fix unused-variable warning after r361647.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:21 : ClangTidyCheck(Name, Context), Rule(std::move(R)) { - for (const

  1   2   >