[libunwind] r362057 - [runtimes] Use -Wunknown-pragmas for the pragma check

Author: phosek Date: Wed May 29 22:38:06 2019 New Revision: 362057 URL: http://llvm.org/viewvc/llvm-project?rev=362057=rev Log: [runtimes] Use -Wunknown-pragmas for the pragma check This is a follow up to r362055, we need -Wunknown-pragmas otherwise the check is going to succeed it the pragma

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

rjmccall added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11101 + if (auto *placeholderType = Init->getType()->getAsPlaceholderType()) +if (placeholderType->getKind() == BuiltinType::PseudoObject) { + Res = CheckPlaceholderExpr(Init).get();

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

ahatanak created this revision. ahatanak added reviewers: rsmith, rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. The spurious `-Warc-repeated-use-of-weak` warnings are issued when an initializer expression uses a weak ObjC pointer. My first attempt to

Re: r350917 - [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto

Hi Richard, Thank you for the feedback. Please review my new patch: https://reviews.llvm.org/D62645 . > On Apr 23, 2019, at 7:21 PM, Richard Smith wrote: > > Hi Akira, > > I've reverted this in r359066. This subtly breaks the semantics of C++ > initializers

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

rjmccall added inline comments. Comment at: lib/CodeGen/CGObjC.cpp:376 + bool isClassMessage, + bool isSelfReceiverInClassMethod) { auto = CGF.CGM; I think it's fine to just call this a class

[PATCH] D58321: Support for relative vtables

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:329 +"Whether to use clang's relative C++ ABI " +"for classes with vtables") + leonardchan wrote: > rjmccall wrote: > > Yeah, see, this plays into the question

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

ahatanak created this revision. ahatanak added reviewers: rjmccall, pete, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. In a class method, 'self' points to the class object, so it should be safe to pass it to `objc_alloc`. Also, convert '[[self

[libunwind] r362055 - [runtimes] Check if pragma comment(lib, ...) is supported first

Author: phosek Date: Wed May 29 21:40:21 2019 New Revision: 362055 URL: http://llvm.org/viewvc/llvm-project?rev=362055=rev Log: [runtimes] Check if pragma comment(lib, ...) is supported first This fixes the issue introduced by r362048 where we always use pragma comment(lib, ...) for dependent

[PATCH] D62299: [PR41567][Sema] Fixed cast kind in addr space conversions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62299/new/ https://reviews.llvm.org/D62299 ___ cfe-commits mailing

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space of pointer/reference with template parameter types

rjmccall added a comment. I think the right approach here is probably to make sure you're applying deduction during instantiation as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62584/new/ https://reviews.llvm.org/D62584 ___

r362054 - Add the `objc_class_stub` attribute.

Author: rjmccall Date: Wed May 29 21:09:01 2019 New Revision: 362054 URL: http://llvm.org/viewvc/llvm-project?rev=362054=rev Log: Add the `objc_class_stub` attribute. Swift requires certain classes to be not just initialized lazily on first use, but actually allocated lazily using information

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore accepted this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/google-objc-global-variable-declaration.m:46 +//

[PATCH] D62509: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rC362052: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D62509?vs=202103=202105#toc

r362052 - [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode

Author: maskray Date: Wed May 29 19:30:04 2019 New Revision: 362052 URL: http://llvm.org/viewvc/llvm-project?rev=362052=rev Log: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode Modern ELF platforms use -fuse-init-array to emit .init_array instead of .ctors . ld.bfd

[PATCH] D62509: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode

MaskRay updated this revision to Diff 202103. MaskRay retitled this revision from "[Driver] Render -fuse-init-array for -fembed-bitcode" to "[Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode". MaskRay edited the summary of this revision. MaskRay added a comment. Add

[PATCH] D59185: [PowerPC] Set the default PLT mode on musl to Secure PLT

This revision was automatically updated to reflect the committed changes. Closed by commit rL362051: [PowerPC] Set the default PLT mode on musl to Secure PLT (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. Also, I read some of the article you showed as well as the one I found on the dominance frontier file documentation[1], and I feel a lot more enlightened about the subject, thanks! I'll spend more time on them before wrapping this up. [1] Sreedhar and Gao. A linear

r362051 - [PowerPC] Set the default PLT mode on musl to Secure PLT

Author: maskray Date: Wed May 29 19:13:15 2019 New Revision: 362051 URL: http://llvm.org/viewvc/llvm-project?rev=362051=rev Log: [PowerPC] Set the default PLT mode on musl to Secure PLT The musl libc only supports Secure PLT. Patch by A. Wilcox! Reviewed By: jhibbits Differential Revision:

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. I seem to have made good progress on this, although it did require a lot of code changes on LLVM side (basically turning `BasicBlock *` to template arguments). Here's a sample: // <-- //

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. > I wrote some tests but i'm not really sure they're worth it. Mmm, on second thought, they probably won't work out of the box, because they might require installing python modules in order to work. I'm actually not sure if all machines have python3. I'll try but it'll

r362050 - [Driver] -static-pie: add -z text

Author: maskray Date: Wed May 29 18:55:43 2019 New Revision: 362050 URL: http://llvm.org/viewvc/llvm-project?rev=362050=rev Log: [Driver] -static-pie: add -z text This matches gcc -static-pie. The intention is to prevent dynamic relocations in read-only segments. In ld.bfd and gold, -z notext

[PATCH] D62606: [Driver] -static-pie: add -z text

This revision was automatically updated to reflect the committed changes. Closed by commit rL362050: [Driver] -static-pie: add -z text (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202094. NoQ added a comment. Use `os.path.join` for discovering the utility in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202092. NoQ added a comment. Remove outdated comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[PATCH] D62638: [analyzer][WIP] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202091. NoQ added a comment. Abstract away raw prints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1522247 , @aprantl wrote: > -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false > impression. Is there a name that emphasizes that this affects the debug info > of the built compiler? How about

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. In D62623#1521999 , @kwk wrote: > @serge-sans-paille testing it now. Unfortunately, the error for me is similar (or the same) to before; [692/2860] Building CXX object

[libunwind] r362048 - [runtimes] Support ELF dependent libraries feature

Author: phosek Date: Wed May 29 18:34:41 2019 New Revision: 362048 URL: http://llvm.org/viewvc/llvm-project?rev=362048=rev Log: [runtimes] Support ELF dependent libraries feature As of r360984, LLD supports dependent libraries feature for ELF. libunwind, libc++abi and libc++ have library

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

morehouse added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} hctim wrote: > morehouse wrote: > > Can we just link with gtest_main instead of having this? > Unfortunately not easily.

[PATCH] D62638: [analyzer][WIP] A Python script to prettify the ExplodedGraph dumps.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, george.karpenkov. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. That's my attempt

r362045 - clang support gnu asm goto.

Author: jyu2 Date: Wed May 29 18:05:46 2019 New Revision: 362045 URL: http://llvm.org/viewvc/llvm-project?rev=362045=rev Log: clang support gnu asm goto. Syntax: asm [volatile] goto ( AssemblerTemplate : : InputOperands :

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 202084. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov marked 2 inline comments as done. slavapestov added inline comments. Comment at: clang/include/clang/Basic/Attr.td:297 def CUDA : LangOpt<"CUDA">; -def COnly : LangOpt<"CPlusPlus", 1>; +def COnly : LangOpt<"COnly", "!LangOpts.CPlusPlus">; def CPlusPlus :

[PATCH] D62636: Driver, IRGen: Set partitions on GlobalValues according to -fsymbol-partition flag.

pcc created this revision. pcc added a reviewer: rsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62636 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. I totally agree about the space before the opening curly, but the space before the opening paren is a matter of style. Certainly it does match LLVM style better, but it does not match

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 added a comment. In D62049#1522203 , @srhines wrote: > Everything looks great. Thanks for adding these improvements. While it's > probably safe to commit this, perhaps you should give it 24 hours in case > some of the other clang-tidy folks have

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik added a comment. I think the AST dump for `EnumDecl` and `ClassTemplateSpecializationDecl` should be dumping the missing `SourceLocations` but I am having trouble tracking down where that should be done. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62635: Add enums as global variables in the IR metadata.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, aprantl. Herald added projects: clang, LLVM. Keeps track of the enums that were used by saving them as DIGlobalVariables, since CodeView emits debug info for global constants.

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} morehouse wrote: > Can we just link with gtest_main instead of having this? Unfortunately not easily. `generate_compiler_rt_tests` builds each

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202078. hctim marked 21 inline comments as done. hctim added a comment. - Apologies about the delay on this. Updated with Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

aprantl added a comment. -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false impression. Is there a name that emphasizes that this affects the debug info of the built compiler? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik added a comment. So an alternative to testing could be matching the AST output from a `clang-import-test` like we did here: https://reviews.llvm.org/D61140 although it unfortunately looks like only only the AST dump of `NamespaceDecl` output the `SourceLocation` you are fixing, see it

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Everything looks great. Thanks for adding these improvements. While it's probably safe to commit this, perhaps you should give it 24 hours in case some of the other clang-tidy folks have

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 202072. jcai19 marked an inline comment as done. jcai19 added a comment. Remove redundant CHECK-MESSAGES-NOT checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

srhines added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:48 + pipe2(pipefd, O_NONBLOCK); + // CHECK-MESSAGES-NOT: warning: + TEMP_FAILURE_RETRY(pipe2(pipefd, O_NONBLOCK)); Much like line 39 (which covers both

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek updated this revision to Diff 202064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake

[PATCH] D62167: CodeView - add static data members to global variable debug info.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362038: CodeView - add static data members to global variable debug info. (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D62167?vs=202027=202063#toc

r362038 - CodeView - add static data members to global variable debug info.

Author: akhuang Date: Wed May 29 14:45:34 2019 New Revision: 362038 URL: http://llvm.org/viewvc/llvm-project?rev=362038=rev Log: CodeView - add static data members to global variable debug info. Summary: Add static data members to IR debug info's list of global variables so that they are emitted

[PATCH] D62167: CodeView - add static data members to global variable debug info.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/ https://reviews.llvm.org/D62167 ___

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak added a comment. In D61974#1521334 , @theraven wrote: > LGTM. I wonder if we have any other ugly GCC bug compatibility parts in > clang's Objective-C implementation... I see a couple of FIXME comments in ASTContext.cpp that seem to suggest

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

This revision was automatically updated to reflect the committed changes. Closed by commit rC362034: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs (authored by ahatanak, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

r362034 - [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

Author: ahatanak Date: Wed May 29 14:23:30 2019 New Revision: 362034 URL: http://llvm.org/viewvc/llvm-project?rev=362034=rev Log: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs clang was encoding pointers to typedefs as if they were pointers to structs because that is

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 202052. jcai19 added a comment. Add CHECK-MESSAGES-NOT checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files:

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. In D62603#1521979 , @yaxunl wrote: > > I think `static __device__` globals would fall into the same category -- > > nominally they should not be visible outside of device-side object file, > > but in practice we do need to make them

[PATCH] D53720: [analyzer] Remove EndPath function as it is dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rL362030: [analyzer] Remove EndPath function as it is dead code (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. @serge-sans-paille testing it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new/ https://reviews.llvm.org/D62623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r362030 - [analyzer] Remove EndPath function as it is dead code

Author: charusso Date: Wed May 29 13:47:27 2019 New Revision: 362030 URL: http://llvm.org/viewvc/llvm-project?rev=362030=rev Log: [analyzer] Remove EndPath function as it is dead code Summary: - Reviewers: george.karpenkov Reviewed By: george.karpenkov Subscribers: baloghadamsoftware,

r362028 - Revert "LLVM IR: update Clang tests for byval being a typed attribute."

Author: tnorthover Date: Wed May 29 13:45:32 2019 New Revision: 362028 URL: http://llvm.org/viewvc/llvm-project?rev=362028=rev Log: Revert "LLVM IR: update Clang tests for byval being a typed attribute." The underlying LLVM change couldn't cope with llvm-link and broke LTO builds. Modified:

[PATCH] D58207: [analyzer] ConditionBRVisitor: Boolean support

This revision was automatically updated to reflect the committed changes. Closed by commit rL362027: [analyzer] ConditionBRVisitor: Boolean support (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

yaxunl added a comment. In D62603#1521832 , @tra wrote: > In D62603#1521792 , @hliao wrote: > > > that should assume that variable is not declared with `static`. that's also > > the motivation of this patch. > > >

r362027 - [analyzer] ConditionBRVisitor: Boolean support

Author: charusso Date: Wed May 29 13:34:29 2019 New Revision: 362027 URL: http://llvm.org/viewvc/llvm-project?rev=362027=rev Log: [analyzer] ConditionBRVisitor: Boolean support Summary: - Reviewers: NoQ, george.karpenkov Reviewed By: NoQ, george.karpenkov Subscribers: cfe-commits, xazax.hun,

[PATCH] D58206: [analyzer] ConditionBRVisitor: MemberExpr support

This revision was automatically updated to reflect the committed changes. Closed by commit rC362026: [analyzer] ConditionBRVisitor: MemberExpr support (authored by Charusso, committed by ). Changed prior to commit: https://reviews.llvm.org/D58206?vs=195073=202044#toc Repository: rC Clang

r362026 - [analyzer] ConditionBRVisitor: MemberExpr support

Author: charusso Date: Wed May 29 13:29:02 2019 New Revision: 362026 URL: http://llvm.org/viewvc/llvm-project?rev=362026=rev Log: [analyzer] ConditionBRVisitor: MemberExpr support Summary: - Reviewers: NoQ, george.karpenkov Reviewed By: NoQ Subscribers: cfe-commits, xazax.hun,

[PATCH] D58199: [analyzer] ConditionBRVisitor: Remove duplicated code

This revision was automatically updated to reflect the committed changes. Closed by commit rL362025: [analyzer] ConditionBRVisitor: Remove duplicated code (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille created this revision. serge-sans-paille added reviewers: vsk, arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. serge-sans-paille edited the summary of this revision. Avoiding an intermediate join operation, which in turns removes the

r362025 - [analyzer] ConditionBRVisitor: Remove duplicated code

Author: charusso Date: Wed May 29 13:18:07 2019 New Revision: 362025 URL: http://llvm.org/viewvc/llvm-project?rev=362025=rev Log: [analyzer] ConditionBRVisitor: Remove duplicated code Summary: - Reviewers: NoQ, george.karpenkov Reviewed By: NoQ Subscribers: cfe-commits, xazax.hun,

[PATCH] D61060: [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false'

This revision was automatically updated to reflect the committed changes. Closed by commit rL362023: [analyzer] ConditionBRVisitor: Test add-pop-up-notes=false (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362023 - [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false'

Author: charusso Date: Wed May 29 13:13:29 2019 New Revision: 362023 URL: http://llvm.org/viewvc/llvm-project?rev=362023=rev Log: [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false' Summary: - Reviewers: NoQ, alexfh Reviewed By: alexfh Subscribers: cfe-commits, xazax.hun,

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek created this revision. phosek added reviewers: beanz, smeenai. Herald added subscribers: llvm-commits, cfe-commits, aprantl, mgorny. Herald added projects: clang, LLVM. CMake always uses absolute file paths in the generated compiler invocation which results in absolute file paths being

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 202030. jcai19 added a comment. Add CHECK-MESSAGES-NOT checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files:

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:52 + +void e() { + int pipefd[2]; srhines wrote: > jcai19 wrote: > > srhines wrote: > > > I'm not all that familiar

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

Ka-Ka added a comment. What about a testcase? It shouldn't be hard to add a small testcase that demonstrate that the changed builtins now work when compiling OpenCL C code for x86. I don't think you have to add all changed builtins to the testcase (but a few to demonstrate the change).

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

kparzysz added a comment. This commit stopped clang++ from finding libc++: main.cc: #include int main() { std::vector x; return x.size(); } $ clang++ main.cc -stdlib=libc++ -v clang version 9.0.0 (/w/src/llvm.org/tools/clang 754813c4737a444eeb4ea5b4070073dd251504cc)

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang updated this revision to Diff 202027. akhuang added a comment. Herald added a subscriber: hiraditya. Append class name to static data member debug info name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ymandel updated this revision to Diff 202026. ymandel added a comment. added comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62621/new/ https://reviews.llvm.org/D62621 Files: clang/include/clang/Tooling/Refactoring/Transformer.h

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. In D62619#1521824 , @kuhar wrote: > You can easily get CD by calculating the PostDominanceFrontier. LLVM > implements a templated IDF (Iterated Dominance Frontier) construction. > A native implementation for llvm ir for

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. In D62603#1521832 , @tra wrote: > In D62603#1521792 , @hliao wrote: > > > that should assume that variable is not declared with `static`. that's also > > the motivation of this patch. > > >

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. `change()` is an all purpose function; the revision adds simple shortcuts for the specific operations of inserting (before/after) or removing source. Repository: rG LLVM Github Monorepo

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. In D62603#1521792 , @hliao wrote: > that should assume that variable is not declared with `static`. that's also > the motivation of this patch. cppreference defines internal linkage as 'The name can be referred to from all scopes

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

kuhar added a comment. You can easily get CD by calculating the PostDominanceFrontier. LLVM implements a templated IDF (Iterated Dominance Frontier) construction. A native implementation for llvm ir for reference, if you need: -

[PATCH] D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece

This revision was automatically updated to reflect the committed changes. Closed by commit rC362014: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece (authored by Charusso, committed by ). Changed prior to commit: https://reviews.llvm.org/D60670?vs=200109=202021#toc

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus created this revision. Szelethus added reviewers: kuhar, NoQ, dcoughlin, xazax.hun, rnkovacs, baloghadamsoftware, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus

r362014 - [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece

Author: charusso Date: Wed May 29 12:21:59 2019 New Revision: 362014 URL: http://llvm.org/viewvc/llvm-project?rev=362014=rev Log: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece Summary: This new piece is similar to our macro expansion printing in HTML reports: On mouse-hover

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. In D62603#1521788 , @tra wrote: > >> NVCC also allows that: https://godbolt.org/z/t78RvM > > > > BTW, that code posted looks quite weird to me, how the code could make > > sense by return a pointer of device variable? or a pointer

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. >> NVCC also allows that: https://godbolt.org/z/t78RvM > > BTW, that code posted looks quite weird to me, how the code could make sense > by return a pointer of device variable? or a pointer of shadow host variable? Magic. :-) More practical example would be something like

r362013 - LLVM IR: update Clang tests for byval being a typed attribute.

Author: tnorthover Date: Wed May 29 12:13:29 2019 New Revision: 362013 URL: http://llvm.org/viewvc/llvm-project?rev=362013=rev Log: LLVM IR: update Clang tests for byval being a typed attribute. Since byval is now a typed attribute it gets sorted slightly differently by LLVM when the order of

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Conditional approval, commit with the comment fixed. Let me know if you need me to commit it for you. Comment at: clang/include/clang/Basic/Builtins.def:56 // N

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. In D62603#1521503 , @tra wrote: > In D62603#1521484 , @hliao wrote: > > > thanks, but that `static __device__` variable won't have shadow in host > > anymore. > > > Why not? Your change only

r362011 - [analyzer] print() JSONify chain: Generic stmt_id

Author: charusso Date: Wed May 29 11:58:41 2019 New Revision: 362011 URL: http://llvm.org/viewvc/llvm-project?rev=362011=rev Log: [analyzer] print() JSONify chain: Generic stmt_id Summary: Some environment create less statements so make them generic. Modified:

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: kadircet, arphaman, jkorous. Herald added a project: clang. E.g. we now turn `while(<#cond#>){` into `while (<#cond#>) {` This slightly improves the final output. Should not affect clients

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. In D62603#1521503 , @tra wrote: > In D62603#1521484 , @hliao wrote: > > > thanks, but that `static __device__` variable won't have shadow in host > > anymore. > > > Why not? Your change only

r362009 - [analyzer] SATestBuild.py: Use driver for analyzing single-file tests.

Author: dergachev Date: Wed May 29 11:49:31 2019 New Revision: 362009 URL: http://llvm.org/viewvc/llvm-project?rev=362009=rev Log: [analyzer] SATestBuild.py: Use driver for analyzing single-file tests. Don't bother coming up with a -cc1 run-line ourselves. This, in particular, gets rid of a

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus updated this revision to Diff 202004. Szelethus added a comment. Fixes according to reviewer comments, thanks! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 Files: clang/unittests/Analysis/CFGBuilder.h

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:95 + CFGPostDomTree PostDom; + PostDom.buildDominatorTree(cfg); + kuhar wrote: > Why not have a constructor that takes the

[PATCH] D62497: [analyzer] print() JSONify: SVal implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL362008: [analyzer] print() JSONify: SVal implementation (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

mantognini added inline comments. Comment at: lib/Sema/SemaType.cpp:7355 + // object. + (D.getContext() == DeclaratorContext::AliasDeclContext) || // Do not deduce addr space for types used to define a typedef and the I think this should also

r362008 - [analyzer] print() JSONify: SVal implementation

Author: charusso Date: Wed May 29 11:38:52 2019 New Revision: 362008 URL: http://llvm.org/viewvc/llvm-project?rev=362008=rev Log: [analyzer] print() JSONify: SVal implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subscribers:

r362005 - Fix an unused-variable error.

Author: hokein Date: Wed May 29 11:36:54 2019 New Revision: 362005 URL: http://llvm.org/viewvc/llvm-project?rev=362005=rev Log: Fix an unused-variable error. Modified: cfe/trunk/lib/StaticAnalyzer/Core/Environment.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/Environment.cpp URL:

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

ilya-biryukov added inline comments. Comment at: clang/lib/Index/IndexSymbol.cpp:99 + if (auto *VT = dyn_cast(D)) { +Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic; kadircet wrote: > ilya-biryukov wrote: > > kadircet wrote: > > > what about

[PATCH] D62615: [CodeComplete] Include more text into typed chunks of pattern completions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: clang. To allow filtering on any of the words in the editors. In particular, the following completions were changed: - 'using namespace <#name#>' Typed text before: 'using', after: 'using

  1   2   3   >