[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362672: android: add a close-on-exec check on pipe2() (authored by gbiv, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362673: android: add a close-on-exec check on pipe() (authored by gbiv, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r362673 - android: add a close-on-exec check on pipe()

Author: gbiv Date: Wed Jun 5 22:21:45 2019 New Revision: 362673 URL: http://llvm.org/viewvc/llvm-project?rev=362673=rev Log: android: add a close-on-exec check on pipe() On Android, pipe() is better to be replaced by pipe2() with O_CLOEXEC flag to avoid file descriptor leakage. Patch by Jian

[clang-tools-extra] r362672 - android: add a close-on-exec check on pipe2()

Author: gbiv Date: Wed Jun 5 22:21:39 2019 New Revision: 362672 URL: http://llvm.org/viewvc/llvm-project?rev=362672=rev Log: android: add a close-on-exec check on pipe2() On Android, pipe2() is better to set O_CLOEXEC flag to avoid file descriptor leakage. Patch by Jian Cai! Differential

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

NoQ added a comment. Aha, that's something! And nice to see we've already had this bug covered with tests. Because, of course, i added these tests a year ago without even thinking about what the correct behavior should look like :/ Comment at:

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

wuzish added a comment. > That (controlling within the headers) sounds good to me. When that lands, > then my understanding is that the `PPCLinuxToolChain` code would be adjusted > to include `ppc_wrappers` in the search path in the general case. Please let > me know if that's not the case.

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 203276. shixiao edited the summary of this revision. shixiao added a comment. Herald added subscribers: sunfish, aheejin, kristof.beyls, tpr, javed.absar. update commit summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 203275. shixiao added a comment. rebase, fix comments, enable for c++2a, add report for running the check on llvm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rL362667: [WebAssembly] Support Leak Sanitizer on Emscripten (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362667 - [WebAssembly] Support Leak Sanitizer on Emscripten

Author: tlively Date: Wed Jun 5 18:38:12 2019 New Revision: 362667 URL: http://llvm.org/viewvc/llvm-project?rev=362667=rev Log: [WebAssembly] Support Leak Sanitizer on Emscripten Summary: LSan is currently being ported to Emscripten and mostly works. Enabling the support in upstream would

[PATCH] D62636: Driver, IRGen: Set partitions on GlobalValues according to -fsymbol-partition flag.

pcc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62636/new/ https://reviews.llvm.org/D62636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus added a comment. > I think we should make clear that this visitor only operates within one > function and does not track controll dependencies across functions. Hmm, maybe it's worth investigating whether if we pop the call stack, does the bug report improve if we update the visitor

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Szelethus added inline comments. Comment at: clang/test/Analysis/new-ctor-null-throw.cpp:1-3 +// RUN: %clang_analyze_cc1 \ +// RUN: -analyzer-checker=core,debug.ExprInspection \ +// RUN: -std=c++11 -verify %s Hmm, how come you removed `-analyzer-config

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

erik.pilkington added a comment. I think this looks good from a clang perspective. No reason to land it before the dust settles on D62433 though. Do you think we can also add this attribute (or something like it) onto allocas of `_NSConcreteStackBlock`s? They

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

ahatanak added inline comments. Comment at: test/CodeGenObjC/local-static-block.m:5 +// CHECK: @{{.*}} = internal constant { i8**, i32, i32, i8*, %struct.__block_descriptor* } { i8** @_NSConcreteGlobalBlock, i32 1342177280, i32 0, i8* bitcast (%0* (i8*, %0*, i64)* @{{.*}} to

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

ahatanak updated this revision to Diff 203247. ahatanak marked 5 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62831/new/ https://reviews.llvm.org/D62831 Files:

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: test/CodeGenObjC/local-static-block.m:59-60 // CHECK-LABEL-LP64: define void @FUNC2( // CHECK: define internal void @_block_invoke{{.*}}( // CHECK: call void %{{.*}}(i8* bitcast ({ i8**,

r362651 - Fix FileCheck prefixes in test case.

Author: ahatanak Date: Wed Jun 5 14:11:06 2019 New Revision: 362651 URL: http://llvm.org/viewvc/llvm-project?rev=362651=rev Log: Fix FileCheck prefixes in test case. Modified: cfe/trunk/test/CodeGenObjC/local-static-block.m Modified: cfe/trunk/test/CodeGenObjC/local-static-block.m URL:

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

This revision was automatically updated to reflect the committed changes. Closed by commit rL362646: [clang-format][NFC] Fix BS_Allman style example in the header docs are… (authored by jkorous, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r362646 - [clang-format][NFC] Fix BS_Allman style example in the header docs are generated from

Author: jkorous Date: Wed Jun 5 13:59:48 2019 New Revision: 362646 URL: http://llvm.org/viewvc/llvm-project?rev=362646=rev Log: [clang-format][NFC] Fix BS_Allman style example in the header docs are generated from Differential Revision: https://reviews.llvm.org/D61729 Modified:

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61729/new/ https://reviews.llvm.org/D61729 ___ cfe-commits mailing list

[PATCH] D59744: Fix i386 ABI "__m64" type bug

joerg added a comment. I think MMX code is obscure enough at this point that it doesn't matter much either way. Even less across DSO boundaries. That's why I don't really care either way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744

[PATCH] D62924: [cmake] Remove duplicate TestingSupport library for linking

This revision was automatically updated to reflect the committed changes. Closed by commit rGe34d1a4e07b8: [cmake] Remove duplicate TestingSupport library for linking (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62924/new/

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. When we traversed backwards on

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

pzheng added inline comments. Comment at: cfe/trunk/unittests/Tooling/CMakeLists.txt:4 Support TestingSupport ) quantum wrote: > thakis wrote: > > The library is already up here. Why do we need it twice? > We don't. It's removed in the code that's

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @Meinersbur Itested with the following configuration cmake3 ../llvm -DLLVM_EXTERNAL_PROJECTS=bye -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 cmake3 ../llvm -DLLVM_EXTERNAL_PROJECTS=bye -DBUILD_SHARED_LIBS=ON

[PATCH] D62924: [cmake] Remove duplicate TestingSupport library for linking

pzheng created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This patch cleans up a duplicate use of TestingSupport library. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62924 Files: clang/unittests/Tooling/CMakeLists.txt

[PATCH] D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece

Charusso added a comment. Fix a nit in rL362632 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60670/new/ https://reviews.llvm.org/D60670 ___ cfe-commits mailing list

r362632 - [analyzer] PathDiagnosticPopUpPiece: working with CharSourceRange

Author: charusso Date: Wed Jun 5 11:55:39 2019 New Revision: 362632 URL: http://llvm.org/viewvc/llvm-project?rev=362632=rev Log: [analyzer] PathDiagnosticPopUpPiece: working with CharSourceRange Summary: Sometimes we are at character boundaries so past the token-range. Modified:

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

richardmembarth added a comment. Thanks for clarification and merging! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54258/new/ https://reviews.llvm.org/D54258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

erik.pilkington added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1441 + cast(literal)->addAttribute("arc_retain_agnostic"); + Can't you just declare `literal` as a GlobalVariable instead of immediately casting it? Comment at:

[PATCH] D62279: Use LTO capable linker

This revision was automatically updated to reflect the committed changes. Closed by commit rL362624: Use LTO capable linker (authored by cbieneman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362624 - Use LTO capable linker

Author: cbieneman Date: Wed Jun 5 10:35:38 2019 New Revision: 362624 URL: http://llvm.org/viewvc/llvm-project?rev=362624=rev Log: Use LTO capable linker Summary: In DistributionExample.cmake be sure we use a LTO capable linker, the easiest to choose is lld. Reviewers: beanz Reviewed By: beanz

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

Anastasia added a comment. In D54258#1528872 , @richardmembarth wrote: > Merging in two weeks is fine for me. No worries. I have just committed this. > My assumption was that accepted patches are merged into upstream in a timely > manner. > Maybe

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

beanz added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:820 + +set(LLVM_ALL_EXTENSION_TARGETS clang;bugpoint;opt) +foreach(tool ${LLVM_ALL_EXTENSION_TARGETS}) I don't think we should hard code this list. It would be much

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL362623: [Clang] Fix pretty printing of CUDA address spaces (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362623 - [Clang] Fix pretty printing of CUDA address spaces

Author: stulova Date: Wed Jun 5 10:29:00 2019 New Revision: 362623 URL: http://llvm.org/viewvc/llvm-project?rev=362623=rev Log: [Clang] Fix pretty printing of CUDA address spaces Patch by richardmembarth (Richard Membarth)! Differential Revision: https://reviews.llvm.org/D54258 Modified:

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. Sorry, you might have tested it with `LLVM_LINK_POLLY_INTO_TOOLS=OFF` and/or `BUILD_SHARED_LIBS`/`LLVM_LINK_LLVM_DYLIV` where it might work, but unfortunately not with the default configuration using static component libraries. Repository: rG LLVM Github

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan added a comment. In D62225#1519394 , @efriedma wrote: > Are the behavior differences between the newpm alwaysinliner and the oldpm > alwaysinliner intentional? Specifically, the differences in pass remarks, > and the differences in the

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. This fails with Polly/Linux regression tests: FAIL: Polly :: Simplify/gemm.ll (1148 of 1149) TEST 'Polly :: Simplify/gemm.ll' FAILED Script: -- : 'RUN: at line 1'; opt

[PATCH] D62915: git-clang-format: Remove trailing whitespace in docstring. NFC.

sbc100 created this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62915 Files: clang/tools/clang-format/git-clang-format Index: clang/tools/clang-format/git-clang-format

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a comment. In D59673#1527487 , @aaronpuchert wrote: > In D59673#1521413 , @dblaikie wrote: > > > Might be easier as a few patches - renaming the existing option, adding the > > new one, then

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia added a comment. Ping! I would appreciate any feedback to this change please. Thanks you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 ___ cfe-commits mailing list

[PATCH] D58060: Fix diagnostic for addr spaces in reference binding

Anastasia abandoned this revision. Anastasia added a comment. Due to my recent commits I had to changed this slightly so it is now under a new review: https://reviews.llvm.org/D62914 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58060/new/ https://reviews.llvm.org/D58060

[PATCH] D62914: [Sema] Fix diagnostic for addr spaces in reference binding

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added subscribers: ebevhan, javed.absar. Extend reference binding behavior to account for address spaces. This change also fixes the diagnostic wording (for qualifier mismatch in reference binding) and simplifies it

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

skan updated this revision to Diff 203170. skan added a comment. When target feature `avx512bf16` is enabled, `avx512vl` is not enabled implicity for some reasons by now. But `_mm_cvtness_sbh`, `_mm256_cvtpbh_ps` , `_mm256_maskz_cvtpbh_ps` , `_mm256_mask_cvtpbh_ps` need `avx512vl` feature. So

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

dnsampaio abandoned this revision. dnsampaio added a comment. Fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60828/new/ https://reviews.llvm.org/D60828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r362551 - Convert MemberExpr creation and serialization to work the same way as

On Wed, 5 Jun 2019, 04:44 Benjamin Kramer via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > It also crashes during clang selfhost with modules and libc++. Let me know > if you need a precise reproducer command. > Yes, please. I reverted this change and the dependent r362563 in r362597. >

[PATCH] D33841: [clang-tidy] redundant 'extern' keyword check

lebedev.ri added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:30 + + if (FD->getStorageClass() != SC_Extern) +return; Can you do that in `registerMatchers()`? Comment at:

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added a comment. > I think the name `ppc_wrappers` is accurate to describe its meaning that > wrapping the headers under standard library path or standard header search > path. Thanks for clarifying this for me. In the case where all of the headers are expected to be

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362611: [OpenCL][PR42031] Prevent deducing addr space in type alias. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362611 - [OpenCL][PR42031] Prevent deducing addr space in type alias.

Author: stulova Date: Wed Jun 5 07:50:01 2019 New Revision: 362611 URL: http://llvm.org/viewvc/llvm-project?rev=362611=rev Log: [OpenCL][PR42031] Prevent deducing addr space in type alias. Similar to typedefs we shouldn't deduce addr space in type alias. Differential Revision:

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel updated this revision to Diff 203154. koldaniel added a comment. Updating warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33841 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

r362607 - Avoid using NoThrow Exception Specifier in non-C++ Modes.

Author: erichkeane Date: Wed Jun 5 07:10:39 2019 New Revision: 362607 URL: http://llvm.org/viewvc/llvm-project?rev=362607=rev Log: Avoid using NoThrow Exception Specifier in non-C++ Modes. As reported in https://bugs.llvm.org/show_bug.cgi?id=42113, there are a number of locations in Clang where

[PATCH] D61318: [Sema] Prevent binding references with mismatching address spaces to temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rL362604: [Sema] Prevent binding incompatible addr space ref to temporaries (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r362604 - [Sema] Prevent binding incompatible addr space ref to temporaries

Author: stulova Date: Wed Jun 5 07:03:34 2019 New Revision: 362604 URL: http://llvm.org/viewvc/llvm-project?rev=362604=rev Log: [Sema] Prevent binding incompatible addr space ref to temporaries References to arbitrary address spaces can't always be bound to temporaries. This change extends the

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362600: [ARM] Allow -march=foo+fp to vary with foo (authored by SjoerdMeijer, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

r362601 - [ARM] Allow "-march=foo+fp" to vary with foo

Author: sjoerdmeijer Date: Wed Jun 5 06:12:01 2019 New Revision: 362601 URL: http://llvm.org/viewvc/llvm-project?rev=362601=rev Log: [ARM] Allow "-march=foo+fp" to vary with foo Now, when clang processes an argument of the form "-march=foo+x+y+z", then instead of calling getArchExtFeature() for

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop updated this revision to Diff 203124. russell.gallop added a comment. Re-added test cases using variables and added comment. This now tests both formats. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62850/new/ https://reviews.llvm.org/D62850 Files:

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ymandel updated this revision to Diff 203122. ymandel marked an inline comment as done. ymandel added a comment. adjusted API comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62621/new/ https://reviews.llvm.org/D62621 Files:

Re: r362551 - Convert MemberExpr creation and serialization to work the same way as

It also crashes during clang selfhost with modules and libc++. Let me know if you need a precise reproducer command. I reverted this change and the dependent r362563 in r362597. On Wed, Jun 5, 2019 at 9:37 AM Martin Storsjö via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This broke

r362597 - Revert "Factor out duplicated code building a MemberExpr and marking it" and "Convert MemberExpr creation and serialization to work the same way as"

Author: d0k Date: Wed Jun 5 04:46:57 2019 New Revision: 362597 URL: http://llvm.org/viewvc/llvm-project?rev=362597=rev Log: Revert "Factor out duplicated code building a MemberExpr and marking it" and "Convert MemberExpr creation and serialization to work the same way as" This reverts commits

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. While I managed to create a version of `llvm::IDFCalculator` that both compiles and works well with `clang::CFGBlock *`, I'm a little unsure about the specifics. I sent out a mail to reach a wider audience about the next steps:

[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, dcoughlin, baloghadamsoftware, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Repository: rC

[PATCH] D62127: [Hexagon] driver uses out-of-date option name and binary name

t.yomitch added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62127/new/ https://reviews.llvm.org/D62127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`

baloghadamsoftware added a comment. This patch definitely reduces the number of false positives, but may not be enough. The problem is that `std::advance()` may call another function that does the actual incremention or decremention, in the `gcc` implementation it is `__advance()`. If the

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

yvvan accepted this revision. yvvan added a comment. This revision is now accepted and ready to land. libclang part is quite small here and looks ok. I would just accept it Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. Fair enough, I don't think we currently try to diagnose any other invalid combinations of features. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 203115. Tyker marked an inline comment as done. Tyker edited the summary of this revision. Tyker added a comment. changed as requested. hasExplicitSpecifier now gives access to the expression if present. CHANGES SINCE LAST ACTION

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. In D60763#1529279 , @Nicola wrote: > A bit late to the review, but I've noticed a couple of issues with some of > the implemented builtins: > > - The fmin/fmax builtins are defined twice for scalar types, does this create >

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

xazax.hun requested changes to this revision. xazax.hun added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:176 + const ExplodedNode *Origin; + CFGControlDependencyTree

[PATCH] D62895: [Analyzer] Iterator Checkers - Check and simulate `std::advance`, `std::prev` and `std::next`

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. baloghadamsoftware added a

[PATCH] D62611: [analyzer][Dominators] Add unittests

xazax.hun added a comment. Oh, I realized later that code I commented on were only moved from somewhere else. If you feel like tackling these comments feel free to do so in a separate patch so this one stays clean (no changes to moved code). Comment at:

[PATCH] D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal

baloghadamsoftware added a comment. I left errors caused by mismatched iterators non-fatal for now. This is debatable because passing a function expecting a range iterators for two different containers or applying a container modifier using a mismatched iterator also leads to undefined

[PATCH] D62893: [Analyzer] Iterator Checkers - Make range errors and invalidated access fatal

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Range errors (dereferencing or

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

xazax.hun added a comment. I did not check the algorithm as you planned changes to that. I only did a quick review of the interface which might also be rendered obsolete once you update this patch. Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:191 + +

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

xazax.hun requested changes to this revision. xazax.hun added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1088 + // descriptions (eg., the ones for C functions that just match the

[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

xazax.hun accepted this revision. xazax.hun added a comment. Nice one :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62557/new/ https://reviews.llvm.org/D62557 ___ cfe-commits mailing list

[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Once Aleksei's comments are resolved it is good to go. My comments are notes and not requests. Comment at:

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

xazax.hun added a comment. The only problem I see with this approach is that it is an all or nothing thing at the moment. Most of the checks in CSA can have false positives and people usually do not want to fail a build due to a false positive finding. This would force the users to do two

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

This revision was automatically updated to reflect the committed changes. Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027 (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362587 - [clang] [test] Add a (xfailing) test for PR41027

Author: mgorny Date: Wed Jun 5 01:21:42 2019 New Revision: 362587 URL: http://llvm.org/viewvc/llvm-project?rev=362587=rev Log: [clang] [test] Add a (xfailing) test for PR41027 Add a test for tracking PR41027 (8.0 regression breaking assembly code relying on __builtin_constant_p() to identify

Re: r362551 - Convert MemberExpr creation and serialization to work the same way as

This broke building of Qt when using PCH. Selfcontained repro is a bit hard to make though... // Martin On Tue, 4 Jun 2019, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Jun 4 14:29:28 2019 New Revision: 362551 URL: http://llvm.org/viewvc/llvm-project?rev=362551=rev Log:

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

uabelho added inline comments. Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925 +// FIXME: this should only be set on CK_CurrentParameter. +Signal.ContainsActiveParameter = true; + } Hi! gcc (7.4) warns on this code: ``` error:

r362585 - [CMake][Fuchsia] Use libc++ ABIv2 for the first stage build

Author: phosek Date: Tue Jun 4 23:58:41 2019 New Revision: 362585 URL: http://llvm.org/viewvc/llvm-project?rev=362585=rev Log: [CMake][Fuchsia] Use libc++ ABIv2 for the first stage build This also unifies flags between macOS and Linux builds. Modified: cfe/trunk/cmake/caches/Fuchsia.cmake

[PATCH] D62623: Reduce memory consumption of coverage dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cd07dbeec98: Reduce memory consumption of coverage dumps (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new/

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 203086. serge-sans-paille added a comment. - get Rid of the constraint on initializePasses : it can be registered suing a static constructor, no need to clutter the API with it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r362584 - Reduce memory consumption of coverage dumps

Author: serge_sans_paille Date: Tue Jun 4 23:35:10 2019 New Revision: 362584 URL: http://llvm.org/viewvc/llvm-project?rev=362584=rev Log: Reduce memory consumption of coverage dumps Avoiding an intermediate join operation removes the need for an intermediate buffer that may be quite large, as

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. In D62621#1529691 , @ymandel wrote: > Thanks for the review. > > Good questions. The answer to both is that it depends on the