[PATCH] D59744: Fix i386 ABI "__m64" type bug

hans added a comment. I've reverted in r363790 until a solution can be found. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list

r363790 - Revert r363116 "[X86] [ABI] Fix i386 ABI "__m64" type bug"

Author: hans Date: Wed Jun 19 04:34:08 2019 New Revision: 363790 URL: http://llvm.org/viewvc/llvm-project?rev=363790=rev Log: Revert r363116 "[X86] [ABI] Fix i386 ABI "__m64" type bug" This introduced MMX instructions in code that wasn't previously using them, breaking programs using 64-bit

[PATCH] D63417: [RISCV] Specify registers used for exception handling

edward-jones updated this revision to Diff 205542. edward-jones retitled this revision from "[WIP][RISCV] Specify registers used for exception handling" to "[RISCV] Specify registers used for exception handling". edward-jones edited the summary of this revision. edward-jones added a comment.

[PATCH] D59744: Fix i386 ABI "__m64" type bug

hans added a comment. In D59744#1549746 , @hans wrote: > In D59744#1549675 , @wxiao3 wrote: > > > Can anyone provide me some small reproducers code for the issue tripped > > over by Chromium / Skia? > > > Sorry, I

r363788 - [analyzer][NFC][tests] Pre-normalize expected-sarif files

Author: hubert.reinterpretcast Date: Wed Jun 19 04:19:51 2019 New Revision: 363788 URL: http://llvm.org/viewvc/llvm-project?rev=363788=rev Log: [analyzer][NFC][tests] Pre-normalize expected-sarif files As discussed in the review for D62952, this patch pre-normalizes the reference expected output

[PATCH] D63426: [clangd] Narrow rename to local symbols.

hokein added a comment. Use the hybrid approach based on our discussion, the implementation should be fine to review, I'm still working on adding more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63426/new/ https://reviews.llvm.org/D63426

[PATCH] D63426: [clangd] Narrow rename to local symbols.

hokein updated this revision to Diff 205541. hokein added a comment. Remove the unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63426/new/ https://reviews.llvm.org/D63426 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D63426: [clangd] Narrow rename to local symbols.

hokein updated this revision to Diff 205540. hokein marked an inline comment as done. hokein added a comment. Switch to a hybrid solution (language semantic + index) to detect "symbol local". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, + bool StoreResult = true); ExprResult

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

ilya-biryukov updated this revision to Diff 205537. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62953/new/ https://reviews.llvm.org/D62953 Files:

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

ilya-biryukov marked 7 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:318 + /// 2. macro name and arguments for macro expansions. + using SpelledMappings = + llvm::DenseMap;

[PATCH] D59744: Fix i386 ABI "__m64" type bug

RKSimon added a comment. I've raised https://bugs.llvm.org/show_bug.cgi?id=42319 which suggests the creation of a EMMS insertion pass. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

gribozavr added a comment. Thanks! Please add tests in `./unittests/Tooling/ReplacementsYamlTest.cpp`. Comment at: clang/include/clang/Tooling/ReplacementsYaml.h:43 +ReplacementText.replace(lineBreakPos, 1, "\n\n"); +// Get the next occurrence from the current

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, a_sidorin, baloghadamsoftware, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. For

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:733 +else + Init->printPretty(ValueOS, nullptr, Policy); + } sammccall wrote: > why not print the non-evaluated init if it's dependent? not-necessary anymore,

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet updated this revision to Diff 205530. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63330/new/ https://reviews.llvm.org/D63330 Files:

[PATCH] D63508: make -frewrite-includes handle __has_include wrapped in a macro

torarnv added a comment. Just a thought: From the point of view of `-frewrite-includes`, it should technically do full/nested macro expansion right? But from the point of view of Icecream, that would defeat the purpose of using `-frewrite-includes`, since the goal is to embed all includes into

[PATCH] D63508: make -frewrite-includes handle __has_include wrapped in a macro

llunak added a comment. The code uses a raw lexer, so it doesn't expand macros. Thus the piece of code quoted will not get the "#if QT_HAS_INCLUDE()" part rewritten. My specific use case is the Icecream distributed build tool which does remote builds in a chroot and so this #if will be false

[PATCH] D57055: [RISCV] Mark TLS as supported

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363776: [RISCV] Mark TLS as supported (authored by lewis-revill, committed by ). Herald added a project: LLVM. Herald

[PATCH] D59744: Fix i386 ABI "__m64" type bug

hans added a comment. In D59744#1549675 , @wxiao3 wrote: > Can anyone provide me some small reproducers code for the issue tripped over > by Chromium / Skia? Sorry, I don't have a small repro yet. I'm still working on finding out exactly what's

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

sammccall added a comment. Sorry, I'm having trouble understanding this patch. Can you try to find some clearer names for the new concepts, or describe how they differ? Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:318 + /// 2. macro name and arguments for macro

[clang-tools-extra] r363766 - Revert "[clangd] Return vector from applyTweak. NFC"

Author: sammccall Date: Wed Jun 19 00:29:10 2019 New Revision: 363766 URL: http://llvm.org/viewvc/llvm-project?rev=363766=rev Log: Revert "[clangd] Return vector from applyTweak. NFC" This reverts commit r363691. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[clang-tools-extra] r363765 - [clangd] Add ClangdServer accessor for buffer contents

Author: sammccall Date: Wed Jun 19 00:29:05 2019 New Revision: 363765 URL: http://llvm.org/viewvc/llvm-project?rev=363765=rev Log: [clangd] Add ClangdServer accessor for buffer contents Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp

[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

Szelethus updated this revision to Diff 205511. Szelethus added a comment. Added a proper testfile. The only downside of it, is that it doesn't test anything. Literally nothing would change is I didn't mark the fields interesting. I'll take this back to the drawing board. CHANGES SINCE LAST

<    1   2   3