[PATCH] D64119: [PowerPC] Support constraint code "ww"

This revision was automatically updated to reflect the committed changes. Closed by commit rL365106: [PowerPC] Support constraint code ww (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D64119?vs=207707=207971#toc Repository: rL LLVM CHANGES SINCE

r365106 - [PowerPC] Support constraint code "ww"

Author: maskray Date: Wed Jul 3 21:44:42 2019 New Revision: 365106 URL: http://llvm.org/viewvc/llvm-project?rev=365106=rev Log: [PowerPC] Support constraint code "ww" Summary: "ww" and "ws" are both constraint codes for VSX vector registers that hold scalar double data. "ww" is preferred for

[PATCH] D64119: [PowerPC] Support constraint code "ww"

MaskRay marked an inline comment as done. MaskRay added a comment. float ws_float(float x, float y) { __asm__ ("xsadddp %0, %1, %2" : "=ws"(x) : "ws"(x), "ws"(y)); return x; } float ww_float(float x, float y) { __asm__ ("xsadddp %0, %1, %2" : "=ww"(x) : "ww"(x), "ww"(y));

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

MaskRay added a comment. `-mlong-double-128` is not supported now. The mangling scheme of `-mlong-double-64` is consistent with gcc on x86 and ppc. % g++ a.cc -S -o - | grep '^_Z3foo' _Z3fooe: % g++ a.cc -S -o - -mlong-double-64 | grep '^_Z3foo' _Z3fooe: % g++ a.cc -S -o -

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

MaskRay updated this revision to Diff 207965. MaskRay edited the summary of this revision. MaskRay added a comment. Add tests to check mangling of long double -mlong-double-64 has no effect on gcc x86. On gcc ppc, -mlong-double-64 changes the mangled type from 'g' (ibmlongdouble) to 'e'

[PATCH] D64119: [PowerPC] Support constraint code "ww"

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for investigating GCC behavior. Comment at: clang/lib/Basic/Targets/PPC.h:211 + case 's': // VSX vector register to hold scalar double data + case 'w': //

[PATCH] D64119: [PowerPC] Support constraint code "ww"

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:211 + case 's': // VSX vector register to hold scalar double data + case 'w': // VSX vector register to hold scalar double data case 'a': // Any

[PATCH] D64119: [PowerPC] Support constraint code "ww"

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/test/CodeGen/PowerPC/inlineasm-vsx-reg.ll:42 + +define float @test_ww(float %x, float %y) { + %1 = tail call float asm "xsmaxdp ${0:x}, ${1:x}, ${2:x}", "=^ww,^ww,^ww"(float %x, float %y)

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert added a comment. `ninja check-all` passed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

hfinkel added a comment. In D64128#1569817 , @rjmccall wrote: > The pointer/integer conversion is "implementation-defined", but it's not > totally unconstrained. C notes that "The mapping functions for converting a > pointer to an integer or an integer

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:1844 + let Documentation = [Undocumented]; +} + Oh, please add a comment on this explaining what it means, since it's not based on a language feature. Repository: rC Clang CHANGES

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62645/new/ https://reviews.llvm.org/D62645 ___

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

rjmccall added a comment. The pointer/integer conversion is "implementation-defined", but it's not totally unconstrained. C notes that "The mapping functions for converting a pointer to an integer or an integer to a pointer are intended to be consistent with the addressing structure of the

[PATCH] D64119: [PowerPC] Support constraint code "ww"

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14080 return std::make_pair(0U, ::VSRCRegClass); - } else if (Constraint == "ws" && Subtarget.hasVSX()) { + } else if ((Constraint == "ws" ||

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

hfinkel added a comment. In D64128#1569590 , @efriedma wrote: > > If they're all syntactically together like this, maybe that's safe? > > Having them together syntactically doesn't really help, I think; it might be > guarded by some code that does the

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:1133 + /// Check if this is or contains a non-trivial C struct/union type. + bool hasNonTrivialPrimitiveCStruct() const; ahatanak wrote: > rjmccall wrote: > > You only want these checks to

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

rjmccall added a comment. Thanks, this looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL365103: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of… (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r365103 - [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Author: charusso Date: Wed Jul 3 17:50:50 2019 New Revision: 365103 URL: http://llvm.org/viewvc/llvm-project?rev=365103=rev Log: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls Summary: It models the known LLVM methods paired with their class.

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LP64 systems.

Bigcheese added a comment. In D64164#1569679 , @rnk wrote: > Please check the commit message: > > > [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems. > > I think you mean "use int on LP64 systems", since long is 32-bits on LLP64, >

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

rnk accepted this revision. rnk added a comment. Please check the commit message: > [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems. I think you mean "use int on LP64 systems", since long is 32-bits on LLP64, right? Otherwise, sounds good. Repository: rC Clang CHANGES

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207939. Charusso marked 9 inline comments as done. Charusso added a comment. - Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso added a comment. Thanks for the reviews! In D63915#1569410 , @Szelethus wrote: > This checker isn't in alpha -- did you evaluate it on LLVM? Other than that, > looks great! Yes, it is made for LLVM and tested out 4 times. Thanks! CHANGES

[PATCH] D64123: Add clang-llvm-rename tool.

ruiu added a comment. In D64123#1568096 , @Eugene.Zelenko wrote: > There is clang-rename > > already. May be new functionality should be added there? clang-rename seems to

[PATCH] D64123: Add clang-llvm-rename tool.

ruiu updated this revision to Diff 207937. ruiu added a comment. - removed a special rule for `E` - do not lowercase global variables whose name is all uppercase - OSec -> osec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64123/new/

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

eugenis added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_allocator.cpp:159 ? (t ? t->GenerateRandomTag() : kFallbackAllocTag) : 0; +uptr tag_size = orig_size ? orig_size : 1; When

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

ahatanak updated this revision to Diff 207931. ahatanak marked 2 inline comments as done. ahatanak added a comment. Add an implicit-only attribute `ObjCDefaultedAnyToId` to avoid passing the flag down. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62645/new/

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

efriedma added a comment. > If they're all syntactically together like this, maybe that's safe? Having them together syntactically doesn't really help, I think; it might be guarded by some code that does the same conversion (and if you repeat the conversion, it has to produce the same result).

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 207925. Nathan-Huckleberry added a comment. - Stylistic fixes of function names and removal of namespace prefixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 207924. jdoerfert added a comment. Rebase (tests will be run later today) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files:

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

rjmccall added a comment. I agree with Eli that this isn't obviously a legal transformation. `llvm.ptrmask` appears to make semantic guarantees about e.g. the pointer after the mask referring to the same underlying object, which means we can only safely emit it when something about the source

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

hfinkel added a comment. In D64128#1568857 , @efriedma wrote: > I don't think this transform is valid, for the same reasons we don't do it in > IR optimizations. I believe that in the problematic cases we previously discussed (e.g., from

Re: [PATCH] D64149: [clang-scan-deps] use `-Wno-error` when scanning for dependencies

The warning output is suppressed, yes. Yeah, we should probably just disable them. I'll follow up with a commit. On Wed, 3 Jul 2019 at 15:25, Duncan P. N. Exon Smith via Phabricator < revi...@reviews.llvm.org> wrote: > dexonsmith added a comment. > > Is warning output suppressed? If so, should

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/include/clang/Sema/AnalysisBasedWarnings.h:95 + void flushDiagnostics(SmallVector); + Methods should be UpperCamelCased. Comment at:

[PATCH] D64169: ARM MTE stack sanitizer.

eugenis updated this revision to Diff 207920. eugenis added a comment. fix bitcode docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64169/new/ https://reviews.llvm.org/D64169 Files: clang/include/clang/Basic/Features.def

[PATCH] D64169: ARM MTE stack sanitizer.

eugenis created this revision. eugenis added reviewers: pcc, hctim, vitalybuka, ostannard. Herald added subscribers: dexonsmith, steven_wu, cryptoad, hiraditya, kristof.beyls, javed.absar, mehdi_amini, srhines. Herald added projects: clang, LLVM. Add "memtag" sanitizer that detects and mitigates

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 207918. Nathan-Huckleberry added a comment. - Small functional and formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files:

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

Bigcheese added a comment. In D64164#1569442 , @efriedma wrote: > Do the changes to BuiltinsARM.def have any practical effect? long should be > 32 bits on all 32-bit ARM targets. I don't think they do right now. I updated them there as that's what

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry added inline comments. Comment at: clang/lib/Analysis/AnalysisDeclContext.cpp:124 +if(VD->hasGlobalStorage()) { + return const_cast(dyn_cast(VD->getInit())); +} nickdesaulniers wrote: > The `const_cast` doesn't look necessary

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

efriedma added a comment. Do the changes to BuiltinsARM.def have any practical effect? long should be 32 bits on all 32-bit ARM targets. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64164/new/ https://reviews.llvm.org/D64164

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

jfb accepted this revision. jfb added inline comments. This revision is now accepted and ready to land. Comment at: test/CodeGen/ms-intrinsics-other.c:212 + return _InterlockedAdd(Addend, Value); +} + Looks like only `cmpxchg` preserves `volatile`? That's not

[PATCH] D64164: [clang][ARM] Fix msvc arm{64} builtins to use int on LLP64 systems.

Bigcheese created this revision. Bigcheese added reviewers: bruno, rnk, bkelley. Herald added subscribers: kristina, jfb, dexonsmith, kristof.beyls, javed.absar. Herald added a project: clang. The `InterlockedX_{acq,nf,rel}` functions deal with 32 bits which is long on MSVC, but int on most other

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Szelethus added a comment. This checker isn't in alpha -- did you evaluate it on LLVM? Other than that, looks great! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1119 - const T *lookup(const CallEvent ) const { + Optional lookup(const

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365092: cmake: Add CLANG_LINK_CLANG_DYLIB option (authored by tstellar, committed by ). Herald added a project: LLVM.

r365092 - cmake: Add CLANG_LINK_CLANG_DYLIB option

Author: tstellar Date: Wed Jul 3 15:45:55 2019 New Revision: 365092 URL: http://llvm.org/viewvc/llvm-project?rev=365092=rev Log: cmake: Add CLANG_LINK_CLANG_DYLIB option Summary: Setting CLANG_LINK_CLANG_DYLIB=ON causes clang tools to link against libclang_shared.so instead of the individual

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

Szelethus updated this revision to Diff 207904. Szelethus added a comment. Add one more assert to `GetExprText`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp

r365091 - [Bitcode] Move Bitstream to a separate library

Author: thegameg Date: Wed Jul 3 15:40:07 2019 New Revision: 365091 URL: http://llvm.org/viewvc/llvm-project?rev=365091=rev Log: [Bitcode] Move Bitstream to a separate library This moves Bitcode/Bitstream*, Bitcode/BitCodes.h to Bitstream/. This is needed to avoid a circular dependency when

[clang-tools-extra] r365091 - [Bitcode] Move Bitstream to a separate library

Author: thegameg Date: Wed Jul 3 15:40:07 2019 New Revision: 365091 URL: http://llvm.org/viewvc/llvm-project?rev=365091=rev Log: [Bitcode] Move Bitstream to a separate library This moves Bitcode/Bitstream*, Bitcode/BitCodes.h to Bitstream/. This is needed to avoid a circular dependency when

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

jfb added a comment. I'm not sure I understand all the implications, and why that would / wouldn't be valid. Should this be an builtin that can be called from C++ directly? Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2034 + (AllOnes <<

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think i like it now! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1119 - const T *lookup(const CallEvent ) const { + Optional lookup(const

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

Szelethus updated this revision to Diff 207902. Szelethus added a comment. - Bail out if the actual terminator isn't a branch - Bail out if the number of successors is less than 2 - LLVM-ify the code as suggested! - Add some unit tests (I mean, you can kinda see how it was duct taped together,

[PATCH] D64149: [clang-scan-deps] use `-Wno-error` when scanning for dependencies

dexonsmith added a comment. Is warning output suppressed? If so, should we just/also disable all warnings? (IIRC, the flag is `-w`.) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64149/new/ https://reviews.llvm.org/D64149

[PATCH] D59980: [Attributor] Deduce memory behavior argument attributes

jdoerfert added a subscriber: fhahn. jdoerfert added a comment. @hfinkel @fhahn ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59980/new/ https://reviews.llvm.org/D59980 ___ cfe-commits mailing

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:42-43 + const ASTContext ) { + assert(Literal->getLength() == 1); + assert(Literal->getCharByteWidth() == 1); //

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:10 #include "FasterStrsplitDelimiterCheck.h" + #include "clang/AST/ASTContext.h" Unnecessary empty line. Repository: rG LLVM Github

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

gribozavr added a comment. Sorry, the patch does not apply cleanly to current master -- could you rebase please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64151/new/ https://reviews.llvm.org/D64151

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/include/clang/Sema/AnalysisBasedWarnings.h:101 + void RegisterVarDeclWarning(VarDecl *VD, PossiblyUnreachableDiag + PossiblyUnreachableDiag); + `git-clang-format HEAD~` The formal

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

mclow.lists added a comment. Did this ever get landed? If not, was there a reason? Note that the synopsis at the top of `` also needs to be updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40259/new/ https://reviews.llvm.org/D40259

r365085 - [analyzer] exploded-graph-rewriter: Implement a black-and-white color scheme.

Author: dergachev Date: Wed Jul 3 13:48:23 2019 New Revision: 365085 URL: http://llvm.org/viewvc/llvm-project?rev=365085=rev Log: [analyzer] exploded-graph-rewriter: Implement a black-and-white color scheme. For accessibility! Differential Revision: https://reviews.llvm.org/D64153 Modified:

[PATCH] D37182: [libcxx] Special visibility macros for the experimental library

mclow.lists added a comment. This is an old patch; is this still needed/desired? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37182/new/ https://reviews.llvm.org/D37182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64153: [analyzer] exploded-graph-rewriter: Add a grayscale mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365085: [analyzer] exploded-graph-rewriter: Implement a black-and-white color scheme. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

mclow.lists added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Is this patch relevant any more? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24372/new/ https://reviews.llvm.org/D24372

[PATCH] D61366: [libcxx] [test] Don't assert that moved-from containers with non-POCMA allocators are empty.

BillyONeal added a comment. In D61366#1569151 , @mclow.lists wrote: > Is there a reason this hasn't been committed? Because it needs that one change Casey requested I was going to do that next time we take a libcxx test harness update, and I was hoping

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam updated this revision to Diff 207882. zahiraam marked 14 inline comments as done. zahiraam added a comment. Thanks for the review. I think and hope that I have responded to every issue you raised. Let me know if there are still pending issues. Happy 4th! CHANGES SINCE LAST ACTION

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam added inline comments. Comment at: include/clang/AST/Decl.h:4303 + + StringLiteral *getSTLUuid() { return STLUuid; } +}; rsmith wrote: > What does "STL" mean here? Renamed it. Comment at: lib/CodeGen/CodeGenModule.cpp:1071-1073 +

[PATCH] D61366: [libcxx] [test] Don't assert that moved-from containers with non-POCMA allocators are empty.

mclow.lists added a comment. Is there a reason this hasn't been committed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61366/new/ https://reviews.llvm.org/D61366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64153: [analyzer] exploded-graph-rewriter: Add a grayscale mode.

Szelethus accepted this revision. Szelethus added a comment. BRILLIANT Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64153/new/ https://reviews.llvm.org/D64153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64156: Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do

thakis created this revision. thakis added a reviewer: ruiu. Herald added subscribers: MaskRay, aheejin, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. This fixes an 8-year-old regression. r105763 made it so that aliases always refer to

[clang-tools-extra] r365078 - Fixed a link in ReleaseNotes.rst (follow-up to r365007)

Author: gribozavr Date: Wed Jul 3 13:18:34 2019 New Revision: 365078 URL: http://llvm.org/viewvc/llvm-project?rev=365078=rev Log: Fixed a link in ReleaseNotes.rst (follow-up to r365007) Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D64119: [PowerPC] Support constraint code "ww"

jsji added a comment. It is great to add `ww` for compatibility. However if we are going to add `ww`, looks like we should update `ws` as well? Comment at: clang/lib/Basic/Targets/PPC.h:211 + case 's': // VSX vector register to hold scalar double data + case 'w': //

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: include/clang/AST/Type.h:1133 + /// Check if this is or contains a non-trivial C struct/union type. + bool hasNonTrivialPrimitiveCStruct() const; rjmccall wrote: > You

[PATCH] D43159: Modernize: Use nullptr more.

mclow.lists added inline comments. Comment at: include/__threading_support:323 bool __libcpp_thread_isnull(const __libcpp_thread_t *__t) { - return *__t == 0; + return *__t == nullptr; } mclow.lists wrote: > This one is wrong. `__libcpp_thread_t` is an alias

[PATCH] D64153: [analyzer] exploded-graph-rewriter: Add a grayscale mode.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Well, it is always awesome to think about the others. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64153/new/ https://reviews.llvm.org/D64153

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

zhangxy988 added a comment. I don't think I have commit access. Please commit it for me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64151/new/ https://reviews.llvm.org/D64151 ___

[PATCH] D64153: [analyzer] exploded-graph-rewriter: Add a grayscale mode.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Accessibility! I remembered to implement accessibility. F9454779:

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso added a comment. Thanks for the reviews! The remaining question is: do we want to use `Optional<>` in the `CallDescriptionMap::lookup()`? Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:98-100 +// The APIModeling package is for checkers that model

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207862. Charusso marked 12 inline comments as done. Charusso added a comment. - More fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D43159: Modernize: Use nullptr more.

ldionne requested changes to this revision. ldionne added a comment. I agree with Marshall's requests. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 ___ cfe-commits

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:98-100 +// The APIModeling package is for checkers that model APIs. These checkers are +// always turned on; this package is intended for API modeling that is not +// controlled

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

xazax.hun added a comment. Some nits inline, note that this was just a partial review. Comment at: clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp:14 + +#include "clang/Driver/DriverDiagnostic.h" +#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Do you have commit access? Would you like me to commit this patch for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64151/new/

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso marked 5 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:98-100 +// The APIModeling package is for checkers that model APIs. These checkers are +// always turned on; this package is intended

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

thakis added a comment. Herald added a project: clang. I noticed that this causes memory errors in certain situations. https://bugs.llvm.org/show_bug.cgi?id=42501 has details. Can you take a look? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53457/new/

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

zhangxy988 created this revision. zhangxy988 added a reviewer: gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently it fails on cases like '\001'. Note: Since `StringLiteral::outputString` dumps most nonprintable characters in octal value, the exact string

[PATCH] D62611: [analyzer][Dominators] Add unittests

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Looks good to me, some nits inline. Comment at: clang/unittests/Analysis/CFGBuildResult.h:1 +//===- unittests/Analysis/CFGTest.cpp - CFG tests

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

andrew.w.kaylor added a comment. In D64067#1568895 , @hfinkel wrote: > One thing to realize about these flags is that they're ABI-altering flags. If > the user provides the flag to alter the platform defaults, this only works if > the user also ensures

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:98-100 +// The APIModeling package is for checkers that model APIs. These checkers are +// always turned on; this package is intended for API modeling that is not +// controlled by the

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso added a comment. In D63915#1568166 , @Szelethus wrote: > This checker seems to only check LLVM functions, but doesn't check whether > these methods lie in the LLVM namespace. Is this intended? Thanks for the reviews! They are not in the `llvm`

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207851. Charusso marked 8 inline comments as done. Charusso added a comment. - Fix. - Document `NoteTag`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files:

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:98-100 +// The APIModeling package is for checkers that model APIs. These checkers are +// always turned on; this package is intended for API modeling that is not +// controlled by the

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

xazax.hun added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:5619-5625 + // If the terminator is a temporary dtor or a virtual base, etc, we can't + // retrieve a meaningful condition, bail out. + if (rbegin()->getKind() != CFGElement::Kind::Statement) +return

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

hfinkel added a comment. In D64067#156 , @rnk wrote: > In D64067#1568533 , @andrew.w.kaylor > wrote: > > > In this review (https://reviews.llvm.org/D6260) @rsmith mentions that this > > should also have an

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

rnk added a comment. In D64067#1568533 , @andrew.w.kaylor wrote: > In this review (https://reviews.llvm.org/D6260) @rsmith mentions that this > should also have an effect on name mangling. I'm not sure that's consistent with GCC, at least not anymore:

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:5619-5625 + // If the terminator is a temporary dtor or a virtual base, etc, we can't + // retrieve a meaningful condition, bail out. + if (rbegin()->getKind() != CFGElement::Kind::Statement) +return

[PATCH] D64149: [clang-scan-deps] use `-Wno-error` when scanning for dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL365065: [clang-scan-deps] use `-Wno-error` when scanning for dependencies (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

efriedma added a comment. I don't think this transform is valid, for the same reasons we don't do it in IR optimizations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64128/new/ https://reviews.llvm.org/D64128

r365065 - [clang-scan-deps] use `-Wno-error` when scanning for dependencies

Author: arphaman Date: Wed Jul 3 11:01:32 2019 New Revision: 365065 URL: http://llvm.org/viewvc/llvm-project?rev=365065=rev Log: [clang-scan-deps] use `-Wno-error` when scanning for dependencies Warnings can be promoted to errors. But that shouldn't prevent us from getting the dependencies!

[PATCH] D64149: [clang-scan-deps] use `-Wno-error` when scanning for dependencies

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64149/new/ https://reviews.llvm.org/D64149 ___

[PATCH] D64149: [clang-scan-deps] use `-Wno-error` when scanning for dependencies

arphaman created this revision. arphaman added a reviewer: Bigcheese. Herald added subscribers: tschuett, dexonsmith, jkorous. Herald added a project: clang. Warning can be promoted to errors. But that shouldn't prevent us from getting the dependencies! Repository: rC Clang

[PATCH] D63876: [OpenCL] Define CLK_NULL_EVENT without cast

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! If you like you can also change reserve_id_t. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63876/new/ https://reviews.llvm.org/D63876

  1   2   3   >