r365877 - [Driver] Delete --no-add-needed for RHEL7 or newer

Author: maskray Date: Thu Jul 11 23:46:47 2019 New Revision: 365877 URL: http://llvm.org/viewvc/llvm-project?rev=365877&view=rev Log: [Driver] Delete --no-add-needed for RHEL7 or newer This is really not needed. gcc driver doesn't add this option. BTW, since binutils 2.22, --no-copy-dt-needed-ent

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

lebedev.ri added a comment. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64607/new/ https://reviews.llvm.org/D64607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang-tools-extra] r365874 - [test] Delete trailing spaces from YAML tests after D65566/r365869

Author: maskray Date: Thu Jul 11 23:01:37 2019 New Revision: 365874 URL: http://llvm.org/viewvc/llvm-project?rev=365874&view=rev Log: [test] Delete trailing spaces from YAML tests after D65566/r365869 Modified: clang-tools-extra/trunk/test/clang-include-fixer/merge.test clang-tools-extra/

r365873 - [test] Delete trailing spaces from YAML tests

Author: maskray Date: Thu Jul 11 22:59:28 2019 New Revision: 365873 URL: http://llvm.org/viewvc/llvm-project?rev=365873&view=rev Log: [test] Delete trailing spaces from YAML tests Modified: cfe/trunk/unittests/Tooling/DiagnosticsYamlTest.cpp cfe/trunk/unittests/Tooling/RefactoringActionRu

r365872 - test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should always be available

Author: maskray Date: Thu Jul 11 22:51:36 2019 New Revision: 365872 URL: http://llvm.org/viewvc/llvm-project?rev=365872&view=rev Log: test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should always be available Follow-up of D64317/r365587. Modified: cfe/trunk/test/Dri

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Charusso accepted this revision. Charusso added a comment. The `impure-warning` sounds like some alpha, not-well-defined warning, other than that I like the movement to rethink existing checkers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ https://reviews.llvm.org/D64274

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64614 Files: clang-tools-extra/docs/clan

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge added a comment. This is an issue I noticed while writing the unit test for D64308 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613 __

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/test/type-hierarchy.test:1 # RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPa

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64613 Files: clang-tools-extra/clangd/XR

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

This revision was automatically updated to reflect the committed changes. nridge marked 3 inline comments as done. Closed by commit rL365867: [clangd] Implement typeHierarchy/resolve for subtypes (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-com

[clang-tools-extra] r365867 - [clangd] Implement typeHierarchy/resolve for subtypes

Author: nridge Date: Thu Jul 11 20:26:32 2019 New Revision: 365867 URL: http://llvm.org/viewvc/llvm-project?rev=365867&view=rev Log: [clangd] Implement typeHierarchy/resolve for subtypes Summary: This allows the client to resolve subtypes one level at a time. For supertypes, this is not necessar

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + Mordante wrote: > rjmccall wrote: > > Comment indentation. > > > > Should we do this when starting to parse a function prototype instead of > > when parsi

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song added a comment. The followup patch for this change is at https://reviews.llvm.org/D64598. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 ___ cfe-commits mailing

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

rjmccall added a comment. There are some code paths that I think are common between the parser and template instantiation, like `BuildPointerType` and `BuildReferenceType`, but if you want to do context-sensitive inference that might not be good enough. CHANGES SINCE LAST ACTION https://revi

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturnLoc().getBeginLoc(), Anastas

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

MaskRay added a comment. This should be rebased after D64294 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cf

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

This revision was automatically updated to reflect the committed changes. Closed by commit rL365866: [X86][PowerPC] Support -mlong-double-128 (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTI

r365866 - [X86][PowerPC] Support -mlong-double-128

Author: maskray Date: Thu Jul 11 19:32:15 2019 New Revision: 365866 URL: http://llvm.org/viewvc/llvm-project?rev=365866&view=rev Log: [X86][PowerPC] Support -mlong-double-128 This patch makes the driver option -mlong-double-128 available for X86 and PowerPC. The CC1 option -mlong-double-128 is av

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay updated this revision to Diff 209404. MaskRay added a comment. Use A->render(Args, CmdArgs); Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/Options.td lib/Basic/TargetInfo.cp

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365863: NFC: Unforget a colon in a few CHECK: directives. (authored by dergachev, committed by ). Herald added a subscribe

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

NoQ added a comment. Thanks all! I guess i'll commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka updated this revision to Diff 209401. vitalybuka added a comment. undo unrelated line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp clang/test/CodeG

r365863 - NFC: Unforget a colon in a few CHECK: directives.

Author: dergachev Date: Thu Jul 11 19:16:56 2019 New Revision: 365863 URL: http://llvm.org/viewvc/llvm-project?rev=365863&view=rev Log: NFC: Unforget a colon in a few CHECK: directives. Differential Revision: https://reviews.llvm.org/D64526 Modified: cfe/trunk/test/Analysis/cfg-rich-construc

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka updated this revision to Diff 209400. vitalybuka added a comment. 0x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp clang/test/CodeGenCXX/aut

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka added a comment. In D64597#1581654 , @jfb wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When I discussed t

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

MaskRay added a comment. I did this in rC365862 with a test after my refactoring of the interface rC365860 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/ https://reviews.llvm.org/

r365862 - [PowerPC] Default to -fomit-frame-pointer when optimization is enabled

Author: maskray Date: Thu Jul 11 19:14:08 2019 New Revision: 365862 URL: http://llvm.org/viewvc/llvm-project?rev=365862&view=rev Log: [PowerPC] Default to -fomit-frame-pointer when optimization is enabled NetBSD, Linux, CloudABI and Hurd already omit frame pointer for PowerPC. Make it do so for o

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

NoQ closed this revision. NoQ added a comment. Whoops, forgot the phabricator link. Committed as rC365861 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64611/new/ https://reviews.llvm.org/D64611

r365861 - [analyzer] exploded-graph-rewriter: Improve source location dumps.

Author: dergachev Date: Thu Jul 11 19:10:33 2019 New Revision: 365861 URL: http://llvm.org/viewvc/llvm-project?rev=365861&view=rev Log: [analyzer] exploded-graph-rewriter: Improve source location dumps. - Correctly display macro expansion and spelling locations. - Use the same procedure to displa

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL365860: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)? (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repositor

r365860 - [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

Author: maskray Date: Thu Jul 11 19:01:51 2019 New Revision: 365860 URL: http://llvm.org/viewvc/llvm-project?rev=365860&view=rev Log: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer Use a tri-state enum to represent shouldUseFramePointer() and

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

MaskRay updated this revision to Diff 209398. MaskRay retitled this revision from "[Driver] Refactor interaction between -f(no-)omit-frame-pointer and -mno-omit-leaf-frame-pointer" to "[Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer". MaskRay

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)omit-frame-pointer and -mno-omit-leaf-frame-pointer

MaskRay updated this revision to Diff 209396. MaskRay marked 2 inline comments as done. MaskRay retitled this revision from "[Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()" to "[Driver] Refactor interaction between -f(no-)omit-frame-pointer and -mno-omit-leaf-frame-p

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

This revision was automatically updated to reflect the committed changes. Closed by commit rL365858: Handle IntToPtr in isBytewiseValue (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D63967?vs=207180&id=209394#toc Repository: rL LLVM CHANGES SINCE

r365858 - Handle IntToPtr in isBytewiseValue

Author: vitalybuka Date: Thu Jul 11 18:42:03 2019 New Revision: 365858 URL: http://llvm.org/viewvc/llvm-project?rev=365858&view=rev Log: Handle IntToPtr in isBytewiseValue Summary: This helps with more efficient use of memset for pattern initialization From @pcc prototype for -ftrivial-auto-var-

r365857 - Codegen, NFC: 32bit test in auto-var-init.cpp

Author: vitalybuka Date: Thu Jul 11 18:36:11 2019 New Revision: 365857 URL: http://llvm.org/viewvc/llvm-project?rev=365857&view=rev Log: Codegen, NFC: 32bit test in auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp U

Re: [PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

Yes, the current behavior is erroring for assembler flags clang does not recognize, which is irrelevant when compiling with `-no-integrated-as`, which is breaking our assembler flag feature detection in building the Linux kernel. On Thu, Jul 11, 2019, 6:09 PM Reid Kleckner via Phabricator < revi..

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Much better! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64611/new/ https://reviews.llvm.org/D64611 __

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum marked 28 inline comments as done. quantum added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + tlively wrote: > quantum wrote

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 209391. quantum marked 10 inline comments as done. quantum added a comment. Apply review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

rnk added a comment. I think the intention of this change was to ignore assembler flags in pre-processing actions without warning about them. It implements that behavior by running the code that gathers and validates assembler flags. The validation is whats emitting the problematic errors. I do

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Clang.cpp:3555 + // in -E mode either for example, even though it's not really used either. + if (!isa(JA)) { +ArgStringList DummyArgs; Should you be checking `!TC.IsIntegrat

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

inglorion added a comment. This was suggested on D64458 . If we take this change, D64458 can be simplified to just accepting -fthinlto-index= as a CoreOption without needing any further changes to Driver.cpp. I also changed the

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. - Correctly display macro expansion and spelling locations. - Use the

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

inglorion created this revision. inglorion added reviewers: tejohnson, rnk, pcc. Herald added subscribers: arphaman, dexonsmith, steven_wu, mehdi_amini. Herald added a project: clang. Previously, passing -fthinlto-index= to clang required that bitcode files be explicitly marked by -x ir. This chan

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added a comment. ah, maybe the addition of `-no-integrated-as` shouldn't produce this error? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64527/new/ https://reviews.llvm.org/D64527 ___ cfe-commits mai

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added a comment. > This change breaks building the Linux kernel for arm32 (at least): Follow up discussion in https://github.com/ClangBuiltLinux/linux/issues/598. I think the kernel is wrong here. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D645

[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

tstellar created this revision. tstellar added reviewers: Pierre, Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64608 Files: clang/lib/Sema/SemaLookup.cpp clang/utils/TableGen/ClangOpenCLBuiltinEmi

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

chandlerc added a comment. Just to make sure we're on the same page (and sorry I didn't jump in sooner)... With the old PM, *anything* that is `always_inline` *gets* `instsimplify` run on it, even at -O0, even if you didn't want that. So using `-instsimplify` explicitly is, IMO, not any more sc

r365850 - Re-Revert Devirtualize destructor of final class.

Author: rupprecht Date: Thu Jul 11 17:32:08 2019 New Revision: 365850 URL: http://llvm.org/viewvc/llvm-project?rev=365850&view=rev Log: Re-Revert Devirtualize destructor of final class. This reverts r365509 (git commit d088720edad9c29ee0d622b5d69092e18a9ac0bd) This is a second revert[1] due to f

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

Nathan-Huckleberry updated this revision to Diff 209381. Nathan-Huckleberry added a comment. - Ran git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64607/new/ https://reviews.llvm.org/D64607 Files: clang-tools-extra/clang-tidy/bugp

[PATCH] D64598: fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

yonghong-song updated this revision to Diff 209379. yonghong-song added a subscriber: anakryiko. yonghong-song added a comment. change test case so we can test metadata is generated correctly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64598/new/ https://revie

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Sorry for the delay here. It'd be nice to land the LLVM patch first and with its own testing -- we should have testing for the pass builder independent of Clang (IE, in the LLV

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Lexer::getLocForEndOfToken is defined to return an invalid location if the given location is inside a macro. Other checks conditionally warn based off location validity. Updat

[PATCH] D64307: [clangd] Add a missing early return in getTypeHierarchy()

This revision was automatically updated to reflect the committed changes. Closed by commit rL365849: [clangd] Add a missing early return in getTypeHierarchy() (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[clang-tools-extra] r365849 - [clangd] Add a missing early return in getTypeHierarchy()

Author: nridge Date: Thu Jul 11 17:24:45 2019 New Revision: 365849 URL: http://llvm.org/viewvc/llvm-project?rev=365849&view=rev Log: [clangd] Add a missing early return in getTypeHierarchy() Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags:

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 209376. quantum added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang/lib/CodeGen/

r365845 - [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

Author: phosek Date: Thu Jul 11 16:49:39 2019 New Revision: 365845 URL: http://llvm.org/viewvc/llvm-project?rev=365845&view=rev Log: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes We want to preserve debug info in our runtimes to aid symbolization and debugging; for shared libraries this w

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL365845: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[clang-tools-extra] r365844 - [clangd] Fix MSVC build failure.

Author: probinson Date: Thu Jul 11 16:48:06 2019 New Revision: 365844 URL: http://llvm.org/viewvc/llvm-project?rev=365844&view=rev Log: [clangd] Fix MSVC build failure. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26898 Modified: clang-tools-extra

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. Lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64605/new/ https://reviews.llvm.org/D64605 ___ cfe-commit

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. We want to preserve debug info in our runtimes to aid symbolization and debugging; for shared libraries this will be stripped away during install-

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with suggestion Comment at: lib/Driver/ToolChains/Clang.cpp:4009 TC.getArch() == llvm::Triple::ppc || TC.getTriple().isPPC64()) { - CmdArgs.push_back("-mlong-dou

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. In D64062#1581662 , @sylvestre.ledru wrote: > In D64062#1581290 , @rnk wrote: > > > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. > > > As you wish. clang --version seems

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1448 +def RequireDesignatedInitDocs : Documentation { + let Category = DocCatType; aaron.ballman wrote: > The behavior should be documented as to what happens when you apply

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

mgehre added a comment. In D64448#1581771 , @gribozavr wrote: > In D64448#1581719 , @mgehre wrote: > > > In D64448#159 , @gribozavr > > wrote: > > > > > I don't know how

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

mgehre updated this revision to Diff 209370. mgehre marked 9 inline comments as done. mgehre added a comment. - Implement comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64448/new/ https://reviews.llvm.org/D64448 Files: clang/include/clan

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209369. tlively added a comment. - and other comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/D

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209367. tlively added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driv

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

tlively updated this revision to Diff 209365. tlively added a comment. - Add mutable-globals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:410 +// Test for functions toHalfOpenFileRange and getHalfOpenFileRange +// FIXME: Need better testing support to be able to check more than just Decls. +TEST(SourceCodeTests, Half

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah updated this revision to Diff 209363. SureYeaah marked 12 inline comments as done. SureYeaah added a comment. Added comments and minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64562/new/ https://reviews.llvm.org/D64562 Files

[PATCH] D64603: [Target] Use IEEE quad format for long double on Fuchsia x86_64

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. This change unifies the long double format between x86_64 and aarch64 targets making it easier to write code that's indepe

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 209362. emmettneyman marked 2 inline comments as done. emmettneyman added a comment. Added documentation about using the attributes with unions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ htt

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

mgehre updated this revision to Diff 209360. mgehre added a comment. Implement comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt cla

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

mgehre added a comment. This should address all remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:486 +TYPE_TRAIT_1(__is_gsl_owner, IsGslOwner, KEYCXX) +TYPE_TRAIT_1(__is_gsl_pointer, IsGslPointer, KEYCXX) KEYWORD(__underlying_type , KEYCXX) mgehre wrote: > griboz

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr added a comment. In D64448#1581719 , @mgehre wrote: > In D64448#159 , @gribozavr wrote: > > > I don't know how various versions of libstdc++ differ. > > > The current implementation passed the (partial

[PATCH] D62888: [NewPM] Port Sancov

This revision was automatically updated to reflect the committed changes. Closed by commit rL365838: [NewPM] Port Sancov (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D62888?vs=207698&id=209358#toc Repository: rL LLVM CHANGES SINCE LAST ACTION

r365838 - [NewPM] Port Sancov

Author: leonardchan Date: Thu Jul 11 15:35:40 2019 New Revision: 365838 URL: http://llvm.org/viewvc/llvm-project?rev=365838&view=rev Log: [NewPM] Port Sancov This patch contains a port of SanitizerCoverage to the new pass manager. This one's a bit hefty. Changes: - Split SanitizerCoverageModul

[PATCH] D64458: add -fthinlto-index= option to clang-cl

tejohnson added a comment. LGTM, but please wait for @pcc to make sure he is satisfied. I think it would be good to port the file type deduction to clang (possibly as a follow on), to make these consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + quantum wrote: > quantum wrote: > > aheejin wrote: > > > Why is it `c`(co

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

mgehre marked 5 inline comments as done. mgehre added a comment. In D64448#159 , @gribozavr wrote: > For example, libc++ wraps everything in std in an inline namespace. I believed that I had written a test for inline namespaces, but seems that I sho

[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

jfb added inline comments. Comment at: clang/lib/AST/ExprVM/Compiler.cpp:85 +/* isArray */ false, +/* isGlobal */ false); + ParamDescriptors.insert({ParamOffset, std::move(Desc)})

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman, steven_wu. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This attribute can be applied to typedefs of BOOL in Objective-C. It causes loads, stores, and casts to BOOL to

r365835 - CodeGen: Suppress c++ warnings in test

Author: vitalybuka Date: Thu Jul 11 14:59:09 2019 New Revision: 365835 URL: http://llvm.org/viewvc/llvm-project?rev=365835&view=rev Log: CodeGen: Suppress c++ warnings in test Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp URL: ht

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante updated this revision to Diff 209348. Mordante added a comment. tab -> space adds an extra unit test for lambdas fixes an off by one error found while testing the lambdas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 Files: clang/in

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru added a comment. In D64062#1581290 , @rnk wrote: > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. As you wish. clang --version seems an alternative and dumpversion never //worked// for clang. so, I don't expect soft

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + rjmccall wrote: > Comment indentation. > > Should we do this when starting to parse a function prototype instead

r365832 - Fix a Python3 compatibility error

Author: azhar Date: Thu Jul 11 14:45:48 2019 New Revision: 365832 URL: http://llvm.org/viewvc/llvm-project?rev=365832&view=rev Log: Fix a Python3 compatibility error File "clang/test/lit.cfg.py", line 186, in config.available_features.add('macos-sdk-' + macOSSDKVersion) TypeError: must be

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xAAAAAAAA

jfb added a comment. In D64597#1581605 , @pcc wrote: > The problem with `0x` on 32-bit is that it is likely to be a valid > address. > > When I discussed this with JF I proposed a pointer initialization of > `0x` which he agreed to. This

[PATCH] D64278: Rename libclang_shared to libclang-cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL365831: Rename libclang_shared to libclang-cpp (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r365831 - Rename libclang_shared to libclang-cpp

Author: sylvestre Date: Thu Jul 11 14:42:55 2019 New Revision: 365831 URL: http://llvm.org/viewvc/llvm-project?rev=365831&view=rev Log: Rename libclang_shared to libclang-cpp Summary: Fix bug 42475 Reviewers: beanz, tstellar Reviewed By: beanz Subscribers: kimgr, mgorny, cfe-commits Tags: #cl

[PATCH] D62888: [NewPM] Port Sancov

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, thanks so much for sticking through this, I know it was ... nontrivial! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ htt

[PATCH] D64278: Rename libclang_shared to libclang-cpp

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This is fine with me. I have no real attachment to the name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

beanz accepted this revision. beanz added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64582/new/ https://reviews.llvm.org/D64582 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xAAAAAAAA

pcc added a comment. The problem with `0x` on 32-bit is that it is likely to be a valid address. When I discussed this with JF I proposed a pointer initialization of `0x` which he agreed to. This value is very likely to trap when accessed (due to accesses likely wrapping to zer

r365827 - [analyzer] exploded-graph-rewriter: Fix filenames in program point.

Author: dergachev Date: Thu Jul 11 14:27:42 2019 New Revision: 365827 URL: http://llvm.org/viewvc/llvm-project?rev=365827&view=rev Log: [analyzer] exploded-graph-rewriter: Fix filenames in program point. Fix a typo in JSON field name. Modified: cfe/trunk/test/Analysis/exploded-graph-rewriter

  1   2   3   >