[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

pcc added subscribers: filcab, pcc. pcc added a comment. It's also worth asking whether `-nodefaultlibs` would work for this use case as @filcab suggested on D64547 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

MaskRay added a comment. There is an existing option `-fsanitize-minimal-runtime`, will `-fsanitize-no-runtime` be a name providing more consistency? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

sbc100 added inline comments. Comment at: lld/trunk/wasm/Symbols.h:438 + // __tls_size + // Symbol whose value is the alignment of the TLS block. __tls_align Comment at: lld/trunk/wasm/Symbols.h:439 + // __tls_size + // Symbol whose

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 ___

Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

Looks good now. Thanks Kadir! > On Jul 19, 2019, at 3:18 AM, Kadir Çetinkaya wrote: > > Hi Azhar, D64980 should fix the problem. I am reverting your revert while > adding the fix in r366559. > > On Fri, Jul 19, 2019 at 11:29 AM Azhar Mohammed > wrote: > Reverted in

r366620 - [NFC] Remove unused variable

Author: dendibakh Date: Fri Jul 19 14:59:42 2019 New Revision: 366620 URL: http://llvm.org/viewvc/llvm-project?rev=366620=rev Log: [NFC] Remove unused variable Change-Id: I5aee24dcdf6eebfbf788e52be22463387f23d927 Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified:

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. This new index contains links to the main section of infos: Namespaces, Records, Functions,

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek created this revision. phosek added reviewers: vitalybuka, morehouse, kcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change introduces a pair of -fsanitize-link-deps and -fno-sanitize-link-deps flags which can be used to control linking of sanitizer

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL366624: [WebAssembly] Compute and export TLS block alignment (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D65028?vs=210930=210934#toc Repository: rL LLVM

r366624 - [WebAssembly] Compute and export TLS block alignment

Author: quantum Date: Fri Jul 19 16:34:16 2019 New Revision: 366624 URL: http://llvm.org/viewvc/llvm-project?rev=366624=rev Log: [WebAssembly] Compute and export TLS block alignment Summary: Add immutable WASM global `__tls_align` which stores the alignment requirements of the TLS segment. Add

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65028/new/ https://reviews.llvm.org/D65028

[PATCH] D65028: [WebAssembly] Compute and export TLS block alignment

quantum created this revision. quantum added reviewers: tlively, aheejin, sbc100, sunfish, alexcrichton. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. Add immutable WASM global `__tls_align` which stores the

[PATCH] D65009: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1

This revision was automatically updated to reflect the committed changes. Closed by commit rL366623: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 (authored by tejohnson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

r366623 - [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1

Author: tejohnson Date: Fri Jul 19 16:02:58 2019 New Revision: 366623 URL: http://llvm.org/viewvc/llvm-project?rev=366623=rev Log: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1 Summary: Regular LTO modules do not need LTO Unit splitting, only ThinLTO does (they must be

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:2102-2103 child_range used_children() { -return child_range(child_iterator(), child_iterator()); +return

[PATCH] D65009: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65009/new/ https://reviews.llvm.org/D65009 ___ cfe-commits mailing

[PATCH] D65009: [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1

tejohnson updated this revision to Diff 210918. tejohnson added a comment. Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65009/new/ https://reviews.llvm.org/D65009 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/split-lto-unit.c Index:

[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

tejohnson added a comment. In D65009#1594009 , @pcc wrote: > Sorry, just realized this. If I do > > clang++ -c -flto a.cpp # "split" > clang++ -c -flto=thin b.cpp -fwhole-program-vtables # non-split > clang++ a.o b.o > > > this should fail, right?

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/AST/OpenMPClause.h:2102-2103 child_range used_children() { -return child_range(child_iterator(), child_iterator()); +return

[PATCH] D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression)

rsmith added a comment. Well, this restores an incorrect behaviour: we're not permitted to substitute into the initializer of the variable template here. Can you look into fixing this properly, by instantiating the type when forming the MemberExpr? If not, taking this to fix the regression

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM alongside NS_ENUM.

benhamilton requested changes to this revision. benhamilton added a comment. This revision now requires changes to proceed. Thanks! Don't forget the CF version. Comment at: clang/lib/Format/FormatToken.h:793 IdentifierInfo *kw_CF_OPTIONS; + IdentifierInfo

[PATCH] D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression)

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This patch fixes a regression introduced in r359947. Here: template struct Outer { template static constexpr auto x = 1;

[PATCH] D58091: Customize warnings for missing built-in type

bcain accepted this revision. bcain added a comment. Herald added a subscriber: dmgreen. @jdoerfert @jyknight @lebedev.ri@rsmith @aaron.ballman This will appear as a 9.0 regression, right? Let's please consider a way to address it for 9.0 before it's released. Repository: rG LLVM

[PATCH] D64780: Disallow most calling convention attributes on PS4.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366617: Disallow most calling convention attributes on PS4 (authored by ssrivastava, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

smeenai added a comment. In D61479#1586987 , @sberg wrote: > eh, the summary here doesn't get updated from the actual git commit message :( > > thanks for the reviews! You can use `arc diff --verbatim` to update the summary based on your local commit

[PATCH] D64646: [OPENMP]Add support for analysis of if clauses.

NoQ added inline comments. Comment at: test/Analysis/cfg-openmp.cpp:58-67 #pragma omp distribute simd for (int i = 0; i < 10; ++i) argc = x; -// CHECK-NEXT: 27: x -// CHECK-NEXT: 28: [B1.27] (ImplicitCastExpr, LValueToRValue, int) -// CHECK-NEXT: 29: argc -//

r366617 - Disallow most calling convention attributes on PS4

Author: ssrivastava Date: Fri Jul 19 14:38:34 2019 New Revision: 366617 URL: http://llvm.org/viewvc/llvm-project?rev=366617=rev Log: Disallow most calling convention attributes on PS4 PS4 now only allows "cdecl", and its equivalent on PS4, "sysv_abi". Differential Revision:

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

Meinersbur added a comment. I prefer having the documentation change to be in the same patch as the functional change. Makes it easier to check whether they match. Comment at: clang/test/CodeGenCXX/pragma-loop.cpp:163 -// CHECK: ![[LOOP_1]] = distinct !{![[LOOP_1]],

[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

pcc added a comment. Sorry, just realized this. If I do clang++ -c -flto a.cpp # "split" clang++ -c -flto=thin b.cpp -fwhole-program-vtables # non-split clang++ a.o b.o this should fail, right? If I'm not mistaken, this patch series will cause this to succeed. I think we need to change

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM alongside NS_ENUM.

heijink created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65012 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

NoQ added inline comments. Comment at: test/Analysis/taint-generic.c:24 +// CHECK-INVALID-FILE-SAME: 'alpha.security.taint.TaintPropagation:Config', +// CHECK-INVALID-FILE-SAME:that expects a valid filename Szelethus wrote: > NoQ wrote: > >

[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: dexonsmith, steven_wu, inglorion, Prazek, mehdi_amini. Herald added a project: clang. LTO Unit splitting does not apply to regular LTO modules, only ThinLTO (which must be consistently split into regular

[PATCH] D65005: [clang-doc] Fix output format of html

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. The children of a TagNode are rendered in the same line as the parent only if they are all TextNodes. When children are not inline;

[PATCH] D64907: [AST] Traverse attributes inside DEF_TRAVERSE_DECL macro

gribozavr added a comment. Looks like a good idea to me. Regarding tests, I couldn't find existing tests that check order either. Seems like you'd need to make some minimal infrastructure for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64780: Disallow most calling convention attributes on PS4.

wristow accepted this revision. wristow added a comment. In D64780#1593624 , @aaron.ballman wrote: > LGTM aside from a nit. You should give other reviewers a chance to sign off > in case they have additional comments. LGTM too, once the line-length is

[PATCH] D64780: Disallow most calling convention attributes on PS4.

rnk accepted this revision. rnk added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64780/new/ https://reviews.llvm.org/D64780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked 4 inline comments as done. jpakkane added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} alexfh

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 210868. jpakkane added a comment. Now properly deals with template instantiations and macros. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgrang, mgorny. An index structure is created while reducing the infos. This is then

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 210862. dgoldman added a comment. - Minor fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.cpp

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong updated this revision to Diff 210861. martong added a comment. - Further simplify by removing the last for loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D44100 Files:

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2332 S->isSemanticForm() ? S->getSyntacticForm() : S, Queue));

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

gribozavr added inline comments. Comment at: clang-tidy/bugprone/InfiniteLoopCheck.cpp:25 + +static bool isAccessForVar(const Stmt *St, const VarDecl *Var) { + if (const auto *DRE = dyn_cast(St)) St => S "S" is a common abbreviation in the Clang codebase, "St"

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer updated this revision to Diff 210857. SjoerdMeijer added a comment. Removed the separate function that created the loop.llvm.vectorize.predicate metadata. This is now just part of function `createLoopVectorizeMetadata`, that creates all other vectorize metadata. CHANGES SINCE

[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL366592: [Format/ObjC] Avoid breaking between unary operators and operands (authored by benhamilton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r366592 - [Format/ObjC] Avoid breaking between unary operators and operands

Author: benhamilton Date: Fri Jul 19 09:50:24 2019 New Revision: 366592 URL: http://llvm.org/viewvc/llvm-project?rev=366592=rev Log: [Format/ObjC] Avoid breaking between unary operators and operands Summary: Test Plan: New tests added. Ran tests with: % ninja FormatTests &&

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: lib/Basic/Targets/OSTargets.h:564 } + TargetInfo::CallingConvCheckResult checkCallingConvention(CallingConv CC) const override { +return (CC == CC_C) ?

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210856. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added a comment. LG with a nit. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2595 +unsigned DeviceID, Line; +unsigned FileID = 0; +getTargetEntryUniqueInfo(CGM.getContext(), No need to initialize FileID. Repository: rC Clang

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/ https://reviews.llvm.org/D64569

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea updated this revision to Diff 210854. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D64592: [OpenMP] Fix declare target link implementation

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: test/OpenMP/declare_target_link_codegen.cpp:22-23 +// HOST-DAG: @c_decl_tgt_ref_ptr = weak global i32* @c +// HOST-DAG: @_{{.*}}d = internal global i32 2 +// HOST-DAG:

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 FillDiagBase(*LastDiag); -adjustDiagFromHeader(*LastDiag, Info, *LangOpts); +if (!InsideMainFile) + LastDiagWasAdjusted = adjustDiagFromHeader(*LastDiag, Info, *LangOpts);

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added a comment. In D64569#1592059 , @rjmccall wrote: > Yes, that's the right fix, although you might also consider adding a > `getObjectType()` to `CXXMemberCallExpr`. Thanks, John, it should be better now, but let me know if I can improve

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210850. mantognini added a comment. - Add minimal regression test for PR42665 - Add CXXMemberCallExpr::getObjectType() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio created this revision. dnsampaio added reviewers: ostannard, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. The maximum alignment used by ARM arch is 64bits, not 128. This could cause overaligned memory access for 128 bit neon

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sunfish added a comment. > This allows for us to fall back from arch-specific to generic headers as > needed. The same can be true of libraries. Not all libraries contains > compiled code. `.so` files can also be linker scripts that reference other > libraries in which case they can be

[libunwind] r366587 - [libunwind][ARM] Fix loading FP registers on big-endian targets

Author: miyuki Date: Fri Jul 19 08:20:32 2019 New Revision: 366587 URL: http://llvm.org/viewvc/llvm-project?rev=366587=rev Log: [libunwind][ARM] Fix loading FP registers on big-endian targets Summary: The function Unwind-EHABI.cpp:_Unwind_VRS_Pop loads the saved values of 64-bit FP registers as

[PATCH] D64780: Disallow most calling convention attributes on PS4.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. You should give other reviewers a chance to sign off in case they have additional comments. Comment at:

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

thakis added a comment. In D63648#1591469 , @aganea wrote: > It totally makes sense, thanks for the explanation Nico! Let's forget about > `cl` compatibility, that wasn't my initial intent. > > We always pass //relative// paths on the cmd-line, for all

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

gribozavr added a comment. Is it true that all inline commands require an argument? For example, "\&" does not. Comment at: clang/test/Sema/warn-documentation.cpp:1030 +// The inline comments expect a string after the command. +// expected-warning@+1 {{'\a' command does not

[PATCH] D64998: Improve clang-format-diff help output

thakis created this revision. thakis added a reviewer: krasimir. The description in clang-format-diff.py is more useful than the one in `clang-format-diff -h`, so use the same description in both places. https://reviews.llvm.org/D64998 Files: clang/tools/clang-format/clang-format-diff.py

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 210838. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files:

[PATCH] D64863: [clangd] Ignore diags from builtin files

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:128 +return false; + Position StartPos = sourceLocToPosition(SM, IncludeInMainFile); NIT: inline `StartPos`, it has online a single usage now.

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 210834. kadircet added a comment. - Move deduplication logic back into the `flushLastDiag` as discussed offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added a comment. In D64838#1592520 , @Nathan-Huckleberry wrote: > void foo() { > __attribute__((address_space(0))) *x; > *y; > } > > > If the attributes are parsed then function body looks like this to the parser: > > { >

[libclc] r366581 - Creating release candidate final from release_801 branch

Author: tstellar Date: Fri Jul 19 07:14:12 2019 New Revision: 366581 URL: http://llvm.org/viewvc/llvm-project?rev=366581=rev Log: Creating release candidate final from release_801 branch Added: libclc/tags/RELEASE_801/final/ - copied from r366580, libclc/branches/release_80/

[libunwind] r366581 - Creating release candidate final from release_801 branch

Author: tstellar Date: Fri Jul 19 07:14:12 2019 New Revision: 366581 URL: http://llvm.org/viewvc/llvm-project?rev=366581=rev Log: Creating release candidate final from release_801 branch Added: libunwind/tags/RELEASE_801/final/ - copied from r366580, libunwind/branches/release_80/

[PATCH] D64863: [clangd] Ignore diags from builtin files

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:601 - if (mentionsMainFile(*LastDiag) || - (LastDiag->Severity >= DiagnosticsEngine::Level::Error && - IncludeLinesWithErrors.insert(LastDiag->Range.start.line).second)) {

[PATCH] D64592: [OpenMP] Fix declare target link implementation

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2592-2593 llvm::raw_svector_ostream OS(PtrName); - OS << CGM.getMangledName(GlobalDecl(VD)) << "_decl_tgt_ref_ptr"; + unsigned DeviceID, Line; + unsigned FileID = 0; + OS <<

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

ilya-biryukov added a comment. The fix for a race condition on remove has landed in rL366577 , this revision would need a small update after it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

This revision was automatically updated to reflect the committed changes. Closed by commit rL366577: [clangd] Provide a way to publish highlightings in non-racy manner (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r366577 - [clangd] Provide a way to publish highlightings in non-racy manner

Author: ibiryukov Date: Fri Jul 19 06:51:01 2019 New Revision: 366577 URL: http://llvm.org/viewvc/llvm-project?rev=366577=rev Log: [clangd] Provide a way to publish highlightings in non-racy manner Summary: By exposing a callback that can guard code publishing results of 'onMainAST' callback in

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

RKSimon added inline comments. Comment at: llvm/test/CodeGen/AArch64/tme-tcancel.ll:1 +; RUN: llc %s -o - | FileCheck %s + Would it make sense to add -verify-machineinstrs to all these Codegen/AArch64/tme-*.ll tests? CHANGES SINCE LAST ACTION

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

kmclaughlin updated this revision to Diff 210821. kmclaughlin retitled this revision from "[SVE][Inline-Asm] Add support to clang for SVE inline assembly" to "[SVE][Inline-Asm] Add support to specify SVE registers in the clobber list". kmclaughlin added a comment. - Removed typo fixes from this

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov updated this revision to Diff 210823. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Group PublishFn with onMainAST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64985/new/

[PATCH] D64990: [clangd] Disable background-index on lit-tests by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL366575: [clangd] Disable background-index on lit-tests by default (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:307 +llvm::StringRef NewCode; +std::vector DiffedLines; + } TestCases[]{ @hokein rightfully pointed out that mentioning all changed lines

[clang-tools-extra] r366575 - [clangd] Disable background-index on lit-tests by default

Author: kadircet Date: Fri Jul 19 06:40:30 2019 New Revision: 366575 URL: http://llvm.org/viewvc/llvm-project?rev=366575=rev Log: [clangd] Disable background-index on lit-tests by default Summary: Since background-index can perform disk writes, we don't want to turn it on tests that won't clear

[PATCH] D64990: [clangd] Disable background-index on lit-tests by default

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:361 + EnableBackgroundIndex = false; // Ensure background index makes progress.

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, rnkovacs, a_sidorin, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity,

[PATCH] D64990: [clangd] Disable background-index on lit-tests by default

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Since background-index can perform disk writes, we don't want to turn it on tests that won't clear it.

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong updated this revision to Diff 210813. martong added a comment. - Rebase to master - Some refactor is done mostly because since D63603 ([ASTImporter] Propagate error from ImportDeclContext) we may not imported successfully all decls of a DC. - Made the

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

ilya-biryukov added a comment. `StaticAnalyzer/Core` does not depend on `clangFrontend` now, you can see this by looking at `lib/StaticAnalyzer/Core/CMakeLists.txt`: add_clang_library(clangStaticAnalyzerCore ... LINK_LIBS clangAST clangASTMatchers clangAnalysis

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov added a comment. Thanks for all the suggestions. This is ready for the next round now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64985/new/ https://reviews.llvm.org/D64985 ___

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, I think this is in better shape than before highlighting was added. Comment at: clang-tools-extra/clangd/TUScheduler.h:102 const

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov updated this revision to Diff 210808. ilya-biryukov added a comment. - Remove a leftover comment from the previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64985/new/ https://reviews.llvm.org/D64985 Files:

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov updated this revision to Diff 210807. ilya-biryukov added a comment. - Update usage of DiagsMu in a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64985/new/ https://reviews.llvm.org/D64985 Files:

[PATCH] D60456: [RISCV] Hard float ABI support

This revision was automatically updated to reflect the committed changes. Closed by commit rL366450: [RISCV] Hard float ABI support (authored by asb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64985: [clangd] Provide a way to publish highlightings in non-racy manner

ilya-biryukov updated this revision to Diff 210805. ilya-biryukov added a comment. - Use the same mechanism for diagnostics - Change typedef to function)> - Update a comment - s/PublishResults/PublishFn - Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64914: Implement P1771

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2833-2835 if (D->getFunctionType() && - D->getFunctionType()->getReturnType()->isVoidType()) { + D->getFunctionType()->getReturnType()->isVoidType() && + !isa(D)) {

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:427 R"cpp(void f(int a) { auto dummy = 1; label: [ [gsl::suppress("type")] ] for (;;) a = dummy; })cpp"}, kadircet

[PATCH] D64914: Implement P1771

erichkeane marked 2 inline comments as done. erichkeane added a comment. I'll need to rebase this on another patch soon anyway, so I'll hold off until next week to update this particularly since we have some open questions. The additional TableGen work is tempting to do, though I'm not

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210803. SureYeaah marked an inline comment as done. SureYeaah added a comment. Added test for label Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[clang-tools-extra] r366568 - [Clangd] Fixed ExtractVariable test

Author: sureyeaah Date: Fri Jul 19 05:11:04 2019 New Revision: 366568 URL: http://llvm.org/viewvc/llvm-project?rev=366568=rev Log: [Clangd] Fixed ExtractVariable test Modified: clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp Modified:

[PATCH] D64914: Implement P1771

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2346 +// spellings. +bool IsCXX11NoDiscard() const { + return this->getSemanticSpelling() == CXX11_nodiscard; I don't think this is strictly required, but perhaps

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

t.p.northover added inline comments. Comment at: clang/test/Sema/aarch64-tme-errors.c:1 +// RUN: %clang_cc1 -triple aarch64-eabi -verify %s + I don't think the Sema checks need to be split over so many files. One for the whole of transactional seems enough.

[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah, worst case we'll need to roll this back and go with the targeted fix, but I don't see a problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM from my side. Do you have any concerns @sammccall ? Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:427 R"cpp(void f(int a) {

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210800. SureYeaah marked 5 inline comments as done. SureYeaah added a comment. Minor changes and disabled extraction from label statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/

  1   2   >