[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

owenpan added a comment. > Are there any other clang-format options that might lead to a lack-of-space > before `>`, `>=`, `==`, or `=`? I brought up `enable_if_t=0` > because that specifically is a construction I've run into in my own code, > even though I've never tried to clang-format it,

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

sylvestre.ledru added a comment. You should also probably add a note in the release notes (maybe for the others changes too) thanks for the work btw! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046

r369183 - [X86] Support -mlong-double-80

Author: troyj Date: Fri Aug 16 21:20:24 2019 New Revision: 369183 URL: http://llvm.org/viewvc/llvm-project?rev=369183=rev Log: [X86] Support -mlong-double-80 Add an option group for all of the -mlong-double-* options and make -mlong-double-80 restore the default long double behavior for X86.

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 215734. paulkirth added a comment. Remove frontend components of clang-misexpect in favor of backend implementations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

juliehockett added a comment. LGTM, for posterity Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66378/new/ https://reviews.llvm.org/D66378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369182: [clang-doc] Fix casting not working in gcc 5.4.0 (authored by DiegoAstiazaran, committed by ). Herald added a

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; mibintc wrote: > mibintc wrote: > > kpn wrote: > > > Wait, so "fast" and "precise" are the

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

DiegoAstiazaran created this revision. DiegoAstiazaran added a project: clang-tools-extra. An implicit cast of std::string to llvm::SmallString<> was breaking GCC 5.4.0 builder. A pair using llvm::SmallString<> now uses std::string. https://reviews.llvm.org/D66378 Files:

[clang-tools-extra] r369182 - [clang-doc] Fix casting not working in gcc 5.4.0

Author: diegoastiazaran Date: Fri Aug 16 18:45:03 2019 New Revision: 369182 URL: http://llvm.org/viewvc/llvm-project?rev=369182=rev Log: [clang-doc] Fix casting not working in gcc 5.4.0 An implicit cast of std::string to llvm::SmallString<> was breaking GCC 5.4.0 builder. A pair using

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 2 inline comments as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:72 +private: + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

efriedma added a comment. > in the proper order I would prefer lexical order, if possible. (At least, the order should be deterministic.) > clang should either generate an error or do "the right thing." Agreed. I think we should send a defect report to the C++ standards committee to

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

aaron.ballman added a comment. In D66364#1633775 , @rsmith wrote: > `_Thread_local` is a reserved identifier; we generally don't produce > extension warnings for uses of reserved identifiers. (Eg, there's no warning > for `_Atomic` in C++ or `_Bool` in

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added a comment. FYI, llvm.global_dtor fix is in https://reviews.llvm.org/D66373 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

Quuxplusone added a comment. In D66332#1633749 , @owenpan wrote: > Do you have `SpaceBeforeAssignmentOperators` off? Yes; I mean, that's what I tested in order to produce the buggy behavior. I don't believe anyone should be using that option in

[PATCH] D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions

NoQ accepted this revision. NoQ added a comment. //*appreciates CFG tests*// Comment at: test/Analysis/cfg.cpp:504-506 +// CHECK-NEXT: 2: return [B2.1]; +// CHECK-NEXT: Preds (1): B3(Unreachable) +// CHECK-NEXT: Succs (1): B0 Looks like runaway

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman updated this revision to Diff 215719. arphaman added a comment. remove accidentally include diff's `.rej` file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65907/new/ https://reviews.llvm.org/D65907 Files: clang/include/clang/Basic/FileManager.h

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman updated this revision to Diff 215718. arphaman marked 8 inline comments as done. arphaman added a comment. Address review comments and proper `use-external-names` support. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65907/new/

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:110 +/// A reference to a \c FileEntry that includes the name of the file as it was +/// accessed by the FileManager's client. +class FileEntryRef { bruno wrote: > How does that

[PATCH] D66045: Improve detection of same value in comparisons

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks from me as well. Comment at: lib/AST/Expr.cpp:4009 + auto getAnyDecl = [](const Expr *E) -> const ValueDecl * { +if (auto *DRE = dyn_cast(E)) + return

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 215716. jdoerfert added a comment. Add tests accidentally removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files:

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 closed this revision. jcai19 added a comment. Upsteamed to r369173. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 ___ cfe-commits mailing list

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thank you! Comment at: lib/Analysis/CFG.cpp:1118 +Expr::EvalResult Result; +if (!Constant->EvaluateAsInt(Result, *Context)) + return {};

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 215713. jdoerfert added a comment. Add more test coverage and improve capture information based on dereferenceability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922

r369173 - Reland "[ARM] push LR before __gnu_mcount_nc"

Author: jcai19 Date: Fri Aug 16 16:30:16 2019 New Revision: 369173 URL: http://llvm.org/viewvc/llvm-project?rev=369173=rev Log: Reland "[ARM] push LR before __gnu_mcount_nc" This relands r369147 with fixes to unit tests. https://reviews.llvm.org/D65019 Modified:

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 215710. jcai19 added a comment. Fix frontend mcount unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

Prince781 updated this revision to Diff 215709. Prince781 added a comment. Use range-based version of llvm::sort Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66122/new/ https://reviews.llvm.org/D66122 Files: clang/lib/CodeGen/CGExpr.cpp

r369170 - Revert "[X86] Support -mlong-double-80"

Author: troyj Date: Fri Aug 16 16:18:22 2019 New Revision: 369170 URL: http://llvm.org/viewvc/llvm-project?rev=369170=rev Log: Revert "[X86] Support -mlong-double-80" This reverts commit 250aafa2c4a1bc2395edfe8d4365545bbe56fffe. Caused buildbot failures -- still investigating. Modified:

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

mgrang added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:472 + + llvm::sort(OrderedVarInits.begin(), OrderedVarInits.end(), + [](const VarDecl *a, const VarDecl *b) { You can use the range-based version of llvm::sort here:

[PATCH] D65037: push LR before mcount on ARM

jcai19 updated this revision to Diff 215703. jcai19 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix frontend unit tests for __gnu_mcount_nc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65037/new/

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

andrew.w.kaylor added a comment. It took some digging, but I finally found the e-mail thread where we initially agreed that we can't mix constrained FP intrinsics and non-constrained FP operations within a function. Here it is: http://lists.llvm.org/pipermail/cfe-dev/2017-August/055325.html

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry marked 4 inline comments as done. Nathan-Huckleberry added inline comments. Comment at: clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp:360 -constexpr int ok_byte = (__builtin_bit_cast(std::byte[8], pad{1, 2}), 0); -constexpr int ok_uchar =

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 215699. Nathan-Huckleberry added a comment. - Use ExprEvalContext and remove mangling context code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files:

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

Prince781 updated this revision to Diff 215695. Prince781 added a comment. Herald added a subscriber: mgrang. I've updated the patch to initialize, in the proper order, all foreign static TLS variables and the variables they depend on for initialization. I've also cleaned up the patch a bit.

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 215693. xbolva00 added a comment. Better comparison for "xor". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

rsmith added a comment. `_Thread_local` is a reserved identifier; we generally don't produce extension warnings for uses of reserved identifiers. (Eg, there's no warning for `_Atomic` in C++ or `_Bool` in C89, and no warning for uses of `__type_traits` or `__builtins`.) But I note that we

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

andrew.w.kaylor added a comment. In D66092#1632642 , @sepavloff wrote: > - What is the issue with moving `a = b/c`? If it moves ahead of `if` > statement it seems OK, because the rounding mode is the same in that point. > It cannot be moved inside the

[PATCH] D65997: Add options rounding and exceptions to pragma fp

andrew.w.kaylor added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3152 +rounding mode. This option is experimental; the compiler may ignore an explicit +rounding mode in some situations. + sepavloff wrote: > andrew.w.kaylor wrote: > > You

r369161 - [doc] Fix some minor formatting issues.

Author: rsmith Date: Fri Aug 16 15:08:39 2019 New Revision: 369161 URL: http://llvm.org/viewvc/llvm-project?rev=369161=rev Log: [doc] Fix some minor formatting issues. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL:

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

This revision was automatically updated to reflect the committed changes. Closed by commit rGac67414618df: [clang-format] Fix the bug that joins template closer and or (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66332/new/

r369157 - [clang-format] Fix the bug that joins template closer and > or >>

Author: owenpan Date: Fri Aug 16 14:49:17 2019 New Revision: 369157 URL: http://llvm.org/viewvc/llvm-project?rev=369157=rev Log: [clang-format] Fix the bug that joins template closer and > or >> Also fixes a buggy test case. See PR42404 Differential Revision: https://reviews.llvm.org/D66332

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

owenpan added a comment. In D66332#1633448 , @Quuxplusone wrote: > Drive-by observation: My experiments with > https://zed0.co.uk/clang-format-configurator/ show that there is a similar > bug where clang-format accidentally produces `>=` via

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith added inline comments. Comment at: lib/Basic/Stack.cpp:53-54 + // If the stack pointer has a surprising value, we do not understand this + // stack usage scheme. (Perhaps the target allocates new stack regions on + // demand for us.) Don't try to guess what's going on.

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith updated this revision to Diff 215680. rsmith added a comment. - Disable stack exhaustion test if threads are disabled. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66361/new/ https://reviews.llvm.org/D66361 Files:

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith updated this revision to Diff 215678. rsmith marked 2 inline comments as done. rsmith added a comment. - Review feedback: use _AddressOfReturnAddress with MSVC, and simplify Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66361/new/

[PATCH] D65545: Handle some fs::remove failures

bruno accepted this revision. bruno added a comment. LGTM with one minor change. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:38 +#define DEBUG_TYPE "pch" + `pch-preamble` is more accurate here. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

bruno added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:110 +/// A reference to a \c FileEntry that includes the name of the file as it was +/// accessed by the FileManager's client. +class FileEntryRef { How does that work with the VFS?

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

arsenm added a comment. In D64931#1633669 , @akhuang wrote: > > Address space have backend defined semantics, and aren’t really reserved > > for front end use. I think the fact that non-0 address spaces on X86 > > codegen the same as address space 0 and

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rnk added inline comments. Comment at: include/clang/Basic/Stack.h:42 + llvm::function_ref Fn) { +if (LLVM_UNLIKELY(isStackNearlyExhausted())) { + runWithSufficientStackSpaceSlow(Diag, Fn); For

r369152 - [X86] Support -mlong-double-80

Author: troyj Date: Fri Aug 16 14:00:22 2019 New Revision: 369152 URL: http://llvm.org/viewvc/llvm-project?rev=369152=rev Log: [X86] Support -mlong-double-80 Add an option group for all of the -mlong-double-* options and make -mlong-double-80 restore the default long double behavior for X86.

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215666. mibintc marked an inline comment as not done. mibintc edited the summary of this revision. mibintc added a comment. I addressed some comments from @kpn: I corrected the documentation formatting and added some details, and used Diag instead of

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. > Address space have backend defined semantics, and aren’t really reserved for > front end use. I think the fact that non-0 address spaces on X86 codegen the > same as address space 0 and could be used for something by a front end is an > accident of how SelectionDAG

[PATCH] D65453: [analyzer] Improve the accuracy of the Clang call graph analysis

Szelethus added a comment. I hope you dont mind me changing the revision title -- many of us are subscribed to the "analyzer" tag and like learning about whats changing :) This is not an objection to the patch or anything of course, just adding some lurkers. CHANGES SINCE LAST ACTION

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

mgehre marked 4 inline comments as done. mgehre added a comment. I now start to wonder if we should instead put the attribute on all declarations (instead of just the canonical). Later redeclarations automatically inherit the attributes. This would make both the checking easier (just check any

r369149 - Revert "[ARM] push LR before __gnu_mcount_nc"

Author: jcai19 Date: Fri Aug 16 13:40:21 2019 New Revision: 369149 URL: http://llvm.org/viewvc/llvm-project?rev=369149=rev Log: Revert "[ARM] push LR before __gnu_mcount_nc" This reverts commit f4cf3b959333f62b7a7b2d7771f7010c9d8da388. Modified: cfe/trunk/lib/Basic/Targets/ARM.cpp

[PATCH] D66365: [clang-tidy] [readability-convert-member-functions-to-static] ignore functions that hide base class methods

mgehre created this revision. mgehre added reviewers: aaron.ballman, Eugene.Zelenko. Herald added a subscriber: xazax.hun. Herald added a project: clang. Fixes bug https://bugs.llvm.org/show_bug.cgi?id=43002 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66365 Files:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as not done. mibintc added a comment. I added an inline reply and unmarked some things that had been inadvertently marked done. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case

r369148 - [Test Commit] Fix typo in diagtool.rst

Author: troyj Date: Fri Aug 16 13:26:48 2019 New Revision: 369148 URL: http://llvm.org/viewvc/llvm-project?rev=369148=rev Log: [Test Commit] Fix typo in diagtool.rst Test commit after obtaining commit access. Modified: cfe/trunk/docs/CommandGuide/diagtool.rst Modified:

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 added a comment. The changes have been upstreamed to r369147. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! I'm happy to accept this as soon as other reviewers are happy. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1548 - state = checkNonNull(C, state,

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

This revision was automatically updated to reflect the committed changes. Closed by commit rL369147: [ARM] push LR before __gnu_mcount_nc (authored by jcai19, committed by ). Changed prior to commit: https://reviews.llvm.org/D65019?vs=214945=215664#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. Herald added a project: clang. We currently accept use of _Thread_local in all C and C++ modes, but we do not issue a warning about it being an extension when used outside of C11 mode. This patch adds the warning and

r369147 - [ARM] push LR before __gnu_mcount_nc

Author: jcai19 Date: Fri Aug 16 13:21:08 2019 New Revision: 369147 URL: http://llvm.org/viewvc/llvm-project?rev=369147=rev Log: [ARM] push LR before __gnu_mcount_nc Push LR register before calling __gnu_mcount_nc as it expects the value of LR register to be the top value of the stack on ARM32.

r369146 - [OPENMP5.0]Diagnose global variables in lambda not marked as declare

Author: abataev Date: Fri Aug 16 13:15:02 2019 New Revision: 369146 URL: http://llvm.org/viewvc/llvm-project?rev=369146=rev Log: [OPENMP5.0]Diagnose global variables in lambda not marked as declare target. According to OpenMP 5.0, if a lambda declaration and definition appears between a declare

[PATCH] D66360: Expose constructing a virtual method dispatch through the include/clang/CodeGen APIs.

pschuh created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In swift, we want to be able to call c++ virtual methods by looking up in the virtual table. There appears to exist no way currently, via the standard APIs, to take a CXXMethodDecl and a

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added a comment. > So it is possible to handle this completely in the backed, but the diagnostic > output is not fantastic when using clang based instrumentation. In > particular, we would need to emit the diagnostic in LowerExpectIntrisic.cpp > by checking if the branch weight

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith created this revision. rsmith added reviewers: rnk, aaron.ballman. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Clang performs various recursive operations (such as template instantiation), and may use non-trivial amounts of stack space in each recursive

r369145 - Stop abusing SuppressAllDiagnostics when speculatively determining

Author: rsmith Date: Fri Aug 16 12:53:22 2019 New Revision: 369145 URL: http://llvm.org/viewvc/llvm-project?rev=369145=rev Log: Stop abusing SuppressAllDiagnostics when speculatively determining whether an expression would be valid during error recovery. Modified:

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

This revision was automatically updated to reflect the committed changes. Closed by commit rL369139: [clang-doc] Redesign of generated HTML files (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r369139 - [clang-doc] Redesign of generated HTML files

Author: diegoastiazaran Date: Fri Aug 16 11:38:11 2019 New Revision: 369139 URL: http://llvm.org/viewvc/llvm-project?rev=369139=rev Log: [clang-doc] Redesign of generated HTML files The new design includes a header (contains the project name), a main section, and a footer. The main section is

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 215646. paulkirth added a comment. Remove reference to clang-misexpect from CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files:

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 ___ cfe-commits mailing list

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 215643. paulkirth edited the summary of this revision. paulkirth added a comment. Herald added subscribers: dexonsmith, steven_wu, mehdi_amini. Removes standalone clang-misexpect from revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

DiegoAstiazaran updated this revision to Diff 215642. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Add comments. Fix clang-doc version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 Files:

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

Quuxplusone added a comment. Drive-by observation: My experiments with https://zed0.co.uk/clang-format-configurator/ show that there is a similar bug where clang-format accidentally produces `>=` via reformatting of `template` `=0>`, `pi` `=3;`, and so on. Is it possible to fix that bug as

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66332/new/ https://reviews.llvm.org/D66332

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added a comment. In D64943#1633372 , @lebedev.ri wrote: > In D64943#1633357 , @vzakhari wrote: > > > In D64943#1633175 , @ABataev wrote: > > > > > In D64943#1633170

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

lebedev.ri added a comment. In D64943#1633357 , @vzakhari wrote: > In D64943#1633175 , @ABataev wrote: > > > In D64943#1633170 , @lebedev.ri > > wrote: > > > > > In

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added a comment. In D66324#1632653 , @lebedev.ri wrote: > This is marked as child revision of D65300 > but it seems like they both add > the same logic, just into different components, D65300 >

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added a comment. In D64943#1633175 , @ABataev wrote: > In D64943#1633170 , @lebedev.ri > wrote: > > > In D64943#1633164 , @ABataev wrote: > > > > > In

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:487-489 +static std::unique_ptr +genFileMainNode(StringRef InfoPath, +std::vector> , Would you be able to briefly comment on each of these `gen*Node`

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

DiegoAstiazaran updated this revision to Diff 215624. DiegoAstiazaran added a comment. Run clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D66298: [clang-doc] Fix records in global namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rL369123: [clang-doc] Fix records in global namespace (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aprantl requested changes to this revision. aprantl added inline comments. This revision now requires changes to proceed. Comment at: test/CodeGen/debug-info-no-location.cpp:4 +// CHECK-NEXT: ret void, !dbg !51 +// CHECK: !48 = distinct !DISubprogram(name: "`dynamic atexit

[clang-tools-extra] r369123 - [clang-doc] Fix records in global namespace

Author: diegoastiazaran Date: Fri Aug 16 09:10:32 2019 New Revision: 369123 URL: http://llvm.org/viewvc/llvm-project?rev=369123=rev Log: [clang-doc] Fix records in global namespace When a Record is declared in the global namespace, clang-doc serializes it as a child of the global namespace, so

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215615. SureYeaah added a comment. Fixed semicolon bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib added a comment. Thank you for the valuable comments and the review! I'm just planning to register to the bug tracker, because it is getting more relevant due to some other contributions as well. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:389 llvm::sort(References, [](const Reference , const Reference ) { - return std::tie(L.Loc, L.CanonicalTarget, L.Role) < - std::tie(R.Loc, R.CanonicalTarget, R.Role); +

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added a comment. In D64943#1633170 , @lebedev.ri wrote: > In D64943#1633164 , @ABataev wrote: > > > In D64943#1619958 , @sdmitriev > > wrote: > > > > > As I

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

lebedev.ri added a comment. In D64943#1633164 , @ABataev wrote: > In D64943#1619958 , @sdmitriev wrote: > > > As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ > > on Linux and ‘atexit’

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added a comment. In D64943#1619958 , @sdmitriev wrote: > As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ > on Linux and ‘atexit’ on Windows) whereas @llvm.global_ctors/dtors variables > offer similar and platform

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

lenary planned changes to this revision. lenary added a comment. Upon further thought, I realise that `MaxAtomicPromoteWidth` should be set to 128 regardless of whether a target `HasA`. I will be updating the patch with the new width and conditions early next week. Repository: rC Clang

[PATCH] D66350: Rudimentary support for Doxygen \retval command

sberg created this revision. sberg added a reviewer: gribozavr. sberg added a project: clang. Herald added a subscriber: cfe-commits. ...so that at least a preceding \param etc. that lacks a description gets a -Wdocumentation warning (instead of erroneously treating the \retval ... text as its

[PATCH] D66349: [clangd] Fix one testcase in XRefsTests.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The test didn't test anything actually -- it used "[]" as annotation which should be "[[]]". This patch also fixes a bug in XRef

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

Anastasia updated this revision to Diff 215598. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66294/new/ https://reviews.llvm.org/D66294 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === ---

[PATCH] D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc

martong added a comment. In D64078#1572675 , @a_sidorin wrote: > Hi Gabor, > it is a nice design question if source locations can participate in > structural match or not. The comparison tells us that the same code written > in different files is not

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Consider this code: void f() { auto L0 =

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 215592. xbolva00 added a comment. Fixed nits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

Anastasia added inline comments. Comment at: docs/ReleaseNotes.rst:173 + +- Added initial support for implicitly including OpenCL BIFs using + efficient trie lookup generated by TableGen. A corresponding svenvh wrote: > mantognini wrote: > > If the BIF acronym

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

Anastasia updated this revision to Diff 215591. Anastasia marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66294/new/ https://reviews.llvm.org/D66294 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

  1   2   >